[GitHub] [incubator-pinot] mayankshriv opened a new issue #4614: Tuning required for dropping queries on server-side after async-broker change

2019-09-16 Thread GitBox
mayankshriv opened a new issue #4614: Tuning required for dropping queries on server-side after async-broker change URL: https://github.com/apache/incubator-pinot/issues/4614 With async-broker, it is observed that the broker keeps piling queries on the server side asynchronously even if

[GitHub] [incubator-pinot] Jackie-Jiang commented on issue #4614: Tuning required for dropping queries on server-side after async-broker change

2019-09-16 Thread GitBox
Jackie-Jiang commented on issue #4614: Tuning required for dropping queries on server-side after async-broker change URL: https://github.com/apache/incubator-pinot/issues/4614#issuecomment-531875761 We already have the feature of dropping queries if it already missed the timeout. We

[GitHub] [incubator-pinot] npawar commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support

2019-09-16 Thread GitBox
npawar commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support URL: https://github.com/apache/incubator-pinot/pull/4602#discussion_r324775779 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/table/ConcurrentIndexedTable.java

[GitHub] [incubator-pinot] npawar commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support

2019-09-16 Thread GitBox
npawar commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support URL: https://github.com/apache/incubator-pinot/pull/4602#discussion_r324769987 ## File path:

[GitHub] [incubator-pinot] npawar commented on issue #4602: First pass of GROUP BY with ORDER BY support

2019-09-16 Thread GitBox
npawar commented on issue #4602: First pass of GROUP BY with ORDER BY support URL: https://github.com/apache/incubator-pinot/pull/4602#issuecomment-531953246 > Looks good overall. Few places where we can optimize further but let us do a benchmark before optimizing further. > > I am

[incubator-pinot] branch master updated (45205e8 -> fe29287)

2019-09-16 Thread jihao
This is an automated email from the ASF dual-hosted git repository. jihao pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 45205e8 [TE] frontend - harleyjj/alert-details - handle reported anomaly for anomaly table (#4587)

[GitHub] [incubator-pinot] jihaozh merged pull request #4580: [TE] frontend - harleyjj/auth - handle expired token and 401 errors p…

2019-09-16 Thread GitBox
jihaozh merged pull request #4580: [TE] frontend - harleyjj/auth - handle expired token and 401 errors p… URL: https://github.com/apache/incubator-pinot/pull/4580 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-pinot] jihaozh merged pull request #4600: [TE] frontend - harleyjj/ai - fix small bug in AI Availability

2019-09-16 Thread GitBox
jihaozh merged pull request #4600: [TE] frontend - harleyjj/ai - fix small bug in AI Availability URL: https://github.com/apache/incubator-pinot/pull/4600 This is an automated message from the Apache Git Service. To respond

[incubator-pinot] branch master updated (fe29287 -> 76fcc86)

2019-09-16 Thread jihao
This is an automated email from the ASF dual-hosted git repository. jihao pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from fe29287 [TE] frontend - harleyjj/auth - handle expired token and 401 errors plus redirect after login

[GitHub] [incubator-pinot] codecov-io commented on issue #4615: Update Getting Started documentation.

2019-09-16 Thread GitBox
codecov-io commented on issue #4615: Update Getting Started documentation. URL: https://github.com/apache/incubator-pinot/pull/4615#issuecomment-531921434 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4615?src=pr=h1) Report > Merging

[incubator-pinot] branch master updated (fe7fff6 -> 8f9bb5d)

2019-09-16 Thread jihao
This is an automated email from the ASF dual-hosted git repository. jihao pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from fe7fff6 [TE] Add anomaly type for merged anomaly result (#4605) add 8f9bb5d [TE] Remove the logic of

[GitHub] [incubator-pinot] jihaozh merged pull request #4611: [TE] Remove the logic of reading stderr from phantomjs to avoid zombie processes

2019-09-16 Thread GitBox
jihaozh merged pull request #4611: [TE] Remove the logic of reading stderr from phantomjs to avoid zombie processes URL: https://github.com/apache/incubator-pinot/pull/4611 This is an automated message from the Apache Git

[GitHub] [incubator-pinot] jihaozh merged pull request #4587: [TE] frontend - harleyjj/alert-details - handle reported anomaly for …

2019-09-16 Thread GitBox
jihaozh merged pull request #4587: [TE] frontend - harleyjj/alert-details - handle reported anomaly for … URL: https://github.com/apache/incubator-pinot/pull/4587 This is an automated message from the Apache Git Service. To

[incubator-pinot] branch master updated (8f9bb5d -> 45205e8)

2019-09-16 Thread jihao
This is an automated email from the ASF dual-hosted git repository. jihao pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 8f9bb5d [TE] Remove the logic of reading stderr from phantomjs to avoid zombie processes (#4611) add

[GitHub] [incubator-pinot] dbadapon opened a new pull request #4615: Update Getting Started documentation.

2019-09-16 Thread GitBox
dbadapon opened a new pull request #4615: Update Getting Started documentation. URL: https://github.com/apache/incubator-pinot/pull/4615 Updated Getting Started documentation to include a CSV config file and a specific CSV file. Also updated minor grammar issues and version number.

[incubator-pinot] branch master updated: [TE] consider anomaly type during merge (#4613)

2019-09-16 Thread jihao
This is an automated email from the ASF dual-hosted git repository. jihao pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 09207f9 [TE] consider anomaly type

[GitHub] [incubator-pinot] jihaozh merged pull request #4613: [TE] consider anomaly type during merge

2019-09-16 Thread GitBox
jihaozh merged pull request #4613: [TE] consider anomaly type during merge URL: https://github.com/apache/incubator-pinot/pull/4613 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-pinot] npawar commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support

2019-09-16 Thread GitBox
npawar commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support URL: https://github.com/apache/incubator-pinot/pull/4602#discussion_r324878618 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/CombineGroupByOrderByOperator.java

[GitHub] [incubator-pinot] npawar commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support

2019-09-16 Thread GitBox
npawar commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support URL: https://github.com/apache/incubator-pinot/pull/4602#discussion_r324877847 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/table/ConcurrentIndexedTable.java

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support

2019-09-16 Thread GitBox
kishoreg commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support URL: https://github.com/apache/incubator-pinot/pull/4602#discussion_r324935988 ## File path:

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support

2019-09-16 Thread GitBox
kishoreg commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support URL: https://github.com/apache/incubator-pinot/pull/4602#discussion_r324935815 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/table/ConcurrentIndexedTable.java

[GitHub] [incubator-pinot] fx19880617 opened a new pull request #4617: Adding CreateSegmentCommandV2 command

2019-09-16 Thread GitBox
fx19880617 opened a new pull request #4617: Adding CreateSegmentCommandV2 command URL: https://github.com/apache/incubator-pinot/pull/4617 Sample usage: ``` pinot-admin.sh CreateSegmentV2 \ -dataDir /tmp/pinot/segmentv2/data \ -outDir /tmp/pinot/segmentv2/out \ -schemaFile

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4535: Implement DISTINCT clause

2019-09-16 Thread GitBox
Jackie-Jiang commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r324929930 ## File path: pinot-common/src/main/java/org/apache/pinot/pql/parsers/pql2/ast/OutputColumnListAstNode.java

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4535: Implement DISTINCT clause

2019-09-16 Thread GitBox
Jackie-Jiang commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r324932815 ## File path:

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4535: Implement DISTINCT clause

2019-09-16 Thread GitBox
Jackie-Jiang commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r324931933 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/DefaultAggregationExecutor.java

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4535: Implement DISTINCT clause

2019-09-16 Thread GitBox
Jackie-Jiang commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r324929120 ## File path: pinot-common/src/main/java/org/apache/pinot/pql/parsers/pql2/ast/FunctionCallAstNode.java ##

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4535: Implement DISTINCT clause

2019-09-16 Thread GitBox
Jackie-Jiang commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r324932329 ## File path:

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4535: Implement DISTINCT clause

2019-09-16 Thread GitBox
Jackie-Jiang commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r324932138 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/DistinctTable.java ## @@ -0,0

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4535: Implement DISTINCT clause

2019-09-16 Thread GitBox
Jackie-Jiang commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r324928495 ## File path: pinot-common/src/main/java/org/apache/pinot/pql/parsers/pql2/ast/FunctionCallAstNode.java ##

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4535: Implement DISTINCT clause

2019-09-16 Thread GitBox
Jackie-Jiang commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r324929054 ## File path: pinot-common/src/main/java/org/apache/pinot/pql/parsers/PinotQuery2BrokerRequestConverter.java

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4535: Implement DISTINCT clause

2019-09-16 Thread GitBox
Jackie-Jiang commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r324928736 ## File path: pinot-common/src/main/java/org/apache/pinot/pql/parsers/PinotQuery2BrokerRequestConverter.java

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4535: Implement DISTINCT clause

2019-09-16 Thread GitBox
Jackie-Jiang commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r324926810 ## File path: pinot-common/src/main/java/org/apache/pinot/pql/parsers/PinotQuery2BrokerRequestConverter.java

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4535: Implement DISTINCT clause

2019-09-16 Thread GitBox
Jackie-Jiang commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r324926552 ## File path: pinot-common/src/main/java/org/apache/pinot/pql/parsers/PinotQuery2BrokerRequestConverter.java

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4535: Implement DISTINCT clause

2019-09-16 Thread GitBox
Jackie-Jiang commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r324930760 ## File path: pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java ## @@ -174,13

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4535: Implement DISTINCT clause

2019-09-16 Thread GitBox
Jackie-Jiang commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r324933169 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/reduce/BrokerReduceService.java ## @@

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4535: Implement DISTINCT clause

2019-09-16 Thread GitBox
Jackie-Jiang commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r324929754 ## File path: pinot-common/src/main/java/org/apache/pinot/pql/parsers/pql2/ast/OutputColumnListAstNode.java

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4535: Implement DISTINCT clause

2019-09-16 Thread GitBox
Jackie-Jiang commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r324929193 ## File path: pinot-common/src/main/java/org/apache/pinot/pql/parsers/pql2/ast/FunctionCallAstNode.java ##

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4535: Implement DISTINCT clause

2019-09-16 Thread GitBox
Jackie-Jiang commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r324926410 ## File path: pinot-common/src/main/java/org/apache/pinot/pql/parsers/PinotQuery2BrokerRequestConverter.java

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4535: Implement DISTINCT clause

2019-09-16 Thread GitBox
Jackie-Jiang commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r324931411 ## File path: pinot-core/src/main/java/org/apache/pinot/core/common/ObjectSerDeUtils.java ## @@ -277,6

[GitHub] [incubator-pinot] codecov-io commented on issue #4617: Adding CreateSegmentCommandV2 command

2019-09-16 Thread GitBox
codecov-io commented on issue #4617: Adding CreateSegmentCommandV2 command URL: https://github.com/apache/incubator-pinot/pull/4617#issuecomment-532039551 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4617?src=pr=h1) Report > Merging

[incubator-pinot] branch master updated (09207f9 -> 8d593f3)

2019-09-16 Thread akshayrai09
This is an automated email from the ASF dual-hosted git repository. akshayrai09 pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 09207f9 [TE] consider anomaly type during merge (#4613) add 8d593f3 [TE] Bug fix to initialize

[GitHub] [incubator-pinot] akshayrai merged pull request #4616: [TE] Bug fix to initialize the configDAO

2019-09-16 Thread GitBox
akshayrai merged pull request #4616: [TE] Bug fix to initialize the configDAO URL: https://github.com/apache/incubator-pinot/pull/4616 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-pinot] akshayrai opened a new pull request #4616: [TE] Bug fix to initialize the configDAO

2019-09-16 Thread GitBox
akshayrai opened a new pull request #4616: [TE] Bug fix to initialize the configDAO URL: https://github.com/apache/incubator-pinot/pull/4616 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-pinot] snleee commented on a change in pull request #4615: Update Getting Started documentation.

2019-09-16 Thread GitBox
snleee commented on a change in pull request #4615: Update Getting Started documentation. URL: https://github.com/apache/incubator-pinot/pull/4615#discussion_r324933167 ## File path: docs/getting_started.rst ## @@ -154,11 +172,11 @@ To upload the schema, we can use the

[GitHub] [incubator-pinot] snleee commented on a change in pull request #4615: Update Getting Started documentation.

2019-09-16 Thread GitBox
snleee commented on a change in pull request #4615: Update Getting Started documentation. URL: https://github.com/apache/incubator-pinot/pull/4615#discussion_r324944420 ## File path: docs/getting_started.rst ## @@ -154,11 +172,11 @@ To upload the schema, we can use the

[GitHub] [incubator-pinot] snleee commented on a change in pull request #4615: Update Getting Started documentation.

2019-09-16 Thread GitBox
snleee commented on a change in pull request #4615: Update Getting Started documentation. URL: https://github.com/apache/incubator-pinot/pull/4615#discussion_r324944105 ## File path: docs/getting_started.rst ## @@ -208,45 +226,45 @@ In order to upload our data to Pinot

[incubator-pinot] 01/01: Adding CreateSegmentCommandV2 command

2019-09-16 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch new_segment_creation in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit 2930748924b88abbf2564a6884d073fc1aa6e50b Author: Xiang Fu AuthorDate: Tue Sep 17 09:48:49 2019

[incubator-pinot] branch new_segment_creation created (now 2930748)

2019-09-16 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch new_segment_creation in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at 2930748 Adding CreateSegmentCommandV2 command This branch includes the following new

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4553: Refactor ControllerLeaderLocator

2019-09-16 Thread GitBox
mcvsubbu commented on a change in pull request #4553: Refactor ControllerLeaderLocator URL: https://github.com/apache/incubator-pinot/pull/4553#discussion_r324931668 ## File path: pinot-core/src/test/java/org/apache/pinot/server/realtime/ControllerLeaderLocatorTest.java

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4553: Refactor ControllerLeaderLocator

2019-09-16 Thread GitBox
mcvsubbu commented on a change in pull request #4553: Refactor ControllerLeaderLocator URL: https://github.com/apache/incubator-pinot/pull/4553#discussion_r324931161 ## File path: pinot-core/src/main/java/org/apache/pinot/server/realtime/ControllerLeaderLocator.java ##

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4553: Refactor ControllerLeaderLocator

2019-09-16 Thread GitBox
mcvsubbu commented on a change in pull request #4553: Refactor ControllerLeaderLocator URL: https://github.com/apache/incubator-pinot/pull/4553#discussion_r324930274 ## File path: pinot-core/src/main/java/org/apache/pinot/server/realtime/ControllerLeaderLocator.java ##

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4567: Add integration test for ControllerLeaderLocator

2019-09-16 Thread GitBox
mcvsubbu commented on a change in pull request #4567: Add integration test for ControllerLeaderLocator URL: https://github.com/apache/incubator-pinot/pull/4567#discussion_r324932592 ## File path:

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4567: Add integration test for ControllerLeaderLocator

2019-09-16 Thread GitBox
mcvsubbu commented on a change in pull request #4567: Add integration test for ControllerLeaderLocator URL: https://github.com/apache/incubator-pinot/pull/4567#discussion_r324931922 ## File path:

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4567: Add integration test for ControllerLeaderLocator

2019-09-16 Thread GitBox
mcvsubbu commented on a change in pull request #4567: Add integration test for ControllerLeaderLocator URL: https://github.com/apache/incubator-pinot/pull/4567#discussion_r324932788 ## File path:

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4567: Add integration test for ControllerLeaderLocator

2019-09-16 Thread GitBox
mcvsubbu commented on a change in pull request #4567: Add integration test for ControllerLeaderLocator URL: https://github.com/apache/incubator-pinot/pull/4567#discussion_r324932156 ## File path:

[incubator-pinot] branch jsonpath_function updated (f5c17ef -> 0f94d9f)

2019-09-16 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch jsonpath_function in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard f5c17ef Adding more tests add 0f94d9f Adding more tests This update added new revisions

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4597: [WIP] Adding json_path function to extract field from json object

2019-09-16 Thread GitBox
codecov-io edited a comment on issue #4597: [WIP] Adding json_path function to extract field from json object URL: https://github.com/apache/incubator-pinot/pull/4597#issuecomment-529669548 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4597?src=pr=h1) Report > Merging