[GitHub] [incubator-pinot] konradmalik opened a new pull request #5178: Fix docker compose & quick start

konradmalik opened a new pull request #5178: Fix docker compose & quick start URL: https://github.com/apache/incubator-pinot/pull/5178 Quick start for docker does not currently work. 1. default network created by compose starts with the name of the parent dir. So it is "pinot_default", n

[GitHub] [incubator-pinot] codecov-io commented on issue #5178: Fix docker compose & quick start

codecov-io commented on issue #5178: Fix docker compose & quick start URL: https://github.com/apache/incubator-pinot/pull/5178#issuecomment-603134174 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5178?src=pr&el=h1) Report > Merging [#5178](https://codecov.io/gh/apache/i

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #5176: Make text index query cache a configurable option

jackjlli commented on a change in pull request #5176: Make text index query cache a configurable option URL: https://github.com/apache/incubator-pinot/pull/5176#discussion_r397352577 ## File path: pinot-core/src/test/java/org/apache/pinot/queries/TestTextSearchQueries.java ###

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #5176: Make text index query cache a configurable option

jackjlli commented on a change in pull request #5176: Make text index query cache a configurable option URL: https://github.com/apache/incubator-pinot/pull/5176#discussion_r397351839 ## File path: pinot-common/src/main/java/org/apache/pinot/common/config/FieldConfig.java #

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #5176: Make text index query cache a configurable option

jackjlli commented on a change in pull request #5176: Make text index query cache a configurable option URL: https://github.com/apache/incubator-pinot/pull/5176#discussion_r397351148 ## File path: pinot-core/src/main/java/org/apache/pinot/core/segment/index/readers/text/LuceneTextI

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5175: add pinot upsert features to pinot common

Jackie-Jiang commented on a change in pull request #5175: add pinot upsert features to pinot common URL: https://github.com/apache/incubator-pinot/pull/5175#discussion_r397361994 ## File path: pinot-common/src/main/java/org/apache/pinot/common/metrics/AbstractMetrics.java

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5175: add pinot upsert features to pinot common

Jackie-Jiang commented on a change in pull request #5175: add pinot upsert features to pinot common URL: https://github.com/apache/incubator-pinot/pull/5175#discussion_r397355590 ## File path: pinot-common/src/main/java/org/apache/pinot/common/config/TableConfig.java ## @

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5175: add pinot upsert features to pinot common

Jackie-Jiang commented on a change in pull request #5175: add pinot upsert features to pinot common URL: https://github.com/apache/incubator-pinot/pull/5175#discussion_r397360233 ## File path: pinot-common/src/main/java/org/apache/pinot/common/config/TableConfig.java ## @

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5175: add pinot upsert features to pinot common

Jackie-Jiang commented on a change in pull request #5175: add pinot upsert features to pinot common URL: https://github.com/apache/incubator-pinot/pull/5175#discussion_r397361692 ## File path: pinot-common/src/main/java/org/apache/pinot/common/config/TableNameBuilder.java

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5175: add pinot upsert features to pinot common

Jackie-Jiang commented on a change in pull request #5175: add pinot upsert features to pinot common URL: https://github.com/apache/incubator-pinot/pull/5175#discussion_r397358004 ## File path: pinot-common/src/main/java/org/apache/pinot/common/config/TableConfig.java ## @

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5177: Lucene DocId to PinotDocId cache

Jackie-Jiang commented on a change in pull request #5177: Lucene DocId to PinotDocId cache URL: https://github.com/apache/incubator-pinot/pull/5177#discussion_r397376549 ## File path: pinot-core/src/main/java/org/apache/pinot/core/segment/index/readers/text/LuceneTextIndexReader.ja

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5176: Make text index query cache a configurable option

Jackie-Jiang commented on a change in pull request #5176: Make text index query cache a configurable option URL: https://github.com/apache/incubator-pinot/pull/5176#discussion_r397383948 ## File path: pinot-core/src/main/java/org/apache/pinot/core/segment/index/loader/IndexLoadingC

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5176: Make text index query cache a configurable option

Jackie-Jiang commented on a change in pull request #5176: Make text index query cache a configurable option URL: https://github.com/apache/incubator-pinot/pull/5176#discussion_r397380997 ## File path: pinot-common/src/main/java/org/apache/pinot/common/config/FieldConfig.java #

[GitHub] [incubator-pinot] mcvsubbu opened a new issue #5180: Test for early termination of selection queries is flaky

mcvsubbu opened a new issue #5180: Test for early termination of selection queries is flaky URL: https://github.com/apache/incubator-pinot/issues/5180 The test added as a part of PR #5163 (@fx19880617 ) is flaky and fails often, breaking our internal continuous integration jobs. T

[GitHub] [incubator-pinot] Jackie-Jiang merged pull request #5179: Fix the numEntriesScannedPostFilter field test in SelectionOnlyEarlyTerminationTest

Jackie-Jiang merged pull request #5179: Fix the numEntriesScannedPostFilter field test in SelectionOnlyEarlyTerminationTest URL: https://github.com/apache/incubator-pinot/pull/5179 This is an automated message from the Apach

[GitHub] [incubator-pinot] Jackie-Jiang commented on issue #5179: Fix the numEntriesScannedPostFilter field test in SelectionOnlyEarlyTerminationTest

Jackie-Jiang commented on issue #5179: Fix the numEntriesScannedPostFilter field test in SelectionOnlyEarlyTerminationTest URL: https://github.com/apache/incubator-pinot/pull/5179#issuecomment-603461262 @mcvsubbu `numSegmentsProcessed` should be all segments that passed the segment pruning

[incubator-pinot] branch master updated (b8ed426 -> 28f2643)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from b8ed426 Add EarlyTerminationException to prevent logging too many invalid error messages (#5174) add

[GitHub] [incubator-pinot] snleee commented on issue #5166: Nightly deploy Pinot to jfrog bintray

snleee commented on issue #5166: Nightly deploy Pinot to jfrog bintray URL: https://github.com/apache/incubator-pinot/pull/5166#issuecomment-603482547 @jackjlli Is this compatible with our existing apache build pipeline? Can you check if the following would give you the correct jar f

[incubator-pinot] 01/01: Deploy pinot to bintray

This is an automated email from the ASF dual-hosted git repository. jlli pushed a commit to branch pinot-jfrog-bintray in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit 0135d800eba1b508142c0dd333424494a5bba1c0 Author: jackjlli AuthorDate: Tue Mar 24 15:26:10 2020 -0700

[incubator-pinot] branch pinot-jfrog-bintray created (now 0135d80)

This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch pinot-jfrog-bintray in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at 0135d80 Deploy pinot to bintray This branch includes the following new commits: new 0135d

[GitHub] [incubator-pinot] jackjlli opened a new pull request #5181: Nightly deploy pinot to bintray

jackjlli opened a new pull request #5181: Nightly deploy pinot to bintray URL: https://github.com/apache/incubator-pinot/pull/5181 This PR adds code to nightly deploy pinot to bintray. This is an automated message from the Apa

[incubator-pinot] branch master updated (28f2643 -> 4a6b21d)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 28f2643 Fix the numEntriesScannedPostFilter field test in SelectionOnlyEarlyTerminationTest (#5179)

[GitHub] [incubator-pinot] fx19880617 merged pull request #5178: Fix docker compose & quick start

fx19880617 merged pull request #5178: Fix docker compose & quick start URL: https://github.com/apache/incubator-pinot/pull/5178 This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [incubator-pinot] fx19880617 commented on issue #5178: Fix docker compose & quick start

fx19880617 commented on issue #5178: Fix docker compose & quick start URL: https://github.com/apache/incubator-pinot/pull/5178#issuecomment-603562231 Thanks for fixing this! This is an automated message from the Apache Git Ser

[incubator-pinot] branch pinot-jfrog-bintray updated (0135d80 -> 2cc232e)

This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch pinot-jfrog-bintray in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 0135d80 Deploy pinot to bintray add 2cc232e Deploy pinot to bintray This update added new

[GitHub] [incubator-pinot] jamesyfshao commented on a change in pull request #5175: add pinot upsert features to pinot common

jamesyfshao commented on a change in pull request #5175: add pinot upsert features to pinot common URL: https://github.com/apache/incubator-pinot/pull/5175#discussion_r397563786 ## File path: pinot-common/src/main/java/org/apache/pinot/common/config/TableConfig.java ## @@

[GitHub] [incubator-pinot] jamesyfshao commented on a change in pull request #5175: add pinot upsert features to pinot common

jamesyfshao commented on a change in pull request #5175: add pinot upsert features to pinot common URL: https://github.com/apache/incubator-pinot/pull/5175#discussion_r397564517 ## File path: pinot-common/src/main/java/org/apache/pinot/common/metrics/BrokerGauge.java ## @

[GitHub] [incubator-pinot] jamesyfshao commented on a change in pull request #5175: add pinot upsert features to pinot common

jamesyfshao commented on a change in pull request #5175: add pinot upsert features to pinot common URL: https://github.com/apache/incubator-pinot/pull/5175#discussion_r397564813 ## File path: pinot-spi/src/main/java/org/apache/pinot/spi/data/Schema.java ## @@ -59,13 +65,28

[GitHub] [incubator-pinot] jamesyfshao commented on a change in pull request #5175: add pinot upsert features to pinot common

jamesyfshao commented on a change in pull request #5175: add pinot upsert features to pinot common URL: https://github.com/apache/incubator-pinot/pull/5175#discussion_r397567501 ## File path: pinot-spi/src/main/java/org/apache/pinot/spi/data/Schema.java ## @@ -59,13 +65,28

[incubator-pinot] branch pinot-jfrog-bintray updated (2cc232e -> 6c672ce)

This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch pinot-jfrog-bintray in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 2cc232e Deploy pinot to bintray add 6c672ce Deploy pinot to bintray This update added new

[GitHub] [incubator-pinot] jamesyfshao commented on a change in pull request #5175: add pinot upsert features to pinot common

jamesyfshao commented on a change in pull request #5175: add pinot upsert features to pinot common URL: https://github.com/apache/incubator-pinot/pull/5175#discussion_r397571798 ## File path: pinot-spi/src/main/java/org/apache/pinot/spi/data/Schema.java ## @@ -631,4 +751,5

[incubator-pinot] branch pinot-jfrog-bintray updated (6c672ce -> 3c56219)

This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch pinot-jfrog-bintray in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 6c672ce Deploy pinot to bintray add 3c56219 Fix the build No new revisions were added by

[GitHub] [incubator-pinot] jamesyfshao commented on a change in pull request #5175: add pinot upsert features to pinot common

jamesyfshao commented on a change in pull request #5175: add pinot upsert features to pinot common URL: https://github.com/apache/incubator-pinot/pull/5175#discussion_r397573029 ## File path: pom.xml ## @@ -132,6 +132,9 @@ 2.11.2 4.1.42.Final + Review co

[GitHub] [incubator-pinot] jamesyfshao commented on a change in pull request #5175: add pinot upsert features to pinot common

jamesyfshao commented on a change in pull request #5175: add pinot upsert features to pinot common URL: https://github.com/apache/incubator-pinot/pull/5175#discussion_r397573029 ## File path: pom.xml ## @@ -132,6 +132,9 @@ 2.11.2 4.1.42.Final + Review co

[GitHub] [incubator-pinot] jamesyfshao commented on issue #5175: add pinot upsert features to pinot common

jamesyfshao commented on issue #5175: add pinot upsert features to pinot common URL: https://github.com/apache/incubator-pinot/pull/5175#issuecomment-603604130 > Can you please link the design doc in the pr description so that it is easier to understand the concept of upsert? > Since thi

[GitHub] [incubator-pinot] jackjlli commented on issue #5166: Nightly deploy Pinot to jfrog bintray

jackjlli commented on issue #5166: Nightly deploy Pinot to jfrog bintray URL: https://github.com/apache/incubator-pinot/pull/5166#issuecomment-603604945 > @jackjlli Is this compatible with our existing apache build pipeline? Yes, it's compatible with our existing build pipline.

[GitHub] [incubator-pinot] jamesyfshao commented on a change in pull request #5175: add pinot upsert features to pinot common

jamesyfshao commented on a change in pull request #5175: add pinot upsert features to pinot common URL: https://github.com/apache/incubator-pinot/pull/5175#discussion_r397575889 ## File path: pinot-common/src/main/java/org/apache/pinot/common/metrics/AbstractMetrics.java #

[GitHub] [incubator-pinot] jamesyfshao commented on a change in pull request #5175: add pinot upsert features to pinot common

jamesyfshao commented on a change in pull request #5175: add pinot upsert features to pinot common URL: https://github.com/apache/incubator-pinot/pull/5175#discussion_r397577434 ## File path: pinot-common/src/main/java/org/apache/pinot/common/config/TableConfig.java ## @@

[incubator-pinot] branch upsert-pr-land updated (723f08a -> 5c31201)

This is an automated email from the ASF dual-hosted git repository. jamesshao pushed a change to branch upsert-pr-land in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 723f08a update pinot upsert features to pinot common add 5c31201 frst update per cr No ne

[GitHub] [incubator-pinot] jamesyfshao commented on a change in pull request #5175: add pinot upsert features to pinot common

jamesyfshao commented on a change in pull request #5175: add pinot upsert features to pinot common URL: https://github.com/apache/incubator-pinot/pull/5175#discussion_r397577584 ## File path: pinot-common/src/main/java/org/apache/pinot/common/config/TableConfig.java ## @@

[GitHub] [incubator-pinot] snleee commented on issue #5166: Nightly deploy Pinot to jfrog bintray

snleee commented on issue #5166: Nightly deploy Pinot to jfrog bintray URL: https://github.com/apache/incubator-pinot/pull/5166#issuecomment-603610980 @Jackie-Jiang oh yeah, it needs some set up to run that cmd. Anyway, I think that it's fine as long as it's backward compatible. --

[GitHub] [incubator-pinot] snleee edited a comment on issue #5166: Nightly deploy Pinot to jfrog bintray

snleee edited a comment on issue #5166: Nightly deploy Pinot to jfrog bintray URL: https://github.com/apache/incubator-pinot/pull/5166#issuecomment-603610980 @Jackie-Jiang oh yeah, it needs some set up to run that cmd. Anyway, I think that it's fine as long as it's backward compatible. Pls

[incubator-pinot] branch pinot-jfrog-bintray updated (3c56219 -> e6eff7c)

This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch pinot-jfrog-bintray in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 3c56219 Fix the build add e6eff7c Testing No new revisions were added by this update. Su

[GitHub] [incubator-pinot] fx19880617 opened a new pull request #5182: Update readme link to gitbook for kafka plugins

fx19880617 opened a new pull request #5182: Update readme link to gitbook for kafka plugins URL: https://github.com/apache/incubator-pinot/pull/5182 Updated readme doc link to gitbook for kafka plugins This is an automated me

[GitHub] [incubator-pinot] kishoreg opened a new issue #5183: Fix license

kishoreg opened a new issue #5183: Fix license URL: https://github.com/apache/incubator-pinot/issues/5183 via Justin on the Pinot release thread > license need a little work. Please fix before the next release. > I checked: > - incubating in name > - signatures and hashes a

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #5175: add pinot upsert features to pinot common

kishoreg commented on a change in pull request #5175: add pinot upsert features to pinot common URL: https://github.com/apache/incubator-pinot/pull/5175#discussion_r397633097 ## File path: pinot-spi/src/main/java/org/apache/pinot/spi/data/Schema.java ## @@ -59,13 +65,28 @@

[GitHub] [incubator-pinot] kishoreg commented on issue #5175: add pinot upsert features to pinot common

kishoreg commented on issue #5175: add pinot upsert features to pinot common URL: https://github.com/apache/incubator-pinot/pull/5175#issuecomment-603667466 One concern here would be that the update related configuration appears in multiple places. One thing that can simplify this PR is to