[GitHub] [incubator-pinot] icefury71 opened a new pull request #6017: Table indexing config validation

2020-09-14 Thread GitBox
icefury71 opened a new pull request #6017: URL: https://github.com/apache/incubator-pinot/pull/6017 Related to #5942 ## Description This is to ensure any column name mentioned in the table indexing config is valid (i.e. it exists in the corresponding schema). Also checking for

[GitHub] [incubator-pinot] lgo opened a new issue #6018: APIs (like /instances) are inconsistently structured

2020-09-14 Thread GitBox
lgo opened a new issue #6018: URL: https://github.com/apache/incubator-pinot/issues/6018 Many APIs do not have consistent or easy to use resource structures. For example, `GET /instances/{instanceName}` may return data like ``` { "instanceName": "Broker_mybrokerhostname_8099",

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6012: Configurable segment generation job parallelism for Hadoop and Spark

2020-09-14 Thread GitBox
Jackie-Jiang commented on a change in pull request #6012: URL: https://github.com/apache/incubator-pinot/pull/6012#discussion_r488393909 ## File path:

[GitHub] [incubator-pinot] harleyjj opened a new pull request #6016: [TE] frontend - harleyjj/error-msgs - focus on errors in preview and …

2020-09-14 Thread GitBox
harleyjj opened a new pull request #6016: URL: https://github.com/apache/incubator-pinot/pull/6016 …detection validation This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6012: Configurable segment generation job parallelism for Hadoop and Spark

2020-09-14 Thread GitBox
Jackie-Jiang commented on a change in pull request #6012: URL: https://github.com/apache/incubator-pinot/pull/6012#discussion_r488393909 ## File path:

[GitHub] [incubator-pinot] fx19880617 commented on issue #5977: Allow ServiceManager to install tables prior to listening on service ports or a healthy status

2020-09-14 Thread GitBox
fx19880617 commented on issue #5977: URL: https://github.com/apache/incubator-pinot/issues/5977#issuecomment-691872386 One thing I can think of is to implement a tableBootstrapService, which implements: `org.apache.pinot.common.utils.ServiceStatusCallback`. Then you can enable it in

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #6009: Adjust schema validation logic in AvroIngestionSchemaValidator

2020-09-14 Thread GitBox
mcvsubbu commented on a change in pull request #6009: URL: https://github.com/apache/incubator-pinot/pull/6009#discussion_r488078457 ## File path: pinot-plugins/pinot-input-format/pinot-avro-base/src/main/java/org/apache/pinot/plugin/inputformat/avro/AvroIngestionSchemaValidator.java

[GitHub] [incubator-pinot] kishoreg merged pull request #5718: Feature/#5390 segment indexing reload status api

2020-09-14 Thread GitBox
kishoreg merged pull request #5718: URL: https://github.com/apache/incubator-pinot/pull/5718 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[incubator-pinot] branch master updated: Feature/#5390 segment indexing reload status api (#5718)

2020-09-14 Thread kishoreg
This is an automated email from the ASF dual-hosted git repository. kishoreg pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new dc77271 Feature/#5390 segment

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6009: Adjust schema validation logic in AvroIngestionSchemaValidator

2020-09-14 Thread GitBox
mayankshriv commented on a change in pull request #6009: URL: https://github.com/apache/incubator-pinot/pull/6009#discussion_r488129792 ## File path:

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #6009: Adjust schema validation logic in AvroIngestionSchemaValidator

2020-09-14 Thread GitBox
jackjlli commented on a change in pull request #6009: URL: https://github.com/apache/incubator-pinot/pull/6009#discussion_r488185083 ## File path: pinot-plugins/pinot-input-format/pinot-avro-base/src/main/java/org/apache/pinot/plugin/inputformat/avro/AvroIngestionSchemaValidator.java

[GitHub] [incubator-pinot] suvodeep-pyne opened a new pull request #6014: [TE] Added thirdeye-coordinator and thirdeye-dist modules

2020-09-14 Thread GitBox
suvodeep-pyne opened a new pull request #6014: URL: https://github.com/apache/incubator-pinot/pull/6014 [TE] Added thirdeye-coordinator and thirdeye-dist modules These are initial stubs created with a larger goal to modularize the codebase. - thirdeye-coordinator: This module is

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #6009: Adjust schema validation logic in AvroIngestionSchemaValidator

2020-09-14 Thread GitBox
jackjlli commented on a change in pull request #6009: URL: https://github.com/apache/incubator-pinot/pull/6009#discussion_r488141168 ## File path: pinot-plugins/pinot-input-format/pinot-avro-base/src/main/java/org/apache/pinot/plugin/inputformat/avro/AvroIngestionSchemaValidator.java

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #6009: Adjust schema validation logic in AvroIngestionSchemaValidator

2020-09-14 Thread GitBox
jackjlli commented on a change in pull request #6009: URL: https://github.com/apache/incubator-pinot/pull/6009#discussion_r488141168 ## File path: pinot-plugins/pinot-input-format/pinot-avro-base/src/main/java/org/apache/pinot/plugin/inputformat/avro/AvroIngestionSchemaValidator.java

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #6009: Adjust schema validation logic in AvroIngestionSchemaValidator

2020-09-14 Thread GitBox
jackjlli commented on a change in pull request #6009: URL: https://github.com/apache/incubator-pinot/pull/6009#discussion_r488192591 ## File path: pinot-plugins/pinot-input-format/pinot-avro-base/src/main/java/org/apache/pinot/plugin/inputformat/avro/AvroIngestionSchemaValidator.java

[incubator-pinot] branch fix-schema-validator updated (f09ca9a -> 8dd0777)

2020-09-14 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch fix-schema-validator in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from f09ca9a Reduce test file sizes add 8dd0777 Address PR comments No new revisions were

[incubator-pinot] branch fix-schema-validator updated (8dd0777 -> 8b4841e)

2020-09-14 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch fix-schema-validator in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 8dd0777 Address PR comments add 8b4841e Address PR comments This update added new

[incubator-pinot] branch master updated (d9d43fb -> f5606b4)

2020-09-14 Thread apucher
This is an automated email from the ASF dual-hosted git repository. apucher pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from d9d43fb [TE] Add ingress, traefik to helm chart (#5985) add f5606b4 [TE] Added thirdeye-coordinator

[GitHub] [incubator-pinot] agrawaldevesh commented on issue #3513: DATETIMECONVERT udf does not work for customized timezone and bucket size > 1 day

2020-09-14 Thread GitBox
agrawaldevesh commented on issue #3513: URL: https://github.com/apache/incubator-pinot/issues/3513#issuecomment-692362099 FWIW, @chenboat I added a preso compatible date_trunc that handles your ask: https://github.com/apache/incubator-pinot/pull/4740.

[incubator-pinot] branch master updated: [TE] Make data-sources configurable in ThirdEye Helm Chart (#6015)

2020-09-14 Thread apucher
This is an automated email from the ASF dual-hosted git repository. apucher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 14611ae [TE] Make data-sources

[GitHub] [incubator-pinot] apucher merged pull request #6015: [TE] Make data-sources configurable in ThirdEye Helm Chart

2020-09-14 Thread GitBox
apucher merged pull request #6015: URL: https://github.com/apache/incubator-pinot/pull/6015 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-pinot] apucher merged pull request #5985: [TE] Add ingress, traefik to helm chart

2020-09-14 Thread GitBox
apucher merged pull request #5985: URL: https://github.com/apache/incubator-pinot/pull/5985 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-pinot] apucher merged pull request #6014: [TE] Added thirdeye-coordinator and thirdeye-dist modules

2020-09-14 Thread GitBox
apucher merged pull request #6014: URL: https://github.com/apache/incubator-pinot/pull/6014 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[incubator-pinot] branch master updated (d9d43fb -> f5606b4)

2020-09-14 Thread apucher
This is an automated email from the ASF dual-hosted git repository. apucher pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from d9d43fb [TE] Add ingress, traefik to helm chart (#5985) add f5606b4 [TE] Added thirdeye-coordinator

[incubator-pinot] branch master updated (dc77271 -> d9d43fb)

2020-09-14 Thread apucher
This is an automated email from the ASF dual-hosted git repository. apucher pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from dc77271 Feature/#5390 segment indexing reload status api (#5718) add d9d43fb [TE] Add ingress,

[incubator-pinot] branch master updated (dc77271 -> d9d43fb)

2020-09-14 Thread apucher
This is an automated email from the ASF dual-hosted git repository. apucher pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from dc77271 Feature/#5390 segment indexing reload status api (#5718) add d9d43fb [TE] Add ingress,

[GitHub] [incubator-pinot] suvodeep-pyne opened a new pull request #6015: [TE] Make data-sources configurable in ThirdEye Helm Chart

2020-09-14 Thread GitBox
suvodeep-pyne opened a new pull request #6015: URL: https://github.com/apache/incubator-pinot/pull/6015 Currently, the data-sources config file is hardcoded in the template. This change allows user to replace the data-sources config in the config directory thereby allowing the user to

[GitHub] [incubator-pinot] suvodeep-pyne commented on pull request #6015: [TE] Make data-sources configurable in ThirdEye Helm Chart

2020-09-14 Thread GitBox
suvodeep-pyne commented on pull request #6015: URL: https://github.com/apache/incubator-pinot/pull/6015#issuecomment-692362285 Thanks @apucher ! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-pinot] npawar commented on a change in pull request #5934: Segment processing framework

2020-09-14 Thread GitBox
npawar commented on a change in pull request #5934: URL: https://github.com/apache/incubator-pinot/pull/5934#discussion_r488325887 ## File path: pinot-core/src/main/java/org/apache/pinot/core/segment/processing/utils/SegmentProcessorUtils.java ## @@ -0,0 +1,113 @@ +/** + *

[GitHub] [incubator-pinot] npawar commented on a change in pull request #5934: Segment processing framework

2020-09-14 Thread GitBox
npawar commented on a change in pull request #5934: URL: https://github.com/apache/incubator-pinot/pull/5934#discussion_r488326079 ## File path: pinot-core/src/main/java/org/apache/pinot/core/segment/processing/partitioner/PartitionerFactory.java ## @@ -0,0 +1,82 @@ +/** + *

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5934: Segment processing framework

2020-09-14 Thread GitBox
Jackie-Jiang commented on a change in pull request #5934: URL: https://github.com/apache/incubator-pinot/pull/5934#discussion_r488337421 ## File path: pinot-core/src/main/java/org/apache/pinot/core/segment/processing/utils/SegmentProcessorUtils.java ## @@ -0,0 +1,113 @@ +/**

[GitHub] [incubator-pinot] npawar commented on pull request #5934: Segment processing framework

2020-09-14 Thread GitBox
npawar commented on pull request #5934: URL: https://github.com/apache/incubator-pinot/pull/5934#issuecomment-692401724 > Overall, I like that all the core components are interfaced out and easy to extend. I have put some comments. Some of them are questions or points that I would like to