[GitHub] massakam commented on a change in pull request #836: In C++ partitioned consumer, do not append partition index in subscription name

2017-10-18 Thread GitBox
massakam commented on a change in pull request #836: In C++ partitioned consumer, do not append partition index in subscription name URL: https://github.com/apache/incubator-pulsar/pull/836#discussion_r145585568 ## File path: pulsar-client-cpp/tests/BasicEndToEndTest.cc ##

[GitHub] saandrews opened a new pull request #839: Specify rsa transform, aes & tag length

2017-10-18 Thread GitBox
saandrews opened a new pull request #839: Specify rsa transform, aes & tag length URL: https://github.com/apache/incubator-pulsar/pull/839 Addressing issues mentioned in #838. Tested using a test program in C++ using openssl and verified encryption/decryption using RSA works both ways.

[GitHub] jai1 commented on issue #836: In C++ partitioned consumer, do not append partition index in subscription name

2017-10-18 Thread GitBox
jai1 commented on issue #836: In C++ partitioned consumer, do not append partition index in subscription name URL: https://github.com/apache/incubator-pulsar/pull/836#issuecomment-337666563 retest this please This is an

[GitHub] saandrews opened a new issue #838: Encryption fixes to address compatibility across crypto libraries

2017-10-18 Thread GitBox
saandrews opened a new issue #838: Encryption fixes to address compatibility across crypto libraries URL: https://github.com/apache/incubator-pulsar/issues/838 Addressing few issues which is require in order for other libraries like openssl(c++ client) to be able to process and decrypt

[GitHub] merlimat opened a new pull request #849: Implement seekToBeginning()/end operations in Kafka consumer wrapper

2017-10-23 Thread GitBox
merlimat opened a new pull request #849: Implement seekToBeginning()/end operations in Kafka consumer wrapper URL: https://github.com/apache/incubator-pulsar/pull/849 ### Motivation The Kafka `ConsumerPerformance` benchmark tool makes use of the `seekToBeginning()`, `seekToEnd()`

[GitHub] rdhabalia commented on a change in pull request #848: Allow consumer to seek to message id from within Pulsar client

2017-10-23 Thread GitBox
rdhabalia commented on a change in pull request #848: Allow consumer to seek to message id from within Pulsar client URL: https://github.com/apache/incubator-pulsar/pull/848#discussion_r146428274 ## File path:

[GitHub] rdhabalia commented on a change in pull request #848: Allow consumer to seek to message id from within Pulsar client

2017-10-23 Thread GitBox
rdhabalia commented on a change in pull request #848: Allow consumer to seek to message id from within Pulsar client URL: https://github.com/apache/incubator-pulsar/pull/848#discussion_r146426737 ## File path:

[GitHub] rdhabalia commented on a change in pull request #848: Allow consumer to seek to message id from within Pulsar client

2017-10-23 Thread GitBox
rdhabalia commented on a change in pull request #848: Allow consumer to seek to message id from within Pulsar client URL: https://github.com/apache/incubator-pulsar/pull/848#discussion_r146428378 ## File path:

[GitHub] merlimat opened a new pull request #850: Use "trimStackTrace" option in Maven surefire

2017-10-23 Thread GitBox
merlimat opened a new pull request #850: Use "trimStackTrace" option in Maven surefire URL: https://github.com/apache/incubator-pulsar/pull/850 ### Motivation This option will print the full stack trace of exception thrown within the test execution. In many cases, this should help

[GitHub] merlimat commented on a change in pull request #848: Allow consumer to seek to message id from within Pulsar client

2017-10-23 Thread GitBox
merlimat commented on a change in pull request #848: Allow consumer to seek to message id from within Pulsar client URL: https://github.com/apache/incubator-pulsar/pull/848#discussion_r146429033 ## File path:

[GitHub] merlimat commented on a change in pull request #848: Allow consumer to seek to message id from within Pulsar client

2017-10-23 Thread GitBox
merlimat commented on a change in pull request #848: Allow consumer to seek to message id from within Pulsar client URL: https://github.com/apache/incubator-pulsar/pull/848#discussion_r146429093 ## File path:

[GitHub] merlimat commented on issue #846: Publish the shaded pulsar-client as the default dependency

2017-10-23 Thread GitBox
merlimat commented on issue #846: Publish the shaded pulsar-client as the default dependency URL: https://github.com/apache/incubator-pulsar/pull/846#issuecomment-338775878 > I just tried this commit it creates pulsar-client.jar(shaded jar) and pulsar-client-original.jar (actual jar

[GitHub] merlimat commented on issue #846: Publish the shaded pulsar-client as the default dependency

2017-10-23 Thread GitBox
merlimat commented on issue #846: Publish the shaded pulsar-client as the default dependency URL: https://github.com/apache/incubator-pulsar/pull/846#issuecomment-338801668 > So, mvn install creates two separate jars in target pulsar-client-original(unshaded) and

[GitHub] merlimat commented on issue #839: Specify rsa transform, aes & tag length

2017-10-19 Thread GitBox
merlimat commented on issue #839: Specify rsa transform, aes & tag length URL: https://github.com/apache/incubator-pulsar/pull/839#issuecomment-337991632 > This is because our build env does not have the JCE Unlimited Strength Jurisdiction Policy files.

[GitHub] saandrews commented on issue #839: Specify rsa transform, aes & tag length

2017-10-19 Thread GitBox
saandrews commented on issue #839: Specify rsa transform, aes & tag length URL: https://github.com/apache/incubator-pulsar/pull/839#issuecomment-338003748 I see your point. But, if we do not enforce, a producer produced using 256 bit AES key and if consumer host does not have the unlimited

[GitHub] saandrews commented on issue #839: Specify rsa transform, aes & tag length

2017-10-19 Thread GitBox
saandrews commented on issue #839: Specify rsa transform, aes & tag length URL: https://github.com/apache/incubator-pulsar/pull/839#issuecomment-337990856 This is because our build env does not have the JCE Unlimited Strength Jurisdiction Policy files.

[GitHub] saandrews commented on issue #839: Specify rsa transform, aes & tag length

2017-10-19 Thread GitBox
saandrews commented on issue #839: Specify rsa transform, aes & tag length URL: https://github.com/apache/incubator-pulsar/pull/839#issuecomment-338003748 I see your point. But, if we do not enforce, a producer produced using 256 bit AES key and if consumer host does not have the unlimited

[GitHub] merlimat opened a new pull request #842: Add PulsarClientImpl.getNumberOfPartitions() to avoid exposing PartitionedTopicMetadata

2017-10-19 Thread GitBox
merlimat opened a new pull request #842: Add PulsarClientImpl.getNumberOfPartitions() to avoid exposing PartitionedTopicMetadata URL: https://github.com/apache/incubator-pulsar/pull/842 ### Motivation The `PartitionedTopicMetadata` will be shaded if the pulsar-client library

[GitHub] saandrews commented on issue #839: Specify rsa transform, aes & tag length

2017-10-19 Thread GitBox
saandrews commented on issue #839: Specify rsa transform, aes & tag length URL: https://github.com/apache/incubator-pulsar/pull/839#issuecomment-338003748 I see your point. But, if we do not enforce, a producer produced using 256 bit AES key and if consumer host does not have the unlimited

[GitHub] merlimat commented on issue #849: Implement seekToBeginning()/end operations in Kafka consumer wrapper

2017-10-23 Thread GitBox
merlimat commented on issue #849: Implement seekToBeginning()/end operations in Kafka consumer wrapper URL: https://github.com/apache/incubator-pulsar/pull/849#issuecomment-338875446 Rebased on master after merging #848

[GitHub] massakam commented on issue #841: Change timezone of request log from GMT to local one

2017-10-24 Thread GitBox
massakam commented on issue #841: Change timezone of request log from GMT to local one URL: https://github.com/apache/incubator-pulsar/pull/841#issuecomment-338884052 @merlimat Yes, since timezone is not specified in log4j configuration files, user's local timezone is used by default.

[GitHub] merlimat commented on issue #850: Use "trimStackTrace" option in Maven surefire

2017-10-23 Thread GitBox
merlimat commented on issue #850: Use "trimStackTrace" option in Maven surefire URL: https://github.com/apache/incubator-pulsar/pull/850#issuecomment-338873124 retest this please This is an automated message from the Apache

[GitHub] merlimat commented on issue #850: Use "trimStackTrace" option in Maven surefire

2017-10-23 Thread GitBox
merlimat commented on issue #850: Use "trimStackTrace" option in Maven surefire URL: https://github.com/apache/incubator-pulsar/pull/850#issuecomment-338873124 retest this please This is an automated message from the Apache

[GitHub] merlimat commented on issue #841: Change timezone of request log from GMT to local one

2017-10-23 Thread GitBox
merlimat commented on issue #841: Change timezone of request log from GMT to local one URL: https://github.com/apache/incubator-pulsar/pull/841#issuecomment-338875818 @massakam Is the other log4j configuration already using local timezone as well?

[GitHub] rdhabalia commented on a change in pull request #846: Publish the shaded pulsar-client as the default dependency

2017-10-23 Thread GitBox
rdhabalia commented on a change in pull request #846: Publish the shaded pulsar-client as the default dependency URL: https://github.com/apache/incubator-pulsar/pull/846#discussion_r146361946 ## File path: pulsar-client-shaded/pom.xml ## @@ -0,0 +1,140 @@ +

[GitHub] asfgit commented on issue #901: Introduce configuration converter

2017-11-15 Thread GitBox
asfgit commented on issue #901: Introduce configuration converter URL: https://github.com/apache/incubator-pulsar/pull/901#issuecomment-344707272 FAILURE --none-- This is an automated message from the Apache Git

[GitHub] asfgit commented on issue #896: Introduce Failure-domain and Anti-affinity-namespace group

2017-11-15 Thread GitBox
asfgit commented on issue #896: Introduce Failure-domain and Anti-affinity-namespace group URL: https://github.com/apache/incubator-pulsar/pull/896#issuecomment-344718476 SUCCESS --none-- This is an automated

[GitHub] yush1ga commented on issue #901: Introduce configuration converter

2017-11-15 Thread GitBox
yush1ga commented on issue #901: Introduce configuration converter URL: https://github.com/apache/incubator-pulsar/pull/901#issuecomment-344734432 retest this please This is an automated message from the Apache Git Service.

[GitHub] asfgit commented on issue #901: Introduce configuration converter

2017-11-15 Thread GitBox
asfgit commented on issue #901: Introduce configuration converter URL: https://github.com/apache/incubator-pulsar/pull/901#issuecomment-344744654 FAILURE --none-- This is an automated message from the Apache Git

[GitHub] yush1ga commented on issue #901: Introduce configuration converter

2017-11-15 Thread GitBox
yush1ga commented on issue #901: Introduce configuration converter URL: https://github.com/apache/incubator-pulsar/pull/901#issuecomment-344748525 retest this please This is an automated message from the Apache Git Service.

[GitHub] asfgit commented on issue #896: Introduce Failure-domain and Anti-affinity-namespace group

2017-11-15 Thread GitBox
asfgit commented on issue #896: Introduce Failure-domain and Anti-affinity-namespace group URL: https://github.com/apache/incubator-pulsar/pull/896#issuecomment-344718476 SUCCESS --none-- This is an automated

[GitHub] asfgit commented on issue #901: Introduce configuration converter

2017-11-15 Thread GitBox
asfgit commented on issue #901: Introduce configuration converter URL: https://github.com/apache/incubator-pulsar/pull/901#issuecomment-344746630 FAILURE --none-- This is an automated message from the Apache Git

[GitHub] asfgit commented on issue #901: Introduce configuration converter

2017-11-15 Thread GitBox
asfgit commented on issue #901: Introduce configuration converter URL: https://github.com/apache/incubator-pulsar/pull/901#issuecomment-344744654 FAILURE --none-- This is an automated message from the Apache Git

[GitHub] asfgit commented on issue #901: Introduce configuration converter

2017-11-15 Thread GitBox
asfgit commented on issue #901: Introduce configuration converter URL: https://github.com/apache/incubator-pulsar/pull/901#issuecomment-344758971 FAILURE --none-- This is an automated message from the Apache Git

[GitHub] asfgit commented on issue #901: Introduce configuration converter

2017-11-15 Thread GitBox
asfgit commented on issue #901: Introduce configuration converter URL: https://github.com/apache/incubator-pulsar/pull/901#issuecomment-344758971 FAILURE --none-- This is an automated message from the Apache Git

[GitHub] yush1ga commented on issue #901: Introduce configuration converter

2017-11-15 Thread GitBox
yush1ga commented on issue #901: Introduce configuration converter URL: https://github.com/apache/incubator-pulsar/pull/901#issuecomment-344759146 retest this please This is an automated message from the Apache Git Service.

[GitHub] asfgit commented on issue #896: Introduce Failure-domain and Anti-affinity-namespace group

2017-11-14 Thread GitBox
asfgit commented on issue #896: Introduce Failure-domain and Anti-affinity-namespace group URL: https://github.com/apache/incubator-pulsar/pull/896#issuecomment-344430368 FAILURE --none-- This is an automated message

[GitHub] rdhabalia commented on issue #896: Introduce Failure-domain and Anti-affinity-namespace group

2017-11-14 Thread GitBox
rdhabalia commented on issue #896: Introduce Failure-domain and Anti-affinity-namespace group URL: https://github.com/apache/incubator-pulsar/pull/896#issuecomment-344415329 retest this please This is an automated message

[GitHub] asfgit commented on issue #896: Introduce Failure-domain and Anti-affinity-namespace group

2017-11-14 Thread GitBox
asfgit commented on issue #896: Introduce Failure-domain and Anti-affinity-namespace group URL: https://github.com/apache/incubator-pulsar/pull/896#issuecomment-344375080 FAILURE --none-- This is an automated message

[GitHub] asfgit commented on issue #902: Set error-message into RestException

2017-11-14 Thread GitBox
asfgit commented on issue #902: Set error-message into RestException URL: https://github.com/apache/incubator-pulsar/pull/902#issuecomment-344389006 SUCCESS --none-- This is an automated message from the Apache Git

[GitHub] rdhabalia commented on issue #896: Introduce Failure-domain and Anti-affinity-namespace group

2017-11-14 Thread GitBox
rdhabalia commented on issue #896: Introduce Failure-domain and Anti-affinity-namespace group URL: https://github.com/apache/incubator-pulsar/pull/896#issuecomment-344415329 retest this please This is an automated message

[GitHub] rdhabalia closed pull request #902: Set error-message into RestException

2017-11-14 Thread GitBox
rdhabalia closed pull request #902: Set error-message into RestException URL: https://github.com/apache/incubator-pulsar/pull/902 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] asfgit commented on issue #901: Introduce configuration converter

2017-11-14 Thread GitBox
asfgit commented on issue #901: Introduce configuration converter URL: https://github.com/apache/incubator-pulsar/pull/901#issuecomment-344383612 SUCCESS --none-- This is an automated message from the Apache Git

[GitHub] rdhabalia commented on a change in pull request #901: Introduce configuration converter

2017-11-14 Thread GitBox
rdhabalia commented on a change in pull request #901: Introduce configuration converter URL: https://github.com/apache/incubator-pulsar/pull/901#discussion_r150950022 ## File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java ##

[GitHub] asfgit commented on issue #901: Introduce configuration converter

2017-11-14 Thread GitBox
asfgit commented on issue #901: Introduce configuration converter URL: https://github.com/apache/incubator-pulsar/pull/901#issuecomment-344383612 SUCCESS --none-- This is an automated message from the Apache Git

[GitHub] rdhabalia commented on a change in pull request #901: Introduce configuration converter

2017-11-14 Thread GitBox
rdhabalia commented on a change in pull request #901: Introduce configuration converter URL: https://github.com/apache/incubator-pulsar/pull/901#discussion_r150948924 ## File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java ##

[GitHub] yush1ga commented on a change in pull request #901: Introduce configuration converter

2017-11-14 Thread GitBox
yush1ga commented on a change in pull request #901: Introduce configuration converter URL: https://github.com/apache/incubator-pulsar/pull/901#discussion_r150965286 ## File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java ## @@

[GitHub] yush1ga commented on a change in pull request #901: Introduce configuration converter

2017-11-14 Thread GitBox
yush1ga commented on a change in pull request #901: Introduce configuration converter URL: https://github.com/apache/incubator-pulsar/pull/901#discussion_r150964865 ## File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java ## @@

[GitHub] asfgit commented on issue #901: Introduce configuration converter

2017-11-14 Thread GitBox
asfgit commented on issue #901: Introduce configuration converter URL: https://github.com/apache/incubator-pulsar/pull/901#issuecomment-344417331 SUCCESS --none-- This is an automated message from the Apache Git

[GitHub] asfgit commented on issue #903: PIP-8: Introduce peer cluster for global namespace redirection

2017-11-14 Thread GitBox
asfgit commented on issue #903: PIP-8: Introduce peer cluster for global namespace redirection URL: https://github.com/apache/incubator-pulsar/pull/903#issuecomment-344472454 SUCCESS --none-- This is an automated

[GitHub] rdhabalia opened a new pull request #903: PIP-8: Introduce peer cluster for global namespace redirection

2017-11-14 Thread GitBox
rdhabalia opened a new pull request #903: PIP-8: Introduce peer cluster for global namespace redirection URL: https://github.com/apache/incubator-pulsar/pull/903 ### Motivation As described in [PIP-8](https://github.com/apache/incubator-pulsar/wiki/PIP-8-Pulsar-beyond-1M-topics),

[GitHub] rdhabalia commented on a change in pull request #901: Introduce configuration converter

2017-11-14 Thread GitBox
rdhabalia commented on a change in pull request #901: Introduce configuration converter URL: https://github.com/apache/incubator-pulsar/pull/901#discussion_r151037495 ## File path:

[GitHub] asfgit commented on issue #901: Introduce configuration converter

2017-11-14 Thread GitBox
asfgit commented on issue #901: Introduce configuration converter URL: https://github.com/apache/incubator-pulsar/pull/901#issuecomment-344417331 SUCCESS --none-- This is an automated message from the Apache Git

[GitHub] nkurihar closed pull request #901: Introduce configuration converter

2017-11-15 Thread GitBox
nkurihar closed pull request #901: Introduce configuration converter URL: https://github.com/apache/incubator-pulsar/pull/901 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] yush1ga commented on a change in pull request #903: PIP-8: Introduce peer cluster for global namespace redirection

2017-11-15 Thread GitBox
yush1ga commented on a change in pull request #903: PIP-8: Introduce peer cluster for global namespace redirection URL: https://github.com/apache/incubator-pulsar/pull/903#discussion_r151291727 ## File path:

[GitHub] yush1ga commented on a change in pull request #903: PIP-8: Introduce peer cluster for global namespace redirection

2017-11-15 Thread GitBox
yush1ga commented on a change in pull request #903: PIP-8: Introduce peer cluster for global namespace redirection URL: https://github.com/apache/incubator-pulsar/pull/903#discussion_r151293829 ## File path:

[GitHub] nkurihar commented on issue #901: Introduce configuration converter

2017-11-15 Thread GitBox
nkurihar commented on issue #901: Introduce configuration converter URL: https://github.com/apache/incubator-pulsar/pull/901#issuecomment-344772559 LGTM ? This is an automated message from the Apache Git Service. To respond

[GitHub] rdhabalia commented on a change in pull request #903: PIP-8: Introduce peer cluster for global namespace redirection

2017-11-15 Thread GitBox
rdhabalia commented on a change in pull request #903: PIP-8: Introduce peer cluster for global namespace redirection URL: https://github.com/apache/incubator-pulsar/pull/903#discussion_r151292532 ## File path:

[GitHub] asfgit commented on issue #904: Check message encryption when producer connect and publish

2017-11-15 Thread GitBox
asfgit commented on issue #904: Check message encryption when producer connect and publish URL: https://github.com/apache/incubator-pulsar/pull/904#issuecomment-344796353 SUCCESS --none-- This is an automated

[GitHub] afalko commented on a change in pull request #920: Provide an Ansible playbook for AWS with documentation (WIP)

2017-11-28 Thread GitBox
afalko commented on a change in pull request #920: Provide an Ansible playbook for AWS with documentation (WIP) URL: https://github.com/apache/incubator-pulsar/pull/920#discussion_r153579930 ## File path: ansible/provision-pulsar-aws.tf ## @@ -0,0 +1,117 @@ +variable

[GitHub] afalko commented on a change in pull request #920: Provide an Ansible playbook for AWS with documentation (WIP)

2017-11-28 Thread GitBox
afalko commented on a change in pull request #920: Provide an Ansible playbook for AWS with documentation (WIP) URL: https://github.com/apache/incubator-pulsar/pull/920#discussion_r153579568 ## File path: ansible/provision-pulsar-aws.tf ## @@ -0,0 +1,117 @@ +variable

[GitHub] afalko commented on a change in pull request #920: Provide an Ansible playbook for AWS with documentation (WIP)

2017-11-28 Thread GitBox
afalko commented on a change in pull request #920: Provide an Ansible playbook for AWS with documentation (WIP) URL: https://github.com/apache/incubator-pulsar/pull/920#discussion_r153579421 ## File path: ansible/provision-pulsar-aws.tf ## @@ -0,0 +1,117 @@ +variable

[GitHub] afalko commented on a change in pull request #920: Provide an Ansible playbook for AWS with documentation (WIP)

2017-11-28 Thread GitBox
afalko commented on a change in pull request #920: Provide an Ansible playbook for AWS with documentation (WIP) URL: https://github.com/apache/incubator-pulsar/pull/920#discussion_r153580924 ## File path: ansible/deploy-pulsar.yaml ## @@ -0,0 +1,166 @@ +# +# Licensed to

[GitHub] merlimat commented on issue #689: Netty 4.1

2017-11-27 Thread GitBox
merlimat commented on issue #689: Netty 4.1 URL: https://github.com/apache/incubator-pulsar/pull/689#issuecomment-347335108 retest this please This is an automated message from the Apache Git Service. To respond to the

[GitHub] merlimat closed pull request #919: Fix: broker-zookeeper latency-metrics's dimension-name

2017-11-28 Thread GitBox
merlimat closed pull request #919: Fix: broker-zookeeper latency-metrics's dimension-name URL: https://github.com/apache/incubator-pulsar/pull/919 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] lucperkins opened a new pull request #921: Restructure bare metal deployment documentation (WIP)

2017-11-28 Thread GitBox
lucperkins opened a new pull request #921: Restructure bare metal deployment documentation (WIP) URL: https://github.com/apache/incubator-pulsar/pull/921 ### Motivation At the moment, the instructions on installing a bare metal cluster or instance are overly complex and in need of

[GitHub] merlimat commented on a change in pull request #689: Netty 4.1

2017-11-28 Thread GitBox
merlimat commented on a change in pull request #689: Netty 4.1 URL: https://github.com/apache/incubator-pulsar/pull/689#discussion_r153646222 ## File path: pom.xml ## @@ -125,7 +125,7 @@ flexible messaging model and an intuitive client API.

[GitHub] lucperkins commented on a change in pull request #920: Provide an Ansible playbook for AWS with documentation (WIP)

2017-11-28 Thread GitBox
lucperkins commented on a change in pull request #920: Provide an Ansible playbook for AWS with documentation (WIP) URL: https://github.com/apache/incubator-pulsar/pull/920#discussion_r153656217 ## File path: ansible/provision-pulsar-aws.tf ## @@ -0,0 +1,117 @@ +variable

[GitHub] merlimat commented on a change in pull request #689: Netty 4.1

2017-11-28 Thread GitBox
merlimat commented on a change in pull request #689: Netty 4.1 URL: https://github.com/apache/incubator-pulsar/pull/689#discussion_r153646724 ## File path: build/docker/protobuf.patch ## @@ -161,30 +167,30 @@ index 4c087db..cd18e28 100644 "classname",

[GitHub] merlimat commented on a change in pull request #689: Netty 4.1

2017-11-28 Thread GitBox
merlimat commented on a change in pull request #689: Netty 4.1 URL: https://github.com/apache/incubator-pulsar/pull/689#discussion_r153646828 ## File path: pulsar-common/src/test/java/org/apache/pulsar/common/api/DoubleByteBufTest.java ## @@ -50,5 +50,22 @@ public void

[GitHub] rdhabalia commented on a change in pull request #689: Netty 4.1

2017-11-28 Thread GitBox
rdhabalia commented on a change in pull request #689: Netty 4.1 URL: https://github.com/apache/incubator-pulsar/pull/689#discussion_r153633906 ## File path: build/docker/protobuf.patch ## @@ -161,30 +167,30 @@ index 4c087db..cd18e28 100644 "classname",

[GitHub] rdhabalia commented on a change in pull request #689: Netty 4.1

2017-11-28 Thread GitBox
rdhabalia commented on a change in pull request #689: Netty 4.1 URL: https://github.com/apache/incubator-pulsar/pull/689#discussion_r153639881 ## File path: pulsar-common/src/test/java/org/apache/pulsar/common/api/DoubleByteBufTest.java ## @@ -50,5 +50,22 @@ public void

[GitHub] rdhabalia commented on a change in pull request #689: Netty 4.1

2017-11-28 Thread GitBox
rdhabalia commented on a change in pull request #689: Netty 4.1 URL: https://github.com/apache/incubator-pulsar/pull/689#discussion_r153638970 ## File path: pulsar-common/src/main/java/org/apache/pulsar/common/util/protobuf/ByteBufCodedOutputStream.java ## @@ -261,7

[GitHub] rdhabalia commented on a change in pull request #689: Netty 4.1

2017-11-28 Thread GitBox
rdhabalia commented on a change in pull request #689: Netty 4.1 URL: https://github.com/apache/incubator-pulsar/pull/689#discussion_r153636992 ## File path: pom.xml ## @@ -125,7 +125,7 @@ flexible messaging model and an intuitive client API.

[GitHub] lucperkins commented on a change in pull request #920: Provide an Ansible playbook for AWS with documentation (WIP)

2017-11-28 Thread GitBox
lucperkins commented on a change in pull request #920: Provide an Ansible playbook for AWS with documentation (WIP) URL: https://github.com/apache/incubator-pulsar/pull/920#discussion_r153655770 ## File path: ansible/provision-pulsar-aws.tf ## @@ -0,0 +1,117 @@ +variable

[GitHub] lucperkins commented on a change in pull request #920: Provide an Ansible playbook for AWS with documentation (WIP)

2017-11-28 Thread GitBox
lucperkins commented on a change in pull request #920: Provide an Ansible playbook for AWS with documentation (WIP) URL: https://github.com/apache/incubator-pulsar/pull/920#discussion_r153655770 ## File path: ansible/provision-pulsar-aws.tf ## @@ -0,0 +1,117 @@ +variable

[GitHub] rdhabalia commented on issue #689: Netty 4.1

2017-11-26 Thread GitBox
rdhabalia commented on issue #689: Netty 4.1 URL: https://github.com/apache/incubator-pulsar/pull/689#issuecomment-346995006 retest this please This is an automated message from the Apache Git Service. To respond to the

[GitHub] rdhabalia commented on issue #689: Netty 4.1

2017-11-26 Thread GitBox
rdhabalia commented on issue #689: Netty 4.1 URL: https://github.com/apache/incubator-pulsar/pull/689#issuecomment-346995006 retest this please This is an automated message from the Apache Git Service. To respond to the

[GitHub] merlimat closed pull request #918: add admin-api doc for peer-clusters

2017-11-24 Thread GitBox
merlimat closed pull request #918: add admin-api doc for peer-clusters URL: https://github.com/apache/incubator-pulsar/pull/918 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] merlimat closed pull request #911: Avoid running duplicate ReplicatorTest

2017-11-24 Thread GitBox
merlimat closed pull request #911: Avoid running duplicate ReplicatorTest URL: https://github.com/apache/incubator-pulsar/pull/911 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] yush1ga commented on issue #912: Check whether the property exists at the beginning of `validateAdminAccessOnProperty`

2017-11-26 Thread GitBox
yush1ga commented on issue #912: Check whether the property exists at the beginning of `validateAdminAccessOnProperty` URL: https://github.com/apache/incubator-pulsar/pull/912#issuecomment-347073918 retest this please This

[GitHub] yush1ga commented on issue #912: Check whether the property exists at the beginning of `validateAdminAccessOnProperty`

2017-11-26 Thread GitBox
yush1ga commented on issue #912: Check whether the property exists at the beginning of `validateAdminAccessOnProperty` URL: https://github.com/apache/incubator-pulsar/pull/912#issuecomment-347073918 retest this please This

[GitHub] zhaijack commented on issue #917: Provide an DCOS Universe package for pulsar

2017-11-22 Thread GitBox
zhaijack commented on issue #917: Provide an DCOS Universe package for pulsar URL: https://github.com/apache/incubator-pulsar/issues/917#issuecomment-346513622 @sijie , Sure, I would like to do this. This is an automated

[GitHub] rdhabalia opened a new pull request #918: add admin-api doc for peer-clusters

2017-11-22 Thread GitBox
rdhabalia opened a new pull request #918: add admin-api doc for peer-clusters URL: https://github.com/apache/incubator-pulsar/pull/918 ### Motivation Add admin-api doc for peer-clusters introduced in #903 This is

[GitHub] sijie opened a new issue #917: Provide an DCOS Universe package for pulsar

2017-11-22 Thread GitBox
sijie opened a new issue #917: Provide an DCOS Universe package for pulsar URL: https://github.com/apache/incubator-pulsar/issues/917 Similar as what Bookkeeper does at apache/bookkeeper#586, provide a pulsar package in DCOS universe.

[GitHub] sijie commented on issue #917: Provide an DCOS Universe package for pulsar

2017-11-22 Thread GitBox
sijie commented on issue #917: Provide an DCOS Universe package for pulsar URL: https://github.com/apache/incubator-pulsar/issues/917#issuecomment-346501894 /cc @zhaijack This is an automated message from the Apache Git

[GitHub] zhaijack commented on issue #917: Provide an DCOS Universe package for pulsar

2017-11-22 Thread GitBox
zhaijack commented on issue #917: Provide an DCOS Universe package for pulsar URL: https://github.com/apache/incubator-pulsar/issues/917#issuecomment-346513622 @sijie , Sure, I would like to have a try on this. This is an

[GitHub] merlimat commented on a change in pull request #918: add admin-api doc for peer-clusters

2017-11-22 Thread GitBox
merlimat commented on a change in pull request #918: add admin-api doc for peer-clusters URL: https://github.com/apache/incubator-pulsar/pull/918#discussion_r152736329 ## File path: site/README.md ## @@ -125,7 +125,7 @@ $ make protobuf_doc_gen ### REST API docs -The

[GitHub] merlimat commented on a change in pull request #923: Upgrade to bk-4.3.1.83-yahoo to expose journalSyncData option

2017-11-28 Thread GitBox
merlimat commented on a change in pull request #923: Upgrade to bk-4.3.1.83-yahoo to expose journalSyncData option URL: https://github.com/apache/incubator-pulsar/pull/923#discussion_r153696154 ## File path: pom.xml ## @@ -106,15 +106,15 @@ flexible messaging model and an

[GitHub] merlimat closed pull request #923: Upgrade to bk-4.3.1.83-yahoo to expose journalSyncData option

2017-11-28 Thread GitBox
merlimat closed pull request #923: Upgrade to bk-4.3.1.83-yahoo to expose journalSyncData option URL: https://github.com/apache/incubator-pulsar/pull/923 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] rdhabalia commented on a change in pull request #923: Upgrade to bk-4.3.1.83-yahoo to expose journalSyncData option

2017-11-28 Thread GitBox
rdhabalia commented on a change in pull request #923: Upgrade to bk-4.3.1.83-yahoo to expose journalSyncData option URL: https://github.com/apache/incubator-pulsar/pull/923#discussion_r153695650 ## File path: pom.xml ## @@ -106,15 +106,15 @@ flexible messaging model and

[GitHub] merlimat commented on a change in pull request #923: Upgrade to bk-4.3.1.83-yahoo to expose journalSyncData option

2017-11-28 Thread GitBox
merlimat commented on a change in pull request #923: Upgrade to bk-4.3.1.83-yahoo to expose journalSyncData option URL: https://github.com/apache/incubator-pulsar/pull/923#discussion_r153696236 ## File path: pom.xml ## @@ -106,15 +106,15 @@ flexible messaging model and an

[GitHub] nkurihar opened a new pull request #925: Bumped version to 1.22.0-incubating-SNAPSHOT

2017-11-29 Thread GitBox
nkurihar opened a new pull request #925: Bumped version to 1.22.0-incubating-SNAPSHOT URL: https://github.com/apache/incubator-pulsar/pull/925 ### Motivation Bump up version to 1.22.0-incubating-SNAPSHOT This is an

[GitHub] merlimat closed pull request #925: Bumped version to 1.22.0-incubating-SNAPSHOT

2017-11-29 Thread GitBox
merlimat closed pull request #925: Bumped version to 1.22.0-incubating-SNAPSHOT URL: https://github.com/apache/incubator-pulsar/pull/925 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] merlimat opened a new pull request #923: Upgrade to bk-4.3.1.83-yahoo to expose journalSyncData option

2017-11-28 Thread GitBox
merlimat opened a new pull request #923: Upgrade to bk-4.3.1.83-yahoo to expose journalSyncData option URL: https://github.com/apache/incubator-pulsar/pull/923 ### Motivation Upgrade to bk-4.3.1.83-yahoo to expose journalSyncData option

[GitHub] merlimat closed issue #686: DuplicatedByteBuf is deprecated

2017-11-28 Thread GitBox
merlimat closed issue #686: DuplicatedByteBuf is deprecated URL: https://github.com/apache/incubator-pulsar/issues/686 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] jiazhai commented on issue #917: Provide an DCOS Universe package for pulsar

2017-11-28 Thread GitBox
jiazhai commented on issue #917: Provide an DCOS Universe package for pulsar URL: https://github.com/apache/incubator-pulsar/issues/917#issuecomment-347736962 Pulsar is composed of several apps (such as bookie, broker, monitor) together. But currently it only support to have one universe

[GitHub] jiazhai commented on issue #917: Provide an DCOS Universe package for pulsar

2017-11-28 Thread GitBox
jiazhai commented on issue #917: Provide an DCOS Universe package for pulsar URL: https://github.com/apache/incubator-pulsar/issues/917#issuecomment-347736962 Pulsar is composed of several apps (such as bookie, broker, monitor) together. But currently it only support to have one universe

[GitHub] zhaijack commented on issue #917: Provide an DCOS Universe package for pulsar

2017-11-28 Thread GitBox
zhaijack commented on issue #917: Provide an DCOS Universe package for pulsar URL: https://github.com/apache/incubator-pulsar/issues/917#issuecomment-347737386 Pulsar is composed of several apps (such as bookie, broker, monitor) together. But currently it only support to have one universe

[GitHub] zhaijack opened a new issue #924: Provide a json file for Marathon app groups to run Pulsar on DCOS

2017-11-28 Thread GitBox
zhaijack opened a new issue #924: Provide a json file for Marathon app groups to run Pulsar on DCOS URL: https://github.com/apache/incubator-pulsar/issues/924 There was a requirement to run Pulsar on DCOS in #917 , but Universe Package is not support well now. This ticket would like to

  1   2   3   4   5   6   7   8   9   10   >