[GitHub] [incubator-tvm] mbaret commented on issue #5134: [RELAY] Add MergeCompilerRegions pass

mbaret commented on issue #5134: [RELAY] Add MergeCompilerRegions pass URL: https://github.com/apache/incubator-tvm/pull/5134#issuecomment-603702585 It isn't (although I hope to handle that next). This is to help support the case where we partition into a region that has multiple outputs.

[GitHub] [incubator-tvm] manupa-arm commented on a change in pull request #5030: [RELAY] Added a AnnotatedRegion utility class

manupa-arm commented on a change in pull request #5030: [RELAY] Added a AnnotatedRegion utility class URL: https://github.com/apache/incubator-tvm/pull/5030#discussion_r397711380 ## File path: tests/python/relay/test_annotated_regions.py ## @@ -0,0 +1,121 @@ +# Licensed to

[GitHub] [incubator-tvm] manupa-arm commented on a change in pull request #5030: [RELAY] Added a AnnotatedRegion utility class

manupa-arm commented on a change in pull request #5030: [RELAY] Added a AnnotatedRegion utility class URL: https://github.com/apache/incubator-tvm/pull/5030#discussion_r397711380 ## File path: tests/python/relay/test_annotated_regions.py ## @@ -0,0 +1,121 @@ +# Licensed to

[GitHub] [incubator-tvm] manupa-arm commented on a change in pull request #5030: [RELAY] Added a AnnotatedRegion utility class

manupa-arm commented on a change in pull request #5030: [RELAY] Added a AnnotatedRegion utility class URL: https://github.com/apache/incubator-tvm/pull/5030#discussion_r397711380 ## File path: tests/python/relay/test_annotated_regions.py ## @@ -0,0 +1,121 @@ +# Licensed to

[GitHub] [incubator-tvm] manupa-arm commented on a change in pull request #5030: [RELAY] Added a AnnotatedRegion utility class

manupa-arm commented on a change in pull request #5030: [RELAY] Added a AnnotatedRegion utility class URL: https://github.com/apache/incubator-tvm/pull/5030#discussion_r397711380 ## File path: tests/python/relay/test_annotated_regions.py ## @@ -0,0 +1,121 @@ +# Licensed to

[GitHub] [incubator-tvm] liangfu commented on issue #5060: [uTVM][Runtime] Deprecate uTVM Standalone Runtime

liangfu commented on issue #5060: [uTVM][Runtime] Deprecate uTVM Standalone Runtime URL: https://github.com/apache/incubator-tvm/issues/5060#issuecomment-603746709  It's very interesti

[GitHub] [incubator-tvm] Robeast opened a new issue #5145: [BUG][TUTORIAL] Tutorial for quantization need update

Robeast opened a new issue #5145: [BUG][TUTORIAL] Tutorial for quantization need update URL: https://github.com/apache/incubator-tvm/issues/5145 Dear community, I've noticed that the [stock tutorial for quantization](https://github.com/apache/incubator-tvm/blob/master/tutorials/fronten

[GitHub] [incubator-tvm] kumasento commented on issue #4847: Return empty CSourceModule when no lowered_funcs exists in Relay mod

kumasento commented on issue #4847: Return empty CSourceModule when no lowered_funcs exists in Relay mod URL: https://github.com/apache/incubator-tvm/pull/4847#issuecomment-603793596 Hi @trevor-m Thanks for this information. I ran the test and reproduced the bug. I've located that the

[GitHub] [incubator-tvm] mbaret commented on a change in pull request #5030: [RELAY] Added a AnnotatedRegion utility class

mbaret commented on a change in pull request #5030: [RELAY] Added a AnnotatedRegion utility class URL: https://github.com/apache/incubator-tvm/pull/5030#discussion_r397865495 ## File path: src/relay/analysis/annotated_region_set.cc ## @@ -0,0 +1,239 @@ +/* + * Licensed to

[GitHub] [incubator-tvm] mbaret commented on a change in pull request #5030: [RELAY] Added a AnnotatedRegion utility class

mbaret commented on a change in pull request #5030: [RELAY] Added a AnnotatedRegion utility class URL: https://github.com/apache/incubator-tvm/pull/5030#discussion_r397873579 ## File path: python/tvm/relay/analysis/annotated_regions.py ## @@ -0,0 +1,62 @@ +# Licensed to th

[GitHub] [incubator-tvm] kumasento opened a new pull request #5146: Handle empty LLVMModule in GetFunction

kumasento opened a new pull request #5146: Handle empty LLVMModule in GetFunction URL: https://github.com/apache/incubator-tvm/pull/5146 #4847 introduces empty `LLVMModule`, which may appear when all the executable code are optimized #4748 . An empty `LLVMModule` is built from an IR file

[GitHub] [incubator-tvm] kumasento commented on issue #4847: Return empty CSourceModule when no lowered_funcs exists in Relay mod

kumasento commented on issue #4847: Return empty CSourceModule when no lowered_funcs exists in Relay mod URL: https://github.com/apache/incubator-tvm/pull/4847#issuecomment-603859603 @trevor-m a tentative fix has been posted in #5146 ---

[GitHub] [incubator-tvm] tqchen commented on issue #4459: [RUNTIME] Implement TVMDSOOp(TensorFlow custom op) for TVM runtime

tqchen commented on issue #4459: [RUNTIME] Implement TVMDSOOp(TensorFlow custom op) for TVM runtime URL: https://github.com/apache/incubator-tvm/pull/4459#issuecomment-603885462 @yzhliu @zhiics @soiferj please follow up again. I will also take a look during the weekend ---

[GitHub] [incubator-tvm] tqchen commented on issue #5145: [BUG][TUTORIAL] Tutorial for quantization need update

tqchen commented on issue #5145: [BUG][TUTORIAL] Tutorial for quantization need update URL: https://github.com/apache/incubator-tvm/issues/5145#issuecomment-603892205 feel free to send a PR to fix this This is an automated m

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5092: [PASS] dtype rewrite for indexing variables

tqchen commented on a change in pull request #5092: [PASS] dtype rewrite for indexing variables URL: https://github.com/apache/incubator-tvm/pull/5092#discussion_r397937697 ## File path: src/tir/pass/narrow_datatype.cc ## @@ -0,0 +1,373 @@ +/* + * Licensed to the Apache So

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5092: [PASS] dtype rewrite for indexing variables

tqchen commented on a change in pull request #5092: [PASS] dtype rewrite for indexing variables URL: https://github.com/apache/incubator-tvm/pull/5092#discussion_r397936976 ## File path: src/tir/pass/narrow_datatype.cc ## @@ -0,0 +1,373 @@ +/* + * Licensed to the Apache So

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5092: [PASS] dtype rewrite for indexing variables

tqchen commented on a change in pull request #5092: [PASS] dtype rewrite for indexing variables URL: https://github.com/apache/incubator-tvm/pull/5092#discussion_r397936885 ## File path: src/tir/pass/narrow_datatype.cc ## @@ -0,0 +1,373 @@ +/* + * Licensed to the Apache So

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5092: [PASS] dtype rewrite for indexing variables

tqchen commented on a change in pull request #5092: [PASS] dtype rewrite for indexing variables URL: https://github.com/apache/incubator-tvm/pull/5092#discussion_r397939075 ## File path: src/tir/pass/narrow_datatype.cc ## @@ -0,0 +1,373 @@ +/* + * Licensed to the Apache So

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5092: [PASS] dtype rewrite for indexing variables

tqchen commented on a change in pull request #5092: [PASS] dtype rewrite for indexing variables URL: https://github.com/apache/incubator-tvm/pull/5092#discussion_r397929962 ## File path: tests/python/unittest/test_tir_pass_narrow_datatype.py ## @@ -0,0 +1,128 @@ +# License

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5092: [PASS] dtype rewrite for indexing variables

tqchen commented on a change in pull request #5092: [PASS] dtype rewrite for indexing variables URL: https://github.com/apache/incubator-tvm/pull/5092#discussion_r397930633 ## File path: tests/python/unittest/test_tir_pass_narrow_datatype.py ## @@ -0,0 +1,128 @@ +# License

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5092: [PASS] dtype rewrite for indexing variables

tqchen commented on a change in pull request #5092: [PASS] dtype rewrite for indexing variables URL: https://github.com/apache/incubator-tvm/pull/5092#discussion_r397932487 ## File path: src/tir/pass/narrow_datatype.cc ## @@ -0,0 +1,373 @@ +/* + * Licensed to the Apache So

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5092: [PASS] dtype rewrite for indexing variables

tqchen commented on a change in pull request #5092: [PASS] dtype rewrite for indexing variables URL: https://github.com/apache/incubator-tvm/pull/5092#discussion_r397935092 ## File path: src/tir/pass/narrow_datatype.cc ## @@ -0,0 +1,373 @@ +/* + * Licensed to the Apache So

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5092: [PASS] dtype rewrite for indexing variables

tqchen commented on a change in pull request #5092: [PASS] dtype rewrite for indexing variables URL: https://github.com/apache/incubator-tvm/pull/5092#discussion_r397939075 ## File path: src/tir/pass/narrow_datatype.cc ## @@ -0,0 +1,373 @@ +/* + * Licensed to the Apache So

[GitHub] [incubator-tvm] tqchen commented on issue #5092: [PASS] dtype rewrite for indexing variables

tqchen commented on issue #5092: [PASS] dtype rewrite for indexing variables URL: https://github.com/apache/incubator-tvm/pull/5092#issuecomment-603902373 Some more comments, mainly wrt to clarity of the code, test coverage and efficiency concerns. Thanks for bringing in the PR. given that

[GitHub] [incubator-tvm] tqchen commented on issue #5092: [TIR][PASS] dtype rewrite for indexing variables

tqchen commented on issue #5092: [TIR][PASS] dtype rewrite for indexing variables URL: https://github.com/apache/incubator-tvm/pull/5092#issuecomment-603902755 @spectrometerHBH @FrozenGene @Hzfengsy please also help to take a look ---

[GitHub] [incubator-tvm] tqchen edited a comment on issue #5092: [TIR][PASS] dtype rewrite for indexing variables

tqchen edited a comment on issue #5092: [TIR][PASS] dtype rewrite for indexing variables URL: https://github.com/apache/incubator-tvm/pull/5092#issuecomment-603902373 Some more comments, mainly wrt to clarity of the code, test coverage and efficiency concerns. Thanks for bringing in the PR

[GitHub] [incubator-tvm] siju-samuel opened a new pull request #5147: [CRT]crt error handling

siju-samuel opened a new pull request #5147: [CRT]crt error handling URL: https://github.com/apache/incubator-tvm/pull/5147 @liangfu @tmoreau89 Please help to review. TIA Most of the places error was not returned to caller and the function will continue to execute and cause some excepti

[GitHub] [incubator-tvm] tqchen commented on issue #5052: Relay to ONNX converter

tqchen commented on issue #5052: Relay to ONNX converter URL: https://github.com/apache/incubator-tvm/pull/5052#issuecomment-603908227 I agree that target is possibly a better name This is an automated message from the Apache

[GitHub] [incubator-tvm] tqchen edited a comment on issue #5052: Relay to ONNX converter

tqchen edited a comment on issue #5052: Relay to ONNX converter URL: https://github.com/apache/incubator-tvm/pull/5052#issuecomment-603908227 I agree that target is possibly a better name, we can discuss in the RFC This is an

[GitHub] [incubator-tvm] Hzfengsy commented on a change in pull request #5092: [TIR][PASS] dtype rewrite for indexing variables

Hzfengsy commented on a change in pull request #5092: [TIR][PASS] dtype rewrite for indexing variables URL: https://github.com/apache/incubator-tvm/pull/5092#discussion_r397949397 ## File path: src/tir/pass/unroll_loop.cc ## @@ -160,7 +160,9 @@ class LoopUnroller : public

[GitHub] [incubator-tvm] tqchen commented on issue #5060: [uTVM][Runtime] Deprecate uTVM Standalone Runtime

tqchen commented on issue #5060: [uTVM][Runtime] Deprecate uTVM Standalone Runtime URL: https://github.com/apache/incubator-tvm/issues/5060#issuecomment-603910501 @liangfu can you try to do a arena based approach given that it is simpler? We could adopt the counter based approach to enable

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #5143: [RELAY] Re-wrote the Graph Partitioner to support multiple outputs

zhiics commented on a change in pull request #5143: [RELAY] Re-wrote the Graph Partitioner to support multiple outputs URL: https://github.com/apache/incubator-tvm/pull/5143#discussion_r397982123 ## File path: tests/python/relay/test_pass_partition_graph.py ## @@ -678,6 +6

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #5143: [RELAY] Re-wrote the Graph Partitioner to support multiple outputs

zhiics commented on a change in pull request #5143: [RELAY] Re-wrote the Graph Partitioner to support multiple outputs URL: https://github.com/apache/incubator-tvm/pull/5143#discussion_r397973058 ## File path: src/relay/transforms/partition_graph.cc ## @@ -36,36 +36,23 @@

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #5143: [RELAY] Re-wrote the Graph Partitioner to support multiple outputs

zhiics commented on a change in pull request #5143: [RELAY] Re-wrote the Graph Partitioner to support multiple outputs URL: https://github.com/apache/incubator-tvm/pull/5143#discussion_r397975848 ## File path: src/relay/transforms/partition_graph.cc ## @@ -102,61 +89,71 @@

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #5143: [RELAY] Re-wrote the Graph Partitioner to support multiple outputs

zhiics commented on a change in pull request #5143: [RELAY] Re-wrote the Graph Partitioner to support multiple outputs URL: https://github.com/apache/incubator-tvm/pull/5143#discussion_r397980929 ## File path: src/relay/transforms/partition_graph.cc ## @@ -364,36 +388,114

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #5143: [RELAY] Re-wrote the Graph Partitioner to support multiple outputs

zhiics commented on a change in pull request #5143: [RELAY] Re-wrote the Graph Partitioner to support multiple outputs URL: https://github.com/apache/incubator-tvm/pull/5143#discussion_r397979319 ## File path: src/relay/transforms/partition_graph.cc ## @@ -165,101 +162,142

[GitHub] [incubator-tvm] FrozenGene opened a new pull request #5148: [Strategy][ARM CPU] Low the plevel of contrib spatial pack of depthwise conv

FrozenGene opened a new pull request #5148: [Strategy][ARM CPU] Low the plevel of contrib spatial pack of depthwise conv URL: https://github.com/apache/incubator-tvm/pull/5148 The spatial pack schedule of depthwise convolution is under the tag of `contrib` before introducing op strategy. H

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #5134: [RELAY] Add MergeCompilerRegions pass

zhiics commented on a change in pull request #5134: [RELAY] Add MergeCompilerRegions pass URL: https://github.com/apache/incubator-tvm/pull/5134#discussion_r397991560 ## File path: src/relay/transforms/merge_compiler_regions.cc ## @@ -0,0 +1,352 @@ +/* + * Licensed to the

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #5134: [RELAY] Add MergeCompilerRegions pass

zhiics commented on a change in pull request #5134: [RELAY] Add MergeCompilerRegions pass URL: https://github.com/apache/incubator-tvm/pull/5134#discussion_r397998462 ## File path: src/relay/transforms/merge_compiler_regions.cc ## @@ -0,0 +1,352 @@ +/* + * Licensed to the

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #5134: [RELAY] Add MergeCompilerRegions pass

zhiics commented on a change in pull request #5134: [RELAY] Add MergeCompilerRegions pass URL: https://github.com/apache/incubator-tvm/pull/5134#discussion_r397993884 ## File path: src/relay/transforms/merge_compiler_regions.cc ## @@ -0,0 +1,352 @@ +/* + * Licensed to the

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #5134: [RELAY] Add MergeCompilerRegions pass

zhiics commented on a change in pull request #5134: [RELAY] Add MergeCompilerRegions pass URL: https://github.com/apache/incubator-tvm/pull/5134#discussion_r397994225 ## File path: src/relay/transforms/merge_compiler_regions.cc ## @@ -0,0 +1,352 @@ +/* + * Licensed to the

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #5134: [RELAY] Add MergeCompilerRegions pass

zhiics commented on a change in pull request #5134: [RELAY] Add MergeCompilerRegions pass URL: https://github.com/apache/incubator-tvm/pull/5134#discussion_r397987916 ## File path: src/relay/transforms/annotate_target.cc ## @@ -38,46 +38,144 @@ class AnnotateTargetWrapper

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #5134: [RELAY] Add MergeCompilerRegions pass

zhiics commented on a change in pull request #5134: [RELAY] Add MergeCompilerRegions pass URL: https://github.com/apache/incubator-tvm/pull/5134#discussion_r397986878 ## File path: src/relay/transforms/annotate_target.cc ## @@ -38,46 +38,144 @@ class AnnotateTargetWrapper

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #5134: [RELAY] Add MergeCompilerRegions pass

zhiics commented on a change in pull request #5134: [RELAY] Add MergeCompilerRegions pass URL: https://github.com/apache/incubator-tvm/pull/5134#discussion_r397992472 ## File path: src/relay/transforms/merge_compiler_regions.cc ## @@ -0,0 +1,352 @@ +/* + * Licensed to the

[GitHub] [incubator-tvm] zhiics commented on issue #5030: [RELAY] Added a AnnotatedRegion utility class

zhiics commented on issue #5030: [RELAY] Added a AnnotatedRegion utility class URL: https://github.com/apache/incubator-tvm/pull/5030#issuecomment-603949577 @jwfromm could you PTAL? This is an automated message from the Apache

[GitHub] [incubator-tvm] ANSHUMAN87 opened a new pull request #5149: [WIP][Relay][Frontend] Chainer frontend introduced

ANSHUMAN87 opened a new pull request #5149: [WIP][Relay][Frontend] Chainer frontend introduced URL: https://github.com/apache/incubator-tvm/pull/5149 Chainer frontend is added among other Relay frontends. Note: This is just a skeleton now. And it is under active development. Pleas

[GitHub] [incubator-tvm] FrozenGene commented on issue #5148: [Strategy][ARM CPU] Remove contrib spatial pack schedule of depthwise convolution

FrozenGene commented on issue #5148: [Strategy][ARM CPU] Remove contrib spatial pack schedule of depthwise convolution URL: https://github.com/apache/incubator-tvm/pull/5148#issuecomment-603956217 After thinking it a bit more, lower the plevel could only change the default schedule. Howeve

[GitHub] [incubator-tvm] comaniac commented on issue #5148: [Strategy][ARM CPU] Remove contrib spatial pack schedule of depthwise convolution

comaniac commented on issue #5148: [Strategy][ARM CPU] Remove contrib spatial pack schedule of depthwise convolution URL: https://github.com/apache/incubator-tvm/pull/5148#issuecomment-603961524 > After thinking it a bit more, lower the plevel could only change the default schedule. Howeve

[GitHub] [incubator-tvm] yzhliu commented on a change in pull request #5092: [TIR][PASS] dtype rewrite for indexing variables

yzhliu commented on a change in pull request #5092: [TIR][PASS] dtype rewrite for indexing variables URL: https://github.com/apache/incubator-tvm/pull/5092#discussion_r398041071 ## File path: src/tir/pass/narrow_datatype.cc ## @@ -0,0 +1,373 @@ +/* + * Licensed to the Apac

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #5134: [RELAY] Add MergeCompilerRegions pass

comaniac commented on a change in pull request #5134: [RELAY] Add MergeCompilerRegions pass URL: https://github.com/apache/incubator-tvm/pull/5134#discussion_r398041335 ## File path: src/relay/transforms/merge_compiler_regions.cc ## @@ -0,0 +1,352 @@ +/* + * Licensed to th

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #5134: [RELAY] Add MergeCompilerRegions pass

comaniac commented on a change in pull request #5134: [RELAY] Add MergeCompilerRegions pass URL: https://github.com/apache/incubator-tvm/pull/5134#discussion_r398051666 ## File path: src/relay/transforms/merge_compiler_regions.cc ## @@ -0,0 +1,352 @@ +/* + * Licensed to th

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #5134: [RELAY] Add MergeCompilerRegions pass

comaniac commented on a change in pull request #5134: [RELAY] Add MergeCompilerRegions pass URL: https://github.com/apache/incubator-tvm/pull/5134#discussion_r398037445 ## File path: src/relay/transforms/merge_compiler_regions.cc ## @@ -0,0 +1,352 @@ +/* + * Licensed to th

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #5134: [RELAY] Add MergeCompilerRegions pass

comaniac commented on a change in pull request #5134: [RELAY] Add MergeCompilerRegions pass URL: https://github.com/apache/incubator-tvm/pull/5134#discussion_r398044599 ## File path: src/relay/transforms/merge_compiler_regions.cc ## @@ -0,0 +1,352 @@ +/* + * Licensed to th

[GitHub] [incubator-tvm] selo1412 commented on issue #5131: [Relay][OP] Register topi schedule for Relay fast_exp and fast_tanh

selo1412 commented on issue #5131: [Relay][OP] Register topi schedule for Relay fast_exp and fast_tanh URL: https://github.com/apache/incubator-tvm/pull/5131#issuecomment-603995475 @comaniac @icemelon9 I took tvm/tests/python/relay/test_pass_fast_math.py tvm/topi/tests/python/tes

[GitHub] [incubator-tvm] icemelon9 commented on issue #5148: [Strategy][ARM CPU] Remove contrib spatial pack schedule of depthwise convolution

icemelon9 commented on issue #5148: [Strategy][ARM CPU] Remove contrib spatial pack schedule of depthwise convolution URL: https://github.com/apache/incubator-tvm/pull/5148#issuecomment-603999626 Yes, let's comment out this implementation temporarily. Could you add a Todo with pointer to t

[GitHub] [incubator-tvm] icemelon9 commented on a change in pull request #5131: [Relay][OP] Register topi schedule for Relay fast_exp and fast_tanh

icemelon9 commented on a change in pull request #5131: [Relay][OP] Register topi schedule for Relay fast_exp and fast_tanh URL: https://github.com/apache/incubator-tvm/pull/5131#discussion_r398075515 ## File path: tests/python/relay/test_op_fast_math.py ## @@ -0,0 +1,58 @@

[GitHub] [incubator-tvm] trevor-m commented on a change in pull request #5106: [Relay][MergeComposite] Support TupleGetItem in body of pattern

trevor-m commented on a change in pull request #5106: [Relay][MergeComposite] Support TupleGetItem in body of pattern URL: https://github.com/apache/incubator-tvm/pull/5106#discussion_r398106710 ## File path: src/relay/transforms/merge_composite.cc ## @@ -66,6 +66,31 @@ cl

[GitHub] [incubator-tvm] mbaret commented on a change in pull request #5106: [Relay][MergeComposite] Support TupleGetItem in body of pattern

mbaret commented on a change in pull request #5106: [Relay][MergeComposite] Support TupleGetItem in body of pattern URL: https://github.com/apache/incubator-tvm/pull/5106#discussion_r398109720 ## File path: src/relay/transforms/merge_composite.cc ## @@ -66,6 +66,31 @@ clas

[GitHub] [incubator-tvm] mbaret commented on a change in pull request #5106: [Relay][MergeComposite] Support TupleGetItem in body of pattern

mbaret commented on a change in pull request #5106: [Relay][MergeComposite] Support TupleGetItem in body of pattern URL: https://github.com/apache/incubator-tvm/pull/5106#discussion_r398110062 ## File path: src/relay/transforms/merge_composite.cc ## @@ -66,6 +66,31 @@ clas

[GitHub] [incubator-tvm] Robeast commented on issue #5145: [BUG][TUTORIAL] Tutorial for quantization need update

Robeast commented on issue #5145: [BUG][TUTORIAL] Tutorial for quantization need update URL: https://github.com/apache/incubator-tvm/issues/5145#issuecomment-604048230 @tqchen I'm extremely ashamed to say this, but due to company policy I'm not allowed to contribute to anything other than

[GitHub] [incubator-tvm] vinx13 opened a new pull request #5150: [Tutorial][Quantization] Fix incorrect name of calibration mode

vinx13 opened a new pull request #5150: [Tutorial][Quantization] Fix incorrect name of calibration mode URL: https://github.com/apache/incubator-tvm/pull/5150 Fix #5145 @Robeast @tqchen This is an automated message f

[GitHub] [incubator-tvm] tqchen commented on issue #5145: [BUG][TUTORIAL] Tutorial for quantization need update

tqchen commented on issue #5145: [BUG][TUTORIAL] Tutorial for quantization need update URL: https://github.com/apache/incubator-tvm/issues/5145#issuecomment-604050409 no problem, thanks @Robeast for reporting the problem :)

[GitHub] [incubator-tvm] trevor-m commented on issue #5146: Handle empty LLVMModule in GetFunction

trevor-m commented on issue #5146: Handle empty LLVMModule in GetFunction URL: https://github.com/apache/incubator-tvm/pull/5146#issuecomment-604059024 Thanks @kumasento ! I have confirmed that this fixes my issue with external codegen. -

[GitHub] [incubator-tvm] Robeast commented on issue #5145: [BUG][TUTORIAL] Tutorial for quantization need update

Robeast commented on issue #5145: [BUG][TUTORIAL] Tutorial for quantization need update URL: https://github.com/apache/incubator-tvm/issues/5145#issuecomment-604081129 Thank you for your understanding... And thank you very much for @vinx13 for fixing!

[GitHub] [incubator-tvm] jwfromm commented on a change in pull request #5099: [TOPI][Tensor Core] Conv2d and Dense ops support on Tensor Core

jwfromm commented on a change in pull request #5099: [TOPI][Tensor Core] Conv2d and Dense ops support on Tensor Core URL: https://github.com/apache/incubator-tvm/pull/5099#discussion_r395912368 ## File path: topi/python/topi/cuda/conv2d_nhwc_tensorcore.py ## @@ -0,0 +1,361

[GitHub] [incubator-tvm] masahi commented on issue #5149: [WIP][Relay][Frontend] Chainer frontend introduced

masahi commented on issue #5149: [WIP][Relay][Frontend] Chainer frontend introduced URL: https://github.com/apache/incubator-tvm/pull/5149#issuecomment-604095365 You should first send a RFC on why you want to add this frontend. I don't think it is a good idea for the following reasons:

[GitHub] [incubator-tvm] yzhliu commented on issue #5121: [TE] reverse-mode autodiff without any optimization

yzhliu commented on issue #5121: [TE] reverse-mode autodiff without any optimization URL: https://github.com/apache/incubator-tvm/pull/5121#issuecomment-604099502 CI's green. @tqchen @hzfan check if there's anything needs to be addressed. ---

[GitHub] [incubator-tvm] masahi edited a comment on issue #5149: [WIP][Relay][Frontend] Chainer frontend introduced

masahi edited a comment on issue #5149: [WIP][Relay][Frontend] Chainer frontend introduced URL: https://github.com/apache/incubator-tvm/pull/5149#issuecomment-604095365 You should first send a RFC on why you want to add this frontend. I don't think it is a good idea for the following reaso

[GitHub] [incubator-tvm] zhiics merged pull request #5084: Duplicate likely nodes added when loop axis split unevenly

zhiics merged pull request #5084: Duplicate likely nodes added when loop axis split unevenly URL: https://github.com/apache/incubator-tvm/pull/5084 This is an automated message from the Apache Git Service. To respond to the

[incubator-tvm] branch master updated (3aabbd9 -> 0c38b91)

This is an automated email from the ASF dual-hosted git repository. zhic pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 3aabbd9 [Torch] Add support for max_pool1d (#5142) add 0c38b91 Duplicate likely nodes added when loop axi

[GitHub] [incubator-tvm] zhiics commented on issue #5084: Duplicate likely nodes added when loop axis split unevenly

zhiics commented on issue #5084: Duplicate likely nodes added when loop axis split unevenly URL: https://github.com/apache/incubator-tvm/pull/5084#issuecomment-604104881 Thanks @ANSHUMAN87 @MarisaKirisame @yzhliu This is an

[GitHub] [incubator-tvm] vinx13 merged pull request #5150: [Tutorial][Quantization] Fix incorrect name of calibration mode

vinx13 merged pull request #5150: [Tutorial][Quantization] Fix incorrect name of calibration mode URL: https://github.com/apache/incubator-tvm/pull/5150 This is an automated message from the Apache Git Service. To respond to

[incubator-tvm] branch master updated: [Tutorial][Quantization] Fix incorrect name of calibration mode (#5150)

This is an automated email from the ASF dual-hosted git repository. wuwei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git The following commit(s) were added to refs/heads/master by this push: new a1d6fc9 [Tutorial][Quantization] Fix inco

[GitHub] [incubator-tvm] vinx13 closed issue #5145: [BUG][TUTORIAL] Tutorial for quantization need update

vinx13 closed issue #5145: [BUG][TUTORIAL] Tutorial for quantization need update URL: https://github.com/apache/incubator-tvm/issues/5145 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-tvm] liangfu commented on a change in pull request #5147: [RUNTIME]crt error handling

liangfu commented on a change in pull request #5147: [RUNTIME]crt error handling URL: https://github.com/apache/incubator-tvm/pull/5147#discussion_r398233351 ## File path: src/runtime/crt/graph_runtime.c ## @@ -38,25 +38,28 @@ uint32_t Shape_Accumulate(int64_t * shape, uint

[GitHub] [incubator-tvm] liangfu commented on a change in pull request #5147: [RUNTIME]crt error handling

liangfu commented on a change in pull request #5147: [RUNTIME]crt error handling URL: https://github.com/apache/incubator-tvm/pull/5147#discussion_r398234478 ## File path: src/runtime/crt/graph_runtime.c ## @@ -38,25 +38,28 @@ uint32_t Shape_Accumulate(int64_t * shape, uint

[GitHub] [incubator-tvm] liangfu commented on issue #5060: [uTVM][Runtime] Deprecate uTVM Standalone Runtime

liangfu commented on issue #5060: [uTVM][Runtime] Deprecate uTVM Standalone Runtime URL: https://github.com/apache/incubator-tvm/issues/5060#issuecomment-604163218 Sure, as this is definitely the direction we should follow, I can do that. And maybe we need a separate PR for the arena alloc

[GitHub] [incubator-tvm] yzhliu opened a new pull request #5151: [Doc] TVM release process

yzhliu opened a new pull request #5151: [Doc] TVM release process URL: https://github.com/apache/incubator-tvm/pull/5151 @tqchen This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-tvm] selo1412 commented on issue #5131: [Relay][OP] Register topi schedule for Relay fast_exp and fast_tanh

selo1412 commented on issue #5131: [Relay][OP] Register topi schedule for Relay fast_exp and fast_tanh URL: https://github.com/apache/incubator-tvm/pull/5131#issuecomment-604183798 @comaniac @icemelon9 Thanks for your help. And, what should I do next? By the way, I find that

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5092: [TIR][PASS] dtype rewrite for indexing variables

tqchen commented on a change in pull request #5092: [TIR][PASS] dtype rewrite for indexing variables URL: https://github.com/apache/incubator-tvm/pull/5092#discussion_r398275074 ## File path: src/tir/pass/narrow_datatype.cc ## @@ -0,0 +1,373 @@ +/* + * Licensed to the Apac

[GitHub] [incubator-tvm] FrozenGene commented on issue #5148: [Strategy][ARM CPU] Remove contrib spatial pack schedule of depthwise convolution

FrozenGene commented on issue #5148: [Strategy][ARM CPU] Remove contrib spatial pack schedule of depthwise convolution URL: https://github.com/apache/incubator-tvm/pull/5148#issuecomment-604186487 > Yes, let's comment out this implementation temporarily. Could you add a Todo with pointer t

[GitHub] [incubator-tvm] FrozenGene merged pull request #5146: Handle empty LLVMModule in GetFunction

FrozenGene merged pull request #5146: Handle empty LLVMModule in GetFunction URL: https://github.com/apache/incubator-tvm/pull/5146 This is an automated message from the Apache Git Service. To respond to the message, please l

[incubator-tvm] branch master updated: Handle empty LLVMModule in GetFunction (#5146)

This is an automated email from the ASF dual-hosted git repository. zhaowu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git The following commit(s) were added to refs/heads/master by this push: new 08b38be Handle empty LLVMModule in GetFu

[GitHub] [incubator-tvm] FrozenGene commented on issue #5146: Handle empty LLVMModule in GetFunction

FrozenGene commented on issue #5146: Handle empty LLVMModule in GetFunction URL: https://github.com/apache/incubator-tvm/pull/5146#issuecomment-604187370 Thanks @kumasento for fixing it. Thanks @trevor-m @zhiics for verifying and reviewing.

[GitHub] [incubator-tvm] selo1412 edited a comment on issue #5131: [Relay][OP] Register topi schedule for Relay fast_exp and fast_tanh

selo1412 edited a comment on issue #5131: [Relay][OP] Register topi schedule for Relay fast_exp and fast_tanh URL: https://github.com/apache/incubator-tvm/pull/5131#issuecomment-604183798 @comaniac @icemelon9 Thanks for your help. And, what should I do next? By the way, I find

[GitHub] [incubator-tvm] icemelon9 commented on issue #5131: [Relay][OP] Register topi schedule for Relay fast_exp and fast_tanh

icemelon9 commented on issue #5131: [Relay][OP] Register topi schedule for Relay fast_exp and fast_tanh URL: https://github.com/apache/incubator-tvm/pull/5131#issuecomment-604206058 Yes, could you also add fast_tanh in the test_fastmath?

[incubator-tvm] branch master updated: [Strategy][ARM CPU] Remove contrib spatial pack schedule of depthwise convolution (#5148)

This is an automated email from the ASF dual-hosted git repository. zhaowu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git The following commit(s) were added to refs/heads/master by this push: new 314f31b [Strategy][ARM CPU] Remove contr

[GitHub] [incubator-tvm] FrozenGene merged pull request #5148: [Strategy][ARM CPU] Remove contrib spatial pack schedule of depthwise convolution

FrozenGene merged pull request #5148: [Strategy][ARM CPU] Remove contrib spatial pack schedule of depthwise convolution URL: https://github.com/apache/incubator-tvm/pull/5148 This is an automated message from the Apache Git

[GitHub] [incubator-tvm] FrozenGene commented on issue #5148: [Strategy][ARM CPU] Remove contrib spatial pack schedule of depthwise convolution

FrozenGene commented on issue #5148: [Strategy][ARM CPU] Remove contrib spatial pack schedule of depthwise convolution URL: https://github.com/apache/incubator-tvm/pull/5148#issuecomment-604232873 Thanks @icemelon9 @comaniac for reviewing and giving advices. ---