[GitHub] [hadoop] harshavardhana commented on issue #654: HADOOP-15183 S3Guard store becomes inconsistent after partial failure of rename

2019-04-26 Thread GitBox
harshavardhana commented on issue #654: HADOOP-15183 S3Guard store becomes inconsistent after partial failure of rename URL: https://github.com/apache/hadoop/pull/654#issuecomment-487256432 @steveloughran how much performance improvement is expected after this change is taken in? ---

[GitHub] [hadoop] ajayydv commented on issue #777: HDDS-1471. Update ratis dependency to 0.3.0. Contributed by Ajay Kumar.

2019-04-26 Thread GitBox
ajayydv commented on issue #777: HDDS-1471. Update ratis dependency to 0.3.0. Contributed by Ajay Kumar. URL: https://github.com/apache/hadoop/pull/777#issuecomment-487241855 /retest This is an automated message from the Apac

[jira] [Commented] (HADOOP-14444) New implementation of ftp and sftp filesystems

2019-04-26 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16827362#comment-16827362 ] Hadoop QA commented on HADOOP-1: | (x) *{color:red}-1 overall{color}* | \\ \\ |

[jira] [Commented] (HADOOP-16266) Add more fine-grained processing time metrics to the RPC layer

2019-04-26 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16827363#comment-16827363 ] Hadoop QA commented on HADOOP-16266: | (x) *{color:red}-1 overall{color}* | \\ \\ |

[GitHub] [hadoop] hadoop-yetus commented on issue #777: HDDS-1471. Update ratis dependency to 0.3.0. Contributed by Ajay Kumar.

2019-04-26 Thread GitBox
hadoop-yetus commented on issue #777: HDDS-1471. Update ratis dependency to 0.3.0. Contributed by Ajay Kumar. URL: https://github.com/apache/hadoop/pull/777#issuecomment-487224907 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--

[GitHub] [hadoop] steveloughran edited a comment on issue #666: HADOOP-16221 add option to fail operation on metadata write failure

2019-04-26 Thread GitBox
steveloughran edited a comment on issue #666: HADOOP-16221 add option to fail operation on metadata write failure URL: https://github.com/apache/hadoop/pull/666#issuecomment-487220946 I've just been retesting this...happy with the changes in the operation, just two things I want to make su

[GitHub] [hadoop] steveloughran commented on issue #666: HADOOP-16221 add option to fail operation on metadata write failure

2019-04-26 Thread GitBox
steveloughran commented on issue #666: HADOOP-16221 add option to fail operation on metadata write failure URL: https://github.com/apache/hadoop/pull/666#issuecomment-487220946 I've just been retesting this...happy with the changes in the operation, just two things I want to make sure we a

[GitHub] [hadoop] steveloughran commented on a change in pull request #666: HADOOP-16221 add option to fail operation on metadata write failure

2019-04-26 Thread GitBox
steveloughran commented on a change in pull request #666: HADOOP-16221 add option to fail operation on metadata write failure URL: https://github.com/apache/hadoop/pull/666#discussion_r279118899 ## File path: hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/Retries.ja

[GitHub] [hadoop] hadoop-yetus commented on issue #778: HDDS-1472. Add retry to kinit command in smoketests. Contributed by Ajay Kumar.

2019-04-26 Thread GitBox
hadoop-yetus commented on issue #778: HDDS-1472. Add retry to kinit command in smoketests. Contributed by Ajay Kumar. URL: https://github.com/apache/hadoop/pull/778#issuecomment-487206968 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |:

[GitHub] [hadoop] bharatviswa504 merged pull request #769: HDDS-1456. Stop the datanode, when any datanode statemachine state is…

2019-04-26 Thread GitBox
bharatviswa504 merged pull request #769: HDDS-1456. Stop the datanode, when any datanode statemachine state is… URL: https://github.com/apache/hadoop/pull/769 This is an automated message from the Apache Git Service. To resp

[GitHub] [hadoop] hadoop-yetus commented on issue #768: HADOOP-16269. ABFS: add listFileStatus with StartFrom.

2019-04-26 Thread GitBox
hadoop-yetus commented on issue #768: HADOOP-16269. ABFS: add listFileStatus with StartFrom. URL: https://github.com/apache/hadoop/pull/768#issuecomment-487201733 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|---

[GitHub] [hadoop] xiaoyuyao commented on issue #778: HDDS-1472. Add retry to kinit command in smoketests. Contributed by Ajay Kumar.

2019-04-26 Thread GitBox
xiaoyuyao commented on issue #778: HDDS-1472. Add retry to kinit command in smoketests. Contributed by Ajay Kumar. URL: https://github.com/apache/hadoop/pull/778#issuecomment-487197560 +1 pending Jenkins. Thanks for fixing this @ajayydv.

[GitHub] [hadoop] anuengineer commented on issue #777: HDDS-1471. Update ratis dependency to 0.3.0. Contributed by Ajay Kumar.

2019-04-26 Thread GitBox
anuengineer commented on issue #777: HDDS-1471. Update ratis dependency to 0.3.0. Contributed by Ajay Kumar. URL: https://github.com/apache/hadoop/pull/777#issuecomment-487195062 +1, Thanks for getting this done. Appreciate it. --

[GitHub] [hadoop] ajayydv opened a new pull request #778: HDDS-1472. Add retry to kinit command in smoketests. Contributed by Ajay Kumar.

2019-04-26 Thread GitBox
ajayydv opened a new pull request #778: HDDS-1472. Add retry to kinit command in smoketests. Contributed by Ajay Kumar. URL: https://github.com/apache/hadoop/pull/778 This is an automated message from the Apache Git Service.

[GitHub] [hadoop] ajayydv opened a new pull request #777: HDDS-1471. Update ratis dependency to 0.3.0. Contributed by Ajay Kumar.

2019-04-26 Thread GitBox
ajayydv opened a new pull request #777: HDDS-1471. Update ratis dependency to 0.3.0. Contributed by Ajay Kumar. URL: https://github.com/apache/hadoop/pull/777 This is an automated message from the Apache Git Service. To resp

[GitHub] [hadoop] dineshchitlangia closed pull request #603: HADOOP-16026:Replace incorrect use of system property user.name

2019-04-26 Thread GitBox
dineshchitlangia closed pull request #603: HADOOP-16026:Replace incorrect use of system property user.name URL: https://github.com/apache/hadoop/pull/603 This is an automated message from the Apache Git Service. To respond t

[GitHub] [hadoop] hadoop-yetus commented on issue #603: HADOOP-16026:Replace incorrect use of system property user.name

2019-04-26 Thread GitBox
hadoop-yetus commented on issue #603: HADOOP-16026:Replace incorrect use of system property user.name URL: https://github.com/apache/hadoop/pull/603#issuecomment-487189875 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--

[jira] [Commented] (HADOOP-16026) Replace incorrect use of system property user.name

2019-04-26 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16827297#comment-16827297 ] Hadoop QA commented on HADOOP-16026: | (x) *{color:red}-1 overall{color}* | \\ \\ |

[GitHub] [hadoop] hadoop-yetus commented on issue #776: HADOOP-16242. ABFS: add bufferpool to AbfsOutputStream

2019-04-26 Thread GitBox
hadoop-yetus commented on issue #776: HADOOP-16242. ABFS: add bufferpool to AbfsOutputStream URL: https://github.com/apache/hadoop/pull/776#issuecomment-487186614 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|---

[GitHub] [hadoop] bharatviswa504 commented on issue #714: HDDS-1406. Avoid usage of commonPool in RatisPipelineUtils.

2019-04-26 Thread GitBox
bharatviswa504 commented on issue #714: HDDS-1406. Avoid usage of commonPool in RatisPipelineUtils. URL: https://github.com/apache/hadoop/pull/714#issuecomment-487179072 Test failures are not related to this patch. I will commit this shortly.

[jira] [Updated] (HADOOP-14444) New implementation of ftp and sftp filesystems

2019-04-26 Thread Lukas Waldmann (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lukas Waldmann updated HADOOP-1: Status: Patch Available (was: Open) > New implementation of ftp and sftp filesystems > -

[jira] [Updated] (HADOOP-14444) New implementation of ftp and sftp filesystems

2019-04-26 Thread Lukas Waldmann (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lukas Waldmann updated HADOOP-1: Status: Open (was: Patch Available) > New implementation of ftp and sftp filesystems > -

[jira] [Updated] (HADOOP-14444) New implementation of ftp and sftp filesystems

2019-04-26 Thread Lukas Waldmann (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lukas Waldmann updated HADOOP-1: Attachment: HADOOP-1.16.patch > New implementation of ftp and sftp filesystems >

[GitHub] [hadoop] hadoop-yetus commented on issue #768: HADOOP-16269. ABFS: add listFileStatus with StartFrom.

2019-04-26 Thread GitBox
hadoop-yetus commented on issue #768: HADOOP-16269. ABFS: add listFileStatus with StartFrom. URL: https://github.com/apache/hadoop/pull/768#issuecomment-487176634 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|--

[GitHub] [hadoop] steveloughran commented on a change in pull request #609: HADOOP-16193. add extra S3A MPU test to see what happens if a file is created during the MPU

2019-04-26 Thread GitBox
steveloughran commented on a change in pull request #609: HADOOP-16193. add extra S3A MPU test to see what happens if a file is created during the MPU URL: https://github.com/apache/hadoop/pull/609#discussion_r279073402 ## File path: hadoop-tools/hadoop-aws/src/test/java/org/apache

[jira] [Commented] (HADOOP-16242) ABFS: add bufferpool to AbfsOutputStream

2019-04-26 Thread Da Zhou (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16827238#comment-16827238 ] Da Zhou commented on HADOOP-16242: -- Opened PR using github: https://github.com/apache/

[GitHub] [hadoop] DadanielZ opened a new pull request #776: HADOOP-16242. ABFS: add bufferpool to AbfsOutputStream

2019-04-26 Thread GitBox
DadanielZ opened a new pull request #776: HADOOP-16242. ABFS: add bufferpool to AbfsOutputStream URL: https://github.com/apache/hadoop/pull/776 - Added bufferpool to AbfsOutPutStream to improve memory usage. - Verified performance change, results are attached in HADOOP-16242 jira. -

[jira] [Updated] (HADOOP-16266) Add more fine-grained processing time metrics to the RPC layer

2019-04-26 Thread Christopher Gregorian (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher Gregorian updated HADOOP-16266: --- Attachment: HADOOP-16266.006.patch > Add more fine-grained processing time

[GitHub] [hadoop] steveloughran commented on issue #157: HADOOP-13600. S3a rename() to copy files in a directory in parallel

2019-04-26 Thread GitBox
steveloughran commented on issue #157: HADOOP-13600. S3a rename() to copy files in a directory in parallel URL: https://github.com/apache/hadoop/pull/157#issuecomment-487167798 @harshavardhana I'm doing work on parallel renames in HADOOP-15183; the complication there is that I want to upda

[GitHub] [hadoop] DadanielZ commented on a change in pull request #768: HADOOP-16269. ABFS: add listFileStatus with StartFrom.

2019-04-26 Thread GitBox
DadanielZ commented on a change in pull request #768: HADOOP-16269. ABFS: add listFileStatus with StartFrom. URL: https://github.com/apache/hadoop/pull/768#discussion_r279069405 ## File path: hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSy

[GitHub] [hadoop] DadanielZ commented on a change in pull request #768: HADOOP-16269. ABFS: add listFileStatus with StartFrom.

2019-04-26 Thread GitBox
DadanielZ commented on a change in pull request #768: HADOOP-16269. ABFS: add listFileStatus with StartFrom. URL: https://github.com/apache/hadoop/pull/768#discussion_r279067742 ## File path: hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSy

[GitHub] [hadoop] steveloughran commented on issue #654: HADOOP-15183 S3Guard store becomes inconsistent after partial failure of rename

2019-04-26 Thread GitBox
steveloughran commented on issue #654: HADOOP-15183 S3Guard store becomes inconsistent after partial failure of rename URL: https://github.com/apache/hadoop/pull/654#issuecomment-487165270 looks like the last version doesn't compile. oops ---

[GitHub] [hadoop] DadanielZ commented on a change in pull request #768: HADOOP-16269. ABFS: add listFileStatus with StartFrom.

2019-04-26 Thread GitBox
DadanielZ commented on a change in pull request #768: HADOOP-16269. ABFS: add listFileStatus with StartFrom. URL: https://github.com/apache/hadoop/pull/768#discussion_r279067429 ## File path: hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSy

[GitHub] [hadoop] DadanielZ commented on a change in pull request #768: HADOOP-16269. ABFS: add listFileStatus with StartFrom.

2019-04-26 Thread GitBox
DadanielZ commented on a change in pull request #768: HADOOP-16269. ABFS: add listFileStatus with StartFrom. URL: https://github.com/apache/hadoop/pull/768#discussion_r279067302 ## File path: hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSy

[jira] [Commented] (HADOOP-16189) S3A copy/rename of large files to be parallelized as a multipart operation

2019-04-26 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16827218#comment-16827218 ] Steve Loughran commented on HADOOP-16189: - 1. It's just the multipart threshold

[jira] [Resolved] (HADOOP-14757) S3AFileSystem.innerRename() to size metadatastore lists better

2019-04-26 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-14757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran resolved HADOOP-14757. - Resolution: Won't Fix need to get rid of the lists entirely as it doesn't scale up enou

[GitHub] [hadoop] DadanielZ commented on a change in pull request #768: HADOOP-16269. ABFS: add listFileStatus with StartFrom.

2019-04-26 Thread GitBox
DadanielZ commented on a change in pull request #768: HADOOP-16269. ABFS: add listFileStatus with StartFrom. URL: https://github.com/apache/hadoop/pull/768#discussion_r279066413 ## File path: hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystemS

[GitHub] [hadoop] DadanielZ commented on a change in pull request #768: HADOOP-16269. ABFS: add listFileStatus with StartFrom.

2019-04-26 Thread GitBox
DadanielZ commented on a change in pull request #768: HADOOP-16269. ABFS: add listFileStatus with StartFrom. URL: https://github.com/apache/hadoop/pull/768#discussion_r279065822 ## File path: hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/utils/CRC64.java ##

[GitHub] [hadoop] DadanielZ commented on a change in pull request #768: HADOOP-16269. ABFS: add listFileStatus with StartFrom.

2019-04-26 Thread GitBox
DadanielZ commented on a change in pull request #768: HADOOP-16269. ABFS: add listFileStatus with StartFrom. URL: https://github.com/apache/hadoop/pull/768#discussion_r279064389 ## File path: hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystemS

[jira] [Comment Edited] (HADOOP-16214) Kerberos name implementation in Hadoop does not accept principals with more than two components

2019-04-26 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16827192#comment-16827192 ] Eric Yang edited comment on HADOOP-16214 at 4/26/19 6:42 PM:

[jira] [Comment Edited] (HADOOP-16214) Kerberos name implementation in Hadoop does not accept principals with more than two components

2019-04-26 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16827192#comment-16827192 ] Eric Yang edited comment on HADOOP-16214 at 4/26/19 6:41 PM:

[jira] [Comment Edited] (HADOOP-16214) Kerberos name implementation in Hadoop does not accept principals with more than two components

2019-04-26 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16827192#comment-16827192 ] Eric Yang edited comment on HADOOP-16214 at 4/26/19 6:36 PM:

[jira] [Commented] (HADOOP-16214) Kerberos name implementation in Hadoop does not accept principals with more than two components

2019-04-26 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16827192#comment-16827192 ] Eric Yang commented on HADOOP-16214: [~ibuenros] {quote}Is it the case that adding

[jira] [Commented] (HADOOP-16214) Kerberos name implementation in Hadoop does not accept principals with more than two components

2019-04-26 Thread Issac Buenrostro (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16827162#comment-16827162 ] Issac Buenrostro commented on HADOOP-16214: --- [~eyang] thanks for the security

[GitHub] [hadoop] hanishakoneru merged pull request #753: HDDS-1403. KeyOutputStream writes fails after max retries while writing to a closed container

2019-04-26 Thread GitBox
hanishakoneru merged pull request #753: HDDS-1403. KeyOutputStream writes fails after max retries while writing to a closed container URL: https://github.com/apache/hadoop/pull/753 This is an automated message from the Apach

[GitHub] [hadoop] hanishakoneru commented on issue #753: HDDS-1403. KeyOutputStream writes fails after max retries while writing to a closed container

2019-04-26 Thread GitBox
hanishakoneru commented on issue #753: HDDS-1403. KeyOutputStream writes fails after max retries while writing to a closed container URL: https://github.com/apache/hadoop/pull/753#issuecomment-487138591 The test failures in CI are not related to this PR. Will merge the PR. Thank you @arp7

[jira] [Commented] (HADOOP-16214) Kerberos name implementation in Hadoop does not accept principals with more than two components

2019-04-26 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16827146#comment-16827146 ] Eric Yang commented on HADOOP-16214: [~ibuenros] {quote}NN and other base Hadoop co

[GitHub] [hadoop] xiaoyuyao commented on a change in pull request #752: HDDS-1430. NPE if secure ozone if KMS uri is not defined. Contributed by Ajay Kumar.

2019-04-26 Thread GitBox
xiaoyuyao commented on a change in pull request #752: HDDS-1430. NPE if secure ozone if KMS uri is not defined. Contributed by Ajay Kumar. URL: https://github.com/apache/hadoop/pull/752#discussion_r279027806 ## File path: hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/cl

[GitHub] [hadoop] hadoop-yetus commented on issue #654: HADOOP-15183 S3Guard store becomes inconsistent after partial failure of rename

2019-04-26 Thread GitBox
hadoop-yetus commented on issue #654: HADOOP-15183 S3Guard store becomes inconsistent after partial failure of rename URL: https://github.com/apache/hadoop/pull/654#issuecomment-487121680 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |:

[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #654: HADOOP-15183 S3Guard store becomes inconsistent after partial failure of rename

2019-04-26 Thread GitBox
hadoop-yetus commented on a change in pull request #654: HADOOP-15183 S3Guard store becomes inconsistent after partial failure of rename URL: https://github.com/apache/hadoop/pull/654#discussion_r279022283 ## File path: hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/s3g

[jira] [Commented] (HADOOP-16266) Add more fine-grained processing time metrics to the RPC layer

2019-04-26 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16827104#comment-16827104 ] Erik Krogen commented on HADOOP-16266: -- In terms of more concrete comments on v005

[GitHub] [hadoop] hadoop-yetus commented on issue #775: HADOOP-16184. S3Guard: Handle OOB deletions and creation of a file wh…

2019-04-26 Thread GitBox
hadoop-yetus commented on issue #775: HADOOP-16184. S3Guard: Handle OOB deletions and creation of a file wh… URL: https://github.com/apache/hadoop/pull/775#issuecomment-487111052 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--

[jira] [Commented] (HADOOP-16266) Add more fine-grained processing time metrics to the RPC layer

2019-04-26 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16827074#comment-16827074 ] Erik Krogen commented on HADOOP-16266: -- Hi [~ste...@apache.org], thanks for sharin

[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #654: HADOOP-15183 S3Guard store becomes inconsistent after partial failure of rename

2019-04-26 Thread GitBox
hadoop-yetus commented on a change in pull request #654: HADOOP-15183 S3Guard store becomes inconsistent after partial failure of rename URL: https://github.com/apache/hadoop/pull/654#discussion_r279005729 ## File path: hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/s3g

[GitHub] [hadoop] hadoop-yetus commented on issue #654: HADOOP-15183 S3Guard store becomes inconsistent after partial failure of rename

2019-04-26 Thread GitBox
hadoop-yetus commented on issue #654: HADOOP-15183 S3Guard store becomes inconsistent after partial failure of rename URL: https://github.com/apache/hadoop/pull/654#issuecomment-487106243 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |:

[GitHub] [hadoop] hadoop-yetus commented on issue #654: HADOOP-15183 S3Guard store becomes inconsistent after partial failure of rename

2019-04-26 Thread GitBox
hadoop-yetus commented on issue #654: HADOOP-15183 S3Guard store becomes inconsistent after partial failure of rename URL: https://github.com/apache/hadoop/pull/654#issuecomment-487104120 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |:

[GitHub] [hadoop] steveloughran commented on a change in pull request #768: HADOOP-16269. ABFS: add listFileStatus with StartFrom.

2019-04-26 Thread GitBox
steveloughran commented on a change in pull request #768: HADOOP-16269. ABFS: add listFileStatus with StartFrom. URL: https://github.com/apache/hadoop/pull/768#discussion_r279002115 ## File path: hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFi

[GitHub] [hadoop] steveloughran commented on a change in pull request #768: HADOOP-16269. ABFS: add listFileStatus with StartFrom.

2019-04-26 Thread GitBox
steveloughran commented on a change in pull request #768: HADOOP-16269. ABFS: add listFileStatus with StartFrom. URL: https://github.com/apache/hadoop/pull/768#discussion_r279001578 ## File path: hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFi

[GitHub] [hadoop] steveloughran commented on a change in pull request #768: HADOOP-16269. ABFS: add listFileStatus with StartFrom.

2019-04-26 Thread GitBox
steveloughran commented on a change in pull request #768: HADOOP-16269. ABFS: add listFileStatus with StartFrom. URL: https://github.com/apache/hadoop/pull/768#discussion_r279000713 ## File path: hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFi

[GitHub] [hadoop] steveloughran commented on a change in pull request #768: HADOOP-16269. ABFS: add listFileStatus with StartFrom.

2019-04-26 Thread GitBox
steveloughran commented on a change in pull request #768: HADOOP-16269. ABFS: add listFileStatus with StartFrom. URL: https://github.com/apache/hadoop/pull/768#discussion_r279000195 ## File path: hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFi

[GitHub] [hadoop] steveloughran commented on a change in pull request #768: HADOOP-16269. ABFS: add listFileStatus with StartFrom.

2019-04-26 Thread GitBox
steveloughran commented on a change in pull request #768: HADOOP-16269. ABFS: add listFileStatus with StartFrom. URL: https://github.com/apache/hadoop/pull/768#discussion_r278999727 ## File path: hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/utils/CRC64.java

[GitHub] [hadoop] steveloughran commented on a change in pull request #768: HADOOP-16269. ABFS: add listFileStatus with StartFrom.

2019-04-26 Thread GitBox
steveloughran commented on a change in pull request #768: HADOOP-16269. ABFS: add listFileStatus with StartFrom. URL: https://github.com/apache/hadoop/pull/768#discussion_r278999013 ## File path: hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSys

[GitHub] [hadoop] steveloughran commented on a change in pull request #768: HADOOP-16269. ABFS: add listFileStatus with StartFrom.

2019-04-26 Thread GitBox
steveloughran commented on a change in pull request #768: HADOOP-16269. ABFS: add listFileStatus with StartFrom. URL: https://github.com/apache/hadoop/pull/768#discussion_r278997891 ## File path: hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSys

[jira] [Commented] (HADOOP-16184) S3Guard: Handle OOB deletions and creation of a file which has a tombstone marker

2019-04-26 Thread Gabor Bota (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16827033#comment-16827033 ] Gabor Bota commented on HADOOP-16184: - Created a PR with 2 initial tests for the se

[GitHub] [hadoop] bgaborg opened a new pull request #775: HADOOP-16184. S3Guard: Handle OOB deletions and creation of a file wh…

2019-04-26 Thread GitBox
bgaborg opened a new pull request #775: HADOOP-16184. S3Guard: Handle OOB deletions and creation of a file wh… URL: https://github.com/apache/hadoop/pull/775 …ich has a tombstone marker This first initial PR is to show what's happening. WIP, do not commit yet. These tests will fa

[GitHub] [hadoop] anuengineer commented on issue #773: HDDS-1469. Generate default configuration fragments based on annotations

2019-04-26 Thread GitBox
anuengineer commented on issue #773: HDDS-1469. Generate default configuration fragments based on annotations URL: https://github.com/apache/hadoop/pull/773#issuecomment-487086122 Thank you for your comments and explanations. +1. Please feel free to commit this. Thanks for getting this don

[GitHub] [hadoop] hadoop-yetus commented on issue #693: HDDS-1382. Create customized CSI server for Ozone.

2019-04-26 Thread GitBox
hadoop-yetus commented on issue #693: HDDS-1382. Create customized CSI server for Ozone. URL: https://github.com/apache/hadoop/pull/693#issuecomment-487071089 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:

[GitHub] [hadoop] hadoop-yetus commented on issue #750: HDDS-1384. TestBlockOutputStreamWithFailures is failing

2019-04-26 Thread GitBox
hadoop-yetus commented on issue #750: HDDS-1384. TestBlockOutputStreamWithFailures is failing URL: https://github.com/apache/hadoop/pull/750#issuecomment-487066181 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|--

[GitHub] [hadoop] hadoop-yetus commented on issue #772: HDDS-1468. Inject configuration values to Java objects

2019-04-26 Thread GitBox
hadoop-yetus commented on issue #772: HDDS-1468. Inject configuration values to Java objects URL: https://github.com/apache/hadoop/pull/772#issuecomment-487036271 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|---

[GitHub] [hadoop] lokeshj1703 commented on issue #765: HDDS-1460: Add the optmizations of HDDS-1300 to BasicOzoneFileSystem

2019-04-26 Thread GitBox
lokeshj1703 commented on issue #765: HDDS-1460: Add the optmizations of HDDS-1300 to BasicOzoneFileSystem URL: https://github.com/apache/hadoop/pull/765#issuecomment-487032481 @mukul1987 Thanks for reviewing the pull request! I have merged it to trunk.

[GitHub] [hadoop] lokeshj1703 merged pull request #765: HDDS-1460: Add the optmizations of HDDS-1300 to BasicOzoneFileSystem

2019-04-26 Thread GitBox
lokeshj1703 merged pull request #765: HDDS-1460: Add the optmizations of HDDS-1300 to BasicOzoneFileSystem URL: https://github.com/apache/hadoop/pull/765 This is an automated message from the Apache Git Service. To respond t

[jira] [Work started] (HADOOP-16184) S3Guard: Handle OOB deletions and creation of a file which has a tombstone marker

2019-04-26 Thread Gabor Bota (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HADOOP-16184 started by Gabor Bota. --- > S3Guard: Handle OOB deletions and creation of a file which has a tombstone >

[jira] [Updated] (HADOOP-16184) S3Guard: Handle OOB deletions and creation of a file which has a tombstone marker

2019-04-26 Thread Gabor Bota (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Bota updated HADOOP-16184: Description: When a file is deleted in S3 using S3Guard a tombstone marker will be added for tha

[GitHub] [hadoop] steveloughran commented on issue #774: HADOOP-16256: HTTPFileSystem disallows users from configuring the connectionTimeout and readTimeout of HttpClient

2019-04-26 Thread GitBox
steveloughran commented on issue #774: HADOOP-16256: HTTPFileSystem disallows users from configuring the connectionTimeout and readTimeout of HttpClient URL: https://github.com/apache/hadoop/pull/774#issuecomment-487016093 Code looks good, tests look great. Key comments * Move the

[GitHub] [hadoop] steveloughran commented on a change in pull request #774: HADOOP-16256: HTTPFileSystem disallows users from configuring the connectionTimeout and readTimeout of HttpClient

2019-04-26 Thread GitBox
steveloughran commented on a change in pull request #774: HADOOP-16256: HTTPFileSystem disallows users from configuring the connectionTimeout and readTimeout of HttpClient URL: https://github.com/apache/hadoop/pull/774#discussion_r278899372 ## File path: hadoop-common-project/hado

[GitHub] [hadoop] steveloughran commented on a change in pull request #774: HADOOP-16256: HTTPFileSystem disallows users from configuring the connectionTimeout and readTimeout of HttpClient

2019-04-26 Thread GitBox
steveloughran commented on a change in pull request #774: HADOOP-16256: HTTPFileSystem disallows users from configuring the connectionTimeout and readTimeout of HttpClient URL: https://github.com/apache/hadoop/pull/774#discussion_r278899264 ## File path: hadoop-common-project/hado

[GitHub] [hadoop] steveloughran commented on a change in pull request #774: HADOOP-16256: HTTPFileSystem disallows users from configuring the connectionTimeout and readTimeout of HttpClient

2019-04-26 Thread GitBox
steveloughran commented on a change in pull request #774: HADOOP-16256: HTTPFileSystem disallows users from configuring the connectionTimeout and readTimeout of HttpClient URL: https://github.com/apache/hadoop/pull/774#discussion_r278898659 ## File path: hadoop-common-project/hado

[GitHub] [hadoop] steveloughran commented on a change in pull request #774: HADOOP-16256: HTTPFileSystem disallows users from configuring the connectionTimeout and readTimeout of HttpClient

2019-04-26 Thread GitBox
steveloughran commented on a change in pull request #774: HADOOP-16256: HTTPFileSystem disallows users from configuring the connectionTimeout and readTimeout of HttpClient URL: https://github.com/apache/hadoop/pull/774#discussion_r278898625 ## File path: hadoop-common-project/hado

[GitHub] [hadoop] steveloughran commented on a change in pull request #774: HADOOP-16256: HTTPFileSystem disallows users from configuring the connectionTimeout and readTimeout of HttpClient

2019-04-26 Thread GitBox
steveloughran commented on a change in pull request #774: HADOOP-16256: HTTPFileSystem disallows users from configuring the connectionTimeout and readTimeout of HttpClient URL: https://github.com/apache/hadoop/pull/774#discussion_r278898398 ## File path: hadoop-common-project/hado

[GitHub] [hadoop] elek closed pull request #758: HDDS-999. Make the DNS resolution in OzoneManager more resilient. (swagle)

2019-04-26 Thread GitBox
elek closed pull request #758: HDDS-999. Make the DNS resolution in OzoneManager more resilient. (swagle) URL: https://github.com/apache/hadoop/pull/758 This is an automated message from the Apache Git Service. To respond to

[GitHub] [hadoop] steveloughran commented on a change in pull request #774: HADOOP-16256: HTTPFileSystem disallows users from configuring the connectionTimeout and readTimeout of HttpClient

2019-04-26 Thread GitBox
steveloughran commented on a change in pull request #774: HADOOP-16256: HTTPFileSystem disallows users from configuring the connectionTimeout and readTimeout of HttpClient URL: https://github.com/apache/hadoop/pull/774#discussion_r278898398 ## File path: hadoop-common-project/hado

[GitHub] [hadoop] lokeshj1703 commented on a change in pull request #714: HDDS-1406. Avoid usage of commonPool in RatisPipelineUtils.

2019-04-26 Thread GitBox
lokeshj1703 commented on a change in pull request #714: HDDS-1406. Avoid usage of commonPool in RatisPipelineUtils. URL: https://github.com/apache/hadoop/pull/714#discussion_r278896085 ## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/RatisPipel

[GitHub] [hadoop] lokeshj1703 commented on a change in pull request #714: HDDS-1406. Avoid usage of commonPool in RatisPipelineUtils.

2019-04-26 Thread GitBox
lokeshj1703 commented on a change in pull request #714: HDDS-1406. Avoid usage of commonPool in RatisPipelineUtils. URL: https://github.com/apache/hadoop/pull/714#discussion_r278895492 ## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/RatisPipel

[jira] [Commented] (HADOOP-16266) Add more fine-grained processing time metrics to the RPC layer

2019-04-26 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16826876#comment-16826876 ] Steve Loughran commented on HADOOP-16266: - see: http://steveloughran.blogspot.

[GitHub] [hadoop] hadoop-yetus commented on issue #773: HDDS-1469. Generate default configuration fragments based on annotations

2019-04-26 Thread GitBox
hadoop-yetus commented on issue #773: HDDS-1469. Generate default configuration fragments based on annotations URL: https://github.com/apache/hadoop/pull/773#issuecomment-487011937 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|-

[GitHub] [hadoop] steveloughran commented on a change in pull request #761: HADOOP-13386 Upgrade avro version in Hadoop

2019-04-26 Thread GitBox
steveloughran commented on a change in pull request #761: HADOOP-13386 Upgrade avro version in Hadoop URL: https://github.com/apache/hadoop/pull/761#discussion_r278894853 ## File path: hadoop-project/pom.xml ## @@ -62,7 +62,7 @@ file:///dev/urandom -1.7.7

[GitHub] [hadoop] steveloughran commented on a change in pull request #761: HADOOP-13386 Upgrade avro version in Hadoop

2019-04-26 Thread GitBox
steveloughran commented on a change in pull request #761: HADOOP-13386 Upgrade avro version in Hadoop URL: https://github.com/apache/hadoop/pull/761#discussion_r278894748 ## File path: hadoop-project/pom.xml ## @@ -638,6 +638,12 @@ org.apache.commons comm

[jira] [Commented] (HADOOP-13386) Upgrade Avro to 1.8.x

2019-04-26 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-13386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16826867#comment-16826867 ] Steve Loughran commented on HADOOP-13386: - +as usual, set versions on affects/t

[jira] [Commented] (HADOOP-13386) Upgrade Avro to 1.8.x

2019-04-26 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-13386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16826864#comment-16826864 ] Steve Loughran commented on HADOOP-13386: - # What extra transitive dependencies

[jira] [Commented] (HADOOP-16277) Expose getTokenKind method in FileSystem

2019-04-26 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16826840#comment-16826840 ] Steve Loughran commented on HADOOP-16277: - I see what you are trying to do here

[GitHub] [hadoop] elek commented on issue #773: HDDS-1469. Generate default configuration fragments based on annotations

2019-04-26 Thread GitBox
elek commented on issue #773: HDDS-1469. Generate default configuration fragments based on annotations URL: https://github.com/apache/hadoop/pull/773#issuecomment-487003326 > I am ok with that, but some of the old school people might like a single file, and in the deployment, phase don't w

[GitHub] [hadoop] elek commented on a change in pull request #773: HDDS-1469. Generate default configuration fragments based on annotations

2019-04-26 Thread GitBox
elek commented on a change in pull request #773: HDDS-1469. Generate default configuration fragments based on annotations URL: https://github.com/apache/hadoop/pull/773#discussion_r278882360 ## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/Rep

[GitHub] [hadoop] elek commented on a change in pull request #773: HDDS-1469. Generate default configuration fragments based on annotations

2019-04-26 Thread GitBox
elek commented on a change in pull request #773: HDDS-1469. Generate default configuration fragments based on annotations URL: https://github.com/apache/hadoop/pull/773#discussion_r278881892 ## File path: hadoop-hdds/config/src/main/java/org/apache/hadoop/hdds/conf/ConfigFileGenera

[GitHub] [hadoop] elek commented on a change in pull request #773: HDDS-1469. Generate default configuration fragments based on annotations

2019-04-26 Thread GitBox
elek commented on a change in pull request #773: HDDS-1469. Generate default configuration fragments based on annotations URL: https://github.com/apache/hadoop/pull/773#discussion_r278881642 ## File path: hadoop-hdds/config/src/main/java/org/apache/hadoop/hdds/conf/ConfigFileGenera

[GitHub] [hadoop] elek commented on a change in pull request #773: HDDS-1469. Generate default configuration fragments based on annotations

2019-04-26 Thread GitBox
elek commented on a change in pull request #773: HDDS-1469. Generate default configuration fragments based on annotations URL: https://github.com/apache/hadoop/pull/773#discussion_r278881241 ## File path: hadoop-hdds/config/pom.xml ## @@ -0,0 +1,66 @@ + + +http://maven.apa

[GitHub] [hadoop] elek commented on a change in pull request #773: HDDS-1469. Generate default configuration fragments based on annotations

2019-04-26 Thread GitBox
elek commented on a change in pull request #773: HDDS-1469. Generate default configuration fragments based on annotations URL: https://github.com/apache/hadoop/pull/773#discussion_r278881502 ## File path: hadoop-hdds/config/src/main/java/org/apache/hadoop/hdds/conf/ConfigFileGenera

[GitHub] [hadoop] elek commented on a change in pull request #773: HDDS-1469. Generate default configuration fragments based on annotations

2019-04-26 Thread GitBox
elek commented on a change in pull request #773: HDDS-1469. Generate default configuration fragments based on annotations URL: https://github.com/apache/hadoop/pull/773#discussion_r278880210 ## File path: hadoop-hdds/config/src/main/java/org/apache/hadoop/hdds/conf/ConfigFileAppend

[GitHub] [hadoop] hadoop-yetus commented on issue #599: HADOOP-16183. Use latest Yetus to support ozone specific build process

2019-04-26 Thread GitBox
hadoop-yetus commented on issue #599: HADOOP-16183. Use latest Yetus to support ozone specific build process URL: https://github.com/apache/hadoop/pull/599#issuecomment-486997915 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--

[GitHub] [hadoop] elek commented on a change in pull request #773: HDDS-1469. Generate default configuration fragments based on annotations

2019-04-26 Thread GitBox
elek commented on a change in pull request #773: HDDS-1469. Generate default configuration fragments based on annotations URL: https://github.com/apache/hadoop/pull/773#discussion_r278879227 ## File path: hadoop-hdds/config/src/main/java/org/apache/hadoop/hdds/conf/Config.java ###

[jira] [Commented] (HADOOP-15888) ITestDynamoDBMetadataStore can leak (large) DDB tables in test failures/timeout

2019-04-26 Thread Gabor Bota (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16826818#comment-16826818 ] Gabor Bota commented on HADOOP-15888: - Thanks for commenting [~ste...@apache.org],

  1   2   >