[GitHub] [hadoop] hadoop-yetus commented on pull request #4663: HDFS-16699:Router Update Observer NameNode state to Active when failo…

hadoop-yetus commented on PR #4663: URL: https://github.com/apache/hadoop/pull/4663#issuecomment-1200354395 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] SanQiMax opened a new pull request, #4663: HDFS-16699:Router Update Observer NameNode state to Active when failo…

SanQiMax opened a new pull request, #4663: URL: https://github.com/apache/hadoop/pull/4663 …ver because of sockeTimeOut Exception ### Description of PR ### How was this patch tested? ### For code changes: - [ ] Does the title or this PR starts with

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4650: YARN-11029. Improve logs to print requestCount, allocatedCount in AMRMProxy service.

slfan1989 commented on code in PR #4650: URL: https://github.com/apache/hadoop/pull/4650#discussion_r933916206 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/amrmproxy/AMRMProxyService.java:

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4657: YARN-11220. [Federation] Add getLabelsToNodes, getClusterNodeLabels, getLabelsOnNode REST APIs for Router

slfan1989 commented on code in PR #4657: URL: https://github.com/apache/hadoop/pull/4657#discussion_r933913533 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/NodeIDsInfo.java:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4650: YARN-11029. Improve logs to print requestCount, allocatedCount in AMRMProxy service.

hadoop-yetus commented on PR #4650: URL: https://github.com/apache/hadoop/pull/4650#issuecomment-1200272038 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4650: YARN-11029. Improve logs to print requestCount, allocatedCount in AMRMProxy service.

hadoop-yetus commented on PR #4650: URL: https://github.com/apache/hadoop/pull/4650#issuecomment-1200257144 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] goiri commented on a diff in pull request #4650: YARN-11029. Improve logs to print requestCount, allocatedCount in AMRMProxy service.

goiri commented on code in PR #4650: URL: https://github.com/apache/hadoop/pull/4650#discussion_r933858260 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/amrmproxy/AMRMProxyService.java:

[GitHub] [hadoop] goiri commented on a diff in pull request #4657: YARN-11220. [Federation] Add getLabelsToNodes, getClusterNodeLabels, getLabelsOnNode REST APIs for Router

goiri commented on code in PR #4657: URL: https://github.com/apache/hadoop/pull/4657#discussion_r933857815 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/NodeIDsInfo.java:

[GitHub] [hadoop] goiri commented on a diff in pull request #4662: HDFS-16705. RBF: Support healthMonitor timeout configurable and cache NN and client proxy in NamenodeHeartbeatService

goiri commented on code in PR #4662: URL: https://github.com/apache/hadoop/pull/4662#discussion_r933857130 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/NamenodeHeartbeatService.java: ## @@ -100,6 +105,8 @@ public class

[GitHub] [hadoop] slfan1989 commented on pull request #4403: MAPREDUCE-7385. improve JobEndNotifier#httpNotification With recommended methods

slfan1989 commented on PR #4403: URL: https://github.com/apache/hadoop/pull/4403#issuecomment-1200168849 @ayushtkn Can you help review this pr？this pr replaces some deprecated method, thank you very much! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hadoop] ZanderXu commented on a diff in pull request #4662: HDFS-16705. RBF supports healthMonitor timeout configurable and caching NN and client proxy in NamenodeHeartbeatService

ZanderXu commented on code in PR #4662: URL: https://github.com/apache/hadoop/pull/4662#discussion_r933813924 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/NamenodeHeartbeatService.java: ## @@ -399,13 +356,58 @@ private

[GitHub] [hadoop] slfan1989 commented on pull request #4657: YARN-11220. [Federation] Add getLabelsToNodes, getClusterNodeLabels, getLabelsOnNode REST APIs for Router

slfan1989 commented on PR #4657: URL: https://github.com/apache/hadoop/pull/4657#issuecomment-1200165978 @goiri Please help to review the code again, thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [hadoop] slfan1989 commented on pull request #4656: YARN-11235. Refactor Policy Code and Define getReservationHomeSubcluster

slfan1989 commented on PR #4656: URL: https://github.com/apache/hadoop/pull/4656#issuecomment-1200165945 @goiri Please help to review the code again, thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [hadoop] slfan1989 commented on pull request #4650: YARN-11029. Improve logs to print requestCount, allocatedCount in AMRMProxy service.

slfan1989 commented on PR #4650: URL: https://github.com/apache/hadoop/pull/4650#issuecomment-1200165865 @goiri Please help to review the code again, thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4650: YARN-11029. Improve logs to print askCount, allocatedCount in AMRMProxy service.

slfan1989 commented on code in PR #4650: URL: https://github.com/apache/hadoop/pull/4650#discussion_r933810467 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/amrmproxy/AMRMProxyService.java:

[GitHub] [hadoop] slfan1989 commented on pull request #4662: HDFS-16705. RBF supports healthMonitor timeout configurable and caching NN and client proxy in NamenodeHeartbeatService

slfan1989 commented on PR #4662: URL: https://github.com/apache/hadoop/pull/4662#issuecomment-1200165388 @ZanderXu Thanks for your contribution, pr is very valuable! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4662: HDFS-16705. RBF supports healthMonitor timeout configurable and caching NN and client proxy in NamenodeHeartbeatService

slfan1989 commented on code in PR #4662: URL: https://github.com/apache/hadoop/pull/4662#discussion_r933811104 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/NamenodeHeartbeatService.java: ## @@ -399,13 +356,58 @@ private

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4662: HDFS-16705. RBF supports healthMonitor timeout configurable and caching NN and client proxy in NamenodeHeartbeatService

slfan1989 commented on code in PR #4662: URL: https://github.com/apache/hadoop/pull/4662#discussion_r933810783 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/NamenodeHeartbeatService.java: ## @@ -399,13 +356,58 @@ private

[GitHub] [hadoop] ZanderXu commented on pull request #4662: HDFS-16705. RBF supports healthMonitor timeout configurable and caching NN and client proxy in NamenodeHeartbeatService

ZanderXu commented on PR #4662: URL: https://github.com/apache/hadoop/pull/4662#issuecomment-1200164043 > updateNameSpaceInfoParameters ? updateSafeModeParameters ? In my personal opinion, if we change the code, we still need to add junit test, and the content of the test should cover

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4650: YARN-11029. Improve logs to print askCount, allocatedCount in AMRMProxy service.

slfan1989 commented on code in PR #4650: URL: https://github.com/apache/hadoop/pull/4650#discussion_r933810467 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/amrmproxy/AMRMProxyService.java:

[GitHub] [hadoop] ZanderXu commented on a diff in pull request #4662: HDFS-16705. RBF supports healthMonitor timeout configurable and caching NN and client proxy in NamenodeHeartbeatService

ZanderXu commented on code in PR #4662: URL: https://github.com/apache/hadoop/pull/4662#discussion_r933810160 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/NamenodeHeartbeatService.java: ## @@ -399,13 +356,58 @@ private

[GitHub] [hadoop] slfan1989 commented on pull request #4660: HDFS-16703. Enable RPC Timeout for some protocols of NameNode.

slfan1989 commented on PR #4660: URL: https://github.com/apache/hadoop/pull/4660#issuecomment-1200163090 > Thanks @slfan1989 for your explain. > > `ipc.client.rpc-timeout.ms` default is 2min. If client can‘t receive the response within 2min, maybe we should give a high priority to

[GitHub] [hadoop] ZanderXu commented on pull request #4660: HDFS-16703. Enable RPC Timeout for some protocols of NameNode.

ZanderXu commented on PR #4660: URL: https://github.com/apache/hadoop/pull/4660#issuecomment-1200162298 Thanks @slfan1989 for your explain. `ipc.client.rpc-timeout.ms` default is 2min. If client can‘t receive the response within 2min, maybe we should give a high priority to improving

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4650: YARN-11029. Improve logs to print askCount, allocatedCount in AMRMProxy service.

slfan1989 commented on code in PR #4650: URL: https://github.com/apache/hadoop/pull/4650#discussion_r933809102 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/amrmproxy/AMRMProxyService.java:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4656: YARN-11235. Refactor Policy Code and Define getReservationHomeSubcluster

hadoop-yetus commented on PR #4656: URL: https://github.com/apache/hadoop/pull/4656#issuecomment-1200160822 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] slfan1989 commented on pull request #4660: HDFS-16703. Enable RPC Timeout for some protocols of NameNode.

slfan1989 commented on PR #4660: URL: https://github.com/apache/hadoop/pull/4660#issuecomment-1200160215 > Sorry, I didn't get your idea. Can you share more detailed information or cases? I mean you have increased the timeout configuration, will some protocols timeout frequently?

[GitHub] [hadoop] slfan1989 commented on pull request #4662: HDFS-16705. RBF supports healthMonitor timeout configurable and caching NN and client proxy in NamenodeHeartbeatService

slfan1989 commented on PR #4662: URL: https://github.com/apache/hadoop/pull/4662#issuecomment-1200158849 > Thanks @slfan1989 for your review. > > > can we add some junit tests? > > Do you want me to add UT for which case? updateNameSpaceInfoParameters ?

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4662: HDFS-16705. RBF supports healthMonitor timeout configurable and caching NN and client proxy in NamenodeHeartbeatService

slfan1989 commented on code in PR #4662: URL: https://github.com/apache/hadoop/pull/4662#discussion_r933807337 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/NamenodeHeartbeatService.java: ## @@ -399,13 +356,58 @@ private

[GitHub] [hadoop] ZanderXu commented on pull request #4662: HDFS-16705. RBF supports healthMonitor timeout configurable and caching NN and client proxy in NamenodeHeartbeatService

ZanderXu commented on PR #4662: URL: https://github.com/apache/hadoop/pull/4662#issuecomment-1200157355 Thanks @slfan1989 for your review. > can we add some junit tests? Do you want me to add UT for which case? -- This is an automated message from the Apache Git Service. To respond

[GitHub] [hadoop] ZanderXu commented on pull request #4660: HDFS-16703. Enable RPC Timeout for some protocols of NameNode.

ZanderXu commented on PR #4660: URL: https://github.com/apache/hadoop/pull/4660#issuecomment-1200156797 @slfan1989 Thanks for your review. > I feel that this change is a bit risky, will this lead to instability of the service? Sometimes it is reasonable to configure without timeout

[GitHub] [hadoop] slfan1989 commented on pull request #4660: HDFS-16703. Enable RPC Timeout for some protocols of NameNode.

slfan1989 commented on PR #4660: URL: https://github.com/apache/hadoop/pull/4660#issuecomment-1200151395 @ZanderXu I feel that this change is a bit risky, will this lead to instability of the service? Sometimes it is reasonable to configure without timeout. The main question is is it

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4650: YARN-11029. Improve logs to print askCount, allocatedCount in AMRMProxy service.

slfan1989 commented on code in PR #4650: URL: https://github.com/apache/hadoop/pull/4650#discussion_r933800979 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/amrmproxy/AMRMProxyService.java:

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4650: YARN-11029. Improve logs to print askCount, allocatedCount in AMRMProxy service.

slfan1989 commented on code in PR #4650: URL: https://github.com/apache/hadoop/pull/4650#discussion_r933797897 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/amrmproxy/AMRMProxyMetrics.java:

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4650: YARN-11029. Improve logs to print askCount, allocatedCount in AMRMProxy service.

slfan1989 commented on code in PR #4650: URL: https://github.com/apache/hadoop/pull/4650#discussion_r933797305 ## hadoop-build-tools/src/main/resources/checkstyle/checkstyle.xml: ## @@ -174,6 +174,7 @@ + Review Comment: Thanks for

[GitHub] [hadoop] hadoop-yetus commented on pull request #4662: HDFS-16705. RBF supports healthMonitor timeout configurable and caching NN and client proxy in NamenodeHeartbeatService

hadoop-yetus commented on PR #4662: URL: https://github.com/apache/hadoop/pull/4662#issuecomment-1200143309 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] slfan1989 commented on pull request #4662: HDFS-16705. RBF supports healthMonitor timeout configurable and caching NN and client proxy in NamenodeHeartbeatService

slfan1989 commented on PR #4662: URL: https://github.com/apache/hadoop/pull/4662#issuecomment-1200143264 an we add some junit tests? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [hadoop] hadoop-yetus commented on pull request #4660: HDFS-16703. Enable RPC Timeout for some protocols of NameNode.

hadoop-yetus commented on PR #4660: URL: https://github.com/apache/hadoop/pull/4660#issuecomment-1200140882 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4656: YARN-11235. Refactor Policy Code and Define getReservationHomeSubcluster

slfan1989 commented on code in PR #4656: URL: https://github.com/apache/hadoop/pull/4656#discussion_r933793535 ##

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4656: YARN-11235. Refactor Policy Code and Define getReservationHomeSubcluster

slfan1989 commented on code in PR #4656: URL: https://github.com/apache/hadoop/pull/4656#discussion_r933793274 ##

[GitHub] [hadoop] hadoop-yetus commented on pull request #4661: HDFS-16704. Datanode return empty response instead of NPE for GetVolumeInfo during restarting

hadoop-yetus commented on PR #4661: URL: https://github.com/apache/hadoop/pull/4661#issuecomment-1200124086 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] ZanderXu opened a new pull request, #4662: HDFS-16705. RBF supports healthMonitor timeout configurable and caching NN and client proxy in NamenodeHeartbeatService

ZanderXu opened a new pull request, #4662: URL: https://github.com/apache/hadoop/pull/4662 ### Description of PR When I read NamenodeHeartbeatService.class of RBF, I feel that there are somethings we can do for NamenodeHeartbeatService.class. - Cache NameNode Protocol and Client

[GitHub] [hadoop] jianghuazhu commented on a diff in pull request #4659: HDFS-16700. RBF: Record the real client IP carried by the Router in the NameNode log

jianghuazhu commented on code in PR #4659: URL: https://github.com/apache/hadoop/pull/4659#discussion_r933773424 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java: ## @@ -1351,6 +1357,33 @@ private class ResponseParams { @Override

[GitHub] [hadoop] jianghuazhu commented on a diff in pull request #4659: HDFS-16700. RBF: Record the real client IP carried by the Router in the NameNode log

jianghuazhu commented on code in PR #4659: URL: https://github.com/apache/hadoop/pull/4659#discussion_r933772819 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java: ## @@ -1351,6 +1357,33 @@ private class ResponseParams { @Override