[GitHub] [hadoop] hadoop-yetus commented on pull request #4711: YARN-11236. Implement FederationReservationHomeSubClusterStore With MemoryStore.

2022-08-05 Thread GitBox
hadoop-yetus commented on PR #4711: URL: https://github.com/apache/hadoop/pull/4711#issuecomment-1207149152 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] slfan1989 commented on pull request #4687: YARN-10846. Add dispatcher metrics to NM.

2022-08-05 Thread GitBox
slfan1989 commented on PR #4687: URL: https://github.com/apache/hadoop/pull/4687#issuecomment-1207143284 @jojochuang Can you help review this PR? I refer to the code of [YARN-9615](https://issues.apache.org/jira/browse/YARN-9615) and the

[GitHub] [hadoop] slfan1989 commented on pull request #4712: YARN-6539. Create SecureLogin inside Router.

2022-08-05 Thread GitBox
slfan1989 commented on PR #4712: URL: https://github.com/apache/hadoop/pull/4712#issuecomment-1207142315 Because the implementation of YarnRouterApi (DelegationToken) requires a router in safe mode, I will continue to follow up on this pr, thanks to those who originally contributed to this

[GitHub] [hadoop] slfan1989 opened a new pull request, #4712: YARN-6539. Consider running RM tests against the Router.

2022-08-05 Thread GitBox
slfan1989 opened a new pull request, #4712: URL: https://github.com/apache/hadoop/pull/4712 JIRA. YARN-6539. Consider running RM tests against the Router. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [hadoop] ZanderXu commented on a diff in pull request #4659: HDFS-16700. RBF: Record the real client IP carried by the Router in the NameNode log

2022-08-05 Thread GitBox
ZanderXu commented on code in PR #4659: URL: https://github.com/apache/hadoop/pull/4659#discussion_r939467240 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java: ## @@ -1351,6 +1357,16 @@ private class ResponseParams { @Override

[GitHub] [hadoop] hadoop-yetus commented on pull request #4705: HADOOP-18373. IOStatisticsContext tuning

2022-08-05 Thread GitBox
hadoop-yetus commented on PR #4705: URL: https://github.com/apache/hadoop/pull/4705#issuecomment-1207125850 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18373) IOStatisticsContext tuning

2022-08-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17576111#comment-17576111 ] ASF GitHub Bot commented on HADOOP-18373: - hadoop-yetus commented on PR #4705: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #1747: HDFS-15042 Add more tests for ByteBufferPositionedReadable.

2022-08-05 Thread GitBox
hadoop-yetus commented on PR #1747: URL: https://github.com/apache/hadoop/pull/1747#issuecomment-1207111762 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4659: HDFS-16700. RBF: Record the real client IP carried by the Router in the NameNode log

2022-08-05 Thread GitBox
hadoop-yetus commented on PR #4659: URL: https://github.com/apache/hadoop/pull/4659#issuecomment-1207107734 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4710: HDFS-16719. Remove unused import in hadoop-hdfs module

2022-08-05 Thread GitBox
hadoop-yetus commented on PR #4710: URL: https://github.com/apache/hadoop/pull/4710#issuecomment-1207100858 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-17380) ITestS3AContractSeek.teardown closes FS before superclass does its cleanup

2022-08-05 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17576092#comment-17576092 ] Viraj Jasani commented on HADOOP-17380: --- Looks like this Jira can be closed >

[GitHub] [hadoop] ZanderXu commented on pull request #4660: HDFS-16703. Enable RPC Timeout for some protocols of NameNode.

2022-08-05 Thread GitBox
ZanderXu commented on PR #4660: URL: https://github.com/apache/hadoop/pull/4660#issuecomment-1207092541 @goiri Master, thanks for your helping review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4711: YARN-11236. Implement FederationReservationHomeSubClusterStore With MemoryStore.

2022-08-05 Thread GitBox
slfan1989 commented on code in PR #4711: URL: https://github.com/apache/hadoop/pull/4711#discussion_r939449057 ##

[GitHub] [hadoop] ZanderXu closed pull request #4709: HDFS-16720. Import detailed class instead of import * in hadoop-hdfs moulde

2022-08-05 Thread GitBox
ZanderXu closed pull request #4709: HDFS-16720. Import detailed class instead of import * in hadoop-hdfs moulde URL: https://github.com/apache/hadoop/pull/4709 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hadoop] ZanderXu commented on pull request #4709: HDFS-16720. Import detailed class instead of import * in hadoop-hdfs moulde

2022-08-05 Thread GitBox
ZanderXu commented on PR #4709: URL: https://github.com/apache/hadoop/pull/4709#issuecomment-1207090035 Thanks @slfan1989 for you review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hadoop] ZanderXu closed pull request #4710: HDFS-16719. Remove unused import in hadoop-hdfs module

2022-08-05 Thread GitBox
ZanderXu closed pull request #4710: HDFS-16719. Remove unused import in hadoop-hdfs module URL: https://github.com/apache/hadoop/pull/4710 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hadoop] ZanderXu commented on pull request #4710: HDFS-16719. Remove unused import in hadoop-hdfs module

2022-08-05 Thread GitBox
ZanderXu commented on PR #4710: URL: https://github.com/apache/hadoop/pull/4710#issuecomment-1207089639 Thanks @slfan1989 @ayushtkn for your review. I will read https://github.com/steveloughran/formality/blob/master/styleguide/styleguide.md carefully and close this PR. -- This is an

[GitHub] [hadoop] goiri commented on a diff in pull request #4711: YARN-11236. Implement FederationReservationHomeSubClusterStore With MemoryStore.

2022-08-05 Thread GitBox
goiri commented on code in PR #4711: URL: https://github.com/apache/hadoop/pull/4711#discussion_r939396343 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/impl/MemoryFederationStateStore.java:

[jira] [Commented] (HADOOP-18181) move org.apache.hadoop.fs.common package into hadoop-common module

2022-08-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17576065#comment-17576065 ] ASF GitHub Bot commented on HADOOP-18181: - hadoop-yetus commented on PR #4690: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4690: HADOOP-18181. Move prefetch common classes to hadoop common

2022-08-05 Thread GitBox
hadoop-yetus commented on PR #4690: URL: https://github.com/apache/hadoop/pull/4690#issuecomment-1206975989 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18373) IOStatisticsContext tuning

2022-08-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17576064#comment-17576064 ] ASF GitHub Bot commented on HADOOP-18373: - virajjasani commented on code in PR #4705: URL:

[GitHub] [hadoop] virajjasani commented on a diff in pull request #4705: HADOOP-18373. IOStatisticsContext tuning

2022-08-05 Thread GitBox
virajjasani commented on code in PR #4705: URL: https://github.com/apache/hadoop/pull/4705#discussion_r939335294 ## hadoop-tools/hadoop-aws/src/test/resources/core-site.xml: ## @@ -178,6 +178,12 @@ true + Review Comment: They might not have issue with test

[GitHub] [hadoop] slfan1989 commented on pull request #4711: YARN-11236. Implement FederationReservationHomeSubClusterStore With MemoryStore.

2022-08-05 Thread GitBox
slfan1989 commented on PR #4711: URL: https://github.com/apache/hadoop/pull/4711#issuecomment-1206930345 @goiri Could you please help to review the code? Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hadoop] hadoop-yetus commented on pull request #4708: HDFS-16718. Improve Code with Lambda in org.apahce.hadoop.hdfs.server.datanode packages

2022-08-05 Thread GitBox
hadoop-yetus commented on PR #4708: URL: https://github.com/apache/hadoop/pull/4708#issuecomment-1206908808 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] goiri commented on a diff in pull request #4660: HDFS-16703. Enable RPC Timeout for some protocols of NameNode.

2022-08-05 Thread GitBox
goiri commented on code in PR #4660: URL: https://github.com/apache/hadoop/pull/4660#discussion_r939242059 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java: ## @@ -2029,5 +2029,33 @@ public class DFSConfigKeys extends

[GitHub] [hadoop] goiri commented on a diff in pull request #4660: HDFS-16703. Enable RPC Timeout for some protocols of NameNode.

2022-08-05 Thread GitBox
goiri commented on code in PR #4660: URL: https://github.com/apache/hadoop/pull/4660#discussion_r939239255 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java: ## @@ -2029,5 +2029,33 @@ public class DFSConfigKeys extends

[GitHub] [hadoop] hadoop-yetus commented on pull request #4709: HDFS-16720. Import detailed class instead of import * in hadoop-hdfs moulde

2022-08-05 Thread GitBox
hadoop-yetus commented on PR #4709: URL: https://github.com/apache/hadoop/pull/4709#issuecomment-1206876037 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4711: YARN-11236. Implement FederationReservationHomeSubClusterStore With MemoryStore.

2022-08-05 Thread GitBox
hadoop-yetus commented on PR #4711: URL: https://github.com/apache/hadoop/pull/4711#issuecomment-1206819328 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4707: HDFS-16653.Safe mode related operations cannot be performed when “dfs.client.mmap.cache.size” is set to a negative number

2022-08-05 Thread GitBox
hadoop-yetus commented on PR #4707: URL: https://github.com/apache/hadoop/pull/4707#issuecomment-1206791577 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-14603) S3A input stream to support ByteBufferReadable

2022-08-05 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-14603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17576016#comment-17576016 ] Steve Loughran commented on HADOOP-14603: - i think we should do this and the basic

[GitHub] [hadoop] hadoop-yetus commented on pull request #4701: YARN-10885. Make FederationStateStoreFacade#getApplicationHomeSubCluster use JCache.

2022-08-05 Thread GitBox
hadoop-yetus commented on PR #4701: URL: https://github.com/apache/hadoop/pull/4701#issuecomment-1206720683 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18258) Merging of S3A Audit Logs

2022-08-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17575989#comment-17575989 ] ASF GitHub Bot commented on HADOOP-18258: - steveloughran commented on PR #4383: URL:

[GitHub] [hadoop] steveloughran commented on pull request #4383: HADOOP-18258. Merging of S3A Audit Logs

2022-08-05 Thread GitBox
steveloughran commented on PR #4383: URL: https://github.com/apache/hadoop/pull/4383#issuecomment-1206709133 this isn't a bug, just inefficient, as the instanceof is always false if the argument is null. because this is generated code, it's not something which can be fixed. so

[jira] [Commented] (HADOOP-18340) deleteOnExit does not work with S3AFileSystem

2022-08-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17575968#comment-17575968 ] ASF GitHub Bot commented on HADOOP-18340: - huaxiangsun commented on PR #4608: URL:

[GitHub] [hadoop] huaxiangsun commented on pull request #4608: HADOOP-18340 deleteOnExit does not work with S3AFileSystem

2022-08-05 Thread GitBox
huaxiangsun commented on PR #4608: URL: https://github.com/apache/hadoop/pull/4608#issuecomment-1206668465 @steveloughran Sorry to bother you while you are busy, just a gentle reminder for the patch I posted couple days ago. Appreciate that you can review the patch when you get chance,

[jira] [Commented] (HADOOP-18258) Merging of S3A Audit Logs

2022-08-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17575964#comment-17575964 ] ASF GitHub Bot commented on HADOOP-18258: - hadoop-yetus commented on PR #4383: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4383: HADOOP-18258. Merging of S3A Audit Logs

2022-08-05 Thread GitBox
hadoop-yetus commented on PR #4383: URL: https://github.com/apache/hadoop/pull/4383#issuecomment-1206660562 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4653: HDFS-16697.Randomly setting “dfs.namenode.resource.checked.volumes.minimum” will always prevent safe mode from being turned off

2022-08-05 Thread GitBox
hadoop-yetus commented on PR #4653: URL: https://github.com/apache/hadoop/pull/4653#issuecomment-1206652668 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4701: YARN-10885. Make FederationStateStoreFacade#getApplicationHomeSubCluster use JCache.

2022-08-05 Thread GitBox
slfan1989 commented on code in PR #4701: URL: https://github.com/apache/hadoop/pull/4701#discussion_r938980459 ##

[GitHub] [hadoop] slfan1989 commented on pull request #4701: YARN-10885. Make FederationStateStoreFacade#getApplicationHomeSubCluster use JCache.

2022-08-05 Thread GitBox
slfan1989 commented on PR #4701: URL: https://github.com/apache/hadoop/pull/4701#issuecomment-1206638972 @goiri Please help to review the code again, thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [hadoop] hadoop-yetus commented on pull request #4701: YARN-10885. Make FederationStateStoreFacade#getApplicationHomeSubCluster use JCache.

2022-08-05 Thread GitBox
hadoop-yetus commented on PR #4701: URL: https://github.com/apache/hadoop/pull/4701#issuecomment-1206638096 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] slfan1989 commented on pull request #4695: YARN-11228. [Federation] Add getAppAttempts, getAppAttempt REST APIs for Router.

2022-08-05 Thread GitBox
slfan1989 commented on PR #4695: URL: https://github.com/apache/hadoop/pull/4695#issuecomment-1206623737 @goiri Thank you very much for your help reviewing the code, I will follow up with YARN-11227. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hadoop] slfan1989 commented on pull request #4708: HDFS-16718. Improve Code with Lambda in org.apahce.hadoop.hdfs.server.datanode packages

2022-08-05 Thread GitBox
slfan1989 commented on PR #4708: URL: https://github.com/apache/hadoop/pull/4708#issuecomment-1206616499 @ZanderXu thanks for your contribution, LGTM. wait for the compilation result of jenkins. -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (HADOOP-18353) HEAD OBJECT returns only 400 BAD REQUEST when token is expired

2022-08-05 Thread Mukund Thakur (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17575933#comment-17575933 ] Mukund Thakur commented on HADOOP-18353: Yes resolving as information provided. Thanks

[jira] [Resolved] (HADOOP-18353) HEAD OBJECT returns only 400 BAD REQUEST when token is expired

2022-08-05 Thread Mukund Thakur (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mukund Thakur resolved HADOOP-18353. Resolution: Information Provided > HEAD OBJECT returns only 400 BAD REQUEST when token

[GitHub] [hadoop] slfan1989 commented on pull request #4390: MAPREDUCE-7384. impove import * In MapReduce Project.

2022-08-05 Thread GitBox
slfan1989 commented on PR #4390: URL: https://github.com/apache/hadoop/pull/4390#issuecomment-1206614396 > > further reading > > https://github.com/steveloughran/formality/blob/master/styleguide/styleguide.md > > This doc is cool, worth having a link in the see also section of

[GitHub] [hadoop] slfan1989 opened a new pull request, #4711: YARN-11236. Implement FederationReservationHomeSubClusterStore With MemoryStore.

2022-08-05 Thread GitBox
slfan1989 opened a new pull request, #4711: URL: https://github.com/apache/hadoop/pull/4711 JIRA:YARN-11236. Implement FederationReservationHomeSubClusterStore With MemoryStore. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hadoop] ashutoshcipher commented on pull request #4703: YARN-11241. Add uncleaning option for local app log file with log-aggregation enabled

2022-08-05 Thread GitBox
ashutoshcipher commented on PR #4703: URL: https://github.com/apache/hadoop/pull/4703#issuecomment-1206601744 FYI: Checkstyle -0 showing here is not due changes in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [hadoop] ayushtkn commented on pull request #4390: MAPREDUCE-7384. impove import * In MapReduce Project.

2022-08-05 Thread GitBox
ayushtkn commented on PR #4390: URL: https://github.com/apache/hadoop/pull/4390#issuecomment-1206601697 >further reading https://github.com/steveloughran/formality/blob/master/styleguide/styleguide.md This doc is cool, worth having a link in the see also section of

[jira] [Updated] (HADOOP-18327) Fix eval expression in hadoop-functions.sh

2022-08-05 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-18327: Target Version/s: 3.3.9 (was: 3.3.9, 3.3.4) > Fix eval expression in

[GitHub] [hadoop] slfan1989 commented on pull request #4687: YARN-10846. Add dispatcher metrics to NM.

2022-08-05 Thread GitBox
slfan1989 commented on PR #4687: URL: https://github.com/apache/hadoop/pull/4687#issuecomment-1206593455 @ayushtkn Can you help review this PR? I refer to the code of [YARN-9615](https://issues.apache.org/jira/browse/YARN-9615) and the

[jira] [Updated] (HADOOP-18067) Über-jira: S3A Hadoop 3.3.5 features

2022-08-05 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-18067: Summary: Über-jira: S3A Hadoop 3.3.5 features (was: Über-jira: S3A Hadoop 3.3.4

[jira] [Updated] (HADOOP-18330) S3AFileSystem removes Path when calling createS3Client

2022-08-05 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-18330: Fix Version/s: 3.3.9 (was: 3.3.5) > S3AFileSystem removes Path

[GitHub] [hadoop] slfan1989 commented on pull request #4710: HDFS-16719. Remove unused import in hadoop-hdfs module

2022-08-05 Thread GitBox
slfan1989 commented on PR #4710: URL: https://github.com/apache/hadoop/pull/4710#issuecomment-1206592441 LGTM +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [hadoop] slfan1989 commented on pull request #4709: HDFS-16720. Import detailed class instead of import * in hadoop-hdfs moulde

2022-08-05 Thread GitBox
slfan1989 commented on PR #4709: URL: https://github.com/apache/hadoop/pull/4709#issuecomment-1206591004 @ZanderXu This fix cannot be approved, see the discussion of this pr. https://github.com/apache/hadoop/pull/4390 -- This is an automated message from the Apache Git Service. To

[jira] [Resolved] (HADOOP-18323) Bump javax.ws.rs-api To Version 3.1.0

2022-08-05 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran resolved HADOOP-18323. - Resolution: Not A Problem HADOOP-18332 makes this unneeded. closing > Bump

[jira] [Resolved] (HADOOP-18386) ITestS3SelectLandsat timeout after 10 minutes

2022-08-05 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran resolved HADOOP-18386. - Resolution: Duplicate > ITestS3SelectLandsat timeout after 10 minutes >

[GitHub] [hadoop] ZanderXu opened a new pull request, #4710: HDFS-16719. Remove useless import in hadoop-hdfs module

2022-08-05 Thread GitBox
ZanderXu opened a new pull request, #4710: URL: https://github.com/apache/hadoop/pull/4710 ### Description of PR During reading code of hadoop-hdfs module, I found that there are some useless import in some classes, such as useless import TrustedChannelResolver in

[GitHub] [hadoop] ZanderXu opened a new pull request, #4709: HDFS-16720. Import detailed class instead of import * in hadoop-hdfs moulde

2022-08-05 Thread GitBox
ZanderXu opened a new pull request, #4709: URL: https://github.com/apache/hadoop/pull/4709 ### Description of PR During reading code in hadoop-hdfs module, I found that there is import * case in some classes, such as ``` // BlockPlacementPolicyDefault.java import java.util.*;

[GitHub] [hadoop] hadoop-yetus commented on pull request #4697: HDFS-16716. Improve appendToFile command: support appending on file w…

2022-08-05 Thread GitBox
hadoop-yetus commented on PR #4697: URL: https://github.com/apache/hadoop/pull/4697#issuecomment-1206571967 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Updated] (HADOOP-18366) ITestS3Select.testSelectSeekFullLandsat is timing out

2022-08-05 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-18366: Fix Version/s: 3.3.9 > ITestS3Select.testSelectSeekFullLandsat is timing out >

[GitHub] [hadoop] ted12138 commented on a diff in pull request #4139: HDFS-16524. Add configuration to control blocks deletion asynchronous…

2022-08-05 Thread GitBox
ted12138 commented on code in PR #4139: URL: https://github.com/apache/hadoop/pull/4139#discussion_r938898456 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java: ## @@ -3410,6 +3410,33 @@ FSPermissionChecker

[jira] [Commented] (HADOOP-18180) Remove use of scala jar twitter util-core with java futures in S3A prefetching stream

2022-08-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17575859#comment-17575859 ] ASF GitHub Bot commented on HADOOP-18180: - ahmarsuhail closed pull request #4520: HADOOP-18180.

[GitHub] [hadoop] ahmarsuhail closed pull request #4520: HADOOP-18180. Replaces ExecutorServicePool with ExecutorService

2022-08-05 Thread GitBox
ahmarsuhail closed pull request #4520: HADOOP-18180. Replaces ExecutorServicePool with ExecutorService URL: https://github.com/apache/hadoop/pull/4520 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hadoop] ZanderXu opened a new pull request, #4708: HDFS-16718. Improve Code with Lambda in org.apahce.hadoop.hdfs.server.datanode packages

2022-08-05 Thread GitBox
ZanderXu opened a new pull request, #4708: URL: https://github.com/apache/hadoop/pull/4708 ### Description of PR Improve Code with Lambda in org.apahce.hadoop.hdfs.server.datanode packages. For example: Current logic: ``` synchronized void startAll() throws IOException {

[jira] [Commented] (HADOOP-18382) Upgrade AWS SDK to V2 - Prerequisites

2022-08-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17575857#comment-17575857 ] ASF GitHub Bot commented on HADOOP-18382: - ahmarsuhail commented on PR #4698: URL:

[GitHub] [hadoop] ahmarsuhail commented on pull request #4698: HADOOP-18382. SDK upgrade prerequisites

2022-08-05 Thread GitBox
ahmarsuhail commented on PR #4698: URL: https://github.com/apache/hadoop/pull/4698#issuecomment-1206494134 Thanks @monthonk! @steveloughran how can the yetus deprecation errors be handled? Also for credential providers, do we want to allow custom V1 credential providers in

[jira] [Commented] (HADOOP-18353) HEAD OBJECT returns only 400 BAD REQUEST when token is expired

2022-08-05 Thread Ahmar Suhail (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17575854#comment-17575854 ] Ahmar Suhail commented on HADOOP-18353: --- This is happening because the HEAD responses don't have

[jira] [Resolved] (HADOOP-18366) ITestS3Select.testSelectSeekFullLandsat is timing out

2022-08-05 Thread Ahmar Suhail (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ahmar Suhail resolved HADOOP-18366. --- Resolution: Fixed > ITestS3Select.testSelectSeekFullLandsat is timing out >

[jira] [Created] (HADOOP-18394) Enable parallel building in pre-commit jobs

2022-08-05 Thread Steve Vaughan (Jira)
Steve Vaughan created HADOOP-18394: -- Summary: Enable parallel building in pre-commit jobs Key: HADOOP-18394 URL: https://issues.apache.org/jira/browse/HADOOP-18394 Project: Hadoop Common

[jira] [Commented] (HADOOP-18366) ITestS3Select.testSelectSeekFullLandsat is timing out

2022-08-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17575838#comment-17575838 ] ASF GitHub Bot commented on HADOOP-18366: - steveloughran merged PR #4702: URL:

[GitHub] [hadoop] steveloughran merged pull request #4702: HADOOP-18366. Fix ITestS3Select.testSelectSeekFullLandsat is timing out.

2022-08-05 Thread GitBox
steveloughran merged PR #4702: URL: https://github.com/apache/hadoop/pull/4702 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4703: YARN-11241. Add uncleaning option for local app log file with log-aggregation enabled

2022-08-05 Thread GitBox
hadoop-yetus commented on PR #4703: URL: https://github.com/apache/hadoop/pull/4703#issuecomment-1206390918 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18073) Upgrade AWS SDK to v2

2022-08-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17575811#comment-17575811 ] ASF GitHub Bot commented on HADOOP-18073: - hadoop-yetus commented on PR #4706: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4706: HADOOP-18073. Adds in s3 client config and updates list.

2022-08-05 Thread GitBox
hadoop-yetus commented on PR #4706: URL: https://github.com/apache/hadoop/pull/4706#issuecomment-1206380249 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4660: HDFS-16703. Enable RPC Timeout for some protocols of NameNode.

2022-08-05 Thread GitBox
hadoop-yetus commented on PR #4660: URL: https://github.com/apache/hadoop/pull/4660#issuecomment-1206343919 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] snmvaughan commented on pull request #4415: MAPREDUCE-7386. Maven parallel builds (skipping tests) fail

2022-08-05 Thread GitBox
snmvaughan commented on PR #4415: URL: https://github.com/apache/hadoop/pull/4415#issuecomment-1206331264 I've been focusing on speeding up the build process in order to aid in development. There are several reasons why the tests can't safely run in parallel, which is why I've started

[jira] [Commented] (HADOOP-18383) Codecs with @DoNotPool annotation are not closed causing memory leak

2022-08-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17575711#comment-17575711 ] ASF GitHub Bot commented on HADOOP-18383: - kevins-29 commented on code in PR #4585: URL:

[GitHub] [hadoop] kevins-29 commented on a diff in pull request #4585: HADOOP-18383. Codecs with @DoNotPool annotation are not closed causing memory leak

2022-08-05 Thread GitBox
kevins-29 commented on code in PR #4585: URL: https://github.com/apache/hadoop/pull/4585#discussion_r938704526 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/zlib/BuiltInGzipCompressor.java: ## @@ -102,7 +103,15 @@ public int compress(byte[]

[GitHub] [hadoop] steveloughran commented on pull request #4415: MAPREDUCE-7386. Maven parallel builds (skipping tests) fail

2022-08-05 Thread GitBox
steveloughran commented on PR #4415: URL: https://github.com/apache/hadoop/pull/4415#issuecomment-1206275892 unfortunate. how about making that focus on parallel test running for a speedup. that's fairly painful to do if anything is making assumptions about exclusive paths or ports, but

[jira] [Commented] (HADOOP-17649) Update wildfly openssl to 2.1.3.Final

2022-08-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17575687#comment-17575687 ] ASF GitHub Bot commented on HADOOP-17649: - steveloughran commented on PR #4539: URL:

[GitHub] [hadoop] steveloughran commented on pull request #4539: HADOOP-17649. Update wildfly openssl to 2.2.1.Final

2022-08-05 Thread GitBox
steveloughran commented on PR #4539: URL: https://github.com/apache/hadoop/pull/4539#issuecomment-1206272902 ok. i will do an (ec2) linux run later. that or fix my pi400 up for testing, which might be fun anyway -- This is an automated message from the Apache Git Service. To respond to

[jira] [Commented] (HADOOP-18181) move org.apache.hadoop.fs.common package into hadoop-common module

2022-08-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17575685#comment-17575685 ] ASF GitHub Bot commented on HADOOP-18181: - steveloughran commented on code in PR #4690: URL:

[GitHub] [hadoop] Likkey opened a new pull request, #4707: HDFS-16653.Safe mode related operations cannot be performed when “dfs.client.mmap.cache.size” is set to a negative number

2022-08-05 Thread GitBox
Likkey opened a new pull request, #4707: URL: https://github.com/apache/hadoop/pull/4707 ### Description of PR When the configuration item “dfs.client.mmap.cache.size” is set to a negative number, it will cause /hadoop/bin hdfs dfsadmin -safemode provides all the operation

[GitHub] [hadoop] steveloughran commented on a diff in pull request #4690: HADOOP-18181. Move prefetch common classes to hadoop common

2022-08-05 Thread GitBox
steveloughran commented on code in PR #4690: URL: https://github.com/apache/hadoop/pull/4690#discussion_r938659885 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/impl/prefetch/BlockOperations.java: ## @@ -163,61 +163,61 @@ private synchronized

[jira] [Commented] (HADOOP-18373) IOStatisticsContext tuning

2022-08-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17575683#comment-17575683 ] ASF GitHub Bot commented on HADOOP-18373: - steveloughran commented on code in PR #4705: URL:

[GitHub] [hadoop] steveloughran commented on a diff in pull request #4705: HADOOP-18373. IOStatisticsContext tuning

2022-08-05 Thread GitBox
steveloughran commented on code in PR #4705: URL: https://github.com/apache/hadoop/pull/4705#discussion_r938647600 ## hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3AIOStatisticsContext.java: ## @@ -153,6 +153,7 @@ public void

[jira] [Commented] (HADOOP-18366) ITestS3Select.testSelectSeekFullLandsat is timing out

2022-08-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17575677#comment-17575677 ] ASF GitHub Bot commented on HADOOP-18366: - hadoop-yetus commented on PR #4702: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4702: HADOOP-18366. Fix ITestS3Select.testSelectSeekFullLandsat is timing out.

2022-08-05 Thread GitBox
hadoop-yetus commented on PR #4702: URL: https://github.com/apache/hadoop/pull/4702#issuecomment-1206259145 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Updated] (HADOOP-18073) Upgrade AWS SDK to v2

2022-08-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18073: Labels: pull-request-available (was: ) > Upgrade AWS SDK to v2 > -

[jira] [Commented] (HADOOP-18073) Upgrade AWS SDK to v2

2022-08-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17575632#comment-17575632 ] ASF GitHub Bot commented on HADOOP-18073: - ahmarsuhail opened a new pull request, #4706: URL:

[GitHub] [hadoop] ahmarsuhail opened a new pull request, #4706: HADOOP-18073. Adds in s3 client config and updates list.

2022-08-05 Thread GitBox
ahmarsuhail opened a new pull request, #4706: URL: https://github.com/apache/hadoop/pull/4706 ### Description of PR Draft PR for first set of sdk upgrade changes ### How was this patch tested? -- This is an automated message from the Apache Git Service.

[jira] [Commented] (HADOOP-18373) IOStatisticsContext tuning

2022-08-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17575620#comment-17575620 ] ASF GitHub Bot commented on HADOOP-18373: - hadoop-yetus commented on PR #4705: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4705: HADOOP-18373. IOStatisticsContext tuning

2022-08-05 Thread GitBox
hadoop-yetus commented on PR #4705: URL: https://github.com/apache/hadoop/pull/4705#issuecomment-1206143298 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |