[jira] [Commented] (HADOOP-18920) RPC Metrics : Optimize logic for log slow RPCs

2023-10-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1568#comment-1568 ] ASF GitHub Bot commented on HADOOP-18920: - haiyang1987 commented on PR #6146: URL:

Re: [PR] HADOOP-18920. RPC Metrics : Optimize logic for log slow RPCs [hadoop]

2023-10-19 Thread via GitHub
haiyang1987 commented on PR #6146: URL: https://github.com/apache/hadoop/pull/6146#issuecomment-1772095278 The failed unit test seems unrelated to the change. Hi @goiri @xinglin @ZanderXu please help me take a look it again , thanks. -- This is an automated message from the Apache Git

[jira] [Commented] (HADOOP-18868) Optimize the configuration and use of callqueue overflow trigger failover

2023-10-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1566#comment-1566 ] ASF GitHub Bot commented on HADOOP-18868: - haiyang1987 commented on PR #5998: URL:

Re: [PR] HADOOP-18868. Optimize the configuration and use of callqueue overflow trigger failover [hadoop]

2023-10-19 Thread via GitHub
haiyang1987 commented on PR #5998: URL: https://github.com/apache/hadoop/pull/5998#issuecomment-1772092475 The failed unit test seems unrelated to the change.

[jira] [Commented] (HADOOP-18359) Update commons-cli from 1.2 to 1.5.

2023-10-19 Thread Colm O hEigeartaigh (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1562#comment-1562 ] Colm O hEigeartaigh commented on HADOOP-18359: -- Thanks [~slfan1989] , should it be

Re: [PR] HADOOP-18943. Addendum: Fix trademark description issue of Apache on website. [hadoop-site]

2023-10-19 Thread via GitHub
Hexiaoqiao commented on PR #47: URL: https://github.com/apache/hadoop-site/pull/47#issuecomment-1772020752 Committed. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] HADOOP-18943. Addendum: Fix trademark description issue of Apache on website. [hadoop-site]

2023-10-19 Thread via GitHub
Hexiaoqiao merged PR #47: URL: https://github.com/apache/hadoop-site/pull/47 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HDFS-17063. Datanode configures different Capacity Reserved for each … [hadoop]

2023-10-19 Thread via GitHub
qijiale76 commented on PR #5793: URL: https://github.com/apache/hadoop/pull/5793#issuecomment-1771981416 @tomscut Thanks for your suggestions. New commit has been submitted. These failed tests seem not related to this PR. Could you help check why these tests are failing? -- This is an

[jira] [Commented] (HADOOP-18919) Zookeeper SSL/TLS support in HDFS ZKFC

2023-10-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1506#comment-1506 ] ASF GitHub Bot commented on HADOOP-18919: - fapifta commented on PR #6194: URL:

Re: [PR] HADOOP-18919. Zookeeper SSL/TLS support in HDFS ZKFC [hadoop]

2023-10-19 Thread via GitHub
fapifta commented on PR #6194: URL: https://github.com/apache/hadoop/pull/6194#issuecomment-1771845122 @jojochuang @dombizita checking into the failures, I firmly believe that they were failing because in the meantime there was a bump in Zookeeper version, 3.6.3->3.6.4 and after the

Re: [PR] YARN-11584. Safely fail on leaf queue with empty name [hadoop]

2023-10-19 Thread via GitHub
hadoop-yetus commented on PR #6148: URL: https://github.com/apache/hadoop/pull/6148#issuecomment-1771840256 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-16791 Add getEnclosingRoot API to filesystem interface and all implementations [hadoop]

2023-10-19 Thread via GitHub
mccormickt12 commented on code in PR #6198: URL: https://github.com/apache/hadoop/pull/6198#discussion_r1366201338 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java: ## @@ -4944,6 +4944,24 @@ public CompletableFuture build() throws

Re: [PR] HDFS-16791 Add getEnclosingRoot API to filesystem interface and all implementations [hadoop]

2023-10-19 Thread via GitHub
mccormickt12 commented on code in PR #6198: URL: https://github.com/apache/hadoop/pull/6198#discussion_r1366201130 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java: ## @@ -4944,6 +4944,24 @@ public CompletableFuture build() throws

[jira] [Commented] (HADOOP-18930) make fs.s3a.create.performance an option you can set for the entire bucket

2023-10-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1484#comment-1484 ] ASF GitHub Bot commented on HADOOP-18930: - hadoop-yetus commented on PR #6168: URL:

Re: [PR] HADOOP-18930. Make fs.s3a.create.performance a bucket-wide setting [hadoop]

2023-10-19 Thread via GitHub
hadoop-yetus commented on PR #6168: URL: https://github.com/apache/hadoop/pull/6168#issuecomment-1771768346 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] YARN-11593. [Federation] Improve command line help information. [hadoop]

2023-10-19 Thread via GitHub
hadoop-yetus commented on PR #6199: URL: https://github.com/apache/hadoop/pull/6199#issuecomment-1771749746 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Resolved] (HADOOP-18829) s3a prefetch LRU cache eviction metric

2023-10-19 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani resolved HADOOP-18829. --- Fix Version/s: 3.4.0 3.3.9 Hadoop Flags: Reviewed

[jira] [Commented] (HADOOP-18829) s3a prefetch LRU cache eviction metric

2023-10-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1473#comment-1473 ] ASF GitHub Bot commented on HADOOP-18829: - virajjasani commented on PR #6111: URL:

Re: [PR] HADOOP-18829. S3A prefetch LRU cache eviction metrics (#5893) [hadoop]

2023-10-19 Thread via GitHub
virajjasani commented on PR #6111: URL: https://github.com/apache/hadoop/pull/6111#issuecomment-1771723101 Thanks @mehakmeet -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (HADOOP-18930) make fs.s3a.create.performance an option you can set for the entire bucket

2023-10-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1468#comment-1468 ] ASF GitHub Bot commented on HADOOP-18930: - hadoop-yetus commented on PR #6168: URL:

Re: [PR] HADOOP-18930. Make fs.s3a.create.performance a bucket-wide setting [hadoop]

2023-10-19 Thread via GitHub
hadoop-yetus commented on PR #6168: URL: https://github.com/apache/hadoop/pull/6168#issuecomment-1771694590 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] YARN-9013. [BackPort] [GPG] fix order of steps cleaning Registry entries in ApplicationCleaner. [hadoop]

2023-10-19 Thread via GitHub
hadoop-yetus commented on PR #6147: URL: https://github.com/apache/hadoop/pull/6147#issuecomment-1771671879 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] YARN-11584. Safely fail on leaf queue with empty name [hadoop]

2023-10-19 Thread via GitHub
bgoerlitz commented on code in PR #6148: URL: https://github.com/apache/hadoop/pull/6148#discussion_r1366074215 ##

Re: [PR] YARN-11584. Safely fail on leaf queue with empty name [hadoop]

2023-10-19 Thread via GitHub
bgoerlitz commented on PR #6148: URL: https://github.com/apache/hadoop/pull/6148#issuecomment-1771653899 Thanks for the comments @brumi1024. In fact it turns out that `QueuePath.hasEmptyParts()` does not detect an empty leaf, so I will revise the patch to address the issue there instead.

[jira] [Commented] (HADOOP-18930) make fs.s3a.create.performance an option you can set for the entire bucket

2023-10-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1453#comment-1453 ] ASF GitHub Bot commented on HADOOP-18930: - steveloughran commented on PR #6168: URL:

Re: [PR] HADOOP-18930. Make fs.s3a.create.performance a bucket-wide setting [hadoop]

2023-10-19 Thread via GitHub
steveloughran commented on PR #6168: URL: https://github.com/apache/hadoop/pull/6168#issuecomment-1771636725 lots of work on the tests, including a fix in production code (create("/") must raise IOE) still ITestS3ADeleteCost failing -- This is an automated message from the Apache

Re: [PR] HDFS-16791 Add getEnclosingRoot API to filesystem interface and all implementations [hadoop]

2023-10-19 Thread via GitHub
steveloughran commented on code in PR #6198: URL: https://github.com/apache/hadoop/pull/6198#discussion_r1366042141 ## hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/AbstractContractGetEnclosingRoot.java: ## @@ -0,0 +1,95 @@ +/** + * Licensed to

Re: [PR] MAPREDUCE-7449: Add add-opens flag to container launch commands on JDK17 nodes [hadoop]

2023-10-19 Thread via GitHub
hadoop-yetus commented on PR #6204: URL: https://github.com/apache/hadoop/pull/6204#issuecomment-1771632684 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] MAPREDUCE-7457: Added support to limit count of spill files [hadoop]

2023-10-19 Thread via GitHub
hadoop-yetus commented on PR #6155: URL: https://github.com/apache/hadoop/pull/6155#issuecomment-1771610859 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] MAPREDUCE-7457: Added support to limit count of spill files [hadoop]

2023-10-19 Thread via GitHub
hadoop-yetus commented on PR #6155: URL: https://github.com/apache/hadoop/pull/6155#issuecomment-1771606389 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] YARN-11592. Add timeout to GPGUtils#invokeRMWebService. [hadoop]

2023-10-19 Thread via GitHub
hadoop-yetus commented on PR #6189: URL: https://github.com/apache/hadoop/pull/6189#issuecomment-1771576107 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-18945. S3A: IAMInstanceCredentialsProvider failing. [hadoop]

2023-10-19 Thread via GitHub
hadoop-yetus commented on PR #6202: URL: https://github.com/apache/hadoop/pull/6202#issuecomment-1771569445 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18945) S3A: IAMInstanceCredentialsProvider failing: Failed to load credentials from IMDS

2023-10-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1442#comment-1442 ] ASF GitHub Bot commented on HADOOP-18945: - hadoop-yetus commented on PR #6202: URL:

Re: [PR] MAPREDUCE-7457: Added support to limit count of spill files [hadoop]

2023-10-19 Thread via GitHub
hadoop-yetus commented on PR #6155: URL: https://github.com/apache/hadoop/pull/6155#issuecomment-1771548389 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18925) S3A: add option "fs.s3a.copy.from.local.enabled" to enable/disable CopyFromLocalOperation

2023-10-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1426#comment-1426 ] ASF GitHub Bot commented on HADOOP-18925: - hadoop-yetus commented on PR #6163: URL:

Re: [PR] HADOOP-18925. S3A: option "fs.s3a.optimized.copy.from.local.enabled" to control CopyFromLocalOperation [hadoop]

2023-10-19 Thread via GitHub
hadoop-yetus commented on PR #6163: URL: https://github.com/apache/hadoop/pull/6163#issuecomment-1771505383 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Updated] (HADOOP-18942) Upgrade ZooKeeper to 3.7.2

2023-10-19 Thread Masatake Iwasaki (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Masatake Iwasaki updated HADOOP-18942: -- Fix Version/s: 3.3.7 > Upgrade ZooKeeper to 3.7.2 > -- > >

Re: [PR] CVE-2023-2976 [hadoop-thirdparty]

2023-10-19 Thread via GitHub
Grimoren commented on PR #25: URL: https://github.com/apache/hadoop-thirdparty/pull/25#issuecomment-1771425717 @coheigea @goiri Is it possible to merge either this or #23 ? It looks like the checks have passed on both of them (unless there is some other check we are waiting for?) --

[jira] [Commented] (HADOOP-18359) Update commons-cli from 1.2 to 1.5.

2023-10-19 Thread Shilun Fan (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1398#comment-1398 ] Shilun Fan commented on HADOOP-18359: - [~coheigea] I will continue to follow up on this JIRA and

Re: [PR] MAPREDUCE-7457: Added support to limit count of spill files [hadoop]

2023-10-19 Thread via GitHub
mudit1289 commented on code in PR #6155: URL: https://github.com/apache/hadoop/pull/6155#discussion_r1365889906 ## hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapred/TestMapTask.java: ## @@ -84,4 +93,77 @@ public

Re: [PR] MAPREDUCE-7457: Added support to limit count of spill files [hadoop]

2023-10-19 Thread via GitHub
slfan1989 commented on code in PR #6155: URL: https://github.com/apache/hadoop/pull/6155#discussion_r1365884610 ## hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapred/TestMapTask.java: ## @@ -84,4 +93,77 @@ public

Re: [PR] MAPREDUCE-7457: Added support to limit count of spill files [hadoop]

2023-10-19 Thread via GitHub
slfan1989 commented on code in PR #6155: URL: https://github.com/apache/hadoop/pull/6155#discussion_r1365883869 ## hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/MapTask.java: ## @@ -984,10 +987,16 @@ public

[jira] [Commented] (HADOOP-18919) Zookeeper SSL/TLS support in HDFS ZKFC

2023-10-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1392#comment-1392 ] ASF GitHub Bot commented on HADOOP-18919: - jojochuang commented on PR #6194: URL:

Re: [PR] HADOOP-18919. Zookeeper SSL/TLS support in HDFS ZKFC [hadoop]

2023-10-19 Thread via GitHub
jojochuang commented on PR #6194: URL: https://github.com/apache/hadoop/pull/6194#issuecomment-1771407719 @dombizita a few test failures may be related TestActiveStandbyElector, TestZKCuratorManager, TestSecureZKCuratorManager -- This is an automated message from the Apache Git Service.

Re: [PR] YARN-11593. [Federation] Improve command line help information. [hadoop]

2023-10-19 Thread via GitHub
slfan1989 commented on PR #6199: URL: https://github.com/apache/hadoop/pull/6199#issuecomment-1771406631 @goiri Can you help review this PR again? Thank you very much! I improved the code to make it more readable. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] YARN-9013. [BackPort] [GPG] fix order of steps cleaning Registry entries in ApplicationCleaner. [hadoop]

2023-10-19 Thread via GitHub
slfan1989 commented on code in PR #6147: URL: https://github.com/apache/hadoop/pull/6147#discussion_r1365878423 ##

Re: [PR] YARN-9013. [BackPort] [GPG] fix order of steps cleaning Registry entries in ApplicationCleaner. [hadoop]

2023-10-19 Thread via GitHub
slfan1989 commented on code in PR #6147: URL: https://github.com/apache/hadoop/pull/6147#discussion_r1365877007 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java: ## @@ -4367,7 +4367,7 @@ public static boolean

[jira] [Commented] (HADOOP-18945) S3A: IAMInstanceCredentialsProvider failing: Failed to load credentials from IMDS

2023-10-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1382#comment-1382 ] ASF GitHub Bot commented on HADOOP-18945: - hadoop-yetus commented on PR #6202: URL:

Re: [PR] HADOOP-18945. S3A: IAMInstanceCredentialsProvider failing. [hadoop]

2023-10-19 Thread via GitHub
hadoop-yetus commented on PR #6202: URL: https://github.com/apache/hadoop/pull/6202#issuecomment-1771396963 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] YARN-11592. Add timeout to GPGUtils#invokeRMWebService. [hadoop]

2023-10-19 Thread via GitHub
slfan1989 commented on code in PR #6189: URL: https://github.com/apache/hadoop/pull/6189#discussion_r1365869956 ##

Re: [PR] YARN-11593. [Federation] Improve command line help information. [hadoop]

2023-10-19 Thread via GitHub
slfan1989 commented on code in PR #6199: URL: https://github.com/apache/hadoop/pull/6199#discussion_r1365864346 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/RouterCLI.java: ## @@ -159,43 +214,59 @@ public

Re: [PR] YARN-11593. [Federation] Improve command line help information. [hadoop]

2023-10-19 Thread via GitHub
slfan1989 commented on code in PR #6199: URL: https://github.com/apache/hadoop/pull/6199#discussion_r1365863997 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/RouterCLI.java: ## @@ -77,25 +79,70 @@ public class RouterCLI

[jira] [Commented] (HADOOP-18830) Cut S3 Select

2023-10-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1363#comment-1363 ] ASF GitHub Bot commented on HADOOP-18830: - steveloughran commented on PR #6144: URL:

Re: [PR] HADOOP-18830. Cut S3 Select [hadoop]

2023-10-19 Thread via GitHub
steveloughran commented on PR #6144: URL: https://github.com/apache/hadoop/pull/6144#issuecomment-1771335503 keeping but moving csv file. it's actually very useful in places; in cloudstore we use it in places like "bandwidth" to track block upload times. so it may be useful in

Re: [PR] HDFS-16791 Add getEnclosingRoot API to filesystem interface and all implementations [hadoop]

2023-10-19 Thread via GitHub
goiri commented on code in PR #6198: URL: https://github.com/apache/hadoop/pull/6198#discussion_r1365815964 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientNamenodeProtocolServerSideTranslatorPB.java: ## @@ -25,22 +25,21 @@ import

Re: [PR] HDFS-16791 Add getEnclosingRoot API to filesystem interface and all implementations [hadoop]

2023-10-19 Thread via GitHub
goiri commented on code in PR #6198: URL: https://github.com/apache/hadoop/pull/6198#discussion_r1365814904 ## hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestGetEnclosingRoot.java: ## @@ -0,0 +1,94 @@ +/** + * Licensed to the Apache Software

[jira] [Updated] (HADOOP-18946) S3A: testMultiObjectExceptionFilledIn() assertion error

2023-10-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18946: Labels: pull-request-available (was: ) > S3A: testMultiObjectExceptionFilledIn()

[jira] [Commented] (HADOOP-18946) S3A: testMultiObjectExceptionFilledIn() assertion error

2023-10-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1343#comment-1343 ] ASF GitHub Bot commented on HADOOP-18946: - steveloughran opened a new pull request, #6205: URL:

[jira] [Commented] (HADOOP-18359) Update commons-cli from 1.2 to 1.5.

2023-10-19 Thread PJ Fanning (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1299#comment-1299 ] PJ Fanning commented on HADOOP-18359: - [~coheigea] I have not been involved with this issue. I am

[jira] [Commented] (HADOOP-18359) Update commons-cli from 1.2 to 1.5.

2023-10-19 Thread Colm O hEigeartaigh (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1298#comment-1298 ] Colm O hEigeartaigh commented on HADOOP-18359: -- [~pj.fanning] Any chance this can get

Re: [PR] HDFS-17063. Datanode configures different Capacity Reserved for each … [hadoop]

2023-10-19 Thread via GitHub
hadoop-yetus commented on PR #5793: URL: https://github.com/apache/hadoop/pull/5793#issuecomment-1771071562 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18868) Optimize the configuration and use of callqueue overflow trigger failover

2023-10-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1269#comment-1269 ] ASF GitHub Bot commented on HADOOP-18868: - hadoop-yetus commented on PR #5998: URL:

Re: [PR] HADOOP-18868. Optimize the configuration and use of callqueue overflow trigger failover [hadoop]

2023-10-19 Thread via GitHub
hadoop-yetus commented on PR #5998: URL: https://github.com/apache/hadoop/pull/5998#issuecomment-1770986362 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[PR] MAPREDUCE-7449: Add add-opens flag to container launch commands on JDK17 nodes [hadoop]

2023-10-19 Thread via GitHub
brumi1024 opened a new pull request, #6204: URL: https://github.com/apache/hadoop/pull/6204 Backport of #5935. ### Description of PR ### How was this patch tested? ### For code changes: - [ ] Does the title or this PR starts with the corresponding

[jira] [Commented] (HADOOP-18920) RPC Metrics : Optimize logic for log slow RPCs

2023-10-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1262#comment-1262 ] ASF GitHub Bot commented on HADOOP-18920: - hadoop-yetus commented on PR #6146: URL:

Re: [PR] HADOOP-18920. RPC Metrics : Optimize logic for log slow RPCs [hadoop]

2023-10-19 Thread via GitHub
hadoop-yetus commented on PR #6146: URL: https://github.com/apache/hadoop/pull/6146#issuecomment-1770969297 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18944) s3a openfile is using readahead rather than async drain threshold to calculate drain threshold

2023-10-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1254#comment-1254 ] ASF GitHub Bot commented on HADOOP-18944: - hadoop-yetus commented on PR #6203: URL:

Re: [PR] HADOOP-18944. fix default value of Async drain threshold in S3A OpenFile [hadoop]

2023-10-19 Thread via GitHub
hadoop-yetus commented on PR #6203: URL: https://github.com/apache/hadoop/pull/6203#issuecomment-1770927563 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18487) Make protobuf 2.5 an optional runtime dependency.

2023-10-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1218#comment-1218 ] ASF GitHub Bot commented on HADOOP-18487: - steveloughran commented on PR #6185: URL:

Re: [PR] HADOOP-18487. Protobuf 2.5 removal part 2: stop exporting protobuf-2.5" [hadoop]

2023-10-19 Thread via GitHub
steveloughran commented on PR #6185: URL: https://github.com/apache/hadoop/pull/6185#issuecomment-1770720017 @mukund-thakur i believe test failure is unrelated, created https://issues.apache.org/jira/browse/HADOOP-18946 will check that again to see if trunk has it. -- This is an

[jira] [Assigned] (HADOOP-18946) S3A: testMultiObjectExceptionFilledIn() assertion error

2023-10-19 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran reassigned HADOOP-18946: --- Assignee: Steve Loughran > S3A: testMultiObjectExceptionFilledIn() assertion

[jira] [Commented] (HADOOP-18945) S3A: IAMInstanceCredentialsProvider failing: Failed to load credentials from IMDS

2023-10-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1217#comment-1217 ] ASF GitHub Bot commented on HADOOP-18945: - steveloughran commented on code in PR #6202: URL:

[jira] [Commented] (HADOOP-18944) s3a openfile is using readahead rather than async drain threshold to calculate drain threshold

2023-10-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1215#comment-1215 ] ASF GitHub Bot commented on HADOOP-18944: - mehakmeet commented on PR #6203: URL:

Re: [PR] HADOOP-18944. fix default value of Async drain threshold in S3A OpenFile [hadoop]

2023-10-19 Thread via GitHub
mehakmeet commented on PR #6203: URL: https://github.com/apache/hadoop/pull/6203#issuecomment-1770714987 hadoop-aws test suite run in progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] HADOOP-18945. S3A: IAMInstanceCredentialsProvider failing. [hadoop]

2023-10-19 Thread via GitHub
steveloughran commented on code in PR #6202: URL: https://github.com/apache/hadoop/pull/6202#discussion_r1365370076 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/auth/IAMInstanceCredentialsProvider.java: ## @@ -78,23 +117,52 @@ public AwsCredentials

[jira] [Commented] (HADOOP-18829) s3a prefetch LRU cache eviction metric

2023-10-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1213#comment-1213 ] ASF GitHub Bot commented on HADOOP-18829: - mehakmeet commented on PR #6111: URL:

[jira] [Commented] (HADOOP-18829) s3a prefetch LRU cache eviction metric

2023-10-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1212#comment-1212 ] ASF GitHub Bot commented on HADOOP-18829: - mehakmeet merged PR #6111: URL:

Re: [PR] HADOOP-18829. S3A prefetch LRU cache eviction metrics (#5893) [hadoop]

2023-10-19 Thread via GitHub
mehakmeet commented on PR #6111: URL: https://github.com/apache/hadoop/pull/6111#issuecomment-1770710613 Sorry, missed this one. Merged now. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] HADOOP-18829. S3A prefetch LRU cache eviction metrics (#5893) [hadoop]

2023-10-19 Thread via GitHub
mehakmeet merged PR #6111: URL: https://github.com/apache/hadoop/pull/6111 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Resolved] (HADOOP-18942) Upgrade ZooKeeper to 3.7.2

2023-10-19 Thread Masatake Iwasaki (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Masatake Iwasaki resolved HADOOP-18942. --- Fix Version/s: 3.4.0 Hadoop Flags: Reviewed Resolution: Fixed >

[jira] [Updated] (HADOOP-18944) s3a openfile is using readahead rather than async drain threshold to calculate drain threshold

2023-10-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18944: Labels: pull-request-available (was: ) > s3a openfile is using readahead rather than

[PR] HADOOP-18944. fix default value of Async drain threshold in S3A OpenFile [hadoop]

2023-10-19 Thread via GitHub
mehakmeet opened a new pull request, #6203: URL: https://github.com/apache/hadoop/pull/6203 ### Description of PR Changing the default value of async drain threshold from read-ahead's default value to actual async drain threshold default value. ### How was this patch tested?

[jira] [Commented] (HADOOP-18944) s3a openfile is using readahead rather than async drain threshold to calculate drain threshold

2023-10-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1196#comment-1196 ] ASF GitHub Bot commented on HADOOP-18944: - mehakmeet opened a new pull request, #6203: URL:

Re: [PR] HADOOP-18942. Upgrade ZooKeeper to 3.7.2. [hadoop]

2023-10-19 Thread via GitHub
iwasakims commented on PR #6200: URL: https://github.com/apache/hadoop/pull/6200#issuecomment-1770459383 Thanks, @ayushtkn. I merged this to trunk. I will cherry-pick this to branch-3.3 after some testing. -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (HADOOP-18942) Upgrade ZooKeeper to 3.7.2

2023-10-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1166#comment-1166 ] ASF GitHub Bot commented on HADOOP-18942: - iwasakims commented on PR #6200: URL:

Re: [PR] HADOOP-18942. Upgrade ZooKeeper to 3.7.2. [hadoop]

2023-10-19 Thread via GitHub
iwasakims merged PR #6200: URL: https://github.com/apache/hadoop/pull/6200 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HADOOP-18943. Addendum: Fix trademark description issue of Apache on website. [hadoop-site]

2023-10-19 Thread via GitHub
Hexiaoqiao commented on PR #47: URL: https://github.com/apache/hadoop-site/pull/47#issuecomment-1770430810 Thanks @aajisaka and @ayushtkn . I try to update the PR: modify `src/description.md` then generate other files by `hugo`. Please take another review. Thanks again. -- This is an

[jira] [Commented] (HADOOP-18918) ITestS3GuardTool fails if SSE/DSSE encryption is used

2023-10-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1148#comment-1148 ] ASF GitHub Bot commented on HADOOP-18918: - hadoop-yetus commented on PR #6165: URL:

Re: [PR] HADOOP-18918. ITestS3GuardTool fails if SSE/DSSE encryption is used [hadoop]

2023-10-19 Thread via GitHub
hadoop-yetus commented on PR #6165: URL: https://github.com/apache/hadoop/pull/6165#issuecomment-1770403861 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18919) Zookeeper SSL/TLS support in HDFS ZKFC

2023-10-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1146#comment-1146 ] ASF GitHub Bot commented on HADOOP-18919: - brumi1024 commented on PR #6194: URL:

Re: [PR] HADOOP-18919. Zookeeper SSL/TLS support in HDFS ZKFC [hadoop]

2023-10-19 Thread via GitHub
brumi1024 commented on PR #6194: URL: https://github.com/apache/hadoop/pull/6194#issuecomment-1770392954 > Unrelated question... in [HADOOP-18709](https://github.com/apache/hadoop/pull/5638/files#top) a new dependency was added (netty-transport-native-epoll) it's a native lib for Netty to

Re: [PR] HADOOP-18918. ITestS3GuardTool fails if SSE/DSSE encryption is used [hadoop]

2023-10-19 Thread via GitHub
virajjasani commented on code in PR #6165: URL: https://github.com/apache/hadoop/pull/6165#discussion_r1365039090 ## hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/S3ATestUtils.java: ## @@ -1471,6 +1471,20 @@ public static void

[jira] [Commented] (HADOOP-18918) ITestS3GuardTool fails if SSE/DSSE encryption is used

2023-10-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1084#comment-1084 ] ASF GitHub Bot commented on HADOOP-18918: - virajjasani commented on code in PR #6165: URL:

[jira] [Commented] (HADOOP-18918) ITestS3GuardTool fails if SSE/DSSE encryption is used

2023-10-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1083#comment-1083 ] ASF GitHub Bot commented on HADOOP-18918: - virajjasani commented on PR #6165: URL:

Re: [PR] HADOOP-18918. ITestS3GuardTool fails if SSE/DSSE encryption is used [hadoop]

2023-10-19 Thread via GitHub
virajjasani commented on PR #6165: URL: https://github.com/apache/hadoop/pull/6165#issuecomment-1770220486 `TestErrorTranslation` seems recent regression, the base branch of this PR does not even have the test. -- This is an automated message from the Apache Git Service. To respond to

[jira] [Commented] (HADOOP-18918) ITestS3GuardTool fails if SSE/DSSE encryption is used

2023-10-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1081#comment-1081 ] ASF GitHub Bot commented on HADOOP-18918: - ahmarsuhail commented on code in PR #6165: URL:

Re: [PR] HADOOP-18918. ITestS3GuardTool fails if SSE/DSSE encryption is used [hadoop]

2023-10-19 Thread via GitHub
ahmarsuhail commented on code in PR #6165: URL: https://github.com/apache/hadoop/pull/6165#discussion_r1365032397 ## hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/S3ATestUtils.java: ## @@ -1471,6 +1471,20 @@ public static void

Re: [PR] HADOOP-18943. Addendum: Fix trademark description issue of Apache on website. [hadoop-site]

2023-10-19 Thread via GitHub
ayushtkn commented on PR #47: URL: https://github.com/apache/hadoop-site/pull/47#issuecomment-1770163016 This is my diff on master after running hugo, maybe you can try this & push ``` diff --git a/content/index.html b/content/index.html index 4944f7c6d3..6ef5783533 100644 ---

Re: [PR] HADOOP-18943. Addendum: Fix trademark description issue of Apache on website. [hadoop-site]

2023-10-19 Thread via GitHub
ayushtkn commented on PR #47: URL: https://github.com/apache/hadoop-site/pull/47#issuecomment-1770123790 Your hugo version is different than the one used to built previously -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub