[
https://issues.apache.org/jira/browse/HADOOP-10670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14380510#comment-14380510
]
Charles Lamb commented on HADOOP-10670:
---
[~wheat9],[~drankye],
Is it possible
[
https://issues.apache.org/jira/browse/HADOOP-9477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14317993#comment-14317993
]
Charles Lamb commented on HADOOP-9477:
--
Hi [~dapengsun],
As near as I can tell, the
[
https://issues.apache.org/jira/browse/HADOOP-9477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Charles Lamb updated HADOOP-9477:
-
Attachment: HADOOP-9477.003.patch
[~drankye],
I have posted a rebased version of your patch
[
https://issues.apache.org/jira/browse/HADOOP-9477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14316744#comment-14316744
]
Charles Lamb commented on HADOOP-9477:
--
TestHttpServerLifecycle passes on my local
[
https://issues.apache.org/jira/browse/HADOOP-9477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14316904#comment-14316904
]
Charles Lamb commented on HADOOP-9477:
--
[~drankye],
I was informed offline that it
[
https://issues.apache.org/jira/browse/HADOOP-9477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14317531#comment-14317531
]
Charles Lamb commented on HADOOP-9477:
--
That would be great. I'm happy to help.
[
https://issues.apache.org/jira/browse/HADOOP-11510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14293534#comment-14293534
]
Charles Lamb commented on HADOOP-11510:
---
[~hitliuyi],
Looks good. One small nit.
[
https://issues.apache.org/jira/browse/HADOOP-11478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Charles Lamb resolved HADOOP-11478.
---
Resolution: Not a Problem
HttpFSServer does not properly impersonate a real user when
[
https://issues.apache.org/jira/browse/HADOOP-11478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14293894#comment-14293894
]
Charles Lamb commented on HADOOP-11478:
---
[~ranadip],
I assume that when you
[
https://issues.apache.org/jira/browse/HADOOP-11469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14291791#comment-14291791
]
Charles Lamb commented on HADOOP-11469:
---
I wish I could, but I'm not a real
[
https://issues.apache.org/jira/browse/HADOOP-11493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14287732#comment-14287732
]
Charles Lamb commented on HADOOP-11493:
---
Oh, good catch. The .002 patch fixes
[
https://issues.apache.org/jira/browse/HADOOP-11493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Charles Lamb updated HADOOP-11493:
--
Attachment: HADOOP-11493.002.patch
Typo in kms-acls.xml description for
[
https://issues.apache.org/jira/browse/HADOOP-11479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Charles Lamb resolved HADOOP-11479.
---
Resolution: Not a Problem
hdfs crypto -createZone fails to impersonate the real user in a
[
https://issues.apache.org/jira/browse/HADOOP-11479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14285884#comment-14285884
]
Charles Lamb commented on HADOOP-11479:
---
[~ranadip],
I haven't heard back about
[
https://issues.apache.org/jira/browse/HADOOP-11493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Charles Lamb updated HADOOP-11493:
--
Attachment: HADOOP-11493.001.patch
Typo in kms-acls.xml description for
[
https://issues.apache.org/jira/browse/HADOOP-11493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14286931#comment-14286931
]
Charles Lamb commented on HADOOP-11493:
---
Thanks for the review [~ajisakaa]. The
[
https://issues.apache.org/jira/browse/HADOOP-11493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Charles Lamb updated HADOOP-11493:
--
Attachment: HADOOP-11493.000.patch
Typo in kms-acls.xml description for
Charles Lamb created HADOOP-11493:
-
Summary: Typo in kms-acls.xml description for
hadoop.kms.acl.ROLLOVER
Key: HADOOP-11493
URL: https://issues.apache.org/jira/browse/HADOOP-11493
Project: Hadoop
[
https://issues.apache.org/jira/browse/HADOOP-11493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Charles Lamb updated HADOOP-11493:
--
Status: Patch Available (was: Open)
Typo in kms-acls.xml description for
[
https://issues.apache.org/jira/browse/HADOOP-11479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14280870#comment-14280870
]
Charles Lamb commented on HADOOP-11479:
---
[~ranadip],
I am pretty sure that the
[
https://issues.apache.org/jira/browse/HADOOP-11469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14278839#comment-14278839
]
Charles Lamb commented on HADOOP-11469:
---
That's a nice simple test solution. The
[
https://issues.apache.org/jira/browse/HADOOP-11479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279284#comment-14279284
]
Charles Lamb commented on HADOOP-11479:
---
[~ranadip],
Just to confirm, you are
[
https://issues.apache.org/jira/browse/HADOOP-11469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279722#comment-14279722
]
Charles Lamb commented on HADOOP-11469:
---
LGTM. +1 (non-binding)
KMS should skip
[
https://issues.apache.org/jira/browse/HADOOP-11469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Charles Lamb updated HADOOP-11469:
--
Description: KMSACLs#setKeyACLs, loads key ACLs from the configuration by
checking if the key
[
https://issues.apache.org/jira/browse/HADOOP-11469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14276937#comment-14276937
]
Charles Lamb commented on HADOOP-11469:
---
Hi [~dian.fu],
In general this looks
[
https://issues.apache.org/jira/browse/HADOOP-11455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Charles Lamb updated HADOOP-11455:
--
Attachment: HADOOP-11455.001.patch
KMS and Credential CLI should request confirmation for
[
https://issues.apache.org/jira/browse/HADOOP-11455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14263994#comment-14263994
]
Charles Lamb commented on HADOOP-11455:
---
Hi [~hitliuyi],
Thanks for the review.
Charles Lamb created HADOOP-11455:
-
Summary: KMS and Credential CLI should request confirmation for
deletion by default
Key: HADOOP-11455
URL: https://issues.apache.org/jira/browse/HADOOP-11455
[
https://issues.apache.org/jira/browse/HADOOP-11455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Charles Lamb updated HADOOP-11455:
--
Status: Patch Available (was: Open)
KMS and Credential CLI should request confirmation for
[
https://issues.apache.org/jira/browse/HADOOP-11455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Charles Lamb updated HADOOP-11455:
--
Attachment: HADOOP-11455.000.patch
The attached patch relates to the hadoop credential delete
[
https://issues.apache.org/jira/browse/HADOOP-11394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14244164#comment-14244164
]
Charles Lamb commented on HADOOP-11394:
---
non-binding +1 from me.
hadoop-aws
Charles Lamb created HADOOP-11289:
-
Summary: Fix typo in RpcInfo log message
Key: HADOOP-11289
URL: https://issues.apache.org/jira/browse/HADOOP-11289
Project: Hadoop Common
Issue Type: Bug
[
https://issues.apache.org/jira/browse/HADOOP-11289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Charles Lamb updated HADOOP-11289:
--
Summary: Fix typo in RpcUtil log message (was: Fix typo in RpcInfo log
message)
Fix typo
[
https://issues.apache.org/jira/browse/HADOOP-11289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Charles Lamb updated HADOOP-11289:
--
Attachment: HADOOP-11289.001.patch
Patch fixes the typo.
Fix typo in RpcUtil log message
[
https://issues.apache.org/jira/browse/HADOOP-11289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Charles Lamb updated HADOOP-11289:
--
Status: Patch Available (was: Open)
Fix typo in RpcUtil log message
[
https://issues.apache.org/jira/browse/HADOOP-11289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14205180#comment-14205180
]
Charles Lamb commented on HADOOP-11289:
---
Thank you [~wheat9] for the quick review
[
https://issues.apache.org/jira/browse/HADOOP-11026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Charles Lamb resolved HADOOP-11026.
---
Resolution: Duplicate
Fix Version/s: 2.7.0
The doc changes were included in
[
https://issues.apache.org/jira/browse/HADOOP-11176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14163811#comment-14163811
]
Charles Lamb commented on HADOOP-11176:
---
[~asuresh],
Just two nits.
This change:
[
https://issues.apache.org/jira/browse/HADOOP-11176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Charles Lamb updated HADOOP-11176:
--
Summary: KMSClientProvider authentication fails when both currentUgi and
loginUgi are a
[
https://issues.apache.org/jira/browse/HADOOP-11160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14157253#comment-14157253
]
Charles Lamb commented on HADOOP-11160:
---
And thank you [~wheat9] for the quick
[
https://issues.apache.org/jira/browse/HADOOP-10714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14153394#comment-14153394
]
Charles Lamb commented on HADOOP-10714:
---
bq. charles —you happy with this?
Yes,
[
https://issues.apache.org/jira/browse/HADOOP-10714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14151740#comment-14151740
]
Charles Lamb commented on HADOOP-10714:
---
[~j...@cloudera.com],
I'm having trouble
[
https://issues.apache.org/jira/browse/HADOOP-10714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14151919#comment-14151919
]
Charles Lamb commented on HADOOP-10714:
---
[~j...@cloudera.com],
The tests all
[
https://issues.apache.org/jira/browse/HADOOP-3?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Charles Lamb updated HADOOP-3:
--
Assignee: Arun Suresh (was: Charles Lamb)
Namenode not able to reconnect to KMS after KMS
[
https://issues.apache.org/jira/browse/HADOOP-3?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Charles Lamb reassigned HADOOP-3:
-
Assignee: Charles Lamb (was: Arun Suresh)
Namenode not able to reconnect to KMS
[
https://issues.apache.org/jira/browse/HADOOP-10714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14141944#comment-14141944
]
Charles Lamb commented on HADOOP-10714:
---
Hi Juan,
The Hadoop Coding Standards are
[
https://issues.apache.org/jira/browse/HADOOP-10714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14141506#comment-14141506
]
Charles Lamb commented on HADOOP-10714:
---
General:
* Several lines bust the 80
[
https://issues.apache.org/jira/browse/HADOOP-10714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14141692#comment-14141692
]
Charles Lamb commented on HADOOP-10714:
---
BTW Juan, I apologize for my terse
Charles Lamb created HADOOP-11097:
-
Summary: kms docs say proxyusers, not proxyuser for config params
Key: HADOOP-11097
URL: https://issues.apache.org/jira/browse/HADOOP-11097
Project: Hadoop Common
[
https://issues.apache.org/jira/browse/HADOOP-11097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Charles Lamb updated HADOOP-11097:
--
Attachment: HADOOP-11097.001.patch
Here's a patch that corrects the parameters.
kms docs
[
https://issues.apache.org/jira/browse/HADOOP-11097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on HADOOP-11097 started by Charles Lamb.
-
kms docs say proxyusers, not proxyuser for config params
[
https://issues.apache.org/jira/browse/HADOOP-11097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14136347#comment-14136347
]
Charles Lamb commented on HADOOP-11097:
---
No tests are required -- it's a simple
[
https://issues.apache.org/jira/browse/HADOOP-11062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14127048#comment-14127048
]
Charles Lamb commented on HADOOP-11062:
---
Hi [~asuresh],
I wonder if you should
[
https://issues.apache.org/jira/browse/HADOOP-11062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14127123#comment-14127123
]
Charles Lamb commented on HADOOP-11062:
---
I forgot to ask why there's a surefire
[
https://issues.apache.org/jira/browse/HADOOP-11062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14122883#comment-14122883
]
Charles Lamb commented on HADOOP-11062:
---
Hi [~asuresh],
I was under the
[
https://issues.apache.org/jira/browse/HADOOP-11062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Charles Lamb reassigned HADOOP-11062:
-
Assignee: Charles Lamb (was: Andrew Wang)
CryptoCodec testcases requiring OpenSSL
[
https://issues.apache.org/jira/browse/HADOOP-11062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Charles Lamb updated HADOOP-11062:
--
Assignee: Arun Suresh (was: Charles Lamb)
CryptoCodec testcases requiring OpenSSL should be
Charles Lamb created HADOOP-11026:
-
Summary: add FileSystem contract specification for
FSDataInputStream and FSDataOutputStream#isEncrypted
Key: HADOOP-11026
URL:
[
https://issues.apache.org/jira/browse/HADOOP-11026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Charles Lamb updated HADOOP-11026:
--
Attachment: HADOOP-11026-prelim.001.patch
Here are some preliminary diffs for the
[
https://issues.apache.org/jira/browse/HADOOP-11026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on HADOOP-11026 started by Charles Lamb.
add FileSystem contract specification for FSDataInputStream and
FSDataOutputStream#isEncrypted
[
https://issues.apache.org/jira/browse/HADOOP-11026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Charles Lamb updated HADOOP-11026:
--
Attachment: HADOOP-11026.001.patch
This patch adds the test case to
[
https://issues.apache.org/jira/browse/HADOOP-11026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on HADOOP-11026 stopped by Charles Lamb.
add FileSystem contract specification for FSDataInputStream and
FSDataOutputStream#isEncrypted
Charles Lamb created HADOOP-11006:
-
Summary: cp should automatically use /.reserved/raw when run by
the superuser
Key: HADOOP-11006
URL: https://issues.apache.org/jira/browse/HADOOP-11006
Project:
[
https://issues.apache.org/jira/browse/HADOOP-10919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14096037#comment-14096037
]
Charles Lamb commented on HADOOP-10919:
---
I'll update the HDFS-6509 doc to reflect
[
https://issues.apache.org/jira/browse/HADOOP-10919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14096358#comment-14096358
]
Charles Lamb commented on HADOOP-10919:
---
bq. Q. when you say distcp /r/r/src
[
https://issues.apache.org/jira/browse/HADOOP-10919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14094661#comment-14094661
]
Charles Lamb commented on HADOOP-10919:
---
Hi [~sanjay.radia],
bq. Is this
[
https://issues.apache.org/jira/browse/HADOOP-10919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14095158#comment-14095158
]
Charles Lamb commented on HADOOP-10919:
---
Hi Sanjay,
The trashing would be due to
[
https://issues.apache.org/jira/browse/HADOOP-10919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14093557#comment-14093557
]
Charles Lamb commented on HADOOP-10919:
---
bq. Charles, you list disadvantage for
[
https://issues.apache.org/jira/browse/HADOOP-10919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14093565#comment-14093565
]
Charles Lamb commented on HADOOP-10919:
---
Sanjay,
I just re-read your comment and
[
https://issues.apache.org/jira/browse/HADOOP-10919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14093611#comment-14093611
]
Charles Lamb commented on HADOOP-10919:
---
Sanjay,
There are three scenarios.
(1)
[
https://issues.apache.org/jira/browse/HADOOP-10919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14093620#comment-14093620
]
Charles Lamb commented on HADOOP-10919:
---
I should clarify case (1). If you are
[
https://issues.apache.org/jira/browse/HADOOP-10919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Charles Lamb updated HADOOP-10919:
--
Description:
Refer to the doc attached to HDFS-6509 for background.
Like distcp -p (see
[
https://issues.apache.org/jira/browse/HADOOP-10919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Charles Lamb resolved HADOOP-10919.
---
Resolution: Fixed
Fix Version/s: fs-encryption (HADOOP-10150 and HDFS-6134)
Thanks
[
https://issues.apache.org/jira/browse/HADOOP-10919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Charles Lamb updated HADOOP-10919:
--
Attachment: (was: HADOOP-10919.001.patch)
Copy command should preserve raw.* namespace
[
https://issues.apache.org/jira/browse/HADOOP-10919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Charles Lamb updated HADOOP-10919:
--
Attachment: HADOOP-10919.001.patch
This patch more closely matches the proposed behavior of
[
https://issues.apache.org/jira/browse/HADOOP-10919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Charles Lamb updated HADOOP-10919:
--
Attachment: HADOOP-10919.002.patch
Thanks for the review [~andrew.wang]. I believe the .002
[
https://issues.apache.org/jira/browse/HADOOP-10919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on HADOOP-10919 started by Charles Lamb.
Copy command should preserve raw.* namespace extended attributes
[
https://issues.apache.org/jira/browse/HADOOP-10919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Charles Lamb updated HADOOP-10919:
--
Attachment: HADOOP-10919.001.patch
Here's a patch to implement the -pd option for cp,
[
https://issues.apache.org/jira/browse/HADOOP-10886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14084458#comment-14084458
]
Charles Lamb commented on HADOOP-10886:
---
+1. Thanks Uma.
[
https://issues.apache.org/jira/browse/HADOOP-10936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14085333#comment-14085333
]
Charles Lamb commented on HADOOP-10936:
---
Seems like the right thing.
Change
Charles Lamb created HADOOP-10919:
-
Summary: Copy command should preserve raw.* namespace extended
attributes
Key: HADOOP-10919
URL: https://issues.apache.org/jira/browse/HADOOP-10919
Project: Hadoop
[
https://issues.apache.org/jira/browse/HADOOP-10870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14069605#comment-14069605
]
Charles Lamb commented on HADOOP-10870:
---
Thanks Colin. This is an improvement.
[
https://issues.apache.org/jira/browse/HADOOP-10736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14046285#comment-14046285
]
Charles Lamb commented on HADOOP-10736:
---
bq. Attributes must be in attribute=value
[
https://issues.apache.org/jira/browse/HADOOP-10736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14045318#comment-14045318
]
Charles Lamb commented on HADOOP-10736:
---
KeyProvider.java:
Use final on
[
https://issues.apache.org/jira/browse/HADOOP-10695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14038999#comment-14038999
]
Charles Lamb commented on HADOOP-10695:
---
The 1000 is an arg to the setFooTimeout()
[
https://issues.apache.org/jira/browse/HADOOP-10695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14038105#comment-14038105
]
Charles Lamb commented on HADOOP-10695:
---
I would think you would want separate
[
https://issues.apache.org/jira/browse/HADOOP-10713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14038261#comment-14038261
]
Charles Lamb commented on HADOOP-10713:
---
+1
Refactor
[
https://issues.apache.org/jira/browse/HADOOP-10719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14036444#comment-14036444
]
Charles Lamb commented on HADOOP-10719:
---
[~tucu00]
In general, LGTM.
When
[
https://issues.apache.org/jira/browse/HADOOP-10696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14033246#comment-14033246
]
Charles Lamb commented on HADOOP-10696:
---
Hi Tucu,
Just a few nits.
As has been
[
https://issues.apache.org/jira/browse/HADOOP-10561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14016484#comment-14016484
]
Charles Lamb commented on HADOOP-10561:
---
Hi Yi,
I thought we had standardized on
[
https://issues.apache.org/jira/browse/HADOOP-10561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14016746#comment-14016746
]
Charles Lamb commented on HADOOP-10561:
---
Yi,
This looks pretty good. A few more
[
https://issues.apache.org/jira/browse/HADOOP-10561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14015438#comment-14015438
]
Charles Lamb commented on HADOOP-10561:
---
Hi Yi,
The usage message is a little bit
[
https://issues.apache.org/jira/browse/HADOOP-10635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14012441#comment-14012441
]
Charles Lamb commented on HADOOP-10635:
---
In general this looks good. I have a few
[
https://issues.apache.org/jira/browse/HADOOP-10628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Charles Lamb resolved HADOOP-10628.
---
Resolution: Fixed
Thanks Yi, I committed this to fs-encryption.
Javadoc and few code
[
https://issues.apache.org/jira/browse/HADOOP-10628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14011440#comment-14011440
]
Charles Lamb commented on HADOOP-10628:
---
+1. Thanks Yi.
Javadoc and few code
[
https://issues.apache.org/jira/browse/HADOOP-10603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14007457#comment-14007457
]
Charles Lamb commented on HADOOP-10603:
---
Yi,
I'm sorry I didn't get these
[
https://issues.apache.org/jira/browse/HADOOP-10603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14007827#comment-14007827
]
Charles Lamb commented on HADOOP-10603:
---
Sounds good.
+1
Crypto input and
[
https://issues.apache.org/jira/browse/HADOOP-10603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14007829#comment-14007829
]
Charles Lamb commented on HADOOP-10603:
---
+1
Crypto input and output streams
[
https://issues.apache.org/jira/browse/HADOOP-10603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14006624#comment-14006624
]
Charles Lamb commented on HADOOP-10603:
---
Hi Yi,
Good work so far. I took your
[
https://issues.apache.org/jira/browse/HADOOP-10603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14006628#comment-14006628
]
Charles Lamb commented on HADOOP-10603:
---
CryptoInputStream.java:
Shouldn't
1 - 100 of 127 matches
Mail list logo
