[jira] [Resolved] (HADOOP-9112) test-patch should -1 for @Tests without a timeout

[ https://issues.apache.org/jira/browse/HADOOP-9112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Surenkumar Nihalani resolved HADOOP-9112. - Resolution: Fixed > test-patch should -1 for @Tests without a timeout >

[jira] [Commented] (HADOOP-9112) test-patch should -1 for @Tests without a timeout

[ https://issues.apache.org/jira/browse/HADOOP-9112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13583123#comment-13583123 ] Surenkumar Nihalani commented on HADOOP-9112: - [~ste...@apache.org], having a

[jira] [Reopened] (HADOOP-9112) test-patch should -1 for @Tests without a timeout

[ https://issues.apache.org/jira/browse/HADOOP-9112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Surenkumar Nihalani reopened HADOOP-9112: - minor bug - Wrong return codes. > test-patch should -1 for @Tests

[jira] [Updated] (HADOOP-9112) test-patch should -1 for @Tests without a timeout

[ https://issues.apache.org/jira/browse/HADOOP-9112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Surenkumar Nihalani updated HADOOP-9112: Attachment: HADOOP-9112-7.patch Hadoop QA seems to -1 w/o reason some places. Look

[jira] [Commented] (HADOOP-9285) findbugs 2 - bad practice warnings fix.

[ https://issues.apache.org/jira/browse/HADOOP-9285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13582591#comment-13582591 ] Surenkumar Nihalani commented on HADOOP-9285: - No feature changes. Hence, no

[jira] [Commented] (HADOOP-9314) Cover package org.apache.hadoop.hdfs.server.common with tests

[ https://issues.apache.org/jira/browse/HADOOP-9314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13582346#comment-13582346 ] Surenkumar Nihalani commented on HADOOP-9314: - [~vbondarev], We do we have bo

[jira] [Updated] (HADOOP-9112) test-patch should -1 for @Tests without a timeout

[ https://issues.apache.org/jira/browse/HADOOP-9112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Surenkumar Nihalani updated HADOOP-9112: Attachment: HADOOP-9112-6.patch Initially, awk was deleting newlines. Now it's sub

[jira] [Updated] (HADOOP-9112) test-patch should -1 for @Tests without a timeout

[ https://issues.apache.org/jira/browse/HADOOP-9112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Surenkumar Nihalani updated HADOOP-9112: Attachment: HADOOP-9112-5.patch Using awk instead of tr now. No need to add anothe

[jira] [Updated] (HADOOP-9112) test-patch should -1 for @Tests without a timeout

[ https://issues.apache.org/jira/browse/HADOOP-9112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Surenkumar Nihalani updated HADOOP-9112: Attachment: HADOOP-9112-4.patch The reason I didn't bother with other corner cases

[jira] [Commented] (HADOOP-8834) Hadoop examples when run without an argument, gives ERROR instead of just usage info

[ https://issues.apache.org/jira/browse/HADOOP-8834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13581224#comment-13581224 ] Surenkumar Nihalani commented on HADOOP-8834: - Hey [~abhishekkapoor], good st

[jira] [Commented] (HADOOP-9112) test-patch should -1 for @Tests without a timeout

[ https://issues.apache.org/jira/browse/HADOOP-9112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13581024#comment-13581024 ] Surenkumar Nihalani commented on HADOOP-9112: - Request for code review.

[jira] [Commented] (HADOOP-9112) test-patch should -1 for @Tests without a timeout

[ https://issues.apache.org/jira/browse/HADOOP-9112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13576410#comment-13576410 ] Surenkumar Nihalani commented on HADOOP-9112: - Request for code review.

[jira] [Updated] (HADOOP-9112) test-patch should -1 for @Tests without a timeout

[ https://issues.apache.org/jira/browse/HADOOP-9112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Surenkumar Nihalani updated HADOOP-9112: Attachment: HADOOP-9112-3.patch Corrected the newline problem. Patch is complete.

[jira] [Updated] (HADOOP-9112) test-patch should -1 for @Tests without a timeout

[ https://issues.apache.org/jira/browse/HADOOP-9112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Surenkumar Nihalani updated HADOOP-9112: Attachment: HADOOP-9112-2.patch There are five possibilities for JUnit's test anno

[jira] [Commented] (HADOOP-9112) test-patch should -1 for @Tests without a timeout

[ https://issues.apache.org/jira/browse/HADOOP-9112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13575624#comment-13575624 ] Surenkumar Nihalani commented on HADOOP-9112: - Turns out, negative look ahead

[jira] [Commented] (HADOOP-9112) test-patch should -1 for @Tests without a timeout

[ https://issues.apache.org/jira/browse/HADOOP-9112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13575345#comment-13575345 ] Surenkumar Nihalani commented on HADOOP-9112: - The patch isn't stable yet. Th

[jira] [Updated] (HADOOP-9112) test-patch should -1 for @Tests without a timeout

[ https://issues.apache.org/jira/browse/HADOOP-9112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Surenkumar Nihalani updated HADOOP-9112: Status: Patch Available (was: In Progress) > test-patch should -1 for @Tests

[jira] [Work started] (HADOOP-9112) test-patch should -1 for @Tests without a timeout

[ https://issues.apache.org/jira/browse/HADOOP-9112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HADOOP-9112 started by Surenkumar Nihalani. > test-patch should -1 for @Tests without a timeout > - > >

[jira] [Updated] (HADOOP-9112) test-patch should -1 for @Tests without a timeout

[ https://issues.apache.org/jira/browse/HADOOP-9112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Surenkumar Nihalani updated HADOOP-9112: Attachment: HADOOP-9112-1.patch > test-patch should -1 for @Tests without a ti

[jira] [Assigned] (HADOOP-9112) test-patch should -1 for @Tests without a timeout

[ https://issues.apache.org/jira/browse/HADOOP-9112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Surenkumar Nihalani reassigned HADOOP-9112: --- Assignee: Surenkumar Nihalani > test-patch should -1 for @Tests without

[jira] [Commented] (HADOOP-9112) test-patch should -1 for @Tests without a timeout

[ https://issues.apache.org/jira/browse/HADOOP-9112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13573725#comment-13573725 ] Surenkumar Nihalani commented on HADOOP-9112: - [~cnauroth], I see this approa

[jira] [Commented] (HADOOP-9112) test-patch should -1 for @Tests without a timeout

[ https://issues.apache.org/jira/browse/HADOOP-9112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13573639#comment-13573639 ] Surenkumar Nihalani commented on HADOOP-9112: - Any thoughts?

[jira] [Updated] (HADOOP-9285) findbugs 2 - bad practice warnings fix.

[ https://issues.apache.org/jira/browse/HADOOP-9285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Surenkumar Nihalani updated HADOOP-9285: Attachment: HADOOP-9285.patch > findbugs 2 - bad practice warnings fix. >

[jira] [Updated] (HADOOP-9285) findbugs 2 - bad practice warnings fix.

[ https://issues.apache.org/jira/browse/HADOOP-9285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Surenkumar Nihalani updated HADOOP-9285: Status: Patch Available (was: In Progress) Request for review. >

[jira] [Updated] (HADOOP-9285) findbugs 2 - bad practice warnings fix.

[ https://issues.apache.org/jira/browse/HADOOP-9285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Surenkumar Nihalani updated HADOOP-9285: Priority: Major (was: Minor) > findbugs 2 - bad practice warnings fix. >

[jira] [Work started] (HADOOP-9285) findbugs 2 - bad practice warnings fix.

[ https://issues.apache.org/jira/browse/HADOOP-9285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HADOOP-9285 started by Surenkumar Nihalani. > findbugs 2 - bad practice warnings fix. > --- > > Key: HADOOP-9

[jira] [Created] (HADOOP-9285) findbugs 2 - bad practice warnings fix.

Surenkumar Nihalani created HADOOP-9285: --- Summary: findbugs 2 - bad practice warnings fix. Key: HADOOP-9285 URL: https://issues.apache.org/jira/browse/HADOOP-9285 Project: Hadoop Common

[jira] [Commented] (HADOOP-9112) test-patch should -1 for @Tests without a timeout

[ https://issues.apache.org/jira/browse/HADOOP-9112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13569978#comment-13569978 ] Surenkumar Nihalani commented on HADOOP-9112: - apt tool has been deprecated s

[jira] [Commented] (HADOOP-9124) SortedMapWritable violates contract of Map interface for equals() and hashCode()

[ https://issues.apache.org/jira/browse/HADOOP-9124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13568916#comment-13568916 ] Surenkumar Nihalani commented on HADOOP-9124: - There is a very small issue:

[jira] [Commented] (HADOOP-9124) SortedMapWritable violates contract of Map interface for equals() and hashCode()

[ https://issues.apache.org/jira/browse/HADOOP-9124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13567803#comment-13567803 ] Surenkumar Nihalani commented on HADOOP-9124: - +1 > SortedMa

[jira] [Updated] (HADOOP-9124) SortedMapWritable violates contract of Map interface for equals() and hashCode()

[ https://issues.apache.org/jira/browse/HADOOP-9124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Surenkumar Nihalani updated HADOOP-9124: Attachment: HADOOP-9124.patch > SortedMapWritable violates contract of Map int

[jira] [Updated] (HADOOP-9124) SortedMapWritable violates contract of Map interface for equals() and hashCode()

[ https://issues.apache.org/jira/browse/HADOOP-9124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Surenkumar Nihalani updated HADOOP-9124: Attachment: HADOOP-9124.patch Sorry about that [~tomwhite]. Updated.

[jira] [Commented] (HADOOP-9124) SortedMapWritable violates contract of Map interface for equals() and hashCode()

[ https://issues.apache.org/jira/browse/HADOOP-9124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13564799#comment-13564799 ] Surenkumar Nihalani commented on HADOOP-9124: - I didn't know about branches i

[jira] [Updated] (HADOOP-9124) SortedMapWritable violates contract of Map interface for equals() and hashCode()

[ https://issues.apache.org/jira/browse/HADOOP-9124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Surenkumar Nihalani updated HADOOP-9124: Attachment: HADOOP-9124.patch Patch ready for review. > SortedMap

[jira] [Commented] (HADOOP-9124) SortedMapWritable violates contract of Map interface for equals() and hashCode()

[ https://issues.apache.org/jira/browse/HADOOP-9124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13563721#comment-13563721 ] Surenkumar Nihalani commented on HADOOP-9124: - [~kkambatl] & [~tomwhite], Wha

[jira] [Commented] (HADOOP-9124) SortedMapWritable violates contract of Map interface for equals() and hashCode()

[ https://issues.apache.org/jira/browse/HADOOP-9124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13562961#comment-13562961 ] Surenkumar Nihalani commented on HADOOP-9124: - I was looking at the {{equals(

[jira] [Commented] (HADOOP-9124) SortedMapWritable violates contract of Map interface for equals() and hashCode()

[ https://issues.apache.org/jira/browse/HADOOP-9124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13562652#comment-13562652 ] Surenkumar Nihalani commented on HADOOP-9124: - [~tomwhite], I agree about tha

[jira] [Commented] (HADOOP-9196) Modify BloomFilter read() and write() to address memory concerns

[ https://issues.apache.org/jira/browse/HADOOP-9196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13562161#comment-13562161 ] Surenkumar Nihalani commented on HADOOP-9196: - {{ ping }} >

[jira] [Commented] (HADOOP-9154) SortedMapWritable#putAll() doesn't add key/value classes to the map

[ https://issues.apache.org/jira/browse/HADOOP-9154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13560812#comment-13560812 ] Surenkumar Nihalani commented on HADOOP-9154: - I see better maintainability i

[jira] [Commented] (HADOOP-9112) test-patch should -1 for @Tests without a timeout

[ https://issues.apache.org/jira/browse/HADOOP-9112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13559303#comment-13559303 ] Surenkumar Nihalani commented on HADOOP-9112: - while adding default timeout s

[jira] [Commented] (HADOOP-9196) Modify BloomFilter read() and write() to address memory concerns

[ https://issues.apache.org/jira/browse/HADOOP-9196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13558170#comment-13558170 ] Surenkumar Nihalani commented on HADOOP-9196: - Clarification: internal variab

[jira] [Commented] (HADOOP-9196) Modify BloomFilter read() and write() to address memory concerns

[ https://issues.apache.org/jira/browse/HADOOP-9196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13558169#comment-13558169 ] Surenkumar Nihalani commented on HADOOP-9196: - James, Turns out the internal

[jira] [Commented] (HADOOP-9196) Modify BloomFilter read() and write() to address memory concerns

[ https://issues.apache.org/jira/browse/HADOOP-9196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13556857#comment-13556857 ] Surenkumar Nihalani commented on HADOOP-9196: - Should I go ahead with this an

[jira] [Commented] (HADOOP-9196) Modify BloomFilter read() and write() to address memory concerns

[ https://issues.apache.org/jira/browse/HADOOP-9196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13556737#comment-13556737 ] Surenkumar Nihalani commented on HADOOP-9196: - Correction: have a method take

[jira] [Commented] (HADOOP-9196) Modify BloomFilter read() and write() to address memory concerns

[ https://issues.apache.org/jira/browse/HADOOP-9196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13556703#comment-13556703 ] Surenkumar Nihalani commented on HADOOP-9196: - I have a more elegant solution

[jira] [Commented] (HADOOP-9196) Modify BloomFilter read() and write() to address memory concerns

[ https://issues.apache.org/jira/browse/HADOOP-9196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13556673#comment-13556673 ] Surenkumar Nihalani commented on HADOOP-9196: - How are you getting the byte?

[jira] [Commented] (HADOOP-9196) Modify BloomFilter read() and write() to address memory concerns

[ https://issues.apache.org/jira/browse/HADOOP-9196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13556674#comment-13556674 ] Surenkumar Nihalani commented on HADOOP-9196: - How about having a getter from

[jira] [Commented] (HADOOP-9196) Modify BloomFilter.write() to address memory concerns

[ https://issues.apache.org/jira/browse/HADOOP-9196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13555606#comment-13555606 ] Surenkumar Nihalani commented on HADOOP-9196: - It does allocate a full array.

[jira] [Commented] (HADOOP-9205) Java7: path to native libraries should be passed to tests via -Djava.library.path rather than env.LD_LIBRARY_PATH

[ https://issues.apache.org/jira/browse/HADOOP-9205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13553966#comment-13553966 ] Surenkumar Nihalani commented on HADOOP-9205: - I think we should share our ou

[jira] [Commented] (HADOOP-9154) SortedMapWritable#putAll() doesn't add key/value classes to the map

[ https://issues.apache.org/jira/browse/HADOOP-9154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13547019#comment-13547019 ] Surenkumar Nihalani commented on HADOOP-9154: - I agree with the refactoring.

[jira] [Commented] (HADOOP-9154) SortedMapWritable#putAll() doesn't add key/value classes to the map

[ https://issues.apache.org/jira/browse/HADOOP-9154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13545499#comment-13545499 ] Surenkumar Nihalani commented on HADOOP-9154: - I debated initializing {{failu

[jira] [Commented] (HADOOP-9154) SortedMapWritable#putAll() doesn't add key/value classes to the map

[ https://issues.apache.org/jira/browse/HADOOP-9154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13545459#comment-13545459 ] Surenkumar Nihalani commented on HADOOP-9154: - Karthik, I would highly apprec

[jira] [Commented] (HADOOP-9154) SortedMapWritable#putAll() doesn't add key/value classes to the map

[ https://issues.apache.org/jira/browse/HADOOP-9154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13545266#comment-13545266 ] Surenkumar Nihalani commented on HADOOP-9154: - Karthik, Had a chance to revie

[jira] [Commented] (HADOOP-9112) test-patch should -1 for @Tests without a timeout

[ https://issues.apache.org/jira/browse/HADOOP-9112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13539601#comment-13539601 ] Surenkumar Nihalani commented on HADOOP-9112: - I think I can write a java pro

[jira] [Commented] (HADOOP-9154) SortedMapWritable#putAll() doesn't add key/value classes to the map

[ https://issues.apache.org/jira/browse/HADOOP-9154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13539590#comment-13539590 ] Surenkumar Nihalani commented on HADOOP-9154: - No worries about the name. Ju

[jira] [Updated] (HADOOP-9154) SortedMapWritable#putAll() doesn't add key/value classes to the map

[ https://issues.apache.org/jira/browse/HADOOP-9154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Surenkumar Nihalani updated HADOOP-9154: Attachment: HADOOP-9124.patch Take a look at the merged tests. >

[jira] [Commented] (HADOOP-9154) SortedMapWritable#putAll() doesn't add key/value classes to the map

[ https://issues.apache.org/jira/browse/HADOOP-9154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13539490#comment-13539490 ] Surenkumar Nihalani commented on HADOOP-9154: - {Thanks for chipping in, Sures

[jira] [Commented] (HADOOP-9154) SortedMapWritable#putAll() doesn't add key/value classes to the map

[ https://issues.apache.org/jira/browse/HADOOP-9154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13539409#comment-13539409 ] Surenkumar Nihalani commented on HADOOP-9154: - It's my understanding that mer

[jira] [Commented] (HADOOP-9124) SortedMapWritable violates contract of Map interface for equals() and hashCode()

[ https://issues.apache.org/jira/browse/HADOOP-9124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13539389#comment-13539389 ] Surenkumar Nihalani commented on HADOOP-9124: - Hey Karthik, I would love to

[jira] [Commented] (HADOOP-9154) SortedMap#putAll() doesn't add key/value classes to the map

[ https://issues.apache.org/jira/browse/HADOOP-9154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13539267#comment-13539267 ] Surenkumar Nihalani commented on HADOOP-9154: - So, using SortedMapWritable's

[jira] [Updated] (HADOOP-9124) SortedMapWritable violates contract of Map interface for equals() and hashCode()

[ https://issues.apache.org/jira/browse/HADOOP-9124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Surenkumar Nihalani updated HADOOP-9124: Attachment: HADOOP-9124.patch > SortedMapWritable violates contract of Map int

[jira] [Commented] (HADOOP-9124) SortedMapWritable violates contract of Map interface for equals() and hashCode()

[ https://issues.apache.org/jira/browse/HADOOP-9124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13537578#comment-13537578 ] Surenkumar Nihalani commented on HADOOP-9124: - So, the sole purpose of timeou

[jira] [Updated] (HADOOP-9124) SortedMapWritable violates contract of Map interface for equals() and hashCode()

[ https://issues.apache.org/jira/browse/HADOOP-9124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Surenkumar Nihalani updated HADOOP-9124: Attachment: HADOOP-9124.patch > SortedMapWritable violates contract of Map int

[jira] [Updated] (HADOOP-9124) SortedMapWritable violates contract of Map interface for equals() and hashCode()

[ https://issues.apache.org/jira/browse/HADOOP-9124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Surenkumar Nihalani updated HADOOP-9124: Attachment: HADOOP-9124.patch Can you clarify on fifth point? I seem to have check

[jira] [Updated] (HADOOP-9124) SortedMapWritable violates contract of Map interface for equals() and hashCode()

[ https://issues.apache.org/jira/browse/HADOOP-9124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Surenkumar Nihalani updated HADOOP-9124: Attachment: HADOOP-9124.patch > SortedMapWritable violates contract of Map int

[jira] [Commented] (HADOOP-9124) SortedMapWritable violates contract of Map interface for equals() and hashCode()

[ https://issues.apache.org/jira/browse/HADOOP-9124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13534807#comment-13534807 ] Surenkumar Nihalani commented on HADOOP-9124: - Request for code review.

[jira] [Updated] (HADOOP-9124) SortedMapWritable violates contract of Map interface for equals() and hashCode()

[ https://issues.apache.org/jira/browse/HADOOP-9124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Surenkumar Nihalani updated HADOOP-9124: Attachment: HADOOP-9124.patch Added unit tests. > SortedMapWritab

[jira] [Updated] (HADOOP-9124) SortedMapWritable violates contract of Map interface for equals() and hashCode()

[ https://issues.apache.org/jira/browse/HADOOP-9124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Surenkumar Nihalani updated HADOOP-9124: Attachment: (was: HADOOP-9124.patch) > SortedMapWritable violates contract

[jira] [Updated] (HADOOP-9124) SortedMapWritable violates contract of Map interface for equals() and hashCode()

[ https://issues.apache.org/jira/browse/HADOOP-9124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Surenkumar Nihalani updated HADOOP-9124: Attachment: HADOOP-9124.patch > SortedMapWritable violates contract of Map int

[jira] [Commented] (HADOOP-9124) SortedMapWritable violates contract of Map interface for equals() and hashCode()

[ https://issues.apache.org/jira/browse/HADOOP-9124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13534669#comment-13534669 ] Surenkumar Nihalani commented on HADOOP-9124: - Hey Karthik, sure. I'll add c

[jira] [Updated] (HADOOP-9124) SortedMapWritable violates contract of Map interface for equals() and hashCode()

[ https://issues.apache.org/jira/browse/HADOOP-9124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Surenkumar Nihalani updated HADOOP-9124: Status: Patch Available (was: Open) > SortedMapWritable violates contract of

[jira] [Updated] (HADOOP-9124) SortedMapWritable violates contract of Map interface for equals() and hashCode()

[ https://issues.apache.org/jira/browse/HADOOP-9124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Surenkumar Nihalani updated HADOOP-9124: Attachment: HADOOP-9124.patch Request for code review. > SortedMa

[jira] [Commented] (HADOOP-9124) SortedMapWritable violates contract of Map interface for equals() and hashCode()

[ https://issues.apache.org/jira/browse/HADOOP-9124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13534503#comment-13534503 ] Surenkumar Nihalani commented on HADOOP-9124: - SortedMapWritable uses a TreeM