[
https://issues.apache.org/jira/browse/HADOOP-13061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15584723#comment-15584723
]
Hudson commented on HADOOP-13061:
-
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10629 (See
[
https://issues.apache.org/jira/browse/HADOOP-13061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15581414#comment-15581414
]
Kai Zheng commented on HADOOP-13061:
Thanks Andrew for the confirm. This refactors {{ErasureCoder}}
[
https://issues.apache.org/jira/browse/HADOOP-13061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15576501#comment-15576501
]
Andrew Wang commented on HADOOP-13061:
--
If it's fine with Kai, it's fine with me. One question
[
https://issues.apache.org/jira/browse/HADOOP-13061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15574121#comment-15574121
]
Hadoop QA commented on HADOOP-13061:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15573731#comment-15573731
]
Kai Zheng commented on HADOOP-13061:
+1 once above two are addressed. [~andrew.wang] might also give
[
https://issues.apache.org/jira/browse/HADOOP-13061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15573727#comment-15573727
]
Kai Zheng commented on HADOOP-13061:
Another one is, we don't need to have this configuration
[
https://issues.apache.org/jira/browse/HADOOP-13061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15573713#comment-15573713
]
Kai Zheng commented on HADOOP-13061:
Thanks [~lewuathe] for the update! Just find one issue, looks
[
https://issues.apache.org/jira/browse/HADOOP-13061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15572262#comment-15572262
]
Hadoop QA commented on HADOOP-13061:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15567337#comment-15567337
]
Kai Sasaki commented on HADOOP-13061:
-
[~drankye] Sure, I can. Thanks.
> Refactor erasure coders
>
[
https://issues.apache.org/jira/browse/HADOOP-13061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15567332#comment-15567332
]
Kai Zheng commented on HADOOP-13061:
Hi [~lewuathe] could you help proceed with the following
[
https://issues.apache.org/jira/browse/HADOOP-13061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15567292#comment-15567292
]
Hadoop QA commented on HADOOP-13061:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15567257#comment-15567257
]
Kai Zheng commented on HADOOP-13061:
Hi [~andrew.wang],
Thanks for your thoughts! Yes the legacy
[
https://issues.apache.org/jira/browse/HADOOP-13061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15567193#comment-15567193
]
Kai Sasaki commented on HADOOP-13061:
-
[~drankye]
Ah sorry I attached wrong JIRA ticket. I intended
[
https://issues.apache.org/jira/browse/HADOOP-13061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15567172#comment-15567172
]
Andrew Wang commented on HADOOP-13061:
--
Somewhat unrelated question related to rs-legacy: it's from
[
https://issues.apache.org/jira/browse/HADOOP-13061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15567152#comment-15567152
]
Kai Zheng commented on HADOOP-13061:
bq. Does it mean the issue which will be solved in
[
https://issues.apache.org/jira/browse/HADOOP-13061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15565350#comment-15565350
]
Kai Sasaki commented on HADOOP-13061:
-
[~drankye] Thank you so much for checking! Build seems to be
[
https://issues.apache.org/jira/browse/HADOOP-13061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15565076#comment-15565076
]
Hadoop QA commented on HADOOP-13061:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1374#comment-1374
]
Hadoop QA commented on HADOOP-13061:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15549155#comment-15549155
]
Hadoop QA commented on HADOOP-13061:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15503147#comment-15503147
]
Hadoop QA commented on HADOOP-13061:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15500383#comment-15500383
]
Kai Zheng commented on HADOOP-13061:
It looks much close now. Some minors:
* AbstractErasureCodec =>
[
https://issues.apache.org/jira/browse/HADOOP-13061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15480927#comment-15480927
]
Hadoop QA commented on HADOOP-13061:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15429236#comment-15429236
]
Hadoop QA commented on HADOOP-13061:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420788#comment-15420788
]
Kai Zheng commented on HADOOP-13061:
Thanks Kai for the update! Looks like more changes need to be
[
https://issues.apache.org/jira/browse/HADOOP-13061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420340#comment-15420340
]
Hadoop QA commented on HADOOP-13061:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420244#comment-15420244
]
Hadoop QA commented on HADOOP-13061:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15418177#comment-15418177
]
Kai Sasaki commented on HADOOP-13061:
-
[~drankye] Thanks for checking and sorry for misunderstood.
[
https://issues.apache.org/jira/browse/HADOOP-13061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15416578#comment-15416578
]
Kai Zheng commented on HADOOP-13061:
Hi Kai,
Looks like you misunderstood what I meant. I meant to
[
https://issues.apache.org/jira/browse/HADOOP-13061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411729#comment-15411729
]
Kai Sasaki commented on HADOOP-13061:
-
[~drankye] Could you review this? and what do you think about
[
https://issues.apache.org/jira/browse/HADOOP-13061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15410834#comment-15410834
]
Kai Sasaki commented on HADOOP-13061:
-
Though there is some checkstyle issues, some of the members
[
https://issues.apache.org/jira/browse/HADOOP-13061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15410826#comment-15410826
]
Hadoop QA commented on HADOOP-13061:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15410796#comment-15410796
]
Hadoop QA commented on HADOOP-13061:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15410658#comment-15410658
]
Hadoop QA commented on HADOOP-13061:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15407778#comment-15407778
]
Kai Zheng commented on HADOOP-13061:
bq. I think the latter is better because ECSchema is already
[
https://issues.apache.org/jira/browse/HADOOP-13061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15407703#comment-15407703
]
Kai Sasaki commented on HADOOP-13061:
-
[~drankye] Thanks for reviewing. I have one thing to confirm.
[
https://issues.apache.org/jira/browse/HADOOP-13061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15407110#comment-15407110
]
Kai Zheng commented on HADOOP-13061:
Thanks Kai for the patch. It looks great. Some comments:
1.
[
https://issues.apache.org/jira/browse/HADOOP-13061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15402109#comment-15402109
]
Kai Sasaki commented on HADOOP-13061:
-
[~drankye] Fixed check style. The test failure seems not
[
https://issues.apache.org/jira/browse/HADOOP-13061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15402092#comment-15402092
]
Hadoop QA commented on HADOOP-13061:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15401193#comment-15401193
]
Hadoop QA commented on HADOOP-13061:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15393827#comment-15393827
]
Kai Zheng commented on HADOOP-13061:
Thanks Kai for the notes. It looks great and I can't wait to
[
https://issues.apache.org/jira/browse/HADOOP-13061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15393735#comment-15393735
]
Kai Sasaki commented on HADOOP-13061:
-
As did in HADOOP-13010, I'll do refactoring basically
*
[
https://issues.apache.org/jira/browse/HADOOP-13061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15387701#comment-15387701
]
Kai Zheng commented on HADOOP-13061:
Re-assigned this to Kai per some discussion.
Hi [~lewuathe],
[
https://issues.apache.org/jira/browse/HADOOP-13061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15345843#comment-15345843
]
Kai Zheng commented on HADOOP-13061:
Thank you both, Rui and Zhe. I'm working on this, so will
[
https://issues.apache.org/jira/browse/HADOOP-13061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15345834#comment-15345834
]
Zhe Zhang commented on HADOOP-13061:
Thanks Rui. Could you ask Wei to create a JIRA account?
>
[
https://issues.apache.org/jira/browse/HADOOP-13061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15345827#comment-15345827
]
Rui Li commented on HADOOP-13061:
-
Hi [~drankye], per our discussion, Wei Zhou would help with this
45 matches
Mail list logo
