[
https://issues.apache.org/jira/browse/HADOOP-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16126207#comment-16126207
]
Aaron Fabbri commented on HADOOP-14749:
---
Awesome, thanks for doing this [~ste...@apache.org]
>
[
https://issues.apache.org/jira/browse/HADOOP-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124654#comment-16124654
]
Hadoop QA commented on HADOOP-14749:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124632#comment-16124632
]
Hadoop QA commented on HADOOP-14749:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124605#comment-16124605
]
Steve Loughran commented on HADOOP-14749:
-
Note: the throttle events are coming from the failing
[
https://issues.apache.org/jira/browse/HADOOP-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124573#comment-16124573
]
Steve Loughran commented on HADOOP-14749:
-
# We haven't any tests of IAM role with r/o bucket
[
https://issues.apache.org/jira/browse/HADOOP-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124000#comment-16124000
]
Aaron Fabbri commented on HADOOP-14749:
---
Quick review of the v5 patch:
{noformat}
+### Security
+
[
https://issues.apache.org/jira/browse/HADOOP-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123831#comment-16123831
]
Hadoop QA commented on HADOOP-14749:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123792#comment-16123792
]
Aaron Fabbri commented on HADOOP-14749:
---
{quote}
If we added a field for each entry as to when the
[
https://issues.apache.org/jira/browse/HADOOP-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123635#comment-16123635
]
Steve Loughran commented on HADOOP-14749:
-
I know the answer to that now. I also see that you
[
https://issues.apache.org/jira/browse/HADOOP-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123392#comment-16123392
]
Hadoop QA commented on HADOOP-14749:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16122901#comment-16122901
]
Mingliang Liu commented on HADOOP-14749:
{quote}
provision burden?
{quote}
I was thinking that,
[
https://issues.apache.org/jira/browse/HADOOP-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16122184#comment-16122184
]
Steve Loughran commented on HADOOP-14749:
-
thx, I'll go through Mingliang's comments and do a
[
https://issues.apache.org/jira/browse/HADOOP-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121069#comment-16121069
]
Mingliang Liu commented on HADOOP-14749:
+1. Nice work. Thanks [~ste...@apache.org].
Nits:
# I
[
https://issues.apache.org/jira/browse/HADOOP-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16120562#comment-16120562
]
Aaron Fabbri commented on HADOOP-14749:
---
+1 on v3 patch.
> review s3guard docs & code prior to
[
https://issues.apache.org/jira/browse/HADOOP-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16120298#comment-16120298
]
Hadoop QA commented on HADOOP-14749:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16120177#comment-16120177
]
Steve Loughran commented on HADOOP-14749:
-
+ feedback from [~ehiggs]
{code}
+ // with a
[
https://issues.apache.org/jira/browse/HADOOP-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16120172#comment-16120172
]
Steve Loughran commented on HADOOP-14749:
-
Aaron: just seen your comments. Yes, the patch was
[
https://issues.apache.org/jira/browse/HADOOP-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16119955#comment-16119955
]
Aaron Fabbri commented on HADOOP-14749:
---
Thanks for the patch [~ste...@apache.org]. This is good
[
https://issues.apache.org/jira/browse/HADOOP-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16119772#comment-16119772
]
Hadoop QA commented on HADOOP-14749:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16119127#comment-16119127
]
Steve Loughran commented on HADOOP-14749:
-
Testing
All well apart from existing failures
[
https://issues.apache.org/jira/browse/HADOOP-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16119123#comment-16119123
]
Steve Loughran commented on HADOOP-14749:
-
{{S3Guard.assertQualified}} added a vargs version to
[
https://issues.apache.org/jira/browse/HADOOP-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16118432#comment-16118432
]
Steve Loughran commented on HADOOP-14749:
-
+
* review javadocs
* arranging imports in roughly
22 matches
Mail list logo
