[GitHub] [hadoop] steveloughran commented on a change in pull request #1332: HADOOP-16445. Allow separate custom signing algorithms for S3 and DDB

2019-09-20 Thread GitBox
steveloughran commented on a change in pull request #1332: HADOOP-16445. Allow separate custom signing algorithms for S3 and DDB URL: https://github.com/apache/hadoop/pull/1332#discussion_r326730426 ## File path:

[GitHub] [hadoop] steveloughran commented on a change in pull request #1332: HADOOP-16445. Allow separate custom signing algorithms for S3 and DDB

2019-09-20 Thread GitBox
steveloughran commented on a change in pull request #1332: HADOOP-16445. Allow separate custom signing algorithms for S3 and DDB URL: https://github.com/apache/hadoop/pull/1332#discussion_r326730224 ## File path:

[GitHub] [hadoop] n-marion opened a new pull request #1484: [HADOOP-16590] - LoginModule Classes and Principal Classes deprecated in IBM Java.

2019-09-20 Thread GitBox
n-marion opened a new pull request #1484: [HADOOP-16590] - LoginModule Classes and Principal Classes deprecated in IBM Java. URL: https://github.com/apache/hadoop/pull/1484 Replace deprecated classes in IBM Java with their replacements.

[jira] [Updated] (HADOOP-16590) IBM Java has deprecated OS login module classes and OS principal classes.

2019-09-20 Thread Nicholas Marion (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicholas Marion updated HADOOP-16590: - Description: When building applications that rely on hadoop-commons and using IBM

[jira] [Updated] (HADOOP-16590) IBM Java has deprecated OS login module classes and OS principal classes.

2019-09-20 Thread Nicholas Marion (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicholas Marion updated HADOOP-16590: - Description: When building applications that rely on hadoop-commons and using IBM

[GitHub] [hadoop] steveloughran commented on issue #1467: HADOOP-16583. Minor fixes to S3 testing instructions

2019-09-20 Thread GitBox
steveloughran commented on issue #1467: HADOOP-16583. Minor fixes to S3 testing instructions URL: https://github.com/apache/hadoop/pull/1467#issuecomment-533659268 -1. this is what the profiles set This is an automated

[GitHub] [hadoop] hadoop-yetus removed a comment on issue #1302: HADOOP-16138. hadoop fs mkdir / of nonexistent abfs container raises NPE

2019-09-20 Thread GitBox
hadoop-yetus removed a comment on issue #1302: HADOOP-16138. hadoop fs mkdir / of nonexistent abfs container raises NPE URL: https://github.com/apache/hadoop/pull/1302#issuecomment-53325 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment |

[jira] [Updated] (HADOOP-16583) Minor fixes to S3 testing instructions

2019-09-20 Thread Siddharth Seth (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Siddharth Seth updated HADOOP-16583: Resolution: Invalid Status: Resolved (was: Patch Available) The specific

[GitHub] [hadoop] sidseth commented on issue #1487: HADOOP-16591 Fix S3A ITest*MRjob failures.

2019-09-20 Thread GitBox
sidseth commented on issue #1487: HADOOP-16591 Fix S3A ITest*MRjob failures. URL: https://github.com/apache/hadoop/pull/1487#issuecomment-533676732 Test command run: mvn -T 1C verify -Dparallel-tests -DtestsThreadCount=12 -Ds3guard -Dauth -Ddynamo Region: us-east-2 There's the usual

[GitHub] [hadoop] hadoop-yetus commented on issue #1484: [HADOOP-16590] - LoginModule Classes and Principal Classes deprecated in IBM Java.

2019-09-20 Thread GitBox
hadoop-yetus commented on issue #1484: [HADOOP-16590] - LoginModule Classes and Principal Classes deprecated in IBM Java. URL: https://github.com/apache/hadoop/pull/1484#issuecomment-533689091 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[jira] [Commented] (HADOOP-16590) IBM Java has deprecated OS login module classes and OS principal classes.

2019-09-20 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16934718#comment-16934718 ] Hadoop QA commented on HADOOP-16590: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[GitHub] [hadoop] vinayakumarb commented on issue #1482: HADOOP-16589. [pb-upgrade] Update docker image to make 3.7.1 protoc as default

2019-09-20 Thread GitBox
vinayakumarb commented on issue #1482: HADOOP-16589. [pb-upgrade] Update docker image to make 3.7.1 protoc as default URL: https://github.com/apache/hadoop/pull/1482#issuecomment-533689284 Since changes are detected to be in parent module, unit tests were triggered for all modules.

[GitHub] [hadoop] hadoop-yetus commented on issue #1442: HADOOP-16570. S3A committers leak threads on job/task commit.

2019-09-20 Thread GitBox
hadoop-yetus commented on issue #1442: HADOOP-16570. S3A committers leak threads on job/task commit. URL: https://github.com/apache/hadoop/pull/1442#issuecomment-533697723 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] anuengineer commented on issue #1491: HDDS-2161. Create RepeatedKeyInfo structure to be saved in deletedTable

2019-09-20 Thread GitBox
anuengineer commented on issue #1491: HDDS-2161. Create RepeatedKeyInfo structure to be saved in deletedTable URL: https://github.com/apache/hadoop/pull/1491#issuecomment-533732216 /label ozone This is an automated message

[GitHub] [hadoop] hadoop-yetus commented on issue #1491: HDDS-2161. Create RepeatedKeyInfo structure to be saved in deletedTable

2019-09-20 Thread GitBox
hadoop-yetus commented on issue #1491: HDDS-2161. Create RepeatedKeyInfo structure to be saved in deletedTable URL: https://github.com/apache/hadoop/pull/1491#issuecomment-533736737 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] steveloughran commented on issue #1332: HADOOP-16445. Allow separate custom signing algorithms for S3 and DDB

2019-09-20 Thread GitBox
steveloughran commented on issue #1332: HADOOP-16445. Allow separate custom signing algorithms for S3 and DDB URL: https://github.com/apache/hadoop/pull/1332#issuecomment-533645496 Patch LGTM, only thing needed is to get the imports consistent. I know its a PITA but its to keep merge hell

[jira] [Created] (HADOOP-16590) IBM Java has deprecated OS login module classes and OS principal classes.

2019-09-20 Thread Nicholas Marion (Jira)
Nicholas Marion created HADOOP-16590: Summary: IBM Java has deprecated OS login module classes and OS principal classes. Key: HADOOP-16590 URL: https://issues.apache.org/jira/browse/HADOOP-16590

[GitHub] [hadoop] ashvina commented on a change in pull request #1478: HDFS-14856 Fetch file ACLs while mounting external store

2019-09-20 Thread GitBox
ashvina commented on a change in pull request #1478: HDFS-14856 Fetch file ACLs while mounting external store URL: https://github.com/apache/hadoop/pull/1478#discussion_r326761028 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java

[GitHub] [hadoop] adoroszlai commented on issue #1485: HDDS-2157. checkstyle: print filenames relative to project root

2019-09-20 Thread GitBox
adoroszlai commented on issue #1485: HDDS-2157. checkstyle: print filenames relative to project root URL: https://github.com/apache/hadoop/pull/1485#issuecomment-533670938 /label ozone This is an automated message from the

[GitHub] [hadoop] hadoop-yetus commented on issue #1487: HADOOP-16591 Fix S3A ITest*MRjob failures.

2019-09-20 Thread GitBox
hadoop-yetus commented on issue #1487: HADOOP-16591 Fix S3A ITest*MRjob failures. URL: https://github.com/apache/hadoop/pull/1487#issuecomment-533696736 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[jira] [Updated] (HADOOP-16581) ValueQueue does not trigger an async refill when number of values falls below watermark

2019-09-20 Thread Erik Krogen (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erik Krogen updated HADOOP-16581: - Resolution: Fixed Status: Resolved (was: Patch Available) > ValueQueue does not

[GitHub] [hadoop] xiaoyuyao opened a new pull request #1490: HDDS-2160. Add acceptance test for ozonesecure-mr compose. Contribute…

2019-09-20 Thread GitBox
xiaoyuyao opened a new pull request #1490: HDDS-2160. Add acceptance test for ozonesecure-mr compose. Contribute… URL: https://github.com/apache/hadoop/pull/1490 This is an automated message from the Apache Git Service. To

[GitHub] [hadoop] hadoop-yetus commented on issue #1489: HDDS-2019. Handle Set DtService of token in S3Gateway for OM HA.

2019-09-20 Thread GitBox
hadoop-yetus commented on issue #1489: HDDS-2019. Handle Set DtService of token in S3Gateway for OM HA. URL: https://github.com/apache/hadoop/pull/1489#issuecomment-533725569 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] dineshchitlangia opened a new pull request #1491: HDDS-2161. Create RepeatedKeyInfo structure to be saved in deletedTable

2019-09-20 Thread GitBox
dineshchitlangia opened a new pull request #1491: HDDS-2161. Create RepeatedKeyInfo structure to be saved in deletedTable URL: https://github.com/apache/hadoop/pull/1491 /label ozone This is an automated message from the

[GitHub] [hadoop] anuengineer commented on issue #1491: HDDS-2161. Create RepeatedKeyInfo structure to be saved in deletedTable

2019-09-20 Thread GitBox
anuengineer commented on issue #1491: HDDS-2161. Create RepeatedKeyInfo structure to be saved in deletedTable URL: https://github.com/apache/hadoop/pull/1491#issuecomment-533732606 +1, pending Jenkins. I think you don't need the change in KeymanagerImpl. But no harm in doing that change.

[GitHub] [hadoop] hadoop-yetus removed a comment on issue #1332: HADOOP-16445. Allow separate custom signing algorithms for S3 and DDB

2019-09-20 Thread GitBox
hadoop-yetus removed a comment on issue #1332: HADOOP-16445. Allow separate custom signing algorithms for S3 and DDB URL: https://github.com/apache/hadoop/pull/1332#issuecomment-532628681 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] hadoop-yetus removed a comment on issue #1332: HADOOP-16445. Allow separate custom signing algorithms for S3 and DDB

2019-09-20 Thread GitBox
hadoop-yetus removed a comment on issue #1332: HADOOP-16445. Allow separate custom signing algorithms for S3 and DDB URL: https://github.com/apache/hadoop/pull/1332#issuecomment-532556334 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[jira] [Commented] (HADOOP-16581) ValueQueue does not trigger an async refill when number of values falls below watermark

2019-09-20 Thread Yuval Degani (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16934615#comment-16934615 ] Yuval Degani commented on HADOOP-16581: --- Thanks for reviewing and merging, folks! > ValueQueue

[GitHub] [hadoop] hadoop-yetus commented on issue #1483: HDDS-2001. Update Ratis version to 0.4.0.

2019-09-20 Thread GitBox
hadoop-yetus commented on issue #1483: HDDS-2001. Update Ratis version to 0.4.0. URL: https://github.com/apache/hadoop/pull/1483#issuecomment-533653067 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] sidseth opened a new pull request #1487: HADOOP-16591 Fix S3A ITest*MRjob failures.

2019-09-20 Thread GitBox
sidseth opened a new pull request #1487: HADOOP-16591 Fix S3A ITest*MRjob failures. URL: https://github.com/apache/hadoop/pull/1487 ## NOTICE Please create an issue in ASF JIRA before opening a pull request, and you need to set the title of the pull request which starts with

[jira] [Commented] (HADOOP-16579) Upgrade to Apache Curator 4.2.0 in Hadoop

2019-09-20 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16934708#comment-16934708 ] Steve Loughran commented on HADOOP-16579: - hadoop trunk is on guava 27; jackson 2.9.x and

[jira] [Commented] (HADOOP-13363) Upgrade protobuf from 2.5.0 to something newer

2019-09-20 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-13363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16934705#comment-16934705 ] Steve Loughran commented on HADOOP-13363: - > Since I'm the originator of this JIRA issue, I

[GitHub] [hadoop] jeffsaremi commented on a change in pull request #1480: HDFS-14857 FS operations fail in HA mode: DataNode fails to connect to NameNode

2019-09-20 Thread GitBox
jeffsaremi commented on a change in pull request #1480: HDFS-14857 FS operations fail in HA mode: DataNode fails to connect to NameNode URL: https://github.com/apache/hadoop/pull/1480#discussion_r326781148 ## File path:

[GitHub] [hadoop] steveloughran commented on a change in pull request #1332: HADOOP-16445. Allow separate custom signing algorithms for S3 and DDB

2019-09-20 Thread GitBox
steveloughran commented on a change in pull request #1332: HADOOP-16445. Allow separate custom signing algorithms for S3 and DDB URL: https://github.com/apache/hadoop/pull/1332#discussion_r326728095 ## File path:

[GitHub] [hadoop] steveloughran commented on a change in pull request #1332: HADOOP-16445. Allow separate custom signing algorithms for S3 and DDB

2019-09-20 Thread GitBox
steveloughran commented on a change in pull request #1332: HADOOP-16445. Allow separate custom signing algorithms for S3 and DDB URL: https://github.com/apache/hadoop/pull/1332#discussion_r326731189 ## File path:

[GitHub] [hadoop] steveloughran commented on a change in pull request #1332: HADOOP-16445. Allow separate custom signing algorithms for S3 and DDB

2019-09-20 Thread GitBox
steveloughran commented on a change in pull request #1332: HADOOP-16445. Allow separate custom signing algorithms for S3 and DDB URL: https://github.com/apache/hadoop/pull/1332#discussion_r326731189 ## File path:

[jira] [Commented] (HADOOP-16207) Fix ITestDirectoryCommitMRJob.testMRJob

2019-09-20 Thread Siddharth Seth (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16934667#comment-16934667 ] Siddharth Seth commented on HADOOP-16207: - Attached a simple patch which fixes just the test

[jira] [Updated] (HADOOP-16207) Fix ITestDirectoryCommitMRJob.testMRJob

2019-09-20 Thread Siddharth Seth (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Siddharth Seth updated HADOOP-16207: Attachment: HADOOP-16207.fixtestsonly.txt > Fix ITestDirectoryCommitMRJob.testMRJob >

[GitHub] [hadoop] anuengineer commented on issue #1344: HDDS-1982 Extend SCMNodeManager to support decommission and maintenance states

2019-09-20 Thread GitBox
anuengineer commented on issue #1344: HDDS-1982 Extend SCMNodeManager to support decommission and maintenance states URL: https://github.com/apache/hadoop/pull/1344#issuecomment-533670612 @nandakumar131 @elek @swagle Thank you for all the comments and discussion. @sodonnel Thank you for

[GitHub] [hadoop] adoroszlai opened a new pull request #1485: HDDS-2157. checkstyle: print filenames relative to project root

2019-09-20 Thread GitBox
adoroszlai opened a new pull request #1485: HDDS-2157. checkstyle: print filenames relative to project root URL: https://github.com/apache/hadoop/pull/1485 ## What changes were proposed in this pull request? Remove project root from filenames. Also, make script slightly more

[GitHub] [hadoop] anuengineer closed pull request #1344: HDDS-1982 Extend SCMNodeManager to support decommission and maintenance states

2019-09-20 Thread GitBox
anuengineer closed pull request #1344: HDDS-1982 Extend SCMNodeManager to support decommission and maintenance states URL: https://github.com/apache/hadoop/pull/1344 This is an automated message from the Apache Git Service.

[GitHub] [hadoop] jeffsaremi commented on a change in pull request #1480: HDFS-14857 FS operations fail in HA mode: DataNode fails to connect to NameNode

2019-09-20 Thread GitBox
jeffsaremi commented on a change in pull request #1480: HDFS-14857 FS operations fail in HA mode: DataNode fails to connect to NameNode URL: https://github.com/apache/hadoop/pull/1480#discussion_r326763136 ## File path:

[GitHub] [hadoop] shanyu commented on a change in pull request #1480: HDFS-14857 FS operations fail in HA mode: DataNode fails to connect to NameNode

2019-09-20 Thread GitBox
shanyu commented on a change in pull request #1480: HDFS-14857 FS operations fail in HA mode: DataNode fails to connect to NameNode URL: https://github.com/apache/hadoop/pull/1480#discussion_r326763525 ## File path:

[jira] [Created] (HADOOP-16591) S3A ITest*MRjob failures

2019-09-20 Thread Siddharth Seth (Jira)
Siddharth Seth created HADOOP-16591: --- Summary: S3A ITest*MRjob failures Key: HADOOP-16591 URL: https://issues.apache.org/jira/browse/HADOOP-16591 Project: Hadoop Common Issue Type: Test

[GitHub] [hadoop] ashvina commented on a change in pull request #1478: HDFS-14856 Fetch file ACLs while mounting external store

2019-09-20 Thread GitBox
ashvina commented on a change in pull request #1478: HDFS-14856 Fetch file ACLs while mounting external store URL: https://github.com/apache/hadoop/pull/1478#discussion_r326765094 ## File path:

[GitHub] [hadoop] hanishakoneru opened a new pull request #1486: HDDS-2158. Fixing Json Injection Issue in JsonUtils.

2019-09-20 Thread GitBox
hanishakoneru opened a new pull request #1486: HDDS-2158. Fixing Json Injection Issue in JsonUtils. URL: https://github.com/apache/hadoop/pull/1486 JsonUtils#toJsonStringWithDefaultPrettyPrinter() does not validate the Json String before serializing it which could result in Json

[GitHub] [hadoop] steveloughran commented on issue #1332: HADOOP-16445. Allow separate custom signing algorithms for S3 and DDB

2019-09-20 Thread GitBox
steveloughran commented on issue #1332: HADOOP-16445. Allow separate custom signing algorithms for S3 and DDB URL: https://github.com/apache/hadoop/pull/1332#issuecomment-533678354 +1 This is an automated message from the

[GitHub] [hadoop] hadoop-yetus commented on issue #1485: HDDS-2157. checkstyle: print filenames relative to project root

2019-09-20 Thread GitBox
hadoop-yetus commented on issue #1485: HDDS-2157. checkstyle: print filenames relative to project root URL: https://github.com/apache/hadoop/pull/1485#issuecomment-533681882 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] anuengineer merged pull request #1445: HDDS-2128. Make ozone sh command work with OM HA service ids

2019-09-20 Thread GitBox
anuengineer merged pull request #1445: HDDS-2128. Make ozone sh command work with OM HA service ids URL: https://github.com/apache/hadoop/pull/1445 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hadoop] steveloughran commented on a change in pull request #1332: HADOOP-16445. Allow separate custom signing algorithms for S3 and DDB

2019-09-20 Thread GitBox
steveloughran commented on a change in pull request #1332: HADOOP-16445. Allow separate custom signing algorithms for S3 and DDB URL: https://github.com/apache/hadoop/pull/1332#discussion_r326729184 ## File path:

[GitHub] [hadoop] steveloughran commented on a change in pull request #1332: HADOOP-16445. Allow separate custom signing algorithms for S3 and DDB

2019-09-20 Thread GitBox
steveloughran commented on a change in pull request #1332: HADOOP-16445. Allow separate custom signing algorithms for S3 and DDB URL: https://github.com/apache/hadoop/pull/1332#discussion_r326729375 ## File path:

[GitHub] [hadoop] sidseth commented on issue #1332: HADOOP-16445. Allow separate custom signing algorithms for S3 and DDB

2019-09-20 Thread GitBox
sidseth commented on issue #1332: HADOOP-16445. Allow separate custom signing algorithms for S3 and DDB URL: https://github.com/apache/hadoop/pull/1332#issuecomment-533659780 Updated the imports again. They should be consistent now. ``` java.* \n org.apache.* \n

[GitHub] [hadoop] goiri commented on a change in pull request #1480: HDFS-14857 FS operations fail in HA mode: DataNode fails to connect to NameNode

2019-09-20 Thread GitBox
goiri commented on a change in pull request #1480: HDFS-14857 FS operations fail in HA mode: DataNode fails to connect to NameNode URL: https://github.com/apache/hadoop/pull/1480#discussion_r326462143 ## File path:

[GitHub] [hadoop] goiri commented on a change in pull request #1480: HDFS-14857 FS operations fail in HA mode: DataNode fails to connect to NameNode

2019-09-20 Thread GitBox
goiri commented on a change in pull request #1480: HDFS-14857 FS operations fail in HA mode: DataNode fails to connect to NameNode URL: https://github.com/apache/hadoop/pull/1480#discussion_r326462034 ## File path:

[GitHub] [hadoop] steveloughran commented on issue #1442: HADOOP-16570. S3A committers leak threads on job/task commit.

2019-09-20 Thread GitBox
steveloughran commented on issue #1442: HADOOP-16570. S3A committers leak threads on job/task commit. URL: https://github.com/apache/hadoop/pull/1442#issuecomment-533671857 This patch is about to get bigger and more complicated, as when you get really big with the scale tests, you also

[GitHub] [hadoop] hadoop-yetus commented on issue #1332: HADOOP-16445. Allow separate custom signing algorithms for S3 and DDB

2019-09-20 Thread GitBox
hadoop-yetus commented on issue #1332: HADOOP-16445. Allow separate custom signing algorithms for S3 and DDB URL: https://github.com/apache/hadoop/pull/1332#issuecomment-533673862 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] sidseth commented on issue #1332: HADOOP-16445. Allow separate custom signing algorithms for S3 and DDB

2019-09-20 Thread GitBox
sidseth commented on issue #1332: HADOOP-16445. Allow separate custom signing algorithms for S3 and DDB URL: https://github.com/apache/hadoop/pull/1332#issuecomment-533677794 /retest This is an automated message from the

[GitHub] [hadoop] hanishakoneru opened a new pull request #1488: HDDS-2159. Fix Race condition in ProfileServlet#pid.

2019-09-20 Thread GitBox
hanishakoneru opened a new pull request #1488: HDDS-2159. Fix Race condition in ProfileServlet#pid. URL: https://github.com/apache/hadoop/pull/1488 There is a race condition in ProfileServlet. The Servlet member field pid should not be used for local assignment. It could lead to race

[GitHub] [hadoop] hadoop-yetus commented on issue #1486: HDDS-2158. Fixing Json Injection Issue in JsonUtils.

2019-09-20 Thread GitBox
hadoop-yetus commented on issue #1486: HDDS-2158. Fixing Json Injection Issue in JsonUtils. URL: https://github.com/apache/hadoop/pull/1486#issuecomment-533695825 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] hadoop-yetus commented on issue #1488: HDDS-2159. Fix Race condition in ProfileServlet#pid.

2019-09-20 Thread GitBox
hadoop-yetus commented on issue #1488: HDDS-2159. Fix Race condition in ProfileServlet#pid. URL: https://github.com/apache/hadoop/pull/1488#issuecomment-533705368 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] bharatviswa504 opened a new pull request #1489: HDDS-2019. Handle Set DtService of token in S3Gateway for OM HA.

2019-09-20 Thread GitBox
bharatviswa504 opened a new pull request #1489: HDDS-2019. Handle Set DtService of token in S3Gateway for OM HA. URL: https://github.com/apache/hadoop/pull/1489 Need some work on server-side for adding secure-om-s3-ha cluster, as some fields like keytab are still not supporting parameter

[jira] [Commented] (HADOOP-16581) ValueQueue does not trigger an async refill when number of values falls below watermark

2019-09-20 Thread Erik Krogen (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16934591#comment-16934591 ] Erik Krogen commented on HADOOP-16581: -- Also backported to branch-3.2, branch-3.1, and branch-2.

[GitHub] [hadoop] sidseth closed pull request #1467: HADOOP-16583. Minor fixes to S3 testing instructions

2019-09-20 Thread GitBox
sidseth closed pull request #1467: HADOOP-16583. Minor fixes to S3 testing instructions URL: https://github.com/apache/hadoop/pull/1467 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hadoop] sidseth commented on issue #1467: HADOOP-16583. Minor fixes to S3 testing instructions

2019-09-20 Thread GitBox
sidseth commented on issue #1467: HADOOP-16583. Minor fixes to S3 testing instructions URL: https://github.com/apache/hadoop/pull/1467#issuecomment-533667267 Yes. I already agreed this can be discarded. The only fix worth keeping is - fs.s3a.assumed.role.sts.endpoint +

[GitHub] [hadoop] steveloughran commented on a change in pull request #1442: HADOOP-16570. S3A committers leak threads on job/task commit.

2019-09-20 Thread GitBox
steveloughran commented on a change in pull request #1442: HADOOP-16570. S3A committers leak threads on job/task commit. URL: https://github.com/apache/hadoop/pull/1442#discussion_r326761254 ## File path:

[GitHub] [hadoop] goiri commented on a change in pull request #1478: HDFS-14856 Fetch file ACLs while mounting external store

2019-09-20 Thread GitBox
goiri commented on a change in pull request #1478: HDFS-14856 Fetch file ACLs while mounting external store URL: https://github.com/apache/hadoop/pull/1478#discussion_r326761613 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java

[GitHub] [hadoop] hadoop-yetus removed a comment on issue #1442: HADOOP-16570. S3A committers leak threads on job/task commit.

2019-09-20 Thread GitBox
hadoop-yetus removed a comment on issue #1442: HADOOP-16570. S3A committers leak threads on job/task commit. URL: https://github.com/apache/hadoop/pull/1442#issuecomment-533064098 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] hadoop-yetus removed a comment on issue #1442: HADOOP-16570. S3A committers leak threads on job/task commit.

2019-09-20 Thread GitBox
hadoop-yetus removed a comment on issue #1442: HADOOP-16570. S3A committers leak threads on job/task commit. URL: https://github.com/apache/hadoop/pull/1442#issuecomment-532857835 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] ayushtkn commented on issue #1482: HADOOP-16589. [pb-upgrade] Update docker image to make 3.7.1 protoc as default

2019-09-20 Thread GitBox
ayushtkn commented on issue #1482: HADOOP-16589. [pb-upgrade] Update docker image to make 3.7.1 protoc as default URL: https://github.com/apache/hadoop/pull/1482#issuecomment-533688181 /rebuild This is an automated message

[GitHub] [hadoop] ayushtkn commented on issue #1482: HADOOP-16589. [pb-upgrade] Update docker image to make 3.7.1 protoc as default

2019-09-20 Thread GitBox
ayushtkn commented on issue #1482: HADOOP-16589. [pb-upgrade] Update docker image to make 3.7.1 protoc as default URL: https://github.com/apache/hadoop/pull/1482#issuecomment-533688094 The build seems to have failed weirdly : > Error when executing cleanup post condition:

[GitHub] [hadoop] hadoop-yetus commented on issue #1489: HDDS-2019. Handle Set DtService of token in S3Gateway for OM HA.

2019-09-20 Thread GitBox
hadoop-yetus commented on issue #1489: HDDS-2019. Handle Set DtService of token in S3Gateway for OM HA. URL: https://github.com/apache/hadoop/pull/1489#issuecomment-533728099 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] goiri commented on a change in pull request #1399: HADOOP-16543: Cached DNS name resolution error

2019-09-20 Thread GitBox
goiri commented on a change in pull request #1399: HADOOP-16543: Cached DNS name resolution error URL: https://github.com/apache/hadoop/pull/1399#discussion_r326824345 ## File path:

[GitHub] [hadoop] hadoop-yetus removed a comment on issue #1332: HADOOP-16445. Allow separate custom signing algorithms for S3 and DDB

2019-09-20 Thread GitBox
hadoop-yetus removed a comment on issue #1332: HADOOP-16445. Allow separate custom signing algorithms for S3 and DDB URL: https://github.com/apache/hadoop/pull/1332#issuecomment-531538491 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] steveloughran commented on a change in pull request #1332: HADOOP-16445. Allow separate custom signing algorithms for S3 and DDB

2019-09-20 Thread GitBox
steveloughran commented on a change in pull request #1332: HADOOP-16445. Allow separate custom signing algorithms for S3 and DDB URL: https://github.com/apache/hadoop/pull/1332#discussion_r326728757 ## File path:

[GitHub] [hadoop] steveloughran commented on a change in pull request #1332: HADOOP-16445. Allow separate custom signing algorithms for S3 and DDB

2019-09-20 Thread GitBox
steveloughran commented on a change in pull request #1332: HADOOP-16445. Allow separate custom signing algorithms for S3 and DDB URL: https://github.com/apache/hadoop/pull/1332#discussion_r326728677 ## File path:

[GitHub] [hadoop] adoroszlai commented on issue #1365: HDDS-1949. Missing or error-prone test cleanup

2019-09-20 Thread GitBox
adoroszlai commented on issue #1365: HDDS-1949. Missing or error-prone test cleanup URL: https://github.com/apache/hadoop/pull/1365#issuecomment-533642087 Thanks @anuengineer for committing it. This is an automated message

[GitHub] [hadoop] ashvina commented on a change in pull request #1478: HDFS-14856 Fetch file ACLs while mounting external store

2019-09-20 Thread GitBox
ashvina commented on a change in pull request #1478: HDFS-14856 Fetch file ACLs while mounting external store URL: https://github.com/apache/hadoop/pull/1478#discussion_r326762306 ## File path:

[jira] [Updated] (HADOOP-16207) Fix ITestDirectoryCommitMRJob.testMRJob

2019-09-20 Thread Siddharth Seth (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Siddharth Seth updated HADOOP-16207: Attachment: (was: HADOOP-16207.fixtestsonly.txt) > Fix

[jira] [Comment Edited] (HADOOP-16207) Fix ITestDirectoryCommitMRJob.testMRJob

2019-09-20 Thread Siddharth Seth (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16934667#comment-16934667 ] Siddharth Seth edited comment on HADOOP-16207 at 9/20/19 7:13 PM: --

[GitHub] [hadoop] sidseth commented on issue #1332: HADOOP-16445. Allow separate custom signing algorithms for S3 and DDB

2019-09-20 Thread GitBox
sidseth commented on issue #1332: HADOOP-16445. Allow separate custom signing algorithms for S3 and DDB URL: https://github.com/apache/hadoop/pull/1332#issuecomment-533677639 Also, the *MRJob tests pass after applying HADOOP-16591 or setting configs in auth-keys.xml

[GitHub] [hadoop] anuengineer merged pull request #1485: HDDS-2157. checkstyle: print filenames relative to project root

2019-09-20 Thread GitBox
anuengineer merged pull request #1485: HDDS-2157. checkstyle: print filenames relative to project root URL: https://github.com/apache/hadoop/pull/1485 This is an automated message from the Apache Git Service. To respond to

[GitHub] [hadoop] hadoop-yetus commented on issue #1490: HDDS-2160. Add acceptance test for ozonesecure-mr compose. Contribute…

2019-09-20 Thread GitBox
hadoop-yetus commented on issue #1490: HDDS-2160. Add acceptance test for ozonesecure-mr compose. Contribute… URL: https://github.com/apache/hadoop/pull/1490#issuecomment-533724849 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] xiaoyuyao commented on a change in pull request #1431: HDDS-1569 Support creating multiple pipelines with same datanode

2019-09-20 Thread GitBox
xiaoyuyao commented on a change in pull request #1431: HDDS-1569 Support creating multiple pipelines with same datanode URL: https://github.com/apache/hadoop/pull/1431#discussion_r326837288 ## File path:

[GitHub] [hadoop] xiaoyuyao commented on a change in pull request #1469: HDDS-2034. Async RATIS pipeline creation and destroy through heartbea…

2019-09-20 Thread GitBox
xiaoyuyao commented on a change in pull request #1469: HDDS-2034. Async RATIS pipeline creation and destroy through heartbea… URL: https://github.com/apache/hadoop/pull/1469#discussion_r326840253 ## File path:

[GitHub] [hadoop] vivekratnavel opened a new pull request #1493: HDDS-2163. Add 'Replication factor' to the output of list keys

2019-09-20 Thread GitBox
vivekratnavel opened a new pull request #1493: HDDS-2163. Add 'Replication factor' to the output of list keys URL: https://github.com/apache/hadoop/pull/1493 This patch adds replication factor to the output of list keys. ``` bash-4.2$ ozone sh key list /vol1/bucket1 {

[GitHub] [hadoop] vivekratnavel commented on issue #1493: HDDS-2163. Add 'Replication factor' to the output of list keys

2019-09-20 Thread GitBox
vivekratnavel commented on issue #1493: HDDS-2163. Add 'Replication factor' to the output of list keys URL: https://github.com/apache/hadoop/pull/1493#issuecomment-533758842 /label ozone This is an automated message from the

[GitHub] [hadoop] hadoop-yetus commented on issue #1478: HDFS-14856 Fetch file ACLs while mounting external store

2019-09-20 Thread GitBox
hadoop-yetus commented on issue #1478: HDFS-14856 Fetch file ACLs while mounting external store URL: https://github.com/apache/hadoop/pull/1478#issuecomment-533760591 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] vinayakumarb opened a new pull request #1494: HADOOP-16558. [COMMON+HDFS] use protobuf-maven-plugin to generate protobuf classes

2019-09-20 Thread GitBox
vinayakumarb opened a new pull request #1494: HADOOP-16558. [COMMON+HDFS] use protobuf-maven-plugin to generate protobuf classes URL: https://github.com/apache/hadoop/pull/1494 Use "protoc-maven-plugin" to dynamically download protobuf executable to generate protobuf classes from proto

[GitHub] [hadoop] xiaoyuyao commented on a change in pull request #1431: HDDS-1569 Support creating multiple pipelines with same datanode

2019-09-20 Thread GitBox
xiaoyuyao commented on a change in pull request #1431: HDDS-1569 Support creating multiple pipelines with same datanode URL: https://github.com/apache/hadoop/pull/1431#discussion_r326836211 ## File path:

[GitHub] [hadoop] xiaoyuyao commented on a change in pull request #1431: HDDS-1569 Support creating multiple pipelines with same datanode

2019-09-20 Thread GitBox
xiaoyuyao commented on a change in pull request #1431: HDDS-1569 Support creating multiple pipelines with same datanode URL: https://github.com/apache/hadoop/pull/1431#discussion_r326837652 ## File path:

[GitHub] [hadoop] hadoop-yetus commented on issue #1491: HDDS-2161. Create RepeatedKeyInfo structure to be saved in deletedTable

2019-09-20 Thread GitBox
hadoop-yetus commented on issue #1491: HDDS-2161. Create RepeatedKeyInfo structure to be saved in deletedTable URL: https://github.com/apache/hadoop/pull/1491#issuecomment-533761420 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] hadoop-yetus commented on issue #1487: HADOOP-16591 Fix S3A ITest*MRjob failures.

2019-09-20 Thread GitBox
hadoop-yetus commented on issue #1487: HADOOP-16591 Fix S3A ITest*MRjob failures. URL: https://github.com/apache/hadoop/pull/1487#issuecomment-533767353 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] hadoop-yetus commented on issue #1480: HDFS-14857 FS operations fail in HA mode: DataNode fails to connect to NameNode

2019-09-20 Thread GitBox
hadoop-yetus commented on issue #1480: HDFS-14857 FS operations fail in HA mode: DataNode fails to connect to NameNode URL: https://github.com/apache/hadoop/pull/1480#issuecomment-533770419 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] ashvina commented on a change in pull request #1478: HDFS-14856 Fetch file ACLs while mounting external store

2019-09-20 Thread GitBox
ashvina commented on a change in pull request #1478: HDFS-14856 Fetch file ACLs while mounting external store URL: https://github.com/apache/hadoop/pull/1478#discussion_r326831610 ## File path:

[GitHub] [hadoop] hadoop-yetus commented on issue #1399: HADOOP-16543: Cached DNS name resolution error

2019-09-20 Thread GitBox
hadoop-yetus commented on issue #1399: HADOOP-16543: Cached DNS name resolution error URL: https://github.com/apache/hadoop/pull/1399#issuecomment-533745609 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[jira] [Commented] (HADOOP-16543) Cached DNS name resolution error

2019-09-20 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16934835#comment-16934835 ] Hadoop QA commented on HADOOP-16543: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[GitHub] [hadoop] xiaoyuyao commented on a change in pull request #1469: HDDS-2034. Async RATIS pipeline creation and destroy through heartbea…

2019-09-20 Thread GitBox
xiaoyuyao commented on a change in pull request #1469: HDDS-2034. Async RATIS pipeline creation and destroy through heartbea… URL: https://github.com/apache/hadoop/pull/1469#discussion_r326840829 ## File path:

[GitHub] [hadoop] vivekratnavel commented on issue #1493: HDDS-2163. Add 'Replication factor' to the output of list keys

2019-09-20 Thread GitBox
vivekratnavel commented on issue #1493: HDDS-2163. Add 'Replication factor' to the output of list keys URL: https://github.com/apache/hadoop/pull/1493#issuecomment-533758900 @bharatviswa504 @anuengineer @elek Please review

[GitHub] [hadoop] hadoop-yetus commented on issue #1493: HDDS-2163. Add 'Replication factor' to the output of list keys

2019-09-20 Thread GitBox
hadoop-yetus commented on issue #1493: HDDS-2163. Add 'Replication factor' to the output of list keys URL: https://github.com/apache/hadoop/pull/1493#issuecomment-533760793 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] dineshchitlangia commented on issue #1491: HDDS-2161. Create RepeatedKeyInfo structure to be saved in deletedTable

2019-09-20 Thread GitBox
dineshchitlangia commented on issue #1491: HDDS-2161. Create RepeatedKeyInfo structure to be saved in deletedTable URL: https://github.com/apache/hadoop/pull/1491#issuecomment-533761076 /restest This is an automated message

  1   2   >