[
https://issues.apache.org/jira/browse/HADOOP-18582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
1kang updated HADOOP-18582:
---
Description:
it not necessary to do `cleanupTempFiles` while ditcp commit job in direct
mode,
[
https://issues.apache.org/jira/browse/HADOOP-18582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
1kang updated HADOOP-18582:
---
Priority: Critical (was: Minor)
> No need to clean tmp files in ditcp direct mode
>
hadoop-yetus commented on PR #4744:
URL: https://github.com/apache/hadoop/pull/4744#issuecomment-1360928620
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
ChengbingLiu commented on code in PR #5246:
URL: https://github.com/apache/hadoop/pull/5246#discussion_r1054026139
##
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/log/LogThrottlingHelper.java:
##
@@ -259,6 +259,10 @@ public LogAction record(String
[
https://issues.apache.org/jira/browse/HADOOP-18582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
1kang updated HADOOP-18582:
---
Description:
it not necessary to do `cleanupTempFiles` while ditcp commit job in direct ,
hadoop-yetus commented on PR #5213:
URL: https://github.com/apache/hadoop/pull/5213#issuecomment-1360888678
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
1kang created HADOOP-18582:
--
Summary: No need to clean tmp files in ditcp direct mode
Key: HADOOP-18582
URL: https://issues.apache.org/jira/browse/HADOOP-18582
Project: Hadoop Common
Issue
slfan1989 commented on code in PR #5247:
URL: https://github.com/apache/hadoop/pull/5247#discussion_r1053929516
##
slfan1989 commented on code in PR #5247:
URL: https://github.com/apache/hadoop/pull/5247#discussion_r1053929516
##
Daniel-009497 commented on code in PR #5247:
URL: https://github.com/apache/hadoop/pull/5247#discussion_r1053913286
##
Daniel-009497 commented on code in PR #5247:
URL: https://github.com/apache/hadoop/pull/5247#discussion_r1053913286
##
jojochuang merged PR #5219:
URL: https://github.com/apache/hadoop/pull/5219
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
jojochuang commented on PR #5219:
URL: https://github.com/apache/hadoop/pull/5219#issuecomment-1360694288
Javadoc build error is unrelated. Merging it now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
xukaren opened a new pull request, #5249:
URL: https://github.com/apache/hadoop/pull/5249
### Description of PR
Removes a bottleneck on the YARN log aggregation service, where finished
applications cannot start aggregating logs to HDFS because all the log
aggregator threads
ZanderXu commented on PR #5098:
URL: https://github.com/apache/hadoop/pull/5098#issuecomment-1360641561
@simbadzina Master, can you help me review this PR when you are available?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
xkrogen commented on PR #4872:
URL: https://github.com/apache/hadoop/pull/4872#issuecomment-1360540535
Merged to trunk and backported to `branch-3.3` (some minor conflicts in the
imports). Thanks for the contribution @ZanderXu !
--
This is an automated message from the Apache Git
xkrogen merged PR #4872:
URL: https://github.com/apache/hadoop/pull/4872
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
xkrogen commented on code in PR #5246:
URL: https://github.com/apache/hadoop/pull/5246#discussion_r1053850133
##
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/log/LogThrottlingHelper.java:
##
@@ -259,6 +259,10 @@ public LogAction record(String
xkrogen commented on code in PR #5246:
URL: https://github.com/apache/hadoop/pull/5246#discussion_r1053850133
##
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/log/LogThrottlingHelper.java:
##
@@ -259,6 +259,10 @@ public LogAction record(String
jojochuang merged PR #5240:
URL: https://github.com/apache/hadoop/pull/5240
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
hadoop-yetus commented on PR #5244:
URL: https://github.com/apache/hadoop/pull/5244#issuecomment-1360300449
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-18146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17649986#comment-17649986
]
ASF GitHub Bot commented on HADOOP-18146:
-
hadoop-yetus commented on PR #4039:
URL:
hadoop-yetus commented on PR #4039:
URL: https://github.com/apache/hadoop/pull/4039#issuecomment-1360244486
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-18146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17649963#comment-17649963
]
ASF GitHub Bot commented on HADOOP-18146:
-
hadoop-yetus commented on PR #4039:
URL:
hadoop-yetus commented on PR #4039:
URL: https://github.com/apache/hadoop/pull/4039#issuecomment-1360103366
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #5246:
URL: https://github.com/apache/hadoop/pull/5246#issuecomment-1360046069
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-18581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17649929#comment-17649929
]
ASF GitHub Bot commented on HADOOP-18581:
-
cnauroth commented on code in PR #5248:
URL:
cnauroth commented on code in PR #5248:
URL: https://github.com/apache/hadoop/pull/5248#discussion_r1053628775
##
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java:
##
@@ -2206,7 +2206,25 @@ private void saslProcess(RpcSaslProto saslMessage)
goiri commented on code in PR #5236:
URL: https://github.com/apache/hadoop/pull/5236#discussion_r1053594237
##
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetUtils.java:
##
@@ -229,6 +230,23 @@ public static InetSocketAddress createSocketAddr(String
goiri commented on code in PR #5236:
URL: https://github.com/apache/hadoop/pull/5236#discussion_r1053591430
##
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestNetUtils.java:
##
@@ -39,6 +39,7 @@
import java.util.concurrent.TimeUnit;
import
cnauroth commented on PR #5187:
URL: https://github.com/apache/hadoop/pull/5187#issuecomment-1359884012
> > @szilard-nemeth and @slfan1989 , I noticed you have been pretty active
in the ResourceManager tests. Are you available to review this? Thank you.
>
> @cnauroth Thank you so
[
https://issues.apache.org/jira/browse/HADOOP-18581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17649876#comment-17649876
]
ASF GitHub Bot commented on HADOOP-18581:
-
hadoop-yetus commented on PR #5248:
URL:
hadoop-yetus commented on PR #5248:
URL: https://github.com/apache/hadoop/pull/5248#issuecomment-1359664117
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #5243:
URL: https://github.com/apache/hadoop/pull/5243#issuecomment-1359629493
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-18146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17649851#comment-17649851
]
ASF GitHub Bot commented on HADOOP-18146:
-
hadoop-yetus commented on PR #4039:
URL:
hadoop-yetus commented on PR #4039:
URL: https://github.com/apache/hadoop/pull/4039#issuecomment-1359589819
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-18146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17649827#comment-17649827
]
ASF GitHub Bot commented on HADOOP-18146:
-
hadoop-yetus commented on PR #4039:
URL:
hadoop-yetus commented on PR #4039:
URL: https://github.com/apache/hadoop/pull/4039#issuecomment-1359549140
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-18146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17649825#comment-17649825
]
ASF GitHub Bot commented on HADOOP-18146:
-
hadoop-yetus commented on PR #4039:
URL:
hadoop-yetus commented on PR #4039:
URL: https://github.com/apache/hadoop/pull/4039#issuecomment-1359544857
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #5236:
URL: https://github.com/apache/hadoop/pull/5236#issuecomment-1359402984
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #5236:
URL: https://github.com/apache/hadoop/pull/5236#issuecomment-1359390995
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #5247:
URL: https://github.com/apache/hadoop/pull/5247#issuecomment-1359348399
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-18526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17649744#comment-17649744
]
Maciej Smolenski commented on HADOOP-18526:
---
[~ste...@apache.org]
Thanks for the
ashutoshcipher commented on code in PR #5243:
URL: https://github.com/apache/hadoop/pull/5243#discussion_r1053287261
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/logaggregation/TestContainerLogsUtils.java:
##
@@ -75,13 +73,12 @@
[
https://issues.apache.org/jira/browse/HADOOP-18581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated HADOOP-18581:
Labels: pull-request-available (was: )
> Handle Server KDC re-login when Server and
[
https://issues.apache.org/jira/browse/HADOOP-18581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17649738#comment-17649738
]
ASF GitHub Bot commented on HADOOP-18581:
-
surendralilhore opened a new pull request, #5248:
surendralilhore opened a new pull request, #5248:
URL: https://github.com/apache/hadoop/pull/5248
…in same JVM.
### Description of PR
### How was this patch tested?
### For code changes:
- [ ] Does the title or this PR starts with the corresponding
ashutoshcipher commented on code in PR #5243:
URL: https://github.com/apache/hadoop/pull/5243#discussion_r1053272651
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/logaggregation/TestContainerLogsUtils.java:
##
@@ -75,13 +73,12 @@
slfan1989 commented on code in PR #5243:
URL: https://github.com/apache/hadoop/pull/5243#discussion_r1053258375
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/logaggregation/TestContainerLogsUtils.java:
##
@@ -75,13 +73,12 @@ public
slfan1989 closed pull request #5245: MAPREDUCE-7428. Fix Error Test.
URL: https://github.com/apache/hadoop/pull/5245
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
slfan1989 commented on code in PR #5243:
URL: https://github.com/apache/hadoop/pull/5243#discussion_r1053259880
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/logaggregation/TestContainerLogsUtils.java:
##
@@ -75,13 +73,12 @@ public
slfan1989 commented on code in PR #5243:
URL: https://github.com/apache/hadoop/pull/5243#discussion_r1053258375
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/logaggregation/TestContainerLogsUtils.java:
##
@@ -75,13 +73,12 @@ public
aajisaka commented on code in PR #5243:
URL: https://github.com/apache/hadoop/pull/5243#discussion_r1053257704
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/logaggregation/TestContainerLogsUtils.java:
##
@@ -75,13 +73,12 @@ public
hadoop-yetus commented on PR #5244:
URL: https://github.com/apache/hadoop/pull/5244#issuecomment-1359268260
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-18526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17649710#comment-17649710
]
Steve Loughran commented on HADOOP-18526:
-
Downgrade from fail to warn if trying to use dynamic
hadoop-yetus commented on PR #5236:
URL: https://github.com/apache/hadoop/pull/5236#issuecomment-1359263559
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
steveloughran closed pull request #5239: MAPREDUCE-7422/MAPREDUCE-7428
URL: https://github.com/apache/hadoop/pull/5239
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
steveloughran commented on PR #5239:
URL: https://github.com/apache/hadoop/pull/5239#issuecomment-1359247784
lets get #5243 in; if it is the fix there's no need to roll back
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
steveloughran commented on code in PR #5243:
URL: https://github.com/apache/hadoop/pull/5243#discussion_r1053230795
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/logaggregation/TestContainerLogsUtils.java:
##
@@ -75,13 +73,12 @@
slfan1989 commented on PR #5213:
URL: https://github.com/apache/hadoop/pull/5213#issuecomment-1359219618
@lnbest0707 Can we rebase again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
slfan1989 commented on PR #5236:
URL: https://github.com/apache/hadoop/pull/5236#issuecomment-1359217042
@Daniel-009497 Thank you very much for your contribution, but we need to
wait for `MAPREDUCE-7428`, `MAPREDUCE-7428` brought some junt test issues, it
is being processed. We need @goiri
slfan1989 commented on code in PR #5247:
URL: https://github.com/apache/hadoop/pull/5247#discussion_r1053205820
##
slfan1989 commented on code in PR #5247:
URL: https://github.com/apache/hadoop/pull/5247#discussion_r1053203404
##
Daniel-009497 opened a new pull request, #5247:
URL: https://github.com/apache/hadoop/pull/5247
Tens of thousands of meaningless logs are frequently printed during
ResourceManager startup and recover container.
As we know, ResourceManager will always keep 10k application information by
[
https://issues.apache.org/jira/browse/HADOOP-18581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Surendra Singh Lilhore updated HADOOP-18581:
Affects Version/s: 3.1.1
> Handle Server KDC re-login when Server and
[
https://issues.apache.org/jira/browse/HADOOP-18581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Surendra Singh Lilhore updated HADOOP-18581:
Description:
Handle re-login in Server when client, server running in
Daniel-009497 commented on code in PR #5236:
URL: https://github.com/apache/hadoop/pull/5236#discussion_r1053132520
##
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetUtils.java:
##
@@ -229,6 +230,23 @@ public static InetSocketAddress
Daniel-009497 commented on code in PR #5236:
URL: https://github.com/apache/hadoop/pull/5236#discussion_r1053132520
##
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetUtils.java:
##
@@ -229,6 +230,23 @@ public static InetSocketAddress
Surendra Singh Lilhore created HADOOP-18581:
---
Summary: Handle Server KDC re-login when Server and Client run in
same JVM.
Key: HADOOP-18581
URL: https://issues.apache.org/jira/browse/HADOOP-18581
ashutoshcipher commented on PR #5243:
URL: https://github.com/apache/hadoop/pull/5243#issuecomment-1359094932
Thanks @aajisaka for taking of this. Sorry I was not around for last few
days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
slfan1989 commented on PR #5243:
URL: https://github.com/apache/hadoop/pull/5243#issuecomment-1359091881
@aajisaka I tried modifying the code and I found yours to be the best, LGTM.
@steveloughran I think this part of the code can be merged to the trunk
branch, This can solve mr's junit
slfan1989 commented on code in PR #5236:
URL: https://github.com/apache/hadoop/pull/5236#discussion_r1053093731
##
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetUtils.java:
##
@@ -229,6 +230,23 @@ public static InetSocketAddress
hadoop-yetus commented on PR #5245:
URL: https://github.com/apache/hadoop/pull/5245#issuecomment-1359065374
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
slfan1989 commented on PR #5240:
URL: https://github.com/apache/hadoop/pull/5240#issuecomment-1359064531
> Could you pls help to review this PR?
LGTM +1.
We'd better trigger a compile again.
--
This is an automated message from the Apache Git Service.
To respond to the message,
Daniel-009497 commented on PR #5240:
URL: https://github.com/apache/hadoop/pull/5240#issuecomment-1358983399
@slfan1989 Could you pls help to review this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
76 matches
Mail list logo