[jira] [Commented] (HADOOP-14749) review s3guard docs & code prior to merge

[ https://issues.apache.org/jira/browse/HADOOP-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16126207#comment-16126207 ] Aaron Fabbri commented on HADOOP-14749: --- Awesome, thanks for doing this [~ste...@a

[jira] [Commented] (HADOOP-14749) review s3guard docs & code prior to merge

[ https://issues.apache.org/jira/browse/HADOOP-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124654#comment-16124654 ] Hadoop QA commented on HADOOP-14749: | (x) *{color:red}-1 overall{color}* | \\ \\ ||

[jira] [Commented] (HADOOP-14749) review s3guard docs & code prior to merge

[ https://issues.apache.org/jira/browse/HADOOP-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124632#comment-16124632 ] Hadoop QA commented on HADOOP-14749: | (x) *{color:red}-1 overall{color}* | \\ \\ ||

[jira] [Commented] (HADOOP-14749) review s3guard docs & code prior to merge

[ https://issues.apache.org/jira/browse/HADOOP-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124605#comment-16124605 ] Steve Loughran commented on HADOOP-14749: - Note: the throttle events are coming

[jira] [Commented] (HADOOP-14749) review s3guard docs & code prior to merge

[ https://issues.apache.org/jira/browse/HADOOP-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124573#comment-16124573 ] Steve Loughran commented on HADOOP-14749: - # We haven't any tests of IAM role wi

[jira] [Commented] (HADOOP-14749) review s3guard docs & code prior to merge

[ https://issues.apache.org/jira/browse/HADOOP-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124000#comment-16124000 ] Aaron Fabbri commented on HADOOP-14749: --- Quick review of the v5 patch: {noformat}

[jira] [Commented] (HADOOP-14749) review s3guard docs & code prior to merge

[ https://issues.apache.org/jira/browse/HADOOP-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16123831#comment-16123831 ] Hadoop QA commented on HADOOP-14749: | (x) *{color:red}-1 overall{color}* | \\ \\ ||

[jira] [Commented] (HADOOP-14749) review s3guard docs & code prior to merge

[ https://issues.apache.org/jira/browse/HADOOP-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16123792#comment-16123792 ] Aaron Fabbri commented on HADOOP-14749: --- {quote} If we added a field for each entr

[jira] [Commented] (HADOOP-14749) review s3guard docs & code prior to merge

[ https://issues.apache.org/jira/browse/HADOOP-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16123635#comment-16123635 ] Steve Loughran commented on HADOOP-14749: - I know the answer to that now. I also

[jira] [Commented] (HADOOP-14749) review s3guard docs & code prior to merge

[ https://issues.apache.org/jira/browse/HADOOP-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16123392#comment-16123392 ] Hadoop QA commented on HADOOP-14749: | (x) *{color:red}-1 overall{color}* | \\ \\ ||

[jira] [Commented] (HADOOP-14749) review s3guard docs & code prior to merge

[ https://issues.apache.org/jira/browse/HADOOP-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16122901#comment-16122901 ] Mingliang Liu commented on HADOOP-14749: {quote} provision burden? {quote} I was

[jira] [Commented] (HADOOP-14749) review s3guard docs & code prior to merge

[ https://issues.apache.org/jira/browse/HADOOP-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16122184#comment-16122184 ] Steve Loughran commented on HADOOP-14749: - thx, I'll go through Mingliang's comm

[jira] [Commented] (HADOOP-14749) review s3guard docs & code prior to merge

[ https://issues.apache.org/jira/browse/HADOOP-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16121069#comment-16121069 ] Mingliang Liu commented on HADOOP-14749: +1. Nice work. Thanks [~ste...@apache.o

[jira] [Commented] (HADOOP-14749) review s3guard docs & code prior to merge

[ https://issues.apache.org/jira/browse/HADOOP-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120562#comment-16120562 ] Aaron Fabbri commented on HADOOP-14749: --- +1 on v3 patch. > review s3guard docs &

[jira] [Commented] (HADOOP-14749) review s3guard docs & code prior to merge

[ https://issues.apache.org/jira/browse/HADOOP-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120298#comment-16120298 ] Hadoop QA commented on HADOOP-14749: | (x) *{color:red}-1 overall{color}* | \\ \\ ||

[jira] [Commented] (HADOOP-14749) review s3guard docs & code prior to merge

[ https://issues.apache.org/jira/browse/HADOOP-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120177#comment-16120177 ] Steve Loughran commented on HADOOP-14749: - + feedback from [~ehiggs] {code} +

[jira] [Commented] (HADOOP-14749) review s3guard docs & code prior to merge

[ https://issues.apache.org/jira/browse/HADOOP-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120172#comment-16120172 ] Steve Loughran commented on HADOOP-14749: - Aaron: just seen your comments. Yes,

[jira] [Commented] (HADOOP-14749) review s3guard docs & code prior to merge

[ https://issues.apache.org/jira/browse/HADOOP-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16119955#comment-16119955 ] Aaron Fabbri commented on HADOOP-14749: --- Thanks for the patch [~ste...@apache.org]

[jira] [Commented] (HADOOP-14749) review s3guard docs & code prior to merge

[ https://issues.apache.org/jira/browse/HADOOP-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16119772#comment-16119772 ] Hadoop QA commented on HADOOP-14749: | (x) *{color:red}-1 overall{color}* | \\ \\ ||

[jira] [Commented] (HADOOP-14749) review s3guard docs & code prior to merge

[ https://issues.apache.org/jira/browse/HADOOP-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16119127#comment-16119127 ] Steve Loughran commented on HADOOP-14749: - Testing All well apart from existing

[jira] [Commented] (HADOOP-14749) review s3guard docs & code prior to merge

[ https://issues.apache.org/jira/browse/HADOOP-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16119123#comment-16119123 ] Steve Loughran commented on HADOOP-14749: - {{S3Guard.assertQualified}} added a v

[jira] [Commented] (HADOOP-14749) review s3guard docs & code prior to merge

[ https://issues.apache.org/jira/browse/HADOOP-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16118432#comment-16118432 ] Steve Loughran commented on HADOOP-14749: - + * review javadocs * arranging impor