[
https://issues.apache.org/jira/browse/HADOOP-12101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15271955#comment-15271955
]
Ray Chiang commented on HADOOP-12101:
-
Thanks for the review and the commit [~iwasakims]!
> Add
[
https://issues.apache.org/jira/browse/HADOOP-12101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15270200#comment-15270200
]
Hudson commented on HADOOP-12101:
-
FAILURE: Integrated in Hadoop-trunk-Commit #9711 (See
[
https://issues.apache.org/jira/browse/HADOOP-12101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15270173#comment-15270173
]
Masatake Iwasaki commented on HADOOP-12101:
---
+1, committing this.
> Add automatic search of
[
https://issues.apache.org/jira/browse/HADOOP-12101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15269081#comment-15269081
]
Hadoop QA commented on HADOOP-12101:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-12101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15267949#comment-15267949
]
Hadoop QA commented on HADOOP-12101:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-12101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15267791#comment-15267791
]
Hadoop QA commented on HADOOP-12101:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-12101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15267602#comment-15267602
]
Masatake Iwasaki commented on HADOOP-12101:
---
Thanks for the update.
{noformat}
108 export
[
https://issues.apache.org/jira/browse/HADOOP-12101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15267191#comment-15267191
]
Hadoop QA commented on HADOOP-12101:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-12101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15262542#comment-15262542
]
Ray Chiang commented on HADOOP-12101:
-
Thanks Masatake! I will update the script with your
[
https://issues.apache.org/jira/browse/HADOOP-12101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15262497#comment-15262497
]
Masatake Iwasaki commented on HADOOP-12101:
---
The patch affects TestHdfsConfigFields,
[
https://issues.apache.org/jira/browse/HADOOP-12101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15261570#comment-15261570
]
Masatake Iwasaki commented on HADOOP-12101:
---
verify-xml.sh is intended to be run on top
[
https://issues.apache.org/jira/browse/HADOOP-12101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15256865#comment-15256865
]
Hadoop QA commented on HADOOP-12101:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-12101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15256796#comment-15256796
]
Hadoop QA commented on HADOOP-12101:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-12101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15180108#comment-15180108
]
Ray Chiang commented on HADOOP-12101:
-
RE: Failed unit test
Test passes in my tree.
> Add
[
https://issues.apache.org/jira/browse/HADOOP-12101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15179597#comment-15179597
]
Hadoop QA commented on HADOOP-12101:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-12101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15179110#comment-15179110
]
Robert Kanter commented on HADOOP-12101:
A few more minor things:
# Use curly braces on this if
[
https://issues.apache.org/jira/browse/HADOOP-12101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15172597#comment-15172597
]
Ray Chiang commented on HADOOP-12101:
-
RE: Failing unit tests
All tests pass in my tree and are
[
https://issues.apache.org/jira/browse/HADOOP-12101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15089699#comment-15089699
]
Ray Chiang commented on HADOOP-12101:
-
RE: Failing unit tests with JDK8
Both tests pass in my tree
[
https://issues.apache.org/jira/browse/HADOOP-12101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15088564#comment-15088564
]
Hadoop QA commented on HADOOP-12101:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-12101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14974610#comment-14974610
]
Ray Chiang commented on HADOOP-12101:
-
RE: failing unit tests
Unrelated unit tests. All tests pass
[
https://issues.apache.org/jira/browse/HADOOP-12101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14972194#comment-14972194
]
Hadoop QA commented on HADOOP-12101:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-12101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14970202#comment-14970202
]
Hadoop QA commented on HADOOP-12101:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-12101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14970061#comment-14970061
]
Ray Chiang commented on HADOOP-12101:
-
For the last item, it looks like YARN-3958 moved the test
[
https://issues.apache.org/jira/browse/HADOOP-12101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14959656#comment-14959656
]
Robert Kanter commented on HADOOP-12101:
Overall looks good. A few minor comments:
- In the
[
https://issues.apache.org/jira/browse/HADOOP-12101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14959578#comment-14959578
]
Hadoop QA commented on HADOOP-12101:
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-12101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14951248#comment-14951248
]
Ray Chiang commented on HADOOP-12101:
-
[~ajisakaa] [~ozawa], any other comments?
> Add automatic
[
https://issues.apache.org/jira/browse/HADOOP-12101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14935646#comment-14935646
]
Ray Chiang commented on HADOOP-12101:
-
RE: Pre-patch findbugs
Not in related code
RE: Failed unit
[
https://issues.apache.org/jira/browse/HADOOP-12101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14934211#comment-14934211
]
Hadoop QA commented on HADOOP-12101:
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-12101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14908911#comment-14908911
]
Ray Chiang commented on HADOOP-12101:
-
Any comments? I'd love to get this in instead of patching
[
https://issues.apache.org/jira/browse/HADOOP-12101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14909007#comment-14909007
]
Hadoop QA commented on HADOOP-12101:
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-12101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14596529#comment-14596529
]
Hadoop QA commented on HADOOP-12101:
\\
\\
| (/) *{color:green}+1 overall{color}* |
[
https://issues.apache.org/jira/browse/HADOOP-12101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14591314#comment-14591314
]
Ray Chiang commented on HADOOP-12101:
-
Thanks!
I did talk to [~aw] about running it
[
https://issues.apache.org/jira/browse/HADOOP-12101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14591634#comment-14591634
]
Hadoop QA commented on HADOOP-12101:
\\
\\
| (/) *{color:green}+1 overall{color}* |
[
https://issues.apache.org/jira/browse/HADOOP-12101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14591299#comment-14591299
]
Tsuyoshi Ozawa commented on HADOOP-12101:
-
[~rchiang] Thank you for taking this
34 matches
Mail list logo
