[jira] [Commented] (HADOOP-14397) Pull up the builder pattern to FileSystem and add AbstractContractCreateTest for it

2017-07-31 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-14397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16108343#comment-16108343 ] Hudson commented on HADOOP-14397: - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12087 (See

[jira] [Commented] (HADOOP-14397) Pull up the builder pattern to FileSystem and add AbstractContractCreateTest for it

2017-07-31 Thread Manoj Govindassamy (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-14397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16108235#comment-16108235 ] Manoj Govindassamy commented on HADOOP-14397: - Looks good to me, [~eddyxu]. +1. > Pull up

[jira] [Commented] (HADOOP-14397) Pull up the builder pattern to FileSystem and add AbstractContractCreateTest for it

2017-07-31 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-14397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16108066#comment-16108066 ] Hadoop QA commented on HADOOP-14397: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-14397) Pull up the builder pattern to FileSystem and add AbstractContractCreateTest for it

2017-07-31 Thread Lei (Eddy) Xu (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-14397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16107665#comment-16107665 ] Lei (Eddy) Xu commented on HADOOP-14397: {{TestLocalFileSystem}} is related. Working on it. >

[jira] [Commented] (HADOOP-14397) Pull up the builder pattern to FileSystem and add AbstractContractCreateTest for it

2017-07-28 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-14397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16105574#comment-16105574 ] Hadoop QA commented on HADOOP-14397: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-14397) Pull up the builder pattern to FileSystem and add AbstractContractCreateTest for it

2017-07-28 Thread Manoj Govindassamy (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-14397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16105395#comment-16105395 ] Manoj Govindassamy commented on HADOOP-14397: - Thanks for working on this [~eddyxu]. v02

[jira] [Commented] (HADOOP-14397) Pull up the builder pattern to FileSystem and add AbstractContractCreateTest for it

2017-07-27 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-14397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104282#comment-16104282 ] Hadoop QA commented on HADOOP-14397: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-14397) Pull up the builder pattern to FileSystem and add AbstractContractCreateTest for it

2017-07-25 Thread Manoj Govindassamy (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-14397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16099625#comment-16099625 ] Manoj Govindassamy commented on HADOOP-14397: - Looks good overall [~eddyxu]. +1, with one

[jira] [Commented] (HADOOP-14397) Pull up the builder pattern to FileSystem and add AbstractContractCreateTest for it

2017-07-25 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-14397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16099576#comment-16099576 ] Hadoop QA commented on HADOOP-14397: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-14397) Pull up the builder pattern to FileSystem and add AbstractContractCreateTest for it

2017-07-12 Thread Aaron Fabbri (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-14397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16084953#comment-16084953 ] Aaron Fabbri commented on HADOOP-14397: --- Code looks good to me. Nice test factorization. I can't

[jira] [Commented] (HADOOP-14397) Pull up the builder pattern to FileSystem and add AbstractContractCreateTest for it

2017-06-22 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-14397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16058908#comment-16058908 ] Hadoop QA commented on HADOOP-14397: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-14397) Pull up the builder pattern to FileSystem and add AbstractContractCreateTest for it

2017-05-11 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-14397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16006439#comment-16006439 ] Steve Loughran commented on HADOOP-14397: - yes, this is the place. Once you've done the spec

[jira] [Commented] (HADOOP-14397) Pull up the builder pattern to FileSystem and add AbstractContractCreateTest for it

2017-05-09 Thread Kai Zheng (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-14397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16002442#comment-16002442 ] Kai Zheng commented on HADOOP-14397: [~ste...@apache.org], Should the following from your comments