[GitHub] [hadoop] adoroszlai commented on issue #1568: HDDS-2225. SCM fails to start in most unsecure environments due to leftover secure config

2019-10-02 Thread GitBox
adoroszlai commented on issue #1568: HDDS-2225. SCM fails to start in most unsecure environments due to leftover secure config URL: https://github.com/apache/hadoop/pull/1568#issuecomment-537351894 Thanks @arp7 for the review. `ozones3` test was run [after

[GitHub] [hadoop] adoroszlai commented on issue #1537: HDDS-2187. ozone-mr test fails with No FileSystem for scheme o3fs

2019-10-02 Thread GitBox
adoroszlai commented on issue #1537: HDDS-2187. ozone-mr test fails with No FileSystem for scheme o3fs URL: https://github.com/apache/hadoop/pull/1537#issuecomment-537444362 Thanks @elek for reviewing and committing it. This

[GitHub] [hadoop] sodonnel commented on a change in pull request #1551: HDDS-2199 In SCMNodeManager dnsToUuidMap cannot track multiple DNs on the same host

2019-10-02 Thread GitBox
sodonnel commented on a change in pull request #1551: HDDS-2199 In SCMNodeManager dnsToUuidMap cannot track multiple DNs on the same host URL: https://github.com/apache/hadoop/pull/1551#discussion_r330481300 ## File path:

[GitHub] [hadoop] hadoop-yetus commented on issue #1551: HDDS-2199 In SCMNodeManager dnsToUuidMap cannot track multiple DNs on the same host

2019-10-02 Thread GitBox
hadoop-yetus commented on issue #1551: HDDS-2199 In SCMNodeManager dnsToUuidMap cannot track multiple DNs on the same host URL: https://github.com/apache/hadoop/pull/1551#issuecomment-537449104 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment

[GitHub] [hadoop] steveloughran commented on a change in pull request #1115: HADOOP-16207 testMR failures

2019-10-02 Thread GitBox
steveloughran commented on a change in pull request #1115: HADOOP-16207 testMR failures URL: https://github.com/apache/hadoop/pull/1115#discussion_r330506694 ## File path: hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/commit/integration/ITestS3ACommitterMRJob.java

[GitHub] [hadoop] elek commented on issue #1544: HDDS-2203 Race condition in ByteStringHelper.init()

2019-10-02 Thread GitBox
elek commented on issue #1544: HDDS-2203 Race condition in ByteStringHelper.init() URL: https://github.com/apache/hadoop/pull/1544#issuecomment-537463935 @fapifta You create the PR from your `fapifta:trunk`, but you pushed a merged trunk. Now 88 files are changed by this PR. Can you

[GitHub] [hadoop] adoroszlai commented on issue #1575: HDDS-2231. test-single.sh cannot copy results

2019-10-02 Thread GitBox
adoroszlai commented on issue #1575: HDDS-2231. test-single.sh cannot copy results URL: https://github.com/apache/hadoop/pull/1575#issuecomment-537436637 /label ozone This is an automated message from the Apache Git Service.

[GitHub] [hadoop] adoroszlai opened a new pull request #1575: HDDS-2231. test-single.sh cannot copy results

2019-10-02 Thread GitBox
adoroszlai opened a new pull request #1575: HDDS-2231. test-single.sh cannot copy results URL: https://github.com/apache/hadoop/pull/1575 ## What changes were proposed in this pull request? Restore pre-[HDDS-2185](https://issues.apache.org/jira/browse/HDDS-2185) behavior of

[GitHub] [hadoop] steveloughran commented on a change in pull request #1115: HADOOP-16207 testMR failures

2019-10-02 Thread GitBox
steveloughran commented on a change in pull request #1115: HADOOP-16207 testMR failures URL: https://github.com/apache/hadoop/pull/1115#discussion_r33048 ## File path: hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/commit/AbstractYarnClusterITest.java

[GitHub] [hadoop] elek commented on issue #1537: HDDS-2187. ozone-mr test fails with No FileSystem for scheme o3fs

2019-10-02 Thread GitBox
elek commented on issue #1537: HDDS-2187. ozone-mr test fails with No FileSystem for scheme o3fs URL: https://github.com/apache/hadoop/pull/1537#issuecomment-537439962 > See HDDS-2225 for the root cause. Ok. As we understand what is this intermittent problem (and it's unrelated),

[GitHub] [hadoop] hadoop-yetus commented on issue #1575: HDDS-2231. test-single.sh cannot copy results

2019-10-02 Thread GitBox
hadoop-yetus commented on issue #1575: HDDS-2231. test-single.sh cannot copy results URL: https://github.com/apache/hadoop/pull/1575#issuecomment-537449639 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] hadoop-yetus commented on issue #1544: HDDS-2203 Race condition in ByteStringHelper.init()

2019-10-02 Thread GitBox
hadoop-yetus commented on issue #1544: HDDS-2203 Race condition in ByteStringHelper.init() URL: https://github.com/apache/hadoop/pull/1544#issuecomment-537443736 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] elek commented on issue #1568: HDDS-2225. SCM fails to start in most unsecure environments due to leftover secure config

2019-10-02 Thread GitBox
elek commented on issue #1568: HDDS-2225. SCM fails to start in most unsecure environments due to leftover secure config URL: https://github.com/apache/hadoop/pull/1568#issuecomment-537440726 Somewhat drastic but effective solution ;-) I am fine with removing it for now, but we need to

[GitHub] [hadoop] hadoop-yetus commented on issue #1568: HDDS-2225. SCM fails to start in most unsecure environments due to leftover secure config

2019-10-02 Thread GitBox
hadoop-yetus commented on issue #1568: HDDS-2225. SCM fails to start in most unsecure environments due to leftover secure config URL: https://github.com/apache/hadoop/pull/1568#issuecomment-537465722 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime |

[GitHub] [hadoop] sodonnel commented on a change in pull request #1551: HDDS-2199 In SCMNodeManager dnsToUuidMap cannot track multiple DNs on the same host

2019-10-02 Thread GitBox
sodonnel commented on a change in pull request #1551: HDDS-2199 In SCMNodeManager dnsToUuidMap cannot track multiple DNs on the same host URL: https://github.com/apache/hadoop/pull/1551#discussion_r330481300 ## File path:

[GitHub] [hadoop] steveloughran commented on a change in pull request #1115: HADOOP-16207 testMR failures

2019-10-02 Thread GitBox
steveloughran commented on a change in pull request #1115: HADOOP-16207 testMR failures URL: https://github.com/apache/hadoop/pull/1115#discussion_r330485301 ## File path: hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/commit/AbstractYarnClusterITest.java

[GitHub] [hadoop] steveloughran commented on a change in pull request #1115: HADOOP-16207 testMR failures

2019-10-02 Thread GitBox
steveloughran commented on a change in pull request #1115: HADOOP-16207 testMR failures URL: https://github.com/apache/hadoop/pull/1115#discussion_r330485245 ## File path: hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/commit/AbstractYarnClusterITest.java

[GitHub] [hadoop] elek closed pull request #1537: HDDS-2187. ozone-mr test fails with No FileSystem for scheme o3fs

2019-10-02 Thread GitBox
elek closed pull request #1537: HDDS-2187. ozone-mr test fails with No FileSystem for scheme o3fs URL: https://github.com/apache/hadoop/pull/1537 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hadoop] hadoop-yetus commented on issue #1551: HDDS-2199 In SCMNodeManager dnsToUuidMap cannot track multiple DNs on the same host

2019-10-02 Thread GitBox
hadoop-yetus commented on issue #1551: HDDS-2199 In SCMNodeManager dnsToUuidMap cannot track multiple DNs on the same host URL: https://github.com/apache/hadoop/pull/1551#issuecomment-537467108 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment

[GitHub] [hadoop] adoroszlai commented on issue #1553: HDDS-2211. Collect docker logs if env fails to start

2019-10-02 Thread GitBox
adoroszlai commented on issue #1553: HDDS-2211. Collect docker logs if env fails to start URL: https://github.com/apache/hadoop/pull/1553#issuecomment-537356639 > I see a couple of integration test failures. How can I get to their docker-compose logs? Integration tests are simple

[GitHub] [hadoop] adoroszlai commented on issue #1570: HDDS-2216. Rename HADOOP_RUNNER_VERSION to OZONE_RUNNER_VERSION in co…

2019-10-02 Thread GitBox
adoroszlai commented on issue #1570: HDDS-2216. Rename HADOOP_RUNNER_VERSION to OZONE_RUNNER_VERSION in co… URL: https://github.com/apache/hadoop/pull/1570#issuecomment-537388339 /retest This is an automated message from the

[jira] [Commented] (HADOOP-14837) Handle S3A "glacier" data

2019-10-02 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-14837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942667#comment-16942667 ] Steve Loughran commented on HADOOP-14837: - we might also want a way to request that glacier

[GitHub] [hadoop] steveloughran commented on a change in pull request #1115: HADOOP-16207 testMR failures

2019-10-02 Thread GitBox
steveloughran commented on a change in pull request #1115: HADOOP-16207 testMR failures URL: https://github.com/apache/hadoop/pull/1115#discussion_r330474645 ## File path: hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/commit/AbstractYarnClusterITest.java

[GitHub] [hadoop] hadoop-yetus commented on issue #1572: HDDS-2226. S3 Secrets should use a strong RNG.

2019-10-02 Thread GitBox
hadoop-yetus commented on issue #1572: HDDS-2226. S3 Secrets should use a strong RNG. URL: https://github.com/apache/hadoop/pull/1572#issuecomment-537358735 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[jira] [Reopened] (HADOOP-16619) Upgrade jackson and jackson-databind to 2.9.10

2019-10-02 Thread Akira Ajisaka (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akira Ajisaka reopened HADOOP-16619: > Upgrade jackson and jackson-databind to 2.9.10 >

[jira] [Resolved] (HADOOP-16619) Upgrade jackson and jackson-databind to 2.9.10

2019-10-02 Thread Akira Ajisaka (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akira Ajisaka resolved HADOOP-16619. Resolution: Fixed Set resolution to Fixed > Upgrade jackson and jackson-databind to

[GitHub] [hadoop] avijayanhwx commented on issue #1536: HDDS-2164 : om.db.checkpoints is getting filling up fast.

2019-10-02 Thread GitBox
avijayanhwx commented on issue #1536: HDDS-2164 : om.db.checkpoints is getting filling up fast. URL: https://github.com/apache/hadoop/pull/1536#issuecomment-537422321 /retest This is an automated message from the Apache Git

[GitHub] [hadoop] adoroszlai commented on issue #1568: HDDS-2225. SCM fails to start in most unsecure environments due to leftover secure config

2019-10-02 Thread GitBox
adoroszlai commented on issue #1568: HDDS-2225. SCM fails to start in most unsecure environments due to leftover secure config URL: https://github.com/apache/hadoop/pull/1568#issuecomment-537426482 > Can you please help me to understand how is it possible. My assumption is that all the

[GitHub] [hadoop] hadoop-yetus commented on issue #1574: HDDS-2227. GDPR key generation could benefit from secureRandom.

2019-10-02 Thread GitBox
hadoop-yetus commented on issue #1574: HDDS-2227. GDPR key generation could benefit from secureRandom. URL: https://github.com/apache/hadoop/pull/1574#issuecomment-537369350 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] elek commented on issue #1568: HDDS-2225. SCM fails to start in most unsecure environments due to leftover secure config

2019-10-02 Thread GitBox
elek commented on issue #1568: HDDS-2225. SCM fails to start in most unsecure environments due to leftover secure config URL: https://github.com/apache/hadoop/pull/1568#issuecomment-537393689 Thanks @adoroszlai to fix this issue. Can you please help me to understand how is it

[GitHub] [hadoop] elek commented on a change in pull request #1542: HDDS-2140. Add robot test for GDPR feature

2019-10-02 Thread GitBox
elek commented on a change in pull request #1542: HDDS-2140. Add robot test for GDPR feature URL: https://github.com/apache/hadoop/pull/1542#discussion_r330475693 ## File path: hadoop-ozone/dist/src/main/smoketest/gdpr/gdpr.robot ## @@ -0,0 +1,68 @@ +# Licensed to the

[GitHub] [hadoop] steveloughran commented on a change in pull request #1115: HADOOP-16207 testMR failures

2019-10-02 Thread GitBox
steveloughran commented on a change in pull request #1115: HADOOP-16207 testMR failures URL: https://github.com/apache/hadoop/pull/1115#discussion_r330474645 ## File path: hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/commit/AbstractYarnClusterITest.java

[GitHub] [hadoop] steveloughran commented on a change in pull request #1115: HADOOP-16207 testMR failures

2019-10-02 Thread GitBox
steveloughran commented on a change in pull request #1115: HADOOP-16207 testMR failures URL: https://github.com/apache/hadoop/pull/1115#discussion_r330476090 ## File path: hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/commit/terasort/ITestTerasortOnS3A.java

[GitHub] [hadoop] elek commented on a change in pull request #1551: HDDS-2199 In SCMNodeManager dnsToUuidMap cannot track multiple DNs on the same host

2019-10-02 Thread GitBox
elek commented on a change in pull request #1551: HDDS-2199 In SCMNodeManager dnsToUuidMap cannot track multiple DNs on the same host URL: https://github.com/apache/hadoop/pull/1551#discussion_r330472982 ## File path:

[GitHub] [hadoop] elek commented on a change in pull request #1551: HDDS-2199 In SCMNodeManager dnsToUuidMap cannot track multiple DNs on the same host

2019-10-02 Thread GitBox
elek commented on a change in pull request #1551: HDDS-2199 In SCMNodeManager dnsToUuidMap cannot track multiple DNs on the same host URL: https://github.com/apache/hadoop/pull/1551#discussion_r330473420 ## File path:

[GitHub] [hadoop] elek commented on a change in pull request #1551: HDDS-2199 In SCMNodeManager dnsToUuidMap cannot track multiple DNs on the same host

2019-10-02 Thread GitBox
elek commented on a change in pull request #1551: HDDS-2199 In SCMNodeManager dnsToUuidMap cannot track multiple DNs on the same host URL: https://github.com/apache/hadoop/pull/1551#discussion_r330472747 ## File path:

[GitHub] [hadoop] elek commented on a change in pull request #1551: HDDS-2199 In SCMNodeManager dnsToUuidMap cannot track multiple DNs on the same host

2019-10-02 Thread GitBox
elek commented on a change in pull request #1551: HDDS-2199 In SCMNodeManager dnsToUuidMap cannot track multiple DNs on the same host URL: https://github.com/apache/hadoop/pull/1551#discussion_r330472747 ## File path:

[GitHub] [hadoop] anuengineer opened a new pull request #1574: HDDS-2227. GDPR key generation could benefit from secureRandom.

2019-10-02 Thread GitBox
anuengineer opened a new pull request #1574: HDDS-2227. GDPR key generation could benefit from secureRandom. URL: https://github.com/apache/hadoop/pull/1574 https://issues.apache.org/jira/browse/HDDS-2227 The SecureRandom can be used for the symetric key for GDPR. While GDPR is not a

[GitHub] [hadoop] steveloughran commented on a change in pull request #1115: HADOOP-16207 testMR failures

2019-10-02 Thread GitBox
steveloughran commented on a change in pull request #1115: HADOOP-16207 testMR failures URL: https://github.com/apache/hadoop/pull/1115#discussion_r330472871 ## File path: hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/commit/integration/ITestS3ACommitterMRJob.java

[GitHub] [hadoop] hadoop-yetus commented on issue #1517: HDDS-2169

2019-10-02 Thread GitBox
hadoop-yetus commented on issue #1517: HDDS-2169 URL: https://github.com/apache/hadoop/pull/1517#issuecomment-537368918 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 78 | Docker

[GitHub] [hadoop] hadoop-yetus commented on issue #1573: HDFS-14889. Add ability to identify a Provided storage block.

2019-10-02 Thread GitBox
hadoop-yetus commented on issue #1573: HDFS-14889. Add ability to identify a Provided storage block. URL: https://github.com/apache/hadoop/pull/1573#issuecomment-537395365 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] xiaoyuyao commented on a change in pull request #1571: HDDS-2228. Fix NPE in OzoneDelegationTokenManager#addPersistedDelegat…

2019-10-02 Thread GitBox
xiaoyuyao commented on a change in pull request #1571: HDDS-2228. Fix NPE in OzoneDelegationTokenManager#addPersistedDelegat… URL: https://github.com/apache/hadoop/pull/1571#discussion_r330594466 ## File path:

[GitHub] [hadoop] bgaborg opened a new pull request #1576: Hadoop 16520 dynamodb ms version race refactor.

2019-10-02 Thread GitBox
bgaborg opened a new pull request #1576: Hadoop 16520 dynamodb ms version race refactor. URL: https://github.com/apache/hadoop/pull/1576 The following should be included: HADOOP-16349. DynamoDBMetadataStore.getVersionMarkerItem() to log at info/warn on retry. Notes: - Why

[GitHub] [hadoop] steveloughran commented on issue #1115: HADOOP-16207 testMR failures

2019-10-02 Thread GitBox
steveloughran commented on issue #1115: HADOOP-16207 testMR failures URL: https://github.com/apache/hadoop/pull/1115#issuecomment-537553344 Also removed all changes which went near the committer code itself, to avoid conflict with #1442. This is a test code only patch now

[jira] [Commented] (HADOOP-16587) Make AAD endpoint configurable on all Auth flows

2019-10-02 Thread Bilahari T H (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942934#comment-16942934 ] Bilahari T H commented on HADOOP-16587: --- *Driver test results using accounts in Central India:*

[GitHub] [hadoop] szetszwo edited a comment on issue #1517: HDDS-2169

2019-10-02 Thread GitBox
szetszwo edited a comment on issue #1517: HDDS-2169 URL: https://github.com/apache/hadoop/pull/1517#issuecomment-537516020 > Thanks @szetszwo for updating the patch. i think We need to change the parsing logic applyTransaction call in ContainerStateMachine as well because the integration

[GitHub] [hadoop] sodonnel commented on a change in pull request #1551: HDDS-2199 In SCMNodeManager dnsToUuidMap cannot track multiple DNs on the same host

2019-10-02 Thread GitBox
sodonnel commented on a change in pull request #1551: HDDS-2199 In SCMNodeManager dnsToUuidMap cannot track multiple DNs on the same host URL: https://github.com/apache/hadoop/pull/1551#discussion_r330585772 ## File path:

[GitHub] [hadoop] sodonnel commented on a change in pull request #1551: HDDS-2199 In SCMNodeManager dnsToUuidMap cannot track multiple DNs on the same host

2019-10-02 Thread GitBox
sodonnel commented on a change in pull request #1551: HDDS-2199 In SCMNodeManager dnsToUuidMap cannot track multiple DNs on the same host URL: https://github.com/apache/hadoop/pull/1551#discussion_r330585943 ## File path:

[GitHub] [hadoop] hadoop-yetus commented on issue #1551: HDDS-2199 In SCMNodeManager dnsToUuidMap cannot track multiple DNs on the same host

2019-10-02 Thread GitBox
hadoop-yetus commented on issue #1551: HDDS-2199 In SCMNodeManager dnsToUuidMap cannot track multiple DNs on the same host URL: https://github.com/apache/hadoop/pull/1551#issuecomment-537537486 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment

[GitHub] [hadoop] steveloughran commented on issue #1576: Hadoop 16520 dynamodb ms version race refactor.

2019-10-02 Thread GitBox
steveloughran commented on issue #1576: Hadoop 16520 dynamodb ms version race refactor. URL: https://github.com/apache/hadoop/pull/1576#issuecomment-537552619 yeah, anything which avoids creating duplicate tables is good. I did some of that the last time I worked on

[GitHub] [hadoop] hadoop-yetus commented on issue #1551: HDDS-2199 In SCMNodeManager dnsToUuidMap cannot track multiple DNs on the same host

2019-10-02 Thread GitBox
hadoop-yetus commented on issue #1551: HDDS-2199 In SCMNodeManager dnsToUuidMap cannot track multiple DNs on the same host URL: https://github.com/apache/hadoop/pull/1551#issuecomment-537560160 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment

[GitHub] [hadoop] hadoop-yetus commented on issue #1576: Hadoop 16520 dynamodb ms version race refactor.

2019-10-02 Thread GitBox
hadoop-yetus commented on issue #1576: Hadoop 16520 dynamodb ms version race refactor. URL: https://github.com/apache/hadoop/pull/1576#issuecomment-537560337 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] steveloughran commented on a change in pull request #1576: Hadoop 16520 dynamodb ms version race refactor.

2019-10-02 Thread GitBox
steveloughran commented on a change in pull request #1576: Hadoop 16520 dynamodb ms version race refactor. URL: https://github.com/apache/hadoop/pull/1576#discussion_r330636147 ## File path:

[GitHub] [hadoop] steveloughran commented on a change in pull request #1576: Hadoop 16520 dynamodb ms version race refactor.

2019-10-02 Thread GitBox
steveloughran commented on a change in pull request #1576: Hadoop 16520 dynamodb ms version race refactor. URL: https://github.com/apache/hadoop/pull/1576#discussion_r330636630 ## File path:

[GitHub] [hadoop] szetszwo edited a comment on issue #1517: HDDS-2169

2019-10-02 Thread GitBox
szetszwo edited a comment on issue #1517: HDDS-2169 URL: https://github.com/apache/hadoop/pull/1517#issuecomment-537516020 > Thanks @szetszwo for updating the patch. i think We need to change the parsing logic applyTransaction call in ContainerStateMachine as well because the integration

[GitHub] [hadoop] arp7 commented on issue #1553: HDDS-2211. Collect docker logs if env fails to start

2019-10-02 Thread GitBox
arp7 commented on issue #1553: HDDS-2211. Collect docker logs if env fails to start URL: https://github.com/apache/hadoop/pull/1553#issuecomment-537563842 Looks good. +1 from me. I will commit this today. This is an

[GitHub] [hadoop] hadoop-yetus commented on issue #1576: Hadoop 16520 dynamodb ms version race refactor.

2019-10-02 Thread GitBox
hadoop-yetus commented on issue #1576: Hadoop 16520 dynamodb ms version race refactor. URL: https://github.com/apache/hadoop/pull/1576#issuecomment-537563747 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] bshashikant commented on issue #1517: HDDS-2169

2019-10-02 Thread GitBox
bshashikant commented on issue #1517: HDDS-2169 URL: https://github.com/apache/hadoop/pull/1517#issuecomment-537506735 Thanks @szetszwo for updating the patch. i think We need to change the parsing logic applyTransaction call in ContainerStateMachine as well because the integration test

[GitHub] [hadoop] kihwal edited a comment on issue #1432: HADOOP-16557. [pb-upgrade] Upgrade protobuf.version to 3.7.1

2019-10-02 Thread GitBox
kihwal edited a comment on issue #1432: HADOOP-16557. [pb-upgrade] Upgrade protobuf.version to 3.7.1 URL: https://github.com/apache/hadoop/pull/1432#issuecomment-537520108 I doubled-checked the HDFS fsimage format compatibility. Today's trunk build was able to read a 16GB image written by

[GitHub] [hadoop] kihwal commented on issue #1432: HADOOP-16557. [pb-upgrade] Upgrade protobuf.version to 3.7.1

2019-10-02 Thread GitBox
kihwal commented on issue #1432: HADOOP-16557. [pb-upgrade] Upgrade protobuf.version to 3.7.1 URL: https://github.com/apache/hadoop/pull/1432#issuecomment-537520108 I doubled-checked the HDFS fsimage format compatibility. Today's trunk build was able read a 16GB image written by a 2.8.5

[GitHub] [hadoop] elek commented on a change in pull request #1551: HDDS-2199 In SCMNodeManager dnsToUuidMap cannot track multiple DNs on the same host

2019-10-02 Thread GitBox
elek commented on a change in pull request #1551: HDDS-2199 In SCMNodeManager dnsToUuidMap cannot track multiple DNs on the same host URL: https://github.com/apache/hadoop/pull/1551#discussion_r330622132 ## File path:

[GitHub] [hadoop] steveloughran commented on a change in pull request #1576: Hadoop 16520 dynamodb ms version race refactor.

2019-10-02 Thread GitBox
steveloughran commented on a change in pull request #1576: Hadoop 16520 dynamodb ms version race refactor. URL: https://github.com/apache/hadoop/pull/1576#discussion_r330637984 ## File path:

[GitHub] [hadoop] szetszwo commented on issue #1517: HDDS-2169

2019-10-02 Thread GitBox
szetszwo commented on issue #1517: HDDS-2169 URL: https://github.com/apache/hadoop/pull/1517#issuecomment-537516020 > Thanks @szetszwo for updating the patch. i think We need to change the parsing logic applyTransaction call in ContainerStateMachine as well because the integration test

[GitHub] [hadoop] sodonnel commented on a change in pull request #1551: HDDS-2199 In SCMNodeManager dnsToUuidMap cannot track multiple DNs on the same host

2019-10-02 Thread GitBox
sodonnel commented on a change in pull request #1551: HDDS-2199 In SCMNodeManager dnsToUuidMap cannot track multiple DNs on the same host URL: https://github.com/apache/hadoop/pull/1551#discussion_r330585159 ## File path:

[GitHub] [hadoop] hadoop-yetus commented on issue #1517: HDDS-2169

2019-10-02 Thread GitBox
hadoop-yetus commented on issue #1517: HDDS-2169 URL: https://github.com/apache/hadoop/pull/1517#issuecomment-537535783 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 80 | Docker

[GitHub] [hadoop] steveloughran commented on issue #1115: HADOOP-16207 testMR failures

2019-10-02 Thread GitBox
steveloughran commented on issue #1115: HADOOP-16207 testMR failures URL: https://github.com/apache/hadoop/pull/1115#issuecomment-537550874 Here is a new revision. Tests in progress. * track stages executed and use an assume() to skip subsequent tests on a failure. Note: this

[GitHub] [hadoop] steveloughran commented on a change in pull request #1576: Hadoop 16520 dynamodb ms version race refactor.

2019-10-02 Thread GitBox
steveloughran commented on a change in pull request #1576: Hadoop 16520 dynamodb ms version race refactor. URL: https://github.com/apache/hadoop/pull/1576#discussion_r330638448 ## File path:

[GitHub] [hadoop] steveloughran commented on a change in pull request #1576: Hadoop 16520 dynamodb ms version race refactor.

2019-10-02 Thread GitBox
steveloughran commented on a change in pull request #1576: Hadoop 16520 dynamodb ms version race refactor. URL: https://github.com/apache/hadoop/pull/1576#discussion_r330649704 ## File path:

[jira] [Commented] (HADOOP-16587) Make AAD endpoint configurable on all Auth flows

2019-10-02 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943005#comment-16943005 ] Hadoop QA commented on HADOOP-16587: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[GitHub] [hadoop] sodonnel commented on a change in pull request #1551: HDDS-2199 In SCMNodeManager dnsToUuidMap cannot track multiple DNs on the same host

2019-10-02 Thread GitBox
sodonnel commented on a change in pull request #1551: HDDS-2199 In SCMNodeManager dnsToUuidMap cannot track multiple DNs on the same host URL: https://github.com/apache/hadoop/pull/1551#discussion_r330682420 ## File path:

[jira] [Comment Edited] (HADOOP-16393) S3Guard init command uses global settings, not those of target bucket

2019-10-02 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943031#comment-16943031 ] Steve Loughran edited comment on HADOOP-16393 at 10/2/19 5:46 PM: --

[jira] [Comment Edited] (HADOOP-16393) S3Guard init command uses global settings, not those of target bucket

2019-10-02 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943031#comment-16943031 ] Steve Loughran edited comment on HADOOP-16393 at 10/2/19 5:46 PM: --

[jira] [Commented] (HADOOP-16393) S3Guard init command uses global settings, not those of target bucket

2019-10-02 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943040#comment-16943040 ] Steve Loughran commented on HADOOP-16393: - The issue here is that we need to pick up the table

[GitHub] [hadoop] sidseth commented on a change in pull request #1115: HADOOP-16207 testMR failures

2019-10-02 Thread GitBox
sidseth commented on a change in pull request #1115: HADOOP-16207 testMR failures URL: https://github.com/apache/hadoop/pull/1115#discussion_r330702914 ## File path: hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/commit/AbstractYarnClusterITest.java ## @@

[GitHub] [hadoop] anuengineer commented on issue #1572: HDDS-2226. S3 Secrets should use a strong RNG.

2019-10-02 Thread GitBox
anuengineer commented on issue #1572: HDDS-2226. S3 Secrets should use a strong RNG. URL: https://github.com/apache/hadoop/pull/1572#issuecomment-537620551 /retest This is an automated message from the Apache Git Service. To

[GitHub] [hadoop] anuengineer merged pull request #1566: HDDS-2201. Rename VolumeList to UserVolumeInfo.

2019-10-02 Thread GitBox
anuengineer merged pull request #1566: HDDS-2201. Rename VolumeList to UserVolumeInfo. URL: https://github.com/apache/hadoop/pull/1566 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hadoop] anuengineer commented on issue #1566: HDDS-2201. Rename VolumeList to UserVolumeInfo.

2019-10-02 Thread GitBox
anuengineer commented on issue #1566: HDDS-2201. Rename VolumeList to UserVolumeInfo. URL: https://github.com/apache/hadoop/pull/1566#issuecomment-537572816 Test failures are not related to this patch. Committed to trunk. @dineshchitlangia Thank you for the review.

[GitHub] [hadoop] goiri commented on a change in pull request #1573: HDFS-14889. Add ability to identify a Provided storage block.

2019-10-02 Thread GitBox
goiri commented on a change in pull request #1573: HDFS-14889. Add ability to identify a Provided storage block. URL: https://github.com/apache/hadoop/pull/1573#discussion_r330671348 ## File path:

[GitHub] [hadoop] goiri commented on a change in pull request #1573: HDFS-14889. Add ability to identify a Provided storage block.

2019-10-02 Thread GitBox
goiri commented on a change in pull request #1573: HDFS-14889. Add ability to identify a Provided storage block. URL: https://github.com/apache/hadoop/pull/1573#discussion_r330670779 ## File path:

[GitHub] [hadoop] goiri commented on a change in pull request #1573: HDFS-14889. Add ability to identify a Provided storage block.

2019-10-02 Thread GitBox
goiri commented on a change in pull request #1573: HDFS-14889. Add ability to identify a Provided storage block. URL: https://github.com/apache/hadoop/pull/1573#discussion_r330670481 ## File path:

[GitHub] [hadoop] goiri commented on a change in pull request #1573: HDFS-14889. Add ability to identify a Provided storage block.

2019-10-02 Thread GitBox
goiri commented on a change in pull request #1573: HDFS-14889. Add ability to identify a Provided storage block. URL: https://github.com/apache/hadoop/pull/1573#discussion_r330670733 ## File path:

[GitHub] [hadoop] goiri commented on a change in pull request #1573: HDFS-14889. Add ability to identify a Provided storage block.

2019-10-02 Thread GitBox
goiri commented on a change in pull request #1573: HDFS-14889. Add ability to identify a Provided storage block. URL: https://github.com/apache/hadoop/pull/1573#discussion_r330670220 ## File path:

[GitHub] [hadoop] goiri commented on a change in pull request #1573: HDFS-14889. Add ability to identify a Provided storage block.

2019-10-02 Thread GitBox
goiri commented on a change in pull request #1573: HDFS-14889. Add ability to identify a Provided storage block. URL: https://github.com/apache/hadoop/pull/1573#discussion_r330671566 ## File path:

[jira] [Reopened] (HADOOP-16393) S3Guard init command uses global settings, not those of target bucket

2019-10-02 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran reopened HADOOP-16393: - still seeing this ``` bin/hadoop s3guard init s3a://hwdev-steve-ireland-new/ 2019-10-02

[GitHub] [hadoop] steveloughran commented on issue #1576: Hadoop 16520 dynamodb ms version race refactor.

2019-10-02 Thread GitBox
steveloughran commented on issue #1576: Hadoop 16520 dynamodb ms version race refactor. URL: https://github.com/apache/hadoop/pull/1576#issuecomment-537610443 I tested out on the command line while doing things to the DDB tables " Version marker in the dynamo table was null"

[GitHub] [hadoop] steveloughran commented on a change in pull request #1481: HADOOP-16587: Made auth endpoints configurable for MSI and refresh token flows

2019-10-02 Thread GitBox
steveloughran commented on a change in pull request #1481: HADOOP-16587: Made auth endpoints configurable for MSI and refresh token flows URL: https://github.com/apache/hadoop/pull/1481#discussion_r330694773 ## File path:

[GitHub] [hadoop] sidseth commented on a change in pull request #1115: HADOOP-16207 testMR failures

2019-10-02 Thread GitBox
sidseth commented on a change in pull request #1115: HADOOP-16207 testMR failures URL: https://github.com/apache/hadoop/pull/1115#discussion_r330706141 ## File path: hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/commit/integration/ITestS3ACommitterMRJob.java

[GitHub] [hadoop] steveloughran commented on a change in pull request #1576: Hadoop 16520 dynamodb ms version race refactor.

2019-10-02 Thread GitBox
steveloughran commented on a change in pull request #1576: Hadoop 16520 dynamodb ms version race refactor. URL: https://github.com/apache/hadoop/pull/1576#discussion_r330639780 ## File path:

[GitHub] [hadoop] steveloughran commented on a change in pull request #1576: Hadoop 16520 dynamodb ms version race refactor.

2019-10-02 Thread GitBox
steveloughran commented on a change in pull request #1576: Hadoop 16520 dynamodb ms version race refactor. URL: https://github.com/apache/hadoop/pull/1576#discussion_r330639194 ## File path:

[GitHub] [hadoop] steveloughran commented on a change in pull request #1576: Hadoop 16520 dynamodb ms version race refactor.

2019-10-02 Thread GitBox
steveloughran commented on a change in pull request #1576: Hadoop 16520 dynamodb ms version race refactor. URL: https://github.com/apache/hadoop/pull/1576#discussion_r330642145 ## File path:

[GitHub] [hadoop] fapifta closed pull request #1544: HDDS-2203 Race condition in ByteStringHelper.init()

2019-10-02 Thread GitBox
fapifta closed pull request #1544: HDDS-2203 Race condition in ByteStringHelper.init() URL: https://github.com/apache/hadoop/pull/1544 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hadoop] fapifta commented on issue #1544: HDDS-2203 Race condition in ByteStringHelper.init()

2019-10-02 Thread GitBox
fapifta commented on issue #1544: HDDS-2203 Race condition in ByteStringHelper.init() URL: https://github.com/apache/hadoop/pull/1544#issuecomment-537585464 I am closing this PR, and will open a new one once I have implemented what we discussed in the JIRA. Closing the JIRA itself as

[GitHub] [hadoop] hadoop-yetus commented on issue #1481: HADOOP-16587: Made auth endpoints configurable for MSI and refresh token flows

2019-10-02 Thread GitBox
hadoop-yetus commented on issue #1481: HADOOP-16587: Made auth endpoints configurable for MSI and refresh token flows URL: https://github.com/apache/hadoop/pull/1481#issuecomment-537595068 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] sodonnel commented on a change in pull request #1551: HDDS-2199 In SCMNodeManager dnsToUuidMap cannot track multiple DNs on the same host

2019-10-02 Thread GitBox
sodonnel commented on a change in pull request #1551: HDDS-2199 In SCMNodeManager dnsToUuidMap cannot track multiple DNs on the same host URL: https://github.com/apache/hadoop/pull/1551#discussion_r330682420 ## File path:

[GitHub] [hadoop] steveloughran commented on issue #1576: Hadoop 16520 dynamodb ms version race refactor.

2019-10-02 Thread GitBox
steveloughran commented on issue #1576: Hadoop 16520 dynamodb ms version race refactor. URL: https://github.com/apache/hadoop/pull/1576#issuecomment-537611585 I should add -overall patch LGTM; these are very minor changes. Impressed that the tag update means that you get this version

[jira] [Updated] (HADOOP-16587) Make AAD endpoint configurable on all Auth flows

2019-10-02 Thread Bilahari T H (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilahari T H updated HADOOP-16587: -- Attachment: HADOOP-16587.004.patch > Make AAD endpoint configurable on all Auth flows >

[GitHub] [hadoop] hadoop-yetus commented on issue #1576: Hadoop 16520 dynamodb ms version race refactor.

2019-10-02 Thread GitBox
hadoop-yetus commented on issue #1576: Hadoop 16520 dynamodb ms version race refactor. URL: https://github.com/apache/hadoop/pull/1576#issuecomment-537571813 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] hadoop-yetus commented on issue #1115: HADOOP-16207 testMR failures

2019-10-02 Thread GitBox
hadoop-yetus commented on issue #1115: HADOOP-16207 testMR failures URL: https://github.com/apache/hadoop/pull/1115#issuecomment-537577690 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 |

[GitHub] [hadoop] steveloughran commented on a change in pull request #1576: Hadoop 16520 dynamodb ms version race refactor.

2019-10-02 Thread GitBox
steveloughran commented on a change in pull request #1576: Hadoop 16520 dynamodb ms version race refactor. URL: https://github.com/apache/hadoop/pull/1576#discussion_r330657047 ## File path:

[jira] [Commented] (HADOOP-16587) Make AAD endpoint configurable on all Auth flows

2019-10-02 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943034#comment-16943034 ] Hadoop QA commented on HADOOP-16587: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

  1   2   3   >