[
https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16279098#comment-16279098
]
Hudson commented on HADOOP-14475:
-
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13329 (See
[
https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16279060#comment-16279060
]
Aaron Fabbri commented on HADOOP-14475:
---
Also apology for the typo, I misspelled your name in the
[
https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277782#comment-16277782
]
Aaron Fabbri commented on HADOOP-14475:
---
Latest patch looks good to me. Tested w/ and w/o s3guard
[
https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275170#comment-16275170
]
genericqa commented on HADOOP-14475:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16274914#comment-16274914
]
genericqa commented on HADOOP-14475:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16274907#comment-16274907
]
Sean Mackrory commented on HADOOP-14475:
{quote} the test thinks s3guard is off, but it isn't,
[
https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16274823#comment-16274823
]
Steve Loughran commented on HADOOP-14475:
-
Commented on HADOOP-15079; I have seen this but
[
https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16273606#comment-16273606
]
Aaron Fabbri commented on HADOOP-14475:
---
v15 patch looks good with minor change:
{noformat}
+its
[
https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16273554#comment-16273554
]
Sean Mackrory commented on HADOOP-14475:
Filed HADOOP-15079. I'm quite certain it's unrelated to
[
https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16272970#comment-16272970
]
Sean Mackrory commented on HADOOP-14475:
I never saw the issue you were referring to and can't
[
https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16271668#comment-16271668
]
Aaron Fabbri commented on HADOOP-14475:
---
I added some instrumentation to detect use after close
[
https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270532#comment-16270532
]
Steve Loughran commented on HADOOP-14475:
-
bq. Quick glance at code, looks like instrumentation
[
https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270527#comment-16270527
]
Steve Loughran commented on HADOOP-14475:
-
bq. let's maybe handle that as a distinct issue from
[
https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270034#comment-16270034
]
Aaron Fabbri commented on HADOOP-14475:
---
Testing v15 patch I'm seeing occasional NPEs in test
[
https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16269021#comment-16269021
]
Sean Mackrory commented on HADOOP-14475:
Yeah FileSink seems to be too primitive for real-world
[
https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268990#comment-16268990
]
Steve Loughran commented on HADOOP-14475:
-
I know you two want to log for a file, but what about
[
https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268964#comment-16268964
]
Sean Mackrory commented on HADOOP-14475:
Okay - sounds like we're on the same page, then -
[
https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268148#comment-16268148
]
Yonger commented on HADOOP-14475:
-
[~mackrorysd] Thank you. I start to understand your logic, and I
[
https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268073#comment-16268073
]
Sean Mackrory commented on HADOOP-14475:
[~iyonger] I don't believe I've changed anything that
[
https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268051#comment-16268051
]
Yonger commented on HADOOP-14475:
-
[~mackrorysd] So our final output format of record doesn't include
[
https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16267892#comment-16267892
]
genericqa commented on HADOOP-14475:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16267865#comment-16267865
]
Sean Mackrory commented on HADOOP-14475:
One other thing worth mentioning is the compatibility
[
https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16267791#comment-16267791
]
genericqa commented on HADOOP-14475:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16267086#comment-16267086
]
Sean Mackrory commented on HADOOP-14475:
{quote}I think we'd probably be better off with
[
https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266866#comment-16266866
]
Yonger commented on HADOOP-14475:
-
azure just give the registry name to the record, which is confused.
[
https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16260516#comment-16260516
]
Steve Loughran commented on HADOOP-14475:
-
I think we'd probably be better off with hostname
[
https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16260436#comment-16260436
]
Yonger commented on HADOOP-14475:
-
[~mackrorysd]Thanks for refining the code, that looks pretty good for
[
https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16259935#comment-16259935
]
Hadoop QA commented on HADOOP-14475:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16259646#comment-16259646
]
Steve Loughran commented on HADOOP-14475:
-
Looking good.
h3. S3AInstrumentation
*
[
https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16257896#comment-16257896
]
Hadoop QA commented on HADOOP-14475:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16257757#comment-16257757
]
Aaron Fabbri commented on HADOOP-14475:
---
Some initial comments on v11-- in addition to above.
- I
[
https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16257309#comment-16257309
]
Hadoop QA commented on HADOOP-14475:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16257249#comment-16257249
]
Sean Mackrory commented on HADOOP-14475:
Also note that I made the record name / source name
[
https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16256382#comment-16256382
]
Hadoop QA commented on HADOOP-14475:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16254662#comment-16254662
]
Sean Mackrory commented on HADOOP-14475:
{quote}DefaultMetricsSystem lifecycle API is confusing
[
https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16254647#comment-16254647
]
Aaron Fabbri commented on HADOOP-14475:
---
There is a learning curve for this Metrics2 stuff. I
[
https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16254356#comment-16254356
]
Hadoop QA commented on HADOOP-14475:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16254283#comment-16254283
]
Aaron Fabbri commented on HADOOP-14475:
---
I will take a look at v9 patch. Noticing some checkstyle
[
https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16252976#comment-16252976
]
Yonger commented on HADOOP-14475:
-
[~mackrorysd]Thank you.
> Metrics of S3A don't print out when
[
https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16252886#comment-16252886
]
Sean Mackrory commented on HADOOP-14475:
Okay - thanks for the additional context. I think the
[
https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16252804#comment-16252804
]
Yonger commented on HADOOP-14475:
-
For the # 2 point of my update
--
[
https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16252798#comment-16252798
]
Yonger commented on HADOOP-14475:
-
[~macdonsp]the .008 patch is newer than .007 patch, I think it's the
[
https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16251577#comment-16251577
]
Sean Mackrory commented on HADOOP-14475:
Also some minor checkstyle issues - but if you can
[
https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16251543#comment-16251543
]
Sean Mackrory commented on HADOOP-14475:
Thanks for the update [~iyonger]! Your .008 patch
[
https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16251540#comment-16251540
]
Hadoop QA commented on HADOOP-14475:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16251020#comment-16251020
]
Yonger commented on HADOOP-14475:
-
[~mackrorysd] Thank you very much.
For the test case, I removed the
[
https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16234542#comment-16234542
]
Sean Mackrory commented on HADOOP-14475:
I tried this out on a cluster. I saw that if I
[
https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16225594#comment-16225594
]
Sean Mackrory commented on HADOOP-14475:
Actually I do have a couple of thoughts on the patch:
*
[
https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16225425#comment-16225425
]
Sean Mackrory commented on HADOOP-14475:
This is needed:
{code}
-String targetMetricSource
[
https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16225089#comment-16225089
]
Sean Mackrory commented on HADOOP-14475:
I'm taking a look at this. For what it's worth, before
[
https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219174#comment-16219174
]
Hadoop QA commented on HADOOP-14475:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219001#comment-16219001
]
Hadoop QA commented on HADOOP-14475:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216729#comment-16216729
]
Hadoop QA commented on HADOOP-14475:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16153417#comment-16153417
]
Steve Loughran commented on HADOOP-14475:
-
Has anyone had a look @ this yet? I'd like to get it
[
https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16128548#comment-16128548
]
Yonger commented on HADOOP-14475:
-
[~ste...@apache.org] Can you help to verify and review this patch?
[
https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110545#comment-16110545
]
Hadoop QA commented on HADOOP-14475:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110482#comment-16110482
]
Hadoop QA commented on HADOOP-14475:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16100142#comment-16100142
]
Yonger commented on HADOOP-14475:
-
[~ste...@apache.org] I found the output of metrics missing part of
[
https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16093406#comment-16093406
]
Hadoop QA commented on HADOOP-14475:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16076511#comment-16076511
]
Yonger commented on HADOOP-14475:
-
[~stevea] the method you mentioned give an empty url to skip the
[
https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16063081#comment-16063081
]
Steve Loughran commented on HADOOP-14475:
-
# {{S3AInstrumentation}}: revert the .* import to the
[
https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16059200#comment-16059200
]
Steve Loughran commented on HADOOP-14475:
-
Failures related to landsat-pds happen when you go
[
https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16059131#comment-16059131
]
Hadoop QA commented on HADOOP-14475:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16059119#comment-16059119
]
Hadoop QA commented on HADOOP-14475:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057270#comment-16057270
]
Steve Loughran commented on HADOOP-14475:
-
bq. the name change of context just for distinguish
[
https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16056807#comment-16056807
]
Yonger commented on HADOOP-14475:
-
@Deng, each task should have an individual s3a file system that i
[
https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16056522#comment-16056522
]
Ai Deng commented on HADOOP-14475:
--
Hello [~iyonger], [~ste...@apache.org] I found this ticket when I
[
https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16040018#comment-16040018
]
Yonger commented on HADOOP-14475:
-
In my case, i just run DFSIO with 20 map/reduce tasks in a 4-nodes
[
https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16039637#comment-16039637
]
Steve Loughran commented on HADOOP-14475:
-
bq. 3.that is the issue confused me. I still don't
[
https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16038864#comment-16038864
]
Yonger commented on HADOOP-14475:
-
Thanks for your suggestion. I will take case for code style and do
[
https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16038746#comment-16038746
]
Steve Loughran commented on HADOOP-14475:
-
Seems a good start, though it'll need some iterations
[
https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16037314#comment-16037314
]
Hadoop QA commented on HADOOP-14475:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16034518#comment-16034518
]
Steve Loughran commented on HADOOP-14475:
-
You are probably the first person to play with this.
73 matches
Mail list logo