Re: DNS proxy

2015-06-29 Thread Patrik Flykt
On Fri, 2015-06-26 at 08:01 -0700, Naveen Singh wrote: I am attaching a simple patch for this fix. Please send the patch inline with 'git send-email' or similar. No attachments, please. Cheers, Patrik ___ connman mailing list

Re: Dynamic natting with connman

2015-06-29 Thread Patrik Flykt
On Wed, 2015-06-24 at 10:19 +0530, Sriram Sagar wrote: Hi, Using connman, is there any possibility that we can do dynamic Natting. 'connmanctl tether wifi on ssid passphrase' would enable masquerading (dynamic NAT) from bridge tether to any uplink destination. With the latest patch on the

Re: [PATCH] wifi: Fix Possible memory leak

2015-06-29 Thread Patrik Flykt
On Tue, 2015-06-23 at 11:58 +0530, Saurav Babu wrote: This patch frees peer_params-path and peer_params-wps_pin also when peer_params is freed. Both peer_params-path and peer_params-wps_pin are allocated memory using g_strdup() and needs to be freed when g_supplicant_interface_p2p_connect()

[PATCH v2 4/4] wifi: Correctly reference count a pending network

2015-06-23 Thread Patrik Flykt
With a WiFi to WiFi switch, the previous network is being disconnected while the new one is waiting for the device to become available. Protect the network struct with a ref so it will be available while the previous network is disconnecting. --- plugins/wifi.c | 7 +-- 1 file changed, 5

[PATCH v2 1/4] wifi: Try to enable tethering for an unused device

2015-06-23 Thread Patrik Flykt
When enabling tethering, try to first find a device without a network connection that supports AP mode. If none is found, try again but this time ignoring the network connection. Factor out tethering enabling adding a boolea parameter that tells whether to consider a connected network or not.

[PATCH v2 3/4] wifi: Set network disconnected in disconnect_callback()

2015-06-23 Thread Patrik Flykt
The network needs to be set disconnected in the callback as the pointer will be unconditionally cleared in the function. Even with a result of zero the interface_state() cannot be relied on; it might not be called by gsupplicant/wpa_supplicant in all cases. Reported by Thomas Green. ---

[PATCH v2 0/4] WiFi tethering fixes

2015-06-23 Thread Patrik Flykt
/4 got revorked, turns out this seems to be needed for a WiFi to WiFi switch. In this case reference counting needs to happen in order not to use memory that has been freed in between. Cheers, Patrik *** BLURB HERE *** Patrik Flykt (4): wifi: Try to enable tethering for an unused

[PATCH 3/4] wifi: Set network disconnected in disconnect_callback()

2015-06-23 Thread Patrik Flykt
The network needs to be set disconnected in the callback as the pointer will be unconditionally cleared in the function. Even with a result of zero the interface_state() cannot be relied on; it might not be called by gsupplicant/wpa_supplicant in all cases. Reported by Thomas Green. ---

[PATCH 0/4] WiFi tethering fixes

2015-06-23 Thread Patrik Flykt
. The other two patches are cleanups for minor issues discovered. Cheers, Patrik Patrik Flykt (4): wifi: Try to enable tethering for an unused device wifi: Factor out freeing of variables on tethering failure wifi: Set network disconnected in disconnect_callback() wifi: Remove unused

[PATCH 1/4] wifi: Try to enable tethering for an unused device

2015-06-23 Thread Patrik Flykt
When enabling tethering, try to first find a device without a network connection that supports AP mode. If none is found, try again but this time ignoring the network connection. Factor out tethering enabling adding a boolea parameter that tells whether to consider a connected network or not.

[PATCH 2/4] wifi: Factor out freeing of variables on tethering failure

2015-06-23 Thread Patrik Flykt
Clean up variables in one place if tethering fails and continue with the next wifi if one exists. --- plugins/wifi.c | 34 +- 1 file changed, 13 insertions(+), 21 deletions(-) diff --git a/plugins/wifi.c b/plugins/wifi.c index db29090..de176ed 100644 ---

Re: DHCP timers

2015-06-23 Thread Patrik Flykt
On Mon, 2015-06-22 at 11:04 -0700, Naveen Singh wrote: This affects all timers set by ConnMan, so a generic fix would be of interest. Hasn't this been implemented in some version of glib already? I have the latest Glib (2.43.2). I did not find any thing in glib to support this. That

Re: [PATCH 4/4] wifi: Remove unused pending_network

2015-06-23 Thread Patrik Flykt
On Tue, 2015-06-23 at 13:35 +0300, Tomasz Bursztyka wrote: Hi Patrik, stop_autoscan(device); if (wifi-p2p_find_timeout) { @@ -2066,7 +2062,6 @@ static int network_connect(struct connman_network *network) ssid_init(ssid, network); if (wifi-disconnecting) {

Re: How to tell to connMan to use only one interface

2015-06-22 Thread Patrik Flykt
On Thu, 2015-06-18 at 18:13 +0530, Sukanya Ch wrote: I have two wlan interfaces. But I want to make use of only one interface. How can I tell that to connman to use only one interface. See the output of 'connmand --help' or check main.conf. Use the '-I' option on the command line or use

[PATCH] wifi: Set network disconnected in disconnect_callback()

2015-06-22 Thread Patrik Flykt
The network needs to be set disconnected in the callback as the pointer will be unconditionally cleared in the function. Even with a result of zero the interface_state() cannot be relied on; it might not be called by gsupplicant/wpa_supplicant in all cases. Reported by Thomas Green. ---

Re: Wireless not connecting

2015-06-22 Thread Patrik Flykt
On Thu, 2015-06-18 at 17:33 +, Thomas Green wrote: Please find attached a partial log file when I'm trying to go from one wireless AP to another. I disconnect from the current wireless AP, then issue a connect to the new one. The disconnect happens correctly, but when I try to connect to

Re: [PATCH] gsupplicant: Fix potential crash in case memory allocaiton failed

2015-06-22 Thread Patrik Flykt
Hi, On Thu, 2015-06-18 at 19:16 +0530, Maneesh Jain wrote: The patch is used to check if memory is allocated or not properly in following functions. In case memory is not allocated, return it from the function to avoid any potential crash. a. signal_peer_found b.

Re: [PATCH] dhcpv6: Fixed Possible Memory Leak

2015-06-22 Thread Patrik Flykt
On Thu, 2015-06-18 at 10:43 +0530, Saurav Babu wrote: This patch frees memory allocated to duid by g_dhcpv6_create_duid() when convert_to_hex() returns NULL. g_dhcpv6_create_duid() allocates memory to duid variable when it returns 0 and duid_type is G_DHCPV6_DUID_LLT. Applied, thanks!

Re: [PATCH] gsupplicant: Fix possible memory leak in g_supplicant_set_country()

2015-06-22 Thread Patrik Flykt
On Thu, 2015-06-18 at 18:47 +0530, Maneesh Jain wrote: In case supplicant_dbus_property_set() function returns error, 'regdom' memory is not freed. Applied, thanks! Patrik ___ connman mailing list connman@connman.net

Re: wired network connect

2015-06-22 Thread Patrik Flykt
On Fri, 2015-06-19 at 19:09 +, Thomas Green wrote: All, To me it is interesting to note that when I have my network cable plugged in and have a dhcp connection, that if it for some reason becomes disconnected (ie, someone kicks the cord) and I re-plug the network cable, as I trace the

Re: Disable Firewall support in connman

2015-06-18 Thread Patrik Flykt
Hi, On Thu, 2015-06-18 at 17:12 +0530, Vidhya Govindan wrote: static int insert_managed_chain(const char *table_name, int id) { char *rule, *managed_chain; int err; managed_chain = g_strdup_printf(%s%s, CHAIN_PREFIX,

Re: proxy configuration

2015-06-18 Thread Patrik Flykt
On Fri, 2015-06-12 at 16:36 +0200, ronney.kai...@europe.svpworldwide.com wrote: One last (I hope...:o) questionthe format of the server URI provided when using the manual method is (according to the documentation) server.example.com:911, but what about the format of the URL when used

Re: [PATCH] supplican:Fix Possible Memory Leak

2015-06-18 Thread Patrik Flykt
On Thu, 2015-06-18 at 10:02 +0530, Maneesh Jain wrote: In case supplicant_dbus_property_set() function return fail, regdom memeory block does not free. Signed-off-by: Maneesh Jain maneesh.j...@samsung.com Applied. We don't do signed-off-bys in this project so you can leave that one off the

Re: [PATCH] connman.service: Remove extra dependency on dbus.socket

2015-06-18 Thread Patrik Flykt
On Fri, 2015-06-12 at 15:58 +0300, Patrik Flykt wrote: Systemd services with Type=dbus automatically have a dependency on dbus.socket. This fix was noticed in Debian's ConnMan package. Applied. Patrik ___ connman mailing list connman

Re: [PATCH] gsupplicant: Remove unused net_mapping hash table

2015-06-18 Thread Patrik Flykt
On Wed, 2015-06-17 at 14:22 +0530, Harish Jenny K N wrote: Removed all occurrences of net_mapping hash table as there were no entries getting added. Applied, thanks! Patrik ___ connman mailing list connman@connman.net

Re: [PATCH] supplicant: Fix Possible Memory Leak

2015-06-18 Thread Patrik Flykt
On Thu, 2015-06-18 at 10:03 +0530, Maneesh Jain wrote: In case supplicant_dbus_property_set() function return fail, regdom memeory block does not free. After applying your previous patch, this no longer applies. Please rebase and resend. Patrik

Re: [PATCHv3 1/2] client: Add support of MoveBefore Service API

2015-06-18 Thread Patrik Flykt
On Mon, 2015-06-15 at 16:03 +0530, Saurav Babu wrote: This patch handles MoveBefore() method from Service API in connman client. This can be used to move any VPN service before any other VPN Service. For Connman services this won't be much useful as the order is not remembered after service

Re: Issues in connecting wireless network

2015-06-18 Thread Patrik Flykt
Hi, On Thu, 2015-06-18 at 09:47 +0530, Sriram Sagar wrote: I am wondering that, I did not find any kind of .config file inside the /var/lib/connman/* Of course there are no .config files, if you did not create any yourself. |-- ethernet_e0db55c7f732_cable | |-- data | `--

[RFC v2] wifi: Try to enable tethering for an unused device

2015-06-18 Thread Patrik Flykt
When enabling tethering, try to first find a device without a network connection that supports AP mode. If none is found, try again but this time ignoring the network connection. Factor out tethering enabling adding a boolea parameter that tells whether to consider a connected network or not.

Re: Connman without iptables

2015-06-18 Thread Patrik Flykt
On Thu, 2015-06-18 at 13:48 +0530, Sukanya Ch wrote: With these changes I am not able to run connman daemon..Here I am providing the logs. connmand[4691]: src/ipconfig.c:__connman_ipconfig_init() connmand[4691]: src/rtnl.c:__connman_rtnl_init() connmand[4691]:

Re: Disable Firewall support in connman

2015-06-18 Thread Patrik Flykt
On Thu, 2015-06-18 at 15:24 +0530, Vidhya Govindan wrote: Hi, Could you please let us know how we can disable firewall support in connman. There are no iptables features in use in ConnMan unless you use Session support which I'm fairly sure you're not using. There are some problems I am

Re: Support to get detected interfaces via connmanctl command ??

2015-06-17 Thread Patrik Flykt
On Wed, 2015-06-17 at 06:05 +, Lamsoge, Abhijit wrote: Hi Patrick, What I meant was that - If there are different interfaces like eth0, eth1, wlan0, wlan1 etc. So how can an external application know via connman, that these interfaces exists. It can't and it's not supposed to. I don't

Re: Issues in connecting wireless network

2015-06-17 Thread Patrik Flykt
Hi, On Wed, 2015-06-17 at 14:51 +0530, Sriram Sagar wrote: I am able to solve the problem by properly following README file instructions. I am using connman1.29. But I got a new problem now. I am having 3 routers dlink, linksys, netgear (dlink,linksys are open and netgear is

[RFC] wifi: Try to enable tethering for an unused device

2015-06-17 Thread Patrik Flykt
When enabling tethering, try to first find a device without a network connection that supports AP mode. If none is found, try again but this time ignoring the network connection. Factor out tethering enabling adding a boolea parameter that tells whether to consider a connected network or not.

Re: Support to get detected interfaces via connmanctl command ??

2015-06-16 Thread Patrik Flykt
On Tue, 2015-06-16 at 13:01 +, Lamsoge, Abhijit wrote: Hi Patrick, Is there any command to know what interfaces(eth0, wlan0, etc) are present in connmand via connmanctl ? See the 'Ethernet' property dictionary for (all) connected services with the 'services _' command. The output

Re: Issues in connecting wireless network

2015-06-16 Thread Patrik Flykt
On Tue, 2015-06-16 at 14:48 +0530, Sriram Sagar wrote: I am trying to connect to open AP using connman. What version of ConnMan? Cheers, Patrik ___ connman mailing list connman@connman.net https://lists.connman.net/mailman/listinfo/connman

Re: [PATCHv2 1/2] client: Add support of MoveBefore Service API

2015-06-15 Thread Patrik Flykt
On Mon, 2015-06-15 at 09:45 +0530, Saurav Babu wrote: EP-584CD5AB95AE4A3A879836122994DB42 Hi, Compilation still fails... Can you let me know what error are you getting while compilation. As I've not got any compilation error on my setup. Please see my replies to the previous two mails.

Re: proxy configuration

2015-06-12 Thread Patrik Flykt
On Thu, 2015-06-11 at 17:01 +0200, ronney.kai...@europe.svpworldwide.com wrote: Hi! I'm trying to find out which methods are available when setting the proxy configuration in connman. I've not been able to find any documentation similar to that describing how to set the ip configuration

[PATCH] connman.service: Remove extra dependency on dbus.socket

2015-06-12 Thread Patrik Flykt
Systemd services with Type=dbus automatically have a dependency on dbus.socket. This fix was noticed in Debian's ConnMan package. --- src/connman.service.in | 2 -- vpn/connman-vpn.service.in | 2 -- 2 files changed, 4 deletions(-) diff --git a/src/connman.service.in b/src/connman.service.in

Re: [PATCHv2 1/2] client: Add support of MoveBefore Service API

2015-06-12 Thread Patrik Flykt
Hi, Compilation still fails... Patrik On Thu, 2015-06-11 at 15:20 +0530, Saurav Babu wrote: This patch handles MoveBefore() method from Service API in connman client. This can be used to move any VPN service before any other VPN Service. For Connman services this won't be

Re: [PATCH] tools: Handle SIGFPE in stats-tool

2015-06-12 Thread Patrik Flykt
On Thu, 2015-06-11 at 16:02 +0530, Harish Jenny K N wrote: Handled SIGFPE when --interval=0 is passed to stats-tool Use default value of 3 second in that case Applied, thanks! Patrik ___ connman mailing list connman@connman.net

Re: proxy configuration

2015-06-12 Thread Patrik Flykt
On Fri, 2015-06-12 at 14:30 +0200, ronney.kai...@europe.svpworldwide.com wrote: If i use proxy method auto, I will provide connman with the following attributes: {'Method' : 'auto', 'URL' : 'some url'} If the URL is omitted, DHCP/WPAD will be attempted. If I use the manual method, I

Re: [PATCHv2 2/2] client: Add support of MoveAfter Service API

2015-06-11 Thread Patrik Flykt
On Thu, 2015-06-11 at 10:35 +0530, Saurav Babu wrote: EP-584CD5AB95AE4A3A879836122994DB42 See previous patch. This patch handles MoveAfter() method from Service API in connman client. This can be used to move any VPN service after any other VPN Service. For Connman services this won't be

Re: [PATCH] tools: Handle SIGFPE in stats-tool

2015-06-11 Thread Patrik Flykt
On Thu, 2015-06-11 at 12:33 +0530, Harish Jenny K N wrote: Handled SIGFPE when --interval=0 is passed to stats-tool --- tools/stats-tool.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/stats-tool.c b/tools/stats-tool.c index 7d117fd..94733a4 100644 ---

Re: Does ConnMan suport to cotrol two wifi devices?

2015-06-11 Thread Patrik Flykt
On Wed, 2015-06-10 at 11:38 +, Lamsoge, Abhijit wrote: I am not sure, but I think, its like wlan0 may go to be STA and wlan1 will go to be AP, depending on what order you do it. I did not see any provision in connman to do so. Not quite. ConnMan will try to enable WiFi AP on the first WiFi

Re: [PATCHv2 1/2] client: Add support of MoveBefore Service API

2015-06-11 Thread Patrik Flykt
On Thu, 2015-06-11 at 10:35 +0530, Saurav Babu wrote: EP-584CD5AB95AE4A3A879836122994DB42 Please remove this ID. This patch handles MoveBefore() method from Service API in connman client. This can be used to move any VPN service before any other VPN Service. For Connman services this won't

Re: Issues with connmand

2015-06-11 Thread Patrik Flykt
On Thu, 2015-06-11 at 11:39 +, Lamsoge, Abhijit wrote: Error getting technologies: The name net.connman was not provided by any .service filesconnmanctl services Error: The name net.connman was not provided by any .service files This issue happens if your connmand is not running Indeed.

Re: Connmand problem 3g modem connection problem

2015-06-11 Thread Patrik Flykt
On Wed, 2015-06-10 at 17:44 +0530, Sriram Sagar wrote: Thank you for response. I am able to solve the issue and and my 3G dongle is detected. But i am not able to connect to the interface.Could you please help me. Vodafone IN cellular_404844222578779_context1 connmanctl

Re: Issues with connmand

2015-06-11 Thread Patrik Flykt
On Wed, 2015-06-10 at 19:49 +0530, Sukanya Ch wrote: I am facing issues with connmand. I am not able to run daemon. can any one help me please. I am using 1.29 version in ARM platform. I enabled xtables netfilter and all kernel configurations which are given in README file in source code.But

Re: Not able to start connmand

2015-06-10 Thread Patrik Flykt
On Wed, 2015-06-10 at 12:42 +0530, Sukanya Ch wrote: Hi, Looks like you miss the support for the xtables in kernel's netfilter. I added support for xtables, but still i am getting same error.. Not having xtables support only prevents proper tethering. Is D-Bus working? Cheers,

Re: Connmand problem 3g modem connection problem

2015-06-10 Thread Patrik Flykt
Hi, On Wed, 2015-06-10 at 10:56 +0530, Sriram Sagar wrote: Hi, I am having getting one print when i run connmand daemon. *connmand -nd* Failed to create storage directory: No such file or directory connmand[18086]: Connection Manager version 1.29 connmand[18086]:

Re: Not able to start dbus in ARM platform

2015-06-08 Thread Patrik Flykt
On Mon, 2015-06-08 at 17:38 +0530, Sukanya Ch wrote: Hi, I am using connman in ARM platform. But while starting daemon I am getting this error. Can you please help me? There are no errors below. ConnMan is just a little bit too eager with its DNS when starting up. Nothing to worry about at

Re: [PATCH 2/2] client: Add MoveAfter Service API

2015-06-08 Thread Patrik Flykt
On Wed, 2015-06-03 at 14:19 +0530, Saurav Babu wrote: EP-584CD5AB95AE4A3A879836122994DB42 As in the previous patch. --- client/commands.c | 59 +++ 1 file changed, 59 insertions(+) diff --git a/client/commands.c b/client/commands.c

Re: [PATCH 0/2] client: Add Service API MoveBefore/MoveAfter

2015-06-08 Thread Patrik Flykt
On Wed, 2015-06-03 at 14:19 +0530, Saurav Babu wrote: EP-584CD5AB95AE4A3A879836122994DB42 Saurav Babu (2): client: Add MoveBefore Service API client: Add MoveAfter Service API Even though ConnMan supports any services to be moved before/after arbitrary services, the order is not

Re: [PATCH] gsupplicant: Debug check for callbacks_pointer

2015-06-08 Thread Patrik Flykt
On Mon, 2015-06-08 at 11:44 +0530, Harish Jenny K N wrote: Improve GSupplicant debug by checking for callbacks_pointer pointer being NULL. Signed-off-by: Harish Jenny K N harish_kand...@mentor.com We don't do signed off by in this project so I removed the above line. Applied, thanks!

Re: Not able to start dbus in ARM platform

2015-06-08 Thread Patrik Flykt
On Mon, 2015-06-08 at 18:42 +0530, Sukanya Ch wrote: connmanctl scan wifi Error /net/connman/technology/wifi: Method Scan with signature on interface net.connman.Technology doesn't exist WiFi technology is not enabled, D-Bus communication with wpa_supplicant is prohibited or wpa_supplicant

Re: [PATCH 0/2] client: Add Service API MoveBefore/MoveAfter

2015-06-08 Thread Patrik Flykt
On Mon, 2015-06-08 at 18:52 +0530, Saurav Babu wrote: I added these patches because I found connman client didn?t have support for these Service APIs. I think if the order is not remembered then it would require a different patch in Connman. Do you think that support of MoveBefore/MoveAfter is

Re: [PATCH 1/2] client: Add MoveBefore Service API

2015-06-08 Thread Patrik Flykt
Hi, On Wed, 2015-06-03 at 14:19 +0530, Saurav Babu wrote: EP-584CD5AB95AE4A3A879836122994DB42 Please add a descriptive commit message. --- client/commands.c | 64 +++ 1 file changed, 64 insertions(+) diff --git

Re: Not able to start dbus in ARM platform

2015-06-08 Thread Patrik Flykt
On Mon, 2015-06-08 at 18:49 +0530, Sukanya Ch wrote: Can you please look into wpa_supplicant logs. Is this won't effect connmactl dbus: Unregister D-Bus object '/fi/w1/wpa_supplicant1'?. If it effect, then how can I solve this. Can you please provide information regarding this? I have no idea

Re: [PATCH] client: Add ClearProperty Service API

2015-06-08 Thread Patrik Flykt
On Wed, 2015-06-03 at 17:38 +0530, Saurav Babu wrote: EP-584CD5AB95AE4A3A879836122994DB42 This id isn't very descriptive for this project. --- client/commands.c | 9 + 1 file changed, 9 insertions(+) diff --git a/client/commands.c b/client/commands.c index 2397883..ca8ceaa

Re: Input/output error

2015-06-01 Thread Patrik Flykt
On Mon, 2015-06-01 at 17:23 +0530, Sukanya Ch wrote: Whenever I was trying to connect to secure wifi at that time it some times it was conneg and sometimes i come across with this error What version of ConnMan are you using? Cheers, Patrik

Re: Background scan for wifi

2015-06-01 Thread Patrik Flykt
On Mon, 2015-06-01 at 18:17 +0530, Sukanya Ch wrote: I want to start background scan for wifi through connmanctl continuously for every sec.Is it is possible through this?. No. And you really can not issue a new scan every second as the scan takes 3-4 seconds to complete. It will also drain any

Re: [PATCH 2/2] config: Correctly handle provisioning for unsecured wifi networks

2015-06-01 Thread Patrik Flykt
On Thu, 2015-05-28 at 21:35 +0200, Peter Meerwald wrote: From: Peter Meerwald p.meerw...@bct-electronic.com when neither EAP nor a passphrase is configured, the security should default to 'none', not 'unknown' otherwise, unsecured wifi networks can not be provisioned Applied, thanks!

Re: [PATCH] peer: stop dhcp client when switching to CONNMAN_PEER_STATE_DISCONNECT state

2015-06-01 Thread Patrik Flykt
On Fri, 2015-05-29 at 14:06 +0200, Michael Olbrich wrote: Otherwise __connman_dhcp_stop() is never called when the disconnect is triggered by the peer. peer_disconnect() already handles this correctly for locally triggered disconnects. Applied, thanks! Patrik

Re: [PATCH] gsupplicant: fix finding matching group

2015-06-01 Thread Patrik Flykt
On Fri, 2015-05-29 at 14:06 +0200, Michael Olbrich wrote: g_slist_find_custom() expects a function that return 0 when the arguments are equal. g_str_equal() returns TRUE, so any not matching group is found. Applied, thanks! Patrik ___

Re: [PATCH] wifi: fix device type category/sub_category endianess

2015-06-01 Thread Patrik Flykt
On Fri, 2015-05-29 at 16:51 +0200, Michael Olbrich wrote: category and sub_category must be big-endian in the device-type string. Applied, thanks! Patrik ___ connman mailing list connman@connman.net

Re: Connecting to unauthenticated wifi with configuration file in /var/lib/connman

2015-06-01 Thread Patrik Flykt
On Mon, 2015-06-01 at 07:45 +0200, Peter Meerwald wrote: Thanks a lot for the patch. Will give it a shot today. A little off-topic - Is there a way I can track the progress of this patch making its way into master? not sure; hopefully Patrik comments on it soon on the mail list If

Re: [PATCH] ipconfig: Update device address when modified

2015-05-22 Thread Patrik Flykt
Hi, On Fri, 2015-05-22 at 09:58 +0530, Saurav Babu wrote: EP-584CD5AB95AE4A3A879836122994DB42 So, in which cases does this issue manifest itself? From the code we can read what it does, but what is causing an IP address to change to something else? What's the use case and

Re: [PATCH] ipconfig: Update device address when modified

2015-05-21 Thread Patrik Flykt
Hi, On Thu, 2015-05-21 at 11:42 +0530, Saurav Babu wrote: EP-584CD5AB95AE4A3A879836122994DB42 So, in which cases does this issue manifest itself? From the code we can read what it does, but what is causing an IP address to change to something else? What's the use case and

Re: service state transition to ready

2015-05-20 Thread Patrik Flykt
Hi, On Tue, 2015-05-19 at 12:58 -0700, Naveen Singh wrote: Thanks for the response. Is there a way currently for it to change the condition from OR to AND. No. Cheers, Patrik ___ connman mailing list connman@connman.net

Re: connman support for 802.11x based WLAN connections

2015-05-20 Thread Patrik Flykt
On Tue, 2015-05-19 at 18:06 +0530, Vidhya Govindan wrote: I understand connman supports known connections and establishes connection to the known networks automatically. Please correct me if I am wrong. We are thinking if it is possible to save our custom WLAN profiles as part of known

Re: [PATCH] ipconfig: Update device address when modified

2015-05-20 Thread Patrik Flykt
Hi, On Wed, 2015-05-20 at 12:50 +0530, Saurav Babu wrote: EP-584CD5AB95AE4A3A879836122994DB42 So, in which cases does this issue manifest itself? From the code we can read what it does, but what is causing an IP address to change to something else? What's the use case and environment

Re: [PATCH] service: Indicate which IP configuration type to add or remove

2015-05-19 Thread Patrik Flykt
On Tue, 2015-05-12 at 10:47 +0300, Patrik Flykt wrote: In order not to remove all nameservers when one IP configuration type is removed, indicate which IP version the remove is intended for. For consistency, indicate IP configuration type also when adding nameservers. Applied. Patrik

Re: [PATCH] service: Sync timeservers when ipconfig state has changed

2015-05-19 Thread Patrik Flykt
On Thu, 2015-04-30 at 13:48 +0300, Patrik Flykt wrote: Do timeserver synchronization when either of the service IP configurations have changed. As the timeservers may be expressed by host name, it is a good idea to redo the IP name resolution at this point. Reported by Olivier Pinel

Re: [PATCH] service: Check ipconfig method before attempting changes

2015-05-19 Thread Patrik Flykt
On Tue, 2015-05-12 at 10:48 +0300, Patrik Flykt wrote: If the ipconfig method is off, ensure that the resulting state will also be idle so that wrong actions are not taken. Print out a warning if the IP configuration state and method do not match. Applied. Patrik

[PATCH] build: Suppress output when creating directories

2015-05-19 Thread Patrik Flykt
When the directories are created, suppress printouts by default. --- Makefile.am | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Makefile.am b/Makefile.am index bc3c695..886cace 100644 --- a/Makefile.am +++ b/Makefile.am @@ -410,11 +410,11 @@ MAINTAINERCLEANFILES =

Re: [PATCH] build: create directories before putting files in them

2015-05-19 Thread Patrik Flykt
On Tue, 2015-05-12 at 18:07 +0300, Patrik Flykt wrote: On Fri, 2015-05-01 at 15:16 +0100, Ross Burton wrote: scripts/connman: scripts/connman.in Makefile + $(AM_V_at)$(MKDIR_P) scripts Should this be $(AM_V_AT)$(MKDIR_P) $(dir $@) as the rest of the lines above? Replying to myself

Re: connman support for 802.11x based WLAN connections

2015-05-19 Thread Patrik Flykt
Hi, On Tue, 2015-05-19 at 16:17 +0530, Vidhya Govindan wrote: Hello group members, We are working on a project to support Hotspot 2.0 WLAN client and 3G connection. We are planning to use connman for our project and want to know if connman can support WLAN connections based on

Re: [PATCH] build: create directories before putting files in them

2015-05-19 Thread Patrik Flykt
On Fri, 2015-05-01 at 15:16 +0100, Ross Burton wrote: When automake's dependency tracking is enabled a mirror of the source tree is created in the build directory as it writes the dependency information. However, if dependency tracking is disabled on an out-of-tree build this mirror isn't

Re: [PATCH] build: Suppress output when creating directories

2015-05-19 Thread Patrik Flykt
On Tue, 2015-05-19 at 10:36 +0300, Patrik Flykt wrote: When the directories are created, suppress printouts by default. Applied. Patrik ___ connman mailing list connman@connman.net https://lists.connman.net/mailman/listinfo/connman

Re: Disable rp_filter in main.conf

2015-05-13 Thread Patrik Flykt
On Tue, 2015-05-12 at 09:34 +, Urs Ritzmann wrote: We're running connman on a system using PTP (IEEE1588). The problem is that connman is fiddling with the rp_filter settings and activating loose mode routing (value 2) if two or more services are present. We cannot have ip_filter activated

Re: [PATCH] ofono: Fix crash in modem_update_interfaces

2015-05-13 Thread Patrik Flykt
On Wed, 2015-04-29 at 15:33 +0300, Slava Monich wrote: modem_update_interfaces could crash if org.ofono.ConnectionManager interface is removed right after it has been added, before GetContext call completes (or if it fails): Applied, thanks! Patrik

Re: [PATCH] ofono: Unref pending dbus calls after cancelling them

2015-05-13 Thread Patrik Flykt
On Wed, 2015-04-29 at 15:44 +0300, Slava Monich wrote: dbus_pending_call_cancel() drops the dbus library's internal reference to DBusPendingCall but we also need to release the reference we got from dbus_connection_send_with_reply() Applied, thanks! Patrik

Re: [PATCH v4] wifi: disconnect if wpa_s state changes from completed to scanning

2015-05-13 Thread Patrik Flykt
On Tue, 2015-05-12 at 15:28 +0300, pasi.sjoh...@jolla.com wrote: From: Pasi Sjöholm pasi.sjoh...@jollamobile.com It's possible from wpa_s to change the state from completed to scanning without going through disconnected state if interface signals that the carrier went off and on

[PATCH] service: Check ipconfig method before attempting changes

2015-05-12 Thread Patrik Flykt
If the ipconfig method is off, ensure that the resulting state will also be idle so that wrong actions are not taken. Print out a warning if the IP configuration state and method do not match. --- src/service.c | 39 --- 1 file changed, 20 insertions(+), 19

Re: [PATCH] timeserver: resync on default service ipconfig change

2015-05-12 Thread Patrik Flykt
Hi, On Tue, 2015-05-12 at 06:56 +, Adam Moore wrote: I also tested against 1.28. The submitted patch was a diff from master though. -Adam On 5/11/15, 8:24 AM, Aron Rosenberg a...@aether.com wrote: On Mon, May 11, 2015 at 12:44 AM, Patrik Flykt patrik.fl...@linux.intel.com

Re: [PATCH] build: create directories before putting files in them

2015-05-12 Thread Patrik Flykt
On Fri, 2015-05-01 at 15:16 +0100, Ross Burton wrote: scripts/connman: scripts/connman.in Makefile + $(AM_V_at)$(MKDIR_P) scripts Should this be $(AM_V_AT)$(MKDIR_P) $(dir $@) as the rest of the lines above? Cheers, Patrik ___

Re: [PATCH] timeserver: resync on default service ipconfig change

2015-05-11 Thread Patrik Flykt
On Thu, 2015-04-30 at 18:53 -0700, Adam Moore wrote: Upon an ipconfig change of the default service, resync with timeservers. --- src/timeserver.c | 16 1 file changed, 16 insertions(+) diff --git a/src/timeserver.c b/src/timeserver.c index f0d33e5..f76320c 100644 ---

Re: Disable a new interface when detected.

2015-05-05 Thread Patrik Flykt
On Mon, 2015-05-04 at 17:41 +0200, Joaquim Duran wrote: I saw that I could disable autoconnect from services, but the interface was not disabled (consumes energy). The wifi interface could be disabled: connmanctl disable wifi connmanctl enable wifi Indeed! With this you don't need to tweak

Re: Disable a new interface when detected.

2015-05-04 Thread Patrik Flykt
On Mon, 2015-05-04 at 14:34 +0200, Joaquim Duran wrote: Dear all, I'm developing an embedded device managed by a custom application. The device only have a network interface: the wifi. The wifi interface is only activated by the application when it needs to transfer data with a server. As

Re: Time not set at connman startup

2015-04-30 Thread Patrik Flykt
Hi, On Wed, 2015-04-29 at 12:57 -0700, Adam Moore wrote: On Mon, Apr 27, 2015 at 8:26 AM, Olivier Pinel (opinel) opi...@cisco.com wrote: Hello, I am facing a random issue with NTP time setup when conman starts. I am using conman 1.27 (will try to reproduce with 1.29 tomorrow)

[PATCH] service: Sync timeservers when ipconfig state has changed

2015-04-30 Thread Patrik Flykt
Do timeserver synchronization when either of the service IP configurations have changed. As the timeservers may be expressed by host name, it is a good idea to redo the IP name resolution at this point. Reported by Olivier Pinel and Adam Moore --- src/service.c | 2 ++ 1 file changed, 2

Re: [PATCH v2] iptables: Keep the current counter values on changes

2015-04-30 Thread Patrik Flykt
On Tue, 2015-04-28 at 15:51 +0200, Thiemo van Engelen wrote: When new iptables are commited, the counters in the kernel are reset and the values of the old tables are returned. By keeping track of the original index of an iptable entry, the new table can be updated with the original counter

Re: [PATCH 0/2] wifi tethering fail handling

2015-04-30 Thread Patrik Flykt
On Tue, 2015-04-21 at 23:12 +0800, bing@intel.com wrote: From: Niu,Bing bing@intel.com Issue: Right now, connman doesn't have a mechanism to handle wifi tethering fail. Applied both patches, thanks! I reordered two lines in one of the patches so that variable declarations come all

Re: [PATCH] wifi: disconnect if 4way-handshake fails while roaming.

2015-04-28 Thread Patrik Flykt
On Tue, 2015-04-28 at 09:09 +0300, pasi.sjoh...@jolla.com wrote: From: Pasi Sjöholm pasi.sjoh...@jollamobile.com While wifi-state is G_SUPPLICANT_STATE_COMPLETED and gets changed into G_SUPPLICANT_STATE_4WAY_HANDSHAKE the connection is most probably roaming. However if for some reason the

Re: [PATCH] gsupplicant: add a callback after WPS start gets called

2015-04-28 Thread Patrik Flykt
On Mon, 2015-04-27 at 11:30 +, Nakamura, Yusuke (ADITJ/SWG) wrote: When WPS is used to connect a network, connect_callback should get called. Before this change connect_callback was called only after non-WPS connection. If WPS is used repeatedly, refcount continues increasing because this

Re: [PATCH] iptables: Keep the current counter values on changes

2015-04-28 Thread Patrik Flykt
Hi, On Tue, 2015-04-21 at 11:30 +0200, Thiemo van Engelen wrote: When new iptables are commited, the counters in the kernel are reset and the values of the old tables are returned. By keeping track of the original index of an iptable entry, the new table can be updated with the

Re: missing patch...

2015-04-28 Thread Patrik Flykt
On Fri, 2015-04-24 at 23:47 +, Thomas Green wrote: There was a patch in service.c __connman_service_set_passphrase that would let a provisioned service that was 8021x let the agent prompt for the username and passphrase. Now, in revision 1.28 there is a check in

Re: How to Enable VPN support in Connman ?

2015-04-28 Thread Patrik Flykt
Hi, On Fri, 2015-04-24 at 07:21 +, Lamsoge, Abhijit wrote: Hi All, I am fairly new to connman. I wanted to know the below two things. 1) How to I enable vpn support in connman from ./configure script ? - Because after compiling I do not see any vpn related binaries or objects

Re: [PATCH] inet: Remove unnecessary break statement

2015-04-28 Thread Patrik Flykt
On Mon, 2015-04-27 at 16:21 +0530, Saurav Babu wrote: --- src/inet.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) Applied, thanks! Patrik ___ connman mailing list connman@connman.net

<    1   2   3   4   5   6   7   8   9   10   >