Changeset: 833f4630f3a1
Author:weijun
Date: 2012-09-07 10:24 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/833f4630f3a1
7196677: diff compares same file to itself in PaddingTest regression test.
Reviewed-by: xuelei
! test/com/sun/crypto/provider/Cipher/DES/PaddingTest.java
Hi Mark,
Thanks for the review and feedback.
Please see my comments inline below.
thanks,
-michael
On 12年09月06日 01:29 下午, mark.reinh...@oracle.com wrote:
2012/9/5 14:08 -0700, michael.f...@oracle.com:
Please help to review the new JDK8 file for the following CR:
7196354 check-in jdk.tbom fi
2012/9/5 14:08 -0700, michael.f...@oracle.com:
> Please help to review the new JDK8 file for the following CR:
> 7196354 check-in jdk.tbom file to openjdk repo
>
> The webrev is located at:
> http://cr.openjdk.java.net/~mfang/7196354/webrev.00/
This file needs a more descriptive name, especially
Typically, the macros COMPILE.c, COMPILE.CC, and COMPILE.m will include
$(CPPFLAGS)
which is the preprocessing flags for any compilations using a preprocessor.
I was trying to make the minimum changes needed to get this additional -D
option on all the
compile lines. I am pretty sure this works,
My strong suspicion is that the JDK Makefiles only use CFLAGS, not CPPFLAGS for
.m files. CPPFLAGS should be used for .mm files (but those should be really
rare).
Regards,
Mike Swingler
Apple Inc.
On Sep 6, 2012, at 11:35 AM, Scott Kovatch wrote:
> I feel like I should be able to find the ans
Hello,
Please help to review the new JDK8 file for the following CR:
7196354 check-in jdk.tbom file to openjdk repo
The webrev is located at:
http://cr.openjdk.java.net/~mfang/7196354/webrev.00/
Build-dev:
The file will be pushed to the top level openjdk repository
http://hg.openjdk.java.net/j
I feel like I should be able to find the answer to this, but does Objective-C
use CPPFLAGS? I can't tell if these changes would apply to .m or .mm files. It
certainly appears to be the intent of the change, since a number of .m files in
the AWT were changed to use THIS_FILE.
-- Scott K.
On Sep
The recommended way to access a rowset is via the factory now.For whatever
reason the original authors chose not to provide a factory.
The connect() method has always been a method to be used internally by
JdbcRowSetRIImpl and Rave. There is no reason for a user of the API to ever
have to
As the comment noted, the connect method was made protected for Rave
requirement but it's not defined in JdbcRowSet and BaseRowSet. It's a
method specific to the RI and changing it to private is okay if they get
an JdbcRowSet instance by calling the rowset factory. Alan's question
prompts me
Hi Alan,
The connect method is used by the RI not the RowSet spec. It was made
protected for Rave.
Best
Lance
On Sep 6, 2012, at 1:21 PM, Alan Bateman wrote:
> Lance,
>
> I see you've just pushed this but one thing I didn't spot initially is that
> in the second webrev you changed the protec
Lance,
I see you've just pushed this but one thing I didn't spot initially is
that in the second webrev you changed the protected connect method to be
private. Is this a supported API and could this cause problems for JDBC
drivers that extend this?
-Alan
Changeset: 8c6895afe204
Author:lancea
Date: 2012-09-06 13:16 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8c6895afe204
7192302: Remove JDBCRowSetImpl dependency on java.beans
Reviewed-by: alanb, mchung
! src/share/classes/com/sun/rowset/JdbcRowSetImpl.java
Hi Mandy,
Thank you also for the feedback along with Alan. I will push these back shortly
and also create a CR.
Best
Lance
On Sep 6, 2012, at 11:04 AM, Mandy Chung wrote:
> Lance,
>
> On 9/6/2012 5:40 AM, Lance Andersen - Oracle wrote:
>> Here is the updated webrev
>> http://cr.openjdk.java.n
Just FYI...
these build changes do touch sources in various teams, please let me know if
you have issues with these changes.
-kto
Begin forwarded message:
> From: "Kelly O'Hair"
> Subject: Need reviewers: more predictable binaries
> Date: September 5, 2012 9:08:53 PM PDT
> To: "build-...@ope
Changeset: 076d0dafea5f
Author:mgerdin
Date: 2012-09-06 14:07 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/076d0dafea5f
7195557: NPG: Unexpected number of memory pools
Summary: Update management tests to work with a VM without a permanent
generation memory pool
Reviewed-by
Lance,
On 9/6/2012 5:40 AM, Lance Andersen - Oracle wrote:
Here is the updated webrev http://cr.openjdk.java.net/~lancea/7192302/webrev.01
It's good to see this change that jdbc rowset doesn't depend on java.beans.
This looks okay to me as you have explained why you remove the call to
connec
On 06/09/2012 14:45, Lance Andersen - Oracle wrote:
:
connect() is typically called to get a connection and it will validate
that there is a non-null Connection. I have unit tests which leverage
that constructor and run clean with that change.
I agree that commit(), rollback, etc should c
On Sep 6, 2012, at 9:31 AM, Alan Bateman wrote:
> On 06/09/2012 14:09, Lance Andersen - Oracle wrote:
>> :
>>>
>>> The latest webrev looks okay except that in one of the constructors you
>>> have removed a call to ensure that the connection is established, I'm not
>>> sure about the significan
On 06/09/2012 14:09, Lance Andersen - Oracle wrote:
:
The latest webrev looks okay except that in one of the constructors
you have removed a call to ensure that the connection is established,
I'm not sure about the significance of that.
This is not needed here and given I have already teste
Thank you for the comments Alan
On Sep 6, 2012, at 9:00 AM, Alan Bateman wrote:
> On 06/09/2012 13:40, Lance Andersen - Oracle wrote:
>> Here is the updated webrev
>> http://cr.openjdk.java.net/~lancea/7192302/webrev.01
>>
>> I know there is more clean-up that can be done to remove other Rave a
On 06/09/2012 13:40, Lance Andersen - Oracle wrote:
Here is the updated webrev http://cr.openjdk.java.net/~lancea/7192302/webrev.01
I know there is more clean-up that can be done to remove other Rave added code
(such as the removal of set/getPreparedStatement/Connection/ResultSet), I want
to k
Here is the updated webrev http://cr.openjdk.java.net/~lancea/7192302/webrev.01
I know there is more clean-up that can be done to remove other Rave added code
(such as the removal of set/getPreparedStatement/Connection/ResultSet), I want
to keep the focus to just removing PropertyChangeSupport.
22 matches
Mail list logo
