hg: jdk8/tl/jdk: 8026762: jdk8-tl builds windows builds failing in corba - javac: no source files

2013-10-17 Thread bradford . wetmore
Changeset: a45acc8de0f3 Author:wetmore Date: 2013-10-16 23:32 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a45acc8de0f3 8026762: jdk8-tl builds windows builds failing in corba - javac: no source files Reviewed-by: katleman, dholmes ! makefiles/GenerateClasses.gmk

hg: jdk8/tl/corba: 8026762: jdk8-tl builds windows builds failing in corba - javac: no source files

2013-10-17 Thread bradford . wetmore
Changeset: 1a71d800b032 Author:wetmore Date: 2013-10-16 23:31 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/1a71d800b032 8026762: jdk8-tl builds windows builds failing in corba - javac: no source files Reviewed-by: katleman, dholmes ! makefiles/BuildCorba.gmk

hg: jdk8/tl/nashorn: 3 new changesets

2013-10-17 Thread sundararajan . athijegannathan
Changeset: 1899da5c71d3 Author:hannesw Date: 2013-10-16 10:12 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/1899da5c71d3 8026692: eval() throws NullPointerException with --compile-only Reviewed-by: sundar, lagergren !

Re: RFC 6910473: BigInteger negative bit length, value range, and future prospects

2013-10-17 Thread Paul Sandoz
On Oct 16, 2013, at 7:46 PM, Dmitry Nadezhin dmitry.nadez...@gmail.com wrote: Thank you, Paul. I tried to combine your and Joe's suggestions in the updated WebRev: http://cr.openjdk.java.net/~bpb/6910473/webrev.2/ Looks good. A slight concern is that the test sets the max heap size to 8g.

Re: RFC 6910473: BigInteger negative bit length, value range, and future prospects

2013-10-17 Thread Alan Bateman
On 15/10/2013 01:27, Brian Burkhalter wrote: Ping! This proposal could use more comments, not to mention review(s). http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-September/021264.html Just to follow up on Paul's observation that the test runs with -Xmx8g. I assume this isn't

Re: Demo for Parallel Core Collection API

2013-10-17 Thread Paul Sandoz
Hi, I notice in some grouping by cases that it appears as if you want to stream downstream. Here is a simple example (not very interesting but it gets the point across): /** * A downstream collector that streams elements to a further downstream * collector. */ public

hg: jdk8/tl/langtools: 8015372: Update tests for Method Parameter Reflection API to check whether a parameter is final

2013-10-17 Thread joel . franck
Changeset: a48d3b981083 Author:mnunez Date: 2013-10-17 13:27 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a48d3b981083 8015372: Update tests for Method Parameter Reflection API to check whether a parameter is final Reviewed-by: jjg, jfranck !

Re: RFR: 8015068 : (m) Use jtreg -exclude for problemlist.txt processing

2013-10-17 Thread Alan Bateman
On 16/10/2013 21:22, Mike Duigou wrote: Hello all; With the imminent promotion of JTReg 4.1b07 it's possible to finally consider completing this changeset! http://cr.openjdk.java.net/~mduigou/JDK-8015068/2/webrev/ This updated webrev includes handling of the shared library permissions.

hg: jdk8/tl/langtools: 8008192: Better ordering checks needed in repeatingAnnotations/combo/ReflectionTest

2013-10-17 Thread joel . franck
Changeset: 4d8af6fda907 Author:mnunez Date: 2013-10-17 13:50 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4d8af6fda907 8008192: Better ordering checks needed in repeatingAnnotations/combo/ReflectionTest Reviewed-by: jjg, jfranck !

Re: RFR [8024521] (process) Async close issues with Process InputStream

2013-10-17 Thread Alan Bateman
On 15/10/2013 16:31, Ivan Gerasimov wrote: Here's the updated webrev with the solution by Paul: http://cr.openjdk.java.net/~igerasim/8024521/1/webrev/ I've also excluded the test from it. Instead, I'm going to write a manual testing instruction for SQE. I've tested the fix and it works as

Re: JDK 8 RFR 8010371: getaddrinfo can fail with EAI_SYSTEM/EAGAIN, causes UnknownHostException to be thrown

2013-10-17 Thread Alan Bateman
On 17/10/2013 00:21, Brian Burkhalter wrote: Dmitry, I think you are correct: that slipped by both me and the reviewers. I have reopened the issue and posted an amendment to the original webrev here: http://cr.openjdk.java.net/~bpb/8010371/webrev.4-amendment/ I've restored the bug fields and

hg: jdk8/tl/jdk: 8026712: TEST_BUG: update sun/security/tools/keytool/autotest.sh with a new location to find of libsoftokn3.so

2013-10-17 Thread weijun . wang
Changeset: 37e3dcb798c3 Author:weijun Date: 2013-10-17 20:56 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/37e3dcb798c3 8026712: TEST_BUG: update sun/security/tools/keytool/autotest.sh with a new location to find of libsoftokn3.so Reviewed-by: vinnie !

Re: [OpenJDK 2D-Dev] RFR(L): 8024854: Basic changes and files to build the class library on AIX

2013-10-17 Thread Volker Simonis
Hi Phil, thanks a lot for the review. Please see my comments inline: On Wed, Oct 16, 2013 at 12:48 AM, Phil Race philip.r...@oracle.com wrote: Hello Volker, I just remembered got back to these changes - my email inbox isn't a very good reminder system. I am OK with everything I see in the

hg: jdk8/tl/jdk: 8022718: Runtime accessibility checking: protected class, if extended, should be accessible from another package

2013-10-17 Thread eric . mccorkle
Changeset: 0a6730b5e192 Author:drchase Date: 2013-10-16 17:55 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0a6730b5e192 8022718: Runtime accessibility checking: protected class, if extended, should be accessible from another package Summary: Modify accessibility check; it

Re: RFR: 8024688: j.u.Map.merge doesn't work as specified if contains key:null pair

2013-10-17 Thread Paul Sandoz
On Oct 17, 2013, at 1:52 AM, Mike Duigou mike.dui...@oracle.com wrote: On Oct 16 2013, at 05:34 , Paul Sandoz paul.san...@oracle.com wrote: On Oct 16, 2013, at 1:52 PM, David Holmes david.hol...@oracle.com wrote: Perhaps HashMap's implementations should throw CME? Perhaps, seems to

hg: jdk8/tl/jdk: 8026516: javadoc errors in java.time

2013-10-17 Thread roger . riggs
Changeset: 36fe6a9bd43e Author:rriggs Date: 2013-10-17 10:37 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/36fe6a9bd43e 8026516: javadoc errors in java.time Summary: Corrected links to TemporalQuery and TemporalField.resolve Reviewed-by: mduigou, darcy, lancea !

Re: RFC 6910473: BigInteger negative bit length, value range, and future prospects

2013-10-17 Thread Dmitry Nadezhin
Another solution may be to exclude the SymmetricRangeTests from automatic test runs, and to keep this file somewhere for manual tests runs only. What do you think about this ? Can this be implemented in jtreg (for example by @key hugeMemory tag) ? On Thu, Oct 17, 2013 at 2:18 PM, Alan Bateman

Re: JDK 8 RFR 8010371: getaddrinfo can fail with EAI_SYSTEM/EAGAIN, causes UnknownHostException to be thrown

2013-10-17 Thread Brian Burkhalter
Sorry about that. Obviously I still need to learn some things about the process, e.g., review the prescribed workflow. Thanks, Brian On Oct 16, 2013, at 7:48 PM, David Holmes wrote: Brian, On 17/10/2013 9:21 AM, Brian Burkhalter wrote: Dmitry, I think you are correct: that slipped by

Re: JDK 8 RFR 8010371: getaddrinfo can fail with EAI_SYSTEM/EAGAIN, causes UnknownHostException to be thrown

2013-10-17 Thread Brian Burkhalter
On Oct 17, 2013, at 5:37 AM, Alan Bateman wrote: On 17/10/2013 00:21, Brian Burkhalter wrote: Dmitry, I think you are correct: that slipped by both me and the reviewers. I have reopened the issue and posted an amendment to the original webrev here:

hg: jdk8/tl/jdk: 3 new changesets

2013-10-17 Thread sean . mullan
Changeset: 5d866df64ae3 Author:mullan Date: 2013-10-17 10:18 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5d866df64ae3 8026346: test/java/lang/SecurityManager/CheckPackageAccess.java failing Reviewed-by: vinnie ! src/share/lib/security/java.security-macosx !

RFR: 8016344 - (props) Properties.storeToXML behaviour has changed from JDK 6 to 7

2013-10-17 Thread Daniel Fuchs
Hi, Please find below a fix for: 8016344: (props) Properties.storeToXML behaviour has changed from JDK 6 to 7 The code for storing properties to XML has changed significantly between 7 8 - but the bug is still present in 8... This is the fix for JDK 8. By default

JDK 8 RFR 8026806: Incomplete test of getaddrinfo() return value could lead to incorrect exception for Windows Inet 6

2013-10-17 Thread Brian Burkhalter
Continuing the discussion from http://mail.openjdk.java.net/pipermail/net-dev/2013-October/007574.html under new issue ID: Issue: https://bugs.openjdk.java.net/browse/JDK-8026806 Webrev: http://cr.openjdk.java.net/~bpb/8026806/webrev/ Thanks, Brian On Oct 17, 2013, at 8:06 AM, Brian

Re: RFR: 8004138: ForkJoinTask leaks exceptions

2013-10-17 Thread Mike Duigou
Hello all; (Chris is on holiday so I agreed to finish the review on this change) I have updated the changeset with the regression test Doug provided. I have also verified that the regression test fails without the provided patch. http://cr.openjdk.java.net/~mduigou/JDK-8004138/0/webrev/ Mike

Please Review javadoc warning fixes to java.lang.invoke

2013-10-17 Thread roger riggs
Please review a couple of issues with javadoc in java.lang.invoke to cleanup javadoc warnings. https://bugs.openjdk.java.net/browse/JDK-8026183 https://bugs.openjdk.java.net/browse/JDK-8015808 Webrev: http://cr.openjdk.java.net/~rriggs/webrev-invoke-javadoc-8026183/ Thanks, Roger

Re: RFR 8026499: Root Logger level can be reset unexpectedly

2013-10-17 Thread Mandy Chung
On 10/16/13 5:35 AM, Daniel Fuchs wrote: Hi, Please find below the new revision: http://cr.openjdk.java.net/~dfuchs/webrev_8026499/webrev.01/ Looks good. As for the test, LoggingSupport.getLogger is just a layer to support the PlatformLogger be called in the absence of java.util.logging

Re: Please Review javadoc warning fixes to java.lang.invoke

2013-10-17 Thread Lance Andersen - Oracle
+1 On Oct 17, 2013, at 1:15 PM, roger riggs wrote: Please review a couple of issues with javadoc in java.lang.invoke to cleanup javadoc warnings. https://bugs.openjdk.java.net/browse/JDK-8026183 https://bugs.openjdk.java.net/browse/JDK-8015808 Webrev:

hg: jdk8/tl/jdk: 8026183: minor documentation problems in java.lang.invoke; ...

2013-10-17 Thread roger . riggs
Changeset: 456a9b199208 Author:rriggs Date: 2013-10-17 13:43 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/456a9b199208 8026183: minor documentation problems in java.lang.invoke 8015808: Typo in MethodHandle javadoc Summary: Fix typos and javadoc markup and extraneous

Re: RFR (JAXP) : 8015243 : SchemaFactory does not catch enum. value that is not in the value space of the base type, anyURI.

2013-10-17 Thread Lance Andersen - Oracle
+1 On Oct 16, 2013, at 2:53 PM, huizhe wang wrote: Hi, This is a conformance issue. The issue is that a JCK test fails since invalid URI such as // was not caught. The fix is to check and allow empty authority only if there's non empty path, query component or fragment identifier.

Re: RFR (JAXP) : 8015243 : SchemaFactory does not catch enum. value that is not in the value space of the base type, anyURI.

2013-10-17 Thread huizhe wang
Thanks! On 10/17/2013 10:51 AM, Lance Andersen - Oracle wrote: +1 On Oct 16, 2013, at 2:53 PM, huizhe wang wrote: Hi, This is a conformance issue. The issue is that a JCK test fails since invalid URI such as // was not caught. The fix is to check and allow empty authority only if there's

Re: RFR: 8016344 - (props) Properties.storeToXML behaviour has changed from JDK 6 to 7

2013-10-17 Thread Mandy Chung
Daniel, Have you considered to revert to the previous version and simply iterate props.keySet rather than adding a new entry point just for jdk.internal.util.xml.PropertiesDefaultHandler to use? Mandy On 10/17/13 9:18 AM, Daniel Fuchs wrote: Hi, Please find below a fix for: 8016344:

hg: jdk8/tl/jaxp: 8015243: SchemaFactory does not catch enum. value that is not in the value space of the base type, anyURI

2013-10-17 Thread huizhe . wang
Changeset: 0c3f951630fe Author:joehw Date: 2013-10-17 11:22 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/0c3f951630fe 8015243: SchemaFactory does not catch enum. value that is not in the value space of the base type, anyURI Reviewed-by: lancea !

Review request 8026812, doclint clean up for java.sql and javax.sql

2013-10-17 Thread Lance Andersen - Oracle
Hi all, Need a reviewer for 8026812 which addresses the new doclint warnings. Webrev is at: http://cr.openjdk.java.net/~lancea/8026812/webrev.00/ Best Lance Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803

hg: jdk8/tl/jdk: 8015243: SchemaFactory does not catch enum. value that is not in the value space of the base type, anyURI

2013-10-17 Thread huizhe . wang
Changeset: bc04f561bb78 Author:joehw Date: 2013-10-17 11:43 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bc04f561bb78 8015243: SchemaFactory does not catch enum. value that is not in the value space of the base type, anyURI Reviewed-by: lancea +

Re: Review request 8026812, doclint clean up for java.sql and javax.sql

2013-10-17 Thread Mike Duigou
Looks good. (reviewed patch file). I did not verify that the remaining p in SQLXML.java, RowSet.java, BaseRowSet.java don't produce any warnings. Mike On Oct 17 2013, at 11:51 , Lance Andersen - Oracle lance.ander...@oracle.com wrote: Hi all, Need a reviewer for 8026812 which addresses

Re: RFR [8024521] (process) Async close issues with Process InputStream

2013-10-17 Thread Ivan Gerasimov
Thank you Alan! Yes, I missed that fact that reading from the recycled file descriptor is actually a problem by itself. Would you please take a look at another updated webrev? It contains another implementation suggested by Paul Sandoz with some minor changes.

hg: jdk8/tl/jdk: 8026812: doclint clean up for java.sql and javax.sql

2013-10-17 Thread lance . andersen
Changeset: 64c0ac7cd936 Author:lancea Date: 2013-10-17 15:14 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/64c0ac7cd936 8026812: doclint clean up for java.sql and javax.sql Reviewed-by: mduigou ! src/share/classes/java/sql/CallableStatement.java !

Re: 8008662: Add @jdk.Exported to JDK-specific/exported APIs

2013-10-17 Thread Andrew
- Original Message - As a follow-up to Joe Darcy's rename of jdk.Supported to jdk.Exported, I'd like to have another attempt at adding the annotation to a number of JDK specific APIs that are long standing exported, documented and supported APIs. Specifically, the following APIs:

JDK 8 RFC 4891331: BigInteger a.multiply(a) should use squaring code

2013-10-17 Thread Brian Burkhalter
This post concerns this issue: https://bugs.openjdk.java.net/browse/JDK-4891331 I performed some tests using JMH [1] on Mac OS X [2] and Windows 7 [3]. The tests were equivalent to calling multiply() with argument == this for bit lengths from 32 through 448 without and with this patch applied:

Re: RFR: 8004138: ForkJoinTask leaks exceptions

2013-10-17 Thread Mike Duigou
Thanks Martin! On Oct 17 2013, at 11:12 , Martin Buchholz marti...@google.com wrote: On Thu, Oct 17, 2013 at 11:09 AM, Martin Buchholz marti...@google.com wrote: Thanks for making a proper regtest. Fix a bug, write a test. Rinse and repeat. Always repeat. :-) A variant of this is now

hg: jdk8/tl/jdk: 8026233: test/sun/security/tools/keytool/StorePasswords.java needs to clean up files

2013-10-17 Thread jason . uh
Changeset: fa38f8e0accd Author:juh Date: 2013-10-17 12:00 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fa38f8e0accd 8026233: test/sun/security/tools/keytool/StorePasswords.java needs to clean up files Reviewed-by: vinnie !

Re: RFC 6910473: BigInteger negative bit length, value range, and future prospects

2013-10-17 Thread Dmitry Nadezhin
I suggest to insert a line * @ignore hugeMemory to SymmeticRangeTests.java after the line * @test . The automatic run of jtreg with usual arguments fails with diagnostics test result: Error. Test ignored: hugeMemory . If somebody wants to run this test he can run jtreg with additional switch

hg: jdk8/tl/langtools: 8015912: jdeps support to output in dot file format; ...

2013-10-17 Thread mandy . chung
Changeset: defadd528513 Author:mchung Date: 2013-10-17 13:19 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/defadd528513 8015912: jdeps support to output in dot file format 8026255: Switch jdeps to follow traditional Java option style Reviewed-by: alanb !

hg: jdk8/tl/jdk: 8015912: jdeps support to output in dot file format; ...

2013-10-17 Thread mandy . chung
Changeset: 3735d81552a7 Author:mchung Date: 2013-10-17 13:22 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3735d81552a7 8015912: jdeps support to output in dot file format 8026255: Switch jdeps to follow traditional Java option style Reviewed-by: alanb !

Re: RFR 8025971 and 8026197

2013-10-17 Thread Xueming Shen
Webrev has been updated accordingly based on your suggestion. http://cr.openjdk.java.net/~sherman/8025971_8026197/webrev thanks! -Sherman On 10/16/2013 01:09 AM, Stephen Colebourne wrote: On 15 October 2013 20:35, Xueming Shenxueming.s...@oracle.com wrote: Please help codereview the changes

hg: jdk8/tl/jdk: 8004138: ForkJoinTask leaks exceptions

2013-10-17 Thread mike . duigou
Changeset: c1af85c48819 Author:mduigou Date: 2013-10-17 12:43 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c1af85c48819 8004138: ForkJoinTask leaks exceptions Reviewed-by: chegar, mduigou, psandoz, martin Contributed-by: Doug Lea d...@cs.oswego.edu !

Re: RFR 8025971 and 8026197

2013-10-17 Thread Stephen Colebourne
I'm happy with the contents of this webrev. As pointed out previously, it doesn't address the specific issue in 8025971 Stephen On 17 October 2013 21:53, Xueming Shen xueming.s...@oracle.com wrote: Webrev has been updated accordingly based on your suggestion.

Re: 8008662: Add @jdk.Exported to JDK-specific/exported APIs

2013-10-17 Thread Mandy Chung
On 10/17/13 12:25 PM, Andrew wrote: I just came across this trying to understand what the new annotation means. Is the intention for these 'exported' APIs to be eventually replaced by proper parts of the specification (i.e. java.* or javax.*). I'm not keen on the idea of encouraging the use

hg: jdk8/tl: 8026062: webrev.ksh: fix bug title web scraping, remove teamware, sac, open bug, -l and wxfile support

2013-10-17 Thread mike . duigou
Changeset: 9ec6626d43bb Author:mduigou Date: 2013-10-17 14:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/9ec6626d43bb 8026062: webrev.ksh: fix bug title web scraping, remove teamware, sac, open bug, -l and wxfile support Reviewed-by: weijun, dsamersoff, darcy, jrose, tbell

Re: RFR 8025971 and 8026197

2013-10-17 Thread Xueming Shen
On 10/17/2013 02:01 PM, Stephen Colebourne wrote: I'm happy with the contents of this webrev. As pointed out previously, it doesn't address the specific issue in 8025971 Stephen On 17 October 2013 21:53, Xueming Shenxueming.s...@oracle.com wrote: Webrev has been updated accordingly based

RFR (JAXP): 8016500 : Unlocalized warnigs.

2013-10-17 Thread huizhe wang
Hi, This is a fix to use the existing localized messages on a warning. The fix is to fetch the localized messages instead of printing out hard-coded message in English. The locale is initialized in parser configuration by calling Locale.getDefault. The configuration.getLocale will reflect

JDK 8 RFR 8026832: Clean up straggling doclint warnings in java.math

2013-10-17 Thread Brian Burkhalter
Please review … Issue: https://bugs.openjdk.java.net/browse/JDK-8026832 Webrev: http://cr.openjdk.java.net/~bpb/8026832/webrev/ Thanks, Brian

Re: RFR (JAXP): 8016500 : Unlocalized warnigs.

2013-10-17 Thread Lance @ Oracle
+1 Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad On Oct 17, 2013, at 5:51 PM, huizhe wang huizhe.w...@oracle.com wrote: Hi, This is a fix to use the existing

Re: JDK 8 RFR 8026832: Clean up straggling doclint warnings in java.math

2013-10-17 Thread Lance @ Oracle
+1 Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad On Oct 17, 2013, at 6:00 PM, Brian Burkhalter brian.burkhal...@oracle.com wrote: Please review … Issue:

hg: jdk8/tl/jdk: 8026832: Clean up straggling doclint warnings in java.math

2013-10-17 Thread brian . burkhalter
Changeset: e76bb2436b04 Author:bpb Date: 2013-10-17 15:05 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e76bb2436b04 8026832: Clean up straggling doclint warnings in java.math Summary: Fix empty paragraph tag warnings. Reviewed-by: lancea !

Re: RFR 8025971 and 8026197

2013-10-17 Thread Stephen Colebourne
On 17 October 2013 22:14, Xueming Shen xueming.s...@oracle.com wrote: On 10/17/2013 02:01 PM, Stephen Colebourne wrote: I'm happy with the contents of this webrev. As pointed out previously, it doesn't address the specific issue in 8025971 I will file a separate issue to address the issue.

Re: RFR (JAXP): 8016500 : Unlocalized warnigs.

2013-10-17 Thread huizhe wang
Thanks for the quick review! Joe On 10/17/2013 3:02 PM, Lance @ Oracle wrote: +1 http://oracle.com/us/design/oracle-email-sig-198324.gifLance Andersen| Principal Member of Technical Staff | +1.781.442.2037 tel:+1.781.442.2037 Oracle Java Engineering 1 Network Drive

Re: RFR (JAXP): 8016500 : Unlocalized warnigs.

2013-10-17 Thread Naoto Sato
Hi Joe, If the locale is used for selecting the language for the warning messages, I'd recommend using Locale.getDefault(Locale.Category.DISPLAY) instead. Naoto On 10/17/13 2:51 PM, huizhe wang wrote: Hi, This is a fix to use the existing localized messages on a warning. The fix is to

Re: JDK 8 RFC 4891331: BigInteger a.multiply(a) should use squaring code

2013-10-17 Thread Joseph Darcy
Hi Brian, On 10/17/2013 12:26 PM, Brian Burkhalter wrote: This post concerns this issue: https://bugs.openjdk.java.net/browse/JDK-4891331 I performed some tests using JMH [1] on Mac OS X [2] and Windows 7 [3]. The tests were equivalent to calling multiply() with argument == this for bit

Re: JDK 8 RFR 8026806: Incomplete test of getaddrinfo() return value could lead to incorrect exception for Windows Inet 6

2013-10-17 Thread Dmitry Samersoff
Brian, Looks good for me (not a reviewer). -Dmitry On 2013-10-17 20:46, Brian Burkhalter wrote: Continuing the discussion from http://mail.openjdk.java.net/pipermail/net-dev/2013-October/007574.html under new issue ID: Issue:https://bugs.openjdk.java.net/browse/JDK-8026806

Re: RFR (JAXP): 8016500 : Unlocalized warnigs.

2013-10-17 Thread huizhe wang
Hi Naoto, The locale is read from the existing, general parser configuration. The getDefault(Locale.Category http://docs.oracle.com/javase/7/docs/api/java/util/Locale.Category.html category) method was added since 1.7 but we would like to maintain code level at 1.5 for JAXP for as long as

Re: JDK 8 RFC 4891331: BigInteger a.multiply(a) should use squaring code

2013-10-17 Thread Brian Burkhalter
Hi Joe, Will do. Thanks, Brian On Oct 17, 2013, at 4:08 PM, Joseph Darcy wrote: Can you test the performance of a patch with: if (val == this and mag.length 8) Do you have any measurements of the multiply performance of values that are not ==? (Making sure there is no general

hg: jdk8/tl/jaxp: 8016500: Unlocalized warnigs.

2013-10-17 Thread huizhe . wang
Changeset: 951c1f7fdb10 Author:joehw Date: 2013-10-17 16:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/951c1f7fdb10 8016500: Unlocalized warnigs. Reviewed-by: lancea ! src/com/sun/org/apache/xerces/internal/jaxp/DefaultValidationErrorHandler.java !

Re: RFR (JAXP): 8016500 : Unlocalized warnigs.

2013-10-17 Thread Naoto Sato
Thanks for the explanation. Keeping the same code with 1.5 sounds more important to me. So, I am OK with the current proposed change. Naoto On 10/17/13 4:50 PM, huizhe wang wrote: Hi Naoto, The locale is read from the existing, general parser configuration. The getDefault(Locale.Category

Re: hg: jdk8/tl/jaxp: 8016500: Unlocalized warnigs.

2013-10-17 Thread mark . reinhold
2013/10/17 9:36 -0700, huizhe.w...@oracle.com: Changeset: 951c1f7fdb10 Author:joehw Date: 2013-10-17 16:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/951c1f7fdb10 8016500: Unlocalized warnigs. Reviewed-by: lancea The synopsis should say warnings, not warnigs.

Re: RFR (JAXP): 8016500 : Unlocalized warnigs.

2013-10-17 Thread huizhe wang
Thanks! Joe On 10/17/2013 5:04 PM, Naoto Sato wrote: Thanks for the explanation. Keeping the same code with 1.5 sounds more important to me. So, I am OK with the current proposed change. Naoto On 10/17/13 4:50 PM, huizhe wang wrote: Hi Naoto, The locale is read from the existing, general

Re: hg: jdk8/tl/jaxp: 8016500: Unlocalized warnigs.

2013-10-17 Thread huizhe wang
On 10/17/2013 5:09 PM, mark.reinh...@oracle.com wrote: 2013/10/17 9:36 -0700, huizhe.w...@oracle.com: Changeset: 951c1f7fdb10 Author:joehw Date: 2013-10-17 16:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/951c1f7fdb10 8016500: Unlocalized warnigs. Reviewed-by:

hg: jdk8/tl/jaxp: 5 new changesets

2013-10-17 Thread lana . steuck
Changeset: acae2e8a46df Author:ihse Date: 2013-10-10 14:58 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/acae2e8a46df 8001931: The new build system whitespace cleanup Reviewed-by: tbell, simonis, erikj ! makefiles/BuildJaxp.gmk ! makefiles/Makefile Changeset:

hg: jdk8/tl: 25 new changesets

2013-10-17 Thread lana . steuck
Changeset: 7dea0ce25bdc Author:pbhat Date: 2013-05-30 16:00 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/rev/7dea0ce25bdc Merge ! common/autoconf/generated-configure.sh Changeset: d081bdbf904d Author:jqzuo Date: 2013-06-10 16:15 -0400 URL:

hg: jdk8/tl/jaxws: 4 new changesets

2013-10-17 Thread lana . steuck
Changeset: 602fdd7bb765 Author:ihse Date: 2013-10-10 14:58 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/602fdd7bb765 8001931: The new build system whitespace cleanup Reviewed-by: tbell, simonis, erikj ! makefiles/BuildJaxws.gmk ! makefiles/Makefile Changeset:

hg: jdk8/tl/corba: 4 new changesets

2013-10-17 Thread lana . steuck
Changeset: 66fc1a749867 Author:ihse Date: 2013-10-10 14:58 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/66fc1a749867 8001931: The new build system whitespace cleanup Reviewed-by: tbell, simonis, erikj ! makefiles/BuildCorba.gmk ! makefiles/Makefile Changeset:

hg: jdk8/tl/nashorn: 4 new changesets

2013-10-17 Thread lana . steuck
Changeset: 45399f3ef717 Author:ihse Date: 2013-10-10 14:58 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/45399f3ef717 8001931: The new build system whitespace cleanup Reviewed-by: tbell, simonis, erikj ! makefiles/BuildNashorn.gmk ! makefiles/Makefile Changeset:

hg: jdk8/tl/langtools: 4 new changesets

2013-10-17 Thread lana . steuck
Changeset: 343aeb2033f0 Author:ihse Date: 2013-10-10 14:58 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/343aeb2033f0 8001931: The new build system whitespace cleanup Reviewed-by: tbell, simonis, erikj ! makefiles/BuildLangtools.gmk ! makefiles/Makefile Changeset:

hg: jdk8/tl/jdk: 11 new changesets

2013-10-17 Thread lana . steuck
Changeset: 28191d3ff921 Author:erikj Date: 2013-10-09 16:22 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/28191d3ff921 8026144: Missing mkdir in Images.gmk Reviewed-by: tbell ! makefiles/Images.gmk Changeset: 86df2e879eca Author:tbell Date: 2013-10-09 18:50 -0700

hg: jdk8/tl/hotspot: 46 new changesets

2013-10-17 Thread lana . steuck
Changeset: deec468baebd Author:amurillo Date: 2013-10-04 14:19 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/deec468baebd 8025859: new hotspot build - hs25-b54 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 5b3b75d9eb2f Author:coleenp Date: 2013-10-01

hg: jdk8/tl/jdk: 7025699: Policy Tool is not accessible by keyboard

2013-10-17 Thread weijun . wang
Changeset: c1616a944d1c Author:weijun Date: 2013-10-18 08:57 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c1616a944d1c 7025699: Policy Tool is not accessible by keyboard Reviewed-by: alexp, weijun Contributed-by: Leif Samuelsson leif.samuels...@oracle.com !

hg: jdk8/tl/langtools: 8026838: Fix new doclint issues in javax.annotation.processing

2013-10-17 Thread joe . darcy
Changeset: 7af634b1fc5b Author:darcy Date: 2013-10-17 19:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7af634b1fc5b 8026838: Fix new doclint issues in javax.annotation.processing Reviewed-by: jjg ! src/share/classes/javax/annotation/processing/Processor.java

JDK 8 RFR for JDK-8026840: Fix new doclint issues in javax.naming

2013-10-17 Thread Joe Darcy
Hello, Please review the patch below which addresses JDK-8026840: Fix new doclint issues in javax.naming (A new version of doclint reveals additional issues.) Thanks, -Joe diff -r c1616a944d1c src/share/classes/javax/naming/CompositeName.java ---

hg: jdk8/tl/jdk: 8025799: Restore sun.reflect.Reflection.getCallerClass(int) until a replacement API is provided

2013-10-17 Thread mandy . chung
Changeset: 042a473535aa Author:mchung Date: 2013-10-17 19:47 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/042a473535aa 8025799: Restore sun.reflect.Reflection.getCallerClass(int) until a replacement API is provided Reviewed-by: alanb, forax, dholmes, twisti !

Re: JDK 8 RFR for JDK-8026840: Fix new doclint issues in javax.naming

2013-10-17 Thread Mandy Chung
Thumbs up. Mandy On 10/17/2013 7:45 PM, Joe Darcy wrote: Hello, Please review the patch below which addresses JDK-8026840: Fix new doclint issues in javax.naming (A new version of doclint reveals additional issues.) Thanks, -Joe diff -r c1616a944d1c

hg: jdk8/tl/jdk: 8026840: Fix new doclint issues in javax.naming

2013-10-17 Thread joe . darcy
Changeset: 8a7b1b615100 Author:darcy Date: 2013-10-17 22:22 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8a7b1b615100 8026840: Fix new doclint issues in javax.naming Reviewed-by: mchung ! src/share/classes/javax/naming/CompositeName.java !

Re: JDK 8 code review request for JDK-8025913 - Rename jdk.Supported to jdk.Exported

2013-10-17 Thread Joe Darcy
Hello, Following up on the earlier feedback, please review the patch below with proposed clarifications to jdk.Exported. Thanks, -Joe diff -r 7af634b1fc5b src/share/classes/jdk/Exported.java --- a/src/share/classes/jdk/Exported.javaThu Oct 17 19:10:19 2013 -0700 +++