Ok, I pushed your change.
Thanks,
Joe
On 3/24/2015 6:20 PM, Amy Lu wrote:
Hi, Joe
Without this fix, jaxp test run in JPRT will fail because it try to
use jtreg/win32/bin/jtreg
Thanks,
Amy
On 3/25/15 2:18 AM, huizhe wang wrote:
Hi Amy,
Does this in any way affect how the tests are run in
On 25/03/2015 4:07 AM, Vladimir Kozlov wrote:
Got it. I missed that you changed code in unsafe.cpp.
Let me prepare closed changes and get it reviewed before we can push this.
Copyright notices need updating too. And the copyright dates on the test
look like they have been copied from another f
Hi, Joe
Without this fix, jaxp test run in JPRT will fail because it try to use
jtreg/win32/bin/jtreg
Thanks,
Amy
On 3/25/15 2:18 AM, huizhe wang wrote:
Hi Amy,
Does this in any way affect how the tests are run in JPRT?
Thanks,
Joe
On 3/23/2015 10:12 PM, Amy Lu wrote:
File structure has c
How about this, which resurrects the jdk7 doc strings for the legacy fields?
--- src/main/java/util/concurrent/ConcurrentHashMap.java 24 Mar 2015
22:30:53 - 1.270
+++ src/main/java/util/concurrent/ConcurrentHashMap.java 25 Mar 2015
00:03:43 -
@@ -566,7 +566,16 @@
/** Number of CPUS, t
Andrew,
The test failed when run it in JPRT with 32-bit fastdebug *Client* VM (-client)
on linux-x86:
java.lang.RuntimeException
at MyByteBuffer.ck(HeapByteBufferTest.java:201)
at MyByteBuffer.getLong(HeapByteBufferTest.java:211)
at HeapByteBufferTest.step(HeapByteBuffer
On Tue, Mar 24, 2015 at 12:49 AM, Alan Bateman
wrote:
>
>> Looks okay but it makes for mix of styles (LL vs. getSig for example).
Yeah, C macros and Java constants are UPPER_CASE. LL should really be
renamed to something more Javaesque.
I changed pkSigAt to not use increment, making the para
Hi Mikhail,
Nit:
Utils.java:
-// reset timezone when all the packers have terminated
+// reset timezone when all the packer/unpacker instances have
terminated
DefaultTimeZoneTest.java
What did you change between 01 and 02 revisions ? They appear to be the
same ?
Kumar
jsr166 CVS now contains this small improvement (I verified the emitted
bytes are unchanged):
--- src/main/java/util/concurrent/ConcurrentHashMap.java 23 Mar 2015
18:48:19 - 1.269
+++ src/main/java/util/concurrent/ConcurrentHashMap.java 24 Mar 2015
22:28:58 -
@@ -1373,9 +1373,10 @@
Hi there,
There's a new webrev:
http://cr.openjdk.java.net/~mcherkas/8066985/webrev.02/
I reduced the a thread number in the test, because with big count of
threads I got OOM on JPRT.
And extract common part form PackerImpl and UnpackerImpl to Utils.
Thanks,
Mikhail.
On 3/20/2015 6:04 PM,
On Tue, Mar 24, 2015 at 7:42 AM, Chris Hegarty
wrote:
>
> 3) "process reaper”, maybe
> “Process-Reaper-“ + monotonically increasing ID ( similar to
> ForkJoin worker threads, or other ). But I do accept that this
> is the existing name for the reaper threads.
>
Nothing interesting is
Please review at your convenience.
Issue: https://bugs.openjdk.java.net/browse/JDK-8075156
Patch: http://cr.openjdk.java.net/~bpb/8075156/webrev.00/
This is a sequel to the resolved issue
https://bugs.openjdk.java.net/browse/JDK-8068373, (prefs) FileSystemPreferences
writes \0 to XML storage,
On 24 Mar 2015, at 17:32, Roger Riggs wrote:
...
>> 2) Can ProcessImpl.waitForProcessExit and its native counterpart be
>> removed? ( since its function is now performed through ProcessHandleImpl
>> )
> I'll look at that again; the two behaviors:
> 1) waiting for and reaping the exit value us
Hi Amy,
Does this in any way affect how the tests are run in JPRT?
Thanks,
Joe
On 3/23/2015 10:12 PM, Amy Lu wrote:
File structure has changed in the new jtreg distribution (4.1/b11),
there are no platform specific bin directories any more.
This fix is for updating jaxp/test/Makefile accordin
Got it. I missed that you changed code in unsafe.cpp.
Let me prepare closed changes and get it reviewed before we can push this.
Thanks,
Vladimir
On 3/24/15 1:15 AM, Andrew Haley wrote:
On 23/03/15 21:10, Vladimir Kozlov wrote:
Hotspot make files changes?
There's no need: I think we came to
Hi Chris,
Thanks for the review and comments.
On 3/24/2015 10:42 AM, Chris Hegarty wrote:
Roger,
I think the API is looking much better now ( just a few comments below on small
specific issues ), so I’ve taken a pass over the implementation changes in the
sandbox. Here are some comments:
1)
Hi Daniel,
Looks good. The only other alternative would be to use
java.io.CharConversionException over IOException. We could even consider
dropping the cause because the subclass of I/O exception would convey the same
meaning.
Minor formatting issues with a missing space after the catch ke
Thanks for the feedback Alan.
On 24 Mar 2015, at 11:27, Alan Bateman wrote:
> On 23/03/2015 15:45, Chris Hegarty wrote:
>> Here is an updated version of the FieldSetter API, with all comments to date
>> incorporated.
>>
>>
>> http://cr.openjdk.java.net/~chegar/8071472/02/specdiff/overview-sum
On 03/23/2015 10:25 PM, Mark Sheppard wrote:
Hi
please oblige and review the following fix
http://cr.openjdk.java.net/~msheppar/8068721/jdk9/corba/webrev/
http://cr.openjdk.java.net/~msheppar/8068721/jdk9/jdk/webrev/
Hi Mark,
Can an instance of ObjectStreamHook (ObjectOutputStream) be invoke
On 3/24/2015 7:42 AM, Daniel Fuchs wrote:
Hi,
Please find below a fix for
8075810: LogManager.readConfiguration may throw
undocumented IllegalArgumentException
https://bugs.openjdk.java.net/browse/JDK-8075810
The proposed fix is to catch the IllegalArgumentException and
wrap it in
Hi Lance,
Thanks for the review!
On 24/03/15 16:01, Lance Andersen wrote:
Hi Daniel,
This looks OK but I might suggest clarifying that the cause could be set
in the javadoc. Now that being said, I am not sure how consistent we
are across the JDK or just make the assumption people will check t
Hi Daniel,
This looks OK but I might suggest clarifying that the cause could be set in the
javadoc. Now that being said, I am not sure how consistent we are across the
JDK or just make the assumption people will check the cause if they desire.
As far as backporting, unless it really needed, I
Roger,
I think the API is looking much better now ( just a few comments below on small
specific issues ), so I’ve taken a pass over the implementation changes in the
sandbox. Here are some comments:
1) Some operations on ProcessHandle require RuntimePermission
"manageProcess", but I don't s
Hi,
Please find below a fix for
8075810: LogManager.readConfiguration may throw
undocumented IllegalArgumentException
https://bugs.openjdk.java.net/browse/JDK-8075810
The proposed fix is to catch the IllegalArgumentException and
wrap it in an IOException, since LogManager.readConfigur
On 24/03/2015 11:11, Mark Sheppard wrote:
Hi Alan,
thanks for the feedback.
WRT test location, I followed what is already in place i.e.
javax/rmi/ssl had an existing test
so as RMI-IIOP falls under javax/rmi/PortableRemoteObject, placing the
test in this grouping seemed reasonable.
It's no
On 23/03/2015 15:45, Chris Hegarty wrote:
Here is an updated version of the FieldSetter API, with all comments
to date incorporated.
http://cr.openjdk.java.net/~chegar/8071472/02/specdiff/overview-summary.html
Final spec comments welcome, after which I intend to submit a CCC
request.
In
Hi Alan,
thanks for the feedback.
WRT test location, I followed what is already in place i.e.
javax/rmi/ssl had an existing test
so as RMI-IIOP falls under javax/rmi/PortableRemoteObject, placing the
test in this grouping seemed reasonable.
It's no bother to place it elsewhere if you wish.
On 24 Mar 2015, at 10:13, Mark Sheppard wrote:
> Thanks Chris
> I can include the proposed changes if you wish.
I think it best to keep any potential changes to CHM separate, so as not to
block your changes. We need to first have the CHM changes accepted by the 166
maintainers, applied upstrea
Thanks Chris
I can include the proposed changes if you wish.
my original fix had similar PutField change to writeObject, but I left
it from this review so
that it could be addressed separately.
regards
Mark
On 24/03/2015 09:38, Chris Hegarty wrote:
Martin,
On 23 Mar 2015, at 22:15, Martin Bu
On 23 Mar 2015, at 21:25, Mark Sheppard wrote:
> ….
>
> ConcurrentHashMap changed its structure in jdk8 from that used in jdk7.
> This resulted in modification to the readObject and writeObject methods,
> and in particular, former serial fields were removed, resulting in
The non-transient fiel
Martin,
On 23 Mar 2015, at 22:15, Martin Buchholz wrote:
> Let us know if the serialization code of the collection classes can be
> improved.
I think there are a few minor cleanups that would be beneficial in CHM:
1) Add @serialField so that the serializable stream fields show up in the
On 23/03/15 21:10, Vladimir Kozlov wrote:
> Hotspot make files changes?
There's no need: I think we came to the conclusion that we wouldn't
define BIG_ENDIAN.
Andrew.
On 24/03/2015 5:55 PM, Paul Sandoz wrote:
On Mar 24, 2015, at 12:27 AM, John Rose wrote:
Meanwhile, Paul Sandoz is working to refactor these aspects, creating a large
chunk of API that will be public, portable, and secure. You've got to
sympathize with him for not wanting to run through all
Hi Stuart,
Many thanks for looking at this gnarly code.
On Mar 24, 2015, at 2:41 AM, Stuart Marks wrote:
> Hi Paul,
>
> After reading your notes here, and in the bug reports, and the comments in
> the code, and banging my head against the code (before and after) for a
> while, I'm starting t
On Mar 24, 2015, at 12:27 AM, John Rose wrote:
> Meanwhile, Paul Sandoz is working to refactor these aspects, creating a large
> chunk of API that will be public, portable, and secure. You've got to
> sympathize with him for not wanting to run through all the inevitable
> arguments about concu
Kindly reminder ...
On 3/17/15 3:05 PM, Amy Lu wrote:
This RFR proposes to remove the duplicate FDTest from “jdk” repo.
FDTest exists in both “jdk” and “langtools”:
http://hg.openjdk.java.net/jdk9/dev/jdk/file/tip/test/jdk/lambda/FDTest.java
http://hg.openjdk.java.net/jdk9/dev/langtools/file/
On 23/03/2015 23:44, Martin Buchholz wrote:
https://bugs.openjdk.java.net/browse/JDK-8075774
http://cr.openjdk.java.net/~martin/webrevs/openjdk9/PKsig-java/
Looks okay but it makes for mix of styles (LL vs. getSig for example).
-Alan
Hi Lev,
On 24/03/2015 3:03 PM, Lev Priima wrote:
Hi David,
Please review and push update:
http://cr.openjdk.java.net/~lpriima/8075071/2/webrev/ .
NPE in WB happens when vm does not have requested flag. To make test run
on 32bit vm, where is no UseCompressedOops flag, I've added additional
null
On 23/03/2015 21:25, Mark Sheppard wrote:
Hi
please oblige and review the following fix
http://cr.openjdk.java.net/~msheppar/8068721/jdk9/corba/webrev/
http://cr.openjdk.java.net/~msheppar/8068721/jdk9/jdk/webrev/
which addresses the issue in
https://bugs.openjdk.java.net/browse/JDK-8068721
38 matches
Mail list logo
