Thanks Mandy and Lance for the review! Changes pushed.
-Joe
On 9/25/2015 3:40 PM, Mandy Chung wrote:
On 09/25/2015 02:38 PM, huizhe wang wrote:
With this application/libraries used to put xml-apis-2.11.0.jar on
the endorsed/ext directory or classpath no longer needs to do that
because o
On 09/25/2015 02:38 PM, huizhe wang wrote:
With this application/libraries used to put xml-apis-2.11.0.jar on
the endorsed/ext directory or classpath no longer needs to do that
because org.w3c.dom.ElementTraversal was not part of the DOM API
endorsed by JAXP in JDK 8.
I skimmed through t
On 9/25/2015 2:18 PM, Mandy Chung wrote:
On 09/25/2015 12:41 PM, huizhe wang wrote:
Hi,
Please review the DOM update to include the Element Traversal
Specification. ElementTraversal is an interface which allows the
author to restrict navigation to Element nodes.
The implementation is the
On 09/25/2015 12:41 PM, huizhe wang wrote:
Hi,
Please review the DOM update to include the Element Traversal
Specification. ElementTraversal is an interface which allows the
author to restrict navigation to Element nodes.
The implementation is the result of a merge with the upper Xerces
so
On 9/25/2015 1:15 PM, Lance Andersen wrote:
Hi Joe,
The change and the test looks overall.
Thanks Lance!
One minor suggestion on the javadocs, I might change to
@{code} on line 177
Sure, changed. Makes me feel like we could use a @emphasize @em tag :-)
Best,
Joe
Best
Lance
On Sep
Hi Joe,
The change and the test looks overall.
One minor suggestion on the javadocs, I might change to @{code} on
line 177
Best
Lance
On Sep 25, 2015, at 3:41 PM, huizhe wang wrote:
> Hi,
>
> Please review the DOM update to include the Element Traversal Specification.
> ElementTraversal
Hi,
Please review the DOM update to include the Element Traversal
Specification. ElementTraversal is an interface which allows the author
to restrict navigation to Element nodes.
The implementation is the result of a merge with the upper Xerces
source. The new methods implementation starts a
Hi Kevin,
- Mail original -
> De: "Kevin Bourrillion"
> À: "Core Libs Dev"
> Envoyé: Vendredi 25 Septembre 2015 17:33:02
> Objet: Re: JEP 269: Convenience Factory Methods for Collections
>
> I don't think the proposal is bad, but for whatever it's worth to you... we
> wouldn't use it. A
Hello,
After a good amount of staring at the code, I was able to figure out the
cause of the previously reported problem in the initial port of FDLIBM
pow to Java:
http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-September/035276.html
In brief, I had replaced some magnitude comparis
> On Sep 24, 2015, at 7:16 AM, Chris Hegarty wrote:
>
> In preparation for JEP 260 "Encapsulate Most Internal APIs” [1],
> SharedSecrets and friend interfaces should be moved out of
> 'sun.misc’ [2] and located in a truly private package. This is so that
> they are not part of the proposed to be
Hi Michael,
On 09/25/2015 03:37 PM, Michael Haupt wrote:
Hi Peter,
thanks for this changeset. Note I'm not a Reviewer (with a capital R); please
read this review in lower-case. ;-)
One question about MethodType: would you mind doing something about the naming
of the newly introduced fromDesc
Hi Paul,
Thanks for looking into this.
On 09/25/2015 04:07 PM, Paul Sandoz wrote:
Hi,
This looks like a partial dup of
https://bugs.openjdk.java.net/browse/JDK-8076596
Ah, sorry, I wasn't aware this has already been registered in JIRA. I
have linked the two issues together as DUPs.
The
On 2015-09-25 15:08, Erik Joelsson wrote:
Hello,
Please review this change to the build of JDK 9, which drops building
of interim-corba.
The interim build of java.corba has historically been needed for rmic
-iiop but it is no longer needed in the build since the JMX remote API
dropped suppo
On 09/25/2015 02:30 PM, Paul Sandoz wrote:
>There's also another problem. The orElseGet(null) is documented to
>work to work fine for non-empty optional
>(why on the Earth it was specified this way?).
Arguably it was a mistake that we did not catch in the frenzy of Java 8 feature
freeze. I wo
Hi,
This looks like a partial dup of
https://bugs.openjdk.java.net/browse/JDK-8076596
The changes look ok, but I am concerned post initialization there may be code
paths taken that require the system class loader to be used but instead the
boot stream class loader is used instead. Is that a le
- Mail original -
> De: "Paul Sandoz"
> Cc: "core-libs-dev"
> Envoyé: Vendredi 25 Septembre 2015 15:29:36
> Objet: Re: RFR 8080418 Add Optional.or()
>
>
> On 25 Sep 2015, at 15:06, Stephen Colebourne wrote:
>
> > On 25 September 2015 at 11:58, Paul Sandoz wrote:
> >> Please review th
Hi Peter,
thanks for this changeset. Note I'm not a Reviewer (with a capital R); please
read this review in lower-case. ;-)
One question about MethodType: would you mind doing something about the naming
of the newly introduced fromDescriptor() method? Its name does not suggest in
any way that
On 25 Sep 2015, at 15:06, Stephen Colebourne wrote:
> On 25 September 2015 at 11:58, Paul Sandoz wrote:
>> Please review this change to add a method Optional.or that allows one to
>> better compose optionals:
>>
>> http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8080418-optional-or/webrev/
>
>
Thanks Ivan, I'll push with these changes.
-Rob
On 24/09/15 16:31, Ivan Gerasimov wrote:
Thanks Rob!
The webrev looks cleaner.
jni_util.h:
Wouldn't it be better to move this block directly to the jni_util_md.c
file?
390 #if defined(LINUX) && (defined(_GNU_SOURCE) || \
391
On 25/09/15 14:08, Erik Joelsson wrote:
Hello,
Please review this change to the build of JDK 9, which drops building of
interim-corba.
The interim build of java.corba has historically been needed for rmic
-iiop but it is no longer needed in the build since the JMX remote API
dropped support for
On 25/09/2015 14:08, Erik Joelsson wrote:
Hello,
Please review this change to the build of JDK 9, which drops building
of interim-corba.
The interim build of java.corba has historically been needed for rmic
-iiop but it is no longer needed in the build since the JMX remote API
dropped suppo
Hello,
Please review this change to the build of JDK 9, which drops building of
interim-corba.
The interim build of java.corba has historically been needed for rmic
-iiop but it is no longer needed in the build since the JMX remote API
dropped support for the IIOP transport (JDK-8043937).
On 25 September 2015 at 11:58, Paul Sandoz wrote:
> Please review this change to add a method Optional.or that allows one to
> better compose optionals:
>
> http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8080418-optional-or/webrev/
New method seems fine.
> Separately while we are on the topic o
On 24 Sep 2015, at 19:57, Martin Buchholz wrote:
> FlakyThreadFactory fixed:
Thanks, verified.
Paul.
> (It would be nice if hotspot was consistent about the way it failed,
> regardless of platform)
> "Write once, fail anywhere"
>
> Index:
> src/test/jtreg/util/concurrent/ThreadPoolExecutor/F
On 25 Sep 2015, at 14:00, Tagir F. Valeev wrote:
> Hello!
>
> Quite interesting and long awaited features (at least according to
> StackOverflow questions).
All of them? or just the first?
> Isn't it a good idea to provide also a way
> to transfer between Optional types like "mapToInt", "map
Hi Simon,
On 09/25/2015 01:01 AM, Simon Spero wrote:
> [Some of this is may simple or prohibitively tricksy depending on alignment
> constraints (even though it's restricted to Prime Multilingual Plane :-) ]
>
> For some not un-realistic use cases, the most significant bytes for all the
> charact
Hello!
Quite interesting and long awaited features (at least according to
StackOverflow questions). Isn't it a good idea to provide also a way
to transfer between Optional types like "mapToInt", "mapToObj", etc.,
like it's done in Stream API?
PS> 2) add to all variants a mapOrElseGet (otherwise k
On 25/09/15 11:46, Miroslav Kos wrote:
On 25/09/15 11:46, Alan Bateman wrote:
On 25/09/2015 10:36, Miroslav Kos wrote:
Hi,
I prepared the webrev again with hg move:
http://cr.openjdk.java.net/~mkos/8061466/jaxws.02/index.html
For sure, jprt built again and all tests rerun.
The move and r
On 25/09/2015 11:46, Miroslav Kos wrote:
:
On 25/09/15 11:46, Alan Bateman wrote:
On 25/09/2015 10:36, Miroslav Kos wrote:
Hi,
I prepared the webrev again with hg move:
http://cr.openjdk.java.net/~mkos/8061466/jaxws.02/index.html
For sure, jprt built again and all tests rerun.
The move an
Hi,
Please review this change to add a method Optional.or that allows one to better
compose optionals:
http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8080418-optional-or/webrev/
I also took the opportunity to clear up the JavaDoc, it was a little
inconsistent and i personally found it harder t
On 25/09/15 11:46, Alan Bateman wrote:
On 25/09/2015 10:36, Miroslav Kos wrote:
Hi,
I prepared the webrev again with hg move:
http://cr.openjdk.java.net/~mkos/8061466/jaxws.02/index.html
For sure, jprt built again and all tests rerun.
The move and re-packaging looks good to me.
However I s
On 25/09/2015 10:36, Miroslav Kos wrote:
Hi,
I prepared the webrev again with hg move:
http://cr.openjdk.java.net/~mkos/8061466/jaxws.02/index.html
For sure, jprt built again and all tests rerun.
The move and re-packaging looks good to me.
However I see there is more to this as it drops the -
On 24/09/15 16:20, Alan Bateman wrote:
On 24/09/2015 14:57, Miroslav Kos wrote:
Hi everybody,
I'd like to ask for review of following fix:
RELAX NG API visible but not accessible
JBS: https://bugs.openjdk.java.net/browse/JDK-8061466
webrev: http://cr.openjdk.java.net/~mkos/8061466/jaxws.01/ind
On 25 Sep 2015, at 09:39, Remi Forax wrote:
> Hi Paul, hi chris,
>
> - Mail original -
>> De: "Chris Hegarty"
>> À: "Paul Sandoz"
>> Cc: "core-libs-dev"
>> Envoyé: Jeudi 24 Septembre 2015 11:06:36
>> Objet: Re: RFR 8135248: Add utility methods to check indexes and ranges
>>
>> On 24 S
Hi Paul, hi chris,
- Mail original -
> De: "Chris Hegarty"
> À: "Paul Sandoz"
> Cc: "core-libs-dev"
> Envoyé: Jeudi 24 Septembre 2015 11:06:36
> Objet: Re: RFR 8135248: Add utility methods to check indexes and ranges
>
> On 24 Sep 2015, at 08:40, Paul Sandoz wrote:
>
> > On 23 Sep 20
Hi Mark, hi Stuart, hi all,
for Map, i think a version with a builder will be cool too,
something like:
public interface EntryBuilder {
public EntryBuilder entry(K key, V value);
}
and by example for HashMap:
public static HashMap fromBuilder(Consumer> consumer) {
HashMap map = n
On 24 Sep 2015, at 23:47, Martin Buchholz wrote:
> I changed my export script to also publish my mercurial queues patches
> directory.
> Find it at
> http://cr.openjdk.java.net/~martin/webrevs/openjdk9/jsr166-jdk9-integration/patches/
Thanks, most helpful,
Paul.
37 matches
Mail list logo
