Re: RFR: JDK-8194750,Console.readPassword does not save/restore tty settings

Thanks! webrev has been updated accordingly as suggested. http://cr.openjdk.java.net/~sherman/8194750/webrev sherman On 4/16/18, 7:20 PM, Martin Buchholz wrote: Thanks, this looks good. But I have my usual nitpicky comments 376 // sets the console echo on/off 377 private static

Re: RFR: JDK-8194750, Console.readPassword does not save/restore tty settings

Thanks, this looks good. But I have my usual nitpicky comments 376 // sets the console echo on/off 377 private static native boolean echo(boolean on) throws IOException; I would document the return value. @returns the previous console echo on/off status 314

Re: RFR: 8184693: (opt) add Optional.isEmpty

Hi Vivek, Please add "@since 11" tags to the doc comments of the four Optional*.isEmpty() methods. Regarding the tests, I don't think the various newly added testIsEmpty() tests are useful. The setup in those test files already generates a fairly comprehensive set of Optional values from a

Re: Clean-room implementation of Double::toString(double) and Float::toString(float)

2018/4/12 1:12:36 -0700, raffaello.giulie...@gmail.com: > my code is now ready to be uploaded to the OpenJDK reps. Currently it > resides on GitHub and is under the "GPLv2 + Classpath Exception" > license, with myself as the copyright holder. > > I asked Oracle about how the copyright notice

Re: Clean-room implementation of Double::toString(double) and Float::toString(float)

On 16/04/2018 11:22 PM, Mario Torre wrote: 2018-04-12 10:12 GMT+02:00 Raffaello Giulietti : I asked Oracle about how the copyright notice should be adapted to meet the OCA requirements but, as of today, I got no answer. All the headers need to have a valid

Re: RFR: 8201609 - Split test/jdk/:tier2 to enable better parallel execution

Hi Alan > On Apr 16, 2018, at 4:14 05PM, Alan Bateman wrote: > > On 16/04/2018 19:15, Christian Tornqvist wrote: >> Please review this small change that splits the tier2 test group into three >> smaller test groups that can be executed in parallel. >> >> Webrev:

Re: RFR(S): 8201540: [AIX] Extend the set of supported charsets in java.base

On 16/04/2018 18:43, Xueming Shen wrote: It looks good to me. I agree, the main thing is that it's not adding charsets to java.base for the other builds. -Alan

Re: RFR: 8201609 - Split test/jdk/:tier2 to enable better parallel execution

On 16/04/2018 19:15, Christian Tornqvist wrote: Please review this small change that splits the tier2 test group into three smaller test groups that can be executed in parallel. Webrev: http://cr.openjdk.java.net/~ctornqvi/webrev/8201609/webrev.00/

Re: RFR: JDK-8194750,Console.readPassword does not save/restore tty settings

On 4/13/18, 8:04 PM, Martin Buchholz wrote: This is trickier than I expected, since you have to manage saving/restoring around each call to readPassword AND have an exit hook to restore in case the user never gets around to responding to the prompt. I see in the old code echo returns a

RFR: 8201609 - Split test/jdk/:tier2 to enable better parallel execution

Please review this small change that splits the tier2 test group into three smaller test groups that can be executed in parallel. Webrev: http://cr.openjdk.java.net/~ctornqvi/webrev/8201609/webrev.00/ Bug:

RE: RFR: 8184693: (opt) add Optional.isEmpty

Hi All, Please find the updated webrev http://cr.openjdk.java.net/~vtheeyarath/8184693/webrev.02/ . Here is the csr which I have raised for this change https://bugs.openjdk.java.net/browse/JDK-8201606 Regards Vivek -Original Message- From: Chris Hegarty Sent: Sunday, April 15,

Re: RFR(S): 8201540: [AIX] Extend the set of supported charsets in java.base

It looks good to me. -Sherman On 4/16/18, 4:10 AM, Bhaktavatsal R Maram wrote: Hi All, I've regenerated webrev using "hg rename" to create template files. webrev looks much neat now.. Thanks Alan for suggestion. webrev - http://cr.openjdk.java.net/~gromero/8201540/v2/ Thanks, Bhaktavatsal

Re: InetAddress.getByName/getAllByName for empty host string

Jaikiran, On 13/04/18 16:29, Jaikiran Pai wrote: Hi Chris, Thank you creating that JIRA. If the fix involves just updating the javadoc, is this something that youwould like me to contribute as a patch? I have a signed and approved OCA, but I will need a sponsor if I do come up with the

Re: Clean-room implementation of Double::toString(double) and Float::toString(float)

2018-04-12 10:12 GMT+02:00 Raffaello Giulietti : > I asked Oracle about how the copyright notice should be adapted to meet the > OCA requirements but, as of today, I got no answer. All the headers need to have a valid copyright text, you can just copy the headers

Re: 8201226 missing JNIEXPORT / JNICALL at some places in function declarations/implementations - was : RE: missing JNIEXPORT / JNICALL at some places in function declarations/implementations

On 2018-04-16 14:59, Alexey Ivanov wrote: Hi Matthias, Phil, The build of 32 bit Windows is broken because of mlib_image.dll. As JNICALL modifier has been added to function declarations, they're exported with a decorated name, for example _j2d_mlib_ImageCreate@16. The functions in this

Re: 8201226 missing JNIEXPORT / JNICALL at some places in function declarations/implementations - was : RE: missing JNIEXPORT / JNICALL at some places in function declarations/implementations

Hi Matthias, Phil, The build of 32 bit Windows is broken because of mlib_image.dll. As JNICALL modifier has been added to function declarations, they're exported with a decorated name, for example _j2d_mlib_ImageCreate@16. The functions in this library are looked up by their name [1] and

Re: RFR: JDK-8190187: C++ code calling JNI_CreateJavaVM can be killed by Java

Hi All, Here is the code to resolve JDK-8190187: http://cr.openjdk.java.net/~mhorie/8190187/hg_diff.txt Could a committer please take the fix and: 1) Complete the CSR process for the new JNI Return code. 2) Commit the changes that contain the Return code. And, optionally, 3) Perform 1 and

Re: RFR(S): 8201540: [AIX] Extend the set of supported charsets in java.base

Hi All, I've regenerated webrev using "hg rename" to create template files. webrev looks much neat now.. Thanks Alan for suggestion. webrev - http://cr.openjdk.java.net/~gromero/8201540/v2/ Thanks, Bhaktavatsal Reddy -"core-libs-dev" wrote: -

RFR: JDK-8190187: C++ code calling JNI_CreateJavaVM can be killed by Java

Hi All, I've attached the code to resolve JDK-8190187 Could a committer please take the fix (amended code attached, and available on request) and: 1) Complete the CSR process for the new JNI Return code. 2) Commit the changes that contain the Return code. And, optionally, 3) Perform 1 and

Re: [PATCH] RFR Bug-pending: Enable Hotspot to Track Native Memory Usage for Direct Byte Buffers

> On 13/04/2018 15:14, Adam Farley8 wrote: >> Hi Alan, Peter, >> >> I see that native memory is tracked in java.nio.Bits, but that only includes what the user thinks they are allocating. >> >> When the VM adds extra memory to the allocation amount this extra bit is not represented in the

Re: RFR(S): 8201540: [AIX] Extend the set of supported charsets in java.base

Hi Alan, I deleted IBM943C.java (using hg remove) and added new file IBM943C.java.template (using hg add). I now understand that using "hg rename" is giving more meaningful representation in webrev/index.html. I will re-generate webrev by renaming source files to templates using "hg rename"

Re: RFR(S): 8201540: [AIX] Extend the set of supported charsets in java.base

On 16/04/2018 09:22, Bhaktavatsal R Maram wrote: 3. Source files for IBM-942C and IBM-943C are changed to template to support #1 You might want to double check the webrev as it looks like you've added templates where as I assume you mean to use "hg rename" to rename IBM942C.java and

RFR(S): 8201540: [AIX] Extend the set of supported charsets in java.base

Hi All, Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8201540 webrev: http://cr.openjdk.java.net/~gromero/8201540/v1/webrev/ In this patch, 1. Default charsets Big5, Big5_Solaris, Big5_HKSCS, GB18030, IBM856, IBM921, IBM922, IBM942, IBM942C, IBM943, IBM943C, IBM950, IBM970,