RE: RFR: 8184693: (opt) add Optional.isEmpty

Hi Stuart, Done with the changes http://cr.openjdk.java.net/~vtheeyarath/8184693/webrev.05/ . Regards Vivek -Original Message- From: Stuart Marks Sent: Wednesday, April 18, 2018 8:56 AM To: Vivek Theeyarath Cc: core-libs-dev

Re: JDK 11 RFR of JDK-8201766: Mark TimSortStackSize2.java as intermittently failing

Looks fine to me Joe! Thanks, David On 18/04/2018 1:59 PM, joe darcy wrote: Hello, Please review the patch below to address     JDK-8201766: Mark TimSortStackSize2.java as intermittently failing which marks the test as failing intermittently and demotes it to tier 2 from tier 1. Thanks,

JDK 11 RFR of JDK-8201766: Mark TimSortStackSize2.java as intermittently failing

Hello, Please review the patch below to address     JDK-8201766: Mark TimSortStackSize2.java as intermittently failing which marks the test as failing intermittently and demotes it to tier 2 from tier 1. Thanks, -Joe diff -r 4c77b1453427 test/jdk/TEST.groups --- a/test/jdk/TEST.groups   

Re: RFR: 8184693: (opt) add Optional.isEmpty

Hi Vivek, Thanks for the update. In the test files, please remove the unnecessary imports of List and the various Predicate types. In most cases it's not a problem to have unnecessary imports. I happened to notice in this case that they're left over from the previous version of the webrev,

Re: RFR: 81820709 - Container Awareness JEP

On 4/3/18 10:09 PM, Bob Vandette wrote: WEBREV: http://cr.openjdk.java.net/~bobv/8182070/v01/webrev I reviewed the webrev and look okay in general. I will look through the javadoc next. Metrics.java 37 * 1. All processes, including the current process within a container. includes

Re: 8194734 : Handle to jimage file inherited into child processes (win)

Alan, thanks a lot for applying my patch! Now, do I need to try and remove the magic from Unix process creation code? Or you'd rather have it untouched?

[11] RFR: 8181157: CLDR Timezone name fallback implementation

Hello, Please review the changes to the following issue: https://bugs.openjdk.java.net/browse/JDK-8181157 The proposed fix is located at: http://cr.openjdk.java.net/~naoto/8181157/webrev.05/ This RFE is to implement CLDR time zone names fallback mechanism [1]. Prior to this fix, time zone

Re: RFR: 8201609 - Split test/jdk/:tier2 to enable better parallel execution

I’ll add a comment in TEST.groups referencing these bugs > On Apr 17, 2018, at 7:01 38AM, Alan Bateman wrote: > > On 17/04/2018 11:57, Seán Coffey wrote: >> The Cipher tests were re-grouped via >> https://bugs.openjdk.java.net/browse/JDK-8132855 >> >> NIO re-grouped

Re: RFR(S): 8201540: [AIX] Extend the set of supported charsets in java.base

Hi Volker, Thank you for reviewing the patch. > you change looks good, although I can't really verify all the charset > aliases. For example Wikipedia mentions that "ibm-932" is equivalent > to "ibm-942" [1] but you made it an alias for "ibm-942C". What's > actually the difference between

Re: RFR: JDK-8194750,Console.readPassword does not save/restore tty settings

On 04/17/2018 12:13 AM, Alan Bateman wrote: On 17/04/2018 06:15, Xueming Shen wrote: Thanks! webrev has been updated accordingly as suggested. http://cr.openjdk.java.net/~sherman/8194750/webrev Just catching on this one. The changes looks good, I'm just wondering if there is any way to

Re: RFR(S): 8201540: [AIX] Extend the set of supported charsets in java.base

Hi Bhaktavatsal Reddy, you change looks good, although I can't really verify all the charset aliases. For example Wikipedia mentions that "ibm-932" is equivalent to "ibm-942" [1] but you made it an alias for "ibm-942C". What's actually the difference between "ibm-942C" and "ibm-942"? I can

RE: RFR: 8184693: (opt) add Optional.isEmpty

Hi All, Please find the updated webrev http://cr.openjdk.java.net/~vtheeyarath/8184693/webrev.04 Regards Vivek -Original Message- From: Stuart Marks Sent: Tuesday, April 17, 2018 5:11 AM To: Vivek Theeyarath Cc: core-libs-dev

Re: RFR: 8201609 - Split test/jdk/:tier2 to enable better parallel execution

On 17/04/2018 11:57, Seán Coffey wrote: The Cipher tests were re-grouped via https://bugs.openjdk.java.net/browse/JDK-8132855 NIO re-grouped via https://bugs.openjdk.java.net/browse/JDK-8132854 All appears connected with exercising hotspot intrinsics in tier1 testing. Thanks for digging into

Re: RFR: 8201609 - Split test/jdk/:tier2 to enable better parallel execution

The Cipher tests were re-grouped via https://bugs.openjdk.java.net/browse/JDK-8132855 NIO re-grouped via https://bugs.openjdk.java.net/browse/JDK-8132854 All appears connected with exercising hotspot intrinsics in tier1 testing. regards, Sean. On 17/04/2018 08:10, Alan Bateman wrote: On

(M) RFR: 8200167: Validate more special case invocations

Bug: https://bugs.openjdk.java.net/browse/JDK-8200167 webrev: http://cr.openjdk.java.net/~dholmes/8200167/webrev/ Credit to John Rose and Vladimir Ivanov for the form of the MH fix; and to Tobias Hartmann for the C1 fix. Their help was very much appreciated (and needed!). tl;dr version:

Re: Clean-room implementation of Double::toString(double) and Float::toString(float)

Thanks Mark, in your position as the Chief Architect, Java Platform Group at Oracle, I take yours as the most authoritative answer I've got so far. Tomorrow I should find the time to finally upload the code. Thanks to everybody who kindly replied to this thread. Greetings Raffaello On

Re: RFR: JDK-8194750,Console.readPassword does not save/restore tty settings

On 17/04/2018 06:15, Xueming Shen wrote: Thanks! webrev has been updated accordingly as suggested. http://cr.openjdk.java.net/~sherman/8194750/webrev Just catching on this one. The changes looks good, I'm just wondering if there is any way to create a reliable test for this. -Alan

Re: RFR: 8201609 - Split test/jdk/:tier2 to enable better parallel execution

On 16/04/2018 21:20, Christian Tornqvist wrote: Do you know what sun/nio/cs/ISO8859x.java and com/sun/crypto/provider/Cipher are special cased? Just wondering if there is a historical or current reason to not run those. No idea. It would be useful to find out why is was setup like this, if

Re: RFR: JDK-8194750, Console.readPassword does not save/restore tty settings

Ship it!

Re: RFR: 8201609 - Split test/jdk/:tier2 to enable better parallel execution

Hi Christian, Regrouping of tests looks fine; cheers, -Joe PS Complementary changes for another day would be an effort to speed up long-running tests. On 4/16/2018 1:20 PM, Christian Tornqvist wrote: Hi Alan On Apr 16, 2018, at 4:14 05PM, Alan Bateman wrote: