Re: RFR: 8212995: Consider placing the Integer.IntegerCache and cached Integer objects in the closed archive heap region

Thanks! Jiangli On 11/2/18 5:15 PM, Ioi Lam wrote: Hi Jiangli, This looks good to me. Ship it! Thanks - Ioi On 11/2/18 10:57 AM, Jiangli Zhou wrote: Hi Ioi, Here is the updated webrev with the warning message below for the Integer cache.  

Re: RFR: 8212995: Consider placing the Integer.IntegerCache and cached Integer objects in the closed archive heap region

Hi Jiangli, This looks good to me. Ship it! Thanks - Ioi On 11/2/18 10:57 AM, Jiangli Zhou wrote: Hi Ioi, Here is the updated webrev with the warning message below for the Integer cache.   http://cr.openjdk.java.net/~jiangli/8212995/webrev.03/  995  *  996  * WARNING: The cache

[12] RFR: 8213330: Fix legal headers in i18n tests

Hello, Please review the fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-8213330 The proposed changeset is located at: http://cr.openjdk.java.net/~naoto/8213330/webrev.00/ It is to remove "Classpath exception" copyright phrase from i18n related test files. Naoto

Re: RFR(M) 8212605: Pure-Java implementation of AccessController.doPrivileged

Thanks Mandy.  I also appreciate you noticing (off-list) that I can remove the extra space in "Class " in several places.  I have updated webrev.4 in place. dl On 11/2/18 1:55 PM, Mandy Chung wrote: Hi Dean, I reviewed webrev.4 version.  It looks good.  Happy to see moving the doPrivileged

Re: RFR(M) 8212605: Pure-Java implementation of AccessController.doPrivileged

Hi Dean, I reviewed webrev.4 version.  It looks good.  Happy to see moving the doPrivileged support to Java and the performance improvement. On 10/31/18 3:23 PM, dean.l...@oracle.com wrote: https://bugs.openjdk.java.net/browse/JDK-8212605 http://cr.openjdk.java.net/~dlong/8212605/webrev.1

Re: 8213321: Fix legal headers in test/jaxp

Thanks all! On 11/2/18, 12:17 PM, Lance Andersen wrote: +1 -- Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive

Re: 8213321: Fix legal headers in test/jaxp

+1 -- Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPhone > On Nov 2, 2018, at 3:13 PM, Joe Wang wrote: > > Hi, > > Please review: > > JBS:

Re: 8213321: Fix legal headers in test/jaxp

+1 On 11/02/2018 12:13 PM, Joe Wang wrote: Hi, Please review: JBS: https://bugs.openjdk.java.net/browse/JDK-8213321 Changes: --- a/test/jaxp/javax/xml/jaxp/unittest/stream/XMLStreamWriterTest/SurrogatesTest.java +++

Re: 8213321: Fix legal headers in test/jaxp

+1 Cheers, -Joe On 11/2/2018 12:13 PM, Joe Wang wrote: Hi, Please review: JBS: https://bugs.openjdk.java.net/browse/JDK-8213321 Changes: --- a/test/jaxp/javax/xml/jaxp/unittest/stream/XMLStreamWriterTest/SurrogatesTest.java +++

8213321: Fix legal headers in test/jaxp

Hi, Please review: JBS: https://bugs.openjdk.java.net/browse/JDK-8213321 Changes: --- a/test/jaxp/javax/xml/jaxp/unittest/stream/XMLStreamWriterTest/SurrogatesTest.java +++ b/test/jaxp/javax/xml/jaxp/unittest/stream/XMLStreamWriterTest/SurrogatesTest.java @@ -4,9 +4,7 @@ * * This code

Re: RFR: 8212995: Consider placing the Integer.IntegerCache and cached Integer objects in the closed archive heap region

Hi Ioi, Here is the updated webrev with the warning message below for the Integer cache.   http://cr.openjdk.java.net/~jiangli/8212995/webrev.03/  995  *  996  * WARNING: The cache is archived with CDS and reloaded from the shared  997  * archive at runtime. The archived cache

Re: 8213305: Fix legal headers in test/java/math

+1 Thanks, -Joe On 11/2/2018 9:53 AM, Brian Burkhalter wrote: https://bugs.openjdk.java.net/browse/JDK-8213305 --- a/test/jdk/java/math/BigInteger/PrimeTest.java Fri Nov 02 16:11:29 2018 + +++

8213305: Fix legal headers in test/java/math

https://bugs.openjdk.java.net/browse/JDK-8213305 --- a/test/jdk/java/math/BigInteger/PrimeTest.java Fri Nov 02 16:11:29 2018 + +++ b/test/jdk/java/math/BigInteger/PrimeTest.java Fri Nov 02 09:49:34 2018 -0700 @@ -4,9 +4,7 @@ *

Re: 6516099: InputStream.skipFully(int k) to skip exactly k bytes

Hi Roger, > On Nov 2, 2018, at 8:03 AM, Roger Riggs wrote: > > The description of this implementation ("the default implementation...") > can be put in an @implSpec tag, since it specifies the behavior of this > method, and is not normative for all subclasses. That will make the 'normal' >

Re: 6516099: InputStream.skipFully(int k) to skip exactly k bytes

Hi Daniel, > On Nov 2, 2018, at 3:40 AM, Daniel Fuchs wrote: > > If skip(n) returns a negative number, e.g. -1, then you might > end up skipping more than n bytes (unless skip returning > -1 indicates that EOF was reached). I suppose you mean line 571: 571 if (n > 0 && (n -= skip(n))

Re: Review request: JDK-8211122: Reduce the number of internal classes made accessible to jdk.unsupported

On 11/2/18 9:16 AM, Alan Bateman wrote: On 02/11/2018 04:16, Mandy Chung wrote: This patch includes the following changes that will reduce the number of internal classes made accessible to jdk.unsupported module via qualified exports. 1. move shared secrets to a new jdk.internal.access

Re: [12] RFR: 8213301 - Fix legal headers in jdk logging tests

Looks good. Mandy On 11/2/18 8:38 AM, Daniel Fuchs wrote: Hi, Following Chris's lead in the network area, and Jon’s lead in the langtools area, here is a change to remove the "Classpath exception” from several test in the test/jdk logging area. 8213301: Fix legal headers in jdk logging tests

Re: Review request: JDK-8211122: Reduce the number of internal classes made accessible to jdk.unsupported

On 02/11/2018 04:16, Mandy Chung wrote: This patch includes the following changes that will reduce the number of internal classes made accessible to jdk.unsupported module via qualified exports. 1. move shared secrets to a new jdk.internal.access package. jdk.internal.misc package has been a

Re: [12] RFR: 8213301 - Fix legal headers in jdk logging tests

> On 2 Nov 2018, at 15:38, Daniel Fuchs wrote: > > Hi, > > Following Chris's lead in the network area, and Jon’s lead > in the langtools area, here is a change to remove the > "Classpath exception” from several test in the > test/jdk logging area. > > 8213301: Fix legal headers in jdk

Re: Review request: JDK-8211122: Reduce the number of internal classes made accessible to jdk.unsupported

On 11/2/18 3:18 AM, Daniel Fuchs wrote: Hi Mandy, I won't comment on the approach, though [1] looks more cryptic to me as it includes suspicious native code changes. The native code change should have been separated from this fix.  It attempts to remove

[12] RFR: 8213301 - Fix legal headers in jdk logging tests

Hi, Following Chris's lead in the network area, and Jon’s lead in the langtools area, here is a change to remove the "Classpath exception” from several test in the test/jdk logging area. 8213301: Fix legal headers in jdk logging tests https://bugs.openjdk.java.net/browse/JDK-8213301

Re: 6516099: InputStream.skipFully(int k) to skip exactly k bytes

Hi Brian, The description of this implementation ("the default implementation...") can be put in an @implSpec tag, since it specifies the behavior of this method, and is not normative for all subclasses.  That will make the 'normal' behavior of the method easier to understand. As Daniel

Re: 6516099: InputStream.skipFully(int k) to skip exactly k bytes

Hi Brian, If skip(n) returns a negative number, e.g. -1, then you might end up skipping more than n bytes (unless skip returning -1 indicates that EOF was reached). Basically, I don't think you can make any guarantee of how many bytes will be skipped if a subclass has an implementation of skip

Re: Review request: JDK-8211122: Reduce the number of internal classes made accessible to jdk.unsupported

Hi Mandy, I won't comment on the approach, though [1] looks more cryptic to me as it includes suspicious native code changes. I skimmed through the patch file at http://cr.openjdk.java.net/~mchung/jdk12/webrevs/8211122/webrev.02/open.patch and haven't noticed anything wrong at first sight. The