Re: RFR: 8266054: VectorAPI rotate operation optimization [v4]

2021-05-07 Thread Jatin Bhateja
On Fri, 7 May 2021 18:31:15 GMT, Jatin Bhateja wrote: >> Current VectorAPI Java side implementation expresses rotateLeft and >> rotateRight operation using following operations:- >> >> vec1 = lanewise(VectorOperators.LSHL, n) >> vec2 = lanewise(VectorOperators.LSHR, n) >> res = lane

Re: RFR: 8266054: VectorAPI rotate operation optimization [v5]

2021-05-07 Thread Jatin Bhateja
> Current VectorAPI Java side implementation expresses rotateLeft and > rotateRight operation using following operations:- > > vec1 = lanewise(VectorOperators.LSHL, n) > vec2 = lanewise(VectorOperators.LSHR, n) > res = lanewise(VectorOperations.OR, vec1 , vec2) > > This patch moves a

Re: RFR: 8265518: C1: Intrinsic support for Preconditions.checkIndex [v6]

2021-05-07 Thread Yi Yang
On Fri, 30 Apr 2021 19:20:54 GMT, Igor Veresov wrote: > Looks like now the test fails in the pre-submit tests? Hi Igor, Can you take a look at the latest version? Now it passes all pre-submit tests. Best Regards, Yang - PR: https://git.openjdk.java.net/jdk/pull/3615

Re: RFR: 8265518: C1: Intrinsic support for Preconditions.checkIndex [v6]

2021-05-07 Thread Yi Yang
On Fri, 30 Apr 2021 17:30:33 GMT, Paul Sandoz wrote: > It was my hope this would eventually happen when we added > `Objects.checkIndex` and the underlying intrinsic. Very good! Hi Paul, Thank you for noticing this PR. > It was my hope this would eventually happen when we added > `Objects.chec

Re: RFR: 8265518: C1: Intrinsic support for Preconditions.checkIndex [v9]

2021-05-07 Thread Yi Yang
> The JDK codebase re-created many variants of checkIndex(`grep -I -r > 'cehckIndex' jdk/`). A notable variant is java.nio.Buffer.checkIndex, which > annotated with @IntrinsicCandidate and it only has a corresponding C1 > intrinsic version. > > In fact, there is an utility method > `jdk.intern

Re: RFR: 8266456: Replace direct TKit.run() calls with jdk.jpackage.test.Annotations.Test annotation [v2]

2021-05-07 Thread Alexander Matveev
> - Replaced direct TKit.run() calls with Test annotation. > - Increased timeout for SigningPackageTest from default to 360 due to > timeout. This is regression from JDK-8248904 due to changes done in signing > and --remove-signature adds additional time since it is run per file. > - Fixed issu

Re: RFR: 8266774: System property values for stdout/err on Windows UTF-8

2021-05-07 Thread Brian Burkhalter
On Fri, 7 May 2021 22:46:08 GMT, Naoto Sato wrote: > Please review this small fix to Windows system property init code. This is > leftover from the support for `Console.charset()` method, where it lacked to > initialize `sun.stdout/err.encoding` to `UTF-8` for the code page `cp65001`. > The f

RFR: 8266774: System property values for stdout/err on Windows UTF-8

2021-05-07 Thread Naoto Sato
Please review this small fix to Windows system property init code. This is leftover from the support for `Console.charset()` method, where it lacked to initialize `sun.stdout/err.encoding` to `UTF-8` for the code page `cp65001`. The fix has been manually verified, but no automated test case is

Re: RFR: 8266603: jpackage: Add missing copyright file in Java runtime .deb installers [v2]

2021-05-07 Thread Alexander Matveev
On Fri, 7 May 2021 19:57:17 GMT, Alexey Semenyuk wrote: >> jpackage should create copyright file in /usr/share/doc directory tree when >> building .deb package for Java runtime with installation directory in /usr >> directory tree. >> >> jpackage creates share/doc/copyright file in installatio

Re: RFR: 8266456: Replace direct TKit.run() calls with jdk.jpackage.test.Annotations.Test annotation

2021-05-07 Thread Alexander Matveev
On Fri, 7 May 2021 16:50:15 GMT, Alexey Semenyuk wrote: >> - Replaced direct TKit.run() calls with Test annotation. >> - Increased timeout for SigningPackageTest from default to 360 due to >> timeout. This is regression from JDK-8248904 due to changes done in signing >> and --remove-signature

Re: RFR: 8266456: Replace direct TKit.run() calls with jdk.jpackage.test.Annotations.Test annotation

2021-05-07 Thread Alexander Matveev
On Fri, 7 May 2021 02:48:44 GMT, Alexander Matveev wrote: > - Replaced direct TKit.run() calls with Test annotation. > - Increased timeout for SigningPackageTest from default to 360 due to > timeout. This is regression from JDK-8248904 due to changes done in signing > and --remove-signature ad

Re: RFR: 8266054: VectorAPI rotate operation optimization [v4]

2021-05-07 Thread Paul Sandoz
On Fri, 7 May 2021 18:31:15 GMT, Jatin Bhateja wrote: >> Current VectorAPI Java side implementation expresses rotateLeft and >> rotateRight operation using following operations:- >> >> vec1 = lanewise(VectorOperators.LSHL, n) >> vec2 = lanewise(VectorOperators.LSHR, n) >> res = lane

Re: RFR: 8255035: Update BCEL to Version 6.5.0

2021-05-07 Thread Lance Andersen
On Thu, 6 May 2021 00:17:40 GMT, Joe Wang wrote: > Update BCEL to the latest version (6.5.0). The majority of the changes were > code refactoring (name format changes). > > XML tests passed on both Linux and Windows. Marked as reviewed by lancea (Reviewer). - PR: https://git.open

RFR: 8266766: Arrays of types that cannot be an annotation member do not yield exceptions

2021-05-07 Thread Rafael Winterhalter
If a type is changed from a type that can be a member of an annotation which is used in an array, changing it to a type that cannot be an array member will be treated as if the type is an annotation type. As a result, no exception proxy is created and the type is returned as if it was correctly

Re: RFR: 8266603: jpackage: Add missing copyright file in Java runtime .deb installers [v2]

2021-05-07 Thread Alexey Semenyuk
> jpackage should create copyright file in /usr/share/doc directory tree when > building .deb package for Java runtime with installation directory in /usr > directory tree. > > jpackage creates share/doc/copyright file in installation directory for apps > installed outside of /usr tree. > > jp

Re: RFR: 8266054: VectorAPI rotate operation optimization [v4]

2021-05-07 Thread Jatin Bhateja
> Current VectorAPI Java side implementation expresses rotateLeft and > rotateRight operation using following operations:- > > vec1 = lanewise(VectorOperators.LSHL, n) > vec2 = lanewise(VectorOperators.LSHR, n) > res = lanewise(VectorOperations.OR, vec1 , vec2) > > This patch moves a

RFR: 8266603: jpackage: Add missing copyright file in Java runtime .deb installers

2021-05-07 Thread Alexey Semenyuk
jpackage should create copyright file in /usr/share/doc directory tree when building .deb package for Java runtime with installation directory in /usr directory tree. jpackage creates share/doc/copyright file in installation directory for apps installed outside of /usr tree. jpackage creates /

Re: RFR: 8266456: Replace direct TKit.run() calls with jdk.jpackage.test.Annotations.Test annotation

2021-05-07 Thread Alexey Semenyuk
On Fri, 7 May 2021 02:48:44 GMT, Alexander Matveev wrote: > - Replaced direct TKit.run() calls with Test annotation. > - Increased timeout for SigningPackageTest from default to 360 due to > timeout. This is regression from JDK-8248904 due to changes done in signing > and --remove-signature ad

Re: RFR: 8264777: Overload optimized FileInputStream::readAllBytes [v6]

2021-05-07 Thread Brian Burkhalter
On Thu, 6 May 2021 16:40:31 GMT, Brian Burkhalter wrote: >> Please consider this request to override the `java.io.InputStream` methods >> `readAllBytes()` and `readNBytes(int)` in `FileInputStream` with more >> performant implementations. The method overrides attempt to read all >> requested b

Re: RFR: 8266610: Method RandomAccessFile#length() returns 0 for block devices on linux. [v2]

2021-05-07 Thread Brian Burkhalter
On Fri, 7 May 2021 12:17:11 GMT, Vyom Tewari wrote: >> RandomAccessFile.length() method for block device return always 0 > > Vyom Tewari has updated the pull request incrementally with one additional > commit since the last revision: > > fixed assigning -1 to uint64_t Covers updated `FileInp

Re: RFR: 8266622: Optimize Class.descriptorString() and Class.getCanonicalName0()

2021-05-07 Thread Peter Levart
On Thu, 6 May 2021 16:34:04 GMT, Peter Levart wrote: >> Hello, from discussion in https://github.com/openjdk/jdk/pull/3464 and >> https://github.com/openjdk/jdk/pull/2212 it appears, that in `j.l.Class` >> expressions like >> >> String str = baseName.replace('.', '/') + '/' + name; >> >> are

Re: RFR: 8266610: Method RandomAccessFile#length() returns 0 for block devices on linux. [v2]

2021-05-07 Thread Alan Bateman
On Fri, 7 May 2021 12:17:11 GMT, Vyom Tewari wrote: >> RandomAccessFile.length() method for block device return always 0 > > Vyom Tewari has updated the pull request incrementally with one additional > commit since the last revision: > > fixed assigning -1 to uint64_t I think this look okay,

Integrated: 8266646: Add more diagnostic to java/lang/System/LoggerFinder/modules

2021-05-07 Thread Daniel Fuchs
On Thu, 6 May 2021 15:25:10 GMT, Daniel Fuchs wrote: > Hi, please find here a trivial test change that adds some diagnostic (time > stamps) to the LoggerFinder/modules subprocess test logs. This pull request has now been integrated. Changeset: 3fcdc50e Author:Daniel Fuchs URL: http

Re: RFR: 8266610: Method RandomAccessFile#length() returns 0 for block devices on linux. [v2]

2021-05-07 Thread Vyom Tewari
> RandomAccessFile.length() method for block device return always 0 Vyom Tewari has updated the pull request incrementally with one additional commit since the last revision: fixed assigning -1 to uint64_t - Changes: - all: https://git.openjdk.java.net/jdk/pull/3914/files - n

Re: RFR: 8264774: Implementation of Foreign Function and Memory API (Incubator) [v13]

2021-05-07 Thread Maurizio Cimadamore
> This PR contains the API and implementation changes for JEP-412 [1]. A more > detailed description of such changes, to avoid repetitions during the review > process, is included as a separate comment. > > [1] - https://openjdk.java.net/jeps/412 Maurizio Cimadamore has updated the pull request

Re: RFR: 8264774: Implementation of Foreign Function and Memory API (Incubator) [v12]

2021-05-07 Thread Alan Bateman
On Thu, 6 May 2021 14:23:27 GMT, Maurizio Cimadamore wrote: >> This PR contains the API and implementation changes for JEP-412 [1]. A more >> detailed description of such changes, to avoid repetitions during the review >> process, is included as a separate comment. >> >> [1] - https://openjdk

Re: RFR: 8254598: StringDedupTable should use OopStorage [v2]

2021-05-07 Thread Kim Barrett
On Tue, 4 May 2021 11:46:21 GMT, Thomas Schatzl wrote: >> Kim Barrett has updated the pull request incrementally with three additional >> commits since the last revision: >> >> - more comment improvements >> - improve naming and comments around injected String flags >> - fix some typos in co

Re: RFR: 8254598: StringDedupTable should use OopStorage [v2]

2021-05-07 Thread Kim Barrett
On Tue, 4 May 2021 11:47:25 GMT, Thomas Schatzl wrote: >> Kim Barrett has updated the pull request incrementally with three additional >> commits since the last revision: >> >> - more comment improvements >> - improve naming and comments around injected String flags >> - fix some typos in co

Re: RFR: 8254598: StringDedupTable should use OopStorage [v2]

2021-05-07 Thread Kim Barrett
> Please review this change to the String Deduplication facility. It is being > changed to use OopStorage to hold weak references to relevant objects, > rather than bespoke data structures requiring dedicated processing phases by > supporting GCs. > > (The Shenandoah update was contributed by Zhe

Re: RFR: 8254598: StringDedupTable should use OopStorage

2021-05-07 Thread Kim Barrett
On Fri, 23 Apr 2021 19:48:47 GMT, Kim Barrett wrote: > Please review this change to the String Deduplication facility. It is being > changed to use OopStorage to hold weak references to relevant objects, > rather than bespoke data structures requiring dedicated processing phases by > supporting

Re: RFR: 8265768 [aarch64] Use glibc libm impl for dlog, dlog10, dexp iff 2.29 or greater on AArch64.

2021-05-07 Thread Andrew Haley
On Thu, 29 Apr 2021 20:24:25 GMT, Carlos O'Donell wrote: > Where does the requirement for monotonicity come from? Semi-monotonicity, to be precise. In the spec of java.lang.Math, "Besides accuracy at individual arguments, maintaining proper relations between the method at different arguments