I'm certain that uses of RC/RS will be rare in the beginning, because they will
be
new, and people won't be familar with them. And then there will the people who
say
"I can't use them because I'm stuck on JDK 11 / 8 / 7 / 6 " It was the same
thing with lambdas and streams in Java 8, with
On Tue, 11 May 2021 14:13:49 GMT, Harold Seigel wrote:
>> Please review this large change to remove Unsafe::defineAnonymousClass().
>> The change removes dAC relevant code and changes a lot of tests. Many of
>> the changed tests need renaming. I hope to do this in a follow up RFE.
>> Some
On 5/10/21 3:31 AM, Remi Forax wrote:
Thinking a little more about conflating "first" and "any".
I wonder if we have not already cross the Rubicon on that matter,
If we have a HashSet or any collections and using Stream.findFirst()
var collection = new HashSet<>(...);
var result =
On Tue, 11 May 2021 17:38:36 GMT, Mandy Chung wrote:
> Add a test to verify that hidden class's members are not statically invocable
> based on
> test/jdk/java/lang/invoke/VMAnonymousClass.java.
This pull request has now been integrated.
Changeset: cc03734b
Author:Mandy Chung
URL:
On 5/1/21 7:36 AM, Peter Levart wrote:
On 4/30/21 9:25 PM, Stuart Marks wrote:
So I think we're stuck with void-returning add{First,Last} methods.
Have you thought of perhaps not adding them at all?
Collection.add() for:
List(s) - behaves the same as addLast()
LinkedHashSet - behaves
> Update module summary, add a few existing properties and features into the
> tables.
Joe Wang has updated the pull request incrementally with one additional commit
since the last revision:
Add legacy property names table
-
Changes:
- all:
On Thu, 6 May 2021 00:17:40 GMT, Joe Wang wrote:
> Update BCEL to the latest version (6.5.0). The majority of the changes were
> code refactoring (name format changes).
>
> XML tests passed on both Linux and Windows.
This pull request has now been integrated.
Changeset: 1a0ff28e
Author:
On Mon, 10 May 2021 23:12:04 GMT, Naoto Sato wrote:
> Please review this test case fix for the upcoming jtreg 6. The test was using
> `@BeforeGroups` annotation, and the behavior of it has changed in TestNG 7.1
> so that it is only issued when the test was configured with filtering.
> Changed
On 5/11/21 3:14 PM, Remi Forax wrote:
Hi Mandy,
impressive work !
I think that the method that are a caller-sensitive adapter (the one that takes
a supplementary class as last parameter) should be annotated with a specific
JDK internal annotation,
so the link between the caller sensitive
On 5/11/21 2:01 PM, Brian Goetz wrote:
Yes, please!
To add to the list of motivations/things to remove: the current
implementation relies on the special `MagicAccessorImpl` to relax
accessibility. The notes in this class are frightening; getting rid
of it would be a mercy.
Thanks,
Hi Mandy,
impressive work !
I think that the method that are a caller-sensitive adapter (the one that takes
a supplementary class as last parameter) should be annotated with a specific
JDK internal annotation,
so the link between the caller sensitive method and it's adapter is obvious for
the
On Fri, 7 May 2021 02:48:44 GMT, Alexander Matveev wrote:
> - Replaced direct TKit.run() calls with Test annotation.
> - Increased timeout for SigningPackageTest from default to 360 due to
> timeout. This is regression from JDK-8248904 due to changes done in signing
> and --remove-signature
Yes, please!
To add to the list of motivations/things to remove: the current
implementation relies on the special `MagicAccessorImpl` to relax
accessibility. The notes in this class are frightening; getting rid of
it would be a mercy.
On 5/11/2021 4:42 PM, Mandy Chung wrote:
This draft
On Tue, 11 May 2021 14:13:49 GMT, Harold Seigel wrote:
>> Please review this large change to remove Unsafe::defineAnonymousClass().
>> The change removes dAC relevant code and changes a lot of tests. Many of
>> the changed tests need renaming. I hope to do this in a follow up RFE.
>> Some
>
> Can you check if you are using an exploded build? In the output directly
> you need to configure the IDE to use images/jdk for an images-build.
> Also part of the issue may be an IDE bug where it puts the directories
> for all the system modules on the class path.
>
> -Alan
Hi, looks like
This draft JEP is a proposal to reimplement core reflection on top of
method handles:
https://bugs.openjdk.java.net/browse/JDK-8266010
Feedback is welcome. The prototype is at [1].
Mandy
[1] https://github.com/mlchung/jdk/tree/reimplement-method-invoke
Hi Attila,
Thanks for the input. I added the Nashorn use case in JDK-8212620.
Mandy
On 5/11/21 3:41 AM, Attila Szegedi wrote:
I'm fine with the removal, although if you remember we use it in
Nashorn too[0], and when I tried to replace it with the hidden classes
facility the issue we run
On Tue, 11 May 2021 16:48:28 GMT, Mandy Chung wrote:
> Data provider with varargs does not work on TestNG 7.4.0. Fix the test to
> create an object array instead of varargs to workaround this issue.
This pull request has now been integrated.
Changeset: dfe8833f
Author:Mandy Chung
URL:
On Thu, 6 May 2021 11:52:09 GMT, Ignasi Marimon-Clos
wrote:
>> @ignasi35 I have created JDK-8266578. Please change the name of this PR to:
>>
>> `8266578: Disambiguate BigDecimal description of scale`
>>
>> Please resolve any conflicts and commit the updated file. Once the update is
>>
On Fri, 30 Apr 2021 16:11:30 GMT, Ichiroh Takiguchi
wrote:
>> When an invalid character is converted by getBytes() method, the character
>> is converted to replacement byte data.
>> Shift code (SO/SI) may not be added into right place by EBCDIC Mix charset.
>> EBCDIC Mix charset encoder is
On Tue, 4 May 2021 13:07:34 GMT, Jason Zaugg wrote:
> If the given Path represents a file, use the overload of read defined
> in FileChannel that accepts an explicit position and avoid serializing
> reads.
>
> Note: The underlying NIO implementation is not required to implement
>
On Tue, 11 May 2021 17:38:36 GMT, Mandy Chung wrote:
> Add a test to verify that hidden class's members are not statically invocable
> based on
> test/jdk/java/lang/invoke/VMAnonymousClass.java.
Marked as reviewed by alanb (Reviewer).
-
PR:
Hi Mitsuru,
Thank you for your interest in contributing to the OpenJDK project
If you are not an Author, you can file bugs via
https://bugreport.java.com/bugreport/
To contribute fixes, you will need to sign an Oracle Committer Agreement(OCA).
Please see https://openjdk.java.net/contribute/
Add a test to verify that hidden class's members are not statically invocable
based on
test/jdk/java/lang/invoke/VMAnonymousClass.java.
-
Commit messages:
- 8266925: Add a test to verify that hidden class's members are not statically
invocable
Changes:
On Tue, 11 May 2021 16:48:28 GMT, Mandy Chung wrote:
> Data provider with varargs does not work on TestNG 7.4.0. Fix the test to
> create an object array instead of varargs to workaround this issue.
Marked as reviewed by iris (Reviewer).
-
PR:
On Tue, 11 May 2021 16:32:25 GMT, Joe Wang wrote:
>> Update BCEL to the latest version (6.5.0). The majority of the changes were
>> code refactoring (name format changes).
>>
>> XML tests passed on both Linux and Windows.
>
> Joe Wang has updated the pull request incrementally with one
On Tue, 11 May 2021 16:48:28 GMT, Mandy Chung wrote:
> Data provider with varargs does not work on TestNG 7.4.0. Fix the test to
> create an object array instead of varargs to workaround this issue.
Yes, fixing these is indeed looking more comfortable
-
PR:
On Tue, 11 May 2021 14:13:49 GMT, Harold Seigel wrote:
>> Please review this large change to remove Unsafe::defineAnonymousClass().
>> The change removes dAC relevant code and changes a lot of tests. Many of
>> the changed tests need renaming. I hope to do this in a follow up RFE.
>> Some
On Tue, 11 May 2021 16:48:28 GMT, Mandy Chung wrote:
> Data provider with varargs does not work on TestNG 7.4.0. Fix the test to
> create an object array instead of varargs to workaround this issue.
All those backslashes hurt my eyes. Could we please use forward slashes, both
in the commit
Data provider with varargs does not work on TestNG 7.4.0. Fix the test to
create an object array instead of varargs to workaround this issue.
-
Commit messages:
- 8266783: java\lang\reflect\Proxy\DefaultMethods.java fails with jtreg 6
Changes:
On 11/05/2021 17:04, Сергей Цыпанов wrote:
Hello
I've run into performance drop-down when using Class.gerResource().
When I run the following benchmark with JDK 16 downloaded from the internet
@State(Scope.Benchmark)
@BenchmarkMode(Mode.AverageTime)
@OutputTimeUnit(TimeUnit.NANOSECONDS)
> Update BCEL to the latest version (6.5.0). The majority of the changes were
> code refactoring (name format changes).
>
> XML tests passed on both Linux and Windows.
Joe Wang has updated the pull request incrementally with one additional commit
since the last revision:
update MD file
Hello
I've run into performance drop-down when using Class.gerResource().
When I run the following benchmark with JDK 16 downloaded from the internet
@State(Scope.Benchmark)
@BenchmarkMode(Mode.AverageTime)
@OutputTimeUnit(TimeUnit.NANOSECONDS)
@Fork(jvmArgsAppend = {"-Xms2g", "-Xmx2g"})
public
On Mon, 10 May 2021 23:25:46 GMT, Liam Miller-Cushon wrote:
> 8266857: PipedOutputStream.sink should be volatile
This pull request has now been integrated.
Changeset: d0daa725
Author:Liam Miller-Cushon
URL:
On Tue, 11 May 2021 10:19:52 GMT, Daniel Fuchs wrote:
> For correctness (and peace of mind)- we should probably introduce a local
> variable in all the places where `sink` is read more than once outside of a
> synchronized block
Done, thanks!
-
PR:
On Tue, 11 May 2021 15:47:37 GMT, Liam Miller-Cushon wrote:
>> 8266857: PipedOutputStream.sink should be volatile
>
> Liam Miller-Cushon has refreshed the contents of this pull request, and
> previous commits have been removed. The incremental views will show
> differences compared to the
> 8266857: PipedOutputStream.sink should be volatile
Liam Miller-Cushon has refreshed the contents of this pull request, and
previous commits have been removed. The incremental views will show differences
compared to the previous content of the PR. The pull request contains one new
commit
There is a tiny probability that the `Random` objects in the 2 child processes
might be created at the same nano time and they will always produce the same
output and the game will never end. This code change explicitly provides them
with different seeds.
-
Commit messages:
-
On Tue, 11 May 2021 15:04:25 GMT, Weijun Wang wrote:
> There is a tiny probability that the `Random` objects in the 2 child
> processes might be created at the same nano time and they will always produce
> the same output and the game will never end. This code change explicitly
> provides
On Tue, 11 May 2021 15:04:25 GMT, Weijun Wang wrote:
> There is a tiny probability that the `Random` objects in the 2 child
> processes might be created at the same nano time and they will always produce
> the same output and the game will never end. This code change explicitly
> provides
On Tue, 11 May 2021 03:40:19 GMT, Alexander Matveev
wrote:
>> - Replaced direct TKit.run() calls with Test annotation.
>> - Increased timeout for SigningPackageTest from default to 360 due to
>> timeout. This is regression from JDK-8248904 due to changes done in signing
>> and
Hi,
Please see the sample code below.
SerialBlob sb = new SerialBlob(new byte[]{1, 2, 3});
System.out.println(Arrays.toString(sb.getBytes(3, 3)));
I think that it should output "[3]" but the current implementation
throws ArrayIndexOutOfBoundsException.
If it's worth changing, could anyone
Hello, please review this small Sonar finding.
Sonar reports a potential NULL pointer dereference here :
https://sonarcloud.io/project/issues?id=shipilev_jdk=c=AXck8CPLBBG2CXpcnh_z=false=MAJOR=BUG
"Access to field 'item' results in a dereference of a null pointer (loaded from
variable 'new')"
It
On Tue, 4 May 2021 16:41:44 GMT, Jan Lahoda wrote:
> This is a preview of a patch implementing JEP 406: Pattern Matching for
> switch (Preview):
> https://bugs.openjdk.java.net/browse/JDK-8213076
>
> The current draft of the specification is here:
>
On Tue, 11 May 2021 13:41:53 GMT, Alan Bateman wrote:
>> test/jdk/java/lang/Class/GetModuleTest.java line 42:
>>
>>> 40: import static org.testng.Assert.*;
>>> 41:
>>> 42: public class GetModuleTest {
>>
>> testGetModuleOnVMAnonymousClass is the only test here that uses ASM so you
>> can
Hi Brian,
Thanks for looking at this.
The JDK no longer creates unsafe anon classes. So, those tests could
only find an unsafe anonymous class if they explicitly created one. In
which case, the tests would need to call Unsafe.defineAnonymousClass().
And, hopefully, those tests have been
> Please review this large change to remove Unsafe::defineAnonymousClass().
> The change removes dAC relevant code and changes a lot of tests. Many of the
> changed tests need renaming. I hope to do this in a follow up RFE. Some of
> the tests were modified to use hidden classes, others
> Please review this large change to remove Unsafe::defineAnonymousClass().
> The change removes dAC relevant code and changes a lot of tests. Many of the
> changed tests need renaming. I hope to do this in a follow up RFE. Some of
> the tests were modified to use hidden classes, others
On Tue, 4 May 2021 16:41:44 GMT, Jan Lahoda wrote:
> This is a preview of a patch implementing JEP 406: Pattern Matching for
> switch (Preview):
> https://bugs.openjdk.java.net/browse/JDK-8213076
>
> The current draft of the specification is here:
>
Hi,
Please see the sample code below.
SerialBlob sb1 = new SerialBlob(new byte[]{1, 2, 3});
SerialBlob sb2 = new SerialBlob(new byte[]{1, 2, 3, 4, 5});
sb2.truncate(3);
System.out.println(sb1.equals(sb2));
System.out.println(sb1.hashCode() == sb2.hashCode());
I think that it should output
- Mail original -
> De: "Peter Levart"
> À: "Remi Forax" , "dfranken jdk"
> Cc: "Stuart Marks" , "core-libs-dev"
>
> Envoyé: Mardi 11 Mai 2021 13:44:08
> Objet: Re: [External] : Re: ReversibleCollection proposal
> Hi Remi,
Hi Peter,
>
>
> I see you avoided addFirst/addLast
On Tue, 11 May 2021 13:37:32 GMT, Alan Bateman wrote:
>> Please review this large change to remove Unsafe::defineAnonymousClass().
>> The change removes dAC relevant code and changes a lot of tests. Many of
>> the changed tests need renaming. I hope to do this in a follow up RFE.
>> Some
On Tue, 4 May 2021 20:35:45 GMT, Maurizio Cimadamore
wrote:
>> This is a preview of a patch implementing JEP 406: Pattern Matching for
>> switch (Preview):
>> https://bugs.openjdk.java.net/browse/JDK-8213076
>>
>> The current draft of the specification is here:
>>
On Tue, 4 May 2021 20:48:34 GMT, Maurizio Cimadamore
wrote:
>> This is a preview of a patch implementing JEP 406: Pattern Matching for
>> switch (Preview):
>> https://bugs.openjdk.java.net/browse/JDK-8213076
>>
>> The current draft of the specification is here:
>>
This is a preview of a patch implementing JEP 406: Pattern Matching for switch
(Preview):
https://bugs.openjdk.java.net/browse/JDK-8213076
The current draft of the specification is here:
http://cr.openjdk.java.net/~gbierman/jep406/jep406-20210430/specs/patterns-switch-jls.html
A summary of
On Tue, 4 May 2021 16:41:44 GMT, Jan Lahoda wrote:
> This is a preview of a patch implementing JEP 406: Pattern Matching for
> switch (Preview):
> https://bugs.openjdk.java.net/browse/JDK-8213076
>
> The current draft of the specification is here:
>
On Tue, 11 May 2021 12:50:31 GMT, Harold Seigel wrote:
> Please review this large change to remove Unsafe::defineAnonymousClass().
> The change removes dAC relevant code and changes a lot of tests. Many of the
> changed tests need renaming. I hope to do this in a follow up RFE. Some of
>
On Tue, 11 May 2021 13:10:30 GMT, Aleksei Voitylov
wrote:
> Please review this PR which fixes the deadlock in ClassLoader between the two
> lock objects - a lock object associated with the class being loaded, and the
> ClassLoader.loadedLibraryNames hash map, locked during the native library
On 2021. May 11., at 1:51, Thiago Henrique Hupner wrote:
>
> Hi all.
>
> I've been testing the JDK Dynalink recently and
> I think I've found a bug.
>
> The class jdk.dynalink.beans.CheckRestrictedPackage checks
> if a package is restricted.
>
> So, I have a class that has some static
Please review this PR which fixes the deadlock in ClassLoader between the two
lock objects - a lock object associated with the class being loaded, and the
ClassLoader.loadedLibraryNames hash map, locked during the native library load
operation.
Problem being fixed:
The initial reproducer
There may be some JDK code that checks for anon classes by comparing the name
to see if it contains a slash, especially tests, but which don’t say
“anonymous”. Did you do a search for these idioms too, which are now dead
tests?
Sent from my iPad
> On May 11, 2021, at 8:59 AM, Harold Seigel
Hi,
While reading the source for SerialBlob, I found that
SerialBlob.position() does not work correctly.
So, I searched JBS and found the description in JDK-4991002 point 1, but
it was closed by Cannot Reproduce.
It can be reproduced easily like below.
SerialBlob sb = new SerialBlob(new
Hi,
While reading the SerialBlob source, I found that it's been over a year
and a half since the JDK-8153490 was last updated.
Furthermore, according to the documentation of Blog.setBytes() (not
SerialBlob.setBytes()), there are the following problems:
1. It says "If the end of the Blob
Please review this large change to remove Unsafe::defineAnonymousClass(). The
change removes dAC relevant code and changes a lot of tests. Many of the
changed tests need renaming. I hope to do this in a follow up RFE. Some of
the tests were modified to use hidden classes, others were
Hi Remi,
I see you avoided addFirst/addLast methods. While getFirst/removeFirst
could be specified to be consistent with iterator().next(), so the
"first" part of the name would be softer, addFirst is cursed two times:
it has no equivalent in current API and it clashes with void returning
I'm fine with the removal, although if you remember we use it in Nashorn
too[0], and when I tried to replace it with the hidden classes facility the
issue we run into was that hidden classes' methods didn't show up in stack
traces the way anonymous classes' methods did[1]. Since Nashorn uses
On Mon, 10 May 2021 23:25:46 GMT, Liam Miller-Cushon wrote:
> 8266857: PipedOutputStream.sink should be volatile
For correctness (and peace of mind)- we should probably introduce a local
variable in all the places where `sink` is read more than once outside of a
synchronized block (the two
- Mail original -
> De: "dfranken jdk"
> À: "Remi Forax"
> Cc: "Stuart Marks" , "core-libs-dev"
>
> Envoyé: Mardi 11 Mai 2021 08:45:15
> Objet: Re: [External] : Re: ReversibleCollection proposal
> Dear mr. Forax,
Hi Dave,
>
> I understand your point of view. You don't like to have
Dear mr. Forax,
I understand your point of view. You don't like to have separate
standalone interfaces for things that seem to belong in a hierarchy, is
that correct? Now that I thought about it, I agree.
So if a reversable/ordered set is a specialized form of a reversable
collection where
69 matches
Mail list logo
