On Wed, 23 Feb 2022 18:49:22 GMT, Ichiroh Takiguchi
wrote:
>> Run jtreg:jdk/java/lang/ProcessBuilder/Basic.java on AIX.
>> The test was failed by:
>> Incorrect handling of envstrings containing NULs
>>
>> According to my investigation, this issue was happened after following
>> change was
On Wed, 23 Feb 2022 18:49:22 GMT, Ichiroh Takiguchi
wrote:
>> Run jtreg:jdk/java/lang/ProcessBuilder/Basic.java on AIX.
>> The test was failed by:
>> Incorrect handling of envstrings containing NULs
>>
>> According to my investigation, this issue was happened after following
>> change was
On Wed, 23 Feb 2022 19:59:46 GMT, Roger Riggs wrote:
>> Ichiroh Takiguchi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add null check
>
> The changes seem ok, modifying both the LIBPATH passed in the environment and
> the expected
On Wed, 23 Feb 2022 18:37:03 GMT, Roger Riggs wrote:
>> Jaikiran Pai has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - implement review comments
>> - copyright years
>
> test/jdk/java/util/Properties/PropertiesStoreTest.java line 61:
>
On Wed, 23 Feb 2022 18:22:53 GMT, Naoto Sato wrote:
>> Jaikiran Pai has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - implement review comments
>> - copyright years
>
> test/jdk/java/util/Properties/PropertiesStoreTest.java line 51:
>
> Can I please get a review of this test only change which fixes the issue
> noted in https://bugs.openjdk.java.net/browse/JDK-8282023?
>
> As noted in that JBS issue these tests fail when the default locale under
> which those tests are run isn't `en_US`. Both these tests were introduced as
>
> Optimizes the divideUnsigned() and remainderUnsigned() methods in
> java.lang.Integer and java.lang.Long classes using x86 intrinsics. This
> change shows 3x improvement for Integer methods and upto 25% improvement for
> Long. This change also implements the DivMod optimization which fuses
>
On Wed, 23 Feb 2022 09:03:37 GMT, Jatin Bhateja wrote:
>> Summary of changes:
>> - Intrinsify Math.round(float) and Math.round(double) APIs.
>> - Extend auto-vectorizer to infer vector operations on encountering scalar
>> IR nodes for above intrinsics.
>> - Test creation using new IR testing
On Wed, 23 Feb 2022 09:03:37 GMT, Jatin Bhateja wrote:
>> Summary of changes:
>> - Intrinsify Math.round(float) and Math.round(double) APIs.
>> - Extend auto-vectorizer to infer vector operations on encountering scalar
>> IR nodes for above intrinsics.
>> - Test creation using new IR testing
On Mon, 14 Feb 2022 21:24:47 GMT, Mandy Chung wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Respond to review feedback explicitly stating returned sets are immutable.
>
> I'm glad to see this proposal moving along
On Wed, 23 Feb 2022 17:05:58 GMT, ExE Boss wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Initial support for accessFlags methods
>
> src/java.base/share/classes/java/lang/Class.java line 1331:
>
>> 1329:
> This is an early review of changes to better model JVM access flags, that is
> "modifiers" like public, protected, etc. but explicitly at a VM level.
>
> Language level modifiers and JVM level access flags are closely related, but
> distinct. There are concepts that overlap in the two domains
On Wed, 23 Feb 2022 09:03:37 GMT, Jatin Bhateja wrote:
>> Summary of changes:
>> - Intrinsify Math.round(float) and Math.round(double) APIs.
>> - Extend auto-vectorizer to infer vector operations on encountering scalar
>> IR nodes for above intrinsics.
>> - Test creation using new IR testing
On Wed, 23 Feb 2022 02:13:21 GMT, Joe Darcy wrote:
>> This is an early review of changes to better model JVM access flags, that is
>> "modifiers" like public, protected, etc. but explicitly at a VM level.
>>
>> Language level modifiers and JVM level access flags are closely related, but
>>
> This is an early review of changes to better model JVM access flags, that is
> "modifiers" like public, protected, etc. but explicitly at a VM level.
>
> Language level modifiers and JVM level access flags are closely related, but
> distinct. There are concepts that overlap in the two domains
On Wed, 23 Feb 2022 23:50:49 GMT, PROgrm_JARvis wrote:
>> Replaces simple `for (Map.Entry entry : map.entrySet())` with
>> `map.forEach((k, v) ->)` calls. This change is better for thread-safety and
>> reduces allocation for some map implementations.
>>
>> A more in-depth description of
On Wed, 23 Feb 2022 22:33:42 GMT, liach wrote:
> Replaces simple `for (Map.Entry entry : map.entrySet())` with
> `map.forEach((k, v) ->)` calls. This change is better for thread-safety and
> reduces allocation for some map implementations.
>
> A more in-depth description of benefits is
Hi there,
The return value from Java_jdk_internal_loader_NativeLibraries_load() at
https://github.com/openjdk/jdk/blob/master/src/java.base/share/native/libjava/NativeLibraries.c
seems incorrect according to the code logic in there.
Looking at the calling path from loadLibrary() to load() at
> This is an early review of changes to better model JVM access flags, that is
> "modifiers" like public, protected, etc. but explicitly at a VM level.
>
> Language level modifiers and JVM level access flags are closely related, but
> distinct. There are concepts that overlap in the two domains
> Optimizes the divideUnsigned() and remainderUnsigned() methods in
> java.lang.Integer and java.lang.Long classes using x86 intrinsics. This
> change shows 3x improvement for Integer methods and upto 25% improvement for
> Long. This change also implements the DivMod optimization which fuses
>
> Optimizes the divideUnsigned() and remainderUnsigned() methods in
> java.lang.Integer and java.lang.Long classes using x86 intrinsics. This
> change shows 3x improvement for Integer methods and upto 25% improvement for
> Long. This change also implements the DivMod optimization which fuses
>
On Wed, 23 Feb 2022 05:52:00 GMT, Jatin Bhateja wrote:
>> Optimizes the divideUnsigned() and remainderUnsigned() methods in
>> java.lang.Integer and java.lang.Long classes using x86 intrinsics. This
>> change shows 3x improvement for Integer methods and upto 25% improvement for
>> Long. This
On Wed, 23 Feb 2022 05:46:45 GMT, Jatin Bhateja wrote:
>> Optimizes the divideUnsigned() and remainderUnsigned() methods in
>> java.lang.Integer and java.lang.Long classes using x86 intrinsics. This
>> change shows 3x improvement for Integer methods and upto 25% improvement for
>> Long. This
> In some Linux configurations, the Linux home directory provided by getpwent
> is not usable.
> The value of the system property `user.home` should fallback to the value of
> $HOME
> if getpwent.user_home is null or less that 2 characters long. "/" is not a
> valid home directory name.
>
>
On Wed, 23 Feb 2022 05:43:10 GMT, Jatin Bhateja wrote:
>> Optimizes the divideUnsigned() and remainderUnsigned() methods in
>> java.lang.Integer and java.lang.Long classes using x86 intrinsics. This
>> change shows 3x improvement for Integer methods and upto 25% improvement for
>> Long. This
Replaces simple `for (Map.Entry entry : map.entrySet())` with
`map.forEach((k, v) ->)` calls. This change is better for thread-safety and
reduces allocation for some map implementations.
A more in-depth description of benefits is available at
On Wed, 23 Feb 2022 21:51:50 GMT, Roger Riggs wrote:
>> src/java.base/unix/native/libjava/java_props_md.c line 498:
>>
>>> 496: if ((user_home != NULL) && (user_home[0] != '\0')) {
>>> 497: sprops.user_home = user_home;
>>> 498: }
>>
>> Is there any
On Wed, 23 Feb 2022 22:00:19 GMT, Roger Riggs wrote:
>> In some Linux configurations, the Linux home directory provided by getpwent
>> is not usable.
>> The value of the system property `user.home` should fallback to the value of
>> $HOME
>> if getpwent.user_home is null or less that 2
On Wed, 23 Feb 2022 19:59:35 GMT, Naoto Sato wrote:
>> In some Linux configurations, the Linux home directory provided by getpwent
>> is not usable.
>> The value of the system property `user.home` should fallback to the value of
>> $HOME
>> if getpwent.user_home is null or less that 2
On Fri, 18 Feb 2022 17:21:48 GMT, Olga Mikhaltsova
wrote:
>> This fix made equal processing of strings such as ""C:\\Program
>> Files\\Git\\"" before and after JDK-8250568.
>>
>> For example, it's needed to execute the following command on Windows:
>> `C:\Windows\SysWOW64\WScript.exe
On Thu, 17 Feb 2022 06:54:33 GMT, Alexander Matveev
wrote:
>> Added ability to override description for additional launchers via
>> "description" property.
>
> Alexander Matveev has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8279995:
On Wed, 23 Feb 2022 18:49:22 GMT, Ichiroh Takiguchi
wrote:
>> Run jtreg:jdk/java/lang/ProcessBuilder/Basic.java on AIX.
>> The test was failed by:
>> Incorrect handling of envstrings containing NULs
>>
>> According to my investigation, this issue was happened after following
>> change was
On Fri, 18 Feb 2022 15:29:34 GMT, Roger Riggs wrote:
> In some Linux configurations, the Linux home directory provided by getpwent
> is not usable.
> The value of the system property `user.home` should fallback to the value of
> $HOME
> if getpwent.user_home is null or less that 2 characters
On Wed, 23 Feb 2022 18:49:22 GMT, Ichiroh Takiguchi
wrote:
>> Run jtreg:jdk/java/lang/ProcessBuilder/Basic.java on AIX.
>> The test was failed by:
>> Incorrect handling of envstrings containing NULs
>>
>> According to my investigation, this issue was happened after following
>> change was
On Fri, 18 Feb 2022 15:29:34 GMT, Roger Riggs wrote:
> In some Linux configurations, the Linux home directory provided by getpwent
> is not usable.
> The value of the system property `user.home` should fallback to the value of
> $HOME
> if getpwent.user_home is null or less that 2 characters
On Wed, 23 Feb 2022 01:08:21 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this test only change which fixes the issue
>> noted in https://bugs.openjdk.java.net/browse/JDK-8282023?
>>
>> As noted in that JBS issue these tests fail when the default locale under
>> which those tests
On Wed, 23 Feb 2022 15:44:07 GMT, Tyler Steele wrote:
>> @RogerRiggs
>> Many thanks. that's good point.
>> Only 1st part has `test.nativepath` because of following code.
>>
>> if (AIX.is()) {
>> pb.environment().put("LIBPATH", libpath);
>> }
>>
>> On current condition, parent (main)
> Run jtreg:jdk/java/lang/ProcessBuilder/Basic.java on AIX.
> The test was failed by:
> Incorrect handling of envstrings containing NULs
>
> According to my investigation, this issue was happened after following change
> was applied.
> JDK-8272600: (test) Use native "sleep" in Basic.java
>
>
On Wed, 23 Feb 2022 01:08:21 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this test only change which fixes the issue
>> noted in https://bugs.openjdk.java.net/browse/JDK-8282023?
>>
>> As noted in that JBS issue these tests fail when the default locale under
>> which those tests
On Fri, 4 Feb 2022 12:42:39 GMT, Lance Andersen wrote:
> Hi all,
>
> Please review the attached patch to address
>
> - That JarFile::getInputStream did not check for a null ZipEntry passed as a
> parameter
> - Have Zip/JarFile::getInputStream throw a ZipException in the event that an
>
On Sat, 19 Feb 2022 05:51:52 GMT, Quan Anh Mai wrote:
> Should the other `requireNonNull` be `ForceInline` as well?
Probably yes.
-
PR: https://git.openjdk.java.net/jdk/pull/7543
On Wed, 23 Feb 2022 09:46:28 GMT, Ichiroh Takiguchi
wrote:
>> Run jtreg:jdk/java/lang/ProcessBuilder/Basic.java on AIX.
>> The test was failed by:
>> Incorrect handling of envstrings containing NULs
>>
>> According to my investigation, this issue was happened after following
>> change was
On Wed, 23 Feb 2022 10:14:44 GMT, Ichiroh Takiguchi
wrote:
>> For my curiosity, how is AIX different from other Linux in that the
>> test.nativepath is not/should not be in LIBPATH?
>
> @RogerRiggs
> Many thanks. that's good point.
> Only 1st part has `test.nativepath` because of following
On Tue, 22 Feb 2022 21:22:57 GMT, Tyler Steele wrote:
> This test had two failing sections on AIX related to an incorrect expected
> value for LIBPATH. The two (previously failing) test sections are below.
>
> - Test Runtime.exec(...envp...) with envstrings with initial `='
> - Test
On Tue, 22 Feb 2022 22:04:38 GMT, Tyler Steele wrote:
>> This test had two failing sections on AIX related to an incorrect expected
>> value for LIBPATH. The two (previously failing) test sections are below.
>>
>> - Test Runtime.exec(...envp...) with envstrings with initial `='
>> - Test
> I'm requesting comments and, hopefully, some help with this patch to replace
> `StringCoding.hasNegatives` with `countPositives`. The new method does a very
> similar pass, but alters the intrinsic to return the number of leading bytes
> in the `byte[]` range which only has positive bytes.
On Wed, 23 Feb 2022 01:06:24 GMT, Yasser Bazzi wrote:
>> Hi, could i get a review on this implementation proposed by Stuart Marks, i
>> decided to use the
>> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html
>> interface to create the default
> I'm requesting comments and, hopefully, some help with this patch to replace
> `StringCoding.hasNegatives` with `countPositives`. The new method does a very
> similar pass, but alters the intrinsic to return the number of leading bytes
> in the `byte[]` range which only has positive bytes.
On Tue, 22 Feb 2022 22:05:32 GMT, Lance Andersen wrote:
>> Hi all,
>>
>> Please review the attached patch to address
>>
>> - That JarFile::getInputStream did not check for a null ZipEntry passed as a
>> parameter
>> - Have Zip/JarFile::getInputStream throw a ZipException in the event that an
On Tue, 22 Feb 2022 18:10:28 GMT, Roger Riggs wrote:
>> Ichiroh Takiguchi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Use expectedLibpath
>
> For my curiosity, how is AIX different from other Linux in that the
> test.nativepath is
> Run jtreg:jdk/java/lang/ProcessBuilder/Basic.java on AIX.
> The test was failed by:
> Incorrect handling of envstrings containing NULs
>
> According to my investigation, this issue was happened after following change
> was applied.
> JDK-8272600: (test) Use native "sleep" in Basic.java
>
>
> Summary of changes:
> - Intrinsify Math.round(float) and Math.round(double) APIs.
> - Extend auto-vectorizer to infer vector operations on encountering scalar IR
> nodes for above intrinsics.
> - Test creation using new IR testing framework.
>
> Following are the performance number of a JMH
On Wed, 23 Feb 2022 01:31:24 GMT, Sandhya Viswanathan
wrote:
>> Jatin Bhateja has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8279508: Fixing for windows failure.
>
> src/hotspot/cpu/x86/c2_MacroAssembler_x86.cpp line 4146:
>
>> 4144:
On Wed, 16 Feb 2022 09:30:46 GMT, Volker Simonis wrote:
> Currently, `InflaterInputStream::read()` first does a native call to the
> underlying zlib `inflate()` function and only afterwards checks if the
> inflater requires input (i.e. `Inflater::needsInput()`) or has finished
> inflating
On Mon, 21 Feb 2022 18:05:08 GMT, Lance Andersen wrote:
>>> The change looks innocuous so it is probably OK. I would like to kick of
>>> our Mach5 runs to see if it shakes out any potential issues.
>>
>> @LanceAndersen , did you manage to get any Mach5 results? Did you find any
>> issues?
>
On Wed, 23 Feb 2022 02:13:21 GMT, Joe Darcy wrote:
>> This is an early review of changes to better model JVM access flags, that is
>> "modifiers" like public, protected, etc. but explicitly at a VM level.
>>
>> Language level modifiers and JVM level access flags are closely related, but
>>
56 matches
Mail list logo
