On Tue, 15 Mar 2022 23:18:24 GMT, Yasser Bazzi wrote:
>> Hi, could i get a review on this implementation proposed by Stuart Marks, i
>> decided to use the
>> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html
>> interface to create the default me
On Sat, 12 Mar 2022 01:35:23 GMT, XenoAmess wrote:
>> 8281631: HashMap copy constructor and putAll can over-allocate table
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> refine test
> what I worried is, the boundary this is
Magnus,
This proposal does not address the previous concerns. As before, you are
proposing to put the data files used to generate the classes for
jdk.localedata and jdk.charsets into src/java.base and I don't think we
should do that. I really think this PR needs to be withdraw n or closed
unt
To core-libs-dev@openjdk.java.net,
float and double should be mutually enhanced or
defaultedly changed, to uphold the following three
properties:
1) Base ten arithmetic on float and double, via operators.
2) Base Ten elementary function calls, like
those made on java.lang.StrictMath,
on do
On Wed, 16 Mar 2022 03:03:23 GMT, Joe Darcy wrote:
> Checking the java.bases sources revealed a number of other instances where
> conceptual links into the JLS (or JVMS) could be upgraded to actual links.
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.java.net/jd
On Tue, 8 Mar 2022 19:11:02 GMT, Ioi Lam wrote:
> This patch makes the result of "java -Xshare:dump" deterministic:
> - Disabled new Java threads from launching. This is harmless. See comments in
> jvm.cpp
> - Fixed a problem in hashtable ordering in heapShared.cpp
> - BasicHashtableEntry has a
Checking the java.bases sources revealed a number of other instances where
conceptual links into the JLS (or JVMS) could be upgraded to actual links.
-
Commit messages:
- JDK-8283234: Improve @jls usage in java.base
Changes: https://git.openjdk.java.net/jdk/pull/7834/files
Webrev:
On Tue, 15 Mar 2022 23:18:24 GMT, Yasser Bazzi wrote:
>> Hi, could i get a review on this implementation proposed by Stuart Marks, i
>> decided to use the
>> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html
>> interface to create the default me
On Wed, 16 Mar 2022 00:33:57 GMT, Joe Darcy wrote:
> Improve some semantic links into JLS with actual links.
This pull request has now been integrated.
Changeset: 4df24c5d
Author:Joe Darcy
URL:
https://git.openjdk.java.net/jdk/commit/4df24c5df38eeacc73097f71383916e9a0933839
Stats:
To core-libs-dev@openjdk.java.net,
float and double should be mutually enhanced or
defaultedly changed, to uphold the following three
properties:
1) Base ten arithmetic on float and double, via operators.
2) Base Ten elementary function calls, like
those made on java.lang.StrictMath,
on do
On Wed, 16 Mar 2022 00:33:57 GMT, Joe Darcy wrote:
> Improve some semantic links into JLS with actual links.
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/7831
On Wed, 16 Mar 2022 00:33:57 GMT, Joe Darcy wrote:
> Improve some semantic links into JLS with actual links.
Marked as reviewed by jjg (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/7831
Improve some semantic links into JLS with actual links.
-
Commit messages:
- JDK-8283230: Improve @jls usage in ElementType
Changes: https://git.openjdk.java.net/jdk/pull/7831/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=7831&range=00
Issue: https://bugs.openjdk.ja
On Tue, 15 Mar 2022 20:51:25 GMT, Valerie Peng wrote:
>> It's been several years since we increased the default key sizes. Before
>> shifting to PQC, NSA replaced its Suite B cryptography recommendations with
>> the Commercial National Security Algorithm Suite which suggests:
>>
>> - SHA-384 f
On Tue, 15 Mar 2022 20:44:20 GMT, Valerie Peng wrote:
>> src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11KeyPairGenerator.java
>> line 122:
>>
>>> 120: default -> {
>>> 121: throw new ProviderException
>>> 122: ("Unrecognized algo
On Tue, 15 Mar 2022 23:50:20 GMT, Magnus Ihse Bursie wrote:
>> A lot (but not all) of the data in make/data is tied to a specific module.
>> For instance, the publicsuffixlist is used by java.base, and fontconfig by
>> java.desktop. (A few directories, like mainmanifest, is *actually* used by
On Mon, 18 Jan 2021 13:47:20 GMT, Magnus Ihse Bursie wrote:
>> A lot (but not all) of the data in make/data is tied to a specific module.
>> For instance, the publicsuffixlist is used by java.base, and fontconfig by
>> java.desktop. (A few directories, like mainmanifest, is *actually* used by
> A lot (but not all) of the data in make/data is tied to a specific module.
> For instance, the publicsuffixlist is used by java.base, and fontconfig by
> java.desktop. (A few directories, like mainmanifest, is *actually* used by
> make for the whole build.)
>
> These data files should move t
On Wed, 9 Mar 2022 08:33:36 GMT, Xin Liu wrote:
>> If AbstractStringBuilder only grow, the inflated value which has been
>> encoded in UTF16 can't be compressed.
>> toString() can skip compression in this case. This can save an
>> ArrayAllocation in StringUTF16::compress().
>>
>> java.io.Buff
On Tue, 15 Mar 2022 17:08:27 GMT, Ioi Lam wrote:
>> This patch makes the result of "java -Xshare:dump" deterministic:
>> - Disabled new Java threads from launching. This is harmless. See comments
>> in jvm.cpp
>> - Fixed a problem in hashtable ordering in heapShared.cpp
>> - BasicHashtableEntry
On Sat, 12 Mar 2022 01:26:24 GMT, Yasser Bazzi wrote:
>> Hi, could i get a review on this implementation proposed by Stuart Marks, i
>> decided to use the
>> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html
>> interface to create the default me
> Hi, could i get a review on this implementation proposed by Stuart Marks, i
> decided to use the
> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html
> interface to create the default method `asRandom()` that wraps around the
> newer algorithms
As described in the linked issue, NullClassBytesTest fails due an
OutOfMemoryError produced on AIX when the test calls defineClass with a byte
array of size of 0. The native implementation of defineClass then calls malloc
with a size of 0. On AIX malloc(0) returns NULL, while on other platforms
On Fri, 11 Mar 2022 23:38:10 GMT, Mikael Vidstedt wrote:
> Background, from JBS:
>
> src/java.base/share/native/libverify/check_code.c: In function
> 'read_all_code':
> src/java.base/share/native/libverify/check_code.c:942:5: error: 'lengths' may
> be used uninitialized [-Werror=maybe-uniniti
> Quoting related changes in https://bugs.openjdk.java.net/browse/JDK-8250568
> modified the way that
> process builder recognized argument strings, causing some arguments to be
> doubly quoted and malformed.
>
> ProcessBuilder encodes command arguments in two ways, a looser legacy encoding
> an
> It's been several years since we increased the default key sizes. Before
> shifting to PQC, NSA replaced its Suite B cryptography recommendations with
> the Commercial National Security Algorithm Suite which suggests:
>
> - SHA-384 for secure hashing
> - AES-256 for symmetric encryption
> - RS
On Mon, 14 Mar 2022 21:24:15 GMT, Weijun Wang wrote:
>> Valerie Peng has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update again and undo DSA changes
>
> src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11KeyPairGenerator.java
On Mon, 14 Mar 2022 21:18:56 GMT, Weijun Wang wrote:
>> Valerie Peng has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update again and undo DSA changes
>
> src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11KeyPairGenerator.java
On Wed, 9 Mar 2022 08:33:36 GMT, Xin Liu wrote:
>> If AbstractStringBuilder only grow, the inflated value which has been
>> encoded in UTF16 can't be compressed.
>> toString() can skip compression in this case. This can save an
>> ArrayAllocation in StringUTF16::compress().
>>
>> java.io.Buff
On Mon, 14 Mar 2022 19:56:17 GMT, Joe Darcy wrote:
> Improving the exception messages for out-of-supported-range array types.
>
> I'll update copyrights before pushing.
This pull request has now been integrated.
Changeset: 32f8437d
Author:Joe Darcy
URL:
https://git.openjdk.java.net
On Tue, 15 Mar 2022 17:09:03 GMT, Joe Darcy wrote:
>> src/java.base/share/classes/java/lang/constant/ClassDesc.java line 185:
>>
>>> 183: netRank = Math.addExact(currentDepth, rank);
>>> 184: if (netRank >
>>> ConstantUtils.MAX_ARRAY_TYPE_DESC_DIMENSIONS) {
>>> 185:
On Tue, 15 Mar 2022 13:49:34 GMT, ExE Boss wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Respond to review feedback.
>
> src/java.base/share/classes/java/lang/constant/ClassDesc.java line 185:
>
>> 183:
On Tue, 15 Mar 2022 13:50:03 GMT, ExE Boss wrote:
>> src/java.base/share/classes/java/lang/constant/ClassDesc.java line 179:
>>
>>> 177: int netRank;
>>> 178: if (rank <= 0) {
>>> 179: throw new IllegalArgumentException("rank " + rank + "is
>>> not a positive value")
> Improving the exception messages for out-of-supported-range array types.
>
> I'll update copyrights before pushing.
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
the merge/rebase. T
> This patch makes the result of "java -Xshare:dump" deterministic:
> - Disabled new Java threads from launching. This is harmless. See comments in
> jvm.cpp
> - Fixed a problem in hashtable ordering in heapShared.cpp
> - BasicHashtableEntry has a gap on 64-bit platforms that may contain random
>
On Mon, 14 Mar 2022 20:52:39 GMT, Joe Darcy wrote:
> Add a constant for tau, 2*pi, to Math and StrictMath. Since 2*pi is a very
> common value in mathematical formulas, it is helpful to give it a distinct
> constant.
>
> Please also review the CSR https://bugs.openjdk.java.net/browse/JDK-82831
> Add a constant for tau, 2*pi, to Math and StrictMath. Since 2*pi is a very
> common value in mathematical formulas, it is helpful to give it a distinct
> constant.
>
> Please also review the CSR https://bugs.openjdk.java.net/browse/JDK-8283136
Joe Darcy has updated the pull request with a new
On Sat, 12 Mar 2022 01:26:24 GMT, Yasser Bazzi wrote:
>> Hi, could i get a review on this implementation proposed by Stuart Marks, i
>> decided to use the
>> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html
>> interface to create the default me
On Tue, 15 Mar 2022 01:36:14 GMT, Joe Darcy wrote:
> Depending on the range of the number line, a double value has between 15 and
> 17 digits of decimal precision. The literals used to initialize Math.PI and
> Math.E have several digits more precision than that maximum.
>
> That is potentially
> Depending on the range of the number line, a double value has between 15 and
> 17 digits of decimal precision. The literals used to initialize Math.PI and
> Math.E have several digits more precision than that maximum.
>
> That is potentially confusing to readers of the code and the minimum len
Please stop sending mails marked as urgent to a mailing list, you just make a
fool of yourself.
The need to round floating point numbers for commercial math (and the risk
involved in doing so) is nothing new, it predates the IEEE standard and should
be subject for even basic comp sci curriculum
On Thu, 10 Mar 2022 18:40:13 GMT, Zhengyu Gu wrote:
> Please review this small patch that fixes early `CHECK_NULL_RETURN` results
> not releasing native `jchar` array returned by `GetStringChars()`.
This pull request has now been integrated.
Changeset: 2cddf3f5
Author:Zhengyu Gu
URL:
On Thu, 10 Mar 2022 19:46:28 GMT, Naoto Sato wrote:
>> Please review this small patch that fixes early `CHECK_NULL_RETURN` results
>> not releasing native `jchar` array returned by `GetStringChars()`.
>
> LGTM.
Thanks, @naotoj @AlanBateman
-
PR: https://git.openjdk.java.net/jdk/pu
On Thu, 10 Mar 2022 18:40:13 GMT, Zhengyu Gu wrote:
> Please review this small patch that fixes early `CHECK_NULL_RETURN` results
> not releasing native `jchar` array returned by `GetStringChars()`.
Marked as reviewed by alanb (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pul
On 15/03/2022 13:23, Pasam Soujanya1 wrote:
Yes, jar command fails(exit code is 1) from JDK11 onward when target
files do not exist while archiving the data.
Can you check JDK 8u? I would expect the exit code to be non-0 with that
release too, it's just that it leaves behind the file. That'
On Mon, 14 Mar 2022 21:27:29 GMT, Joe Darcy wrote:
>> Improving the exception messages for out-of-supported-range array types.
>>
>> I'll update copyrights before pushing.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Respo
On Tue, 15 Mar 2022 07:50:29 GMT, Peter Levart wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Respond to review feedback.
>
> src/java.base/share/classes/java/lang/constant/ClassDesc.java line 179:
>
>> 177:
On Thu, 10 Mar 2022 18:40:13 GMT, Zhengyu Gu wrote:
> Please review this small patch that fixes early `CHECK_NULL_RETURN` results
> not releasing native `jchar` array returned by `GetStringChars()`.
Friendly ping. May I have a second review, please!
-
PR: https://git.openjdk.java.
Yes, jar command fails(exit code is 1) from JDK11 onward when target files do
not exist while archiving the data.
Please find the below jar execution with JDK11
$ jar -cvf sample.jar nofile.txt
nofile.txt : no such file or directory
added manifest
$ echo $?
1
Could you please share any documenta
On 3/1/22 18:17, Sean Mullan wrote:
Can you explain in a little more detail as to what the compatibility
issues are with preventing threads in thread pools from calling System.exit?
It is possible, I suppose, that some rather odd programmer is using
a task in a thread pool to exit their program
On Fri, 11 Mar 2022 23:37:06 GMT, Alexey Semenyuk wrote:
> Implementation of [JDK-8275062: "Allow jpackage create installers for
> services"](https://bugs.openjdk.java.net/browse/JDK-8275062)
> CSR
Build change looks good.
-
PR: https://git.openjdk.java.net/jdk/pull/7793
On 15/03/2022 11:33, Pasam Soujanya1 wrote:
Basically, we have a customer who use the jar command to zip up data
files generated in a directory, most of the time the files don't exist.
Can you confirm that the jar command is failing, meaning the exit code
is non-0? The change in JDK 9 to remov
Basically, we have a customer who use the jar command to zip up data files
generated in a directory, most of the time the files don't exist. With JDK11,
the jar archive is not created, and they see their tests failing. Their tests
were probably written to suit the JDK8 behavior.
However, if thi
On Mon, 14 Mar 2022 20:30:51 GMT, Roger Riggs wrote:
>> Claes Redestad has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix copyright year in new test
>
> core libs String.java changes look fine.
Thanks @RogerRiggs
I intend to push thi
Hello A.Z.
As Raffaello said, Java arithmetic does not have any more problem than
C/C++ when using IEEE 754. The "proof" of contrary is only an illusion
due to the rounding behavior of C/C++ output routines, as demonstrated
by Raffaello's code. Maybe some C/C++ code use Intel extended precisio
Sorry, for some reason a line was missing in the C++ code
#include
using namespace std;
int main()
{
cout << "Program has started..." << endl;
double a = 0.1D;
double b = 0.1D;
double c = a*b;
double d = 0.01D;
cout << endl << "0.1D*0.1D " << (c == d ? "==" : "!=") <<
The new decimal literals have indeed the minimal length required to
recover the doubles closest to the true mathematical values.
Raffaello
On 3/15/22 02:43, Joe Darcy wrote:
Depending on the range of the number line, a double value has between 15 and 17
digits of decimal precision. The lite
Hi,
Java, as well as most implementations of most languages, including C and
C++, have adopted the IEEE 754 floating-point standard, first issued in
1985. The standard specifies the formats, the outcome of operators and
comparisons up to the last bit.
Try out this C/C++ code (I'm on Linux wi
On Tue, 15 Mar 2022 08:17:24 GMT, Ioi Lam wrote:
>> This patch makes the result of "java -Xshare:dump" deterministic:
>> - Disabled new Java threads from launching. This is harmless. See comments
>> in jvm.cpp
>> - Fixed a problem in hashtable ordering in heapShared.cpp
>> - BasicHashtableEntry
On 15/03/2022 08:18, Pasam Soujanya1 wrote:
I tried "tar" with a target that does not exist, and the tar file got
created successfully (with an error message about the missing file)
and with the exit code 0 (success). Same behavior is seen with JDK8
jar too. From JDK11 onward, the output jar is
On Mon, 14 Mar 2022 22:07:24 GMT, Calvin Cheung wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Added helper function CollectedHeap::zap_filler_array_with
>
> test/hotspot/jtreg/runtime/cds/appcds/javaldr/LockDuringDump
> This patch makes the result of "java -Xshare:dump" deterministic:
> - Disabled new Java threads from launching. This is harmless. See comments in
> jvm.cpp
> - Fixed a problem in hashtable ordering in heapShared.cpp
> - BasicHashtableEntry has a gap on 64-bit platforms that may contain random
>
On Mon, 14 Mar 2022 21:27:29 GMT, Joe Darcy wrote:
>> Improving the exception messages for out-of-supported-range array types.
>>
>> I'll update copyrights before pushing.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Respo
On Mon, 14 Mar 2022 21:27:29 GMT, Joe Darcy wrote:
>> Improving the exception messages for out-of-supported-range array types.
>>
>> I'll update copyrights before pushing.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Respo
64 matches
Mail list logo
