- Warning will be printed if .jpackage.xml has old version number.
- Error will be thrown if main-class and app-store values are missing from
.jpackage.xml.
- Both main-class and app-store are required values for JDK-8286850 and they
might be missing if user uses app images generated by
Hi Michael,
Yes, this is correct. It is a three step process as you outlined it below.
Thanks,
Alexander
On Jun 7, 2022, at 12:00 AM, Michael Hall
mailto:mik3h...@gmail.com>> wrote:
Alexander,
I had an existing local GitHub repo for the jdk I updated that appeared to
accept the parameters
Hi Michael,
See below.
On Jun 5, 2022, at 5:58 PM, Michael Hall
mailto:mik3h...@gmail.com>> wrote:
./build/*/images/jdk/bin/jpackage --app-image
~/HalfPipe/halfpipe_jpkg/outputdir/HalfPipe.app --mac-sign
--mac-signing-key-user-name "Developer ID Application: Michael Hall
(5X6BXQB3Q7)"
Hi Michael,
Printing "Warning: Using unsigned app-image to build signed dmg.” with signed
application should be fixed with JDK-8286850. Did you reproduce it on build
containing JDK-8286850?
Thanks,
Alexander
> On Jun 5, 2022, at 3:06 PM, Michael Hall wrote:
>
>
>
>> On Jun 5, 2022, at
On Mon, 6 Jun 2022 20:37:11 GMT, Alexey Semenyuk wrote:
>> 8250950: Allow per-user and system wide configuration of a jpackaged app
>
> Alexey Semenyuk has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Add TKit.createDirectories() method
On Fri, 3 Jun 2022 21:07:47 GMT, Alexey Semenyuk wrote:
> 8250950: Allow per-user and system wide configuration of a jpackaged app
test/jdk/tools/jpackage/share/PerUserCfgTest.java line 174:
> 172: action.accept(cmd);
> 173: } finally {
> 174:
On Thu, 2 Jun 2022 05:17:25 GMT, Alexander Matveev wrote:
> - Added support for signing predefined application image.
> - Following command can be used to sign predefined application images:
> jpackage --type app-image --app-image Test.app --mac-sign [additional signing
> option
On Fri, 3 Jun 2022 01:56:01 GMT, Alexander Matveev wrote:
>> - Added support for signing predefined application image.
>> - Following command can be used to sign predefined application images:
>> jpackage --type app-image --app-image Test.app --mac-sign [additional
app images are supported. App image will be
> completely unsigned before signing.
Alexander Matveev has updated the pull request incrementally with one
additional commit since the last revision:
8286850: [macos] Add support for signing user provided app image [v3]
-
Changes:
-
app images are supported. App image will be
> completely unsigned before signing.
Alexander Matveev has updated the pull request incrementally with one
additional commit since the last revision:
8286850: [macos] Add support for signing user provided app image [v2]
-
Changes:
-
On Fri, 27 May 2022 03:12:39 GMT, Alexander Matveev
wrote:
> Looks like regression from JDK-8277493. JDK-8277493 will always un-sign app
> image. Un-signing takes time since we enumerating all files and un-signing
> binaries one by one. Average increase 2-3 minutes for tests which
- Added support for signing predefined application image.
- Following command can be used to sign predefined application images:
jpackage --type app-image --app-image Test.app --mac-sign [additional signing
options]
- Main class and if --mac-app-store was specified will be saved in
Looks like regression from JDK-8277493. JDK-8277493 will always un-sign app
image. Un-signing takes time since we enumerating all files and un-signing
binaries one by one. Average increase 2-3 minutes for tests which generates
multiple app images. Fixed by increasing timeout for reported tests.
On Thu, 19 May 2022 19:13:12 GMT, Alexey Semenyuk wrote:
> 8281682: Redundant .ico files in Windows app-image cause unnecessary bloat
Marked as reviewed by almatvee (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/8794
to run in order to cleanup extracted files.
Thanks,
Alexander
On May 18, 2022, at 6:44 PM, Michael Hall
mailto:mik3h...@gmail.com>> wrote:
On May 11, 2022, at 4:39 PM, Alexander Matveev
mailto:almat...@openjdk.java.net>> wrote:
- It is not possible to support native
On Wed, 11 May 2022 21:31:44 GMT, Alexander Matveev
wrote:
> - It is not possible to support native JDK commands such as "java" inside Mac
> App Store bundles due to embedded info.plist. Workarounds suggested in
> JDK-8286122 does not seems to be visible.
>
jdk.jpackage module with your app, you
should able to use jpackage functionality from your app via ToolProvider
without actual jpackage native command.
Thanks,
Alexander
> On May 16, 2022, at 6:03 PM, Michael Hall wrote:
>
>
>
>> On May 16, 2022, at 7:09 PM, Alexander Matveev
&g
Hi Michael,
>
>>>
>>> I’m not real familiar with the build process. But would it be possible for
>>> the user to build their own jdk that substitutes something else for the
>>> colliding identifier that gets embedded?
>> Yes, it should be possible and in theory such JDK with native commands
On Wed, 4 May 2022 03:56:10 GMT, Alexander Matveev wrote:
> - No changes to code provided by original fix.
> - Added ad hoc signing on macOS aarch64, since macOS aarch64 cannot execute
> unsigned code and code should be at least ad hoc signed.
> - Signing of app bun
On Wed, 4 May 2022 03:56:10 GMT, Alexander Matveev wrote:
> - No changes to code provided by original fix.
> - Added ad hoc signing on macOS aarch64, since macOS aarch64 cannot execute
> unsigned code and code should be at least ad hoc signed.
> - Signing of app bun
undle structure with added files into Content folder. Thus test
> is executed but failure is always expected on macOS aarch64.
Alexander Matveev has updated the pull request incrementally with one
additional commit since the last revision:
8277493: [REDO] Quarantined jpackage apps are l
Hi Michael,
> On May 11, 2022, at 3:17 PM, Michael Hall wrote:
>
> Is this restricted somehow to Mac App Store applications?
Yes, helper tools (in our case JDK native commands) in Mac App Store
applications cannot use same bundle ID as another application. Since we have
bundle ID embedded in
On Wed, 11 May 2022 21:58:46 GMT, Alexey Semenyuk wrote:
>> Alexander Matveev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8286122: [macos]: App bundle cannot upload to Mac App Store due to
>> info.
tion for
> jlink, so native JDK commands are not included when generating Mac App Store
> bundles.
> - Custom runtime provided via --runtime-image should not contain native
> commands as well, otherwise jpackage will throw error.
> - Added two tests to validate fix.
- It is not possible to support native JDK commands such as "java" inside Mac
App Store bundles due to embedded info.plist. Workarounds suggested in
JDK-8286122 does not seems to be visible.
- With proposed fix we will enforce "--strip-native-commands" option for
jlink, so native JDK commands
On Mon, 9 May 2022 21:25:37 GMT, Alexey Semenyuk wrote:
> 8282351: jpackage does not work if class file has `$$` in the name on windows
Marked as reviewed by almatvee (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/8613
On Thu, 5 May 2022 20:00:54 GMT, Alexey Semenyuk wrote:
> - Replace `System.getProperty("java.io.tmpdir")` call with hardcoded `/tmp`
> string to get root folder for test files.
> - Fix test cleanup - the test didn't delete test files upon completion
Marked as reviewed by almatvee (Reviewer).
- No changes to code provided by original fix.
- Added ad hoc signing on macOS aarch64, since macOS aarch64 cannot execute
unsigned code and code should be at least ad hoc signed.
- Signing of app bundle produced by AppContentTest.java fails, since it has
invalid app bundle structure with
On Thu, 31 Mar 2022 20:08:13 GMT, Alexey Semenyuk wrote:
> Add missing `exit(exitCode)` call.
> Add relevant unit test.
Marked as reviewed by almatvee (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/8064
On Sat, 12 Mar 2022 03:12:30 GMT, Alexander Matveev
wrote:
> - Fixed by adding missing ']'.
> - I changed '()' to '[]', since other error messages use '[]' and not '()'.
This pull request has now been integrated.
Changeset: d83cee98
Author:Alexander Matveev
URL:
On Fri, 11 Mar 2022 23:37:06 GMT, Alexey Semenyuk wrote:
> Implementation of [JDK-8275062: "Allow jpackage create installers for
> services"](https://bugs.openjdk.java.net/browse/JDK-8275062)
> CSR
Marked as reviewed by almatvee (Reviewer).
-
PR:
- Fixed by adding missing ']'.
- I changed '()' to '[]', since other error messages use '[]' and not '()'.
-
Commit messages:
- 8282407: Missing ')' in MacResources.properties
Changes: https://git.openjdk.java.net/jdk/pull/7797/files
Webrev:
On Wed, 9 Feb 2022 07:37:42 GMT, Alexander Matveev wrote:
> Added ability to override description for additional launchers via
> "description" property.
This pull request has now been integrated.
Changeset: fb8bf818
Author:Alexander Matveev
URL:
https://git.open
On Thu, 17 Feb 2022 17:53:57 GMT, Alexey Semenyuk wrote:
>> Alexander Matveev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8279995: jpackage --add-launcher option should allow overriding
>> descr
> Added ability to override description for additional launchers via
> "description" property.
Alexander Matveev has updated the pull request incrementally with one
additional commit since the last revision:
8279995: jpackage --add-launcher option should allow overriding
On Tue, 15 Feb 2022 15:48:02 GMT, Alexey Semenyuk wrote:
>> Alexander Matveev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8279995: jpackage --add-launcher option should allow overriding
>> descr
> Added ability to override description for additional launchers via
> "description" property.
Alexander Matveev has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains five commits:
- Merge master
- 8279995: jpackag
> Added ability to override description for additional launchers via
> "description" property.
Alexander Matveev has updated the pull request incrementally with one
additional commit since the last revision:
8279995: jpackage --add-launcher option should allow overriding
On Thu, 17 Feb 2022 03:50:39 GMT, Alexey Semenyuk wrote:
>> 8282007: Assorted enhancements to jpackage testing framework
>
> Alexey Semenyuk has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Copyright years fixed
Marked as reviewed by
On Wed, 16 Feb 2022 23:51:30 GMT, Alexey Semenyuk wrote:
>> 8282007: Assorted enhancements to jpackage testing framework
>
> Alexey Semenyuk has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Don't fail if requested to uninstall not installed
On Wed, 16 Feb 2022 17:52:43 GMT, Alexey Semenyuk wrote:
> 8282011: test/jdk/tools/jpackage/windows/WinL10nTest.java test fails if
> light.exe is not in %PATH%
Marked as reviewed by almatvee (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/7500
On Tue, 15 Feb 2022 22:56:35 GMT, Alexey Semenyuk wrote:
> 8281874: Can't unpack msi installers from
> test/jdk/tools/jpackage/windows/test/jdk/tools/jpackage/windows/WinShortcutPromptTest.java
> test
Marked as reviewed by almatvee (Reviewer).
-
PR:
On Tue, 15 Feb 2022 17:44:24 GMT, Alexey Semenyuk wrote:
> Code clean up. Remove obsolete comments, unused imports, and unneeded jtreg
> test parameter.
> Fix the code to handle the case when installers are not created and there is
> nothing to verify in the test.
Marked as reviewed by
On Fri, 11 Feb 2022 22:11:44 GMT, Alexey Semenyuk wrote:
>> Alexander Matveev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8279995: jpackage --add-launcher option should allow overriding
>> descr
> Added ability to override description for additional launchers via
> "description" property.
Alexander Matveev has updated the pull request incrementally with one
additional commit since the last revision:
8279995: jpackage --add-launcher option should allow overriding
On Wed, 9 Feb 2022 07:37:42 GMT, Alexander Matveev wrote:
> Added ability to override description for additional launchers via
> "description" property.
Added automated tests for .exe files in Windows and .desktop files on Linux.
-
PR: https://git.openjdk.java.net/jdk/pull/7399
> Added ability to override description for additional launchers via
> "description" property.
Alexander Matveev has updated the pull request incrementally with one
additional commit since the last revision:
8279995: jpackage --add-launcher option should allow overriding
On Wed, 9 Feb 2022 07:37:42 GMT, Alexander Matveev wrote:
> Added ability to override description for additional launchers via
> "description" property.
AddLauncherArguments.java class reads parameters for additional launcher from
property file and if this class contains par
On Wed, 9 Feb 2022 12:35:59 GMT, Alexey Semenyuk wrote:
>> Added ability to override description for additional launchers via
>> "description" property.
>
> test/jdk/tools/jpackage/share/AddLauncherTest.java line 93:
>
>> 91: new AdditionalLauncher("Baz2")
>> 92:
Added ability to override description for additional launchers via
"description" property.
-
Commit messages:
- 8279995: jpackage --add-launcher option should allow overriding description
Changes: https://git.openjdk.java.net/jdk/pull/7399/files
Webrev:
On Tue, 1 Dec 2020 23:54:11 GMT, Alexey Semenyuk wrote:
> Add missing quotes to `%if` expressions in spec template. Required by
> rpmbuild 4.16.0
Marked as reviewed by almatvee (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/1551
On Mon, 3 Jan 2022 08:10:27 GMT, Aleksey Shipilev wrote:
> Seems like a missing include. C++ docs say `offsetof` is from ``,
> adding that include explicitly fixes the build. Seems to only happen with
> older GCCs, but it seems to be a happy accident it works on newer ones,
> probably through
On Fri, 17 Dec 2021 03:28:12 GMT, Alexander Matveev
wrote:
> This is regression from JDK-8263155. MacHelper.java is now calling test
> verification callback with all content in DMG root. SigningPackageTest
> expects only path with app name in it and thus it fails when trying to veri
This is regression from JDK-8263155. MacHelper.java is now calling test
verification callback with all content in DMG root. SigningPackageTest expects
only path with app name in it and thus it fails when trying to verify app
inside ".background" folder. Fixed by checking that provided path for
On Tue, 14 Dec 2021 06:10:51 GMT, Alexander Matveev
wrote:
> This is regression from JDK-8276837. exec() was passing INFINITE_TIMEOUT
> instead of actual value of timeout variable. Execution of osascript was
> running without timeout and thus several tests timeout. Osascript ha
This is regression from JDK-8276837. exec() was passing INFINITE_TIMEOUT
instead of actual value of timeout variable. Execution of osascript was running
without timeout and thus several tests timeout. Osascript hang during test
execution is intermittent issue.
Also, removed IconTest.java and
On Mon, 6 Dec 2021 19:20:00 GMT, Alexey Semenyuk wrote:
> 8278311: Debian packaging doesn't work
Marked as reviewed by almatvee (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/6726
On Wed, 1 Dec 2021 21:35:01 GMT, Andy Herrick wrote:
> - We need to unsign all executables and libraries in the app-image before
> signing. (not just those in the runtime).
> - Clean up excessive output by executing the individual file sign and
> unsigning commands in quiet mode.
> - Add
On Sun, 21 Nov 2021 12:39:17 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to add more
> diagnostics when a failure occurs in the jlink tool during the jpackage tests?
>
> As noted in https://bugs.openjdk.java.net/browse/JDK-8277507, so far 3
> failures
On Sat, 20 Nov 2021 03:26:51 GMT, Alexey Semenyuk wrote:
> 8277429: Conflicting jpackage static library name
Marked as reviewed by almatvee (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/6485
On Mon, 15 Nov 2021 19:56:28 GMT, Andy Herrick wrote:
> JDKJDK-8276150: Quarantined jpackage apps are labeled as "damaged"
Looks good. Just fix pull request title.
-
Marked as reviewed by almatvee (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/6396
On Thu, 11 Nov 2021 04:07:18 GMT, Alexey Semenyuk wrote:
> 8276084: Linux DEB Bundler: release number in outputted .deb file should be
> optional
Marked as reviewed by almatvee (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/6345
On Fri, 5 Nov 2021 19:58:01 GMT, Alexey Semenyuk wrote:
> The fix is to isolate C++ calls in the separate forked child process on
> Linux.
> This change requires the passing of JLI command line arguments and values of
> environment variables between two processes.
Marked as reviewed by
On Fri, 5 Nov 2021 17:21:01 GMT, Andy Herrick wrote:
> JDK-8276562: Fix to JDK-8263155 left out the help text changes
Marked as reviewed by almatvee (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/6281
On Thu, 21 Oct 2021 15:36:36 GMT, Andy Herrick wrote:
>> JDK-8263155: Allow additional contents for DMG
>
> Andy Herrick has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains five commits:
>
> - Merge branch 'master' into
On Wed, 6 Oct 2021 18:53:39 GMT, Andy Herrick wrote:
>> 8274346: Support for additional content in an app-image.
>
> Andy Herrick has updated the pull request incrementally with one additional
> commit since the last revision:
>
> JDK-8274346: Support for additional content in an app-image.
On Thu, 23 Sep 2021 20:03:29 GMT, Andy Herrick wrote:
> JDK-8274087: Windows DLL path not set correctly.
Marked as reviewed by almatvee (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/5663
On Tue, 14 Sep 2021 21:47:36 GMT, Alexey Semenyuk wrote:
>> Fix jpackage error output when "--type" CLI option is missing and jpackage
>> detects that it can't build native packages in the environment.
>
> Alexey Semenyuk has updated the pull request incrementally with one
> additional commit
On Thu, 9 Sep 2021 20:14:01 GMT, Andy Herrick wrote:
> backport from jdk-18
Marked as reviewed by almatvee (Reviewer).
-
PR: https://git.openjdk.java.net/jdk17/pull/306
On Thu, 19 Aug 2021 14:12:00 GMT, Andy Herrick wrote:
> JDK-8272639: jpackaged applications using microphone on mac
Marked as reviewed by almatvee (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/5186
On Wed, 11 Aug 2021 17:52:57 GMT, Alexey Semenyuk wrote:
> Restart window app launcher to make changes made to `PATH` env variable
> visible to JLI code in
> https://github.com/openjdk/jdk/blob/master/src/hotspot/os/windows/os_windows.cpp#L347
Marked as reviewed by almatvee (Reviewer).
On Mon, 9 Aug 2021 18:19:03 GMT, Alexey Semenyuk wrote:
>> Added jtreg test to verify jpackage launcher adds app dir to
>> `java.library.path` system property.
>> Removed unused test/jdk/tools/jpackage/apps/installer/Hello.java.
>> Moved test/jdk/tools/jpackage/apps/image/Hello.java to
>>
On Thu, 5 Aug 2021 17:07:13 GMT, Andy Herrick wrote:
>> 8271868: Warn user when using mac-sign option with unsigned app-image.
>
> Andy Herrick has updated the pull request incrementally with one additional
> commit since the last revision:
>
> JDK-8271868: Warn user when using mac-sign
On Wed, 4 Aug 2021 20:00:37 GMT, Andy Herrick wrote:
> 8271868: Warn user when using mac-sign option with unsigned app-image.
First of all why we only want to cover case when app-image was produced without
--mac-sign? If we want to cover such case only, then we need to use approach
suggested
On Wed, 4 Aug 2021 20:00:37 GMT, Andy Herrick wrote:
> 8271868: Warn user when using mac-sign option with unsigned app-image.
I think it will not work. User might modify app image after it was created and
it will invalidate signature.
-
PR:
On Wed, 4 Aug 2021 20:00:37 GMT, Andy Herrick wrote:
> 8271868: Warn user when using mac-sign option with unsigned app-image.
Changes requested by almatvee (Reviewer).
src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacAppImageBuilder.java
line 877:
> 875: try {
> 876:
On Mon, 2 Aug 2021 13:45:17 GMT, Andy Herrick wrote:
> JDK-8271344: Windows product version issue
Marked as reviewed by almatvee (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/4958
On Thu, 22 Jul 2021 19:35:59 GMT, Alexey Semenyuk wrote:
> Replace `";"` with `FileUtils::pathSeparator` in the expression adding 'app'
> dir to env variable in jpackage app launcher.
Marked as reviewed by almatvee (Reviewer).
-
PR: https://git.openjdk.java.net/jdk17/pull/271
On Wed, 14 Jul 2021 16:50:39 GMT, Andy Herrick wrote:
>> JDK-8269387: jpackage --add-launcher should have option to not create
>> shortcuts for additional launchers
>
> Andy Herrick has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
On Fri, 2 Jul 2021 22:17:09 GMT, Alexey Semenyuk wrote:
> Disable stripping to prevent rpmbuild from modifying executables
Marked as reviewed by almatvee (Reviewer).
-
PR: https://git.openjdk.java.net/jdk17/pull/207
On Fri, 25 Jun 2021 22:41:10 GMT, Alexey Semenyuk wrote:
> jpackage app launcher randomly crashes JVM at termination in EMS enabled JDK
> builds.
> Until the root cause of the issue is understood and fixed let's add a
> workaround to jpackage tests to run test app few more times if the first
On Tue, 22 Jun 2021 21:59:43 GMT, Alexander Matveev
wrote:
> Looks like another "Resource busy" issue similar to recent fixes for "hdiutil
> convert" and "hdiutil detach". Workaround in same way by repeating "create"
> command. Modified Re
Looks like another "Resource busy" issue similar to recent fixes for "hdiutil
convert" and "hdiutil detach". Workaround in same way by repeating "create"
command. Modified RetryExecutor to pass write to file flag, otherwise "hdiutil
create" might deadlock.
Also, repeat is done only for creating
On Fri, 18 Jun 2021 22:46:24 GMT, Alexey Semenyuk wrote:
> GetApplicationHomeFromDll() fails if the path to libjli.so contains "bin"
> component (/tmp/bin/HelloWorld/lib/runtime/lib/libjli.so). TruncatePath()
> looks for "/bin/" first in "/tmp/bin/HelloWorld/lib/runtime/lib/libjli.so"
>
On Tue, 8 Jun 2021 17:25:46 GMT, Alexey Semenyuk wrote:
>> …ages
>
> Alexey Semenyuk has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in by the merge/rebase. The pull request contains two
On Thu, 3 Jun 2021 00:47:45 GMT, Jonathan Gibbons wrote:
> Please review a small test fix, to include hamcrest.jar, as required by the
> latest version of JUnit in jtreg 6.
Marked as reviewed by almatvee (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/4328
On Wed, 2 Jun 2021 13:48:47 GMT, Andy Herrick wrote:
> JDK-8267764: jpackage cannot handle window screensaver files when EXE renamed
> as SCR
Marked as reviewed by almatvee (Reviewer).
Can we add a simple test for .scr executables?
-
PR:
On Wed, 26 May 2021 11:26:24 GMT, Andy Herrick wrote:
> JDK-8267598: jpackage removes system libraries from java.library.path
Marked as reviewed by almatvee (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/4203
On Fri, 21 May 2021 04:34:22 GMT, Alexander Matveev
wrote:
> Looks like another issue similar to hdiutil (JDK-8249395) when process is
> gone, but we still waiting for it. I was not able to reproduce this issue by
> running test or pkgbuild separately and conclusion was made base
Looks like another issue similar to hdiutil (JDK-8249395) when process is gone,
but we still waiting for it. I was not able to reproduce this issue by running
test or pkgbuild separately and conclusion was made based on logs. Fixed in
same way as hdiutil issue. Also, I added logging PID for
On Wed, 19 May 2021 21:00:07 GMT, Alexander Matveev
wrote:
> For debug build on macOS, runtime which used for test fill be located in
> /path/jdk-17/fastdebug and /path/jdk-17 will not contain any other files
> except fastdebug and in this case our check to decide if we need to
On Thu, 20 May 2021 16:15:21 GMT, Alexey Semenyuk wrote:
>> Alexander Matveev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8267056: tools/jpackage/share/RuntimePackageTest.java fails with
>> No
rrect. Fixed by skipping
> this check for runtime and only using it for app. Also, added ignoring
> .DS_Store to test which is needed if user used Finder to look inside runtime
> folder which will cause .DS_Store to be created and will cause test to fail,
> since this file is not be
For debug build on macOS, runtime which used for test fill be located in
/path/jdk-17/fastdebug and /path/jdk-17 will not contain any other files except
fastdebug and in this case our check to decide if we need to copy app or
runtime will return /path/jdk-17 which is not correct. Fixed by
On Fri, 14 May 2021 04:24:42 GMT, Alexander Matveev
wrote:
> Looks like it is similar to JDK-8236282, except for "hdiutil create". Based
> on call stack from failed test we launched "hdiutil create" and were waiting
> for it to terminate while reading output from
Looks like it is similar to JDK-8236282, except for "hdiutil create". Based on
call stack from failed test we launched "hdiutil create" and were waiting for
it to terminate while reading output from it. However, based on process dump
from machine which reproduced this issue, hdiutil no longer
On Wed, 12 May 2021 20:34:08 GMT, Alexey Semenyuk wrote:
> 8266162: Remove JPackage duplicate tests
Marked as reviewed by almatvee (Committer).
-
PR: https://git.openjdk.java.net/jdk/pull/4003
On Fri, 7 May 2021 02:48:44 GMT, Alexander Matveev wrote:
> - Replaced direct TKit.run() calls with Test annotation.
> - Increased timeout for SigningPackageTest from default to 360 due to
> timeout. This is regression from JDK-8248904 due to changes done in signing
> and --remo
On Sat, 8 May 2021 01:44:46 GMT, Alexander Matveev wrote:
>> - Replaced direct TKit.run() calls with Test annotation.
>> - Increased timeout for SigningPackageTest from default to 360 due to
>> timeout. This is regression from JDK-8248904 due to changes done in signin
.
> - Fixed issue with jtreg.SkippedException which caused test to fail instead
> of being skipped, since it was wrapped in ExceptionBox.
Alexander Matveev has updated the pull request incrementally with one
additional commit since the last revision:
8266456: Replace direc
1 - 100 of 501 matches
Mail list logo
