looks good. It's fortunate we haven't broken anything ;-) The
test passed just fine.
Best,
Joe
On 8/27/19 2:06 AM, Frank Yuan wrote:
> Hi all
>
>
>
> We found 2 jaxp tests, which didn't run indeed.
>
>
>
> Bugs:
>
> https://bugs.openjdk.java.net/browse
Hi all
We found 2 jaxp tests, which didn't run indeed.
Bugs:
https://bugs.openjdk.java.net/browse/JDK-8230002
Annotation @Test was missed in TestNG test.
https://bugs.openjdk.java.net/browse/JDK-8230010
The old test was left during it was converted to TestNG test.
Webrev:
> +1
>
> -Joe
>
>
> On 7/11/19 11:32 PM, Frank Yuan wrote:
> > Hi
> >
> >
> >
> > Would you like to review the following patch for
> >
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8227438
> >
> >
> >
> > --- a/test/l
Hi
Would you like to review the following patch for
Bug: https://bugs.openjdk.java.net/browse/JDK-8227438
--- a/test/lib/jdk/test/lib/util/FileUtils.java Thu Jul 11 15:58:54 2019
+
+++ b/test/lib/jdk/test/lib/util/FileUtils.java Fri Jul 12 13:33:30 2019 +0800
@@ -96,7
of MethodHandle we may not take
VarHandle api in some cases for the performance.
Thanks
YC
On Wed, Apr 24, 2019 at 10:33 PM Frank Yuan mailto:frank.y...@oracle.com> > wrote:
>
> Hi Frank,
> a VarHandle is a glorified integer value that correspond to the number of
> bytes from a
gt; - Mail original -
> > De: "Frank Yuan"
> > À: "Aleksey Shipilev"
> > Cc: "core-libs-dev"
> > Envoyé: Mercredi 24 Avril 2019 12:11:11
> > Objet: RE: VarHandle instance methods performance
>
> >> On 4/
> On 4/24/19 11:51 AM, Frank Yuan wrote:
> > My test code is as below:
> > ...
> > final VarHandle vhf;
> > final VarHandle vhvf;
> > ...
>
> Make these two "static final", initialize them in class initializer, then try
> again.
>
Hi Aleksey
I happened to see the performance to access a field by VarHandle API is much
worse than the native access.
I tested the following situations:
1. reading a volatile field directly
2. calling getVolatile against this volatile field
3. calling getVolatile against another non-volatile
Thank you, Joe! Pushed the change.
Frank
>
> Hi Frank,
>
> The change looks good to me. Thanks for fixing the failure!
>
> Best,
> Joe
>
> On 12/4/18, 6:19 PM, Frank Yuan wrote:
> > Hi all
> >
> >
> >
> > Would you like to review this
Hi all
Would you like to review this patch?
Bug: https://bugs.openjdk.java.net/browse/JDK-8213300
Webrev: http://cr.openjdk.java.net/~fyuan/8213300/webrev.00/
This patch made the following changes:
1. change the path of test file from the root directory of drive C to
C:\temp
Thank you! Pushed.
Frank
> -Original Message-
> From: Chris Hegarty [mailto:chris.hega...@oracle.com]
> Sent: Monday, September 17, 2018 6:16 PM
> To: Frank Yuan; 'core-libs-dev'
> Subject: Re: RFR (12): 8210819: Update the host name in CNameTest.java
>
> Loo
Hi
Would you like to review the following patch for
Bug: https://bugs.openjdk.java.net/browse/JDK-8210819
--- a/test/jdk/sun/net/InetAddress/nameservice/dns/CNameTest.java Wed
Sep 12 21:56:59 2018 -0700
+++ b/test/jdk/sun/net/InetAddress/nameservice/dns/CNameTest.java Mon
On 28/09/2017 09:37, Frank Yuan wrote:
> Hi Daniel and all
>
> Would you like to review
> http://cr.openjdk.java.net/~fyuan/8187700/webrev.00/?
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8187700
>
> I applied the fix for proxy port reusing issue, which was review
Hi Daniel and all
Would you like to have a look on this review? It's the same issue as
JDK-8188086 but in SetAuthenticator tests. The fix's verified
by running the test in loop.
Thanks
Frank
From: Frank Yuan [mailto:frank.y...@oracle.com]
Subject: [10] [testbug] RFR of JDK
Hi Daniel and all
Would you like to review http://cr.openjdk.java.net/~fyuan/8187700/webrev.00/?
Bug: https://bugs.openjdk.java.net/browse/JDK-8187700
I applied the fix for proxy port reusing issue, which was reviewed in bug
JDK-8187507. And made a few code cleaning in
We have not see any issues with pid re-use and I would prefer to avoid over
engineering the code
for a non-issue.
Yes, I agree.
With the proposed fix, the onExit completion handler and isAlive are consistent.
I mean, in ProcessHandleImpl.isAlive(), startTime is the final filed of the
Hi Roger
I think this is the cause and I believe the patch will work.
However, I have the following concern and minor comments:
a. Is it possible that following scenario happens?
1. process A exits
2. Completion thread in onExist runs and gets 0 as origStart, and then
sleeps 5s
3.
Hi Joe and Daniel
> > So far so good, most of them still seem to be present in
> > your changes, but I have a doubt about these two:
> >
> > https://bugs.openjdk.java.net/browse/JDK-8062608
> > https://bugs.openjdk.java.net/browse/JDK-8064516
> >
> > Has the issue been fixed upstream in a
Looks fine, although I am not a reviewer.
Thanks
Frank
> -Original Message-
> From: core-libs-dev [mailto:core-libs-dev-boun...@openjdk.java.net] On Behalf
> Of Igor Ignatyev
> Subject: RFR(S): 8180195: remove jaxp testlibrary
>
>
Since no one has more comment, and Joe agree this solution, I will push the
change.
Thanks
Frank
> -Original Message-
> From: Weijun Wang [mailto:weijun.w...@oracle.com]
> Sent: Thursday, February 16, 2017 4:35 PM
> To: Frank Yuan; 'Daniel Fuchs'; core-libs-dev@open
> Thanks
> Max
>
> On 02/16/2017 04:03 PM, Frank Yuan wrote:
> > Hi Max and All
> >
> > Would you like to review
> > http://cr.openjdk.java.net/~fyuan/8175043/webrev.00/?
> >
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8175043
> >
&
Hi Max and All
Would you like to review http://cr.openjdk.java.net/~fyuan/8175043/webrev.00/?
Bug: https://bugs.openjdk.java.net/browse/JDK-8175043
Some JAXP tests are impacted by JDK-8168410, to fix the issue, I added the pull
path name to the file name in the tests, and added a
Thank you very much for the check! Pushed.
Frank
> -Original Message-
> From: huizhe wang [mailto:huizhe.w...@oracle.com]
> Sent: Wednesday, February 15, 2017 11:35 AM
> To: Frank Yuan; 'Daniel Fuchs'
> Cc: core-libs-dev@openjdk.java.net
> Subject: Re: RFR [JAXP] JDK-
nal Message-
> From: Frank Yuan [mailto:frank.y...@oracle.com]
> Subject: RE: RFR [JAXP] JDK-8174025 Regression in XML Transform caused by
> JDK-8087303
>
>
> > -Original Message-
> > From: huizhe wang [mailto:huizhe.w...@oracle.com]
> > Subject: Re: RFR
inningNewlines && (text[start] == '\n'
|| text[start] == '\r')) {
---
> while (skipBeginningNewlines && text[start] == '\n') {
Once it is passed by all tests, I will push the change.
Thanks
Frank
> Best,
> Joe
>
> On 2/14/2017 6:58 AM, Frank Yuan wrote:
> >
> -Original Message-
> From: Daniel Fuchs [mailto:daniel.fu...@oracle.com]
> Subject: Re: RFR [JAXP] JDK-8174025 Regression in XML Transform caused by
> JDK-8087303
>
> Hi Frank,
>
> On 14/02/17 13:43, Frank Yuan wrote:
> >
> >> -Origin
Since XML processor should normalize the newline.
Thanks
Frank
>
> best regards,
>
> -- daniel
>
> On 14/02/17 10:33, Frank Yuan wrote:
> > Hi Joe
> >
> > As you suggested, I made pretty-print a little better based on the fix.
> > That is when adding i
n 2/13/2017 1:35 AM, Frank Yuan wrote:
> Hi Joe and Daniel
>
> Thank you very much for your review!
>
> Frank
>
>
> -Original Message-
> From: huizhe wang [mailto:huizhe.w...@oracle.com]
> Subject: Re: RFR [JAXP] JDK-8170192 Regression in XML Transform caused
Hi Joe and Daniel
Thank you very much for your review!
Frank
-Original Message-
From: huizhe wang [mailto:huizhe.w...@oracle.com]
Sent: Saturday, February 11, 2017 5:52 AM
To: Daniel Fuchs; Frank Yuan; core-libs-dev@openjdk.java.net
Subject: Re: RFR [JAXP] JDK-8170192 Regression
Hi All
Would you like to review http://cr.openjdk.java.net/~fyuan/8174025/webrev.00/?
Bug: https://bugs.openjdk.java.net/browse/JDK-8174025
JDK-8087303 introduced 2 issues:
1. Flaw when xlst uses disable-output-escaping attribute
2. Eat the whitespace between html inline
Thank you, Christoph
Frank
> -Original Message-
> From: Langer, Christoph [mailto:christoph.lan...@sap.com]
> Sent: Tuesday, January 24, 2017 6:30 PM
> To: Frank Yuan
> Cc: 'Daniel Fuchs'; core-libs-dev@openjdk.java.net
> Subject: RE: RFR (JAXP) 8169827:
> javax
> From: Langer, Christoph [mailto:christoph.lan...@sap.com]
> To: Frank Yuan
> Cc: 'Daniel Fuchs'; core-libs-dev@openjdk.java.net
> Subject: RE: RFR (JAXP) 8169827:
> javax/xml/jaxp/isolatedjdk/catalog/PropertiesTest.sh copied JDK failed
>
> Hi Frank,
>
> thank
gt; From: Langer, Christoph [mailto:christoph.lan...@sap.com]
> To: Daniel Fuchs; Frank Yuan; core-libs-dev@openjdk.java.net
> Subject: RE: RFR (JAXP) 8169827:
> javax/xml/jaxp/isolatedjdk/catalog/PropertiesTest.sh copied JDK failed
>
> Hi Daniel,
>
> thanks for checking/re
he latest visualvm binaries from the
> VisualVM project website.
>
> See https://blogs.oracle.com/java-platform-group/entry/visual_vm_in_jdk_9
>
> regards,
> Sean.
>
> On 29/12/2016 02:39, Frank Yuan wrote:
> > Hi Dmitry
> >
> > Thank you very much fo
6 4:57 PM
> To: Frank Yuan; code-tools-...@openjdk.java.net;
> core-libs-dev@openjdk.java.net
> Subject: Re: Does jvisualvm work in JDK 9?
>
> Hi,
>
> I had a similar problem on Mac. Downloaded the latest version of
> VisualVM (https://visualvm.github.io/) and it did work.
>
Hi all
I tried to run jvisualvm in Linux with both b147 and b150(by adding add-opens
option), it always quit quietly after showing a splash
screen. Does it still work?
Thanks
Frank
ions and
# limitations under the License.
##
#
# Specify defaults when method="html". These defaults use
output_xml.properties
# as a base.
#
Best,
Joe
On 12/15/16, 2:52 AM, Frank Yuan wrote:
> Hi Christoph
>
> Thank you for the review!
>
> Please check http://cr.openj
tml.properties..." part can be removed?
>
> Best regards
> Christoph
>
> > -Original Message-
> > From: core-libs-dev [mailto:core-libs-dev-boun...@openjdk.java.net] On
> > Behalf
> > Of Joe Wang
> > Sent: Mittwoch, 14. Dezember 2016 04:09
> >
t; matter, the original xml files were a mess.
>
> The tests set PrettyPrint, and by default for html. It would be good to
> test the cases when it's turned off, that would help verify the
> non-pretty format was not changed.
>
> Thanks,
> Joe
>
> On 12/13/16, 6:55 AM, Frank Yu
Hi all
Webrev http://cr.openjdk.java.net/~fyuan/8087303_8114834/webrev.00/ is for
JDK-8087303 and JDK-8114834, I have to combine the fix
because there is some interaction between them.
Bugs: https://bugs.openjdk.java.net/browse/JDK-8087303
https://bugs.openjdk.java.net/browse/JDK-8114834
Hi all
Would you like to review http://cr.openjdk.java.net/~fyuan/8169948/webrev.00/?
Bug: https://bugs.openjdk.java.net/browse/JDK-8169948
This test update is because of JDK-8169778 Add new public methods to get new
instances of the JAXP factories builtin system-default
implementations.
PM, Frank Yuan wrote:
Hi All
Would you like to review http://cr.openjdk.java.net/~fyuan/8170192/webrev.00/
<http://cr.openjdk.java.net/%7Efyuan/8170192/webrev.00/> ?
Bug: https://bugs.openjdk.java.net/browse/JDK-8170192
This patch is fully same as Daniel provided except a few
't find any other issue in jdk and langtools repo so
far.
[1]
https://adopt-openjdk.ci.cloudbees.com/job/jtreg/lastSuccessfulBuild/artifact/jtreg-4.2-b03.tar.gz
Thanks
Frank
> -Original Message-
> From: Langer, Christoph [mailto:christoph.lan...@sap.com]
> Sent: Wednesday, Nov
Hi Christoph and Volker
I have been launching jdk and langtools tests with the new jtreg, will update
to you once I get the result.
Hope jaxp test is special because most of tests should control the Security
Manager setting inside the test methods.
Thanks
Frank
> -Original Message-
Hi All
Would you like to review http://cr.openjdk.java.net/~fyuan/8170192/webrev.00/?
Bug: https://bugs.openjdk.java.net/browse/JDK-8170192
This patch is fully same as Daniel provided except a few lines of additional
cleaning, thanks to Daniel for providing the patch!
Thanks
Frank
Hi All
This is a problem list update in langtools repo:
diff -r f4b6b78a1200 test/ProblemList.txt
--- a/test/ProblemList.txt Mon Nov 21 12:28:56 2016 -0800
+++ b/test/ProblemList.txt Tue Nov 22 16:34:24 2016 +0800
@@ -38,7 +38,7 @@
jdk/jshell/EditorPadTest.java
Hi all
This is to correct the bugid in ProblemList.txt, see Bug:
https://bugs.openjdk.java.net/browse/JDK-8169829
Would you like to have a review
http://cr.openjdk.java.net/~fyuan/8169829/webrev.00/?
Thanks,
Frank
ion:
> access denied ("java.io.FilePermission" "sko?ice")"
>
> Looks fine. Paths.get is the way to go.
>
> -Joe
>
> On 10/14/16, 2:28 AM, Frank Yuan wrote:
> > Hi Joe
> >
> > After some testing, I am sure current Windows platfor
by the Windows' default encoding (Windows-1252). Does
> > that mean this test will no longer run on Windows?
> >
> > Thanks,
> > Joe
> >
> > On 10/13/16, 2:05 AM, Frank Yuan wrote:
> >>
> >> Hi all
> >>
>
ot;java.io.FilePermission" "sko?ice")"
>
> A comment on naming, alpha to ALPHA ?
> -Felix
>
> > 在 2016年10月13日，17:05，Frank Yuan <frank.y...@oracle.com> 写道：
> >
> > Hi all
> >
> >
> >
> > Would you like to review
> &g
Hi all
Would you like to review http://cr.openjdk.java.net/~fyuan/8167478/webrev.00/ ?
Bug: https://bugs.openjdk.java.net/browse/JDK-8167478
This is a test bug, because Bug6341770.java is invalid when the system
environment doesn't support non-ascii characters, the test
will exit
Hi Aleksey
Thank you very much for your review an comments!
> -Original Message-
> From: Aleksey Shipilev [mailto:sh...@redhat.com]
> Sent: Monday, September 12, 2016 6:45 PM
> To: Frank Yuan; 'core-libs-dev'
> Subject: Re: RFR (JAXP) JDK-8087303 LSSerializer pretty prin
Hi
Would you like to review http://cr.openjdk.java.net/~fyuan/8087303/webrev.01/?
Bug: https://bugs.openjdk.java.net/browse/JDK-8087303
In this patch, I add handling for whitespace text node and support for
xml:space attribute in xml serializer.
Thanks,
Frank
jaxp/test
>
> Hi Frank,
>
> just out of interest: Is it a rule not to have any LFs at the end of java
> files?
>
> Best regards
> Christoph
>
> > -Original Message-
> > From: core-libs-dev [mailto:core-libs-dev-boun...@openjdk.java.net] On
>
Thank you! Pushed.
Frank
-Original Message-
From: Joe Wang [mailto:huizhe.w...@oracle.com]
Sent: Thursday, September 08, 2016 12:11 PM
To: Frank Yuan
Cc: 'core-libs-dev'
Subject: Re: RFR JDK-8165617: Cleanup whitespace in jaxp/test
Hi Frank,
Looks good. Thanks for getting
Hi
This bug is to remove the extra LF from the end of the java files, that will
help to conform with the normalizer.
Anyone would like to take a look?
http://cr.openjdk.java.net/~fyuan/8165617/webrev.00/
Thanks
Frank
t; > than the main thread, I believe InheritableThreadLocal would not
> > be appropriate nor sufficient for that).
> >
> > JAXP multi-threaded tests might need to be revisited with that
> > in mind.
> >
> > best regards,
> >
> > -- daniel
>
is also
OK to you and Joe, I pushed it at first :)
Thanks
Frank
> JAXP multi-threaded tests might need to be revisited with that
> in mind.
>
> best regards,
>
> -- daniel
>
>
> On 10/08/16 09:06, Frank Yuan wrote:
> > Hi,
> >
> >
> >
&g
Hi,
Would you like to review http://cr.openjdk.java.net/~fyuan/8163468/webrev.00/
It is to fix https://bugs.openjdk.java.net/browse/JDK-8163468
Please check the bug comment for the root cause, this patch moved the code
which requires file permission to the main test method,
that can
Thank you! I pushed the change into jaxp repo.
Frank
> -Original Message-
> From: Joe Wang [mailto:huizhe.w...@oracle.com]
> Sent: Saturday, August 06, 2016 1:59 AM
> To: Frank Yuan
> Cc: 'Daniel Fuchs'; 'core-libs-dev'
> Subject: Re: RFR (JAXP) JDK-8067170: Enabl
mentioned it but I
didn't understand at that time :P
Thanks
Frank
> -Original Message-
> From: Frank Yuan [mailto:frank.y...@oracle.com]
> Sent: Thursday, August 04, 2016 6:06 PM
> To: 'Joe Wang'; 'Daniel Fuchs'
> Cc: 'core-libs-dev'
> Subject: RE: RFR (JAXP) JDK-806717
st.java
>
> Did you forget to hg add them?
>
>
>
>
> Otherwise the new JAXPPolicyManager & its Policy implementation
> look good. This is much simpler and better than the first
> iteration :-)
>
> This was a
Otherwise the new JAXPPolicyManager & its Policy implementation
> look good. This is much simpler and better than the first
> iteration :-)
>
> This was a *very* long patch - so congratulations for seeing
> this through!
>
Really thank you very much for having reviewed my cha
Hi Joe and Daniel
I have finished the rework as your comments, please check
http://cr.openjdk.java.net/~fyuan/8067170/webrev.02/
JAXP tests use Policy classes, as well as 3 other patterns provided by
JAXPTestUtilities:
1. runWithAllPerm methods, are only used for user setup code, never run
Hi Daniel
Thank you very much for your comments! Please check my reply inline below:
>
> Hi Frank,
>
> Please see my comments inline.
>
> On 27/07/16 10:27, Frank Yuan wrote:
> > Hi Daniel
> >
> > Would you like to have a look at the following cha
> > +/*
> > + * Install a SecurityManager along with a default Policy to allow
> > testNG to
> > + * run when there is a security manager.
> > + */
> > +private JAXPPolicyManager() {
> > +// Backing up policy and security manager for restore
> > +policyBackup =
tSystemProperty("org.xml.sax.driver", ReaderStub.class.getName());
try {
TransformerFactory transFactory = TransformerFactory.newInstance();
Transformer transformer = transFactory.newTransformer();
@@ -111,7 +115,7 @@
+ " Hello World!\n"
rework.
Thanks
Frank
> -Original Message-
> From: Daniel Fuchs [mailto:daniel.fu...@oracle.com]
> Sent: Tuesday, July 26, 2016 3:46 PM
> To: Frank Yuan; 'huizhe wang'
> Cc: 'Amy Lu'; 'core-libs-dev'
> Subject: Re: RFR (JAXP) JDK-8067170: Enable security manager on
nal Message-
> From: Daniel Fuchs [mailto:daniel.fu...@oracle.com]
> Sent: Tuesday, July 26, 2016 8:47 AM
> To: huizhe wang; Frank Yuan
> Cc: 'Amy Lu'; 'core-libs-dev'
> Subject: Re: RFR (JAXP) JDK-8067170: Enable security manager on JAXP unit
> tests
>
> On 26/07/
> -Original Message-
> From: huizhe wang [mailto:huizhe.w...@oracle.com]
> Subject: Re: RFR (JAXP) JDK-8067170: Enable security manager on JAXP unit
> tests
>
>
>
> On 7/22/2016 5:53 AM, Daniel Fuchs wrote:
> > On 22/07/16 10:15, Frank Yuan wrote:
>
} finally {
> allowAll.get().set(before);
> }
>
JAXPTestUtilities.tryRunWithTmpPermission is similar with this, see the example:
http://cr.openjdk.java.net/~fyuan/8067170/webrev.01/test/javax/xml/jaxp/unittest/stream/XMLEventReaderTest/Bug6555001.java.sdiff.htm
l
> My implementatio
According to Amy's suggestion, re-generate a webrev
http://cr.openjdk.java.net/~fyuan/8067170/webrev.01/ as well as fix some issues,
please check.
Thanks
Frank
> -Original Message-
> From: Amy Lu [mailto:amy...@oracle.com]
> Sent: Monday, July 18, 2016 5:42 PM
> To: Frank
Hi
Would you like to review http://cr.openjdk.java.net/~fyuan/8067170/webrev.00/?
Bug: https://bugs.openjdk.java.net/browse/JDK-8067170
In this change, I enabled security manager for JAXP unit tests with improving
the implementation approach and fixing some defects.
Now jaxp tests use TestNG
Hi
Would you like to review http://cr.openjdk.java.net/~fyuan/8156119/webrev.00/?
Bug: https://bugs.openjdk.java.net/browse/JDK-8156119
This change is to add/update some tests for verifying JDK-8152912: SAX
XMLReaderFactory needs to be ServiceLoader compliant, see
Joe's RFR mail thread
urity policy
>
> Hi Frank,
>
> The fix looks fine.
>
> Thanks for verifying it with my patch to deprivilege jdk.charasets.
>
> Mandy
>
> > On Apr 28, 2016, at 1:11 AM, Frank Yuan <frank.y...@oracle.com> wrote:
> >
> > Hi Mandy, Joe and all
Thank you! Pushed.
Best Regards
Frank
-Original Message-
From: Mandy Chung [mailto:mandy.ch...@oracle.com]
Sent: Friday, April 29, 2016 4:00 AM
To: Frank Yuan <frank.y...@oracle.com>
Cc: core-libs-dev <core-libs-dev@openjdk.java.net>; huizhe wang
<huizhe.w...@oracle.com
Hi Mandy, Joe and all
Would you like to review the fix for bug
https://bugs.openjdk.java.net/browse/JDK-8155514?
The webrev is at: http://cr.openjdk.java.net/~fyuan/8155514/webrev.00/.
It's verified with the source bundle in
: Tuesday, August 25, 2015 7:18 PM
To: Frank Yuan frank.y...@oracle.com
Cc: 'core-libs-dev' core-libs-dev@openjdk.java.net; 'Joe Wang'
huizhe.w...@oracle.com
Subject: Re: Review request for JDK-8133924: NPE may be thrown when xsltc
select a non-existing node after JDK-8062518
Hi Frank,
Fix looks good
Hi, Joe and all
Would you like to have a review for bug
https://bugs.openjdk.java.net/browse/JDK-8133924?
The webrev is at: http://cr.openjdk.java.net/~fyuan/8133924/webrev.00/.
I have verified this fix, the corresponding test(it will be pushed with
another test suite) and jaxp test
the
functional part sometime after that suite is finished.
Best Regards
Frank
From: huizhe wang [mailto:huizhe.w...@oracle.com]
Sent: Wednesday, August 05, 2015 2:26 AM
To: Frank Yuan frank.y...@oracle.com
Cc: 'core-libs-dev' core-libs-dev@openjdk.java.net; 'Alan Bateman'
alan.bate
Hi, Joe and all
Would you like to have a review for bug
https://bugs.openjdk.java.net/browse/JDK-8132660?
This is already on our plan for a while, but I have to finish it now because
these unit tests failed with latest Jigsaw build. However I made the changes
based on 9-dev repo, I tested
Alright, thanks a lot! :)
Best Regards
Frank
-Original Message-
From: Daniel Fuchs [mailto:daniel.fu...@oracle.com]
Sent: Thursday, June 25, 2015 2:34 PM
To: Frank Yuan; 'huizhe wang'
Cc: 'core-libs-dev'; 'Lance Andersen'; 'jibing chen'; 'Gustavo Galimberti';
sandeep.konch...@oracle.com
Hi,
Would you like to have a review for bug
https://bugs.openjdk.java.net/browse/JDK-8080266?
This bug is caused by jigsaw change, the context class loader can't load
internal resource which is in a named module any more.
To fix it, LSSerializerImpl shall invoke
Hi
Many thanks for your review!
Best Regards
Frank
-Original Message-
From: Daniel Fuchs [mailto:daniel.fu...@oracle.com]
Sent: Wednesday, June 24, 2015 4:59 PM
To: Frank Yuan; 'core-libs-dev'; 'Joe Wang'
Cc: 'Lance Andersen'; 'jibing chen'; 'Gustavo Galimberti';
sandeep.konch
So, would you like to push the code for me?
Best Regards
Frank
-Original Message-
From: huizhe wang [mailto:huizhe.w...@oracle.com]
Sent: Thursday, June 25, 2015 12:57 AM
To: Daniel Fuchs
Cc: Frank Yuan; 'core-libs-dev'; 'Lance Andersen'; 'jibing chen'; 'Gustavo
Galimberti
Hi Joe, Lance and all
Would you like to have a review for bug:
https://bugs.openjdk.java.net/browse/JDK-8080907?
I added some new tests and updated some existing tests to add more coverage
for JAXP library.
The webrev is at http://cr.openjdk.java.net/~fyuan/8080907/webrev.00/, your
Hi Joe and all
I have been working on the test task of JEP 255 Xerces Updates.
Here I would invite you to review the changes for 2 bugs of this task:
1. JDK-8080906 Develop test for Xerces Update: DOM L3 Serializer
To verify default LSSerializer is Xalan dom 3 serializer
2.
Hi, Joe and All
This is a test bug on 9-repo-jigsaw, jaxp tests failed due to internal class
access.
To fix this bug, I made the following changes:
1. moved the tests which test internal APIs to separate directory and added
@modules for them
2. for other tests which don't intend to test
Hi Joe
Do you have any comment for dom suite co-location?
Best Regards
Frank
From: Frank Yuan [mailto:frank.y...@oracle.com]
Sent: Wednesday, March 25, 2015 5:46 PM
To: 'huizhe wang'; 'Core-Libs-Dev'
Cc: 'jibing chen'; 'Gustavo Galimberti'; sandeep.konch...@oracle.com;
'Alexandre
Hi, Joe and All
We are working on moving internal jaxp functional tests to open jdk repo.
This is the astro suite. Would you please review these test? Any comment
will be appreciated.
bug: https://bugs.openjdk.java.net/browse/JDK-8051560
webrev:
Hi All
Would you like to review the code change for bug:
https://bugs.openjdk.java.net/browse/JDK-8061293, this is a Jigsaw related
bug, it's to clean up the reference to jre dir.
webrev: http://cr.openjdk.java.net/~fyuan/8061293/webrev/
Best Regards
Frank
]
Sent: Wednesday, January 28, 2015 12:36 PM
To: Frank Yuan
Cc: 'Lance Andersen'; 'Core-Libs-Dev'; 'jibing chen'; 'Gustavo Galimberti';
sandeep.konch...@oracle.com; 'Alexandre (Shura) Iline'
Subject: Re: Review request for JDK-8052401: JAXP function gap tests
conversion
Looks good.
Joe
On 1/27
[mailto:huizhe.w...@oracle.com]
Sent: Wednesday, January 28, 2015 12:44 PM
To: Frank Yuan
Cc: 'Lance Andersen'; 'Core-Libs-Dev'; 'jibing chen'; 'Gustavo Galimberti';
sandeep.konch...@oracle.com; 'Alexandre (Shura) Iline'
Subject: Re: Review request for JDK-8051710: Convert JAXP function tests
Hi, Joe, Lance and All
We are working on moving internal jaxp functional tests to open jdk repo.
This is the jaxp14 suite. Would you please review these test? Any comment
will be appreciated.
bug: https://bugs.openjdk.java.net/browse/JDK-8051710
webrev:
Hi, Joe, Lance and All
We are working on moving internal jaxp functional tests to open jdk repo.
This is the gaptest suite. Would you please review these test? Any comment
will be appreciated.
bug: https://bugs.openjdk.java.net/browse/JDK-8052401
webrev:
in javax.xml.stream.ptest, is it ok? (I would rename
XMLEventFactoryTest as its small coverage)
Best Regards
Frank
-Original Message-
From: huizhe wang [mailto:huizhe.w...@oracle.com]
Sent: Wednesday, January 28, 2015 10:27 AM
To: Frank Yuan
Cc: 'Lance Andersen'; 'Core-Libs-Dev'; 'jibing chen'; 'Gustavo
Hi, Joe and All
We are working on moving internal jaxp functional tests to open jdk repo.
This is the datatype suite. Would you please review these test? Any comment
will be appreciated.
bug: https://bugs.openjdk.java.net/browse/JDK-8051709
webrev:
Hi, Joe and All
We are working on moving internal jaxp functional tests to open jdk repo.
This is the validation suite. Would you please review these test? Any
comment will be appreciated.
bug: https://bugs.openjdk.java.net/browse/JDK-8051547
webrev:
Hi, Joe and All
We are working on moving internal jaxp functional tests to open jdk repo.
This is the parsers suite. Would you please review these test? Any comment
will be appreciated.
bug: https://bugs.openjdk.java.net/browse/JDK-8051536
webrev:
Hi Joe and All
I revised the code based on latest comments and put the webrev on
http://cr.openjdk.java.net/~joehw/jdk9/test/Frank/8043090/webrev/
Best Regards
Frank
-Original Message-
From: Frank Yuan [mailto:frank.y...@oracle.com]
Sent: Wednesday, November 05, 2014 5:12 PM
1 - 100 of 104 matches
Mail list logo
