On Mon, 22 Mar 2021 15:57:12 GMT, Jaroslav Bachorik
wrote:
> With this change it becomes possible to surface various cgroup level metrics
> (available via `jdk.internal.platform.Metrics`) as JFR events.
>
> Only a subset of the metrics exposed by `jdk.internal.platform.Metrics`
> By using these values the emitted events seem to contain useful information
> without increasing overhead (the metrics values are read from `/proc`
> filesystem so that should not be done too frequently).
Jaroslav Bachorik has updated the pull request incrementally with one
additio
On Wed, 19 May 2021 17:21:26 GMT, Erik Gahlin wrote:
> I think you need to add the hook, for the event metadata to be correct.
> Otherwise, the "period" setting will not show up.
Yes. The failed test log would indicate also the rest of the metadata not being
in a good shape. But with the hook
On Wed, 21 Apr 2021 22:38:32 GMT, Erik Gahlin wrote:
>> Jaroslav Bachorik has refreshed the contents of this pull request, and
>> previous commits have been removed. The incremental views will show
>> differences compared to the previous content of the PR.
>
> I won
On Wed, 19 May 2021 14:11:40 GMT, Jaroslav Bachorik
wrote:
>> With this change it becomes possible to surface various cgroup level metrics
>> (available via `jdk.internal.platform.Metrics`) as JFR events.
>>
>> Only a subset of the metrics exposed by `jdk.i
> By using these values the emitted events seem to contain useful information
> without increasing overhead (the metrics values are read from `/proc`
> filesystem so that should not be done too frequently).
Jaroslav Bachorik has refreshed the contents of this pull request, and previou
> By using these values the emitted events seem to contain useful information
> without increasing overhead (the metrics values are read from `/proc`
> filesystem so that should not be done too frequently).
Jaroslav Bachorik has updated the pull request with a new target base due to
On Wed, 19 May 2021 10:00:04 GMT, Severin Gehwolf wrote:
>> Jaroslav Bachorik has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains 10 commits:
>>
>> - Small fixes
>> - Remove trailing spaces
>>
> By using these values the emitted events seem to contain useful information
> without increasing overhead (the metrics values are read from `/proc`
> filesystem so that should not be done too frequently).
Jaroslav Bachorik has updated the pull request with a new target base due to
On Tue, 27 Apr 2021 09:40:01 GMT, Severin Gehwolf wrote:
>> Jaroslav Bachorik has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request cont
On Mon, 26 Apr 2021 21:20:57 GMT, Erik Gahlin wrote:
>> Jaroslav Bachorik has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request cont
On Wed, 21 Apr 2021 22:38:32 GMT, Erik Gahlin wrote:
>> Jaroslav Bachorik has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix event metadata
>
> I wonder if something similar to below could be adde
> By using these values the emitted events seem to contain useful information
> without increasing overhead (the metrics values are read from `/proc`
> filesystem so that should not be done too frequently).
Jaroslav Bachorik has updated the pull request with a new target base due to
On Wed, 21 Apr 2021 11:49:10 GMT, Erik Gahlin wrote:
>> Ok. So what would be a good rule-of-thumb for when one should introduce a
>> flag?
>
> I think we want to limit the number flags/options There are already too many,
> preferably we would have none, but some of the ones we have today, like
On Wed, 21 Apr 2021 13:21:32 GMT, Jaroslav Bachorik
wrote:
>> How does it look in proc?
>
> This was based on
> https://github.com/openjdk/jdk/blob/da860290c2657c0fb1de8c77c8dffdb35f1cf938/src/java.base/linux/classes/jdk/internal/platform/CgroupV1Metrics.java#L149
>
>
On Wed, 21 Apr 2021 11:50:25 GMT, Erik Gahlin wrote:
>> I guess we could fit those events under `Operating System/Memory` and
>> `Operating System/Processor` categories.
>> What about I/O? Currently, there is only `Operating System/Network`
>> category. The options are:
>> * Add `Operating
On Wed, 14 Apr 2021 10:26:44 GMT, Erik Gahlin wrote:
>> Jaroslav Bachorik has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains 11 commits:
>>
>> - Roll back conditional registration of container events
>&
> By using these values the emitted events seem to contain useful information
> without increasing overhead (the metrics values are read from `/proc`
> filesystem so that should not be done too frequently).
Jaroslav Bachorik has updated the pull request incrementally with one
additional
On Wed, 21 Apr 2021 11:55:48 GMT, Erik Gahlin wrote:
>> I don't see this event field being set anywhere? Which Metrics API call is
>> this using?
>
> How does it look in proc?
This was based on
On Wed, 14 Apr 2021 10:25:09 GMT, Erik Gahlin wrote:
>> Jaroslav Bachorik has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request cont
On Wed, 14 Apr 2021 11:17:14 GMT, Erik Gahlin wrote:
>> Jaroslav Bachorik has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request cont
> By using these values the emitted events seem to contain useful information
> without increasing overhead (the metrics values are read from `/proc`
> filesystem so that should not be done too frequently).
Jaroslav Bachorik has updated the pull request with a new target base due to
On Mon, 12 Apr 2021 18:53:07 GMT, Erik Gahlin wrote:
>> Jaroslav Bachorik has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove trailing spaces
>
> src/jdk.jfr/share/classes/jdk/jfr/internal/inst
> By using these values the emitted events seem to contain useful information
> without increasing overhead (the metrics values are read from `/proc`
> filesystem so that should not be done too frequently).
Jaroslav Bachorik has updated the pull request incrementally with one
additio
> By using these values the emitted events seem to contain useful information
> without increasing overhead (the metrics values are read from `/proc`
> filesystem so that should not be done too frequently).
Jaroslav Bachorik has updated the pull request incrementally with one
addi
> By using these values the emitted events seem to contain useful information
> without increasing overhead (the metrics values are read from `/proc`
> filesystem so that should not be done too frequently).
Jaroslav Bachorik has updated the pull request incrementally with one
additio
On Thu, 1 Apr 2021 15:55:59 GMT, Jaroslav Bachorik
wrote:
>>> Does each getter call result in parsing /proc, or do things aggregated over
>>> several calls or hooks?
>>
>> From the looks of it the event emitting code uses `Metrics.java` interface
>>
On Fri, 26 Mar 2021 11:05:56 GMT, Severin Gehwolf wrote:
>> Does each getter call result in parsing /proc, or do things aggregated over
>> several calls or hooks?
>>
>> Do you have any data how expensive the invocations are?
>>
>> You could for example try to measure it by temporary making
> By using these values the emitted events seem to contain useful information
> without increasing overhead (the metrics values are read from `/proc`
> filesystem so that should not be done too frequently).
Jaroslav Bachorik has updated the pull request incrementally with two
additiona
> By using these values the emitted events seem to contain useful information
> without increasing overhead (the metrics values are read from `/proc`
> filesystem so that should not be done too frequently).
Jaroslav Bachorik has updated the pull request incrementally with one
additio
> By using these values the emitted events seem to contain useful information
> without increasing overhead (the metrics values are read from `/proc`
> filesystem so that should not be done too frequently).
Jaroslav Bachorik has updated the pull request incrementally with one
additional
With this change it becomes possible to surface various cgroup level metrics
(available via `jdk.internal.platform.Metrics`) as JFR events.
Only a subset of the metrics exposed by `jdk.internal.platform.Metrics` is
turned into JFR events to start with.
* CPU related metrics
* Memory related
Hi Yuji,
On 4.1.2016 15:14, KUBOTA Yuji wrote:
Hi all,
Could you please review this patch?
Sorry for the long delay. Shanliang has not been present for some time
and probably this slipped the attention of the others.
However, core-libs mailing list might be more appropriate place to
On 9.12.2015 14:55, Severin Gehwolf wrote:
On Tue, 2015-12-01 at 14:19 +0100, Severin Gehwolf wrote:
Hi Jaroslav,
On Tue, 2015-12-01 at 12:33 +0100, Jaroslav Bachorik wrote:
On 1.12.2015 11:17, Severin Gehwolf wrote:
On Mon, 2015-11-09 at 10:32 +0100, Severin Gehwolf wrote:
On Wed, 2015-11
,
Severin
Cheers,
Severin
On Tue, 2015-11-03 at 15:45 +0100, Jaroslav Bachorik wrote:
On 2.11.2015 19:06, Severin Gehwolf wrote:
Hi,
Thanks Jaroslav and Daniel for the reviews! Comments inline.
On Mon, 2015-11-02 at 16:54 +0100, Jaroslav Bachorik wrote:
Hi,
On 2.11.2015 16:19, Daniel Fuchs wrote
On 26.11.2015 12:48, Jaroslav Bachorik wrote:
On 25.11.2015 04:11, Mandy Chung wrote:
> On Nov 24, 2015, at 6:24 PM, David Holmes <david.hol...@oracle.com>
wrote:
>
> On 25/11/2015 10:06 AM, Mandy Chung wrote:
>>
>>> On Nov 24, 2015, at 3:45 PM, Peter Levart
On 25.11.2015 04:11, Mandy Chung wrote:
> On Nov 24, 2015, at 6:24 PM, David Holmes <david.hol...@oracle.com> wrote:
>
> On 25/11/2015 10:06 AM, Mandy Chung wrote:
>>
>>> On Nov 24, 2015, at 3:45 PM, Peter Levart <peter.lev...@gmail.com> wrote:
>>>
Hi,
while working on an issue to clean up a code in java.base module using
reflection to access RuntimeMXBean (from java.management module) in
order to get hold of the VM arguments (yes, this won't work with module
boundaries in place) it was pointed out that this functionality should
be
On 2.11.2015 19:06, Severin Gehwolf wrote:
Hi,
Thanks Jaroslav and Daniel for the reviews! Comments inline.
On Mon, 2015-11-02 at 16:54 +0100, Jaroslav Bachorik wrote:
> Hi,
>
> On 2.11.2015 16:19, Daniel Fuchs wrote:
>> Hi Severin,
>>
>> Adding servicea
Adding core libs.
On 2.11.2015 11:38, Severin Gehwolf wrote:
Hi,
Here is a patch addressing JDK-6425769. The issue is that the JMX agent
binds to the wildcard address by default, preventing users to use
system properties for JMX agents on multi-homed hosts. Given a host
with local network
Hi,
On 2.11.2015 16:19, Daniel Fuchs wrote:
Hi Severin,
Adding serviceability-...@openjdk.java.net into the loop - that's
a better alias than hotspot-dev for this kind of changes - maybe
someone from serviceability-dev will offer to sponsor :-)
I will let serviceability team members comment
Hi Katja,
This request should probably go to core-libs as well.
Other than that I have just a few nits:
test/java/util/logging/TestLoggerWeakRefLeak.java
L57: if (Logger.contains(args[0])) - Logger.equals(args[0]) ?
L127: // in LogManager.loggers that *arebeing* properly managed - *are
Looks good. Additional benefit is the compliance with the secure coding guide.
-JB-
On February 7, 2014 11:46:07 AM CET, Staffan Larsen staffan.lar...@oracle.com
wrote:
A few of the public read and write methods in FileInputStream and
RandomAccessFile are declared native. This means that it is
Changeset: 4afe1281c837
Author:jbachorik
Date: 2013-11-28 09:10 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4afe1281c837
6987597: ManagementFactory.getGarbageCollectorMXBeans() returns empty list with
CMS
Reviewed-by: mchung
!
Changeset: d842131d12d8
Author:jbachorik
Date: 2013-11-18 15:25 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d842131d12d8
8027163: sun/management/jmxremote/bootstrap/CustomLauncherTest.java should be
updated for jdk8 removal of solaris-32bit support
Reviewed-by: sla
!
Changeset: 0298ebbaf3b8
Author:jbachorik
Date: 2013-11-18 16:20 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0298ebbaf3b8
8028433: [TESTBUG] add -XX:+UsePerfData to some sun.management tests
Reviewed-by: sla, egahlin
!
Changeset: 680ef14a2cc0
Author:jbachorik
Date: 2013-11-13 13:12 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/680ef14a2cc0
8004126: TEST_BUG: com/sun/jdi/BadHandshakeTest.java fails intermittently
Reviewed-by: dholmes, ykantser
! test/com/sun/jdi/BadHandshakeTest.java
Changeset: 0c75cc07d264
Author:jbachorik
Date: 2013-11-10 20:05 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0c75cc07d264
6523160: RuntimeMXBean.getUptime() returns negative values
Summary: RuntimeMXBean.getUptime() should be based on HR timers rather than on
the OS time
Changeset: b5748857ef42
Author:jbachorik
Date: 2013-11-08 08:47 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b5748857ef42
8007984: Null pointer dereference in
jdk/linux-amd64/democlasses/demo/jvmti/heapTracker/src/java_crw_demo.c
Reviewed-by: dholmes
!
Changeset: 5d1bda6c1fe3
Author:jbachorik
Date: 2013-10-30 14:50 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5d1bda6c1fe3
8027058: sun/management/jmxremote/bootstrap/RmiBootstrapTest.sh Failed to
initialize connector
Summary: Dynamically discover the first available port
Changeset: 2a714dabb624
Author:jbachorik
Date: 2013-10-30 17:54 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2a714dabb624
8020467: Inconsistency between usage.getUsed() and isUsageThresholdExceeded()
with CMS Old Gen pool
Reviewed-by: mchung, brutisso
!
Changeset: a3ac9c0b19a9
Author:jbachorik
Date: 2013-10-29 21:49 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a3ac9c0b19a9
8027358: sun/management/jmxremote/bootstrap/LocalManagementTest.java failing
since JDK-8004926
Reviewed-by: alanb, egahlin
!
Changeset: f4970c7abe93
Author:jbachorik
Date: 2013-10-23 15:03 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f4970c7abe93
7112404: 2 tests in java/lang/management/ManagementFactory fails with G1
because expect non-zero pools
Reviewed-by: mchung, sjiang
!
Changeset: 30c46debdf0f
Author:jbachorik
Date: 2013-10-21 10:40 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/30c46debdf0f
7197919: java/lang/management/ThreadMXBean/ThreadBlockedCount.java has
concurency issues
Reviewed-by: sla, mchung
!
Changeset: d8694ad1ed2d
Author:jbachorik
Date: 2013-10-21 10:54 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d8694ad1ed2d
8024613: javax/management/remote/mandatory/connection/RMIConnector_NPETest.java
failing intermittently
Summary: RMID needs a varying amount of time to
Changeset: 698baf22e081
Author:jbachorik
Date: 2013-10-21 13:57 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/698baf22e081
7140929: NotSerializableNotifTest.java fails intermittently
Reviewed-by: sjiang, alanb
!
Changeset: abe8d432f714
Author:jbachorik
Date: 2013-10-15 10:26 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/abe8d432f714
6804470: JvmstatCountersTest.java test times out on slower machines
Summary: Increasing the default timeout to cater for the slower machines
Changeset: da9de6f5cd6f
Author:jbachorik
Date: 2013-09-06 10:03 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/da9de6f5cd6f
6815130: Intermittent ThreadMXBean/Locks.java test failure
Summary: Preventing stale reads from ThreadExecutionSynchronizer.waiting flag
Reviewed-by:
Changeset: af1b08ff48ae
Author:jbachorik
Date: 2013-09-05 13:04 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/af1b08ff48ae
8023464: test/closed/sun/tracing/ProviderProxyTest.java failing
Summary: Don't rely on assertions when an Exception suits better
Reviewed-by: alanb,
Changeset: 9522b5e836d3
Author:jbachorik
Date: 2013-09-05 14:34 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9522b5e836d3
8004179: Few of test/java/lang/management/ThreadMXBean/* tests don't clean up
the created threads
Summary: Just run those tests in othervm mode.
Changeset: 8e098a29ecd8
Author:egahlin
Date: 2013-08-16 17:02 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8e098a29ecd8
6417702: Graph in Memory tab is not redrawn immediately if changed via 'Chart'
combo box
Reviewed-by: alanb, jbachorik, sjiang
!
Changeset: 952476b80fa7
Author:jbachorik
Date: 2013-07-26 10:12 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/952476b80fa7
8020875: java/lang/management/ThreadMXBean/ResetPeakThreadCount.java fails
intermittently
Reviewed-by: dfuchs, chegar
!
Changeset: a46982a212e0
Author:jbachorik
Date: 2013-07-11 09:21 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a46982a212e0
8019826: Test com/sun/management/HotSpotDiagnosticMXBean/SetVMOption.java fails
with NPE
Reviewed-by: sjiang, dholmes, mchung
!
Changeset: f3211af79339
Author:jbachorik
Date: 2013-07-11 21:11 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f3211af79339
8010285: Enforce the requirement of Management Interfaces being public
Reviewed-by: sjiang, dfuchs, mchung
!
Changeset: dc22b7241a70
Author:jbachorik
Date: 2013-05-30 13:58 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/dc22b7241a70
8015627:
test/com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.java
fails in agentvm mode
Reviewed-by: alanb, chegar
!
Changeset: 7d9fab5d86cd
Author:jbachorik
Date: 2013-05-28 15:57 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7d9fab5d86cd
8005472:
com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.sh
failed on windows
Reviewed-by: chegar, smarks, dfuchs
!
Changeset: 470f19b6bfdd
Author:jbachorik
Date: 2013-05-02 13:21 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/470f19b6bfdd
7199324: Connection ID for IPv6 addresses is not generated accordingly to the
specification
Summary: RemoteServer.getClientHost is returning a String
Changeset: 3119f0ebb58d
Author:jbachorik
Date: 2013-02-05 12:36 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3119f0ebb58d
8005791: Remove java.beans.* imports from com.sun.jmx.mbeanserver.Introspector
Reviewed-by: rbackman
!
Changeset: 9ffcd758e2be
Author:jbachorik
Date: 2013-02-05 12:28 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9ffcd758e2be
7170447: Intermittent DeadListenerTest.java failure
Summary: Due to asynchronous nature of processing server notifications it may
happen that an
69 matches
Mail list logo
