Re: [9] RFR of JDK-8085192: java/rmi/activation/Activatable tests fail intermittently due to "Port already in use"

Hello, Without commenting on the particulars, I'm happy to see work being done to address this issue in running the RMI tests. A fix here should greatly increase the reliability of the JDK test suite! Thanks, -Joe On 9/29/2016 12:09 PM, Chris Hegarty wrote: On 29 Sep 2016, at 16:25, Chris

Re: JDK 9 RFR of JDK-8164524: Correct inconsistencies in floating-point abs spec

ng if the value is positive? s/of/indicating a/ ? On Mon, Aug 22, 2016 at 1:47 PM, Joseph D. Darcy<mailto:joe.da...@oracle.com>>wrote: Hello, I plan to push with a slightly different wording. Rather than ... but with a guaranteed positive sign bit: using ...but

Re: JDK 9 RFR of JDK-8164524: Correct inconsistencies in floating-point abs spec

Hello, I plan to push with a slightly different wording. Rather than ... but with a guaranteed positive sign bit: using ...but with a guaranteed zero sign bit of a positive value: I think the latter is clearer. Thanks, -Joe On 8/22/2016 11:41 AM, Brian Burkhalter wrote: Hi Joe, T

JDK 9 RFR of JDK-8162746: VersionCheck.java failure after change for JDK-8160921

Hello, When the binary p2launcher was renamed to jweblauncher (JDK-8160921), the test tools/launcher/VersionCheck.java did not get the corresponding update and started failing. Please review the patch below to address this. Thanks, -Joe --- a/test/tools/launcher/VersionCheck.javaThu J

JDK 9 RFR of JDK-8162666: Mark ValidationWarningsTest.java as intermittently failing

The test javax/xml/jaxp/unittest/common/ValidationWarningsTest.java is known to intermittently fail (JDK-8150145) and should be marked accordingly. Please review the patch below with does this (and removes an unnecessary space from the TEST.ROOT file). Thanks, -Joe --- a/test/TEST.ROOT

Re: JDK 9 RFR of JDK-8161567: Mark java/util/concurrent/forkjoin/FJExceptionTableLeak.java as intermittently failing

Hello, While the underlying issues are being investigated, I think it is worthwhile to tag the test as intermittently failing to aid those having to QA any if its failures. Cheers, -Joe On 7/18/2016 4:56 PM, David Holmes wrote: Hi Martin, On 19/07/2016 12:38 AM, Martin Buchholz wrote: Li

JDK 9 RFR of JDK-8161500: Use getTypeName and StringJoiner in core reflection toString methods

Hello, Please review this straightforward cleanup of some of the core reflection implementation classes: JDK-8161500: Use getTypeName and StringJoiner in core reflection toString methods http://cr.openjdk.java.net/~darcy/8161500.1/ All java/lang/Class and java/lang/reflect regressio

Re: JDK 9 RFR of problem listing of several http2 tests

PS The line for ErrorTest is better as +java/net/httpclient/http2/ErrorTest.java 8158127 solaris-all,windows-all Cheers, -Joe On 6/28/2016 2:57 PM, Joseph D. Darcy wrote: Hello, Several of the http2 tests have been observed to fail intermittently with relatively high frequency on various

JDK 9 RFR of problem listing of several http2 tests

Hello, Several of the http2 tests have been observed to fail intermittently with relatively high frequency on various of our tests systems. I'd like to problem lists these tests while the underlying issues are being worked on. Patch below. Thanks, -Joe diff -r 5cfbcb4e6009 test/ProblemList

Re: RFR: 8150680 JarFile.Release enum needs reconsideration with respect to it's values

Steve, In JarFile, please use methods not fields to return the new information. The information in question is not constant across versions. Using methods instead of fields avoid over-committing on a particular implementation, etc. Cheers, -Joe On 6/15/2016 3:49 PM, Steve Drach wrote: I’v

JDK 9 RFR of JDK-8071859: AnnotationInvocationHandler.equals(Object) return true when apply to annotation

Hello, Please review the changes to address JDK-8071859: AnnotationInvocationHandler.equals(Object) return true when apply to annotation http://cr.openjdk.java.net/~darcy/8071859.0/ Thanks, -Joe

Re: Chair voting to *accept* (rather than approve) 8159111: JShell API: Add access to wrappers and dependencies

On 6/14/2016 5:44 PM, Joseph D. Darcy wrote:

Chair voting to approve 8159111: JShell API: Add access to wrappers and dependencies

Re: RFR[9]: 8147585: Annotations with lambda expressions has parameters result in wrong behavior.

Hello, The test 45 void testAnnotationWithLambda() { 46 Method[] methods = AnnotationWithLambda.MethodsWithAnnotations.class.getDeclaredMethods(); 47 for (Method method : methods) { 48 assertEquals(1, method.getDeclaredAnnotations().length); 49

JDK 9 RFR Update String.join sample code to use List convenience factory methods

Hello, The String.join javadoc contains some sample code to demonstrate how to use the method. The sample code can be improved with the new-in-JDK-9 List convenience factory method. Please review this patch to update the sample code: --- a/src/java.base/share/classes/java/lang/String.java

Re: RFR(s): 8157777: RMI test DeadCachedConnection doesn't wait for registry to die

Hi Stuart, Looks good; thanks, -Joe On 5/31/2016 5:01 PM, Stuart Marks wrote: Hi all, Please review this small test fix to improve the reliability of an RMI test. Basically this waits for a subprocess to exit instead of proceeding immediately. webrev: http://cr.openjdk.java.net/~smar

JDK 9 RFR of problem listing of java_sql_Timestamp.java

Hello, After the push for , the test java/beans/XMLEncoder/java_sql_Timestamp.java is failing across platforms. I'd like to problem list the test until the fix for JDK-8158281: "java_sql_Timestamp.java fails with AssertionError" is ready. Patch below. Thanks, -Joe --- a/test/ProblemL

Re: RFR(xs): 8059361: Properties.stringPropertyNames() returns a set inconsistent with the assertions from the spec

Looks fine Stuart; thanks, -Joe On 5/25/2016 4:11 PM, Stuart Marks wrote: Hi all, Please review this small spec change. Properties.stringPropertyNames() seems to imply that the Set it returns is modifiable. It is, but only partially. Since it's a keySet() from a Hashtable, it supports remova

JDK 9 RFR of JDK-8157487: Mark ZoneId.java as intermittently failing

Hello, The test sun/net/www/protocol/http/ZoneId.java has been seen to intermittently fail (JDK-8085785) and should be marked accordingly. Please review the patch below which does this. Thanks, -Joe --- a/test/sun/net/www/protocol/http/ZoneId.javaFri May 20 14:41:41 2016 -0700 +++

Re: RFR(xs): 8156810 remove redundant sentence in SecurityManager.checkMemberAccess doc

Looks fine Stuart, -Joe On 5/11/2016 4:47 PM, Stuart Marks wrote: Hi all, Regarding this bug, https://bugs.openjdk.java.net/browse/JDK-8156810 I had recently "upgraded" the deprecation annotation of SecurityManager.checkMemberAccess() to include forRemoval=true. [1] [2] This included t

Re: JDK 9 RFR of JDK-4943627 Deprecate rounding mode integer constants in BigDecimal and their uses

Hi Brian, Pushed with updated copyright range; thanks, -Joe On 5/3/2016 3:22 PM, Brian Burkhalter wrote: Hi Joe, On Apr 30, 2016, at 8:24 PM, joe darcy > wrote: Please review the changes to address JDK-4943627 Deprecate rounding mode integer constants in B

Re: JDK 9 RFR of adding a few @jls tags to java.lang.String

Hi David, On 5/2/2016 5:01 AM, David Holmes wrote: On 1/05/2016 5:34 AM, joe darcy wrote: Hello, Please review the small patch below to add some JLS references to the string class to supplement its textual discussion of a few sections of the JLS. Side question: what mechanism is there to det

Re: RFR 9: 8066750 broke jdk9 builds; backup the changeset

+1 if it is just applying an anti-delta to the earlier change. Thanks, -Joe On 4/26/2016 6:14 PM, Roger Riggs wrote: Please review the backout of the change for 8806750 which broke some builds that have not yet removed a dependency. Webrev: http://cr.openjdk.java.net/~rriggs/webrev-backout

Re: JDK 9 pre-review of JDK-6850612: Deprecate Class.newInstance since it violates the checked exception language contract

Hello, With that feedback, I'll go ahead and prepare a changeset for the deprecation of this method and the suppression of the resulting warnings. Thanks, -Joe On 4/18/2016 5:26 PM, David Holmes wrote: I agree with Stuart. David On 19/04/2016 9:05 AM, Stuart Marks wrote: On 4/17/16 10:

Re: JDK 9 RFR of JDK-4851642: Add fused mac to Java math library

Hi Brian, On 4/14/2016 5:55 PM, Brian Burkhalter wrote: Hi Joe, This all looks good aside from the “@code fusedMac” in the javadoc of which I believe you are aware. Doh! s/fusedMac/fma in my working copy. Thanks for the review, -Joe

Re: JDK 9 RFR of JDK-4851642: Add fused mac to Java math library

Hi Brian and Dmitry, On 4/13/2016 12:43 PM, Brian Burkhalter wrote: Joe / Dmitry, On Apr 12, 2016, at 5:21 PM, joe darcy > wrote: Please review the changes for JDK-4851642: Add fused mac to Java math library http://cr.openjdk.java.net/~darcy/4851642.0/

Re: JDK 9 RFR of JDK-8154031: Mark tools/pack200/BandIntegrity.java as intermittently failing

Looks fine Amy; thanks, -Joe On 4/11/2016 6:50 PM, Amy Lu wrote: tools/pack200/BandIntegrity.java This test is known to fail intermittently (JDK-8153815). This patch is to mark the test accordingly with keyword 'intermittent'. bug: https://bugs.openjdk.java.net/browse/JDK-8154031 webrev: ht

Re: JDK 9 RFR of JDK-8151763; Use more informative format for problem list

: The fix looks fine to me. can you please clarify what "enabling better reporting" from the bug description means? Where this information will be reported? On 31.03.16 2:48, Joseph D. Darcy wrote: Hi Mandy, Hopefully the third time will be the charm for this changeset after your cor

Re: JDK 9 RFR of JDK-8151763; Use more informative format for problem list

ebrev since the tab expansion is different than in a text editor.) Thanks, -Joe On 3/29/2016 12:31 PM, Mandy Chung wrote: On Mar 29, 2016, at 12:15 PM, joe darcy wrote: Hi Mandy, On 3/28/2016 8:48 PM, Mandy Chung wrote: On Mar 28, 2016, at 5:03 PM, Joseph D. Darcy wrote: Hello, New iterati

Re: RFR 9: 8152005: sun/misc/SunMiscSignalTest.java failed intermittently

lace, http://cr.openjdk.java.net/~rriggs/webrev-signal-8152005/ Thanks, Roger On 3/28/2016 8:29 PM, Joseph D. Darcy wrote: Hi Roger, If the test is only rarely failing as-is, I'd prefer to keep the first timeout short and only fallback to the longer timeout in the fallback case. Wh

Re: RFR 9: 8152005: sun/misc/SunMiscSignalTest.java failed intermittently

Hi Roger, If the test is only rarely failing as-is, I'd prefer to keep the first timeout short and only fallback to the longer timeout in the fallback case. What do you think? Thanks, -Joe On 3/28/2016 11:22 AM, Roger Riggs wrote: Please review this improvement to an intermittently failing

Re: JDK 9 RFR of JDK-8151763; Use more informative format for problem list

Hello, New iteration of the webrev updated after the Jigsaw integration and incorporating the earlier feedback. http://cr.openjdk.java.net/~darcy/8151763.1 Thanks, -Joe On 3/16/2016 4:52 PM, Joseph D. Darcy wrote: Hi Jon, Noted; I'll make that improvement in the next round. T

Re: JDK 9 RFR of JDK-8151763; Use more informative format for problem list

Just a follow-up, to avoid causing additional merge headaches, I'll revise the patch to make this change once the next round of Jigsaw changes get back in jdk9/dev (http://mail.openjdk.java.net/pipermail/jdk9-dev/2016-March/003877.html). Thanks, -Joe On 3/12/2016 1:28 PM, Chris Hegarty wrote

Re: JDK 9 RFR of JDK-8151763; Use more informative format for problem list

Hi Jon, Noted; I'll make that improvement in the next round. Thanks for pointing this out, -Joe On 3/16/2016 4:50 PM, Jonathan Gibbons wrote: On 03/11/2016 07:28 PM, joe darcy wrote: Hello, As Jon Gibbons has noted off-list, the problem list entries can directly include the bug number as

Re: RFR: 8150533 - Test java/util/logging/LogManagerAppContextDeadlock.java times out intermittently.

Hi Daniel, Looks fine; thanks, -Joe On 2/25/2016 6:30 AM, Daniel Fuchs wrote: Hi, Please find below a simple fix for 8150533 - Test java/util/logging/LogManagerAppContextDeadlock.java times out intermittently. This is a test bug. The issue is that the logger created by thread t2 might ge

Re: RFR: 8135108: java/util/zip/TestLocalTime.java fails intermittently with Invalid value for NanoOfSecond

Looks fine Sherman; thanks, -Joe On 2/15/2016 2:45 PM, Xueming Shen wrote: Hi, Please help review the changes for JDK-8135108 issue: https://bugs.openjdk.java.net/browse/JDK-8135108 webrev: http://cr.openjdk.java.net/~sherman/8135108 It's a overflow of the low 32-bit of xdostime when the yea

Re: RFR: 8072379: Implement jdk.Version and jdk.OracleVersion

Hi Iris, Catching up on old reviews, the regular expression for versions is given as ^[1-9][0-9]*(((\.0)*\.[1-9][0-9]*)*)*$ Is this equivalent to ^[1-9][0-9]*(\.[0-9])* Trying to put this in words, "The version number starts with a sequence of digits where the leading digit is not "0

Re: 8049422: Remove @jdk.Exported

Looks fine Alan; cheers, -Joe On 1/7/2016 3:15 AM, Alan Bateman wrote: It's time to remove @jdk.Exported. As background, this annotation was introduced by JEP 179 in JDK 8 to document the supportness of JDK-specific APIs. It will become redundant and confusing once we bring the module syste

Re: [9] RFR of 8032027: Add BigInteger square root methods

on of MutableBigInteger I changed "if (bitLength() < 63)" to "if (bitLength() <= 63)". I realized that in that case the entire calculation might as well be done in longs so I changed it accordingly. The modified test passes with this new revision. Thanks, Brian On Dec

Re: [9] RFR of 8032027: Add BigInteger square root methods

) behaves well too ;-) Thanks, -Joe On 12/9/2015 5:41 PM, Brian Burkhalter wrote: Hi Joe, On Dec 1, 2015, at 7:25 PM, Joseph D. Darcy <mailto:joe.da...@oracle.com>> wrote: Current version looks okay. One more request, before pushing please add explicit test cases for the for the

Re: RFR: JDK-8057804: AnnotatedType interfaces provide no way to get annotations on owner type

Hi Joel, Sorry for the delay in reviewing. For the specification, it should seem reasonable to me to have the default implementation of AnnotatedType.getAnnotatedOwnerType() to return null rather than throwing an UnsupportedOperationException. Following experience with similar structures in

Re: RFR(s): JDK-8144952: add wildcards to the Map.ofEntries() method

Looks fine Stuart; thanks, -Joe On 12/9/2015 4:22 PM, Stuart Marks wrote: Hi all, Joe Darcy pointed out that API changes I pushed into jdk9-dev yesterday are missing wildcards from the Map.ofEntries() method. Please see this bug: https://bugs.openjdk.java.net/browse/JDK-8144952 The Map

Re: RFR JDK-8144958: changes by JDK-8142508 seems to have broken jtreg

Approved to back out the earlier changeset while the investigation is underway. Thanks, -Joe On 12/8/2015 4:40 PM, Xueming Shen wrote: Please help review the change for 8144958. issue: https://bugs.openjdk.java.net/browse/JDK-8144958 webrev: http://cr.openjdk.java.net/~sherman/8144958/ The

Re: [9] RFR of 8032027: Add BigInteger square root methods

Hi Brian, On 11/30/2015 3:24 PM, Brian Burkhalter wrote: Hi Joe, On Nov 29, 2015, at 10:01 AM, joe darcy > wrote: The "if (...) " logic that is repeated a few times in this method could be pulled out into its own method, possibly one structured a bit differently

Re: RFR 9: 8143876 : test/java/lang/ProcessHandle/TreeTest.java failed intermittently with assertion error

Hi Roger, Looks fine. Do you know if there are clock skew issues to be concerned with if the parent and child are spawned on different CPUs? Thanks, -Joe On 12/1/2015 5:49 PM, Roger Riggs wrote: Please review this change in ProcessHandle to validate parent pids provided by the OS. Children

Re: JDK 9 RFR of JDK-8142370: Move java/util/concurrent/Phaser/Basic.java to tier 2

On 11/9/2015 7:56 PM, Martin Buchholz wrote: I approve this change. @key intermittent also added in CVS. We also observe this test to fail, but only very rarely. We do want to eventually address all the test failures, even the rare intermittent ones :-) Thanks, -Joe

Re: RFR - 8132734: java.util.jar.* changes to support multi-release jar files

On 10/14/2015 1:56 PM, Steve Drach wrote: The current test directory contains binary jar files. In fact in all the test directories, there are 52 binary .jar files. I know but we need to work to remove those. I figured that might be the response, but thought it was worth the try ;-) A reason

Re: JDK 9 RFR of JDK-8136799 Port fdlibm cbrt to Java

Hi Brian, On 10/14/2015 1:34 PM, Brian Burkhalter wrote: Hi Joe, On Oct 12, 2015, at 8:53 AM, joe darcy > wrote: Please review the next step of porting fdlibm to Java, the cbrt method: JDK-8136799 Port fdlibm cbrt to Java http://cr.openjdk.java.net/~darcy/813

Re: Spin Loop Hint support: Draft JEP proposal

On 10/6/2015 6:28 PM, Gil Tene wrote: On Oct 6, 2015, at 1:02 PM, Doug Lea wrote: On 10/04/2015 12:22 PM, Gil Tene wrote: I would like to circulate this draft JEP proposal for initial review and consensus building purposes. Some background: about two years ago, Dave Dice and I put together

Re: [9] RFR of 8023217: Additional floorDiv/floorMod/multiplyExact methods for java.lang.Math

Hi Brian, Do you think any tests are needed here, at least for a quick sanity check? Thanks, -Joe On 9/28/2015 6:06 PM, Brian Burkhalter wrote: Please review at your convenience. Issue: https://bugs.openjdk.java.net/browse/JDK-8023217 Patch: http://cr.openjdk.java.net/~bpb/8023217/webrev.0

Re: RFR 8135248: Add utility methods to check indexes and ranges

Hello, Joining this thread late, I think the range checking methods would have a happier life where they are more often found and used if the they live somewhere other than the exception classes. The class java.util.Objects is not an ideal host for these methods, since they don't deal direct

Re: JDK 9 RFR of JDK-8134795: Port fdlibm pow to Java

PS Bug JDK-8136874: Bug in port of fdlibm pow to Java https://bugs.openjdk.java.net/browse/JDK-8136874 has been filed and I've started working on a fix. Thanks, -Joe On 9/17/2015 9:10 PM, joe darcy wrote: Hi Jeff, Thanks for the bug report; I'll take a look into this, -Joe On 9/17

JDK 9 RFR of JDK-7130085 Port fdlibm hypot to Java

Hello, Please review the next portion of the port of fdlibm to Java: JDK-7130085 Port fdlibm hypot to Java http://cr.openjdk.java.net/~darcy/7130085.0/ As before with pow, this isn't necessarily the end state of the code we'd like to stop at, but it should be sufficiently idiomatic Jav

JDK 9 RFR of JDK-8134795: Port fdlibm pow to Java

Hello, At long last, I've started the port of the C version of FDLIBM (freely distributable math library) from C to Java, beginning with the pow method: JDK-8134795: Port fdlibm pow to Java http://cr.openjdk.java.net/~darcy/8134795.6/ The FDLIBM algorithms provide direct backing to th

JDK 9 RFR of JDK-8136506: Include sun.arch.data.model as a property that can be queried by jtreg

Hello, Please review the patch below for JDK-8136506: Include sun.arch.data.model as a property that can be queried by jtreg The jtreg TEST.ROOT file in the HotSpot repository puts sun.arch.data.model on the list of properties which can be queried by an @requires clause in jtreg. This

Re: RFR 9: 8133552 : java/lang/ProcessHandle/InfoTest.java fails intermittently - incorrect user

Hi Roger, If timeouts need to be used, I suggest rather than fixed values they be adjusted according to the timeout factor being used in the test run. Can some sort of repeated testing with exponential backout to a longer timeout be used ? If the system is actually ready is a fraction of a s

JDK 9 RFR of JDK-8134982: Problem list TCKJapaneseChronology.java

Hello, Until the HotSpot issue in JDK-8134979 is addressed, the test java/time/tck/java/time/chrono/TCKJapaneseChronology.java should be placed on the problem list to avoid repeated uninformative test failures. Please review the patch below. Thanks, -Joe diff -r d9bd64884486 test/Prob

Re: RFR 8073056: Repeating annotations throws java.security.AccessControlException with a SecurityManager

Belatedly, the http://cr.openjdk.java.net/~jfranck/8073056/webrev.02/ webrev looks fine other than a missing space in a line of AnnotationSuport.java: 208 }catch (Throwable t) { // from InvocationHandler::invoke Thanks, -Joe On 3/28/2015 3:24 AM, Joel Borggrén-Fra

Re: JDK 9 RFR of JDK-8133588: Place TimeoutLockLoops.java on the problem lis

Hi David, On 8/13/2015 2:30 PM, David Holmes wrote: Joe, This is making it hard to clean up everything at once. I'm already delayed from pushing the fix because the "@key intermittent" change is not in hs-rt yet. If the test needs to be updated as part of the fix for JDK-8029453, presumabl

Chair voting to approve 8041565: JMX ObjectName could be refactored to save memory

Re: RFR(xs): 8132745: minor cleanup of java/util/Scanner/ScanTest.java

Looks fine Stuart, -Joe On 7/30/2015 3:39 PM, Stuart Marks wrote: Hi all, Please review this quick cleanup to this test I moved into the open yesterday. It changes the JVM's locale, and out of an abundance of caution it's safer to run things that change JVM global state in /othervm mode.

Re: RFR 9: JDK-8130877 : (process) java/lang/ProcessHandle/TreeTest test3 failure - Destroyed process.isAlive

Hi Roger, Looks fine; thanks, -Joe On 7/13/2015 2:13 PM, Roger Riggs wrote: Please review a testbug to correctly look for destroyed processes. Webrev: http://cr.openjdk.java.net/~rriggs/webrev-isalive-8130877/ Issue: https://bugs.openjdk.java.net/browse/JDK-8130877 Thanks, Roger

Re: [9] RFR: 8130753: Sync-up javadoc changes in jax-ws area - includes JAX-B API, JAX-WS API, SAAJ-API

Hello, Note that as part of JEP 212, large parts of the sources in the jdk are now compiled with both lint and doclint checks enabled. For technical reasons explained in "FYI, coming soon: doclint checking of references" http://mail.openjdk.java.net/pipermail/jdk9-dev/2015-June/002343.htm

Re: RFR 9: 8098852 : java/lang/ProcessHandle/InfoTest.java failed: total cpu time

Hi Roger, Le me be more explicit, is getCpuTime() something that gets normalized to zero-ish at the start of each run or is it just a shapshot of some nano-second granularity counter? If it is the latter, it is possible that the counter value is negative or near the long overflow threshold.

Re: RFR 9: 8130296 [TESTBUG] java/lang/ProcessHandle/OnExitTest - Unaccounted for children

Looks good Roger; thanks, -Joe On 7/8/2015 2:08 PM, Roger Riggs wrote: Hi Joe, Webrev updated in place. The jdk.testlibrary.Utils.adjustTimeout(timeout) returns the timeout adjusted by the jtreg -timeoutFactor argument. Thanks, Roger On 7/8/2015 4:50 PM, joe darcy wrote: Hi Roger, I th

Re: RFR 9: 8085981 java/lang/ProcessHandle/OnExitTest.java: AssertionError: Child onExit not called

Looks fine; thanks, -Joe On 7/7/2015 5:57 PM, Roger Riggs wrote: Please review this test fix for a race condition checking that the onExit CompletableFuture was completed and with the correct value. Webrev: http://cr.openjdk.java.net/~rriggs/webrev-onexit-8085981/ Issue: https://bugs.openjdk

Re: RFR: 8129601: [launcher] test VersionCheck.java fails with new version string (more removal of dead code)

Looks fine Kumar; cheers, -Joe On 6/26/2015 7:20 AM, Kumar Srinivasan wrote: Hi, Please review fix to remove unused dead code, this was needed by mJRE, but with the removal of that, this also is no longer necessary and will make the build infra simpler as individual version numbers info. need

Re: RFR(s): 8080450: doc for Double/Int/LongSummaryStatistics.toString has errors

Hi Stuart, The changes look good; a ccc is not necessary IMO. Thanks, -Joe On 6/24/2015 1:37 PM, Stuart Marks wrote: Hi all, Please review this small javadoc change to the Double/Int/LongSummaryStatistics classes' toString() method specifications. Basically they all inherit the Object.toSt

FYI, make file support for tiered testing targets underway, JDK-8075571: Support tiered testing make targets

Hello jaxp and core-libs teams, FYI, I have some in-progress changes to add Makefile support for tiered testing: JDK-8075571: Support tiered testing make targets http://cr.openjdk.java.net/~darcy/8075571.0/ This involves adding some new TEST.group definitions in the jdk and jaxp repo

Re: RFR 9: [TESTBUG] 8078582: java/lang/Runtime/exec/LotsOfOutput.java fails intermittently with Process consumes memory

been made so that there is an opportunity to verify that the fix holds up and reduces the probability of failure. Thanks, -Joe Roger On 5/19/15 10:21 PM, Joseph D. Darcy wrote: On 5/19/2015 7:14 PM, Martin Buchholz wrote: Thanks, Roger. This is a much better test now (but still not

Re: RFR 9: [TESTBUG] 8078582: java/lang/Runtime/exec/LotsOfOutput.java fails intermittently with Process consumes memory

On 5/19/2015 7:14 PM, Martin Buchholz wrote: Thanks, Roger. This is a much better test now (but still not actually a good one...) Probably want to be optimistic and delete + * @key intermittent That is an interesting (and as yet unresolved) policy question: how should removal of intermitten

Re: JDK 9 RFR of JDK-8075284: fix up miscellaneous TM constructions

Hi Joe, I just wanted to keep this changeset focused on the TM issues, but I don't oppose the other improvements you've suggested being made. Thanks, -Joe On 5/19/2015 1:09 PM, huizhe wang wrote: Hi Joe, Looks good to me. You might also change the followings if you want: src/jdk.jdi/share

Re: Updating existing JDK code to use InputStream.transferTo() (jdk)

Hello, Not providing a code review, but I wanted to state I think this is a very good sort of cleanup and worthwhile to get into the platform once the details have been worked through. Thanks, -Joe On 5/12/2015 3:10 PM, Patrick Reinhart wrote: Hi Pavel, Is there anything I can do in the m

Re: JDK 9 RFR of JDK-8053918: make the spec for @Documented comprehensible

How about as a first sentence "The Documented meta-annotation indicates whether or not annotations of the annotation types it annotates are considered part of the public contract of the elements they in turn annotate." (Admittedly still a bit convoluted.) -Joe On 5/11/2015 4:07 PM, Jonatha

Re: JDK 9 RFR of Update to RegEx test to use random number library

-Joe On 5/5/2015 3:25 PM, Xueming Shen wrote: looks fine. On 5/5/15 2:53 PM, Joseph D. Darcy wrote: Hello, The regression test test/java/util/regex/RegExTest.java has been observed to intermittently fail. As the test uses randomness, I'd like to update to the test to use th

JDK 9 RFR of Update to RegEx test to use random number library

Hello, The regression test test/java/util/regex/RegExTest.java has been observed to intermittently fail. As the test uses randomness, I'd like to update to the test to use the random number testing library to better identify the cause of any future failures. Please review the patch belo

Re: RFR (XS): 8078225: tools/launcher/FXLauncherTest.java fails intermittently (win)

Looks fine Kumar; thanks, -Joe On 5/5/2015 1:37 PM, Kumar Srinivasan wrote: Hello, Please review the simple fix which allows the test to be run in its own vm, there seems to be some issue with the harness running in a concurrent mode specifically on Windows. Thanks Kumar diff --git a/test

Re: [9] RFR of 8078672: Print and allow setting by Java property seeds used to initialize Random instances in java.lang numerics tests

Hi Brian, On 4/29/2015 4:25 PM, Brian Burkhalter wrote: Hi Joe, No, RandomFactory would have been added by the previous webrev.00 version of the patch, i.e., RandomFactory did not come from RandomSeed. Is this reasonable? Thanks, Sounds reasonable (they two files didn't necessarily look

Re: JDK 9 RFR of JDK-8078334: Mark regression tests using randomness

Hello, I'd like to get this changeset, or something close to it, pushed soon so we can start taking advantage of better failure triaging. Any further concerns? Thanks, -Joe On 4/24/2015 11:04 AM, joe darcy wrote: On 4/23/2015 10:58 PM, Alan Bateman wrote: On 24/04/2015 02:54, Jos

Re: JDK 9 RFR of JDK-8078334: Mark regression tests using randomness

Hello, Any additional comments on marking with tests in question with a "randomness" keyword? Thanks, -Joe On 4/21/2015 7:13 PM, Joseph D. Darcy wrote: Hello, As the next step of implementing "Proposed new policies for JDK 9 regression tests: tiered testing, intermitten

JDK 9 RFR of JDK-8078334: Mark regression tests using randomness

Hello, As the next step of implementing "Proposed new policies for JDK 9 regression tests: tiered testing, intermittent failures, and randomness" [1], please review this changeset which adds a "randomness" jtreg keyword and tags 240 regression tests in the jdk repository with the keyword:

Re: JEP 238: Multi-Version JAR Files

Note that one possible feature of JDK 9 is a -platform N option to javac which would allow compiling against older versions of the platform libraries: JEP draft: Compile for Specific Platform Version http://openjdk.java.net/jeps/8058150 This feature would address some of the concerns r

Re: RFR: JDK-8076583: move jdk.Exported from langtools to jdk

Jon, The actual file move looks fine to me. Thanks, -Joe On 4/2/2015 4:52 PM, Jonathan Gibbons wrote: Sorry for the relatively wide distribution. JDK-8076583 is a conceptually simple cleanup, to move the source file for the jdk.Exported class from the langtools repo (where it is a singleto

Re: native2ascii be removed from JDK?

Hi Mandy, If there is agreement on this internally, I suggest floating a trial balloon on jdk9-dev. Cheers, -Joe On 3/30/2015 2:37 PM, Mandy Chung wrote: There are several existing ways to do native to ascii conversion. For example, IDEs like NetBeans and IntelliJ support the transparent

JDK 9 RFR of JDK-8075565: Define @intermittent jtreg keyword and mark intermittently failing jdk tests

Hello, Per recent proposals (http://mail.openjdk.java.net/pipermail/jdk9-dev/2015-March/001991.html), please review the change below for JDK-8075565: Define @intermittent jtreg keyword and mark intermittently failuring jdk tests http://cr.openjdk.java.net/~darcy/8075565.0/ which de

Re: [9] RFR of 8074460: Always print seeds used in [Splittable]Random instances in java.math tests

Looks good; thanks, -Joe On 3/6/2015 12:03 PM, Brian Burkhalter wrote: Please review at your convenience: Issue: https://bugs.openjdk.java.net/browse/JDK-8074460 Patch: http://cr.openjdk.java.net/~bpb/8074460/webrev.00/ Summary: Create a utility class which creates a pseudorandom number gen

Re: JAXP repo warnings fixed

ue, Mar 3, 2015 at 2:05 AM, Joseph D. Darcy <mailto:joe.da...@oracle.com>> wrote: Hello, Sorry for the belated reply, I tried the URLs and some obvious variations, but the webrevs didn't come up as being there. Have they been moved? Thanks, -Joe O

Re: RFR(s): 8073923: Files.lines() documentation needs clarification

Hi Stuart, The revised version looks good; thanks, -Joe On 3/2/2015 6:43 PM, Stuart Marks wrote: Hi Joe, Oh yes, good point. Revised webrev: http://cr.openjdk.java.net/~smarks/reviews/8073923/webrev.1/ Thanks, s'marks On 3/2/15 6:14 PM, Joseph D. Darcy wrote: Hi Stuart, Sinc

Re: RFR(s): 8073923: Files.lines() documentation needs clarification

Hi Stuart, Since try-with-resources is "just" a desugaring, I think the statements like [The resource] must be opened as a resource within a try-with-resources 136 * statement to ensure that it is closed promptly after its operations have completed. should be replaced with the mil

Re: JAXP repo warnings fixed

Hello, Sorry for the belated reply, I tried the URLs and some obvious variations, but the webrevs didn't come up as being there. Have they been moved? Thanks, -Joe On 2/18/2015 12:17 PM, Ivan St. Ivanov wrote: Hi Joe, core libs developers, Last night we had a hackathon in Bulgarian Java U

Re: RFR 9: 8044051 Test jdk/lambda/vm/InterfaceAccessFlagsTest.java gets IOException during compilation

Hi Roger, Doesn't jtreg define a test-specific scratch directory? Is that not available to TestNG tests? Cheers, -Joe On 2/26/2015 1:14 PM, Roger Riggs wrote: Please review this test fix to make the test more robust to configuration and pollution of the temp directory. Webrev: http://c

Re: [9] RFR of 8066842: java.math.BigDecimal.divide(BigDecimal, RoundingMode) produces incorrect result

Hi Brian, Looks fine; just adjust the copyright dates before pushing. Thanks, -Joe On 2/6/2015 12:29 PM, Brian Burkhalter wrote: On Feb 6, 2015, at 7:46 AM, Brian Burkhalter wrote: On Feb 6, 2015, at 12:51 AM, Paul Sandoz wrote: +1, but you should remove the "@throws IAE" on divRemNega

Re: JDK 9 RFR of 8067669: Documentation for methods in Number incomplete regarding too large values.

Hello, I'm fine with version 1 as well. Cheers, -Joe On 1/29/2015 1:07 PM, Roger Riggs wrote: Hi Brian, #1, The current webrev is fine as is. (Perhaps with a 2015 copyright update). Since the methods are abstract, the general description is sufficient and the subclass would have more det

Re: JDK 9 RFR of JDK-8071434: doc updates for java.lang.Object

I don't think that usage would be inappropriate, but I don't think it is called for here either. Thanks, -Joe On 1/29/2015 1:01 PM, Brian Burkhalter wrote: Would it be appropriate to put the parenthetic information in the new lines 91-93 in an @implSpec or other such section? Brian On Jan

Re: java.util.DualPivotQuickSort does not guarantee NlogN time

On 1/27/2015 12:15 PM, Doug Lea wrote: On 01/27/2015 08:44 AM, Buis, Paul wrote: The slowdown would be passing a single extra integer parameter, decrementing it and comparing it to zero at the beginning of the function. Right. The question is whether even a small slowdown is warranted. Does

Re: JDK 9 RFR of JDK-8069262: Doclint regression in java.nio.channels.Channels

Hi Amy, The fix looks fine; approved to go back, Thanks, -Joe On 1/19/2015 1:34 AM, Amy Lu wrote: Please review the fix for Doclint regression in java.nio.channels.Channels, removed the empty tag. bug: https://bugs.openjdk.java.net/browse/JDK-8069262 webrev: http://cr.openjdk.java.net/~aml

Re: [9] RFR (M): 8067344: Adjust java/lang/invoke/LFCaching/LFGarbageCollectedTest.java for recent changes in java.lang.invoke

Hello, I don't have a comment on the changes to the test per se, but as someone who keeps an eye on test failures that occur in regression tests in the jdk repo of the JDK 9 dev forest, I'd like to see this test stop failing, either by the test being fixed for, barring that, the testing being

Re: JDK 9 RFR of 8067669: Documentation for methods in Number incomplete regarding too large values.

On 1/7/2015 2:04 PM, Brian Burkhalter wrote: On Jan 7, 2015, at 12:08 AM, Andreas Lundblad mailto:andreas.lundb...@oracle.com>> wrote: On Mon, Jan 05, 2015 at 05:43:26PM -0800, Joseph D. Darcy wrote: Hello, Getting back to this issue in the new year, taking a closer look at the ex

Re: JDK 9 RFR of 8059175: Zero BigDecimal with negative scale prints leading zeroes in String.format

On 1/7/2015 9:39 AM, Brian Burkhalter wrote: On Jan 7, 2015, at 1:23 AM, Paul Sandoz wrote: In java.util.Formatter.BigDecimalLayout.layout() trailing zeroes are erroneously appended when the unscaled value of the BigDecimal is zero and the scale is negative. Some other minor changes are incl

Re: JDK 9 RFR of 8067669: Documentation for methods in Number incomplete regarding too large values.

Hello, Getting back to this issue in the new year, taking a closer look at the existing class-level documentation, I don't really see a compelling case for an edit this large. I for one would be content if the bug were closed as "not an issue." HTH, -Joe On 12/22/2014 10:46 AM, Brian Burkh

<    1   2   3   4   >