Re: RFR [14/java.xml] 8068376: Validator fails valid XML files due to String == in XSD validator code

enjdk.java.net/~joehw/jdk14/8068376/webrev/ > > Thanks, > Joe <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/u

Re: [OpenJDK 2D-Dev] 8187898: PrintStream should override FilterOutputStream#write(byte[]) with a method that has no throws clause

alt.02/ > > Thanks, > > Brian > <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: 8228392: java.io.Filter{In,Out}put stream constructors should allow null stream parameter

cle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: RFR [14/java.xml] 8157830: Errors in XSLT stylesheet are not dispatched correctly to ErrorListener

.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: 8228392: java.io.Filter{In,Out}put stream constructors should allow null stream parameter

Hi Brian, Are we having fun yet ;-) The back out looks good > On Jul 18, 2019, at 4:01 PM, Brian Burkhalter > wrote: > > >> On Jul 18, 2019, at 12:35 PM, Brian Burkhalter >> wrote: >> >>> On Jul 18, 2019, at 12:34 PM, Lance Andersen >&

Re: 8228392: java.io.Filter{In,Out}put stream constructors should allow null stream parameter

-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: 8228338: tools/pack200/TimeStamp.java fails with NullPointerException

t; until tiers 1-3 are done before looking at it to avoid more spinning. > > Thanks, > > Brian > >> On Jul 17, 2019, at 4:17 PM, Lance Andersen > <mailto:lance.ander...@oracle.com>> wrote: >> >> Looks OK Brian >>> On Jul 17, 2019, at

Re: 8228338: tools/pack200/TimeStamp.java fails with NullPointerException

Thanks, > > Brian <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Anderse

Re: 8228204: Fix for JDK-8067801 breaks java/io/NegativeInitSize.java

m bis = new BufferedInputStream(goodbis, -1); > } catch (IllegalArgumentException e) { > <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.g

Re: 8067801: Enforce null check for underlying I/O streams

Hi Brian > On Jul 17, 2019, at 5:08 PM, Brian Burkhalter > wrote: > > Hi Lance, > >> On Jul 17, 2019, at 1:55 PM, Lance Andersen > <mailto:lance.ander...@oracle.com>> wrote: >> >> I guess the next question(here he goes again ;-) is do

Re: 8067801: Enforce null check for underlying I/O streams

Hi Brian > On Jul 17, 2019, at 4:39 PM, Brian Burkhalter > wrote: > > Hi Lance, > >> On Jul 17, 2019, at 1:02 PM, Lance Andersen > <mailto:lance.ander...@oracle.com>> wrote: >> >> I think what you have is fine, a unique test in each subdirecto

Re: 8067801: Enforce null check for underlying I/O streams

ethods as described in the package javadoc. Maybe this is a TBD, but if you decide that is a good idea, consider renaming the test now to maybe NPETests.java Either way you are good to go. Best Lance > > Thanks, > > Brian <http://oracle.com/us/design/oracle-email-sig-198324.g

Re: 8067801: Enforce null check for underlying I/O streams

/oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: 8073213: javadoc of PushbackInputStream methods should specify NullPointerExceptions

bpb/8073213/webrev.00/ > [2] http://cr.openjdk.java.net/~bpb/8073213/webrev.00-01/ > [3] http://cr.openjdk.java.net/~bpb/8073213/webrev.01/ > >> On Jul 16, 2019, at 10:19 AM, Lance Andersen >> wrote: >> >> +1 >>> On Jul 16, 2019, at 12:08 PM, Bria

Re: 8131664: Javadoc for PrintStream is now incorrect

t; Anyways, something to consider for a future todo list I guess :-) >> >> Might be worth doing. I’ll after any other comments come in. > <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: RFR [14/java.xml] 8176447: javax.xml.validation.Validator validates incorrectly on uniqueness constraint

//cr.openjdk.java.net/~joehw/jdk14/8176447/webrev/ > > Thanks, > Joe <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com

Re: 8073213: javadoc of PushbackInputStream methods should specify NullPointerExceptions

ows IOException { <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: 8131664: Javadoc for PrintStream is now incorrect

://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: RFR [14]: 8227438: [TESTLIB] Determine if file exists by Files.exists in function FileUtils.deleteFileIfExistsWithRetry

tp://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive

Re: RFR [14] JDK-8225763 Inflater and Deflater should implement AutoCloseable

Hi Jaikiran, > On Jul 10, 2019, at 2:56 AM, Jaikiran Pai wrote: > > Hello Lance, > On 10/07/19 2:25 AM, Lance Andersen wrote: >> ——— >> @implSpec This method is a no-op if this compressor has already >> 886 * been previously closed, >> >> —

Re: RFR [14/java.xml] 8178843: A bug in an inner loop in MethodGenerator's getLocals method

; <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineerin

Re: RFR [14/java.xml] 7148925: StAXSource causes exceptions to be thrown with certain wellformed XML instances

://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: RFR [14] JDK-8225763 Inflater and Deflater should implement AutoCloseable

here. Best Lance <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: 8193072: File.delete() should remove its path from DeleteOnExitHook.files

e.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: Inputs on patch for JDK-8225763? Inflater and Deflater should implement AutoCloseable

of a question - do we have to update the class level >>>>>> javadoc of both these classes to make a mention that these classes >>>>>> have >>>>>> started implementing the AutoCloseable starting version 14 (or >>>>>> whichever >>>>>> version this change makes into) of Java? >>>>>> >>>>>> Any other inputs/suggestions on what else might be needed in this >>>>>> change? >>>>> Hi Jaikiran, >>>>> >>>>> Thanks for picking this up. There are some small wrinkles with this, >>>>> but I hope nothing that will prevent it from happening. >>>>> >>>>> >>>>> 2) Alan already mentioned this, but we need to consider the issue of >>>>> idempotent close() or end() carefully. It's not strictly required, but >>>>> it would be nice. I had taken a quick look at end() and I *thought* it >>>>> was idempotent already, but a more careful analysis needs to be done. >>>> I did some checks in the current JDK code. From what I see, the >>>> Inflater >>>> and Deflater do not have any subclasses within the JDK itself. >>> >>> To be clear - I couldn't find any subclasses in the main source code of >>> JDK. There are a couple of subclasses in the tests >>> (ConstructInflaterOutput.java and ConstructDeflaterInput.java), but >>> those don't do much outside of the context of testing. >>> >>> -Jaikiran <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: Inputs on patch for JDK-8225763? Inflater and Deflater should implement AutoCloseable

ere are some small wrinkles with this, >>>> but I hope nothing that will prevent it from happening. >>>> >>>> >>>> 2) Alan already mentioned this, but we need to consider the issue of >>>> idempotent close() or end() carefully. It's not stri

Re: RFR(JDK 14/java.xml) 8223291: Whitespace is added to CDATA tags when using OutputKeys.INDENT to format XML

as that before this fix. >>> >>> JBS: https://bugs.openjdk.java.net/browse/JDK-8223291 >>> webrev: http://cr.openjdk.java.net/~joehw/jdk14/8223291/webrev/ >>> >>> Thanks, >>> Joe >>> >> <http://oracle.com/us/design/orac

Re: RFR (JDK13/java.xml) 8224157: BCEL: update to version 6.3.1

;>> essential to pass all of the existing tests. I've run the tests multiple >>> times and noted that all of the XML functional and unit tests passed, so >>> were JCK XML tests. I've also done a comparison between builds before and >>> after applying the BCEL upd

Re: RFR (JDK13/java.xml) 8224157: BCEL: update to version 6.3.1

rowse/JDK-8224157 > webrevs: http://cr.openjdk.java.net/~joehw/jdk13/8224157/webrev/ > > Thanks, > Joe > <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198

Re: RFR XS,docs,13 JDK-8226593 Fix HTML in com/sun/jdi/doc-files/signature.html

Signatures > > JDI Type Signatures > @@ -74,6 +73,5 @@ > has the following type signature: > (ILjava/lang/String;[I)J > > - > > > <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif&

Re: RFR: XS,docs,13 JDK-8226592: Fix HTML in table for jdk.zipfs module-info

8324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

RFR 8226518: Typo in the ConnectionBuilder javadoc examples

oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: RFR: 8213561: ZipFile/MultiThreadedReadTest.java timed out in tier1

sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: [14]RFR: 8220229: Timezone pattern "OOOO" does not result in the full "GMT+00:00" substring

t;http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network D

Re: RFR 8213031: (zipfs) Add support for POSIX file permissions

k and reviewed from your end? > > Thanks > Christoph > > From: Langer, Christoph > Sent: Mittwoch, 5. Juni 2019 16:45 > To: Alan Bateman ; Lance Andersen > > Cc: nio-dev ; Java Core Libs > > Subject: RE: RFR 8213031: (zipfs) Add support for POSIX file permi

RFR 8225680: Address links in java.sql.rowset

esign/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: JDK 13 RFR of JDK-8225675: Outdated citation of JLS in java.lang.ref.Reference

Instances > */ > @ForceInline > public static void reachabilityFence(Object ref) { > <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-

Re: JDK 13 RFR of JDK-708660: (reflect) Clarifications to javadoc for getGeneric*Type methods in j.l.r

gt; JDK-708660: (reflect) Clarifications to javadoc for getGeneric*Type >>>> methods in j.l.r >>>> webrev: http://cr.openjdk.java.net/~darcy/7086604.0/ >>>> specdiff: >>>> http://cr.openjdk.java.net/~darcy/7086604.0.specdiff/overview-s

RFR: 8225189: Multiple JNI calls within critical region in ZIP Library

s/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: JDK 13 RFR of JDK-8042748: Clarify exception thrown by ParameterizedTypeImpl.validateConstructorArguments()

-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: JDK 13 RFR of JDK-8181869: getAnnotatedParameterTypes​() specification should be clarified

> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

RFR 8225322: Broken links in java.sql

tp://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive

Re: JDK 13 RFR of JDK-8225465: Add @jls tags to receiver type methods

(); > > <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: 13 RFR (XXS) 8197927: Allow the system property `java.vendor.version` to be undefined

ail-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: 8219992: Correct the documentation of PrintWriter to refer System.lineSeparator

; + * method, and is not necessarily a single newline character ({@code >> '\n'}). >> */ >>public void println() { >> > <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <h

Re: RFR 8224905 : java/lang/ProcessBuilder/Basic.java#id1 failed with stream closed

esign/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2

Re: JDK 13 RFR of JDK-8225353: Add @jls links to java.lang.Enum

://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Tec

Re: RFR(s): 8205131: remove Runtime trace methods

//oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: RFR: XXS,docs JDK-8225324 Bad HTML in jdk.jfr module-info.java

6 @@ > > /** > * Defines the API for JDK Flight Recorder. > - * > * > * @moduleGraph > * @since 9 > > <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design

Re: RFR XS,docs JDK-8225309 HTML issues in jdk.jdi module

<http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: RFR: XS,doc JDK-8225306 bad headings in java.sql.rowset SyncProvider.java

ttp://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: RFR: XXS,doc JDK-8225207: redundant in Instrumentation.java

+1 -- Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPhone > On Jun 3, 2019, at 6:33 PM, Jonathan Gibbons > wrote: > > Please review a tiny delete-one

Re: RFR 8213031: (zipfs) Add support for POSIX file permissions

* access permissions stored in the Zip file. The default set of permissions > * is {@link PosixFilePermission#OWNER_READ OWNER_READ}, {@link > PosixFilePermission#OWNER_WRITE is -> are > * OWNER_WRITE} and {@link PosixFilePermission#GROUP_READ GROUP_READ}. perhaps consider using a when listing the permissions? > The default > * permissions can be configured with the "{@code defaultPermissions}" > property > * described below. Best Lance <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: RFR [XS,docs] JDK-8225129: Fix minor HTML issues in java.naming

le.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: RFR [XS/docs] JDK-8225094: Fix minor HTML issues in jdk.zipfs

oes not exist, > * it will be created: > <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: RFR: docs/accessibility: JDK-8220251: fix headings in java.management

ml > > <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance A

Re: RFR: [XS,doc] JDK-8225077: fix references to broken link in java.compiler module

.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: RFR 8212807: tools/jar/multiRelease/Basic.java times out

<http://cr.openjdk.java.net/~lancea/8212807/webrev.01/> Best Lance > > Thanks, > -Brent > > On 5/30/19 9:21 AM, Lance Andersen wrote: >> Hi all, >> The following fix addresses an issue with an occasional timeout for >> tools/jar/multiRelease/Basic.java.

RFR 8212807: tools/jar/multiRelease/Basic.java times out

<http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Tec

Re: [13] RFR: 8223773: DateTimeFormatter Fails to throw an Exception on Invalid CLOCK_HOUR_OF_AMPM and HOUR_OF_AMPM

e-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle

Re: JDK 13 RFR of JDK-8224783: Javadoc of String strip methods uses link where linkplain would be better

nkplain Character#isWhitespace(int) white space}. >>> * >>> * This method may be used to trim >>> - * {@link Character#isWhitespace(int) white space} from >>> + * {@linkplain Character#isWhitespace(int) white space} from >>> * t

Re: JDK 13 RFR of JDK-8224783: Javadoc of String strip methods uses link where linkplain would be better

cter#isWhitespace(int) white space} > codepoints, > * otherwise {@code false} > * > * @see Character#isWhitespace(int) > <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: RFR (JDK 13/java.xml) 8223658: Performance regression of XML.validation in 13-b19

<http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering

Re: RFR 8224682: Remove the com.sun.CORBA.ORBIorTypeCheckRegistryFilter security property

t;, "jdk.certpath.disabledAlgorithms", ------ > > -Brent > > On 5/23/19 3:58 PM, Lance Andersen wrote: >> Hi all, >> Please review the fix for 8224682 which removes this legacy property left >> over from the removal from CORBA >> The webrev can be found: >&

RFR 8224682: Remove the com.sun.CORBA.ORBIorTypeCheckRegistryFilter security property

us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlingt

Re: RFR (jdk13/java.xml) 8219692: DOM and SAX parser ignore namespace

s: http://cr.openjdk.java.net/~joehw/jdk13/8219692/webrev/ > > Thanks, > Joe <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://ora

Re: RFR: 8222276: (zipfs) Refactoring and cleanups to prepare for JDK-8213031

ling" which should be “trailing” in the >> comment. > > Done. + > > Does it look good now? It runs successfully through our regression testing > system. > > Thanks and best regards > Christoph > <http://oracle.com/us/design/oracle-email-sig-

Re: RFR: 8222276: (zipfs) Refactoring and cleanups to prepare for JDK-8213031

ds out with a 0 value as we lost that comment? line 1937: can you fix the typo “tailing" which should be “trailing” in the comment. Best Lance > > Thanks > Christoph > <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-

Re: RFR: 8222276: (zipfs) Refactoring and cleanups to prepare for JDK-8213031

> got from Lance. > > Please get me some reviews  > > Thanks > Christoph > > > From: Langer, Christoph > Sent: Dienstag, 30. April 2019 11:54 > To: core-libs-dev ; nio-dev > ; Alan Bateman ; Lance > Andersen > Subject: RE: RFR: 876: (zipfs)

Re: RFR(S): 8223597: jdk/nio/zipfs/ZipFSTester.java RuntimeException: CHECK_FAILED! (getAttribute.crc failed 6af4413c vs 0 ...)

sign/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.7

Re: RFR(JDK 13/java.xml) 8222991: Xerces 2.12.0: Validation

ttp://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: 8223254: DataOutputStream/WriteUTF.java fails due to "OutOfMemoryError: Java heap space"

arrayIndexOutOfBoundsException() throws IOException { > <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-em

Re: RFR(JDK 13/java.xml) 8220818: Validator does not find missing match for keyref error

ttp://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: RFR 8221267 : Document the jdk.net.URLClassPath.showIgnoredClassPathEntries system property

comment-14251670 > 3. https://bugs.openjdk.java.net/browse/JDK-8223103 > <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/u

Re: RFR (S): 8223015: Cleanups for zipfs tests

an > > OK for you if I push this without another webrev next week? Yes that is fine :-) Have a good weekend! Best Lance > > Best regards > Christoph > > From: Lance Andersen <mailto:lance.ander...@oracle.com>> > Sent: Freitag, 26. April 2019 18:26 >

Re: RFR: 8222276: (zipfs) Refactoring and cleanups to prepare for JDK-8213031

//cr.openjdk.java.net/~clanger/webrevs/876.1/> > > The jtreg tests for zipfs are all passing. > > Thanks > Christoph > > From: Langer, Christoph > Sent: Donnerstag, 11. April 2019 16:06 > To: core-libs-dev ; nio-dev > ; Alan Bateman ; Lance > Andersen >

Re: RFR (S): 8223015: Cleanups for zipfs tests

198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: [13] RFR: 8222980: Upgrade IANA Language Subtag Registry to Version 2019-04-03

http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: RFR(JDK 13/java.xml) 8222743: Xerces 2.12.0: DOM Implementation

cle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: RFR: 8222440: (zipfs) JarFileSystem does not correctly handle versioned entries if no root entry is present

ain after a failure I think you are good to go. Best Lance > > Best regards > Christoph > <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.g

Re: [13] RFR (XXS): 8222668: Add @since tag to JapaneseEra.REIWA

); > > Naoto <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance And

Re: RFR: 8222440: (zipfs) JarFileSystem does not correctly handle versioned entries if no root entry is present

4.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: ZipFileSystem performance regression

Thanks! >>>> >>>> /Claes >>>> >>>>> On 2019-04-16 09:29, Alan Bateman wrote: >>>>>> On 15/04/2019 14:32, Lennart Börjeson wrote: >>>>>> : >>>>>> >>>>>> Previously, the defla

Re: RFR (JDK 13/java.xml) 8222415: Xerces 2.12.0: Parsing Configuration

.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: RFR(s): 8217405 rmic should reject class files with preview features enabled

s'marks <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member

Re: (1-line) Review Request: 8222078: test/jdk/java/lang/reflect/exeCallerAccessTest/exeCallerAccessTest.c build fails after 8221530

+1 -- Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPhone > On Apr 6, 2019, at 7:37 PM, Mandy Chung wrote: > > A simple test fix. The test causes the buil

Re: 8221597: A typo in the Java API doc for File.getUsableSpace()

om/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.

Re: RFR: 8221924: get(null) on single-entry unmodifiable Map returns null instead of throwing NPE

http://cr.openjdk.java.net/~smarks/reviews/8221924/webrev.0/ > > Thanks, > > s'marks <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif&

Re: Review Request: JDK-8220282 Add MethodHandle tests on accessing final fields

<http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Memb

Re: RFR: 8216539: tools/jar/modularJar/Basic.java timed out

to 28 seconds on average on the slow machine. The webrev can be found at: http://cr.openjdk.java.net/~lancea/8216539/webrev.01/index.html > On Mar 27, 2019, at 8:23 PM, Mandy Chung wrote: > > > > On 3/27/19 4:56 PM, Lance Andersen wrote: >> Hi Mandy, >> >>

Re: RFR (JDK 13) 8220254: fix headings in java.xml

-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 O

Re: RFR: 8216539: tools/jar/modularJar/Basic.java timed out

> Is it running fastdebug and -Xcomp or other flag? It is just a standard windows run. > > Mandy > > On 3/27/19 1:55 PM, Lance Andersen wrote: >> Hi all , >> >> Please review this fix for https://bugs.openjdk.java.net/browse/JDK-8216539 >> <https://

RFR: 8216539: tools/jar/modularJar/Basic.java timed out

<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com> <http://oracle.com/us/desig

Re: RFR (JDK 13) 8221533: Incorrect copyright header in DurationDayTimeImpl.java, DurationYearMonthImpl.java and XMLStreamException.java

DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. > * > * This code is free software; you can redistribute it and/or modify it > > Thanks, > Joe > <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-1

Re: 8078860: (spec) InputStream.read(byte[] b, int off, int len) claims to not affect element b[off]

.java.net/browse/JDK-8078860 <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance A

Re: RFR: docs JDK-8220261: fix headings in java.base

sign/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington

Re: RFR 8220613: [TEST] java/util/Arrays/TimSortStackSize2.java times out with fastdebug build

f> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineerin

Re: RFR 8220252: Fix Headings in java.naming

> Otherwise looks good! Thank you and have a nice evening Best Lance > > best regards, > > -- daniel > > On 13/03/2019 18:55, Lance Andersen wrote: >> Hi all >> Please review the fix for 8220252, to address the javadoc header issues [1] >> in java.

RFR 8220252: Fix Headings in java.naming

Hi all Please review the fix for 8220252, to address the javadoc header issues [1] in java.naming The webrev can be found at: http://cr.openjdk.java.net/~lancea/8220252/webrev.00/index.html Best Lance [1] https://mail.openjdk.java.net/pipermail/jdk-dev/2019-March/002671.html

Re: RFR 8220598: Malformed copyright year range in a few files in java.base

T ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. > * > * This code is free software; you can redistribute it and/or modify it > > -Chris. <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <ht

<    3   4   5   6   7   8   9   10   11   12   >