looks good joe, say goodbye to them :-)
On Apr 13, 2012, at 1:17 PM, Joe Wang wrote:
In the patch for 7053556, the ObjectFactory/SecuritySupport classes that were
duplicated in many packages were replaced by a unified set under
xerces/internal/utils and xalan/internal/utils (Note that
Looks OK to me
Best
Lance
On Apr 12, 2012, at 4:09 PM, Xueming Shen wrote:
Hi
Please help review the change for 7067045.
The change is to throw a more meaningful IAE instead of the
StringIndexoutputOfBoundsException
if backslash or $ is the last character in the replacement string. (as
Hi Joe,
Looks fine
-lance
On Mar 30, 2012, at 3:24 AM, Joe Wang wrote:
Hi,
This is a one line fix: adding a return statement as suggested in the bug
report to guard against null value of the name parameter.
webrev: http://cr.openjdk.java.net/~joehw/7u6/cr7151484/webrev/
Please
Thank you Joe, good to go from my perspective.
Best
Lance
On Mar 20, 2012, at 11:36 PM, Joe Wang wrote:
Thanks Lance!
On 3/20/2012 2:44 PM, Lance Andersen - Oracle wrote:
Hi Joe,
This looks Ok, a couple of minor comments:
- SerializationHandler.java could use a comment before
Hi Joe,
This looks Ok, a couple of minor comments:
- SerializationHandler.java could use a comment before the method
setIsStandalone().
- ToXMLStream.java seems to have a typo in the comment
/**
331 * Before Xalan 1497, a newline char was printed out if
not inside of an
looks ok joe
-lance
On Mar 5, 2012, at 1:46 PM, Joe Wang wrote:
Hi all,
This is a low risk, proven patch made in Xerces back in 2007 [1], removing
unnecessary synchronization in DTDDVFactory. As reported in 7147666, this
patch improves performance in one of the xml test.
Webrev :
Hi,
Looking for a reviewer for http://cr.openjdk.java.net/~lancea/7133815/webrev.00/
this is a small change to address 2 findbug errors. The findbug issues being
addressed:
May expose internal representation by returning reference to mutable object
and
Load of known null value
For
Hi Remi,
Thanks for the feedback, I made the suggested changes
http://cr.openjdk.java.net/~lancea/7133815/webrev.01/ and re-ran the rowset tck
.
Best
Lance
On Jan 26, 2012, at 5:21 PM, Rémi Forax wrote:
On 01/26/2012 10:46 PM, Lance Andersen - Oracle wrote:
Hi,
Looking for a reviewer
Hi Remi,
thanks for the additional info. Made the extra
changehttp://cr.openjdk.java.net/~lancea/7133815/webrev.02, so I hope we are
good to go now.
Best
Lance
On Jan 26, 2012, at 6:47 PM, Rémi Forax wrote:
On 01/27/2012 12:12 AM, Lance Andersen - Oracle wrote:
Hi Remi,
Thanks
Hi,
Looking for a reviewer for
http://cr.openjdk.java.net/~lancea/7132879/webrev.00/
this is a small change to address 2 findbug errors for this class. The
findbug issues being addressed:
Inefficient use of keySet iterator instead of entrySet iterator
and
non-serializable instance
suggestion
Best
Lance
On Jan 24, 2012, at 1:29 PM, Remi Forax wrote:
Looks good.
The only weird thing is the use of java.util.Map instead of Map. Because Map
is used in when referencing Map.Entry just after.
Rémi
- Reply message -
From: Lance Andersen - Oracle lance.ander
:
On 01/24/2012 07:50 PM, Lance Andersen - Oracle wrote:
You are suggesting changing
java.util.Map?,? typeMap = caller.getTypeMap();
to
Map?,? typeMap = caller.getTypeMap();
Which I can do. I probably did not think about it much as it was their
previously but I agree that would
Looks good
On Jan 10, 2012, at 8:20 PM, Joe Darcy wrote:
Hello,
Please review this simple fix to the javadoc of java.lang.Throwable; use of
and rather than lt; and gt; currently causes malformed HTML to
be generated.
--- a/src/share/classes/java/lang/Throwable.javaTue Jan 10
Looks good to me
Best
Lance
On Dec 2, 2011, at 8:42 AM, Alan Bateman wrote:
I'm down on the sign-up sheet for warnings in a couple of arcane areas. The
following webrev fixes the warnings in sun.instrument.*, several
serviceability tools, serialver, and some residual warnings left in
() {
return (driver[className= + driver + ]);
}
On Dec 2, 2011, at 8:19 AM, Lance Andersen - Oracle wrote:
Hi Dave,
thanks for the feedback. Adding @Deprecated changes the signatures so I need
to coordinate any changes as it will result in TCK signature failures. This
is something I
://cr.openjdk.java.net/~lancea/7116445/webrev.04, but will push back if
tonight
Thank you for your help and reviews through all of these modules
Best
Lance
s'marks
On 12/2/11 8:06 AM, Lance Andersen - Oracle wrote:
On Dec 2, 2011, at 10:54 AM, David Schlosnagle wrote:
On Fri, Dec 2, 2011
Looks fine Chris
On Dec 1, 2011, at 11:09 AM, Chris Hegarty wrote:
This is a follow up to an issue that came up during discussion of another
fix. Essentially, JDK classes should use j.u.ServiceLoader rather than
sun.misc.Service.
On 12/1/11 11:52 AM, Lance Andersen - Oracle wrote:
Thank you for the review Chris. Once I hear back from Stuart, I will push
these changes back.
Best
Lance
On Dec 1, 2011, at 11:17 AM, Chris Hegarty wrote:
Skimming over this, I think it looks fine.
-Chris.
On 01/12/2011 01
RowSetProvider.java
SQLInputImpl.java
SQLOutputImpl.java
src/javax/sql/rowset/:
StatementEvent.java
BaseRowSet.java
src/javax/sql/rowset/spi:
SyncFactory.java
Best,
Lance
On Dec 1, 2011, at 4:28 PM, Stuart Marks wrote:
On 12/1/11 1:21 PM, Lance Andersen - Oracle wrote:
I will make the couple
Hi Chris,
Do you want to use diamond reference on lines 81, 82 of jarindex.java?
In Signal.java, line 203, i do not think you need new Integer() any longer?
Other than that it looks good
Best
Lance
On Nov 30, 2011, at 11:33 AM, Chris Hegarty wrote:
I started to look at the reason why we
/assignment
http://cr.openjdk.java.net/~chegar/7116722/webrev.01/webrev/
-Chris.
On 30/11/2011 19:02, Lance Andersen - Oracle wrote:
Hi Chris,
Do you want to use diamond reference on lines 81, 82 of jarindex.java?
In Signal.java, line 203, i do not think you need new Integer() any
I looked at the core and sql changes and they are fine.
I will great a bug for these and submit the change-set.
Best
lance
On Nov 9, 2011, at 6:30 AM, Alan Bateman wrote:
Does anyone have cycles to review and sponsor the Core and SQL clean-ups?
They should be trivial to review and push as
Looks good joe.
On Aug 25, 2011, at 12:37 PM, Joe Darcy wrote:
Hello.
Please review the patch below to add an explicit serialVersionUID to
VirtualMachineError:
7082727 VirtualMachineError should declare its serialVersionUID
http://cr.openjdk.java.net/~darcy/7082727.0/
Thanks,
Should we start a page on OpenJDK as a coding practice FAQ for code and tests?
On Aug 18, 2011, at 6:55 PM, joe.da...@oracle.com wrote:
On 8/18/2011 1:14 PM, Alan Bateman wrote:
Sebastian Sickelmann wrote:
Hi,
i have created a fix for fixing Exception-Chains in case of an rethrown
looks fine Joe...
Best
Lance
On Aug 15, 2011, at 3:17 PM, Joe Darcy wrote:
Hello.
More bug cleanup, please review this small change to correct a misstatement
in the javadoc of Integer and Long about getProperty; along the way, some
more uses of multi-catch are added:
4850225:
Looks fine to me Joe
Best
Lance
On Aug 8, 2011, at 1:24 AM, Joe Darcy wrote:
Hello.
Please review this small fix, developed after I went through my open bug
list; patch below, webrev at:
6380161 (reflect) Exception from newInstance() not chained to cause.
?
Regards
Patrick
Am 22.07.2011 um 23:37 schrieb Lance Andersen - Oracle
lance.ander...@oracle.com:
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com
Hi Patrick,
Still on my list as been in a lot of fire drills.
best
lance
On Jul 26, 2011, at 1:46 PM, Patrick Reinhart wrote:
Hi Lance,
Did you already had the time looking into my suposed changes?
Regards
Patrick
Am 22.07.2011 um 23:37 schrieb Lance Andersen - Oracle
works for me Joe
-Lance
On Jun 15, 2011, at 8:51 PM, Joe Darcy wrote:
GenericSignatureFormatError
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com
Looks good to me.
Best,
Lance
On May 3, 2011, at 8:07 PM, Mike Duigou wrote:
Hello All;
Per the most recent message from Mark Reinhold
(http://mail.openjdk.java.net/pipermail/core-libs-dev/2011-May/006827.html)
the recently added StandardCharset class will be renamed to StandardCharsets
On Apr 28, 2011, at 11:52 PM, Stuart Marks wrote:
On 4/28/11 11:13 AM, Lance Andersen - Oracle wrote:
Hi all,
I could use a reviewer for 7040150 which addresses a positioning issue with
CacheResultSetImpl.removeCurrentRow().
The diff is located at:
http://cr.openjdk.java.net/~lancea
Hi all,
I could use a reviewer for 7040150 which addresses a positioning issue with
CacheResultSetImpl.removeCurrentRow().
The diff is located at:
http://cr.openjdk.java.net/~lancea/7040150/webrev.00/
Thank you.
Regards,
Lance
Lance Andersen| Principal Member of Technical Staff |
update the javadoc style (code - @code etc.) and move the
constructor to the begining.
-Ulf
Am 11.03.2011 21:03, schrieb Lance Andersen - Oracle:
Hi,
I have posted the diffs to DriverManager for review at
http://cr.openjdk.java.net/~lancea/7026898/. This change utilizes
-libs-dev/2011-April/006694.html
On 4/25/11 9:28 AM, Lance Andersen - Oracle wrote:
On Apr 23, 2011, at 6:11 AM, David Holmes wrote:
Rémi Forax said the following on 04/23/11 04:22:
On 04/22/2011 06:51 PM, Lance Andersen - Oracle wrote:
You should use clone() instead of Arrays.copyOf
On Apr 20, 2011, at 7:41 AM, Doug Lea wrote:
On 04/19/11 21:07, David Holmes wrote:
Hi Mike,
Mike Duigou said the following on 04/20/11 08:00:
Hello All;
Another collections javadoc review request. This change links the
(optional)
notes in on various Collection methods to text which
Hi Folks,
I am looking for a reviewer for this update to BatchUpdateException to address
a findbugs issue for exposing a mutable object.
The webrev is at http://cr.openjdk.java.net/~lancea/7038565/
Have a great weekend!
Regards,
lance
Lance Andersen| Principal Member of Technical Staff |
Regards,
Lance
On Apr 23, 2011, at 6:11 AM, David Holmes wrote:
Rémi Forax said the following on 04/23/11 04:22:
On 04/22/2011 06:51 PM, Lance Andersen - Oracle wrote:
You should use clone() instead of Arrays.copyOf.
Can you explain why you have a preference for clone() in this case
Hi Folks,
I am looking for a reviewer for this update to BatchUpdateException to address
a findbugs issue for exposing a mutable object.
The webrev is at http://cr.openjdk.java.net/~lancea/7038565/
Have a great weekend!
Regards,
lance
Lance Andersen| Principal Member of Technical Staff |
Hi Remi,
Thank you for the feedback.
On Apr 22, 2011, at 12:29 PM, Rémi Forax wrote:
On 04/22/2011 06:22 PM, Lance Andersen - Oracle wrote:
Hi Folks,
Hi Lance,
I am looking for a reviewer for this update to BatchUpdateException to
address a findbugs issue for exposing a mutable object
Hi Remi,
I pushed a revised webrev
http://cr.openjdk.java.net/~lancea/7038565/webrev.01/
Regards,
lance
On Apr 22, 2011, at 2:22 PM, Rémi Forax wrote:
On 04/22/2011 06:51 PM, Lance Andersen - Oracle wrote:
Hi Remi,
Thank you for the feedback.
[...]
You should use clone() instead
comment.
Éamonn
On 15/4/11 9:45 PM, Lance Andersen - Oracle wrote:
Hi Eamonn
The javadocs for Timestamp have always specifically called the following
blurb out in the class description. Based on some side discussions, it was
best to also copy this blurb to the added hashCode method (you
Hi all,
Need a reviewer for the following minor change which adds hasCode() to
Timestamp to address a Findbugs warning.
Regards
Lance
hg diff
diff -r d9248245a88c src/share/classes/java/sql/Timestamp.java
--- a/src/share/classes/java/sql/Timestamp.java Wed Apr 13 11:21:36 2011 -0400
+++
.
Regards
Lance
On Apr 15, 2011, at 3:37 PM, Eamonn McManus wrote:
This isn't wrong, but wouldn't it be simpler to just add or xor the nanos
field into the hashcode, rather than explicitly saying that you don't?
Éamonn
On 15/4/11 8:54 PM, Lance Andersen - Oracle wrote:
Hi all,
Need
HI all,
Need a reviewer for this minor update to the SQLPermission constructors which I
missed when I added the updates for the new permission target names.
Thank you.
Regards,
Lance
hg diff
diff -r 0bae251b548b src/share/classes/java/sql/SQLPermission.java
---
Hi Alan,
thank you. Yes I will be going through all of JDBC to clean up the java docs
in the coming weeks.
Regards,
lance
On Apr 13, 2011, at 10:39 AM, Alan Bateman wrote:
Lance Andersen - Oracle wrote:
HI all,
Need a reviewer for this minor update to the SQLPermission constructors
Hi Alan,
http://cr.openjdk.java.net/~lancea/7035615/webrev.02/ has your suggested
changes below.
Regards
Lance
On Apr 12, 2011, at 4:08 AM, Alan Bateman wrote:
Lance Andersen - Oracle wrote:
Hi Alan, Joe
I pushed the revised webrev out (webrev.01). I am going through a directory
Hi folks,
Looking for a reviewer for the following simple change to ResultSet to address
CR 7007772
hg diff
diff -r 1bb95f6ac753 src/share/classes/java/sql/ResultSet.java
--- a/src/share/classes/java/sql/ResultSet.java Tue Apr 12 12:25:15 2011 -0400
+++
Hi all,
This is a request for a review of the changes to remove the lint warnings for
javax.sql.rowset. The diff is at http://cr.openjdk.java.net/~lancea/7035615
Thank you.
Regards,
Lance
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1
Hi Joe, Alan,
Thank you for your feedback Joe.
On Apr 11, 2011, at 2:35 PM, Alan Bateman wrote:
joe.da...@oracle.com wrote:
Hi Lance.
The generification looks fine.
Thank you Joe
Separately I'd recommend considering replacing Vector with ArrayList and
Hashtable with HashMap.
I was
On Apr 11, 2011, at 2:48 PM, Alan Bateman wrote:
Lance Andersen - Oracle wrote:
:
PS: javac was updated recently to emit warnings for unreachable catch
clauses and one place that generates this warning is
src/share/classes/com/sun/rowset/CachedRowSetImpl.java:947. It would be
great
On Apr 11, 2011, at 2:48 PM, Alan Bateman wrote:
Lance Andersen - Oracle wrote:
:
PS: javac was updated recently to emit warnings for unreachable catch
clauses and one place that generates this warning is
src/share/classes/com/sun/rowset/CachedRowSetImpl.java:947. It would be
great to get
Hi all,
This is a request for a review of the changes to remove the lint warnings for
DriverManager. The diff is at http://cr.openjdk.java.net/~lancea/7034656/.
Thank you.
Regards,
Lance
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network
Hi Dave,
Yes it could be made final. This is just a hold over from the original code,
but there is no reason that I cannot make it final.
Regards
Lance
On Mar 11, 2011, at 6:26 PM, David Schlosnagle wrote:
On Fri, Mar 11, 2011 at 3:03 PM, Lance Andersen - Oracle
lance.ander...@oracle.com
Hi,
I have posted the diffs to DriverManager for review at
http://cr.openjdk.java.net/~lancea/7026898/. This change utilizes
CopyOnWriteArrayList instead of the Vectors previously used.
Regards,
Lance
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java
, I will look at the javadoc changes that you
suggest then (there are existing CRs on this)
I do not mind moving the constructor, I just left it where it was since
DriverManager was written, but happy to do so.
Regards
Lance
-Ulf
Am 11.03.2011 21:03, schrieb Lance Andersen - Oracle:
Hi
looks fine Alan
On Mar 2, 2011, at 10:12 AM, Alan Bateman wrote:
I need a reviewer for a small regression in the native2ascii tool whereby its
error messages aren't as expected. Early in the jdk7 this code appears to
have been changed to address a non-varargs call of varargs method warning
looks fine to me Alan
On Jan 4, 2011, at 8:50 AM, Alan Bateman wrote:
The HPI is left over from bygone years where we had a portability layer and
needed to support green and native threading models. Some of the code has not
been used or maintained since the transition to HotSpot back in
Hi Joe,
Looks fine to me.
-lance
On Dec 1, 2010, at 12:24 PM, Joe Darcy wrote:
Hello.
Please review my simple fix for
7002594 Math.max and Math.min should use floatToRawIntBits() to check for
-0.0
http://cr.openjdk.java.net/~darcy/7002594.0/
Besides addressing the reported
Looks good to me Alan.
Regards
Lance
On Nov 16, 2010, at 9:34 AM, Alan Bateman wrote:
I need a reviewer to a trivial drive-by fix to java.lang.Readable's javadoc.
Thanks,
Alan.
diff --git a/src/share/classes/java/lang/Readable.java
b/src/share/classes/java/lang/Readable.java
---
Thank you Alan.
Yes I am planning on doing additional clean up across the code utilizing a
separate CR.
Regards,
Lance
On Nov 11, 2010, at 4:59 AM, Alan Bateman wrote:
Lance Andersen - Oracle wrote:
Hi Remi (and team),
I made changes to SyncFactory and one other class for a similar error
Hi David,
Thanks for the feedback.
Please see below.
On Nov 6, 2010, at 2:04 AM, David Schlosnagle wrote:
On Fri, Nov 5, 2010 at 5:51 PM, Lance Andersen - Oracle
lance.ander...@oracle.com wrote:
Hi Remi (and team),
I made changes to SyncFactory and one other class for a similar error
Hi Remi (and team),
I made changes to SyncFactory and one other class for a similar error. Also
cleaned up a couple of other minor issues in these classes.
The webrev can be found at http://cr.openjdk.java.net/~lancea/6982530/
Thank you for catching the error.
Regards
Lance
On Sep 5, 2010,
201 - 262 of 262 matches
Mail list logo
