Re: RFR: 4890732: GZIPOutputStream doesn't support optional GZIP fields [v12]

2021-09-29 Thread Lin Zang
On Mon, 6 Sep 2021 07:20:11 GMT, Lin Zang wrote: >> 4890732: GZIPOutputStream doesn't support optional GZIP fields > > Lin Zang has updated the pull request with a new target base due to a merge > or a rebase. The pull request now contains 17 commits: > > - Merge bran

Re: RFR: 4890732: GZIPOutputStream doesn't support optional GZIP fields [v13]

2021-09-29 Thread Lin Zang
> 4890732: GZIPOutputStream doesn't support optional GZIP fields Lin Zang has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 21 commits: - remove trailing whitespaces - fix build warnings - Merge branch 'master' into gzip-fi

Re: RFR: 4890732: GZIPOutputStream doesn't support optional GZIP fields [v12]

2021-09-27 Thread Lin Zang
On Mon, 6 Sep 2021 07:20:11 GMT, Lin Zang wrote: >> 4890732: GZIPOutputStream doesn't support optional GZIP fields > > Lin Zang has updated the pull request with a new target base due to a merge > or a rebase. The pull request now contains 17 commits: > > - Merge bran

Re: RFR: 4890732: GZIPOutputStream doesn't support optional GZIP fields [v12]

2021-09-06 Thread Lin Zang
> 4890732: GZIPOutputStream doesn't support optional GZIP fields Lin Zang has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 17 commits: - Merge branch 'master' into gzip-field - delete trailing spaces - refine code - Merge bra

Re: RFR: 4890732: GZIPOutputStream doesn't support optional GZIP fields [v11]

2021-08-02 Thread Lin Zang
> 4890732: GZIPOutputStream doesn't support optional GZIP fields Lin Zang has updated the pull request incrementally with one additional commit since the last revision: delete trailing spaces - Changes: - all: https://git.openjdk.java.net/jdk/pull/3072/files - new: ht

Re: RFR: 4890732: GZIPOutputStream doesn't support optional GZIP fields [v10]

2021-08-02 Thread Lin Zang
> 4890732: GZIPOutputStream doesn't support optional GZIP fields Lin Zang has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 15 commits: - refine code - Merge branch 'master' into gzip-field - change since version to 18 - Me

Re: RFR: 4890732: GZIPOutputStream doesn't support optional GZIP fields [v9]

2021-08-02 Thread Lin Zang
On Mon, 26 Jul 2021 20:47:59 GMT, Lance Andersen wrote: >> Lin Zang has updated the pull request with a new target base due to a merge >> or a rebase. The pull request now contains 13 commits: >> >> - change since version to 18 >> - Merge branch 'master' into

Re: RFR: 4890732: GZIPOutputStream doesn't support optional GZIP fields [v9]

2021-08-02 Thread Lin Zang
On Mon, 26 Jul 2021 20:55:00 GMT, Lance Andersen wrote: >> Lin Zang has updated the pull request with a new target base due to a merge >> or a rebase. The pull request now contains 13 commits: >> >> - change since version to 18 >> - Merge branch 'master' into

Re: RFR: 4890732: GZIPOutputStream doesn't support optional GZIP fields [v9]

2021-08-02 Thread Lin Zang
On Tue, 27 Jul 2021 15:52:23 GMT, Alan Bateman wrote: >> Thank you for reviving the discussion. >> >> I have not gone through the latest update in detail but there are some >> changes that are needed. Before moving forward with the CSR, I would like to >> give time for additional feedback on

Re: RFR: 4890732: GZIPOutputStream doesn't support optional GZIP fields [v9]

2021-07-25 Thread Lin Zang
On Mon, 26 Jul 2021 03:28:44 GMT, Lin Zang wrote: >> 4890732: GZIPOutputStream doesn't support optional GZIP fields > > Lin Zang has updated the pull request with a new target base due to a merge > or a rebase. The pull request now contains 13 commits: > > - chang

Re: RFR: 4890732: GZIPOutputStream doesn't support optional GZIP fields [v9]

2021-07-25 Thread Lin Zang
> 4890732: GZIPOutputStream doesn't support optional GZIP fields Lin Zang has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 13 commits: - change since version to 18 - Merge branch 'master' into gzip-field - Merge branch 'mas

Re: RFR: 4890732: GZIPOutputStream doesn't support optional GZIP fields [v8]

2021-05-24 Thread Lin Zang
> 4890732: GZIPOutputStream doesn't support optional GZIP fields Lin Zang has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 11 commits: - Merge branch 'master' into gzip-field - Add api in GZIPInputStream to get header data - Me

Re: RFR: 4890732: GZIPOutputStream doesn't support optional GZIP fields [v7]

2021-05-24 Thread Lin Zang
> 4890732: GZIPOutputStream doesn't support optional GZIP fields Lin Zang has updated the pull request incrementally with one additional commit since the last revision: Add api in GZIPInputStream to get header data - Changes: - all: https://git.openjdk.java.net/jdk/pull/3

Re: RFR: 4890732: GZIPOutputStream doesn't support optional GZIP fields [v3]

2021-05-23 Thread Lin Zang
On Wed, 24 Mar 2021 10:25:44 GMT, Lance Andersen wrote: >> Lin Zang has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - update copyright >> - reuse arguments constructor for non-argument one. > > Hi L

Re: RFR: 4890732: GZIPOutputStream doesn't support optional GZIP fields [v6]

2021-04-30 Thread Lin Zang
On Thu, 15 Apr 2021 12:41:17 GMT, Lin Zang wrote: >> 4890732: GZIPOutputStream doesn't support optional GZIP fields > > Lin Zang has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in

Re: RFR: 4890732: GZIPOutputStream doesn't support optional GZIP fields [v4]

2021-04-26 Thread Lin Zang
On Thu, 8 Apr 2021 08:54:06 GMT, Alan Bateman wrote: >> Dear All, >> May I ask your help to review this change? Thanks! >> >> BRs, >> Lin > >> Dear All, >> May I ask your help to review this change? Thanks! > > @LanceAndersen Do you have cycles to help Lin? This proposal will require >

Re: RFR: 4890732: GZIPOutputStream doesn't support optional GZIP fields [v6]

2021-04-15 Thread Lin Zang
> 4890732: GZIPOutputStream doesn't support optional GZIP fields Lin Zang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits si

Re: RFR: 4890732: GZIPOutputStream doesn't support optional GZIP fields [v3]

2021-04-15 Thread Lin Zang
On Wed, 24 Mar 2021 10:25:44 GMT, Lance Andersen wrote: >> Lin Zang has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - update copyright >> - reuse arguments constructor for non-argument one. > > Hi L

Re: RFR: 4890732: GZIPOutputStream doesn't support optional GZIP fields [v5]

2021-04-15 Thread Lin Zang
> 4890732: GZIPOutputStream doesn't support optional GZIP fields Lin Zang has updated the pull request incrementally with one additional commit since the last revision: Use record and Builder pattern - Changes: - all: https://git.openjdk.java.net/jdk/pull/3072/files -

Re: RFR: 4890732: GZIPOutputStream doesn't support optional GZIP fields [v3]

2021-04-10 Thread Lin Zang
On Thu, 8 Apr 2021 08:54:06 GMT, Alan Bateman wrote: >> Dear All, >> May I ask your help to review this change? Thanks! >> >> BRs, >> Lin > >> Dear All, >> May I ask your help to review this change? Thanks! > > @LanceAndersen Do you have cycles to help Lin? This proposal will require >

Re: RFR: 4890732: GZIPOutputStream doesn't support optional GZIP fields [v3]

2021-04-08 Thread Lin Zang
On Fri, 2 Apr 2021 08:53:20 GMT, Lin Zang wrote: >> Hi Lin, >> >> On Mar 24, 2021, at 2:51 AM, Lin Zang ***@***.**@***.***>> wrote: >> >> >> >> Hi Lance, >> Thanks a lot for your review. I will update the PR ASAP. >> May I as

Re: RFR: 4890732: GZIPOutputStream doesn't support optional GZIP fields [v3]

2021-04-02 Thread Lin Zang
On Wed, 24 Mar 2021 10:25:44 GMT, Lance Andersen wrote: >> Hi Lance, >> Thanks a lot for your review. I will update the PR ASAP. >> May I ask your help to also review the CSR? Thanks! >> >> BRs, >> Lin > > Hi Lin, > > On Mar 24, 2021, at

Re: RFR: 4890732: GZIPOutputStream doesn't support optional GZIP fields [v4]

2021-04-02 Thread Lin Zang
> 4890732: GZIPOutputStream doesn't support optional GZIP fields Lin Zang has updated the pull request incrementally with one additional commit since the last revision: add class GZIPHeaderData, refine testcases - Changes: - all: https://git.openjdk.java.net/jdk/pull/3

Re: RFR: 4890732: GZIPOutputStream doesn't support, in fact thwarts, use of optional GZIP fields [v3]

2021-03-25 Thread Lin Zang
On Mon, 22 Mar 2021 20:18:37 GMT, Lance Andersen wrote: >> Lin Zang has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - update copyright >> - reuse arguments constructor for non-argument one. > > src/j

Re: RFR: 4890732: GZIPOutputStream doesn't support, in fact thwarts, use of optional GZIP fields [v3]

2021-03-25 Thread Lin Zang
On Mon, 22 Mar 2021 20:15:38 GMT, Lance Andersen wrote: > on operating systems using > EBCDIC or any other character set for file names, the name > must be translated to the ISO LATIN-1 character set. This > is the original name of the file being compressed, with any >

Re: RFR: 4890732: GZIPOutputStream doesn't support, in fact thwarts, use of optional GZIP fields [v3]

2021-03-25 Thread Lin Zang
On Mon, 22 Mar 2021 20:06:33 GMT, Lance Andersen wrote: >> Lin Zang has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - update copyright >> - reuse arguments constructor for non-argument one. > > src/j

Re: RFR: 4890732: GZIPOutputStream doesn't support, in fact thwarts, use of optional GZIP fields [v3]

2021-03-25 Thread Lin Zang
On Wed, 24 Mar 2021 10:25:44 GMT, Lance Andersen wrote: >> Hi Lance, >> Thanks a lot for your review. I will update the PR ASAP. >> May I ask your help to also review the CSR? Thanks! >> >> BRs, >> Lin > > Hi Lin, > > On Mar 24, 2021, at

Re: RFR: 4890732: GZIPOutputStream doesn't support, in fact thwarts, use of optional GZIP fields [v3]

2021-03-24 Thread Lin Zang
On Mon, 22 Mar 2021 21:37:27 GMT, Lance Andersen wrote: >> Lin Zang has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - update copyright >> - reuse arguments constructor for non-argument one. > > Hi Li

Re: RFR: 4890732: GZIPOutputStream doesn't support, in fact thwarts, use of optional GZIP fields [v3]

2021-03-19 Thread Lin Zang
> 4890732: GZIPOutputStream doesn't support, in fact thwarts, use of optional > GZIP fields Lin Zang has updated the pull request incrementally with two additional commits since the last revision: - update copyright - reuse arguments constructor for non-argument one. - C

Re: RFR: 4890732: GZIPOutputStream doesn't support, in fact thwarts, use of optional GZIP fields [v2]

2021-03-19 Thread Lin Zang
> 4890732: GZIPOutputStream doesn't support, in fact thwarts, use of optional > GZIP fields Lin Zang has updated the pull request incrementally with one additional commit since the last revision: add test case - Changes: - all: https://git.openjdk.java.net/jdk/pull/3072

Re: RFR: 4890732: GZIPOutputStream doesn't support, in fact thwarts, use of optional GZIP fields

2021-03-19 Thread Lin Zang
On Thu, 18 Mar 2021 10:50:05 GMT, Lin Zang wrote: >> 4890732: GZIPOutputStream doesn't support, in fact thwarts, use of optional >> GZIP fields > > Dear All, > This PR introduce new constructor of GZIPOutputStream to support adding extra > field info in gzip file he

Re: RFR: 4890732: GZIPOutputStream doesn't support, in fact thwarts, use of optional GZIP fields

2021-03-18 Thread Lin Zang
On Thu, 18 Mar 2021 10:46:04 GMT, Lin Zang wrote: > 4890732: GZIPOutputStream doesn't support, in fact thwarts, use of optional > GZIP fields Dear All, This PR introduce new constructor of GZIPOutputStream to support adding extra field info in gzip file header, as decribed in RFC 195

RFR: 4890732: GZIPOutputStream doesn't support, in fact thwarts, use of optional GZIP fields

2021-03-18 Thread Lin Zang
4890732: GZIPOutputStream doesn't support, in fact thwarts, use of optional GZIP fields - Commit messages: - remove trailing spaces - 4890732: support optional GZIP fields in GZIPOutputStream Changes: https://git.openjdk.java.net/jdk/pull/3072/files Webrev:

Re: RFR: 8261482: Adjust jmap histo command to accept noparallel option to inspect heap serially

2021-02-10 Thread Lin Zang
On Thu, 11 Feb 2021 02:36:01 GMT, Lin Zang wrote: > 8261482: Adjust jmap histo command to accept noparallel option to inspect > heap serially Dear All, Stories and discussions related with this PR could be found at #2379 and #2261. Just FYI. BRs, Lin - PR:

RFR: 8261482: Adjust jmap -histo to accept noparallel option to inspect heap serially

2021-02-10 Thread Lin Zang
8261482: Adjust jmap -histo to accept noparallel option to inspect heap serially - Commit messages: - 8261482: Adjust jmap -histo to accept noparallel option to inspect heap serially Changes: https://git.openjdk.java.net/jdk/pull/2519/files Webrev:

Re: RFR: 8257234 : Add gz option to SA jmap to write a gzipped heap dump [v13]

2021-01-28 Thread Lin Zang
On Fri, 29 Jan 2021 05:33:19 GMT, Serguei Spitsyn wrote: > You are right. > So, in my suggestion just replace this block: > > ``` > if (gzlevel <= 0 || gzlevel > 9) { > err.println("Invalid "gz=" option: " + option); >

RFR: 8252842: Extend jmap to support parallel heap dump

2021-01-27 Thread Lin Zang
8252842: Extend jmap to support parallel heap dump - Commit messages: - fix white space trailing issue - 8252842: Extend jmap to support parallel heap dump Changes: https://git.openjdk.java.net/jdk/pull/2261/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=2261=00

RFR: 8255982: Extend BasicJMapTest to test with different GC Heap

2020-11-06 Thread Lin Zang
The implementation of jmap tool depends on the implementation of object iteration by different GC heap. This patch extend the BasicJMapTest to cover differet GC Heap. - Commit messages: - 8255982: Extend BasicJMapTest to test with different GC Heap Changes: