Re: RFR(xs): 8221375: Windows 32bit build (VS2017) broken

Hi Thomas, Will do and appreciate the support! Cheers, Martijn On Wed, 27 Mar 2019 at 11:13, Thomas Stüfe wrote: > > > On Wed, Mar 27, 2019 at 11:08 AM Martijn Verburg > wrote: > >> Hi Thomas, >> >> Release only (we've only created debug builds for x64

Re: RFR(xs): 8221375: Windows 32bit build (VS2017) broken

other things. Cheers, Martijn On Tue, 26 Mar 2019 at 06:04, Thomas Stüfe wrote: > > > On Mon, Mar 25, 2019 at 10:49 PM Martijn Verburg > wrote: > >> Hi all, >> >> Snipping much, but commenting on one statement inline below. >> >> On Mon, 25 Mar 201

Re: RFR(xs): 8221375: Windows 32bit build (VS2017) broken

Hi all, Snipping much, but commenting on one statement inline below. On Mon, 25 Mar 2019 at 01:58, David Holmes wrote: > Hi Thomas, > > A few queries, comments and concerns ... > > On 25/03/2019 6:58 am, Thomas Stüfe wrote: > > Hi all, > > > > After a long time I tried to build a Windows 32bit

Re: RFC: JEP JDK-8208089: Implement C++14 Language Features

Hi Kim, I like this initiative. I'm wondering if some of these rules can be easily codified or written into a jcheck style checker (ccheck?) so that Authors can adhere to the conventions and not rely on a Human review to pick out where that convention isn't met. Cheers, Martijn On Wed, 3 Oct

Re: Draft JEP proposal: JDK-8200758: Packaging Tool

Hi Kevin, Looks good, I assume as part of the work several existing javapackager bugs will be swept up along the way? We use javapackager and are very happy with what it gives us considering it is "free as in beer", but there are some significant workarounds required for code signing, especially

Re: RFR 8190378: Java EE and CORBA modules removal

One could almost shed a tear - of joy! This is exactly the use case for the module system that the developer community at large will understand. Thanks for this change and a leaner meaner JDK. Cheers, Martijn On 8 February 2018 at 13:37, Lance Andersen wrote: > > >

Re: RFR(s): 8177681: Remove methods Runtime.getLocalized{Input, Output}Stream

That must be oddly satisfying :-D Cheers, Martijn On 7 December 2017 at 03:35, wrote: > 2017/12/6 17:33:36 -0500, stuart.ma...@oracle.com: > > Please review the removal of these methods, which were part of an > obsolete > > internationalization mechanism. They were

JDK-6253001 - Joinrowset bug - question on whether test code has been migrated?

Hi all, The Adoption Group is having a go at collaboratively walking through the process of resolving an open bug with the view of writing up the steps for folks new to OpenJDK. We picked https://bugs.openjdk.java.net/browse/JDK-6253001 - a fairly simple, low priority joinrowset bug reported in

Re: On what issues could I help clean up for JDK 9

Thanks Claes! That's helpful, we'll pick a few of these over on adoption-discuss and come back here to start a discussion on the relevant issue(s) before we start. Cheers, Martijn On 2 December 2016 at 13:12, Claes Redestad wrote: > Hi, > > I'd suggest start looking

Re: On what issues could I help clean up for JDK 9

There's no JBS query that I know of (I think in the distant past we discussed adding a low hanging fruit 'Duke' tag?). Cheers, Martijn On 1 December 2016 at 21:58, Patrick Reinhart wrote: > Hi there, > > I wanted to ask if there is a simple JBS query to find small clean up

Re: Java language and API improvements

Hi Alberto, Further to this, all of these have been proposed in one form or another previously during Project Coin during Java 7's development. I suggest you have a look at the old coin-dev archives (http://mail.openjdk.java.net/ pipermail/coin-dev/) to see why they weren't taken on board (or

Re: JEP 276: Dynamic Linking of Language-Defined Object Models

gt; a later iteration of which got integrated into Nashorn in 2012, and then > developed alongside it ever since. So, it’s been part of my work life, on > and off for good 7-8 years now. I’m obviously thrilled to be taking it to > maturation with OpenJDK community :-) > > Attila

Re: JEP 276: Dynamic Linking of Language-Defined Object Models

This looks very, very promising. Would it help to get the language maintainers of the most popular scripting/dynamic JVM languages involved ASAP? Happy to contact Groovy, Clojure, Scala, JRuby folks (although I suspect many of them are on this list). Cheers, Martijn On 16 October 2015 at

Re: Updating existing JDK code to use InputStream.transferTo()

Hi Patrick, Have you posted the webrev somewhere for review? Cheers, Martijn On 8 May 2015 at 23:53, Patrick Reinhart patr...@reini.net wrote: Hi Pavel, I have changed the most obvious files and made a patch of each repo. I hope the patches will not be removed… Cheers Patrick Am

Low hanging fruit in JBS for the Adoption Group Hackdays to tackle?

Hi all, We had a short discussion in Adoption Group about having its members triaging issues in JBS to identify low-hanging fruit for new OpenJDK developers to tackle. Dalibor sensibly suggested that each project/group was far more familiar with which issues would be appropriate and that we

Re: JDK 9 RFR of JDK-8071434: doc updates for java.lang.Object

Perhaps the authors in question would be happy to have a publicly hosted snippet of that useful information? I have both books but can appreciate that there's a *large* number of Java devs who can't afford or get access to those. Cheers, Martijn On 29 January 2015 at 21:03, Roger Riggs

Re: JDK 9 RFR of JDK-8069255: Suppress deprecation warnings in jdk.rmic module

See more background (which I should have given): http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-December/030085.html Thanks, Amy On 1/29/15 7:14 PM, Martijn Verburg wrote: Hi Amy, Idle curiosity here - are the warnings being suppressed because there is no way of 'resolving

Re: JDK 9 RFR of JDK-8069255: Suppress deprecation warnings in jdk.rmic module

Hi Amy, Idle curiosity here - are the warnings being suppressed because there is no way of 'resolving' them? Cheers, Martijn On 29 January 2015 at 03:09, Amy Lu amy...@oracle.com wrote: I updated the webrev, suppress deprecation warnings for jdk/src/jdk.rmic/share/classes/sun/tools/java/*

Re: RFR 8065998: Avoid use of _ as a one-character identifier

I know this is descending into bike shedding - but I like that split of definition, shamelessly stealing for my future projects, thanks! Cheers, Martijn On 1 December 2014 at 13:01, Andreas Lundblad andreas.lundb...@oracle.com wrote: On Mon, Dec 01, 2014 at 01:10:29PM +0100, Jan Lahoda wrote:

Re: Process API Updates (JEP 102)

Hi Roger, Is there a short survey we could send out to the wider dev community on this one? I think just about every day to day Java developer has had to use Process at some stage in their career. Cheers, Martijn On 24 March 2014 21:11, roger riggs roger.ri...@oracle.com wrote: Hi, I'm

Re: A hole in the serialization spec

In the long term will it be possible to just mark j.u.Date as deprecated since the new Date and Time libs have come in? Avoids having to fix old behaviour that folks might be relying on. Cheers, Martijn On 14 February 2014 18:56, David M. Lloyd david.ll...@redhat.com wrote: Interestingly, if

Re: JAXP JEP: Update Xerces implementation in the JDK

Hi Huizhe, Is there a possibility to look at having a more loosely coupled relationship between Xerces and what is core JDK? I'm thinking about (in combination with) Jigsaw that you could allow the Xerces components to be kept up to date more often (assuming API compatibility etc is retained).

Re: JAXP JEP: Update Xerces implementation in the JDK

Makes sense - thanks for the extra explanation! Cheers, Martijn On 3 February 2014 22:49, Alan Bateman alan.bate...@oracle.com wrote: On 03/02/2014 21:13, Martijn Verburg wrote: Hi Huizhe, Is there a possibility to look at having a more loosely coupled relationship between Xerces

Re: RFR: 8024704: Improve API documentation of ClassLoader and ServiceLoader with respect to enumeration of resources.

As a mostly ;-) silent observer on this list I just wanted to say Thank You to everyone for continuing the diligent work to fix issues like this. I've seen a host of really useful small improvements go in recently (and docs definitely count as well) - it doesn't go unnoticed! Cheers, Martijn On

Re: about JavaOne2012 Finding and Solving Java Deadlocks

I've pinged Heinz - M On 31 October 2012 20:08, Jim Gish jim.g...@oracle.com wrote: I'd be very interested in this too, and would also like to see the slides. Thanks, Jim On 10/15/2012 05:50 PM, Mike Duigou wrote: The session was a hands on lab so was not recorded that I can tell.

Re: Review Request: 7193406 - Clean-up JDK Build Warnings in java.util, java.io

Hi all, On 08/23/2012 11:46 PM, Dan Xu wrote: Please review the fix of CR 7193406 at http://cr.openjdk.java.net/~dxu/7193406/webrev/. It cleans up warnings in the following java files. src/share/classes/java/io/FilePermission.java src/share/classes/java/util/ArrayDeque.java

Re: Bug 7176907 - Patches for javac warnings cleanup (text and util) from Adopt OpenJDK

Hi Stuart, snip The java.util patches look good and are almost ready to go in. The only issue is how to format the Contributed-by line in the changeset comment. What I have so far for the comment is: 7176907: additional warnings cleanup in java.util, java.util.regexp, java.util.zip

Re: Bug 7176907 - Patches for javac warnings cleanup (text and util) from Adopt OpenJDK

Hi Kurchi, Thanks for updating this. This looks good to me. I guess Stuart will be sponsoring the patch. For his sins he's kindly offered to do so yes :-) There are a couple of other switch statements in  src/share/classes/java/util/regex/Pattern.java. which are not throwing fallthrough

Re: Bug 7176907 - Patches for javac warnings cleanup (text and util) from Adopt OpenJDK

-submitted/javac_warnings/core_java_util.patch Cheers, Martijn On 27 June 2012 08:58, Martijn Verburg martijnverb...@gmail.com wrote: Hi Kurchi, Thanks for updating this. This looks good to me. I guess Stuart will be sponsoring the patch. For his sins he's kindly offered to do so yes

Re: Bug 7176907 - Patches for javac warnings cleanup (text and util) from Adopt OpenJDK

is complete now. Cheers, Martijn On 20 June 2012 17:18, Martijn Verburg martijnverb...@gmail.com wrote: We'll look into it, hopefully have an answer for you shortly - M On 20 June 2012 17:07, Kurchi Subhra Hazra kurchi.subhra.ha...@oracle.com wrote: Hi,   I was just going through the patches

Bug 7176907 - Patches for javac warnings cleanup (text and util) from Adopt OpenJDK

Hi Stuart, As requested - attached are 2 patch files, one covering util, the other text. I'm aware some fixes did go in recently, so if these patches are out of date and need re-spinning, then please let me know. Cheers, Martijn (on behalf of Adopt OpenJDK)

Re: Bug 7176907 - Patches for javac warnings cleanup (text and util) from Adopt OpenJDK

2012 09:50, Martijn Verburg martijnverb...@gmail.com wrote: Hi Stuart, As requested - attached are 2 patch files, one covering util, the other text. I'm aware some fixes did go in recently, so if these patches are out of date and need re-spinning, then please let me know. Cheers, Martijn

Re: Bug 7176907 - Patches for javac warnings cleanup (text and util) from Adopt OpenJDK

Hi Remi, On 20 June 2012 15:08, Rémi Forax fo...@univ-mlv.fr wrote: On 06/20/2012 01:51 PM, Martijn Verburg wrote: Hi all, Apologies, I didn't check that attachments were stripped.  The patches can be found at: https://raw.github.com/AdoptOpenJDK/PatchReview/master/submitted

Re: Bug 7176907 - Patches for javac warnings cleanup (text and util) from Adopt OpenJDK

in line 2247). Are these not generating warnings? - Kurchi On 6/20/12 7:30 AM, Martijn Verburg wrote: Hi all, Apologies, I didn't check that attachments were stripped.  The patches can be found at: https://raw.github.com/AdoptOpenJDK/PatchReview/master/submitted/core_java_text.patch

Re: Proposed refactoring: introduce JLS7 language features to core libs

Hi all, On 4/25/12 12:07 PM, Stefan Reich wrote: Hello, is there any interest to accept change sets based on OpenJDK 7 that update the java classes in jdk/src/share/classes to use * multi-catch * string switch statements as opposed to nested if statements when comparing strings with

Re: Proposed refactoring: introduce JLS7 language features to core libs

Hi all, On 1 May 2012 10:33, Martijn Verburg martijnverb...@gmail.com wrote: Hi all, On 4/25/12 12:07 PM, Stefan Reich wrote: Hello, is there any interest to accept change sets based on OpenJDK 7 that update the java classes in jdk/src/share/classes to use * multi-catch * string switch

Re: Initial preview: JEP-149 Reduced Class instance size

Hi Hinkmond, Is there a corpus of code you can look at in the embedded space to see what ratio of real-world apps use a lot of reflection? We have access to a corpus in the SE space (some Cambridge PhD students that work with us) and I know Brian/Joe et al use one internally at Oracle as well,

Re: Request for Review: Warnings cleanup in java.lang.*, java.util.**

FYI - The London JUG did have java.util.regex listed, but we didn't have time to produce a patch for that area, so no clash there - Cheers, M On 2 December 2011 12:18, Alan Bateman alan.bate...@oracle.com wrote: cc'ing core-libs-dev as that is the place to discuss these changes. I see on the