Hi Brian,
Pushed with recommend changes; webrev of final version:
http://cr.openjdk.java.net/~darcy/8233452.5
Thanks,
-Joe
On 1/14/2020 1:59 PM, Brian Burkhalter wrote:
Hi Joe,
This looks good modulo a few picayune things I noticed in the
implementation and test. Line numbers refer to
Hi Joe,
This looks good modulo a few picayune things I noticed in the implementation
and test. Line numbers refer to the updated version of each file.
1. Implementation
2: Newer copyright year 2020, of course.
2150: s/much many/many/.
2185: I suppose that this is in case targetPrecision
Hello,
Some further refinements to the implementation and tests ready for
re-review:
http://cr.openjdk.java.net/~darcy/8233452.4/
The fix-up code for directed roundings (up, down, etc.) was corrected to
properly handle rounding down when the interim result is a power of 10,
in this
Hi Joe,
> On Nov 5, 2019, at 6:04 PM, Joe Darcy wrote:
>
> Please review the changes to fix
>
> JDK-8233452: java.math.BigDecimal.sqrt() with RoundingMode.FLOOR results
> in incorrect result
> http://cr.openjdk.java.net/~darcy/8233452.0/
>
Hello,
Please review the changes to fix
JDK-8233452: java.math.BigDecimal.sqrt() with RoundingMode.FLOOR
results in incorrect result
http://cr.openjdk.java.net/~darcy/8233452.0/
Some background on the problem and fix.
The core of the BigDecimal.sqrt method is a Newton-Raphson loop.
