Re: RFR: jsr166 jdk10 integration wave 3

2017-09-29 Thread Martin Buchholz
On Wed, Sep 27, 2017 at 1:44 PM, Doug Lea wrote: > On 09/27/2017 02:38 PM, Paul Sandoz wrote: > >> Looks good, i just need to look a little more closely at the > ConcurrentSkipListMap changes. > >> > > > > > > 328 * Note that, with VarHandles, a boolean result of > > 329 * compareAndS

Re: RFR: jsr166 jdk10 integration wave 3

2017-09-27 Thread Doug Lea
On 09/27/2017 02:38 PM, Paul Sandoz wrote: >> Looks good, i just need to look a little more closely at the >> ConcurrentSkipListMap changes. >> > > > 328 * Note that, with VarHandles, a boolean result of > 329 * compareAndSet must be declared even if not used. > This should not be ne

Re: RFR: jsr166 jdk10 integration wave 3

2017-09-27 Thread Paul Sandoz
> On 21 Sep 2017, at 10:29, Paul Sandoz wrote: > > Looks good, i just need to look a little more closely at the > ConcurrentSkipListMap changes. > 328 * Note that, with VarHandles, a boolean result of 329 * compareAndSet must be declared even if not used. This should not be neces

Re: RFR: jsr166 jdk10 integration wave 3

2017-09-21 Thread Martin Buchholz
Within a household, there's -chan and -kun https://en.wikipedia.org/wiki/Japanese_honorifics#Common_honorifics On Thu, Sep 21, 2017 at 12:36 PM, John Rose wrote: > On Sep 21, 2017, at 10:50 AM, Martin Buchholz wrote: > > > NonNestmates does have nested classes, but they need to be non-nestmates

Re: RFR: jsr166 jdk10 integration wave 3

2017-09-21 Thread John Rose
On Sep 21, 2017, at 10:50 AM, Martin Buchholz wrote: > > NonNestmates does have nested classes, but they need to be non-nestmates of > the invoking test code. I don't think we have a word for birds that are > not in the same nest. Japanese has > https://en.wikipedia.org/wiki/Uchi-soto >

Re: RFR: jsr166 jdk10 integration wave 3

2017-09-21 Thread Remi Forax
Bastard.java ? Rémi - Mail original - > De: "Martin Buchholz" > À: "Paul Sandoz" > Cc: "core-libs-dev" > Envoyé: Jeudi 21 Septembre 2017 19:50:51 > Objet: Re: RFR: jsr166 jdk10 integration wave 3 > On Thu, Sep 21, 2017 at 10:29 AM

Re: RFR: jsr166 jdk10 integration wave 3

2017-09-21 Thread Martin Buchholz
On Thu, Sep 21, 2017 at 10:29 AM, Paul Sandoz wrote: > > > Thanks - much appreciated. The refactoring looks fine - though I > wouldn't have immortalized the "nestmates" part in the naming. :) > > > > Perhaps use the prefix TopLevelAtomicTests or NonEnclosingAtomicTests ? > . NonNestmates does hav

Re: RFR: jsr166 jdk10 integration wave 3

2017-09-21 Thread Paul Sandoz
Looks good, i just need to look a little more closely at the ConcurrentSkipListMap changes. > On 20 Sep 2017, at 20:49, David Holmes wrote: > > Hi Martin, > > On 21/09/2017 1:20 PM, Martin Buchholz wrote: >> http://cr.openjdk.java.net/~martin/webrevs/openjdk10/jsr166-integration/ >>

Re: RFR: jsr166 jdk10 integration wave 3

2017-09-20 Thread David Holmes
Hi Martin, On 21/09/2017 1:20 PM, Martin Buchholz wrote: http://cr.openjdk.java.net/~martin/webrevs/openjdk10/jsr166-integration/ Our usual webrev, rejiggered for the consolidated repo. David, this includes your nestma

RFR: jsr166 jdk10 integration wave 3

2017-09-20 Thread Martin Buchholz
http://cr.openjdk.java.net/~martin/webrevs/openjdk10/jsr166-integration/ Our usual webrev, rejiggered for the consolidated repo. David, this includes your nestmates changes.