RFR 8166051: [jline] Cannot parse .inputrc with \r

Please review a change to how .inputrc is read. Currently, it uses BufferedReader.readLine(), which interprets '\r' as a line separator, and so the '\r' character cannot be used in the macros. The proposed change is to use System.getProperty("line.separator") and "\n" as line separators. Bug:

RFR: 8166189: Fix for Bug 8165524 breaks AIX build

Hi, the fix for https://bugs.openjdk.java.net/browse/JDK-8165524 breaks the AIX build as function dladdr is not available on AIX. There already exist ports of that API in hotspot and awt. With the proposed change I duplicate the awt port to libjli. This is maybe only a quick fix - eventually w

Re: OpenJDK JDK-7067885 code changes for community review

Hi Alok, This change should be discussed on swing-dev mailing list because you modify behavior of javax.swing.JFileChooser, and on core-libs-dev because you also modify java.io.File. I agree with Alan, using the new API appears to be a better alternative than changing java.io.File. Regard

Re: RFR 9: 8155760 Implement Serialization Filtering

Sorry for being late to this party. I like the approach, but I have some concerns about the evolvability of this API. The filter already receives a handful of parameters; it seems quite unlikely that a use case will not emerge where the filter needs more information in the future (say, the cal

Re: RFR: 8166189: Fix for Bug 8165524 breaks AIX build

> On Sep 16, 2016, at 2:58 AM, Langer, Christoph > wrote: > > Hi, > > the fix for https://bugs.openjdk.java.net/browse/JDK-8165524 breaks the AIX > build as function dladdr is not available on AIX. > > There already exist ports of that API in hotspot and awt. With the proposed > change I du

Re: RFR: 8166189: Fix for Bug 8165524 breaks AIX build

Hi Christoph, I think your change is fine as a quick-fix to fix the build. But you're completely right that this should be reworked in the long term. I hate to see that we now have the third version of these routines in the OpenJDK. Unfortunately a clean solution is not trivial. libjli is not lin

Re: RFR: 8166189: Fix for Bug 8165524 breaks AIX build

I assume libjvm.so has access to dlopen and dlsym? Can the AIX implementation of dladdr live in libjli.so and libjvm.so load it from there? Chris > On Sep 16, 2016, at 10:34 AM, Volker Simonis wrote: > > Hi Christoph, > > I think your change is fine as a quick-fix to fix the build. But > you

Re: RFR: 8153654: Update jdeps to be multi-release jar aware

A relatively minor update. I simplified VersionHelper. No other changes. http://cr.openjdk.java.net/~sdrach/8153654/webrev.12/ > On Sep 14, 2016, at 4:06 PM, Steve Drach wrote: > > The most recent webrev is > http://cr.openjdk.java.ne

Re: RFR: 8153654: Update jdeps to be multi-release jar aware

> On Sep 16, 2016, at 11:40 AM, Steve Drach wrote: > > A relatively minor update. I simplified VersionHelper. No other changes. > > http://cr.openjdk.java.net/~sdrach/8153654/webrev.12/ > This looks good. Thanks for the update. Minor

Re: RFR: 8153654: Update jdeps to be multi-release jar aware

> This looks good. Thanks for the update. > > Minor comments below and you can make the change before you push (no need for > a new webrev). > > MultiReleaseException.java >key and msg should be final fields Done. > > VersionHelper.java > nameToVersion can simply be Map (I missed this

Re: RFR: 8153654: Update jdeps to be multi-release jar aware

> On Sep 16, 2016, at 1:30 PM, Steve Drach wrote: > >> >> VersionHelper.java >> nameToVersion can simply be Map (I missed this last round) > > It should be , see line 43 of VersionHelper. This returns a concatenated string. line 43 will work as is as (javap shows what javac emits.) > >>