RFR[8245658]: 'Arrays.java has two occurrences of bad unicode constants in Javadoc.'

Hi, Could someone please review my webrev for JDK-8245658 'Arrays.java has two occurrences of bad unicode constants in Javadoc.'? In Arrays.java Javadoc, there were two instances of bad Unicode formatting where the null character constant was incorrectly specified with '\u000' (another zero

Re: RFR(xs): 8245970: IntStream.html#reduce doc should not mention average

+1  > On May 29, 2020, at 6:05 AM, Conor Cleary wrote: > > Hi, > > The method-level documentation of Intstream::reduce(int, IntBinaryOperator) > mentions the average function as a case of reduction even though the function > cannot be used with the reduce method. This might cause

Re: RFR[8245658]: 'Arrays.java has two occurrences of bad unicode constants in Javadoc.'

looks fine Connor > On May 29, 2020, at 5:37 AM, Conor Cleary wrote: > > Hi, > > Could someone please review my webrev for JDK-8245658 'Arrays.java has two > occurrences of bad unicode constants in Javadoc.'? > > In Arrays.java Javadoc, there were two instances of bad Unicode formatting >

Re: RFR[8245658]: 'Arrays.java has two occurrences of bad unicode constants in Javadoc.'

Hi Connor, You will want to add the label noreg-doc to the issue before you push for fix Best Lance > On May 29, 2020, at 6:25 AM, Lance Andersen wrote: > > looks fine Connor > >> On May 29, 2020, at 5:37 AM, Conor Cleary wrote: >> >> Hi, >> >> Could someone please review my webrev for

Re: RFR(xs): 8245970: IntStream.html#reduce doc should not mention average

Hi Conor, I believe you want to reference https://bugs.openjdk.java.net/browse/JDK-8242281 as the issue below ,https://bugs.openjdk.java.net/browse/JDK-8245970, is the CSR that was withdrawn. Please add the label noreg-doc prior to

Re: RFR[8245658]: 'Arrays.java has two occurrences of bad unicode constants in Javadoc.'

There were two issues with this sequence in the resulting HTML pages. The first one, which you mentioned and fixed, was a missing zero. The second one, which you fixed but didn't mention, was an extra slash symbol. Looks good to me. P.S. There seem to be more cases where authors assumed the

RFR 8246040: java/foreign/TestAddressHandle fails on big endian platforms

Hi, following integration of second iteration of foreign memory access API, one of the new tests started acting up on big endian platforms (thanks to Thomas Stüfe for catching this!). Here's a fix: http://cr.openjdk.java.net/~mcimadamore/8246040_v1/webrev/ Cheers Maurizio

Re: RFR 8246040: java/foreign/TestAddressHandle fails on big endian platforms

> On 29 May 2020, at 12:21, Maurizio Cimadamore > wrote: > ... > > http://cr.openjdk.java.net/~mcimadamore/8246040_v1/webrev/ > LGTM. -Chris.

Re: RFR[8245658]: 'Arrays.java has two occurrences of bad unicode constants in Javadoc.'

+1  > On May 29, 2020, at 6:37 AM, Conor Cleary wrote: > > Hi, > > Could someone please review my webrev for JDK-8245658 'Arrays.java has two > occurrences of bad unicode constants in Javadoc.'? > > In Arrays.java Javadoc, there were two instances of bad Unicode formatting > where the

RFR(xs): 8245970: IntStream.html#reduce doc should not mention average

Hi, The method-level documentation of Intstream::reduce(int, IntBinaryOperator) mentions the average function as a case of reduction even though the function cannot be used with the reduce method. This might cause confusion, this fix therefore removes the mention of the average function from

Re: 8245867: Logger/bundleLeak/BundleTest.java fails due to "OutOfMemoryError: Java heap space"

Hi David, Thanks for the feedback! On 29/05/2020 00:36, David Holmes wrote: This seems to be assuming that the GC will clear all SoftReferences when it needs to clear any SoftReference. I don't think that is at all guaranteed. In theory your memory eating loop could be satisfied by clearing

Re: RFR(xs): 8242281: IntStream.html#reduce doc should not mention average

Hi, You should also remove the @see #average() tag. I see this was already proposed in the CSR. When you push make sure to push with 8242281 (which is the bug id) and not with 8245970 - which is the CSR id. I have corrected the subject to help archeological search of the mail archive. best

Re: RFR(xs): 8242281: IntStream.html#reduce doc should not mention average

Oh! Thanks for pointing that Pavel. I should read comments fully ;-) I hadn't noticed that the CSR was withdrawn - I saw it was closed and thought it had been Approved. Well - keep the @see then! best regards, -- daniel On 29/05/2020 14:27, Pavel Rappo wrote: Daniel, have you considered

RFR: 8246152: Improve String concat bootstrapping

Hi, a few small simplifications and optimizations to StringConcatFactory: - refactor makeConcat/makeConcatWithArguments methods to remove the generateRecipe argument - fold back-to-back constants into one when parsing recipe, which allows the prepender logic to be simplified - do input

Re: RFR(xs): 8242281: IntStream.html#reduce doc should not mention average

Daniel, have you considered that comment from Paul Sandoz to that CSR? > IMHO removing the @see is not necessary in this respect, it's useful to point > to related reduction methods.

RFR: JDK-8246010: AdditionalLaunchersTest is not enabled, and fails.

Please review jpackage fix at [1] to issue [2] /Andy [1] http://cr.openjdk.java.net/~herrick/8246010/webrev.01/ [2] https://bugs.openjdk.java.net/browse/JDK-8246010

Re: RFR 8246040: java/foreign/TestAddressHandle fails on big endian platforms

Looks good to me. -Sundar On 29/05/20 4:51 pm, Maurizio Cimadamore wrote: Hi, following integration of second iteration of foreign memory access API, one of the new tests started acting up on big endian platforms (thanks to Thomas Stüfe for catching this!). Here's a fix:

Re: RFR[8245658]: 'Arrays.java has two occurrences of bad unicode constants in Javadoc.'

Looks good to me Conor! best regards, -- daniel On 29/05/2020 10:37, Conor Cleary wrote: Hi, Could someone please review my webrev for JDK-8245658 'Arrays.java has two occurrences of bad unicode constants in Javadoc.'? In Arrays.java Javadoc, there were two instances of bad Unicode

Re: 8245867: Logger/bundleLeak/BundleTest.java fails due to "OutOfMemoryError: Java heap space"

On 5/29/20 11:39 AM, Daniel Fuchs wrote: Hi, I have updated the webrev as suggested by David: http://cr.openjdk.java.net/~dfuchs/webrev_8245867/webrev.01 test/jdk/java/util/logging/Logger/bundleLeak/BundleTest.java     No comments. Thumbs up. Dan Unless I hear any objection I'll push

Re: RFR: 8246152: Improve String concat bootstrapping

Hi Claes, For the code below the comment "Mock the recipe to reuse the concat generator code", i believe you can use String.repeat() that was introduced recently. The code that parse the the receipe can be in its own method to make the code more readable, this method returns the list and use

Re: 8245867: Logger/bundleLeak/BundleTest.java fails due to "OutOfMemoryError: Java heap space"

Hi Daniel, Do you still need the SoftReference import given you are no longer using it with memory.add()? Best Lance > On May 29, 2020, at 11:39 AM, Daniel Fuchs wrote: > > Hi, > > I have updated the webrev as suggested by David: > >

Re: RFR: 8246152: Improve String concat bootstrapping

Hi, will deal with your suggestions soon, separately. :-) On 2020-05-29 17:51, Remi Forax wrote: Can you explain me, what rebind is exactly ? MH.rebind() wraps any kind of MH as a BoundMethodHandle, which is necessary to subject it to transforms. /** Require this method handle to be a

Re: RFR: 8246152: Improve String concat bootstrapping

- Mail original - > De: "Claes Redestad" > À: "Remi Forax" > Cc: "core-libs-dev" > Envoyé: Vendredi 29 Mai 2020 18:10:40 > Objet: Re: RFR: 8246152: Improve String concat bootstrapping > Hi, > > will deal with your suggestions soon, separately. :-) > > On 2020-05-29 17:51, Remi Forax

Re: 8245867: Logger/bundleLeak/BundleTest.java fails due to "OutOfMemoryError: Java heap space"

Hi, I have updated the webrev as suggested by David: http://cr.openjdk.java.net/~dfuchs/webrev_8245867/webrev.01 Unless I hear any objection I'll push that new version if the tests come back successful. best regards, -- daniel (tier1 and 2 passed, tier5 still running) On 29/05/2020 00:36,

Re: RFR: 8246152: Improve String concat bootstrapping

Hi Rémi, thanks for looking at this and suggesting some improvements! On 2020-05-29 17:51, Remi Forax wrote: Hi Claes, For the code below the comment "Mock the recipe to reuse the concat generator code", i believe you can use String.repeat() that was introduced recently. Sure, The code

Re: RFR(xs): 8245970: IntStream.html#reduce doc should not mention average

+1 Paul. > On May 29, 2020, at 2:04 AM, Conor Cleary wrote: > > Hi, > > The method-level documentation of Intstream::reduce(int, IntBinaryOperator) > mentions the average function as a case of reduction even though the function > cannot be used with the reduce method. This might cause

Re: RFR: JDK-8245432: Lookup::defineHiddenClass should throw UnsupportedClassVersionError if the given bytes are of an unsupported major or minor version

On 29/05/2020 04:52, Mandy Chung wrote: On 5/28/20 5:44 PM, David Holmes wrote: This is to validate the given version.  The runtime will check if preview feature is enabled when such class file is loaded.   I will make a comment to make it clear. Okay but I thought the intent here was to

Re: RFR: 8246152: Improve String concat bootstrapping

On 2020-05-29 19:32, fo...@univ-mlv.fr wrote: - Mail original - De: "Claes Redestad" À: "Remi Forax" Cc: "core-libs-dev" Envoyé: Vendredi 29 Mai 2020 18:47:03 Objet: Re: RFR: 8246152: Improve String concat bootstrapping Hi Rémi, thanks for looking at this and suggesting some

Re: RFR 8246095: Tweaks to memory access API

> On 28 May 2020, at 22:25, Maurizio Cimadamore > wrote: > > Hi, > this followup change includes a number of tweaks that have been added to the > memory access API while we were in the process of integrating it. Most of > them have been contributed by Chris (thanks!), and are all listed in

RFR: JDK-8222241 - Example in ServiceLoader API docs should have one provides directive

Hi, in the ServiceLoader API docs, the given example specifying the service providers for a particular service should be comma-separated instead of using two separate ‘provides’ directives, that would result in a compilation error. Web rev:

Re: 8245867: Logger/bundleLeak/BundleTest.java fails due to "OutOfMemoryError: Java heap space"

On 29/05/2020 16:53, Lance Andersen wrote: Hi Daniel, Do you still need the SoftReference import given you are no longer using it with memory.add()? No - I removed it. cheers, -- daniel Best Lance

Re: RFR: 8245832 - JDK build make-static-libs should build all JDK libraries

Looks good. /Erik On 2020-05-29 10:07, Bob Vandette wrote: Please review this change that alters the make target “make-static-libs” to produce static libraries for ALL native libraries in the JDK. Prior to this fix we only built a small select list. Note: I had to change the functions

Re: RFR: 8246152: Improve String concat bootstrapping

- Mail original - > De: "Claes Redestad" > À: "Remi Forax" > Cc: "core-libs-dev" > Envoyé: Vendredi 29 Mai 2020 18:47:03 > Objet: Re: RFR: 8246152: Improve String concat bootstrapping > Hi Rémi, > > thanks for looking at this and suggesting some improvements! > > On 2020-05-29 17:51,

Re: RFR: JDK-8222241 - Example in ServiceLoader API docs should have one provides directive

On 29/05/2020 18:12, Fernando Guallini wrote: Hi, in the ServiceLoader API docs, the given example specifying the service providers for a particular service should be comma-separated instead of using two separate ‘provides’ directives, that would result in a compilation error. Web rev:

RFR: 8245832 - JDK build make-static-libs should build all JDK libraries

Please review this change that alters the make target “make-static-libs” to produce static libraries for ALL native libraries in the JDK. Prior to this fix we only built a small select list. Note: I had to change the functions JAWT_GetAWT for all platforms to match the prototype which used

Re: RFR: JDK-8245831: Unify code parsing version strings on Mac and Windows

On 5/27/2020 10:05 AM, Andy Herrick wrote: looks good curious why app.identifier was added to cfg file.  I don't see it used anywhere. Right. That is why I removed it. Thank you for the review! - Alexey /Andy On 5/26/2020 3:26 PM, Alexey Semenyuk wrote: Please review fix [2] for

Re: RFR 8246095: Tweaks to memory access API

+1 (reviewed on panama-dev) Paul. > On May 28, 2020, at 2:25 PM, Maurizio Cimadamore > wrote: > > Hi, > this followup change includes a number of tweaks that have been added to the > memory access API while we were in the process of integrating it. Most of > them have been contributed by

Re: RFR: 8246152: Improve String concat bootstrapping

- Mail original - > De: "Claes Redestad" > À: "Remi Forax" > Cc: "core-libs-dev" > Envoyé: Vendredi 29 Mai 2020 20:45:26 > Objet: Re: RFR: 8246152: Improve String concat bootstrapping > On 2020-05-29 19:32, fo...@univ-mlv.fr wrote: >> - Mail original - >>> De: "Claes

Re: RFR: JDK-8245432: Lookup::defineHiddenClass should throw UnsupportedClassVersionError if the given bytes are of an unsupported major or minor version

It's fixed.  Thanks Mandy On 5/28/20 4:35 PM, Johannes Kuhn wrote: Hi, just noticed a small thing: The magic is 4 bytes, but readUnsignedShort reads two bytes. - Johannes On 28-May-20 19:25, Mandy Chung wrote: On 5/28/20 6:55 AM, Alan Bateman wrote: On 28/05/2020 05:13, Mandy Chung

Re: RFR: JDK-8245432: Lookup::defineHiddenClass should throw UnsupportedClassVersionError if the given bytes are of an unsupported major or minor version

On 5/29/20 11:29 AM, Alan Bateman wrote: I went through webrev.02 and the only issue is the magic is read as a u2 when it should be u4, otherwise looks good. Thanks.  Updated in place: http://cr.openjdk.java.net/~mchung/jdk15/webrevs/8245432/webrev.02/index.html Mandy

Re: RFR: JDK-8246010: AdditionalLaunchersTest is not enabled, and fails.

On 5/29/20 7:00 PM, alexander.matv...@oracle.com wrote: Hi Andy, Why we need error.lock-resource? because resource was used , but never defined. Also, I do not like 194 limit obtained by testing, since once new files are introduced in runtime this value might not work anymore. Can we

RFR: 8232841: [TESTBUG] [macos] SigningPackageTest fails when untrusted certificates exist on machine

Please review the jpackage fix for bug [1] at [2]. - I was not able to reproduce this issue. Not sure why this command returns non zero code in some cases. It still returns output which we need, so fixed by ignoring exit code, since we will scan output for presence of certificate anyway.

RFR(XL) 8198698: Support Lambda proxy classes in dynamic CDS archive

RFE: https://bugs.openjdk.java.net/browse/JDK-8198698 webrev: http://cr.openjdk.java.net/~ccheung/jdk15/8198698/webrev.00/ There's a high level design doc in the attachment[1] of the RFE. Passed tiers 1 - 4 tests (including the new tests). thanks, Calvin [1]

Re: RFR: 8246152: Improve String concat bootstrapping

Hi Paul, On 2020-05-29 21:57, Paul Sandoz wrote: This looks good. Thanks for reviewing! 204 String recipe = "\u0001".repeat(concatType.parameterCount()); IIUC, that’s a rather convoluted way of creating a List from: Collections.nCopies(concatType.parameterCount(). (String)

Re: RFR: JDK-8246010: AdditionalLaunchersTest is not enabled, and fails.

Hi Andy, Why we need error.lock-resource? Also, I do not like 194 limit obtained by testing, since once new files are introduced in runtime this value might not work anymore. Can we check on actual file paths to make sure they have valid length? Thanks, Alexander On 5/29/20 7:36 AM, Andy

Re: RFR: 8246152: Improve String concat bootstrapping

On 2020-05-29 21:18, fo...@univ-mlv.fr wrote: - Mail original - De: "Claes Redestad" À: "Remi Forax" Cc: "core-libs-dev" Envoyé: Vendredi 29 Mai 2020 20:45:26 Objet: Re: RFR: 8246152: Improve String concat bootstrapping On 2020-05-29 19:32, fo...@univ-mlv.fr wrote: -

Re: RFR: 8246152: Improve String concat bootstrapping

This looks good. 204 String recipe = "\u0001".repeat(concatType.parameterCount()); IIUC, that’s a rather convoluted way of creating a List from: Collections.nCopies(concatType.parameterCount(). (String) null); Perhaps it makes sense to double down on the List representation with an

Re: RFR: JDK-8246010: AdditionalLaunchersTest is not enabled, and fails.

On 5/29/20 7:16 PM, Alexey Semenyuk wrote: Andy, The check is added to WindowsAppImageBuilder.java which means it will be done for app image bundling too. However the problem is with msi bundling only as far as I understood from your explanation. Did you try fix suggested at [1]? Yes -

Re: RFR 8246095: Tweaks to memory access API

I added myself as reviewer on the CSR. Thanks The code looks good to me. Thanks for taking the time to include these API tweaks in JDK 15. Well, thank _you_ for contributing these great additions! Cheers Maurizio -Chris.

Re: 8246183: Scanner/ScanTest.java fails due to SIGSEGV in StubRoutines::jshort_disjoint_arraycopy

Missed that it was a backout.  > On May 29, 2020, at 11:18 PM, James Laskey wrote: > > You may not have intended this comment. s/offset/scale/ > 49 > 50 // Cached array base offset > 51 private static final long ARRAY_INDEX_SCALE = > UNSAFE.arrayIndexScale($type$[].class); > >

Re: RFR: JDK-8245432: Lookup::defineHiddenClass should throw UnsupportedClassVersionError if the given bytes are of an unsupported major or minor version

Thanks. Noted that readInt can read outside of the byte array when it is shorter than 4 bytes, throwing an ArrayIndexOutOfBoundsException. Same applies for readUnsignedShort. Test cases for malformedClassFiles: new byte[3], new byte[] {0xCA, 0xFE, 0xBA, 0xBE, 0x00} - Johannes On

Re: 8246183: Scanner/ScanTest.java fails due to SIGSEGV in StubRoutines::jshort_disjoint_arraycopy

Looks good, thanks for fixing! Cheers, Mikael > On May 29, 2020, at 7:01 PM, Brian Burkhalter > wrote: > > Please review this fix [1] for [2]. It in effect just backs out the recent > fix for [3]. I’ll investigate the root cause next week. > > Thanks, > > Brian > > [1]

8246183: Scanner/ScanTest.java fails due to SIGSEGV in StubRoutines::jshort_disjoint_arraycopy

Please review this fix [1] for [2]. It in effect just backs out the recent fix for [3]. I’ll investigate the root cause next week. Thanks, Brian [1] http://cr.openjdk.java.net/~bpb/8246183/webrev.00/ [2] https://bugs.openjdk.java.net/browse/JDK-8246183 [3]

Re: 8246183: Scanner/ScanTest.java fails due to SIGSEGV in StubRoutines::jshort_disjoint_arraycopy

You may not have intended this comment. s/offset/scale/ 49 50 // Cached array base offset 51 private static final long ARRAY_INDEX_SCALE = UNSAFE.arrayIndexScale($type$[].class);  > On May 29, 2020, at 11:05 PM, Mikael Vidstedt > wrote: > >  > Looks good, thanks for fixing!

Re: RFR: JDK-8245432: Lookup::defineHiddenClass should throw UnsupportedClassVersionError if the given bytes are of an unsupported major or minor version

On 5/28/20 9:18 PM, David Holmes wrote: On 29/05/2020 1:52 pm, Mandy Chung wrote: On 5/28/20 5:44 PM, David Holmes wrote: This is to validate the given version.  The runtime will check if preview feature is enabled when such class file is loaded. I will make a comment to make it clear.

Re: RFR: JDK-8246010: AdditionalLaunchersTest is not enabled, and fails.

Andy, The check is added to WindowsAppImageBuilder.java which means it will be done for app image bundling too. However the problem is with msi bundling only as far as I understood from your explanation. Did you try fix suggested at [1]? [1]

[PATCH] Typo in java.util.regex.Pattern

Hi! I found a typo which has been long undetected in the documentation. In case you think this is worthwhile, I would appreciate it if someone can sponsor this patch. Cheers, Shao Yang = PATCH == diff --git a/src/java.base/share/classes/java/util/regex/Pattern.java

Re: 8246183: Scanner/ScanTest.java fails due to SIGSEGV in StubRoutines::jshort_disjoint_arraycopy

OK, looks good. Thanks for jumping on this quickly. s'marks On 5/29/20 7:01 PM, Brian Burkhalter wrote: Please review this fix [1] for [2]. It in effect just backs out the recent fix for [3]. I’ll investigate the root cause next week. Thanks, Brian [1]

Re: 8246183: Scanner/ScanTest.java fails due to SIGSEGV in StubRoutines::jshort_disjoint_arraycopy

Thanks. Pushed. Brian > On May 29, 2020, at 7:10 PM, Stuart Marks wrote: > > OK, looks good. Thanks for jumping on this quickly. > > s'marks > > On 5/29/20 7:01 PM, Brian Burkhalter wrote: >> Please review this fix [1] for [2]. It in effect just backs out the recent >> fix for [3]. I’ll

[PATCH] Typo in java.util.regex.Pattern

Hi! I found a typo which has been long undetected in the documentation. In case you think this is worthwhile, I would appreciate it if someone can sponsor this patch. Cheers, Shao Yang = PATCH == diff --git a/src/java.base/share/classes/java/util/regex/Pattern.java