Re: RFR: 8253299: Manifest bytes are read twice when verifying a signed JAR

On Thu, 19 Nov 2020 17:13:00 GMT, Lance Andersen wrote: >> Small change to retrieve the raw bytes of manifest during verifying signed >> JAR. > > Marked as reviewed by lancea (Reviewer). Thank you all for the review. I added the noreg-trivial label to the bug. - PR:

Integrated: 8253299: Manifest bytes are read twice when verifying a signed JAR

On Wed, 18 Nov 2020 21:59:01 GMT, Hai-May Chao wrote: > Small change to retrieve the raw bytes of manifest during verifying signed > JAR. This pull request has now been integrated. Changeset: 9bb82232 Author:Hai-May Chao Committer: Lance Andersen URL:

Integrated: 8227400: Adjust jib profiles to make 3rd party tools for creating installers available on Mach5 test machines

On Wed, 18 Nov 2020 21:57:13 GMT, Alexey Semenyuk wrote: > Fix test failures. They didn't fail in Mach5 test runs as WiX was not > available on test machines and these tests were not executed. This pull request has now been integrated. Changeset: 1718abae Author:Alexey Semenyuk URL:

Re: RFR: 8255908: ExceptionInInitializerError due to UncheckedIOException while initializing cgroupv1 subsystem [v2]

On Thu, 19 Nov 2020 15:00:54 GMT, Poonam Bajaj wrote: >> src/java.base/linux/classes/jdk/internal/platform/cgroupv1/CgroupV1Subsystem.java >> line 79: >> >>> 77: .forEach(entry -> createSubSystemController(subsystem, >>> entry)); >>> 78: >>> 79: } catch

Re: RFR: 8255908: ExceptionInInitializerError due to UncheckedIOException while initializing cgroupv1 subsystem [v2]

On Thu, 19 Nov 2020 17:04:15 GMT, Poonam Bajaj wrote: >> Hi, >> >> Please review this simple change that catches UncheckedIOException that can >> occur if /proc/self/cgroup or /proc/self/mountinfo files don't exist on the >> system, or if there is an interrupt while these are being read. >>

Re: RFR: 8256585: Remove in-place conversion vector operators from Vector API [v2]

On Thu, 19 Nov 2020 17:18:12 GMT, Paul Sandoz wrote: >> Sandhya Viswanathan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update documentation > > The documentation `Vector.convert` and `Vector.convertShape` needs to be > updated to

Re: RFR: 8256299: Implement JEP 396: Strongly Encapsulate JDK Internals by Default [v2]

On Thu, 19 Nov 2020 17:16:22 GMT, Mark Reinhold wrote: >> Please review this implementation of JEP 396 >> (https://openjdk.java.net/jeps/396). >> Alan Bateman is the original author; I’ve credited him in the commit >> metadata. >> Passes tiers 1-3 on {linux,macos,windows}-x64 and

Re: RFR: 8246739: InputStream.skipNBytes could be implemented more efficiently

On Thu, 19 Nov 2020 19:29:43 GMT, Brian Burkhalter wrote: > Please review this modification of `java.io.InputStream.skipNBytes(long)` to > improve its performance when `skip(long)` skips fewer than the requested > number of bytes. In the current implementation, `skip(long)` is invoked once >

Re: RFR: 8255908: ExceptionInInitializerError due to UncheckedIOException while initializing cgroupv1 subsystem [v3]

> Hi, > > Please review this simple change that catches UncheckedIOException that can > occur if /proc/self/cgroup or /proc/self/mountinfo files don't exist on the > system, or if there is an interrupt while these are being read. > > Testing: Tier1, Tier2 and Tier3. > > Thanks, > Poonam

Re: RFR: 8246739: InputStream.skipNBytes could be implemented more efficiently [v2]

On Thu, 19 Nov 2020 20:20:17 GMT, Brian Burkhalter wrote: >> Please review this modification of `java.io.InputStream.skipNBytes(long)` to >> improve its performance when `skip(long)` skips fewer than the requested >> number of bytes. In the current implementation, `skip(long)` is invoked once

Re: RFR: 8246739: InputStream.skipNBytes could be implemented more efficiently [v2]

On Thu, 19 Nov 2020 20:20:17 GMT, Brian Burkhalter wrote: >> Please review this modification of `java.io.InputStream.skipNBytes(long)` to >> improve its performance when `skip(long)` skips fewer than the requested >> number of bytes. In the current implementation, `skip(long)` is invoked once

Re: RFR: 8255908: ExceptionInInitializerError due to UncheckedIOException while initializing cgroupv1 subsystem

On Thu, 19 Nov 2020 14:36:53 GMT, Aleksey Shipilev wrote: >> Hi, >> >> Please review this simple change that catches UncheckedIOException that can >> occur if /proc/self/cgroup or /proc/self/mountinfo files don't exist on the >> system, or if there is an interrupt while these are being read.

Re: RFR: 8253299: Manifest bytes are read twice when verifying a signed JAR

On Wed, 18 Nov 2020 21:59:01 GMT, Hai-May Chao wrote: > Small change to retrieve the raw bytes of manifest during verifying signed > JAR. Marked as reviewed by alanb (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/1299

Re: RFR: 8256585: Remove in-place conversion vector operators from Vector API [v2]

On Thu, 19 Nov 2020 19:47:15 GMT, Sandhya Viswanathan wrote: >> Remove partially implemented in-place conversion vector operators from >> Vector API: >>ofNarrowing, ofWidening, INPLACE_XXX > > Sandhya Viswanathan has updated the pull request incrementally with one > additional commit

Re: RFR: 8256154: Some TestNG tests require default constructors

On Thu, 19 Nov 2020 16:36:02 GMT, Daniel Fuchs wrote: >> test/jdk/java/lang/StackWalker/Basic.java line 116: >> >>> 114: /** For TestNG */ >>> 115: public Basic() { >>> 116: depth = 0; >> >> Is the assignment really ended here? I only see: >> >> Basic test = new

Re: RFR: 8256299: Implement JEP 396: Strongly Encapsulate JDK Internals by Default [v2]

> Please review this implementation of JEP 396 > (https://openjdk.java.net/jeps/396). > Alan Bateman is the original author; I’ve credited him in the commit metadata. > Passes tiers 1-3 on {linux,macos,windows}-x64 and linux-aarch64. Mark Reinhold has updated the pull request incrementally with

Re: RFR: JDK-8256475: Fix Behavior when Installer name differs from applicatio… [v2]

On Thu, 19 Nov 2020 16:49:23 GMT, Andy Herrick wrote: >> …n name. > > Andy Herrick has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains 69 additional

Re: RFR: 8256487: Handle disableEagerInitialization for archived lambda proxy classes

On Wed, 18 Nov 2020 23:58:25 GMT, Calvin Cheung wrote: > Before this change, the setting of the > `jdk.internal.lambda.disableEagerInitialization` property was not captured > during dumping of lambda proxy classes. There's a workaround in > `LambdaProxyClassArchive.find`, it won't call

Re: RFR: 8211449: Correction to the spec of implicit negative subpattern in DecimalFormat

On Thu, 19 Nov 2020 17:15:11 GMT, Naoto Sato wrote: > Hi, > > Please review this doc only fix to the class description of `DecimalFormat` > class. `localized minus sign` has never been (and should never be) used in > the implicit negative subpattern. Actual implementation correctly uses ascii

Re: RFR: 8256480: Refactor ObjectInputStream field reader implementation [v2]

> ObjectInputStream has nearly identical but separate implementations to read > values from the stream. > Both implementations read primitive and object values from the stream and > return an object holding the values. > OIS.readFields() uses the internal class GetFieldImpl while >

Re: RFR: 8037384: Fix wording in Javadoc of java.io.Serializable

On Thu, 19 Nov 2020 03:44:10 GMT, Stuart Marks wrote: > 8231547: Serializable class doc should link to serialization specification > > Rewrite a couple confusing sentences in the Serializable class doc. This does > affect normative text, but the edits are primarily to focus and clarify the >

Re: RFR: 8256585: Remove in-place conversion vector operators from Vector API

On Thu, 19 Nov 2020 03:26:20 GMT, Sandhya Viswanathan wrote: > Remove partially implemented in-place conversion vector operators from Vector > API: >ofNarrowing, ofWidening, INPLACE_XXX The documentation `Vector.convert` and `Vector.convertShape` needs to be updated to remove

Re: RFR: JDK-8256475: Fix Behavior when Installer name differs from applicatio… [v3]

> …n name. Andy Herrick has updated the pull request incrementally with one additional commit since the last revision: JDK-8256475: Fix Behavior when Installer name differs from application name. - Changes: - all: https://git.openjdk.java.net/jdk/pull/1300/files - new:

Re: RFR: 8246739: InputStream.skipNBytes could be implemented more efficiently

On Thu, 19 Nov 2020 19:58:16 GMT, Naoto Sato wrote: > The code looks good. Should we also change the @implSpec, as it specifically > describes how it works, i.e., calling no-arg read(), but the new impl calls > read() with buffer. Good catch. Yes, the `@implSpec` should be updated. I was too

Re: RFR: 8255908: ExceptionInInitializerError due to UncheckedIOException while initializing cgroupv1 subsystem [v2]

On Thu, 19 Nov 2020 19:29:25 GMT, Bob Vandette wrote: >> This looks good to me. @jerboaa might want to take a look. > > Shouldn't you add a check in > src/java.base/linux/classes/jdk/internal/platform/cgroupv2/CgroupV2Subsystem.java:sumTokensIOStat > ? > > What about getLongEntry in >

Re: RFR: 8256154: Some TestNG tests require default constructors

On Thu, 19 Nov 2020 15:56:59 GMT, Lance Andersen wrote: >> In TestNG 7, it is a requirement that TestNG is able to create a Test object >> using a default constructor. >> >> This simple fix addresses two such classes so that this requirement is >> satisfied by inserting default construtors.

Re: RFR: 8253299: Manifest bytes are read twice when verifying a signed JAR

On Wed, 18 Nov 2020 21:59:01 GMT, Hai-May Chao wrote: > Small change to retrieve the raw bytes of manifest during verifying signed > JAR. Marked as reviewed by lancea (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/1299

Re: RFR: 8211449: Correction to the spec of implicit negative subpattern in DecimalFormat

On Thu, 19 Nov 2020 17:15:11 GMT, Naoto Sato wrote: > Hi, > > Please review this doc only fix to the class description of `DecimalFormat` > class. `localized minus sign` has never been (and should never be) used in > the implicit negative subpattern. Actual implementation correctly uses ascii

Integrated: 8253459: Formatter treats index, width and precision > Integer.MAX_VALUE incorrectly

On Mon, 5 Oct 2020 22:23:56 GMT, Ian Graves wrote: > The `java.util.Formatter` format specifies support for field widths, argument > indexes, or precision lengths of a field that relate to the variadic > arguments supplied to the formatter. These numbers are specified by integers, > sometimes

Re: RFR: 8246739: InputStream.skipNBytes could be implemented more efficiently

> On Nov 19, 2020, at 12:04 PM, Brian Burkhalter wrote: > > On Thu, 19 Nov 2020 19:58:16 GMT, Naoto Sato > wrote: > >> The code looks good. Should we also change the @implSpec, as it specifically >> describes how it works, i.e., calling no-arg read(), but the new

Re: RFR: 8246739: InputStream.skipNBytes could be implemented more efficiently [v2]

On Thu, 19 Nov 2020 21:41:00 GMT, Naoto Sato wrote: >> Brian Burkhalter has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - 8246739: InputStream.skipNBytes could be implemented more efficiently >> - 8246739: InputStream.skipNBytes could

Re: RFR: JDK-8256475: Fix Behavior when Installer name differs from applicatio… [v2]

> …n name. Andy Herrick has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 69 additional commits since the last revision: - JDK-8256475: Fix Behavior

Re: RFR: 8255908: ExceptionInInitializerError due to UncheckedIOException while initializing cgroupv1 subsystem [v2]

On Thu, 19 Nov 2020 16:41:07 GMT, Poonam Bajaj wrote: >> src/java.base/linux/classes/jdk/internal/platform/CgroupUtil.java line 50: >> >>> 48: throw new InternalError(e.getCause()); >>> 49: } catch (UncheckedIOException e) { >>> 50: throw e.getCause(); >> >>

Re: RFR: 8255908: ExceptionInInitializerError due to UncheckedIOException while initializing cgroupv1 subsystem [v2]

> Hi, > > Please review this simple change that catches UncheckedIOException that can > occur if /proc/self/cgroup or /proc/self/mountinfo files don't exist on the > system, or if there is an interrupt while these are being read. > > Testing: Tier1, Tier2 and Tier3. > > Thanks, > Poonam

Re: RFR: 8037384: Fix wording in Javadoc of java.io.Serializable

On Thu, 19 Nov 2020 03:44:10 GMT, Stuart Marks wrote: > 8231547: Serializable class doc should link to serialization specification > > Rewrite a couple confusing sentences in the Serializable class doc. This does > affect normative text, but the edits are primarily to focus and clarify the >

Re: RFR: 8256299: Implement JEP 396: Strongly Encapsulate JDK Internals by Default [v2]

On Thu, 19 Nov 2020 17:03:54 GMT, Alan Bateman wrote: >> Mark Reinhold has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove unnecessary @module :open from ASN1FormatterTest.java > >

Re: RFR: 8253299: Manifest bytes are read twice when verifying a signed JAR

On Thu, 19 Nov 2020 17:08:21 GMT, Alan Bateman wrote: >> Small change to retrieve the raw bytes of manifest during verifying signed >> JAR. > > Marked as reviewed by alanb (Reviewer). I can sponsor once you integrate - PR: https://git.openjdk.java.net/jdk/pull/1299

RFR: 8211449" Correction to the spec of implicit negative subpattern in DecimalFormat

Hi, Please review this doc only fix to the class description of `DecimalFormat` class. `localized minus sign` has never been (and should never be) used in the implicit negative subpattern. Actual implementation correctly uses ascii minus sign for that purpose, so there won't be any

Re: RFR: 8256183: InputStream.skipNBytes is missing @since 12

On Thu, 19 Nov 2020 12:35:04 GMT, Conor Cleary wrote: > InputStream.skipNBytes is missing `@since 12` tag which was not added during > the review of [JDK-6516099](https://bugs.openjdk.java.net/browse/JDK-6516099). > > This small fix adds the `@since` tag to InputStream.skipNBytes Marked as

Re: RFR: 8255908: ExceptionInInitializerError due to UncheckedIOException while initializing cgroupv1 subsystem [v2]

On Thu, 19 Nov 2020 17:56:50 GMT, Aleksey Shipilev wrote: >> Poonam Bajaj has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Added UncheckedIOException catch blocks for cgroupv2 subsystem, and also >> for the rest of reader methods in

Re: RFR: 8256487: Handle disableEagerInitialization for archived lambda proxy classes

On Wed, 18 Nov 2020 23:58:25 GMT, Calvin Cheung wrote: > Before this change, the setting of the > `jdk.internal.lambda.disableEagerInitialization` property was not captured > during dumping of lambda proxy classes. There's a workaround in > `LambdaProxyClassArchive.find`, it won't call

Re: RFR: 8246739: InputStream.skipNBytes could be implemented more efficiently [v2]

On Thu, 19 Nov 2020 20:20:17 GMT, Brian Burkhalter wrote: >> Please review this modification of `java.io.InputStream.skipNBytes(long)` to >> improve its performance when `skip(long)` skips fewer than the requested >> number of bytes. In the current implementation, `skip(long)` is invoked once

Re: RFR: JDK-8256475: Fix Behavior when Installer name differs from applicatio… [v4]

> …n name. Andy Herrick has updated the pull request incrementally with one additional commit since the last revision: JDK-8256475: Fix Behavior when Installer name differs from application name. - Changes: - all: https://git.openjdk.java.net/jdk/pull/1300/files - new:

Integrated: 8256581: Refactor vector conversion tests

On Thu, 19 Nov 2020 01:07:12 GMT, Paul Sandoz wrote: > Refactor the vector conversions tests to improve performance and reduce > explicit test methods (using data providers). This pull request has now been integrated. Changeset: 580f22cc Author:Paul Sandoz URL:

Re: RFR: 8253299: Manifest bytes are read twice when verifying a signed JAR

On Thu, 19 Nov 2020 17:20:58 GMT, Hai-May Chao wrote: >> Marked as reviewed by lancea (Reviewer). > > Thank you all for the review. I added the noreg-trivial label to the bug. Lance, I've entered /integrate. Thank you for sponsoring this! - PR:

Re: RFR: 8246739: InputStream.skipNBytes could be implemented more efficiently

On Thu, 19 Nov 2020 19:29:43 GMT, Brian Burkhalter wrote: > Please review this modification of `java.io.InputStream.skipNBytes(long)` to > improve its performance when `skip(long)` skips fewer than the requested > number of bytes. In the current implementation, `skip(long)` is invoked once >

Re: RFR: 8246739: InputStream.skipNBytes could be implemented more efficiently

On Thu, 19 Nov 2020 19:52:05 GMT, Sergey Bylokhov wrote: >> Please review this modification of `java.io.InputStream.skipNBytes(long)` to >> improve its performance when `skip(long)` skips fewer than the requested >> number of bytes. In the current implementation, `skip(long)` is invoked once

RFR: 8256299: Implement JEP 396: Strongly Encapsulate JDK Internals by Default

Please review this implementation of JEP 396 (https://openjdk.java.net/jeps/396). Alan Bateman is the original author; I’ve credited him in the commit metadata. Passes tiers 1-3 on {linux,macos,windows}-x64 and linux-aarch64. - Commit messages: - 8256299: Implement JEP 396:

Re: RFR: 8256299: Implement JEP 396: Strongly Encapsulate JDK Internals by Default

On Thu, 19 Nov 2020 16:49:30 GMT, Mark Reinhold wrote: > Please review this implementation of JEP 396 > (https://openjdk.java.net/jeps/396). > Alan Bateman is the original author; I’ve credited him in the commit metadata. > Passes tiers 1-3 on {linux,macos,windows}-x64 and linux-aarch64.

Re: RFR: 8037384: Fix wording in Javadoc of java.io.Serializable

On Thu, 19 Nov 2020 03:44:10 GMT, Stuart Marks wrote: > 8231547: Serializable class doc should link to serialization specification > > Rewrite a couple confusing sentences in the Serializable class doc. This does > affect normative text, but the edits are primarily to focus and clarify the >

RFR: 8246739: InputStream.skipNBytes could be implemented more efficiently

Please review this modification of `java.io.InputStream.skipNBytes(long)` to improve its performance when `skip(long)` skips fewer than the requested number of bytes. In the current implementation, `skip(long)` is invoked once and, if not enough bytes have been skipped, then `read()` is invoked

Re: RFR: 8256585: Remove in-place conversion vector operators from Vector API [v2]

> Remove partially implemented in-place conversion vector operators from Vector > API: >ofNarrowing, ofWidening, INPLACE_XXX Sandhya Viswanathan has updated the pull request incrementally with one additional commit since the last revision: Update documentation - Changes:

Re: RFR: 8253459: Formatter treats index, width and precision > Integer.MAX_VALUE incorrectly [v13]

On Thu, 19 Nov 2020 00:58:21 GMT, Ian Graves wrote: >> The `java.util.Formatter` format specifies support for field widths, >> argument indexes, or precision lengths of a field that relate to the >> variadic arguments supplied to the formatter. These numbers are specified by >> integers,

Re: RFR: 8246739: InputStream.skipNBytes could be implemented more efficiently [v2]

> Please review this modification of `java.io.InputStream.skipNBytes(long)` to > improve its performance when `skip(long)` skips fewer than the requested > number of bytes. In the current implementation, `skip(long)` is invoked once > and, if not enough bytes have been skipped, then `read()` is

Re: RFR: 8256487: Handle disableEagerInitialization for archived lambda proxy classes

On Thu, 19 Nov 2020 16:09:41 GMT, Claes Redestad wrote: >> Hi Claes, >> >> Thanks for taking a look. >> >> So should I keep the following `!initialize` check in >> LambdaProxyClassArchive? >> 109 if (!loadedByBuiltinLoader(caller) || !initialize || >> 110

Re: RFR: 8235304: JPackage Windows test should be added to set Publisher [v2]

On Thu, 19 Nov 2020 22:26:20 GMT, Alexey Semenyuk wrote: >> 8235304: JPackage Windows test should be added to set Publisher > > Alexey Semenyuk has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in

Re: RFR: JDK-8256475: Fix Behavior when Installer name differs from applicatio… [v4]

On Thu, 19 Nov 2020 20:45:23 GMT, Andy Herrick wrote: >> …n name. > > Andy Herrick has updated the pull request incrementally with one additional > commit since the last revision: > > JDK-8256475: Fix Behavior when Installer name differs from application name. Marked as reviewed by

Integrated: 8251317: Support for CLDR version 38

On Tue, 17 Nov 2020 23:19:23 GMT, Naoto Sato wrote: > Hi, > > Please review the changes for upgrading the CLDR data to version 38. The vast > majority of the changes are simply the changes in CLDR upstream, and others > are mainly test changes due to the locale data change. This pull request

Re: RFR: 8235304: JPackage Windows test should be added to set Publisher [v2]

On Thu, 19 Nov 2020 22:26:20 GMT, Alexey Semenyuk wrote: >> 8235304: JPackage Windows test should be added to set Publisher > > Alexey Semenyuk has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in

Re: RFR: 8256487: Handle disableEagerInitialization for archived lambda proxy classes

On Thu, 19 Nov 2020 16:09:41 GMT, Claes Redestad wrote: >> Hi Claes, >> >> Thanks for taking a look. >> >> So should I keep the following `!initialize` check in >> LambdaProxyClassArchive? >> 109 if (!loadedByBuiltinLoader(caller) || !initialize || >> 110

Re: RFR: 8235304: JPackage Windows test should be added to set Publisher [v2]

> 8235304: JPackage Windows test should be added to set Publisher Alexey Semenyuk has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional

Re: RFR: 8256299: Implement JEP 396: Strongly Encapsulate JDK Internals by Default [v3]

On Thu, 19 Nov 2020 19:51:59 GMT, Mandy Chung wrote: >> Mark Reinhold has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add "Add-Exports" case for the >> setAccessibleNonPublicMemberNonExportedPackage test > >

Re: RFR: 8037384: Fix wording in Javadoc of java.io.Serializable [v2]

On Thu, 19 Nov 2020 17:11:04 GMT, Chris Hegarty wrote: >> Stuart Marks has updated the pull request incrementally with one additional >> commit since the last revision: >> >> non-serializable classes => non-serializable superclasses > > src/java.base/share/classes/java/io/Serializable.java

Re: RFR: 8037384: Fix wording in Javadoc of java.io.Serializable [v2]

> 8231547: Serializable class doc should link to serialization specification > > Rewrite a couple confusing sentences in the Serializable class doc. This does > affect normative text, but the edits are primarily to focus and clarify the > text, not to make any semantic changes. Thus, a CSR

Re: RFR: 8256299: Implement JEP 396: Strongly Encapsulate JDK Internals by Default [v3]

> Please review this implementation of JEP 396 > (https://openjdk.java.net/jeps/396). > Alan Bateman is the original author; I’ve credited him in the commit metadata. > Passes tiers 1-3 on {linux,macos,windows}-x64 and linux-aarch64. Mark Reinhold has updated the pull request incrementally with

Re: RFR: JDK-8256475: Fix Behavior when Installer name differs from applicatio… [v4]

On Thu, 19 Nov 2020 20:45:23 GMT, Andy Herrick wrote: >> …n name. > > Andy Herrick has updated the pull request incrementally with one additional > commit since the last revision: > > JDK-8256475: Fix Behavior when Installer name differs from application name. Marked as reviewed by almatvee

Withdrawn: 8256487: Handle disableEagerInitialization for archived lambda proxy classes

On Wed, 18 Nov 2020 23:58:25 GMT, Calvin Cheung wrote: > Before this change, the setting of the > `jdk.internal.lambda.disableEagerInitialization` property was not captured > during dumping of lambda proxy classes. There's a workaround in > `LambdaProxyClassArchive.find`, it won't call

Re: RFR: 8159746: (proxy) Support for default methods [v5]

> This proposes a new static `Proxy::invokeDefaultMethod` method to invoke > the given default method on the given proxy instance. > > The implementation looks up a method handle for `invokespecial` instruction > as if called from with the proxy class as the caller, equivalent to calling >

Re: RFR: 8256299: Implement JEP 396: Strongly Encapsulate JDK Internals by Default [v3]

On Thu, 19 Nov 2020 23:03:54 GMT, Mark Reinhold wrote: >> test/jdk/tools/launcher/modules/illegalaccess/IllegalAccessTest.java line >> 387: >> >>> 385: "--illegal-access=permit"); >>> 386: } >>> 387: >> >> I see `setAccessibleNonPublicMemberExportedPackage` test case

Re: RFR: 8256487: Handle disableEagerInitialization for archived lambda proxy classes

On Thu, 19 Nov 2020 19:42:51 GMT, Yumin Qi wrote: >> Before this change, the setting of the >> `jdk.internal.lambda.disableEagerInitialization` property was not captured >> during dumping of lambda proxy classes. There's a workaround in >> `LambdaProxyClassArchive.find`, it won't call

RFR: 8235304: JPackage Windows test should be added to set Publisher

8235304: JPackage Windows test should be added to set Publisher - Commit messages: - 8235304: JPackage Windows test should be added to set Publisher - 8227400: Adjust jib profiles to make 3rd party tools for creating installers available on Mach5 test machines Changes:

Re: RFR: 8256299: Implement JEP 396: Strongly Encapsulate JDK Internals by Default [v3]

On Thu, 19 Nov 2020 23:08:21 GMT, Mark Reinhold wrote: >> Please review this implementation of JEP 396 >> (https://openjdk.java.net/jeps/396). >> Alan Bateman is the original author; I’ve credited him in the commit >> metadata. >> Passes tiers 1-3 on {linux,macos,windows}-x64 and

Re: RFR: 8256643: Terminally deprecate ThreadGroup stop, destroy, isDestroyed,…

On Thu, 19 Nov 2020 14:24:18 GMT, Alan Bateman wrote: > This change terminally deprecates the following methods defined by > java.lang.ThreadGroup > > - stop > - destroy > - isDestroyed > - setDaemon > - isDaemon > > The stop method has been deprecated since=1.2 because it is inherently

RFR: 8256643: Terminally deprecate ThreadGroup stop, destroy, isDestroyed,…

This change terminally deprecates the following methods defined by java.lang.ThreadGroup - stop - destroy - isDestroyed - setDaemon - isDaemon The stop method has been deprecated since=1.2 because it is inherently unsafe. It is time to terminally deprecate this method so it can be

Re: RFR: 8256643: Terminally deprecate ThreadGroup stop, destroy, isDestroyed,…

On Thu, 19 Nov 2020 18:51:50 GMT, Sergey Bylokhov wrote: >> This change terminally deprecates the following methods defined by >> java.lang.ThreadGroup >> >> - stop >> - destroy >> - isDestroyed >> - setDaemon >> - isDaemon >> >> The stop method has been deprecated since=1.2 because it

Re: RFR: 8230501: Class data support for hidden classes [v4]

On Wed, 18 Nov 2020 00:50:22 GMT, Mandy Chung wrote: >> Provide the `Lookup::defineHiddenClassWithClassData` API that allows live >> objects >> be shared between a hidden class and other classes. A hidden class can load >> these live objects as dynamically-computed constants via this API. >>

Re: RFR: 8227400: Adjust jib profiles to make 3rd party tools for creating installers available on Mach5 test machines

On Wed, 18 Nov 2020 21:57:13 GMT, Alexey Semenyuk wrote: > Fix test failures. They didn't fail in Mach5 test runs as WiX was not > available on test machines and these tests were not executed. Marked as reviewed by herrick (Reviewer). - PR:

Re: RFR: 8255908: ExceptionInInitializerError due to UncheckedIOException while initializing cgroupv1 subsystem

On Thu, 19 Nov 2020 01:22:01 GMT, Poonam Bajaj wrote: > Hi, > > Please review this simple change that catches UncheckedIOException that can > occur if /proc/self/cgroup or /proc/self/mountinfo files don't exist on the > system, or if there is an interrupt while these are being read. > >

RFR: 8256154: Some TestNG tests require default constructors

In TestNG 7, it is a requirement that TestNG is able to create a Test object using a default constructor. This simple fix addresses two such classes so that this requirement is satisfied by inserting default construtors. Example: `public GetPackages() { ... }`

RFR: 8256183: InputStream.skipNBytes is missing @since 12

InputStream.skipNBytes is missing `@since 12` tag which was not added during the review of [JDK-6516099](https://bugs.openjdk.java.net/browse/JDK-6516099). This small fix adds the `@since` tag to InputStream.skipNBytes - Commit messages: - 8256183: InputStream.skipNBytes is

Re: RFR: 8256183: InputStream.skipNBytes is missing @since 12

On Thu, 19 Nov 2020 12:35:04 GMT, Conor Cleary wrote: > InputStream.skipNBytes is missing `@since 12` tag which was not added during > the review of [JDK-6516099](https://bugs.openjdk.java.net/browse/JDK-6516099). > > This small fix adds the `@since` tag to InputStream.skipNBytes Marked as

Re: RFR: 8255908: ExceptionInInitializerError due to UncheckedIOException while initializing cgroupv1 subsystem

On Thu, 19 Nov 2020 14:36:27 GMT, Aleksey Shipilev wrote: >> Hi, >> >> Please review this simple change that catches UncheckedIOException that can >> occur if /proc/self/cgroup or /proc/self/mountinfo files don't exist on the >> system, or if there is an interrupt while these are being read.

Re: RFR: 8256154: Some TestNG tests require default constructors

On Thu, 19 Nov 2020 13:50:30 GMT, Conor Cleary wrote: > In TestNG 7, it is a requirement that TestNG is able to create a Test object > using a default constructor. > > This simple fix addresses two such classes so that this requirement is > satisfied by inserting default construtors.

Re: RFR: 8256183: InputStream.skipNBytes is missing @since 12

On Thu, 19 Nov 2020 12:35:04 GMT, Conor Cleary wrote: > InputStream.skipNBytes is missing `@since 12` tag which was not added during > the review of [JDK-6516099](https://bugs.openjdk.java.net/browse/JDK-6516099). > > This small fix adds the `@since` tag to InputStream.skipNBytes Marked as

Re: RFR: 8256154: Some TestNG tests require default constructors

On Thu, 19 Nov 2020 13:50:30 GMT, Conor Cleary wrote: > In TestNG 7, it is a requirement that TestNG is able to create a Test object > using a default constructor. > > This simple fix addresses two such classes so that this requirement is > satisfied by inserting default construtors.

Re: RFR: 8256480: Refactor ObjectInputStream field reader implementation

Hi Brent, Thanks for the review On 11/18/20 7:24 PM, Brent Christian wrote: Hi, Roger. The change looks good.  I just noticed a couple small things: 2324 for (int i = 0; i < slots.length-1; i++) { 2325 new FieldValues(slots[i].desc, true); The slots[i].hasData

Re: RFR: 8256487: Handle disableEagerInitialization for archived lambda proxy classes

On Thu, 19 Nov 2020 02:08:52 GMT, Calvin Cheung wrote: >> I'm not sure if this is a good idea, TBH. The disableEagerInitialization >> setting is for native-image pre-generation purposes and the less CDS cares >> about it, the better. I'd prefer it if there's no trace of the property in >>

Re: RFR: 8256581: Refactor vector conversion tests

On Thu, 19 Nov 2020 01:07:12 GMT, Paul Sandoz wrote: > Refactor the vector conversions tests to improve performance and reduce > explicit test methods (using data providers). > +463, -37,019 Impressive improvement, Paul! :-) - Marked as reviewed by vlivanov (Reviewer). PR: