On 01/06/2021 21:28, John Rose wrote:
:
Note to self and other reviewers of future versions
of the JVMS: When you see proposed language like
the “unless…” of JVMS 4.7.17, remember today's
conversation and try to avoid putting dark corners
like that into the JVMS.
The RuntimeInvisibleAnnotations
On Wed, 2 Jun 2021 00:39:25 GMT, Stuart Marks wrote:
> I'm fixing this along with a couple intertwined issues.
>
> 1. Add Map.Entry::copyOf as an idempotent copy operation.
>
> 2. Clarify that AbstractMap.SimpleImmutableEntry is itself unmodifiable (not
> really immutable) but that subclasses
On Wed, 2 Jun 2021 06:30:11 GMT, Jonathan Gibbons wrote:
>> Nikita Gubarkov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8267706: Break long line in make/ide/idea/jdk/idea.gmk
>
> The fix was supposed to be just about disentangling cy
On Wed, 2 Jun 2021 01:56:00 GMT, Xiaohong Gong wrote:
>> Currently `"VectorMask.eq()" `is not vectorized:
>>
>> public VectorMask eq(VectorMask m) {
>> // FIXME: Generate good code here.
>> return bOp(m, (i, a, b) -> a == b);
>> }
>>
>> This can be implemented by calling
On Mon, 31 May 2021 10:25:26 GMT, Xiaohong Gong wrote:
> Currently `"VectorMask.eq()" `is not vectorized:
>
> public VectorMask eq(VectorMask m) {
> // FIXME: Generate good code here.
> return bOp(m, (i, a, b) -> a == b);
> }
>
> This can be implemented by calling `"xor(
On Tue, 1 Jun 2021 09:30:40 GMT, Jaroslav Tulach
wrote:
> There doesn't seem to be much support for the complete changes in #4245. To
> get at least something useful from that endeavor I have extracted the test
> for existing behavior of `-XX:+PreserveAllAnnotations` and I am offering it
> in
On Tue, 1 Jun 2021 09:30:40 GMT, Jaroslav Tulach
wrote:
> There doesn't seem to be much support for the complete changes in #4245. To
> get at least something useful from that endeavor I have extracted the test
> for existing behavior of `-XX:+PreserveAllAnnotations` and I am offering it
> in
On Tue, 1 Jun 2021 09:30:40 GMT, Jaroslav Tulach
wrote:
> There doesn't seem to be much support for the complete changes in #4245. To
> get at least something useful from that endeavor I have extracted the test
> for existing behavior of `-XX:+PreserveAllAnnotations` and I am offering it
> in
On Mon, 26 Apr 2021 17:10:13 GMT, Maurizio Cimadamore
wrote:
> This PR contains the API and implementation changes for JEP-412 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.jav
On Wed, 2 Jun 2021 10:36:06 GMT, Peter Levart wrote:
>> There doesn't seem to be much support for the complete changes in #4245. To
>> get at least something useful from that endeavor I have extracted the test
>> for existing behavior of `-XX:+PreserveAllAnnotations` and I am offering it
>> in
On Wed, 2 Jun 2021 11:34:18 GMT, Peter Levart wrote:
>> test/jdk/java/lang/annotation/AnnotationType/AnnotationTypeChangedToRuntimeTest.java
>> line 81:
>>
>>> 79: " should not be visible at runtime");
>>> 80: }
>>> 81: }
>>
>> I'm trying to understand w
> Please review this implementation of [JEP
> 411](https://openjdk.java.net/jeps/411).
>
> The code change is divided into 3 commits. Please review them one by one.
>
> 1.
> https://github.com/openjdk/jdk/commit/576161d15423f58281e384174d28c9f9be7941a1
> The essential change for this JEP, incl
On Mon, 17 May 2021 18:23:41 GMT, Weijun Wang wrote:
> Please review this implementation of [JEP
> 411](https://openjdk.java.net/jeps/411).
>
> The code change is divided into 3 commits. Please review them one by one.
>
> 1.
> https://github.com/openjdk/jdk/commit/576161d15423f58281e384174d28
On Fri, 21 May 2021 20:37:30 GMT, Weijun Wang wrote:
>> The code change refactors classes that have a `SuppressWarnings("removal")`
>> annotation that covers more than 50KB of code. The big annotation is often
>> quite faraway from the actual deprecated API usage it is suppressing, and
>> with
On Fri, 26 Feb 2021 10:48:33 GMT, Сергей Цыпанов
wrote:
> The usage of `LinkedList` is senseless and can be replaced with either
> `ArrayList` or `ArrayDeque` which are both more compact and effective.
>
> jdk:tier1 and jdk:tier2 are both ok
This pull request has been closed without being int
On Wed, 2 Jun 2021 11:40:13 GMT, Peter Levart wrote:
>> ...hm, it seems that mere presence of any RUNTIME annotation that was
>> RUNTIME already at the use compile time somehow affects
>> -XX:+PreserveAllAnnotations option so that now RUNTIME annotations that were
>> CLASS annotations at use c
After I've renamed remove branch GitHub for some reason has closed original
https://github.com/openjdk/jdk/pull/2744, so I've decided to recreate it.
-
Commit messages:
- Merge branch 'master' into 8263561
- Merge branch 'master' into purge-linked-list
- 8263561: Use sized constru
On Tue, 1 Jun 2021 09:30:40 GMT, Jaroslav Tulach
wrote:
> There doesn't seem to be much support for the complete changes in #4245. To
> get at least something useful from that endeavor I have extracted the test
> for existing behavior of `-XX:+PreserveAllAnnotations` and I am offering it
> in
On Wed, 2 Jun 2021 12:33:37 GMT, Peter Levart wrote:
> I suggest the following patch for the bug in AnnotationParser:
>
An alternative would be to change the `ClassFileParser::assemble_annotations`
in the VM to no be so "dumb", but to construct correct concatenation.
-
PR: https:/
On 2/06/2021 10:17 pm, Peter Levart wrote:
On Wed, 2 Jun 2021 11:40:13 GMT, Peter Levart wrote:
...hm, it seems that mere presence of any RUNTIME annotation that was RUNTIME
already at the use compile time somehow affects -XX:+PreserveAllAnnotations
option so that now RUNTIME annotations tha
The motivation here is that we wanted to preserve the ability to
describe "special" indy sites with special objects. The standard
implementation can describe any indy site (bootstrap, static args,
invocation name and type), but some indy sites (e.g., lambda capture)
are "special". It would be
Never mind ...
On 2/06/2021 10:47 pm, David Holmes wrote:
On 2/06/2021 10:17 pm, Peter Levart wrote:
On Wed, 2 Jun 2021 11:40:13 GMT, Peter Levart
wrote:
...hm, it seems that mere presence of any RUNTIME annotation that
was RUNTIME already at the use compile time somehow affects
-XX:+Prese
On Thu, 27 May 2021 17:45:40 GMT, Nikita Gubarkov
wrote:
>> 8267706: bin/idea.sh tries to use cygpath on WSL
>
> Nikita Gubarkov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8267706: Break long line in make/ide/idea/jdk/idea.gmk
We do
On Thu, 22 Apr 2021 08:19:53 GMT, Nick Gasson wrote:
> macOS on Apple silicon uses slightly different ABI conventions to the
> standard AArch64 ABI. The differences are outlined in [1]. In
> particular in the standard (AAPCS) ABI, variadic arguments may be passed
> in either registers or on the
On Wed, 2 Jun 2021 00:39:25 GMT, Stuart Marks wrote:
> I'm fixing this along with a couple intertwined issues.
>
> 1. Add Map.Entry::copyOf as an idempotent copy operation.
>
> 2. Clarify that AbstractMap.SimpleImmutableEntry is itself unmodifiable (not
> really immutable) but that subclasses
On Wed, 2 Jun 2021 13:24:00 GMT, Erik Joelsson wrote:
>> Nikita Gubarkov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8267706: Break long line in make/ide/idea/jdk/idea.gmk
>
> We do not require brew to install packages on mac, the bu
JDK-8267764: jpackage cannot handle window screensaver files when EXE renamed
as SCR
-
Commit messages:
- JDK-8267764: jpackage cannot handle window screensaver files when EXE
renamed as SCR
Changes: https://git.openjdk.java.net/jdk/pull/4306/files
Webrev: https://webrevs.ope
There is a few JDK classes duplicating the contents of Long.hashCode() for hash
code calculation. They should explicitly delegate to Long.hashCode().
-
Commit messages:
- 8268113: Re-use Long.hashCode() where possible
Changes: https://git.openjdk.java.net/jdk/pull/4309/files
Webre
On Wed, 2 Jun 2021 14:10:38 GMT, Сергей Цыпанов
wrote:
> There is a few JDK classes duplicating the contents of Long.hashCode() for
> hash code calculation. They should explicitly delegate to Long.hashCode().
src/java.base/share/classes/java/util/BitSet.java line 1040:
> 1038: h ^
> Methods are added to java.lang.Process to read and write characters and lines
> from and to a spawned Process.
> The Charset used to encode and decode characters to bytes can be specified or
> use the
> operating system native encoding as is available from the "native.encoding"
> system proper
On Wed, 2 Jun 2021 05:59:05 GMT, David Holmes wrote:
> Sorry Jaroslav but I don't really see this test as a basic functional
> test of the PreserveAllAnnotations flag. There is no need for any
> dynamic retention mode switch. All you need as I've said previously is a
> class with all the CLASS re
On Tue, 1 Jun 2021 09:30:40 GMT, Jaroslav Tulach
wrote:
> There doesn't seem to be much support for the complete changes in #4245. To
> get at least something useful from that endeavor I have extracted the test
> for existing behavior of `-XX:+PreserveAllAnnotations` and I am offering it
> in
On Wed, 2 Jun 2021 14:10:38 GMT, Сергей Цыпанов
wrote:
> There is a few JDK classes duplicating the contents of Long.hashCode() for
> hash code calculation. They should explicitly delegate to Long.hashCode().
src/java.base/share/classes/java/lang/Double.java line 881:
> 879: public static
> Methods are added to java.lang.Process to read and write characters and lines
> from and to a spawned Process.
> The Charset used to encode and decode characters to bytes can be specified or
> use the
> operating system native encoding as is available from the "native.encoding"
> system proper
Hi,
Could someone please review my code for updating the code in the `java.lang`
packages to make use of the switch expressions?
Kind regards,
Patrick
-
Commit messages:
- 8268124: Update java.lang to use switch expressions
Changes: https://git.openjdk.java.net/jdk/pull/4312/file
> The code change refactors classes that have a `SuppressWarnings("removal")`
> annotation that covers more than 50KB of code. The big annotation is often
> quite faraway from the actual deprecated API usage it is suppressing, and
> with the annotation covering too big a portion it's easy to cal
On Wed, 2 Jun 2021 13:24:10 GMT, David Holmes wrote:
> Sorry now I see what happens. We aren't combining two arrays of
> annotations we're concatenating two streams of byes, each of which
> represents a set of annotations, starting with the length.
>
> The code that receives this on the JDK side
On Wed, 2 Jun 2021 15:00:56 GMT, Roger Riggs wrote:
>> Methods are added to java.lang.Process to read and write characters and
>> lines from and to a spawned Process.
>> The Charset used to encode and decode characters to bytes can be specified
>> or use the
>> operating system native encoding
On Fri, 21 May 2021 01:52:27 GMT, Weijun Wang wrote:
> The code change refactors classes that have a `SuppressWarnings("removal")`
> annotation that covers more than 50KB of code. The big annotation is often
> quite faraway from the actual deprecated API usage it is suppressing, and
> with the
Please find below a fix that will make
`java/net/DatagramSocket/DatagramSocketMulticasting.java` more resilient to the
rare case where addresses bound to a network interfaces are updated while the
test is running.
Instead of using `NetworkInterface::equals` to compare network interfaces, the
t
On Wed, 2 Jun 2021 15:25:16 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the `java.lang`
> packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
src/java.base/share/classes/java/lang/invoke/InvokerBytecodeGenerator
On Wed, 2 Jun 2021 15:25:16 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the `java.lang`
> packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
src/java.base/share/classes/java/lang/invoke/MemberName.java line 331
On Thu, 27 May 2021 17:45:40 GMT, Nikita Gubarkov
wrote:
>> 8267706: bin/idea.sh tries to use cygpath on WSL
>
> Nikita Gubarkov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8267706: Break long line in make/ide/idea/jdk/idea.gmk
We req
On Wed, 2 Jun 2021 15:25:16 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the `java.lang`
> packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
src/java.base/share/classes/java/lang/invoke/MethodHandleProxies.java
On Wed, 2 Jun 2021 15:25:16 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the `java.lang`
> packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
src/java.base/share/classes/java/lang/runtime/ObjectMethods.java line
Please review the change to update to using jtreg 6.
The primary change is to the jib-profiles.js file, which specifies the version
of jtreg to use, for those systems that rely on this file. In addition, the
`requiredVersion` has been updated in the various `TEST.ROOT` files.
All the tests tha
On Wed, 2 Jun 2021 14:51:35 GMT, liach
wrote:
>> Сергей Цыпанов has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8268113: Delegate to Double.hashCode()
>
> src/java.desktop/macosx/classes/apple/laf/JRSUIConstants.java line 115:
>
>> 113
> There is a few JDK classes duplicating the contents of Long.hashCode() for
> hash code calculation. They should explicitly delegate to Long.hashCode().
Сергей Цыпанов has updated the pull request incrementally with one additional
commit since the last revision:
8268113: Delegate to Double.h
On Wed, 2 Jun 2021 16:13:48 GMT, Jonathan Gibbons wrote:
> Please review the change to update to using jtreg 6.
>
> The primary change is to the jib-profiles.js file, which specifies the
> version of jtreg to use, for those systems that rely on this file. In
> addition, the `requiredVersion`
On Thu, 27 May 2021 20:33:50 GMT, Brian Burkhalter wrote:
> Modify the specification of `java.io.File.equals` to clarify that equality is
> based only on a comparison of abstract pathnames as opposed to the file
> system objects that the `File`s represent.
This pull request has now been integr
On Wed, 2 Jun 2021 14:50:23 GMT, liach
wrote:
>> Сергей Цыпанов has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8268113: Inline local vars where reasonable
>
> src/java.base/share/classes/java/lang/Double.java line 881:
>
>> 879: p
> There is a few JDK classes duplicating the contents of Long.hashCode() for
> hash code calculation. They should explicitly delegate to Long.hashCode().
Сергей Цыпанов has updated the pull request incrementally with one additional
commit since the last revision:
8268113: Inline local vars wh
On Wed, 2 Jun 2021 15:00:56 GMT, Roger Riggs wrote:
>> Methods are added to java.lang.Process to read and write characters and
>> lines from and to a spawned Process.
>> The Charset used to encode and decode characters to bytes can be specified
>> or use the
>> operating system native encoding
On Wed, 2 Jun 2021 16:13:48 GMT, Jonathan Gibbons wrote:
> Please review the change to update to using jtreg 6.
>
> The primary change is to the jib-profiles.js file, which specifies the
> version of jtreg to use, for those systems that rely on this file. In
> addition, the `requiredVersion`
If the reflection runtime doesn't implement the semantics of
-XX+PreserveAllAnnotations, I suggest deprecating/obsoleting/etc. that
option now.
-Joe
On 6/2/2021 7:48 AM, Peter Levart wrote:
On Tue, 1 Jun 2021 09:30:40 GMT, Jaroslav Tulach
wrote:
There doesn't seem to be much support for t
On Wed, 2 Jun 2021 16:13:48 GMT, Jonathan Gibbons wrote:
> Please review the change to update to using jtreg 6.
>
> The primary change is to the jib-profiles.js file, which specifies the
> version of jtreg to use, for those systems that rely on this file. In
> addition, the `requiredVersion`
On Wed, 2 Jun 2021 15:25:16 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the `java.lang`
> packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
Hi Patrick, some minor comments.
src/java.base/share/classes/java/la
On Wed, 2 Jun 2021 13:48:47 GMT, Andy Herrick wrote:
> JDK-8267764: jpackage cannot handle window screensaver files when EXE renamed
> as SCR
Marked as reviewed by asemenyuk (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/4306
On Wed, 2 Jun 2021 16:13:48 GMT, Jonathan Gibbons wrote:
> Please review the change to update to using jtreg 6.
>
> The primary change is to the jib-profiles.js file, which specifies the
> version of jtreg to use, for those systems that rely on this file. In
> addition, the `requiredVersion`
On Wed, 2 Jun 2021 15:25:16 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the `java.lang`
> packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
Changes to Math and Long look fine.
-
Marked as reviewe
On Wed, 2 Jun 2021 16:13:48 GMT, Jonathan Gibbons wrote:
> Please review the change to update to using jtreg 6.
>
> The primary change is to the jib-profiles.js file, which specifies the
> version of jtreg to use, for those systems that rely on this file. In
> addition, the `requiredVersion`
On Wed, 2 Jun 2021 07:35:25 GMT, Rémi Forax wrote:
> i wonder if we should not declare SimpleImmutableEntry final, while it's not
> a backward compatible change,
> it's may be better on the long term because SimpleImmutableEntry is already
> used as an immutable type,
> so instead of documentin
> This PR contains Short Vector Math Library support related changes for
> [JEP-414 Vector API (Second Incubator)](https://openjdk.java.net/jeps/414),
> in preparation for when targeted.
>
> Intel Short Vector Math Library (SVML) based intrinsics in native x86
> assembly provide optimized imple
On Wed, 2 Jun 2021 17:12:21 GMT, Stuart Marks wrote:
> A quick search reveals that Guava has a public subclass of
> SimpleImmutableEntry:
> https://guava.dev/releases/30.1.1-jre/api/docs/com/google/common/cache/RemovalNotification.html
>There are possibly others. It doesn't seem worth the incom
This patch overhauls the library loading mechanism used by the Foreign Linker
API. We realized that, while handy, the *default* lookup abstraction
(`LibraryLookup::ofDefault`) was behaving inconsistentlt across platforms.
This patch replaces `LibraryLookup` with a simpler `SymbolLookup` abstract
On Fri, 28 May 2021 02:14:45 GMT, Igor Ignatyev wrote:
>> Leonid Mesnik has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> spaces updated.
>
> test/failure_handler/src/share/classes/jdk/test/failurehandler/action/PatternAction.java
> line
On Wed, 2 Jun 2021 17:19:06 GMT, Maurizio Cimadamore
wrote:
> This patch overhauls the library loading mechanism used by the Foreign Linker
> API. We realized that, while handy, the *default* lookup abstraction
> (`LibraryLookup::ofDefault`) was behaving inconsistentlt across platforms.
>
> T
On Thu, 27 May 2021 17:45:40 GMT, Nikita Gubarkov
wrote:
>> 8267706: bin/idea.sh tries to use cygpath on WSL
>
> Nikita Gubarkov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8267706: Break long line in make/ide/idea/jdk/idea.gmk
I file
> I'm fixing this along with a couple intertwined issues.
>
> 1. Add Map.Entry::copyOf as an idempotent copy operation.
>
> 2. Clarify that AbstractMap.SimpleImmutableEntry is itself unmodifiable (not
> really immutable) but that subclasses can be modifiable.
>
> 3. Clarify some confusing, hist
On Wed, 2 Jun 2021 16:13:48 GMT, Jonathan Gibbons wrote:
> Please review the change to update to using jtreg 6.
>
> The primary change is to the jib-profiles.js file, which specifies the
> version of jtreg to use, for those systems that rely on this file. In
> addition, the `requiredVersion`
> This PR contains API and implementation changes for [JEP-414 Vector API
> (Second Incubator)](https://openjdk.java.net/jeps/414), in preparation for
> when targeted.
>
> Enhancements are made to the API for the support of operations on characters,
> such as for UTF-8 character decoding. Speci
On Wed, 2 Jun 2021 16:37:49 GMT, Сергей Цыпанов
wrote:
>> There is a few JDK classes duplicating the contents of Long.hashCode() for
>> hash code calculation. They should explicitly delegate to Long.hashCode().
>
> Сергей Цыпанов has updated the pull request incrementally with one additional
>
On Wed, 2 Jun 2021 17:54:06 GMT, Stuart Marks wrote:
>> I'm fixing this along with a couple intertwined issues.
>>
>> 1. Add Map.Entry::copyOf as an idempotent copy operation.
>>
>> 2. Clarify that AbstractMap.SimpleImmutableEntry is itself unmodifiable (not
>> really immutable) but that subcl
On Wed, 2 Jun 2021 16:13:48 GMT, Jonathan Gibbons wrote:
> Please review the change to update to using jtreg 6.
>
> The primary change is to the jib-profiles.js file, which specifies the
> version of jtreg to use, for those systems that rely on this file. In
> addition, the `requiredVersion`
Special characters are different in File and URI. Treat File input as File
using FileInputStream instead of converting to an URI, but fall back to URI in
case of error for compatibility (in error handling).
-
Commit messages:
- 8266019: StreamResult(File) writes to incorrect file p
On Wed, 2 Jun 2021 17:19:06 GMT, Maurizio Cimadamore
wrote:
> This patch overhauls the library loading mechanism used by the Foreign Linker
> API. We realized that, while handy, the *default* lookup abstraction
> (`LibraryLookup::ofDefault`) was behaving inconsistentlt across platforms.
>
> T
On Wed, 2 Jun 2021 17:58:29 GMT, Vyom Tewari wrote:
>> Сергей Цыпанов has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8268113: Inline local vars where reasonable
>
> src/java.base/share/classes/java/util/BitSet.java line 105:
>
>> 103:
On Wed, 2 Jun 2021 18:17:43 GMT, Joe Wang wrote:
> Special characters are different in File and URI. Treat File input as File
> using FileInputStream instead of converting to an URI, but fall back to URI
> in case of error for compatibility (in error handling).
I believe this is the wrong fix
On Wed, 2 Jun 2021 18:17:43 GMT, Joe Wang wrote:
> Special characters are different in File and URI. Treat File input as File
> using FileInputStream instead of converting to an URI, but fall back to URI
> in case of error for compatibility (in error handling).
I tried, but getRawPath returned
> Please review the change to update to using jtreg 6.
>
> The primary change is to the jib-profiles.js file, which specifies the
> version of jtreg to use, for those systems that rely on this file. In
> addition, the `requiredVersion` has been updated in the various `TEST.ROOT`
> files.
>
>
> This patch overhauls the library loading mechanism used by the Foreign Linker
> API. We realized that, while handy, the *default* lookup abstraction
> (`LibraryLookup::ofDefault`) was behaving inconsistentlt across platforms.
>
> This patch replaces `LibraryLookup` with a simpler `SymbolLookup
On Wed, 2 Jun 2021 17:19:06 GMT, Maurizio Cimadamore
wrote:
> This patch overhauls the library loading mechanism used by the Foreign Linker
> API. We realized that, while handy, the *default* lookup abstraction
> (`LibraryLookup::ofDefault`) was behaving inconsistentlt across platforms.
>
> T
On Wed, 2 Jun 2021 18:17:43 GMT, Joe Wang wrote:
> Special characters are different in File and URI. Treat File input as File
> using FileInputStream instead of converting to an URI, but fall back to URI
> in case of error for compatibility (in error handling).
Argh! You're right. It's this li
On Wed, 2 Jun 2021 20:15:55 GMT, Jonathan Gibbons wrote:
>> Please review the change to update to using jtreg 6.
>>
>> The primary change is to the jib-profiles.js file, which specifies the
>> version of jtreg to use, for those systems that rely on this file. In
>> addition, the `requiredVers
On Wed, 2 Jun 2021 18:17:43 GMT, Joe Wang wrote:
> Special characters are different in File and URI. Treat File input as File
> using FileInputStream instead of converting to an URI, but fall back to URI
> in case of error for compatibility (in error handling).
I now agree that what you propos
On Wed, 2 Jun 2021 20:17:20 GMT, Maurizio Cimadamore
wrote:
>> This patch overhauls the library loading mechanism used by the Foreign
>> Linker API. We realized that, while handy, the *default* lookup abstraction
>> (`LibraryLookup::ofDefault`) was behaving inconsistentlt across platforms.
>>
On Wed, 2 Jun 2021 18:17:43 GMT, Joe Wang wrote:
> Special characters are different in File and URI. Treat File input as File
> using FileInputStream instead of converting to an URI, but fall back to URI
> in case of error for compatibility (in error handling).
Thanks Daniel!
For the questi
On Wed, 2 Jun 2021 18:40:48 GMT, Paul Sandoz wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with 10
>> additional commits since the last revision:
>>
>> - Update test/jdk/java/foreign/TestIntrinsics.java
>>
>>Co-authored-by: Paul Sandoz
>> - Update test/jdk/
> This patch overhauls the library loading mechanism used by the Foreign Linker
> API. We realized that, while handy, the *default* lookup abstraction
> (`LibraryLookup::ofDefault`) was behaving inconsistentlt across platforms.
>
> This patch replaces `LibraryLookup` with a simpler `SymbolLookup
> This patch overhauls the library loading mechanism used by the Foreign Linker
> API. We realized that, while handy, the *default* lookup abstraction
> (`LibraryLookup::ofDefault`) was behaving inconsistentlt across platforms.
>
> This patch replaces `LibraryLookup` with a simpler `SymbolLookup
On Wed, 2 Jun 2021 16:56:07 GMT, Joe Darcy wrote:
> If the reflection runtime doesn't implement the semantics of
> -XX+PreserveAllAnnotations, I suggest deprecating/obsoleting/etc. that
> option now.
>
> -Joe
What is the -XX+PreserveAllAnnotations semantics in terms of reflection? The VM
spec
On Wed, 2 Jun 2021 16:13:48 GMT, Jonathan Gibbons wrote:
> Please review the change to update to using jtreg 6.
>
> The primary change is to the jib-profiles.js file, which specifies the
> version of jtreg to use, for those systems that rely on this file. In
> addition, the `requiredVersion`
This patch increases time out for both TestUpcall and TestDowncall. These tests
were already long-running, but with JEP-412, they were beefed up even more, so
now they time out on some debug builds.
This patch also address a minor issue in TestResourceScope which can sometimes
lead to intermitt
Can the test cases be broken into pieces or otherwise decomposed into
several shorter-running tests?
-Joe
On 6/2/2021 2:35 PM, Maurizio Cimadamore wrote:
This patch increases time out for both TestUpcall and TestDowncall. These tests
were already long-running, but with JEP-412, they were beef
A trivial copyright fix.
-
Commit messages:
- 8268146: fix for JDK-8266254 fails validate-source
Changes: https://git.openjdk.java.net/jdk/pull/4323/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4323&range=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8268146
On Wed, 2 Jun 2021 21:39:15 GMT, Daniel D. Daugherty wrote:
> A trivial copyright fix.
Marked as reviewed by psandoz (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/4323
On Wed, 2 Jun 2021 21:40:59 GMT, Paul Sandoz wrote:
>> A trivial copyright fix.
>
> Marked as reviewed by psandoz (Reviewer).
@PaulSandoz - Thanks for the fast review!
-
PR: https://git.openjdk.java.net/jdk/pull/4323
On Wed, 2 Jun 2021 21:39:15 GMT, Daniel D. Daugherty wrote:
> A trivial copyright fix.
LGTM
-
Marked as reviewed by wetmore (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/4323
On Wed, 2 Jun 2021 21:39:15 GMT, Daniel D. Daugherty wrote:
> A trivial copyright fix.
This pull request has now been integrated.
Changeset: 76fdf2c8
Author:Daniel D. Daugherty
URL:
https://git.openjdk.java.net/jdk/commit/76fdf2c89bb7df9140438fcbaf16ea5fda024551
Stats: 1 line in
On Wed, 2 Jun 2021 21:50:24 GMT, Bradford Wetmore wrote:
>> A trivial copyright fix.
>
> LGTM
@bradfordwetmore - Thanks for the review.
-
PR: https://git.openjdk.java.net/jdk/pull/4323
1 - 100 of 138 matches
Mail list logo
