On 17/06/2021 8:50 pm, Alan Bateman wrote:
On Thu, 17 Jun 2021 05:16:14 GMT, David Holmes wrote:
There are a lot more tests than just tier1. :) I don't expect many, if any,
tests to be looking for a specific IOOBE message, and I can't see an easy way
to find such tests without running them.
Hello, please review this PR; it extend the OSContainer API in order to also
support the pids controller of cgroups.
I noticed that unlike the other controllers "cpu", "cpuset", "cpuacct",
"memory" on some older Linux distros (SLES 12.1, RHEL 7.1) the pids controller
might not be there (or
> Upstream a critical fix from the panama-foreign repo.
>
> See the prior review thread here:
> https://github.com/openjdk/panama-foreign/pull/558
>
> Testing: tier 1-2, local run of run-test-jdk_foreign.
Jorn Vernee has updated the pull request incrementally with two additional
commits since
On Thu, 17 Jun 2021 12:30:46 GMT, David Holmes wrote:
> Now that you have explained it I think a much simpler comment will suffice :)
Ok, I've shortened the comment. Thanks :)
-
PR: https://git.openjdk.java.net/jdk17/pull/76
On Thu, 17 Jun 2021 12:50:10 GMT, Jorn Vernee wrote:
>> Upstream a critical fix from the panama-foreign repo.
>>
>> See the prior review thread here:
>> https://github.com/openjdk/panama-foreign/pull/558
>>
>> Testing: tier 1-2, local run of run-test-jdk_foreign.
>
> Jorn Vernee has updated
On Mon, 14 Jun 2021 16:06:04 GMT, Paul Sandoz wrote:
> Test that when the jdk.incubator.vector module is present that libsvml.so is
> present, and test the opposite case.
This pull request has now been integrated.
Changeset: 091bc4a1
Author:Paul Sandoz
URL:
On Tue, 8 Jun 2021 19:26:14 GMT, Brian Burkhalter wrote:
>> This PR-*draft* is **work in progress** and an invitation to discuss a
>> possible solution for issue
>> [JDK-8265891](https://bugs.openjdk.java.net/browse/JDK-8265891). It is *not
>> yet* intended for a final review.
>>
>> As
On Tue, 8 Jun 2021 20:34:15 GMT, Brian Burkhalter wrote:
>> I'd like to abstain from changes in ChannelOutputStream, as I did not write
>> that code at all. It is simply moved from being an inner class. Please let's
>> concentrate on the code I actually wrote in this PR. Thanks.
>
> That's
On Wed, 16 Jun 2021 07:51:32 GMT, Aleksei Voitylov
wrote:
>> Please review this PR which fixes the deadlock in ClassLoader between the
>> two lock objects - a lock object associated with the class being loaded, and
>> the ClassLoader.loadedLibraryNames hash map, locked during the native
>>
On Thu, 17 Jun 2021 22:03:46 GMT, Joe Wang wrote:
>> The issue was that the attribute was processed before the variable was set
>> (e.g. m_preserveSpaces.push). Reversing the order fixed it.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last
A trivial fix to ProblemList tools/jpackage/windows/WinInstallerIconTest.java
on win-x64.
-
Commit messages:
- 8268971: ProblemList tools/jpackage/windows/WinInstallerIconTest.java on
win-x64
Changes: https://git.openjdk.java.net/jdk17/pull/90/files
Webrev:
Filed this:
https://bugs.openjdk.java.net/browse/JDK-8268974
Maurizio
On 17/06/2021 18:52, Alexey Semenyuk wrote:
Seems like a new issue. Please file a bug in Jira.
- Alexey
On 6/16/2021 5:14 PM, Maurizio Cimadamore wrote:
Also, if --dest is removed, or if it is set to something which
On Thu, 17 Jun 2021 18:12:19 GMT, Aleksei Voitylov
wrote:
>> test/jdk/java/lang/ClassLoader/loadLibraryDeadlock/TestLoadLibraryDeadlock.java
>> line 95:
>>
>>> 93: Collections.addAll(args, "cvf", Paths.get(testClassPath,
>>> outputJar).toString());
>>> 94: for (String c :
On Thu, 17 Jun 2021 18:15:52 GMT, Aleksei Voitylov
wrote:
> Thanks Mandy for the thorough review, I'll definitely do that. Shall we wait
> for Alan opinion as well?
I think you can proceed posting a PR for jdk17 as the new version has addressed
Alan's concern of using ThreadLocal. Alan can
On Tue, 8 Jun 2021 11:49:55 GMT, Alan Bateman wrote:
>> @AlanBateman I'm done with the changes you requested and kindly like to ask
>> where to go from here.
>
>> @AlanBateman I'm done with the changes you requested and kindly like to ask
>> where to go from here.
>
> Moving
On Wed, 2 Jun 2021 09:03:03 GMT, Alan Bateman wrote:
>> This PR-*draft* is **work in progress** and an invitation to discuss a
>> possible solution for issue
>> [JDK-8265891](https://bugs.openjdk.java.net/browse/JDK-8265891). It is *not
>> yet* intended for a final review.
>>
>> As proposed
On Sun, 30 May 2021 17:30:56 GMT, Markus KARG
wrote:
> This PR-*draft* is **work in progress** and an invitation to discuss a
> possible solution for issue
> [JDK-8265891](https://bugs.openjdk.java.net/browse/JDK-8265891). It is *not
> yet* intended for a final review.
>
> As proposed in
On Thu, 17 Jun 2021 15:09:17 GMT, Paul Sandoz wrote:
>> Refactor scatter/gather tests to be included in the load/store test classes
>> and expand to support access between `ShortVector` and and `char[]`, and
>> access between `ByteVector` and `boolean[]`.
>>
>> Vector tests pass on linux-x64
On Thu, 17 Jun 2021 18:33:56 GMT, Jan Lahoda wrote:
>> Currently, an enum switch with patterns is desugared in a very non-standard,
>> and potentially slow, way. It would be better to use the standard
>> `typeSwitch` bootstrap to classify the enum constants. The bootstrap needs
>> to accept
> The issue was that the attribute was processed before the variable was set
> (e.g. m_preserveSpaces.push). Reversing the order fixed it.
Joe Wang has updated the pull request incrementally with one additional commit
since the last revision:
Thanks Naoto. Updated accordingly.
-
On Thu, 17 Jun 2021 22:03:46 GMT, Joe Wang wrote:
>> The issue was that the attribute was processed before the variable was set
>> (e.g. m_preserveSpaces.push). Reversing the order fixed it.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last
On Thu, 17 Jun 2021 22:03:46 GMT, Joe Wang wrote:
>> The issue was that the attribute was processed before the variable was set
>> (e.g. m_preserveSpaces.push). Reversing the order fixed it.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last
On Thu, 17 Jun 2021 16:32:52 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList tools/jpackage/windows/WinInstallerIconTest.java
> on win-x64.
This pull request has now been integrated.
Changeset: b66001a5
Author:Daniel D. Daugherty
URL:
On Thu, 17 Jun 2021 16:32:52 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList tools/jpackage/windows/WinInstallerIconTest.java
> on win-x64.
Marked as reviewed by herrick (Reviewer).
-
PR: https://git.openjdk.java.net/jdk17/pull/90
On Thu, 17 Jun 2021 16:49:49 GMT, Andy Herrick wrote:
>> A trivial fix to ProblemList
>> tools/jpackage/windows/WinInstallerIconTest.java on win-x64.
>
> Marked as reviewed by herrick (Reviewer).
@andyherrick - Thanks for the fast review!
-
PR:
On Sun, 30 May 2021 17:30:56 GMT, Markus KARG
wrote:
> This PR-*draft* is **work in progress** and an invitation to discuss a
> possible solution for issue
> [JDK-8265891](https://bugs.openjdk.java.net/browse/JDK-8265891). It is *not
> yet* intended for a final review.
>
> As proposed in
On Sat, 5 Jun 2021 15:11:55 GMT, Markus KARG
wrote:
> @AlanBateman I'm done with the changes you requested and kindly like to ask
> where to go from here.
Moving ChannelOutputStream to sun.nio.ch looks right. The implementation of
transferTo will need a few rounds of cleanup, it's a look
This PR-*draft* is **work in progress** and an invitation to discuss a possible
solution for issue
[JDK-8265891](https://bugs.openjdk.java.net/browse/JDK-8265891). It is *not
yet* intended for a final review.
As proposed in JDK-8265891, this PR provides an implementation for
On Sun, 30 May 2021 17:30:56 GMT, Markus KARG
wrote:
> This PR-*draft* is **work in progress** and an invitation to discuss a
> possible solution for issue
> [JDK-8265891](https://bugs.openjdk.java.net/browse/JDK-8265891). It is *not
> yet* intended for a final review.
>
> As proposed in
On Wed, 16 Jun 2021 07:51:32 GMT, Aleksei Voitylov
wrote:
>> Please review this PR which fixes the deadlock in ClassLoader between the
>> two lock objects - a lock object associated with the class being loaded, and
>> the ClassLoader.loadedLibraryNames hash map, locked during the native
>>
On Thu, 17 Jun 2021 16:13:49 GMT, Joe Wang wrote:
> The issue was that the attribute was processed before the variable was set
> (e.g. m_preserveSpaces.push). Reversing the order fixed it.
Looks good overall. Some minor comments in the test.
On Thu, 3 Jun 2021 17:29:14 GMT, Markus KARG
wrote:
>> src/java.base/share/classes/java/nio/channels/Channels.java line 145:
>>
>>> 143: * @since 18
>>> 144: */
>>> 145: public static class ChannelOutputStream extends OutputStream {
>>
>> This adds Channels.ChannelOutputStream
On Sat, 5 Jun 2021 07:25:44 GMT, Markus KARG
wrote:
>> You mean as a source comment or just here in this discussion thread?
>>
>> In fact it might be better to not add it to a package with is part of the
>> API, but to move it to the `sun` package, which is not, right?
>>
>> The
On Tue, 8 Jun 2021 20:20:58 GMT, Markus KARG
wrote:
>> src/java.base/share/classes/sun/nio/ch/ChannelOutputStream.java line 113:
>>
>>> 111: if ((off < 0) || (off > bs.length) || (len < 0) ||
>>> 112: ((off + len) > bs.length) || ((off + len) < 0)) {
>>> 113:
On Wed, 16 Jun 2021 15:59:44 GMT, Mandy Chung wrote:
>> Aleksei Voitylov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> address review comments
>
> test/jdk/java/lang/ClassLoader/loadLibraryDeadlock/TestLoadLibraryDeadlock.java
> line
> Currently, an enum switch with patterns is desugared in a very non-standard,
> and potentially slow, way. It would be better to use the standard
> `typeSwitch` bootstrap to classify the enum constants. The bootstrap needs to
> accept enum constants as labels in order to allow this. A
On Thu, 17 Jun 2021 18:33:56 GMT, Jan Lahoda wrote:
>> Currently, an enum switch with patterns is desugared in a very non-standard,
>> and potentially slow, way. It would be better to use the standard
>> `typeSwitch` bootstrap to classify the enum constants. The bootstrap needs
>> to accept
Thanks. I'll look into it.
- Alexey
On 6/17/2021 2:01 PM, Maurizio Cimadamore wrote:
Filed this:
https://bugs.openjdk.java.net/browse/JDK-8268974
Maurizio
On 17/06/2021 18:52, Alexey Semenyuk wrote:
Seems like a new issue. Please file a bug in Jira.
- Alexey
On 6/16/2021 5:14 PM,
Seems like a new issue. Please file a bug in Jira.
- Alexey
On 6/16/2021 5:14 PM, Maurizio Cimadamore wrote:
Also, if --dest is removed, or if it is set to something which doesn't
contain the "bin" subfolder, everything works... that seems different
from the issue you linked?
Maurizio
On
On Sun, 30 May 2021 17:30:56 GMT, Markus KARG
wrote:
> This PR-*draft* is **work in progress** and an invitation to discuss a
> possible solution for issue
> [JDK-8265891](https://bugs.openjdk.java.net/browse/JDK-8265891). It is *not
> yet* intended for a final review.
>
> As proposed in
Hi Jorn,
On 17/06/2021 9:28 pm, Jorn Vernee wrote:
On Thu, 17 Jun 2021 00:23:19 GMT, David Holmes wrote:
Jorn Vernee has updated the pull request incrementally with one additional
commit since the last revision:
Add comment about optimized entry frames only being generated on x86_64
On Wed, 16 Jun 2021 10:57:07 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my code for updating the code in the `java.time`
>> packages to make use of the switch expressions?
>>
>> Kind regards,
>> Patrick
>
> Patrick Concannon has updated the pull request with a new
On Wed, 16 Jun 2021 16:43:20 GMT, Stephen Colebourne
wrote:
>> The vertical alignment improves readability in these short-line cases.
>> Removing the spaces before the arrows will make it a little harder to
>> discern the difference between the cases.
>
> It is your codebase, not mine, so it
On Thu, 17 Jun 2021 10:21:35 GMT, Alan Bateman wrote:
>> After JDK-8265518(#3615), it's possible to replace all variants of
>> checkIndex by
>> Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in
>> the whole JDK codebase.
>
>
The issue was that the attribute was processed before the variable was set
(e.g. m_preserveSpaces.push). Reversing the order fixed it.
-
Commit messages:
- 8265073: XML transformation and indentation when using xml:space
Changes: https://git.openjdk.java.net/jdk17/pull/89/files
On Thu, 17 Jun 2021 12:27:25 GMT, Matthias Baesken wrote:
> Hello, please review this PR; it extend the OSContainer API in order to also
> support the pids controller of cgroups.
>
> I noticed that unlike the other controllers "cpu", "cpuset", "cpuacct",
> "memory" on some older Linux
On Thu, 17 Jun 2021 11:28:54 GMT, Jorn Vernee wrote:
>> Upstream a critical fix from the panama-foreign repo.
>>
>> See the prior review thread here:
>> https://github.com/openjdk/panama-foreign/pull/558
>>
>> Testing: tier 1-2, local run of run-test-jdk_foreign.
>
> Jorn Vernee has updated
On Wed, 16 Jun 2021 20:42:56 GMT, Sandhya Viswanathan
wrote:
>> Paul Sandoz has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove redundatem data providers.
>
> test/jdk/jdk/incubator/vector/Byte128VectorLoadStoreTests.java line 1248:
On Thu, 17 Jun 2021 05:16:14 GMT, David Holmes wrote:
> There are a lot more tests than just tier1. :) I don't expect many, if any,
> tests to be looking for a specific IOOBE message, and I can't see an easy way
> to find such tests without running them. If core-libs folk are okay with this
>
> Upstream a critical fix from the panama-foreign repo.
>
> See the prior review thread here:
> https://github.com/openjdk/panama-foreign/pull/558
>
> Testing: tier 1-2, local run of run-test-jdk_foreign.
Jorn Vernee has updated the pull request incrementally with one additional
commit since
On Thu, 17 Jun 2021 00:23:19 GMT, David Holmes wrote:
>> Jorn Vernee has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add comment about optimized entry frames only being generated on x86_64
>
> src/hotspot/share/runtime/frame.inline.hpp
On Thu, 17 Jun 2021 13:56:00 GMT, Daniel Fuchs wrote:
>> It is your codebase, not mine, so it is up to you. Aligning things by column
>> is generally frowned on in most style guides because it handles refactoring
>> poorly, resulting in lots of needless change (or people forgetting to
>>
> Refactor scatter/gather tests to be included in the load/store test classes
> and expand to support access between `ShortVector` and and `char[]`, and
> access between `ByteVector` and `boolean[]`.
>
> Vector tests pass on linux-x64 linux-aarch64 macosx-x64, and windows-x64.
Paul Sandoz has
On 16/06/2021 11:18 pm, David Lloyd wrote:
On Mon, Jun 14, 2021 at 6:47 PM Peter Firmstone
wrote:
Permission references can be replaced with Guard references (which
Permissions are instances of).
I guess you've got something fairly complex in mind, could you give
some practical examples of
Forwardport JDK 17 -> JDK 18
-
Commit messages:
- Merge
- 8268371: C2: assert(_gvn.type(obj)->higher_equal(tjp)) failed: cast_up is no
longer needed
- 8268676: assert(!ik->is_interface() && !ik->has_subklass()) failed:
inconsistent klass hierarchy
- 8268265:
On Thu, 17 Jun 2021 22:03:46 GMT, Joe Wang wrote:
>> The issue was that the attribute was processed before the variable was set
>> (e.g. m_preserveSpaces.push). Reversing the order fixed it.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last
> Hi all,
>
> Could you please review the 8268457 bug fixes?
>
> The problem is that ToHTMLStream applies processing for non-surrogate pairs
> to the surrogate pair.
> This fix changes the processing for non-surrogate pairs to the else condition.
Masanori Yano has updated the pull request
On Thu, 17 Jun 2021 22:03:46 GMT, Joe Wang wrote:
>> The issue was that the attribute was processed before the variable was set
>> (e.g. m_preserveSpaces.push). Reversing the order fixed it.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last
On Thu, 17 Jun 2021 10:19:43 GMT, Alan Bateman wrote:
>> Yi Yang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> restore IndexOfOufBoundsException; split exception line
>
>
> After JDK-8265518(#3615), it's possible to replace all variants of checkIndex
> by Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in
> the whole JDK codebase.
Yi Yang has updated the pull request incrementally with one additional commit
since the last revision:
On Thu, 17 Jun 2021 23:26:26 GMT, Jesper Wilhelmsson
wrote:
> Forwardport JDK 17 -> JDK 18
This pull request has now been integrated.
Changeset: a051e735
Author:Jesper Wilhelmsson
URL:
https://git.openjdk.java.net/jdk/commit/a051e735cda0d5ee5cb6ce0738aa549a7319a28c
Stats: 845
On Fri, 11 Jun 2021 12:42:35 GMT, Masanori Yano wrote:
> Hi all,
>
> Could you please review the 8268457 bug fixes?
>
> The problem is that ToHTMLStream applies processing for non-surrogate pairs
> to the surrogate pair.
> This fix changes the processing for non-surrogate pairs to the else
On Mon, 19 Apr 2021 20:43:26 GMT, Ian Graves wrote:
> Clarifying note on comments mode to explicitly note that whitespace within
> character classes is ignored.
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.java.net/jdk/pull/3577
On Thu, 26 Nov 2020 18:51:10 GMT, Richard Fussenegger
wrote:
> 6594730: UUID.getVersion() is only meaningful for Leach-Salz variant
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.java.net/jdk/pull/1467
On Thu, 26 Nov 2020 18:24:22 GMT, Richard Fussenegger
wrote:
> Made byte constructor public and changed the length assertion to an
> `IllegalArgumentException`, added a `getBytes` method that allows users to
> retrieve the raw bytes of the UUID, and created a new private constructor
> with
On Wed, 16 Jun 2021 08:08:47 GMT, Yi Yang wrote:
> After JDK-8265518(#3615), it's possible to replace all variants of checkIndex
> by Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in
> the whole JDK codebase.
I looked through the changes in java.base and only spotted
On Wed, 16 Jun 2021 20:22:17 GMT, Roger Riggs wrote:
> Remove the unnecessary special case "OVERRIDE" in jdk.serialFilterFactory
> property.
> Fix description in the example of a filter allowing platform classes.
> Suppress some warnings about use of SecurityManager in tests.
Looks reasonable
On Wed, 16 Jun 2021 09:57:29 GMT, Julia Boes wrote:
> In the methods in question, `RejectedExecutionException` is an expected
> exception that was previously unhandled (it is a `RuntimeException`, not a
> subclass of `ExecutionException`). This change adds
> `RejectedExecutionException` to
On Wed, 16 Jun 2021 09:49:17 GMT, Andrey Turbanov
wrote:
>> src/java.base/share/classes/sun/net/www/protocol/https/HttpsClient.java line
>> 154:
>>
>>> 152: while (tokenizer.hasMoreTokens())
>>> 153: v.add(tokenizer.nextToken());
>>> 154: ciphers = new
69 matches
Mail list logo
