On Tue, 29 Mar 2022 20:05:50 GMT, Mandy Chung wrote:
> A small improvement to `RawNativeLibraries`. `RawNativeLibraries::load`
> returns the same `NativeLibrary` instance of a given path if it's called
> multiple times. This means that multiple clients have to coordinate that the
> last one
> Please review this PR which is updating the ASM included in the JDK to ASM
> 9.2. This version should be included in JDK19. There are basically two
> commits here, one that was automatically generated and that mostly changes
> file headers etc and another one, smaller, that make changes to
> This creates a regression test for
> [JDK-8240734](https://bugs.openjdk.java.net/browse/JDK-8240734). This was
> once blocked
> by a time stamp issue which has been resolved by: [JDK-8276766
> ](https://bugs.openjdk.java.net/browse/JDK-8276766)
>
> We found the issue can be produced stably
On Fri, 11 Mar 2022 06:29:22 GMT, Xiaohong Gong wrote:
> The current vector `"NEG"` is implemented with substraction a vector by zero
> in case the architecture does not support the negation instruction. And to
> fit the predicate feature for architectures that support it, the masked
> vector
On Tue, 29 Mar 2022 18:05:56 GMT, Paul Sandoz wrote:
>> Xiaohong Gong has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Make "degenerate_vector_integral_negate" to be "NegVI" private
>
> Java changes are good.
Thanks for the review
On Fri, 25 Mar 2022 11:54:52 GMT, Alan Bateman wrote:
> The existing tests for the jmod tool are in test/jdk/tools/jmod.
> HashesTest.java might provide inspiration to avoid introducing a shell test.
Hi, Alan
I have rewritten this test in Java in the latest commit.
-
PR:
> This creates a regression test for
> [JDK-8240734](https://bugs.openjdk.java.net/browse/JDK-8240734). This was
> once blocked
> by a time stamp issue which has been resolved by: [JDK-8276766
> ](https://bugs.openjdk.java.net/browse/JDK-8276766)
>
> We found the issue can be produced stably
On Mon, 28 Mar 2022 09:56:22 GMT, Xiaohong Gong wrote:
>> The current vector `"NEG"` is implemented with substraction a vector by zero
>> in case the architecture does not support the negation instruction. And to
>> fit the predicate feature for architectures that support it, the masked
>>
redo of 8280400
-
Commit messages:
- 8280400: JDK 19 L10n resource files update - msgdrop 10
Changes: https://git.openjdk.java.net/jdk/pull/8026/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=8026=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8283805
Stats:
On Tue, 29 Mar 2022 16:07:18 GMT, Stuart Marks wrote:
>> Pretty much just what it says.
>
> Stuart Marks has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Adjust nonfinal CSMs and rework error reporting in CheckCSMs.java test
Hello Stuart,
On Tue, 29 Mar 2022 21:41:52 GMT, Naoto Sato wrote:
>> Joe Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> remove variable, check instance instead.
>
> src/java.xml/share/classes/javax/xml/catalog/GroupEntry.java line 44:
>
>> 42:
5 XML tests passed:
> https://mach5.us.oracle.com/mdash/jobs/huizwang-open-20220329-0148-30563542
Joe Wang has updated the pull request incrementally with one additional commit
since the last revision:
remove variable, check instance instead.
-
Changes:
- all: https://git.open
On Thu, 24 Mar 2022 17:43:31 GMT, XenoAmess wrote:
>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - update jmh
> - refine javadoc; refine implement when expectedSize < 0
On Tue, 29 Mar 2022 21:56:18 GMT, Vamsi Parasa wrote:
>> This is both complicated and inefficient, I would suggest building the
>> intrinsic in the IR graph so that the compiler can simplify
>> `Integer.compareUnsigned(x, y) < 0` into `x u< y`. Thanks.
>
>> This is both complicated and
On Tue, 29 Mar 2022 02:24:21 GMT, Jatin Bhateja wrote:
>> Implements x86 intrinsics for compare() method in java.lang.Integer and
>> java.lang.Long.
>
> src/hotspot/cpu/x86/x86_64.ad line 12107:
>
>> 12105: instruct compareSignedI_rReg(rRegI dst, rRegI op1, rRegI op2, rRegI
>> tmp, rFlagsReg
On Sun, 27 Mar 2022 06:57:58 GMT, Quan Anh Mai wrote:
> This is both complicated and inefficient, I would suggest building the
> intrinsic in the IR graph so that the compiler can simplify
> `Integer.compareUnsigned(x, y) < 0` into `x u< y`. Thanks.
Thank you for the suggestion! This
djustment,
> PreferFeatureTest would fail.
>
> Mach5 XML tests passed:
> https://mach5.us.oracle.com/mdash/jobs/huizwang-open-20220329-0148-30563542
src/java.xml/share/classes/javax/xml/catalog/GroupEntry.java line 44:
> 42:
> 43: //Indicates whether this is the Catalog instanc
On Tue, 29 Mar 2022 21:28:44 GMT, Naoto Sato wrote:
>> Proposing to deprecate the constructors in the `java.util.Locale` class.
>> There is already a factory method and a builder to return singletons, so
>> there is no need to have constructors anymore unless one purposefully wants
>> to
djustment,
> PreferFeatureTest would fail.
>
> Mach5 XML tests passed:
> https://mach5.us.oracle.com/mdash/jobs/huizwang-open-20220329-0148-30563542
looks fine Joe
-
Marked as reviewed by lancea (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/8018
> Proposing to deprecate the constructors in the `java.util.Locale` class.
> There is already a factory method and a builder to return singletons, so
> there is no need to have constructors anymore unless one purposefully wants
> to create `ill-formed` Locale objects, which is discouraged. We
On Tue, 29 Mar 2022 18:23:31 GMT, Lance Andersen wrote:
> Hi all,
>
> Please review this trivial fix which addresses a typo in
> src/java.sql/share/classes/java/sql/package-info.java
>
> make docs is clean and I am also running mach5 tier1 as an extra sanity check
> so there are no surprises
A small improvement to `RawNativeLibraries`. `RawNativeLibraries::load`
returns the same `NativeLibrary` instance of a given path if it's called
multiple times. This means that multiple clients have to coordinate that the
last one using the loaded library is the one to close the library by
On Tue, 29 Mar 2022 18:23:31 GMT, Lance Andersen wrote:
> Hi all,
>
> Please review this trivial fix which addresses a typo in
> src/java.sql/share/classes/java/sql/package-info.java
>
> make docs is clean and I am also running mach5 tier1 as an extra sanity check
> so there are no surprises
On Wed, 9 Mar 2022 22:52:41 GMT, Mandy Chung wrote:
> A simple patch to call `Objects.requireNonNull(recv)` for an explicit null
> receiver check rather than NPE thrown by `Object::getClass`. The message of
> NPE generated by JEP 358 (Helpful NullPointerExceptions) is supposed to be
>
> A simple patch to call `Objects.requireNonNull(recv)` for an explicit null
> receiver check rather than NPE thrown by `Object::getClass`. The message of
> NPE generated by JEP 358 (Helpful NullPointerExceptions) is supposed to be
> helpful but not in this case.
Mandy Chung has updated the
On Tue, 29 Mar 2022 10:37:20 GMT, Claes Redestad wrote:
> In `LocalDate::ofEpochDays` we validate the epoch day input, then we also
> validate the year derived from that value. This second validation is
> redundant since the minimum and maximum valid epoch day line up with the
> first and
On Tue, 29 Mar 2022 15:27:28 GMT, Claes Redestad wrote:
>> In `LocalDate::ofEpochDays` we validate the epoch day input, then we also
>> validate the year derived from that value. This second validation is
>> redundant since the minimum and maximum valid epoch day line up with the
>> first and
On Tue, 29 Mar 2022 15:56:37 GMT, Jim Laskey wrote:
>> doesn't the compiler (either javac or hotspot) automatically do that?
>
> Yes, the compilers handle this. I did however switch to
>
>
> primitiveCount != 0 ? new long[(primitiveCount + 1) /
> LONG_SLOTS] : null;
>
> We propose to provide a runtime anonymous carrier class object generator;
> java.lang.runtime.Carrier. This generator class is designed to share
> anonymous classes when shapes are similar. For example, if several clients
> require objects containing two integer fields, then Carrier will
On Tue, 29 Mar 2022 18:23:31 GMT, Lance Andersen wrote:
> Hi all,
>
> Please review this trivial fix which addresses a typo in
> src/java.sql/share/classes/java/sql/package-info.java
>
> make docs is clean and I am also running mach5 tier1 as an extra sanity check
> so there are no surprises
Hi all,
Please review this trivial fix which addresses a typo in
src/java.sql/share/classes/java/sql/package-info.java
make docs is clean and I am also running mach5 tier1 as an extra sanity check
so there are no surprises when the patch is pushed
Best
Lance
-
Commit messages:
> This PR contains the API and implementation changes for JEP-424 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/424
Maurizio Cimadamore has updated the pull
> This PR contains the API and implementation changes for JEP-424 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/424
Maurizio Cimadamore has updated the pull
On Mon, 28 Mar 2022 09:56:22 GMT, Xiaohong Gong wrote:
>> The current vector `"NEG"` is implemented with substraction a vector by zero
>> in case the architecture does not support the negation instruction. And to
>> fit the predicate feature for architectures that support it, the masked
>>
On Wed, 23 Mar 2022 23:22:31 GMT, Mandy Chung wrote:
>> A simple patch to call `Objects.requireNonNull(recv)` for an explicit null
>> receiver check rather than NPE thrown by `Object::getClass`. The message of
>> NPE generated by JEP 358 (Helpful NullPointerExceptions) is supposed to be
>>
On Wed, 23 Mar 2022 16:27:29 GMT, Mandy Chung wrote:
> This patch changes VarHandle and its implementation hierarchy to use sealed
> classes. All VarHandle permitted classes are package-private and either
> final or sealed abstract classes.
>
> Please also review the CSR:
On Tue, 29 Mar 2022 15:27:28 GMT, Claes Redestad wrote:
>> In `LocalDate::ofEpochDays` we validate the epoch day input, then we also
>> validate the year derived from that value. This second validation is
>> redundant since the minimum and maximum valid epoch day line up with the
>> first and
On Tue, 29 Mar 2022 16:07:18 GMT, Stuart Marks wrote:
>> Pretty much just what it says.
>
> Stuart Marks has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Adjust nonfinal CSMs and rework error reporting in CheckCSMs.java test
Looks good.
On Tue, 29 Mar 2022 16:07:18 GMT, Stuart Marks wrote:
>> Pretty much just what it says.
>
> Stuart Marks has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Adjust nonfinal CSMs and rework error reporting in CheckCSMs.java test
Nice update to
On Tue, 29 Mar 2022 09:15:01 GMT, Andrey Turbanov wrote:
> It was no longer used due to JDK-4479184 long ago.
Nice clean-up.
-
Marked as reviewed by iris (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/8013
On Tue, 29 Mar 2022 16:07:18 GMT, Stuart Marks wrote:
>> Pretty much just what it says.
>
> Stuart Marks has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Adjust nonfinal CSMs and rework error reporting in CheckCSMs.java test
Marked as
On Tue, 29 Mar 2022 09:15:01 GMT, Andrey Turbanov wrote:
> It was no longer used due to JDK-4479184 long ago.
Marked as reviewed by mchung (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/8013
.us.oracle.com/mdash/jobs/huizwang-open-20220329-0148-30563542
-
Commit messages:
- 8253569: javax.xml.catalog.Catalog.matchURI() implementation should reset
state variables
Changes: https://git.openjdk.java.net/jdk/pull/8018/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk
On Tue, 29 Mar 2022 16:07:18 GMT, Stuart Marks wrote:
>> Pretty much just what it says.
>
> Stuart Marks has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Adjust nonfinal CSMs and rework error reporting in CheckCSMs.java test
Yes, the
> Pretty much just what it says.
Stuart Marks has updated the pull request incrementally with one additional
commit since the last revision:
Adjust nonfinal CSMs and rework error reporting in CheckCSMs.java test
-
Changes:
- all:
On Tue, 29 Mar 2022 15:49:51 GMT, liach wrote:
>> src/java.base/share/classes/java/lang/runtime/Carrier.java line 335:
>>
>>> 333: CarrierArray(int primitiveCount, int objectCount) {
>>> 334: this.primitives =
>>> 335: primitiveCount != 0 ? new
On Tue, 29 Mar 2022 09:15:01 GMT, Andrey Turbanov wrote:
> It was no longer used due to JDK-4479184 long ago.
It builds so looks fine.
-
Marked as reviewed by bpb (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/8013
On Tue, 29 Mar 2022 13:58:56 GMT, ExE Boss wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add condy static methods
>
> src/java.base/share/classes/java/lang/runtime/Carrier.java line 335:
>
>> 333:
> In `LocalDate::ofEpochDays` we validate the epoch day input, then we also
> validate the year derived from that value. This second validation is
> redundant since the minimum and maximum valid epoch day line up with the
> first and last day of the minimum and maximum valid year, respectively.
On Mon, 28 Mar 2022 22:16:43 GMT, Naoto Sato wrote:
>> Proposing to deprecate the constructors in the `java.util.Locale` class.
>> There is already a factory method and a builder to return singletons, so
>> there is no need to have constructors anymore unless one purposefully wants
>> to
On Tue, 29 Mar 2022 14:07:41 GMT, Claes Redestad wrote:
>> In `LocalDate::ofEpochDays` we validate the epoch day input, then we also
>> validate the year derived from that value. This second validation is
>> redundant since the minimum and maximum valid epoch day line up with the
>> first and
On Tue, 29 Mar 2022 01:07:33 GMT, Stuart Marks wrote:
> Pretty much just what it says.
Close by is `java.io.ObjectStreamField` which seems also useful to make final.
Though it does have a public constructor so is more likely to raise a
compatibility concern.
-
PR:
On Tue, 29 Mar 2022 13:56:09 GMT, Roger Riggs wrote:
>> Claes Redestad has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Sparse out the range of offsets tested
>
> test/jdk/java/time/test/java/time/TestLocalDate.java line 432:
>
>> 430:
> In `LocalDate::ofEpochDays` we validate the epoch day input, then we also
> validate the year derived from that value. This second validation is
> redundant since the minimum and maximum valid epoch day line up with the
> first and last day of the minimum and maximum valid year, respectively.
On Tue, 29 Mar 2022 13:49:37 GMT, Jim Laskey wrote:
>> We propose to provide a runtime anonymous carrier class object generator;
>> java.lang.runtime.Carrier. This generator class is designed to share
>> anonymous classes when shapes are similar. For example, if several clients
>> require
On Tue, 29 Mar 2022 10:37:20 GMT, Claes Redestad wrote:
> In `LocalDate::ofEpochDays` we validate the epoch day input, then we also
> validate the year derived from that value. This second validation is
> redundant since the minimum and maximum valid epoch day line up with the
> first and
On Tue, 29 Mar 2022 12:43:25 GMT, Volker Simonis wrote:
>> Add an API note to `InflaterInputStream::read(byte[] b, int off, int len)`
>> to highlight that it might write more bytes than the returned number of
>> inflated bytes into the buffer `b`.
>>
>> The superclass `java.io.InputStream`
> We propose to provide a runtime anonymous carrier class object generator;
> java.lang.runtime.Carrier. This generator class is designed to share
> anonymous classes when shapes are similar. For example, if several clients
> require objects containing two integer fields, then Carrier will
On Tue, 29 Mar 2022 01:58:05 GMT, Jaikiran Pai wrote:
> Hello Volker, An additional thing that we might have to consider here is
> whether adding this javadoc change to `InflaterInputStream` is ever going to
> "show up" to end user applications. What I mean is, I think in many cases the
> end
On Mon, 28 Mar 2022 18:23:46 GMT, Lance Andersen wrote:
>> I think this require a bit of word smithing. If the return value is 'n' then
>> it should make it clear that the values in elements b[off + n] to b[off +
>> len - 1] are undefined, their values may or may have been changed by the
>>
> Add an API note to `InflaterInputStream::read(byte[] b, int off, int len)` to
> highlight that it might write more bytes than the returned number of
> inflated bytes into the buffer `b`.
>
> The superclass `java.io.InputStream` specifies that `read(byte[] b, int off,
> int len)` will leave
On Mon, 28 Mar 2022 20:32:02 GMT, ExE Boss wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Clean up @return
>
> src/java.base/share/classes/java/lang/runtime/Carrier.java line 330:
>
>> 328: *
On Sat, 20 Nov 2021 10:08:41 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which proposes to fix the issue
> reported in https://bugs.openjdk.java.net/browse/JDK-8003417?
>
> The issue notes that this is applicable for `WeakHashMap` which have `null`
> keys. However,
In `LocalDate::ofEpochDays` we validate the epoch day input, then we also
validate the year derived from that value. This second validation is redundant
since the minimum and maximum valid epoch day line up with the first and last
day of the minimum and maximum valid year, respectively. This
On Sat, 26 Mar 2022 16:35:14 GMT, liach wrote:
>> Сергей Цыпанов has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8282662: Revert dubious changes in MethodType
>
> Just curious, this issue asks to replace set constructions with `Set.of`,
On Mon, 28 Mar 2022 10:35:04 GMT, Claes Redestad wrote:
> - Add capability to ignore fields explicitly when checking for immutability
> of classes in java.time
> - Use this to avoid a test failure due the new `rules` cache in `ZoneOffset`
> - Remove `TestZoneOffset` from problem list.
This
> - Add capability to ignore fields explicitly when checking for immutability
> of classes in java.time
> - Use this to avoid a test failure due the new `rules` cache in `ZoneOffset`
> - Remove `TestZoneOffset` from problem list.
Claes Redestad has updated the pull request incrementally with one
On Mon, 28 Mar 2022 10:35:04 GMT, Claes Redestad wrote:
> - Add capability to ignore fields explicitly when checking for immutability
> of classes in java.time
> - Use this to avoid a test failure due the new `rules` cache in `ZoneOffset`
> - Remove `TestZoneOffset` from problem list.
Thanks
On Tue, 29 Mar 2022 01:07:33 GMT, Stuart Marks wrote:
> Pretty much just what it says.
Yes - it looks like jdk/internal/reflect/CallerSensitive/CheckCSMs.java needs
to be updated.
-
PR: https://git.openjdk.java.net/jdk/pull/8009
On Mon, 28 Mar 2022 11:52:38 GMT, Claes Redestad wrote:
> This address a minor inefficiency in that the `ZoneRules` of any `ZoneOffset`
> (and some `ZoneRegion`s) allocate `lastRulesCache` unnecessarily.
This pull request has now been integrated.
Changeset: 0e788e0e
Author:Claes Redestad
On Mon, 28 Mar 2022 11:52:38 GMT, Claes Redestad wrote:
> This address a minor inefficiency in that the `ZoneRules` of any `ZoneOffset`
> (and some `ZoneRegion`s) allocate `lastRulesCache` unnecessarily.
Thanks for reviews!
-
PR: https://git.openjdk.java.net/jdk/pull/7990
It was no longer used due to JDK-4479184 long ago.
-
Commit messages:
- [PATCH] Remove unused jdk.internal.reflect.SignatureIterator
Changes: https://git.openjdk.java.net/jdk/pull/8013/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=8013=00
Issue:
On Tue, 29 Mar 2022 01:07:33 GMT, Stuart Marks wrote:
> Pretty much just what it says.
The test failures caught by GitHub Actions jobs look related to the area of
this change:
2022-03-29T02:21:21.2187570Zat CheckCSMs.main(CheckCSMs.java:98)
2022-03-29T02:21:21.2188140Zat
On Tue, 29 Mar 2022 01:07:33 GMT, Stuart Marks wrote:
> Pretty much just what it says.
Marked as reviewed by jpai (Committer).
-
PR: https://git.openjdk.java.net/jdk/pull/8009
On Tue, 29 Mar 2022 05:05:43 GMT, Jie Fu wrote:
>> Xiaohong Gong has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Make "degenerate_vector_integral_negate" to be "NegVI" private
>
> Note: I didn't check the aarch64 code change.
Thanks
75 matches
Mail list logo
