> Currently we set _WIN32_WINNT at various places in the codebase; this is used
> to target a minimum Windows version we want to support. See also for more
> detailled information :
>
On Mon, 2 May 2022 23:54:33 GMT, Doug Lea wrote:
>> src/java.base/share/classes/java/util/concurrent/FutureTask.java line 222:
>>
>>> 220: throw new IllegalStateException("Task has not
>>> completed");
>>> 221: }
>>> 222: }
>>
>> I think the code will be more
On Mon, 2 May 2022 17:29:02 GMT, Leonid Mesnik wrote:
>> test/hotspot/jtreg/serviceability/jvmti/events/Breakpoint/breakpoint01/libbreakpoint01.cpp
>> line 139:
>>
>>> 137:thr_info.name,(jni->IsVirtualThread(thread) ==
>>> JNI_TRUE) ? "virtual" : "kernel",
>>> 138:
On Tue, 3 May 2022 13:38:07 GMT, xpbob wrote:
>> set memory.swappiness to 0,swap space will not be used
>> determine the value of memory.swappiness
>> https://www.kernel.org/doc/Documentation/cgroup-v1/memory.txt
>>
>>
>> Memory Limit: 50.00M
>> Memory Soft Limit: Unlimited
>>
On Mon, 2 May 2022 13:33:33 GMT, Doug Lea wrote:
>> This is the jsr166 refresh for jdk19. See
>> https://bugs.openjdk.java.net/browse/JDK-8285450 and
>> https://bugs.openjdk.java.net/browse/JDK-8277090
>
> Doug Lea has updated the pull request incrementally with one additional
> commit since
8262889: Compiler implementation for Record Patterns
A first version of a patch that introduces record patterns into javac as a
preview feature. For the specification, please see:
http://cr.openjdk.java.net/~gbierman/jep427+405/jep427+405-20220426/specs/patterns-switch-record-patterns-jls.html
On Tue, 3 May 2022 07:10:58 GMT, Matthias Baesken wrote:
>> Currently we set _WIN32_WINNT at various places in the codebase; this is
>> used to target a minimum Windows version we want to support. See also for
>> more detailled information :
>>
> set memory.swappiness to 0,swap space will not be used
> determine the value of memory.swappiness
> https://www.kernel.org/doc/Documentation/cgroup-v1/memory.txt
>
>
> Memory Limit: 50.00M
> Memory Soft Limit: Unlimited
> Memory & Swap Limit: 100.00M
> Maximum Processes Limit:
> set memory.swappiness to 0,swap space will not be used
> determine the value of memory.swappiness
> https://www.kernel.org/doc/Documentation/cgroup-v1/memory.txt
>
>
> Memory Limit: 50.00M
> Memory Soft Limit: Unlimited
> Memory & Swap Limit: 100.00M
> Maximum Processes Limit:
On Tue, 3 May 2022 08:23:52 GMT, Alan Bateman wrote:
>> Hi Alan, I agree (thats why I did not change the define in harfbuzz, but I
>> missed that wepoll.c is 3rd party code as well).
>
> I assume you can revert the update to the copyright header in the latest
> version as there aren't any
On Mon, 2 May 2022 13:01:40 GMT, Sibabrata Sahoo wrote:
>> A new API to support replacing selective lines with desired content.
>
> Sibabrata Sahoo has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8285452: Tests updated
LGTM
-
On Tue, 3 May 2022 07:10:58 GMT, Matthias Baesken wrote:
>> Currently we set _WIN32_WINNT at various places in the codebase; this is
>> used to target a minimum Windows version we want to support. See also for
>> more detailled information :
>>
On Tue, 3 May 2022 13:38:07 GMT, xpbob wrote:
>> set memory.swappiness to 0,swap space will not be used
>> determine the value of memory.swappiness
>> https://www.kernel.org/doc/Documentation/cgroup-v1/memory.txt
>>
>>
>> Memory Limit: 50.00M
>> Memory Soft Limit: Unlimited
>>
> set memory.swappiness to 0,swap space will not be used
> determine the value of memory.swappiness
> https://www.kernel.org/doc/Documentation/cgroup-v1/memory.txt
>
>
> Memory Limit: 50.00M
> Memory Soft Limit: Unlimited
> Memory & Swap Limit: 100.00M
> Maximum Processes Limit:
On Tue, 3 May 2022 09:21:11 GMT, xpbob wrote:
>> set memory.swappiness to 0,swap space will not be used
>> determine the value of memory.swappiness
>> https://www.kernel.org/doc/Documentation/cgroup-v1/memory.txt
>>
>>
>> Memory Limit: 50.00M
>> Memory Soft Limit: Unlimited
>>
> set memory.swappiness to 0,swap space will not be used
> determine the value of memory.swappiness
> https://www.kernel.org/doc/Documentation/cgroup-v1/memory.txt
>
>
> Memory Limit: 50.00M
> Memory Soft Limit: Unlimited
> Memory & Swap Limit: 100.00M
> Maximum Processes Limit:
> set memory.swappiness to 0,swap space will not be used
> determine the value of memory.swappiness
> https://www.kernel.org/doc/Documentation/cgroup-v1/memory.txt
>
>
> Memory Limit: 50.00M
> Memory Soft Limit: Unlimited
> Memory & Swap Limit: 100.00M
> Maximum Processes Limit:
> This PR contains the API and implementation changes for JEP-424 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/424
Maurizio Cimadamore has updated the pull
> Currently we set _WIN32_WINNT at various places in the codebase; this is used
> to target a minimum Windows version we want to support. See also for more
> detailled information :
>
On Thu, 28 Apr 2022 07:13:24 GMT, Matthias Baesken wrote:
>> src/java.base/windows/native/libnio/ch/wepoll.c line 159:
>>
>>> 157:
>>> 158: #undef _WIN32_WINNT
>>> 159: #define _WIN32_WINNT 0x0601
>>
>> This is 3rd party code and would prefer not change it if possible.
>
> Hi Alan, I agree
> set memory.swappiness to 0,swap space will not be used
> determine the value of memory.swappiness
> https://www.kernel.org/doc/Documentation/cgroup-v1/memory.txt
>
>
> Memory Limit: 50.00M
> Memory Soft Limit: Unlimited
> Memory & Swap Limit: 100.00M
> Maximum Processes Limit:
> This PR contains the API and implementation changes for JEP-424 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/424
Maurizio Cimadamore has updated the pull
On Fri, 29 Apr 2022 08:15:32 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-424 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] -
> set memory.swappiness to 0,swap space will not be used
> determine the value of memory.swappiness
> https://www.kernel.org/doc/Documentation/cgroup-v1/memory.txt
>
>
> Memory Limit: 50.00M
> Memory Soft Limit: Unlimited
> Memory & Swap Limit: 100.00M
> Maximum Processes Limit:
On Mon, 2 May 2022 13:33:33 GMT, Doug Lea wrote:
>> This is the jsr166 refresh for jdk19. See
>> https://bugs.openjdk.java.net/browse/JDK-8285450 and
>> https://bugs.openjdk.java.net/browse/JDK-8277090
>
> Doug Lea has updated the pull request incrementally with one additional
> commit since
On Mon, 2 May 2022 22:55:43 GMT, Joe Darcy wrote:
> Please review the addition of @-see links from classes that mention the IEEE
> 754 floating-point standard to an IEEE page about the standard. The URL in
> the initial version of the PR is the top search result on the IEEE home page
> for
On Tue, 3 May 2022 08:34:50 GMT, xpbob wrote:
>> set memory.swappiness to 0,swap space will not be used
>> determine the value of memory.swappiness
>> https://www.kernel.org/doc/Documentation/cgroup-v1/memory.txt
>>
>>
>> Memory Limit: 50.00M
>> Memory Soft Limit: Unlimited
>>
> This is a (preliminary) patch for javac implementation for the third preview
> of pattern matching for switch (type patterns in switches).
>
> Draft JLS:
>
> This is the implementation of JEP 425: Virtual Threads (Preview).
>
> We will refresh this PR periodically to pick up changes and fixes from the
> loom repo.
>
> Most of the new mechanisms in the HotSpot VM are disabled by default and
> require running with `--enable-preview` to enable.
>
>
> set memory.swappiness to 0,swap space will not be used
> determine the value of memory.swappiness
> https://www.kernel.org/doc/Documentation/cgroup-v1/memory.txt
>
>
> Memory Limit: 50.00M
> Memory Soft Limit: Unlimited
> Memory & Swap Limit: 100.00M
> Maximum Processes Limit:
On 03.05.2022 10:28, Raffaello Giulietti wrote:
On Mon, 2 May 2022 22:55:43 GMT, Joe Darcy wrote:
Please review the addition of @-see links from classes that mention the IEEE 754
floating-point standard to an IEEE page about the standard. The URL in the initial
version of the PR is the top
On Mon, 2 May 2022 13:33:33 GMT, Doug Lea wrote:
>> This is the jsr166 refresh for jdk19. See
>> https://bugs.openjdk.java.net/browse/JDK-8285450 and
>> https://bugs.openjdk.java.net/browse/JDK-8277090
>
> Doug Lea has updated the pull request incrementally with one additional
> commit since
On Tue, 3 May 2022 15:32:27 GMT, Martin Buchholz wrote:
>> Doug Lea has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address review comments
>
> src/java.base/share/classes/java/util/concurrent/CompletableFuture.java line
> 2153:
>
>>
On Tue, 3 May 2022 20:00:52 GMT, Paul Sandoz wrote:
>> Doug Lea has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address review comments
>
> src/java.base/share/classes/java/util/concurrent/ForkJoinWorkerThread.java
> line 76:
>
>> 74:
> This is the jsr166 refresh for jdk19. See
> https://bugs.openjdk.java.net/browse/JDK-8285450 and
> https://bugs.openjdk.java.net/browse/JDK-8277090
Doug Lea has updated the pull request incrementally with one additional commit
since the last revision:
Fix internal doc typos; thanks to
On Tue, 3 May 2022 20:04:48 GMT, Paul Sandoz wrote:
>> src/java.base/share/classes/java/util/concurrent/CompletableFuture.java line
>> 2153:
>>
>>> 2151:
>>> 2152: @Override
>>> 2153: public Throwable exceptionNow() {
>>
>> The unwrapping of CompletionExceptions should be documented
Hi Alan,
>Is this a Future implementation that doesn't implement the spec
>correctly? The get method shouldn't throw CancellationException if done
>and not-cancelled.
What you say makes sense. I should have checked this before I brought it up
but CancellationException is an
> This is an early review of changes to better model JVM access flags, that is
> "modifiers" like public, protected, etc. but explicitly at a VM level.
>
> Language level modifiers and JVM level access flags are closely related, but
> distinct. There are concepts that overlap in the two domains
On Fri, 29 Apr 2022 20:34:21 GMT, Mandy Chung wrote:
> I took a closer look at the proposed APIs. I think it's in a good state to
> target for 19. I skimmed on the existing JDK usage of `getModifiers` other
> than a trivial test e.g. is public, final, etc and the proposed API works
> well
> Please review the addition of @-see links from classes that mention the IEEE
> 754 floating-point standard to an IEEE page about the standard. The URL in
> the initial version of the PR is the top search result on the IEEE home page
> for "754 standard".
>
> Another candidate page to use is
On Tue, 3 May 2022 08:25:30 GMT, Raffaello Giulietti
wrote:
> What about the DOI URL? Probably even more stable.
> https://doi.org/10.1109/IEEESTD.2019.8766229
Hmm. I'd rather use the IEEE URL for now; if that turns out to problematic, we
can switch to the DOI one.
-
PR:
On 03/05/2022 17:14, Jason Mehrens wrote:
Hi Doug,
In Future::exceptionNow() and Future::state() I would think we would want to
catch CancellationException since the implementation of the Future is not
known. Even though we pre-screen the state I would imagine there could be an
On Mon, 2 May 2022 15:00:07 GMT, Roger Riggs wrote:
>> Ichiroh Takiguchi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8285517: System.getenv() returns unexpected value if environment variable
>> has non ASCII character
>
> Can you
On Mon, 2 May 2022 20:50:11 GMT, Naoto Sato wrote:
>> Ichiroh Takiguchi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8285517: System.getenv() returns unexpected value if environment variable
>> has non ASCII character
>
>
> Java runtime has been detecting the Windows system locale encoding using
> `GetLocaleInfo(GetSystemDefaultLCID(), LOCALE_IDEFAULTANSICODEPAGE, ...)`,
> but it returns the *legacy* ANSI code page value, e.g, 1252 for US-English.
> In order to detect whether the user has selected `UTF-8` as the
Hello,
While informative, I think some kind of official link to the IEEE 754
document is more appropriate in this context.
-Joe
On 5/3/2022 2:59 AM, Rony G. Flatscher wrote:
On 03.05.2022 10:28, Raffaello Giulietti wrote:
On Mon, 2 May 2022 22:55:43 GMT, Joe Darcy wrote:
Please review
On Wed, 27 Apr 2022 20:23:32 GMT, Naoto Sato wrote:
> Java runtime has been detecting the Windows system locale encoding using
> `GetLocaleInfo(GetSystemDefaultLCID(), LOCALE_IDEFAULTANSICODEPAGE, ...)`,
> but it returns the *legacy* ANSI code page value, e.g, 1252 for US-English.
> In order
On Tue, 3 May 2022 17:30:34 GMT, Ichiroh Takiguchi
wrote:
>> test/jdk/java/lang/System/i18nEnvArg.java line 63:
>>
>>> 61: }
>>> 62:
>>> 63: public static class Start {
>>
>> Do we need `Start` class? Can it be merged with the parent to reduce the
>> complexity?
>
> I'm not sure, it
Hi Doug,
In Future::exceptionNow() and Future::state() I would think we would want to
catch CancellationException since the implementation of the Future is not
known. Even though we pre-screen the state I would imagine there could be an
implementation that prefers cancellation over normal
> On JDK19 with Linux ja_JP.eucjp locale,
> System.getenv() returns unexpected value if environment variable has Japanese
> EUC characters.
> It seems this issue happens because of JEP 400.
> Arguments for ProcessBuilder have same kind of issue.
Ichiroh Takiguchi has updated the pull request
On Mon, 2 May 2022 22:55:43 GMT, Joe Darcy wrote:
> Please review the addition of @-see links from classes that mention the IEEE
> 754 floating-point standard to an IEEE page about the standard. The URL in
> the initial version of the PR is the top search result on the IEEE home page
> for
On Mon, 2 May 2022 22:55:43 GMT, Joe Darcy wrote:
> Please review the addition of @-see links from classes that mention the IEEE
> 754 floating-point standard to an IEEE page about the standard. The URL in
> the initial version of the PR is the top search result on the IEEE home page
> for
On Tue, 3 May 2022 16:17:00 GMT, Roger Riggs wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Default to UTF-8 if malloc fails
>
> src/java.base/windows/native/libjava/java_props_md.c line 695:
>
>> 693:
On Sun, 1 May 2022 17:48:39 GMT, Yasser Bazzi wrote:
>> Hi, could i get a review on this implementation proposed by Stuart Marks, i
>> decided to use the
>> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html
>> interface to create the default
Hi,
This patch optimises the matching rules for floating-point comparison with
respects to eq/ne on x86-64
1, When the inputs of a comparison is the same (i.e `isNaN` patterns), `ZF` is
always set, so we don't need `cmpOpUCF2` for the eq/ne cases, which improves
the sequence of `If (CmpF x x)
- No changes to code provided by original fix.
- Added ad hoc signing on macOS aarch64, since macOS aarch64 cannot execute
unsigned code and code should be at least ad hoc signed.
- Signing of app bundle produced by AppContentTest.java fails, since it has
invalid app bundle structure with
On Sun, 1 May 2022 17:48:39 GMT, Yasser Bazzi wrote:
>> Hi, could i get a review on this implementation proposed by Stuart Marks, i
>> decided to use the
>> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html
>> interface to create the default
On Tue, 3 May 2022 18:35:33 GMT, Naoto Sato wrote:
>> I think 3 processes required for this testing.
>> 1. Start test process on ja_JP.eucjp locale
>> 2. Set the test data by encoder
>> 3. Verify the encoded data by decoder
>>
>> To verify the encoded data, I think I need to check the byte
> set memory.swappiness to 0,swap space will not be used
> determine the value of memory.swappiness
> https://www.kernel.org/doc/Documentation/cgroup-v1/memory.txt
>
>
> Memory Limit: 50.00M
> Memory Soft Limit: Unlimited
> Memory & Swap Limit: 100.00M
> Maximum Processes Limit:
On Tue, 3 May 2022 13:38:07 GMT, xpbob wrote:
>> set memory.swappiness to 0,swap space will not be used
>> determine the value of memory.swappiness
>> https://www.kernel.org/doc/Documentation/cgroup-v1/memory.txt
>>
>>
>> Memory Limit: 50.00M
>> Memory Soft Limit: Unlimited
>>
On Sun, 1 May 2022 17:48:39 GMT, Yasser Bazzi wrote:
>> Hi, could i get a review on this implementation proposed by Stuart Marks, i
>> decided to use the
>> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html
>> interface to create the default
61 matches
Mail list logo
