On Tue, 17 May 2022 06:18:25 GMT, Ioi Lam wrote:
>> Severin Gehwolf has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Use stringStream to simplify controller path assembly
>
> src/hotspot/os/linux/cgroupV1Subsystem_linux.cpp line 92:
>
>>
> Hi All,
>
> Patch adds the planned support for new vector operations and APIs targeted
> for [JEP 426: Vector API (Fourth
> Incubator).](https://bugs.openjdk.java.net/browse/JDK-8280173)
>
> Following is the brief summary of changes:-
>
> 1) Extends the scope of existing lanewise API for fo
On Tue, 17 May 2022 05:55:47 GMT, Ioi Lam wrote:
>> Severin Gehwolf has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Use stringStream to simplify controller path assembly
>
> test/hotspot/gtest/runtime/test_os_linux_cgroups.cpp line 63:
>
On Tue, 17 May 2022 07:14:34 GMT, Thomas Stuefe wrote:
>> src/hotspot/os/linux/cgroupV1Subsystem_linux.cpp line 92:
>>
>>> 90: }
>>> 91: ss.print_raw(_root, last_matching_slash_pos);
>>> 92: _path = os::strdup(ss.base());
>>
>> Do you mean `Find the longest common
> On May 17, 2022, at 12:15 AM, Alexander Matveev
> wrote:
>
> Hi Michael,
>
> I filed following enhancement for signing user provided app image and yes it
> will be two step process. Invoke jpackage to generate image, then user can
> modified it and then invoke jpackage again to sign it.
They are unused and leftover since JDK 7. It's good to remove them.
-
Commit messages:
- [PATCH] Remove unused code in sun.reflect.misc.MethodUtil
Changes: https://git.openjdk.java.net/jdk/pull/8715/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=8715&range=00
Issue:
On Mon, 16 May 2022 16:15:49 GMT, Jorn Vernee wrote:
>> Hi,
>>
>> This PR updates the VM implementation of the foreign linker, by bringing
>> over commits from the panama-foreign repo.
>>
>> This is split off from the main JEP integration for 19, since we have
>> limited resources to handle t
On Mon, 16 May 2022 07:21:27 GMT, Ningsheng Jian wrote:
> This is the REDO of JDK-8269559 and JDK-8275448. Those two backouts finally
> turned to be some system zlib issue in AArch64 macOS, and is not related to
> the patch itself. See [1][2] for details.
>
> This patch is generally the same a
On Mon, 16 May 2022 17:40:41 GMT, Jorn Vernee wrote:
>> Hi,
>>
>> This PR brings over commits from the panama-foreign repo. These commits
>> mostly pertain to the switch to ASM and away from MethodHandle combinators
>> for the binding recipe specialization. But, there is one more commit which
On Tue, 17 May 2022 05:54:39 GMT, Rémi Forax wrote:
>> Jorn Vernee has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> BootstrapMethodError -> ExceptionInInitializerError
>
> src/java.base/share/classes/jdk/internal/foreign/abi/BindingSpecia
On Fri, 13 May 2022 13:23:41 GMT, Jorn Vernee wrote:
>> Hi,
>>
>> This PR brings over commits from the panama-foreign repo. These commits
>> mostly pertain to the switch to ASM and away from MethodHandle combinators
>> for the binding recipe specialization. But, there is one more commit which
On Tue, 17 May 2022 08:27:41 GMT, Maurizio Cimadamore
wrote:
>> Jorn Vernee has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Missing ASSERT -> NOT_PRODUCT
>
> src/java.base/share/classes/jdk/internal/foreign/abi/ProgrammableInvoker.java
On Tue, 17 May 2022 08:32:54 GMT, Maurizio Cimadamore
wrote:
>> Jorn Vernee has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> BootstrapMethodError -> ExceptionInInitializerError
>
> src/java.base/share/classes/jdk/internal/foreign/abi/Bin
On Mon, 16 May 2022 12:58:51 GMT, Maurizio Cimadamore
wrote:
>> Jorn Vernee has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use unaligned layout constants when filling in reconstituted structs (was
>> accidentally dropped change)
>
> s
> Hi,
>
> This PR updates the VM implementation of the foreign linker, by bringing over
> commits from the panama-foreign repo.
>
> This is split off from the main JEP integration for 19, since we have limited
> resources to handle this. As such, this PR might fall over to 20, but it
> would b
On Tue, 17 May 2022 06:13:04 GMT, Rémi Forax wrote:
>> Jorn Vernee has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> BootstrapMethodError -> ExceptionInInitializerError
>
> src/java.base/share/classes/jdk/internal/foreign/abi/BindingSpecia
On Tue, 17 May 2022 05:51:58 GMT, Rémi Forax wrote:
>> Jorn Vernee has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> BootstrapMethodError -> ExceptionInInitializerError
>
> src/java.base/share/classes/jdk/internal/foreign/abi/SoftReference
On Fri, 22 Apr 2022 15:08:51 GMT, Magnus Ihse Bursie wrote:
> I ran `codespell` on modules owned by core-libs, and accepted those changes
> where it indeed discovered real typos.
>
> I will update copyright years using a script before pushing (otherwise like
> every second change would be a co
On Tue, 17 May 2022 10:38:39 GMT, Jorn Vernee wrote:
>> Hi,
>>
>> This PR updates the VM implementation of the foreign linker, by bringing
>> over commits from the panama-foreign repo.
>>
>> This is split off from the main JEP integration for 19, since we have
>> limited resources to handle t
On Tue, 17 May 2022 01:43:25 GMT, Kim Barrett wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Revert change for java.c , parse_manifest.c , LinuxPackage.c
>
> src/hotspot/share/classfile/classFileParser.cpp lin
On Tue, 17 May 2022 03:02:55 GMT, Kim Barrett wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Revert change for java.c , parse_manifest.c , LinuxPackage.c
>
> src/hotspot/share/jfr/recorder/checkpoint/types/tra
### Problem description
Minimal jdk image created by jlink with the only jdk.compiler module and its
dependencies
fails to run java source launcher correctly (for example when --source N is
specified).
Failing source launcher is the only one expression of internal jdk.compiler
malfunction, anoth
> ### Problem description
> Minimal jdk image created by jlink with the only jdk.compiler module and its
> dependencies
> fails to run java source launcher correctly (for example when --source N is
> specified).
> Failing source launcher is the only one expression of internal jdk.compiler
> malf
> I saw some compiler warnings when I tried to build OpenJDK with GCC 12.0.1 on
> Fedora 36.
> As you can see, the warnings spreads several areas. Let me know if I should
> separate them by area.
>
> * -Wstringop-overflow
> * src/hotspot/share/oops/array.hpp
> *
> src/hotspot/share/jfr/
On Thu, 31 Mar 2022 08:03:23 GMT, Andrey Turbanov wrote:
>> Method `Class.isAssignableFrom` is often used in form of:
>>
>> if (clazz.isAssignableFrom(obj.getClass())) {
>> Such condition could be simplified to more shorter and performarnt code
>>
>> if (clazz.isInstance(obj)) {
>>
On Tue, 17 May 2022 03:14:05 GMT, Kim Barrett wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Revert change for java.c , parse_manifest.c , LinuxPackage.c
>
> src/hotspot/share/classfile/bytecodeAssembler.cpp l
> I saw some compiler warnings when I tried to build OpenJDK with GCC 12.0.1 on
> Fedora 36.
> As you can see, the warnings spreads several areas. Let me know if I should
> separate them by area.
>
> * -Wstringop-overflow
> * src/hotspot/share/oops/array.hpp
> *
> src/hotspot/share/jfr/
On Tue, 17 May 2022 03:06:49 GMT, Kim Barrett wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Revert change for java.c , parse_manifest.c , LinuxPackage.c
>
> src/hotspot/share/opto/type.cpp line 4300:
>
>> 42
On Tue, 17 May 2022 04:52:44 GMT, Kim Barrett wrote:
>> src/hotspot/share/opto/memnode.cpp line 1413:
>>
>>> 1411:bt == T_BYTE|| bt == T_SHORT ||
>>> 1412:bt == T_INT || bt == T_LONG, "wrong type =
>>> %s", type2name(bt));
>>> 1413: PRAGMA_DIAG_PO
> GCC 12 reports as following:
Yasumasa Suenaga has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull request contains three additional
commits since the last revision:
- U
On Tue, 17 May 2022 04:39:06 GMT, David Holmes wrote:
>> GCC 12 reports as following:
>
> You forced me to look at this in depth. The values are set via the build
> system. In the build system it is impossible to get just -J because the -J is
> only added as a prefix for an existing string. So
This fix ensures that when a lookup for a custom TZ code fails, and an attempt
is made to find the GMT offset in order to get the current time, Daylight
savings rules are applied correctly.
-
Commit messages:
- 8285838: Fix for TZ environment variable DST rules
Changes: https://gi
On Wed, 11 May 2022 18:00:31 GMT, Gaurav Chaudhari
wrote:
> This fix ensures that when a lookup for a custom TZ code fails, and an
> attempt is made to find the GMT offset in order to get the current time,
> Daylight savings rules are applied correctly.
Hi, please send me an e-mail at dalibor
On Wed, 11 May 2022 21:20:52 GMT, Dalibor Topic wrote:
>> This fix ensures that when a lookup for a custom TZ code fails, and an
>> attempt is made to find the GMT offset in order to get the current time,
>> Daylight savings rules are applied correctly.
>
> Hi, please send me an e-mail at dalib
On Tue, 17 May 2022 08:16:32 GMT, Maurizio Cimadamore
wrote:
>> src/java.base/share/classes/jdk/internal/foreign/abi/BindingSpecializer.java
>> line 98:
>>
>>> 96: private static final String CLASS_DATA_DESC =
>>> methodType(Object.class, MethodHandles.Lookup.class, String.class,
>>> Cla
On Tue, 17 May 2022 11:57:01 GMT, Jorn Vernee wrote:
>> src/java.base/share/classes/jdk/internal/foreign/abi/SoftReferenceCache.java
>> line 42:
>>
>>> 40:
>>> 41: private class Node {
>>> 42: private SoftReference ref;
>>
>> this code looks like a double check locking so ref shou
This is a test fix. ThreadAPI.testGetStackTrace3 tests Thread::getStackTrace on
a thread doing a selection operation. The test is not reliable as it expects to
see the "select" method in the stack trace after waiting 200ms. The test is
changed to poll the stack trace so that it's no longer depen
On Tue, 17 May 2022 14:28:11 GMT, Rémi Forax wrote:
>> What about using MethodTypeDesc/ClassDesc as building block?
>
> yes, it should be less expensive, the ClassDesc still need to be constructed
> from Class to allow refactoring.
Can't wait for constant folding :)
I'll pull the `methodType(v
On Mon, 16 May 2022 22:34:21 GMT, Brian Burkhalter wrote:
>> Add constant `java.math.BigDecimal.TWO`.
>
> Brian Burkhalter has refreshed the contents of this pull request, and
> previous commits have been removed. The incremental views will show
> differences compared to the previous content of
On Tue, 17 May 2022 01:19:30 GMT, Ichiroh Takiguchi
wrote:
>> On JDK19 with Linux ja_JP.eucjp locale,
>> System.getenv() returns unexpected value if environment variable has
>> Japanese EUC characters.
>> It seems this issue happens because of JEP 400.
>> Arguments for ProcessBuilder have same
> Hi,
>
> This PR updates the VM implementation of the foreign linker, by bringing over
> commits from the panama-foreign repo.
>
> This is split off from the main JEP integration for 19, since we have limited
> resources to handle this. As such, this PR might fall over to 20, but it
> would b
On Tue, 17 May 2022 11:15:19 GMT, Alan Bateman wrote:
> This is a test fix. ThreadAPI.testGetStackTrace3 tests Thread::getStackTrace
> on a thread doing a selection operation. The test is not reliable as it
> expects to see the "select" method in the stack trace after waiting 200ms.
> The test
On Mon, 16 May 2022 14:48:43 GMT, Raffaello Giulietti
wrote:
> Please review these simple changes in jdk.internal.math.[Double|Float]Consts
This pull request has now been integrated.
Changeset: ea713c37
Author:Raffaello Giulietti
Committer: Joe Darcy
URL:
https://git.openjdk.java.
On Tue, 17 May 2022 11:15:19 GMT, Alan Bateman wrote:
> This is a test fix. ThreadAPI.testGetStackTrace3 tests Thread::getStackTrace
> on a thread doing a selection operation. The test is not reliable as it
> expects to see the "select" method in the stack trace after waiting 200ms.
> The test
On Tue, 17 May 2022 00:39:37 GMT, Joe Wang wrote:
>> Update to Xerces 2.12.2.
>>
>> The update also fixes JDK-8144117. Added a test.
>>
>> Tests: local XML tests passed. Tier2 passed. Two JCK tests failed with this
>> update. See related issue report.
>
> Joe Wang has updated the pull request
On Sun, 15 May 2022 18:36:07 GMT, Joe Darcy wrote:
> Make the javadoc in the InputStream and OutputStream subclasses in core libs
> DRY-er by use of inheritDoc. (Any analagous changes to AudioInputStream in
> client libs will be done another a separate bug.) When the time comes, will
> do any
> Hi,
>
> This PR brings over commits from the panama-foreign repo. These commits
> mostly pertain to the switch to ASM and away from MethodHandle combinators
> for the binding recipe specialization. But, there is one more commit which
> adds freeing of downcall stubs, since those changes were
On Mon, 16 May 2022 18:55:42 GMT, Mandy Chung wrote:
> `Class::forName(String)` javadoc should specify which class loader to use
> when invoked with null caller similar to the other APIs you fixed for null
> callers.
>
> I think this new test case does not belong to `NullCallerGetResource.java
On Tue, 17 May 2022 16:55:14 GMT, Tim Prinzing wrote:
> I like the idea of moving all the null caller tests to a clearly named
> directory to avoid duplication.
+1. You can do this refactoring in a separate JBS issue and then update this
PR when the tests are moved.
-
PR: https
On Tue, 17 May 2022 11:15:19 GMT, Alan Bateman wrote:
> This is a test fix. ThreadAPI.testGetStackTrace3 tests Thread::getStackTrace
> on a thread doing a selection operation. The test is not reliable as it
> expects to see the "select" method in the stack trace after waiting 200ms.
> The test
> Hi All,
>
> Patch adds the planned support for new vector operations and APIs targeted
> for [JEP 426: Vector API (Fourth
> Incubator).](https://bugs.openjdk.java.net/browse/JDK-8280173)
>
> Following is the brief summary of changes:-
>
> 1) Extends the scope of existing lanewise API for fo
On Mon, 16 May 2022 21:29:22 GMT, Brian Burkhalter wrote:
> Add constant `java.math.BigDecimal.TWO`.
This pull request has now been integrated.
Changeset: 1d8e92ae
Author:Brian Burkhalter
URL:
https://git.openjdk.java.net/jdk/commit/1d8e92ae0d2d0d6740e2171abef45545439e6414
Stats:
On Tue, 17 May 2022 00:39:37 GMT, Joe Wang wrote:
>> Update to Xerces 2.12.2.
>>
>> The update also fixes JDK-8144117. Added a test.
>>
>> Tests: local XML tests passed. Tier2 passed. Two JCK tests failed with this
>> update. See related issue report.
>
> Joe Wang has updated the pull request
> The Class::forName behavior change to match JNI FindClass is a compatible
> change and seems pretty attractive as it would be expected that
> Class::forName would give the same behavior as FindClass which uses the
> system classloader. The test for 8281006 was enhanced to test for this
> cha
On Wed, 11 May 2022 18:00:31 GMT, Gaurav Chaudhari
wrote:
> This fix ensures that when a lookup for a custom TZ code fails, and an
> attempt is made to find the GMT offset in order to get the current time,
> Daylight savings rules are applied correctly.
Thanks for contributing the fix. This i
On Thu, 12 May 2022 04:15:50 GMT, Alexander Matveev
wrote:
>> - It is not possible to support native JDK commands such as "java" inside
>> Mac App Store bundles due to embedded info.plist. Workarounds suggested in
>> JDK-8286122 does not seems to be visible.
>> - With proposed fix we will enf
> Supporting `IsoFields` temporal fields in chronologies that are similar to
> ISO chronology. Corresponding CSR has also been drafted.
Naoto Sato has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by
On Mon, 16 May 2022 19:34:11 GMT, Joe Wang wrote:
> Update to Xerces 2.12.2.
>
> The update also fixes JDK-8144117. Added a test.
>
> Tests: local XML tests passed. Tier2 passed. Two JCK tests failed with this
> update. See related issue report.
This pull request has now been integrated.
Cha
> Please review this change to replace the finalizer in
> `AbstractLdapNamingEnumeration` with a Cleaner.
>
> The pieces of state required for cleanup (`LdapCtx homeCtx`, `LdapResult
> res`, and `LdapClient enumClnt`) are moved to a static inner class . From
> there, the change is fairly mechan
On Mon, 2 May 2022 15:00:07 GMT, Roger Riggs wrote:
>> Ichiroh Takiguchi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8285517: System.getenv() returns unexpected value if environment variable
>> has non ASCII character
>
> Can you cl
On Tue, 17 May 2022 08:37:52 GMT, Nick Gasson wrote:
> LGTM!
Thank you, Nick!
-
PR: https://git.openjdk.java.net/jdk/pull/8723
On Mon, 16 May 2022 07:21:27 GMT, Ningsheng Jian wrote:
> This is the REDO of JDK-8269559 and JDK-8275448. Those two backouts finally
> turned to be some system zlib issue in AArch64 macOS, and is not related to
> the patch itself. See [1][2] for details.
>
> This patch is generally the same a
On Sun, 15 May 2022 12:47:10 GMT, Andrey Turbanov wrote:
> They are unused and leftover since JDK 7. It's good to remove them.
Looks good. Do you know why there are test failures (they look unrelated)?
-
Marked as reviewed by mchung (Reviewer).
PR: https://git.openjdk.java.net/
On Tue, 17 May 2022 13:08:32 GMT, Adam Sotona wrote:
>> ### Problem description
>> Minimal jdk image created by jlink with the only jdk.compiler module and its
>> dependencies
>> fails to run java source launcher correctly (for example when --source N is
>> specified).
>> Failing source launche
On Sun, 15 May 2022 12:47:10 GMT, Andrey Turbanov wrote:
> They are unused and leftover since JDK 7. It's good to remove them.
Nice clean up.
-
Marked as reviewed by iris (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/8715
On Tue, 17 May 2022 13:55:43 GMT, Yasumasa Suenaga wrote:
>> GCC 12 reports as following:
>
> Yasumasa Suenaga has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in by the merge/rebase. The pull reque
On Tue, 17 May 2022 13:54:59 GMT, Yasumasa Suenaga wrote:
>> You forced me to look at this in depth. The values are set via the build
>> system. In the build system it is impossible to get just -J because the -J
>> is only added as a prefix for an existing string. So basically this is
>> impos
On Wed, 18 May 2022 02:50:49 GMT, Jaikiran Pai wrote:
> Hello Adam, I don't have necessary knowledge of this area, so I don't know
> what approach would be preferred.
>
> But a couple of questions:
>
> * If we do decide to add the `jdk.zipfs` dependency to `jdk.compiler` module,
> do you thin
> ### Problem description
> Minimal jdk image created by jlink with the only jdk.compiler module and its
> dependencies
> fails to run java source launcher correctly (for example when --source N is
> specified).
> Failing source launcher is only one the expressions of internal jdk.compiler
> mal
On Mon, 16 May 2022 18:27:23 GMT, Joe Wang wrote:
>> Do not enclose the skara command within backquotes.
>
>> Do not enclose the skara command within backquotes.
>
> Thanks Naoto! I didn't realize that's what he did :-)
@JoeWang-Java I have issued the **integrate** command. Now it is ready to
70 matches
Mail list logo
